[koha-commits] main Koha release repository branch master updated. v3.16.00-292-g3e20153
Git repo owner
gitmaster at git.koha-community.org
Mon Jul 28 00:31:20 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3e201530ed8e56a4f49e66067a71ad82ad2a558e (commit)
via 8a02608a4742a72ce21605e3cc5271a93ff0c597 (commit)
from fd90d097becad854ba556d6539c6e25126fe8264 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3e201530ed8e56a4f49e66067a71ad82ad2a558e
Author: Mathieu Saby <mathsabypro at gmail.com>
Date: Mon Jul 14 00:15:04 2014 +0200
Bug 11230: dereference hashes in keys (QA followup)
This followup replaces $params with %$params in keys function
It also fixes some wording
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 8a02608a4742a72ce21605e3cc5271a93ff0c597
Author: Mathieu Saby <mathieu.saby at univ-rennes2.fr>
Date: Sun Nov 10 16:12:31 2013 +0100
Bug 11230 - Refactor C4::Stats::UpdateStats and add UT
This patch
- refactors C4::Stats::UpdateStats (it now takes a hashref as unique parameter, instead of a list of parameters)
- add UT for it
- change the calls made to this sub in C4::Accounts and C4::Circulation
Additionnaly it also
- adds POD to C4::Stats::TotalPaid
- adds some comments to C4::Stats::TotalPaid (I think I found some errors in it)
To test :
1. run "prove t/db_dependant/Stats.t -v"
2. make some circulation operations (checkout, checkin, renew, localuse)
check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november)
3. make some fine payments operations (writeoff, payment)
check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november)
Note that there is probably an issue to fix in Accounts.pm : the user is saved instead of the branch. But this is not the purpose of this patch, so I kept the previous behavior for the moment.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work, test pass, isse/return/writeoff recorded on statistics
Removed a "=back" to make happy koha-qa
No other errors
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Accounts.pm | 44 ++++++++++++----
C4/Circulation.pm | 48 ++++++++++++-----
C4/Stats.pm | 123 ++++++++++++++++++++++++++++++++++----------
t/db_dependent/Stats.t | 133 ++++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 297 insertions(+), 51 deletions(-)
create mode 100644 t/db_dependent/Stats.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list