[koha-commits] main Koha release repository branch master updated. v3.16.00-324-ge31add0
Git repo owner
gitmaster at git.koha-community.org
Wed Jul 30 15:17:46 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e31add0b7b27a257b6ef94fd6598114c55a582cd (commit)
via 8f7e38f3b762ce830224c985a16847474fe23aac (commit)
via 1b887029181eb21e696251f09dd37ee8f902ee50 (commit)
via 33ccf4c9a73e8aa35a6bf7fabbcb863e3d363afa (commit)
via 3ed1d0bf7ed48a207a021e171882b5f30c257f2e (commit)
via fd2e17b289c203115a87c02e09b57650734f02ac (commit)
via 0247b6741e9b70632080cf9bee8231e9bf0d3a4d (commit)
via e9d1965fbd0e9934635a545eef2f4e587446f916 (commit)
via 5f74170e68269360de848314a1e5ce0723ac672f (commit)
via 093ba1d9b7c8e15a8ee536c8f4aacbee10348065 (commit)
from e65121e41599c3f809d07ee82935135aa49fe380 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e31add0b7b27a257b6ef94fd6598114c55a582cd
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sun Jul 20 18:59:59 2014 -0300
Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl
This patch removes all instances on this file.
Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed.
Up to QA or RM for consideration, simply to remove.
But is strange to have a non editable field on auth frameworks.
To test:
1. Apply the patch
2. Go to Administration > MARC frameworks
3. Clic MARC structure of any auth fw
4. Clic subfield on any tag, e.g. 020
5. Clic 'Edit subfields' button
Now the tests proper
6. On any subfield, check pulldown
'Managed in tab', was replaced, so test
if it works and search for regressions
Change, save, load, change again
7. Clic on 'Advanced constraints'
(2) scrolling list removed
At the bottom, check 'Koha link', was changed
Check assign/remove/save/load values, search for regressions
8. Clic on 'Other options' box
Eight(6) scrolling_list removed, they use to
feed three pulldowns, so check each one
'Authorised value',
'Thesaurus'
'Plugin'
Check assign/remove/save/load values, search for regressions
Check adding a new subfield
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, no regressions found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 8f7e38f3b762ce830224c985a16847474fe23aac
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jul 18 09:14:07 2014 -0400
Bug 12487 [QA Followup] - GetContract must return undef with no params
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1b887029181eb21e696251f09dd37ee8f902ee50
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Mon Jun 30 14:42:27 2014 +0200
Bug 12487: SQLHelper replacement - C4::Contract
With this patch, the subroutines GetContract, GetContracts, AddContract, ModContract and DelContract uses DBIx::Class instead of C4::SQLHelper
Test plan:
1) Apply the patch
2) Execute the unit tests by launching:
prove t/db_dependent/Contract.t
3) The command has to be a success :
t/db_dependent/Contract.t .. ok
All tests successful.
Files=1, Tests=43, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.49 cusr 0.05 csys = 1.59 CPU)
Result: PASS
4) Log on with a superlibrarian permission
5) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor")
6) Record a vendor with a nonzero "name"
7) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu)
8) Click on the button "New" > "Contract" and record a new one
9) Verify the displayed data are correct about the contract
10) "Edit" the contract with different values and verify the data are updated
11) Click on "Delete" in order to delete the contract, verify the displayed data are correct but cancel the operation
12) Click on "New" > "Basket" and verify there is the created contract in field "Contract", then record a basket by selectioning the created contract
13) Verify the contract name displayed is correct
14) Record an active budget and a fund linked to this budget
15) Go on the new basket (Home > Acquisitions > Search the created vendor)
16) Click on "Add to basket" then "From a new (empty) record" and verify the displayed contract name is correct, then cancel
17) Click on "Delete this basket"
18) Click on "Contracts" (in the left menu) in order to go on aqcontract.pl, then "Delete" the created contract
19) The contract is not displayed anymore in the vendor page
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described following test plan.
Tested on top of Bug 12493
Tests pass
No koha-qa errors
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 33ccf4c9a73e8aa35a6bf7fabbcb863e3d363afa
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Jul 30 10:42:58 2014 -0300
Bug 12493: (followup) remove unnecessary output message
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3ed1d0bf7ed48a207a021e171882b5f30c257f2e
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Tue Jul 8 09:16:48 2014 +0200
Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm
Fix in order to respect the coding guidelines
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit fd2e17b289c203115a87c02e09b57650734f02ac
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Mon Jun 30 10:02:01 2014 +0200
Bug 12493: unit tests for the module C4::Contract.pm
This patch are the unit tests of the previous patch
Test plan :
Same as the previous patch
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comments on previous patch
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0247b6741e9b70632080cf9bee8231e9bf0d3a4d
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Fri Jun 27 16:00:50 2014 +0200
Bug 12493: moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm
This patch includes:
- the subroutines GetContract and GetContracts has been moved from C4::Acquisition.pm to C4::Contract.pm and adapted for a general use
- adaptation of acqui/basket.pl, acqui/basketheader.pl, acqui/neworderempty.pl, acqui/supplier.pl and admin/aqcontract.pl
- the unit tests for the module C4::Contract.pm
Test plan:
1) Apply the patch
2) Execute the unit tests by launching:
prove t/db_dependent/Contract.t t/Acquisition/ t/db_dependent/Acquisition/ t/db_dependent/Acquisition.t
3) The command has to be a success :
t/db_dependent/Contract.t ................................. ok
t/Acquisition/CanUserManageBasket.t ....................... ok
t/Acquisition/Invoice.t ................................... ok
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok
t/db_dependent/Acquisition/GetOrdersByBiblionumber.t ...... ok
t/db_dependent/Acquisition/Invoices.t ..................... ok
t/db_dependent/Acquisition/OrderFromSubscription.t ........ ok
t/db_dependent/Acquisition/TransferOrder.t ................ 1/11 # Transfering order to basket2
t/db_dependent/Acquisition/TransferOrder.t ................ ok
t/db_dependent/Acquisition/close_reopen_basket.t .......... ok
t/db_dependent/Acquisition.t .............................. ok
All tests successful.
Files=10, Tests=284, 15 wallclock secs ( 0.11 usr 0.02 sys + 12.88 cusr 0.77 csys = 13.78 CPU)
Result: PASS
4) Log on with a superlibrarian permission
5) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor")
6) Record a vendor with a nonzero "name"
7) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu)
8) Click on the button "New" > "Contract" and record a new one
9) Verify the displayed data are correct about the contract
10) "Edit" the contract with different values and verify the data are updated
11) Click on "Delete" in order to delete the contract, verify the displayed data are correct but cancel the operation
12) Click on "New" > "Basket" and verify there is the created contract in field "Contract", then record a basket by selectioning the created contract
13) Verify the contract name displayed is correct
14) Record an active budget and a fund linked to this budget
15) Go on the new basket (Home > Acquisitions > Search the created vendor)
16) Click on "Add to basket" then "From a new (empty) record" and verify the displayed contract name is correct
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested with both patches applied.
Works as described following test plan, all points (I did 14 first)
All test pass
No koha-qa errors
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e9d1965fbd0e9934635a545eef2f4e587446f916
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Mon Jul 21 09:27:17 2014 +0200
Bug 12457: Allow UT on a non empty database
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5f74170e68269360de848314a1e5ce0723ac672f
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Mon Jun 23 16:00:58 2014 +0200
Bug 12457: Adding unit tests for Members.pm
Adding unit tests for the routines AddMessage, GetMessages, GetMessagesCount and DeleteMessage in t/db_dependent/Members.t
Adding unit tests for the routines GetPendingIssues and GetAllIssues in separate files : t/db_dependent/Members/GetPendingIssues.t and t/db_dependent/Members/GetAllIssues.t
The routine GetAllIssues has been modified because it does not test if the arguments was defined :
- the borrowernumber argument is required
- if the order argument is not given, it takes a value by default : 'date_due desc'
- the limit argument is optional
Test plan:
1/ Apply the patch
2/ Execute : prove t/db_dependent/Members.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/GetPendingIssues.t
3/ The result has to be a success without error or warning :
t/db_dependent/Members.t ................... ok
t/db_dependent/Members/GetAllIssues.t ...... ok
t/db_dependent/Members/GetPendingIssues.t .. ok
All tests successful.
Files=3, Tests=83, 5 wallclock secs ( 0.06 usr 0.01 sys + 4.68 cusr 0.26 csys = 5.01 CPU)
Result: PASS
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Amended patch: perltidy on t/db_dependent/Members/*
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 093ba1d9b7c8e15a8ee536c8f4aacbee10348065
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Fri Jun 20 14:31:53 2014 +0200
Bug 12457: Removal warning in t/db_dependent/Members.t
When I execute prove t/db_dependent/Members.t, this warning appears twice :
"Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256."
The warning is due to a invalid use of the routine set_userenv
Test plan:
1/ Execute : prove t/db_dependent/Members.t
2/ The warning appears twice :
"Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256."
3/ Apply the patch
4/ Execute : prove t/db_dependent/Members.t
5/ The result has to be a success without error or warning :
t/db_dependent/Members.t .. ok
All tests successful.
Files=1, Tests=26, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.50 cusr 0.08 csys = 1.63 CPU)
Result: PASS
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All new and old tests pass now.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 79 ++--------
C4/Contract.pm | 99 ++++++++++--
C4/Members.pm | 3 +
acqui/basket.pl | 9 +-
acqui/basketheader.pl | 16 +-
acqui/neworderempty.pl | 5 +-
acqui/supplier.pl | 5 +-
admin/aqcontract.pl | 9 +-
admin/marc_subfields_structure.pl | 157 ++++++--------------
.../en/modules/admin/marc_subfields_structure.tt | 75 +++++++++-
t/db_dependent/Acquisition/TransferOrder.t | 2 +-
t/db_dependent/Contract.t | 144 ++++++++++++++++++
t/db_dependent/Members.t | 54 ++++++-
t/db_dependent/Members/GetAllIssues.t | 96 ++++++++++++
t/db_dependent/Members/GetPendingIssues.t | 111 ++++++++++++++
15 files changed, 651 insertions(+), 213 deletions(-)
create mode 100644 t/db_dependent/Contract.t
create mode 100644 t/db_dependent/Members/GetAllIssues.t
create mode 100644 t/db_dependent/Members/GetPendingIssues.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list