[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.07-20-g0578b09

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  0578b090956f606a5d978f1343b24600f8b1345e (commit)
       via  4cc6eb8e87c89f840dec572af8ca9bd938699e89 (commit)
      from  3e9d0ce14b3a2ab21d43309af57d8df770cafd28 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0578b090956f606a5d978f1343b24600f8b1345e
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Fri Feb 1 17:52:11 2013 +0100

    Bug 9532: fix reservability check when bib-level item types are in use
    
    When itemtype is defined on biblio (item-level_itypes syspref), the
    method C4::Reserves::CanItemBeReserved uses item->{itemtype}. But
    ithe item comes from C4::Items::GetItem and it does not have an
    'itemtype' key; in this method the item type value is always in
    'itype' key.
    
    This patch corrects it.
    
    Test plan:
    
    You should have itemtype on biblio and 'item-level_itypes' syspref
    set to biblio.
    
    This test plan is with ReservesControlBranch on ItemHomeLibrary.
    - Choose a branch, a borrower category and an item type, for example
      'NYC', 'CHILD' and 'DVD'
    - Set an issuing rule for 'NYC', CHILD' and 'DVD' with 'Holds allowed'
      set to 10
    - Set an issuing rule for 'NYC', CHILD' and all item types with
      'Holds allowed' set to 0
    - Choose an item of a biblio with itemtype 'DVD', that can be reserved,
      with 'NYC' as homebranch
    - Choose a borrower with category 'CHILD'
    - Try to request the item for the borrower
    => without the patch, you can
    => with the patch, you can't
    You may check reserve is allowed with 'Holds allowed' > 0 on issuing
    rule for 'DVD'.
    
    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Great test plan - thanks!
    
    Confirmed the bug, and the fix. Looks good to me.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 7acd7f43a703c3aa853ea6e58153584c24ca6d09)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 4cc6eb8e87c89f840dec572af8ca9bd938699e89
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 5 17:16:37 2014 +0000

    Bug 9532: add regression test
    
    To test:
    
    [1] Run prove -v t/db_dependent/Holds.t.  The last test
        should fail.
    [2] Apply the main patch.
    [3] Run step 1 again.  This time the tests should all pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 2afadcc3583c466759f2c4da6970a3cc96a1ba36)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm         |   18 +++++++++---------
 t/db_dependent/Holds.t |   43 +++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 50 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository