[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.07-56-g5903687

Git repo owner gitmaster at git.koha-community.org
Thu Jun 12 09:55:41 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  59036877f2cd8f817fd3689c8feeb91891428185 (commit)
      from  6faf44d042b88aa9cff4774fb8564027b5a78676 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 59036877f2cd8f817fd3689c8feeb91891428185
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Jan 22 15:38:41 2014 -0300

    Bug 9114: Make frameworks import/export routines correctly use UTF-8
    
    Currently both the import_export_framework.pl script outputs data with
    Perl's default encoding, ISO-8859. This patch properly sets
    the binmode to UTF-8 when exporting SQL and CSV files using the PerlIO
    layer (":encoding(UTF-8)") for STDOUT.
    
    To test:
    
    Export step test
    - Use some ASCII character(s) with DIACRITICS in some field description
      in a chosen framework.
    - Export the framework at Administration > MARC frameworks
    - Run this to check the file is ISO-8859 encoded:
     $ file export_XXX.csv
     export_XXX.csv: ISO-8859 text, with very long lines
     (Note: try SQL and other output formats too. But not ODS)
    - Apply the patch
    - Export the framework again (change the name), and test encoding:
     $ file export_XXX_2.csv
     export_XXX_2.csv: UTF-8 Unicode text
    
    Import step test
    I assume you have two files, export_XXX.csv (ISO-8859 encoded) and
    export_XXX_2.csv (XXX will depend on your framework's code)
    - Reset your testing branch to master
    - Import export_XXX.csv
    - The string with non-ASCII chars is truncated at the first non-ASCII
      char's position (Note: this is the current behaviour).
    - Import export_XXX_2.csv
    - The non-ASCII chars are broken, the logs show errors on non-UNICODE
      chars.  (Note: even thou UTF-8 is the expected encoding it is
      treated as ISO-8859).
    - Apply the patch
    - Import the good (UTF-8 as expected) file and check everything worked
      as expected.
    
    No double encoding should occur with either combination of formats.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Magnus Enger <digitalutvikling at gmail.com>
    I put some Norwegian and accented letters in a fremawork to test.
    Before the patch, the exported CSV came out as ISO-8859, after the
    patch it came out as UTF-8. ODS and XML (viewed in LibreOffice)
    both looked good, before and after the patch.
    
    Importing the ISO-8859 CSV cut off the strings at the first non-ASCII
    char. Importing the UTF-8 CSV worked as epected.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as expected, passes tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 40d3800cc4d73be3f40fb3b895de3e7fe29e4999)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 admin/import_export_framework.pl |    4 ++++
 1 file changed, 4 insertions(+)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list