[koha-commits] main Koha release repository branch master updated. v3.16.00-94-g7e69422

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  7e694228c29a2a20829d927bbcaeba2d1f4369fb (commit)
       via  7ca5bb388c3e1d0cd8fc57914421db402a5414ab (commit)
       via  661f9e01d64909692c98686a3117db1927f6bd20 (commit)
       via  6dd79171a5eced348dc1cffd231c7d368eb66508 (commit)
      from  3e8607e0759261f5c41eeaa13e3a1b5217f1ad66 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7e694228c29a2a20829d927bbcaeba2d1f4369fb
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Jun 11 13:36:28 2014 +0200

    Bug 12343: QA follow-up
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

commit 7ca5bb388c3e1d0cd8fc57914421db402a5414ab
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Jun 11 13:31:55 2014 +0200

    Bug 12343: Add regression test for TransformKohaToMarc
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

commit 661f9e01d64909692c98686a3117db1927f6bd20
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Tue Jun 3 09:24:23 2014 +0200

    Bug 12343 - TransformKohaToMarc() is adding MARC subfields in random order
    
    TransformKohaToMarc() function in C4/Biblio.pm iterates through it's
    argument - which is a hashref - using 'each'. Perl is not guaranteed
    to return hash keys in any particular order (not to mention that
    in more recent perl versions, explicit hash key order randomization
    is to be expected).
    
    As a consequence:
    1) For biblio records added via acquisition (order from a new/empty
    record, order from a suggestion), freshly created MARC biblio records
    doesn't always have 260 $b and 260 $c stored in the proper order
    2) Holdings data exported for zebra indexing as 952 fields may have
    subfields generated in more-or-less random order. While it probably (?)
    does not affect zebra indexing/searching in any significant way,
    end result is prone to be somehow ugly (which can be a potential
    issue e.g. for people running Z39.50 server) and is not guaranteed
    to be consistent; different records - or even different items in the
    same record, can have 952 subfields generated in indiscriminate order.
    
    This patch fixes abovementioned issues via introducting explicit
    sorting (by subfiled code/letter) for subfield pairs before they
    are added to the MARC record.
    
    To test:
    1/ Try to confirm and reproduce both issues (use perl 5.18.1 if possible
    for more randomly ordered results).
    2/ Apply patch.
    3/ Redo the tests; ensure that both issues are now fixed and that there
    are no apparent regressions of any kind (especially regarding to 952 fields
    generated for zebra [re]indexing).
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

commit 6dd79171a5eced348dc1cffd231c7d368eb66508
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Sun Jun 15 11:24:59 2014 -0300

    Bug 11169: DBRev 3.17.00.008
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                           |   21 +++++++++++++--------
 installer/data/mysql/updatedatabase.pl |    2 +-
 kohaversion.pl                         |    2 +-
 t/Biblio/TransformKohaToMarc.t         |   31 +++++++++++++++++++++++++++++++
 4 files changed, 46 insertions(+), 10 deletions(-)
 create mode 100644 t/Biblio/TransformKohaToMarc.t


hooks/post-receive
-- 
main Koha release repository