[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.00-38-g7ef0472
Git repo owner
gitmaster at git.koha-community.org
Wed Jun 18 22:44:48 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.16.x has been updated
via 7ef04729902ba7e1fb5e64367b1d473de41b7726 (commit)
via 07dfccd318c0b97e25c886b2e7f448a2e5110d29 (commit)
via a09b6c9fa426e20703bd16ba5f1291916f2dc26c (commit)
via 1f95fdf16776ed95d17cb864fe51a609a1b93989 (commit)
via 50083b239b7e90989d9cb7a20e5b496724843466 (commit)
via fe8fa36cd70b9eb9163ddfdb54c1a578ef1d865c (commit)
via f7f2db2f9cbcdf645883fe1ac081ee79f97decfb (commit)
via 293776bdd26fdf497fa6e5c712109463a1c46430 (commit)
via c308506e1fbe9106d4e53b4a78f506f94bd953af (commit)
via bea454de6251b6a61899efbdd07146300afe309f (commit)
from 644937f411b309e48ce7174a787633ad0f337463 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7ef04729902ba7e1fb5e64367b1d473de41b7726
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Feb 20 10:06:36 2014 -0500
Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl
If an item needs to be transferred to fill a hold, the hold will be
listed as 'Waiting to be pulled" while it is in transit.
Test Plan:
1) Place a hold for pickup at another library
2) Check in the item, confirm the hold transfer
3) View the holds for that record ( request.pl )
4) Note the priority is "In transit" and the status is 'Waiting to be
pulled".
5) Apply this patch
6) Reload the holds page
7) Note the status is now "Item being transferred to $branch"
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 07dfccd318c0b97e25c886b2e7f448a2e5110d29
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Wed Jun 11 16:26:18 2014 +0200
Bug 12406: adding the column maxsuspensiondays in the tests
The column maxsuspensiondays was added in the datatable but not in the tests, which caused the failure of the tests
test plan: execute prove t/db_dependent/Circulation_Issuingrule.t
The command has to print:
t/db_dependent/Circulation_Issuingrule.t .. ok
All tests successful.
Files=1, Tests=9, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.35 cusr 0.08 csys = 1.47 CPU)
Result: PASS
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Failure on test before patch, success after
No koha-qa errors
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit a09b6c9fa426e20703bd16ba5f1291916f2dc26c
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Wed Jun 18 14:05:48 2014 +1200
Bug 12439 - check that CGI is enabled when doing koha-create
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Works as expected.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 1f95fdf16776ed95d17cb864fe51a609a1b93989
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jun 9 08:58:30 2014 -0400
Bug 12380 - can't tab to save buttons on add item
Many form elements on the add item page are giving a tabindex of "1" by
the script. This seems to make it impossible to tab through the add item
form fields onto the save buttons. I don't see a reason to set an
explicit tabindex of "1," so this patch removes it.
To test, apply the patch and open an item for editing. Try tabbing
through the add item form fields. It should be possible to tab through
the fields and onto the submit buttons at the bottom. Test again when
adding a new item.
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 50083b239b7e90989d9cb7a20e5b496724843466
Author: Nicole C. Engard <nengard at bywatersolutions.com>
Date: Sat May 31 12:32:24 2014 -0500
Bug 11958: Fix typo in classification source help
The Classification Sources help file said the source was in the 942$2 but it's in the 952$2 and 94$2 so this patch fixes that.
To test:
* Go to Admin > Classification Sources
* Click Help
* Confirm the Help file is right now
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
String change, no errors.
Note: Perhaps change "Authorized Values ..." for "Authorized values ..."
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit fe8fa36cd70b9eb9163ddfdb54c1a578ef1d865c
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri May 30 16:13:36 2014 -0300
Bug 12338: Remove smartmatch operator from C4/Serials.pm
This patch removes the use of the 'when' smartmatch operator from
Serials.pm
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit f7f2db2f9cbcdf645883fe1ac081ee79f97decfb
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Jun 11 13:36:28 2014 +0200
Bug 12343: QA follow-up
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 293776bdd26fdf497fa6e5c712109463a1c46430
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Jun 11 13:31:55 2014 +0200
Bug 12343: Add regression test for TransformKohaToMarc
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit c308506e1fbe9106d4e53b4a78f506f94bd953af
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date: Tue Jun 3 09:24:23 2014 +0200
Bug 12343 - TransformKohaToMarc() is adding MARC subfields in random order
TransformKohaToMarc() function in C4/Biblio.pm iterates through it's
argument - which is a hashref - using 'each'. Perl is not guaranteed
to return hash keys in any particular order (not to mention that
in more recent perl versions, explicit hash key order randomization
is to be expected).
As a consequence:
1) For biblio records added via acquisition (order from a new/empty
record, order from a suggestion), freshly created MARC biblio records
doesn't always have 260 $b and 260 $c stored in the proper order
2) Holdings data exported for zebra indexing as 952 fields may have
subfields generated in more-or-less random order. While it probably (?)
does not affect zebra indexing/searching in any significant way,
end result is prone to be somehow ugly (which can be a potential
issue e.g. for people running Z39.50 server) and is not guaranteed
to be consistent; different records - or even different items in the
same record, can have 952 subfields generated in indiscriminate order.
This patch fixes abovementioned issues via introducting explicit
sorting (by subfiled code/letter) for subfield pairs before they
are added to the MARC record.
To test:
1/ Try to confirm and reproduce both issues (use perl 5.18.1 if possible
for more randomly ordered results).
2/ Apply patch.
3/ Redo the tests; ensure that both issues are now fixed and that there
are no apparent regressions of any kind (especially regarding to 952 fields
generated for zebra [re]indexing).
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit bea454de6251b6a61899efbdd07146300afe309f
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Tue Jun 10 09:48:14 2014 +0300
Bug 12396 - MTT FIX: Due notices (DUEDGST) are multiplicated and all of them are sent to everybody who is about to receive ODUEDGST.
So the first patron receives correct letters, but the followings received
all the previous ones AND his letters.
Eventually you end up with !n letters in message_queue where n = amount of patrons
receiving due messages as digest and having something due.
Eventually we got 4 000 000 ODUEDGST-letters of which 1 100 000 were sent to our patrons :)
This is madness!
Test plan:
0/ Delete the content of the message_queue table.
1/ Pick 3 patrons and set them to receive due messages as digest.
2/ Check 1 item out for 3 separate patrons and specify a due date today.
3/ Launch the advance_notices.pl script.
4/ Before this patch, you got 6 notices (1+2+3 [!n]). Now, you get 3 notices, 1 for each patron.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Problem exis.
Patch work as described following test plan.
No koha-qa errors
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 21 +++++---
C4/Serials.pm | 54 +++++++++-----------
cataloguing/additem.pl | 5 +-
debian/scripts/koha-create | 13 +++++
.../prog/en/modules/help/admin/classsources.tt | 2 +-
misc/cronjobs/advance_notices.pl | 4 +-
reserve/request.pl | 7 ++-
t/Biblio/TransformKohaToMarc.t | 31 +++++++++++
t/db_dependent/Circulation_Issuingrule.t | 23 ++++++---
9 files changed, 108 insertions(+), 52 deletions(-)
create mode 100644 t/Biblio/TransformKohaToMarc.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list