[koha-commits] main Koha release repository branch master updated. v3.16.00-105-gb264e39

Git repo owner gitmaster at git.koha-community.org
Thu Jun 19 16:30:38 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b264e398401723e05e1f5dff62c426254e7066ec (commit)
       via  967f5cb51321a6a08176c7718a6ab933b3b5f926 (commit)
       via  a10f6858e1a1f7096af19845362ded66a4343b33 (commit)
       via  610b41434704583a51959e52937e4a7170a18258 (commit)
      from  76596ff6dc09b6443f23b0d3cdb01ff3aa4ac5d5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b264e398401723e05e1f5dff62c426254e7066ec
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue May 27 17:57:33 2014 +0000

    Bug 11891: (follow-up) set DBIC storage flags correctly
    
    Since we're passing an existing DBI database handle to
    DBIC, and that handle doesn't have RaiseError set to true
    by default, don't let DBIC override that -- for now.
    
    Test plan: verify that the DB-dependent test suite passes.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 967f5cb51321a6a08176c7718a6ab933b3b5f926
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Jun 18 22:25:22 2014 +0000

    Bug 11891: (follow-up) remove custom storage class
    
    For now, just rely on the normal DBIx::Class cleanup handler;
    otherwise, the following warning is displayed in logs:
    
      (in cleanup) Can't locate object method "_preserve_foreign_dbh" via package "Koha::Storage" at .../Koha/Storage.pm
    
    Using the default DBIC storage class also means that we
    don't have to manually do things like set the SQL limit dialect;
    meaning that we don't get the following warning message:
    
      DBIx::Class::ResultSet::find(): Your storage class (Koha::Storage) does
      not set sql_limit_dialect and you have not supplied an explicit
      limit_dialect in your connection_info. DBIC will attempt to use the
      GenericSubQ dialect, which works on most databases but can be (and
      often is) painfully slow. Please file an RT ticket against
      'Koha::Storage' . at /home/gmc/koha/C4/Members.pm line 840
    
    Test plan: same as main patch
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a10f6858e1a1f7096af19845362ded66a4343b33
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Mar 4 13:26:03 2014 -0500

    Bug 11891 - Make Koha::Schema use C4::Context->dbh
    
    Right now there is no connection between the database handles used by
    C4::Context::dbh and Koha::Datbase/Schema. This makes it impossible to
    use transactions in unit tests to temporarily modify the database to
    test subroutines that take advantage of Koha::Database. This patch fixes
    that issue.
    
    Test Plan:
    1) Apply this patch
    2) prove -v t/db_dependent/ILSDI_Services.t and
       prove -v t/db_dependent/Items.t and
       prove -v t/db_dependent/Circulation_issue.t should
       all start passing
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 610b41434704583a51959e52937e4a7170a18258
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 26 18:39:11 2014 +0000

    Bug 11891: set up tests to require that Koha::Database uses same DB handle as C4::Context
    
    This patch removes changes in two cases to work around the fact that
    Koha::Database and C4::Context were not using the same DBI database
    handle.
    
    To test:
    
    [1] Run prove -v t/db_dependent/ILSDI_Services.t and
        prove -v t/db_dependent/Items.t.  Both tests
        should fail.
    [2] Apply the main patches and run step 1 again.  This
        time, both tests should pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Database.pm                |   19 +++++--------------
 t/db_dependent/ILSDI_Services.t |    6 +++---
 t/db_dependent/Items.t          |    4 ++--
 3 files changed, 10 insertions(+), 19 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list