[koha-commits] main Koha release repository branch master updated. v3.16.00-134-gc81f58a

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c81f58a1c821905fb89016487325264390065cdd (commit)
       via  1ac6af8fe21c6838f1a0b5e3e8bf3efd0ee16156 (commit)
       via  5c4fdcf78aab2d284f3b88f9926756acb6a4d48f (commit)
       via  1976ec2020a0a17a7b73ac3acac491532ef3e66d (commit)
       via  6d75fa8d2137b51bb0de2bc0039b0e86f5a89705 (commit)
      from  1692ab4cdf620012bd02b2c21094e02218f50c0c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c81f58a1c821905fb89016487325264390065cdd
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Jun 23 15:22:37 2014 -0300

    Bug 11742: (QA followup) wrong number of tests
    
    The number of tests was wrong.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 1ac6af8fe21c6838f1a0b5e3e8bf3efd0ee16156
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jun 9 12:21:31 2014 +0200

    Bug 11742: FIX the code parameter was not take into account
    
    In C4::Letters::GetLetters, the code filter was not used as a query
    parameter.
    
    Moreover, the JS code was buggy. We only need to check the letter code,
    except if it is an edit and the letter code has not been changed.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

commit 5c4fdcf78aab2d284f3b88f9926756acb6a4d48f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed May 7 16:12:39 2014 +0200

    Bug 11742: A letter code should be unique.
    
    This patch is a dirty way to fix a design issue on notices.
    Currently the code assumes that a letter code is unique. Which is wrong,
    the primary key is module, code, branchcode.
    
    Maybe we should add a primary key (id) for the letter table in order to
    pass the id to the template and correctly manage the letter code
    duplication.
    
    Test plan:
    Try to duplicate a letter code using edit, add and copy actions.
    If you manage to do it, please describe how you did.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

commit 1976ec2020a0a17a7b73ac3acac491532ef3e66d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed May 7 15:55:54 2014 +0200

    Bug 11742: Change return type for GetLetters
    
    The GetLetters subroutine should return an arrayref with different
    letters for a module.
    
    Test plan:
    0/ Delete your notices with module=claimacquisition, claimissues,
    serial
    1/ Go on the late orders page (acqui/lateorders.pl) and verify you
    cannot choose a notice for claiming
    2/ Create a notice with module=claimacquisition
    3/ Go on the late orders page (acqui/lateorders.pl) and verify you
    can choose the notice for claiming
    4/ Go on the Claim serials page (serials/claims.pl) and repeat the same
    thing with the a "claimissues" notice
    5/ Create a new subscription (serials/subscription-add.pl) and verify
    you cannot choose a notification for patrons.
    6/ Create a notice with module "serial" and verify you can.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script. Additional tests done:
    
    - copy notice ODUE, on saving you are now prompted to choose
      a new CODE for the notice
    - edit new notice, try to set code back to ODUE. You are
      prompted that the code is already in use.
    
    This will prevent people from accidentally overwriting a letter
    with the same letter code.

commit 6d75fa8d2137b51bb0de2bc0039b0e86f5a89705
Author: Robin Sheat <robin at catalyst.net.nz>
Date:   Tue Jun 3 14:23:43 2014 +1200

    Bug 12350 - disable apache indexes
    
    Test plan:
    * Go to http://library/opac-tmpl and check you get a 403 error instead
      of a directory listing.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm                                      |   65 ++++---------
 acqui/lateorders.pl                                |    8 +-
 debian/templates/apache-shared.conf                |    2 +-
 .../prog/en/modules/serials/claims.tt              |    6 +-
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |   97 ++++++++++++++------
 .../prog/en/modules/tools/overduerules.tt          |   12 +--
 serials/claims.pl                                  |   12 +--
 serials/subscription-add.pl                        |   38 ++++----
 svc/letters                                        |   63 +++++++++++++
 t/Letters.t                                        |   25 ++++-
 tools/letter.pl                                    |   62 +++++--------
 tools/overduerules.pl                              |   46 ++--------
 12 files changed, 236 insertions(+), 200 deletions(-)
 create mode 100755 svc/letters


hooks/post-receive
-- 
main Koha release repository