[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.00-62-g5ffcefd
Git repo owner
gitmaster at git.koha-community.org
Thu Jun 26 00:16:21 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.16.x has been updated
via 5ffcefd6e324e2cdb591cf31b507eb66d93afd53 (commit)
via d6d515f6e9713615ea6263c1ab5c4e4b18e5452c (commit)
via dd97948cb522f1a8c5d3ef86182a0bf5135559a3 (commit)
via 62e137743dba5161dadc5fd8baa0481942ae5a8a (commit)
via 761363992779917d29e2cc416e38e72280fad0b0 (commit)
via 16061bf0d36b15c1102f8635ecc599ee8cbf6019 (commit)
via 81fc43b13e9a90ec625021fb7e72515631021d1c (commit)
via 217ef61b6662181ebdcf6caaf34d9f9c898ffd4c (commit)
via db5481bc4b4b21b8d72abdcfcf3534e63537caa9 (commit)
via 808c0c2cd1262b5a3018dffa44ba42dbbcd3780c (commit)
via b8f487fff3278a441f49c5a302af5e1994a70c44 (commit)
via 8e1b6f76d60efd4b7806788ec44c73348dcbdd51 (commit)
via de89021646c4eda33703af9516541bd69758573e (commit)
via c9ad34f46676fe2b4808b0c9a83bd6b1845960ef (commit)
via ccb130058c395fd0bc46f7d05a6d8b82cce102d2 (commit)
via ef227c3a4021577a0de07677adda06177ffd8cbb (commit)
via e037fe1aa60534eb3887362e013ae83bd3ab08b0 (commit)
from e560bdcdeb0cc2a3cf520215189818e80a0b4896 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5ffcefd6e324e2cdb591cf31b507eb66d93afd53
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri May 2 12:06:30 2014 +0200
Bug 11715: Update POD for get_template_and_user
If flagsrequired is set, authnotrequired should be 0.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit d6d515f6e9713615ea6263c1ab5c4e4b18e5452c
Author: Galen Charlton <gmc at esilibrary.com>
Date: Tue Apr 29 17:04:02 2014 +0000
Bug 11715: require authentication for various staff scripts
To test:
[1] Verify that item record creating and editing during the
acquisitions process continues to work.
[2] Verify that calling services/itemrecorddisplay.pl without
a valid user session fails.
[3] Verify that authentication is required for making a new
order from a suggestion, transferring an order, doing a
Z39.50 search from acquisitions, displaying the record
card view in the staff interface, and running the till
reconciliation report (/cgi-bin/koha/reports/stats.screen.pl)
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Verified all changed scripts are not accessible witout a valid
user session, but are with one.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit dd97948cb522f1a8c5d3ef86182a0bf5135559a3
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Mon Mar 17 09:15:05 2014 +1300
Bug 11715 : require authentication for the cataloging authorities Z39.50 search
To test:
1/ go to /cgi-bin/koha/cataloguing/z3950_auth_search.pl when you are not
logged in, notice no log in is enforced
2/ Apply patch
3/ go to /cgi-bin/koha/cataloguing/z3950_auth_search.pl notice you now
need to login
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 62e137743dba5161dadc5fd8baa0481942ae5a8a
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Tue Mar 11 10:56:53 2014 +1300
Bug 11715: require authentication for the cataloging Z39.50 search
To test:
1/ go to /cgi-bin/koha/cataloguing/z3950_search.pl when you are not
logged in, notice no log in is enforced
2/ Apply patch
3/ go to /cgi-bin/koha/cataloguing/z3950_search.pl notice you now need
to login
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 761363992779917d29e2cc416e38e72280fad0b0
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Tue Mar 11 10:51:00 2014 +1300
Bug 11715: Set the default of authnotrequired = 0 in get_template_and_user
To test:
Verify that pages in the OPAC and staff interface display correctly.
Note that there are cases where 'authnotrequired' was not passed
at all to get_template_and_user, so there may be pages that start
requiring authentication. Whether that is correct or not depends
on context.
Follow up patches are to remove all the unnessecary setting of this
value, so that the only places we set are when we do want
authnotrequired=1
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 16061bf0d36b15c1102f8635ecc599ee8cbf6019
Author: David Cook <dcook at prosentient.com.au>
Date: Fri Jun 6 14:01:17 2014 +1000
Bug 9093 - 008 forgetting what material type was chosen
This patch adds material type checking to the MARC21 008 tag editor,
based on value from the leader. That is, the 008 tag editor
will choose an initial material type based on the leader 06
(and if necessary the leader 07 position)
_TEST PLAN_
1) Create a new record or open an existing bib record
2) Change position 6 from its current value (probably "a") to
"c" or "e" or "g" or "m" or "p". (See the end of this message
for a comprehensive list of 06 values to try.)
3) Open the 008 tag editor
4) Note that it still says BKS even though it should say "MU"
or "MP" or "VM" or "CF" or "MX".
5) Apply the patch
6) Repeat steps 2 and 3.
7) Note that the 008 tag editor now shows the correct material
type based on the leader.
8) For more comprehensive checking, try switching position 6
back to "a" and changing position 7 to "b" instead of "m".
9) Note that it will switch from "BKS" to "CR".
10) Fin
Comprehensive mapping:
Field 008/18-34 Configuration
If Leader/06 = a and Leader/07 = a, c, d, or m: Books
If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources
If Leader/06 = t: Books
If Leader/06 = c, d, i, or j: Music
If Leader/06 = e, or f: Maps
If Leader/06 = g, k, o, or r: Visual Materials
If Leader/06 = m: Computer Files
If Leader/06 = p: Mixed Materials
http://www.loc.gov/marc/bibliographic/bdleader.html
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, nice job.
koha-qa complains for a tab char, removed on followup.
Mode change on TT file (+x), removed.
No other errors
NOTE: It would be desirable to update LEADER values
to reflect changes on 008.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Awesome work David.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 81fc43b13e9a90ec625021fb7e72515631021d1c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Jun 19 13:50:31 2014 +0200
Bug 12427: Allow execution of UTs on a DB with issues
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 217ef61b6662181ebdcf6caaf34d9f9c898ffd4c
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Tue Jun 17 16:53:14 2014 +0200
Bug 12427: adding unit tests of module C4::Members::Attributes.pm
The subroutines UpdateBorrowerAttribute, SearchIdMatchingAttribute, DeleteBorrowerAttribute, GetBorrowerAttributes, GetAttributes, GetBorrowerAttributeValue, SetBorrowerAttributes and CheckUniqueness of the module C4::Members::Attributes.pm were not tested.
Test plan:
1/ Execute the command: prove t/db_dependent/Members_Attributes.t
2/ The result has to be:
t/db_dependent/Members_Attributes.t .. ok
All tests successful.
Files=1, Tests=60, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.45 cusr 0.08 csys = 1.58 CPU)
Result: PASS
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test with patrons on db having issues and attributes
New test file, all test pass
No koha-qa errors
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit db5481bc4b4b21b8d72abdcfcf3534e63537caa9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jun 16 07:30:03 2014 -0400
Bug 11292 [QA Followup] - Use noEnterSubmit instead of new keypress handler
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 808c0c2cd1262b5a3018dffa44ba42dbbcd3780c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu May 22 08:35:16 2014 -0400
Bug 11292 - barcode scanner clicking 'save'
When cataloging a bib record if you scan an ISBN barcode in the barcode
scanner clicks the 'save' button before the cataloging is done. This did
not happen in 3.10, but is happening again in 3.12.
Test Plan:
1) Open the marc editor
2) Focus on a field, hit the enter key
3) Note the record tries to save
4) Focus on an indicator, hit the enter key
5) Note the record tries to save
6) Apply this patch
7) Repeat steps 2 and 4, note the record no longer
tries to save upon carriage return
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Patch tested with a sandbox.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit b8f487fff3278a441f49c5a302af5e1994a70c44
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Tue Jun 3 14:23:43 2014 +1200
Bug 12350 - disable apache indexes
Test plan:
* Go to http://library/opac-tmpl and check you get a 403 error instead
of a directory listing.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 8e1b6f76d60efd4b7806788ec44c73348dcbdd51
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jun 23 11:43:48 2014 +0200
Bug 12086: qa-followup: remove warning on launching unit tests
Without this patch, the following warning appears:
t/db_dependent/Holds/RevertWaitingStatus.t .. Subroutine
C4::Context::userenv redefined at
t/db_dependent/Holds/RevertWaitingStatus.t line 25.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit de89021646c4eda33703af9516541bd69758573e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Apr 17 12:10:21 2014 -0400
Bug 12086 - Hold priorities incorrect, when waiting status was reversed
1) Test record has 1 single item, checked out to patron X
2) Place 3 holds for patrons A, B and C, all title level hold this time
A, B, C, item branches and staff branch are the same.
3) Return item, confirm hold
4) Confirm item is now waiting for patron A
Priorities are: A = Waiting, B = 1, C = 2
5) Open patron account of user B, checkout book
Koha asks: Item X has been waiting for patron A... Revert
waiting status
Confirm.
6) Check priorities:
Hold list shows: A = 1, C = 1
Database says: A = 1, C = 3
7) Apply this patch
8) Repeat steps 1-6
9) Note the priorities are correct
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Test plan correctly predicts the error and the correction made by the
patch.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit c9ad34f46676fe2b4808b0c9a83bd6b1845960ef
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Mon Jun 9 19:25:47 2014 -0600
Bug 12393 - Depend on SSL module for LWP, for OverDrive
The OverDrive integration needs to connect to an authentication server
over HTTPS, and many systems do not install the necessary module
(LWP::Protocol::https) by default.
Test plan (for patch):
1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in
listing.
Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access):
1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian).
2) Run an OverDrive search on the OPAC, it should fail.
3) Reinstall LWP::Protocol::https.
4) Rerun OverDrive search, it should now succeed.
Note: older versions of Debian do not need to install LWP::Protocol::https separately;
the Debian scripts have been updated to reflect this divide.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit ccb130058c395fd0bc46f7d05a6d8b82cce102d2
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Mon Jun 16 10:19:02 2014 +0200
Bug 12416: add new tests of DelUniqueDebarment
The subroutine DelUniqueDebarment was not enough tested
To test: execute the command prove t/db_dependent/Borrower_Debarments.t
The command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU)
Result: PASS
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All 31 test pass, no koha-qa errors
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests pass.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit ef227c3a4021577a0de07677adda06177ffd8cbb
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Mon Jun 16 09:31:13 2014 +0200
Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is'
The use of the subroutine 'is' is prefered over the subroutine 'is'
To test: execute the commande prove t/db_dependent/Borrower_Debarments.t
To command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU)
Result: PASS
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comments on last patch
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit e037fe1aa60534eb3887362e013ae83bd3ab08b0
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Mon Jun 16 09:13:35 2014 +0200
Bug 12416: add the test of DelUniqueDebarment
The subroutine DelUniqueDebarment was not tested
To test: execute the command prove t/db_dependent/Borrower_Debarments.t
The command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU)
Result: PASS
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comments on last patch
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 5 +-
C4/Installer/PerlDependencies.pm | 5 +
C4/Reserves.pm | 5 +-
acqui/newordersuggestion.pl | 1 -
acqui/transferorder.pl | 2 -
acqui/z3950_search.pl | 1 -
cataloguing/value_builder/marc21_field_008.pl | 58 +++++-
cataloguing/z3950_auth_search.pl | 1 -
cataloguing/z3950_search.pl | 1 -
debian/list-deps | 12 +-
debian/templates/apache-shared.conf | 2 +-
koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js | 4 +
.../cataloguing/value_builder/marc21_field_008.tt | 4 +
reports/stats.screen.pl | 2 -
serials/serial-issues.pl | 5 +-
services/itemrecorddisplay.pl | 2 +-
t/db_dependent/Borrower_Debarments.t | 88 +++++++--
t/db_dependent/Holds/RevertWaitingStatus.t | 101 ++++++++++
t/db_dependent/Members_Attributes.t | 200 ++++++++++++++++++++
19 files changed, 457 insertions(+), 42 deletions(-)
create mode 100755 t/db_dependent/Holds/RevertWaitingStatus.t
create mode 100755 t/db_dependent/Members_Attributes.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list