[koha-commits] main Koha release repository branch master updated. v3.14.00-541-g67d3985

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  67d3985929d70b67e64d5f0c275109b109065d2d (commit)
       via  2e6d44bd3200d0dceef59f04a79a27dcadceab1d (commit)
       via  cb45d4c2184622e15239077dd1c535a13abc53ce (commit)
      from  e0b13056b24655e52bb80543995ff9efe0470e34 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 67d3985929d70b67e64d5f0c275109b109065d2d
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon Mar 10 18:13:16 2014 +0000

    Bug 10452: (follow-up) remove duplicate check of damaged status
    
    While reviewing the main patch for this bug to verify that the
    holds queue routines and C4::Reserves had the same conception of
    when a damaged item could fill a hold request, I noticed that
    GetItemsAvailableToFillHoldRequestsForBib() duplicated the code
    for adding an SQL clause to filter out damaged items.  This patch
    removes the duplication and improves the POD for that routine.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 2e6d44bd3200d0dceef59f04a79a27dcadceab1d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jan 17 09:05:40 2014 -0500

    Bug 10452: [QA Followup] - Unit tests
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script. Also checked
      t/db_dependent/Holds.t
      t/db_dependent/HoldsQueue.t
    
    Tested holds triggering with different settings of
    AllowHoldsOnDamagedItems. Works as described.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit cb45d4c2184622e15239077dd1c535a13abc53ce
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Jun 12 10:09:25 2013 -0400

    Bug 10452: make AllowHoldsOnDamagedItems control using damaged items to fulfill holds
    
    AllowHoldsOnDamagedItems will stop item-specific holds from being placed
    on damaged items, but does not stop Koha from using damaged items to
    fill holds. This seems like incorrect behavior.
    
    Test Plan:
    1) Set 'AllowHoldsOnDamagedItems' to "Don't Allow"
    2) Pick an item, set it to damaged
    3) Place a bib-level hold on this item's record
    4) Scan the item though the returns system
    5) Koha will ask to use this item to fill the hold, click "ignore"
    6) Apply this patch
    7) Repeat step 4
    8) Koha will not ask to use this item to fill the hold
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/HoldsQueue.pm                                   |    3 +--
 C4/Reserves.pm                                     |   26 +++++++++++++-------
 .../en/modules/admin/preferences/circulation.pref  |    2 +-
 t/db_dependent/Holds.t                             |   10 +++++++-
 4 files changed, 28 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
main Koha release repository