[koha-commits] main Koha release repository branch master updated. v3.14.00-579-g556eb67

Wed Mar 12 04:45:51 CET 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  556eb677186b738c036fd13a7cc3461c3f8c3d48 (commit)
       via  22593e2e9b613bd03fd42100e60f9a1da53476d9 (commit)
       via  a5c7918eb3d4d83ceb22ee9881ebcef99f453345 (commit)
       via  aeae8ef3b29117eaf6a6ac0c0917f68e172f7957 (commit)
       via  3d938ffc823b0193fc61822ffeb08cb127c6682e (commit)
       via  c898f23f139866e2adb1fa46422f5cf32c5a1328 (commit)
       via  834abff631a4ea9bc779424d2096551d63dd13bb (commit)
      from  fd773f8e798f328292f49969b103892eb7dc6721 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 556eb677186b738c036fd13a7cc3461c3f8c3d48
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Mar 12 03:33:50 2014 +0000

    Bug 108661: (follow-up) enshrine letting CardnumberLength specify just a maximum

    This patch finishes the work started in one of the previous
    follow-ups and allows CardnumberLength to be set to a value
    like ',5'.  In conjunction with not including cardnumber in
    BorrowerMandatoryField, this allows a cardnumber to not be
    required but, if present, to not exceed the specified length.

    This patch also updates t/db_dependent/Members.t so that
    it runs in a transaction, tests the new return value
    of checkcardnumber, and manages the CardnumberLength syspref.

    To test:

    [1] Verify that prove -v t/db_dependent/Members.t and
        prove -v t/Members/cardnumber.t pass.
    [2] Set CardnumberLength to ",5" and take cardnubmer out of
        the BorrowerMandatoryField list.
    [3] Verify that you can save a patron record without a cardnumber,
        but if you supply one, that it can be at most 5 characters long.
    [4] Add cardnumber back to BorrowerMandatoryField.  This time, the
        minimum length is 1 even though CardnumberLength is ",5".

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 22593e2e9b613bd03fd42100e60f9a1da53476d9
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Mar 12 02:54:05 2014 +0000

    Bug 10861: (follow-up) use minlength/maxlength rather than pattern for client-side validation

    This patch replaces use of the HTML5 pattern attribute with minlength
    and maxlength, which is compatible with the jQuery validation plugin
    and which, in Chrome 33.0.1750.146 at least, works better.

    To test:

    [1] Enter a new patron record or edit an existing one.
    [2] Verify that the minimum and/or maximum length requirements
        set by the CardnumberLength syspref are validated and that
        form submission is prevented if the cardnumber doesn't
        meet the length requirements.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit a5c7918eb3d4d83ceb22ee9881ebcef99f453345
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Mar 12 02:26:37 2014 +0000

    Bug 10861: DBrev 3.15.00.023

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit aeae8ef3b29117eaf6a6ac0c0917f68e172f7957
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Dec 20 14:19:08 2013 -0500

    Bug 10861: (follow-up) Clarify preference description

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 3d938ffc823b0193fc61822ffeb08cb127c6682e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 11 19:06:15 2013 +0100

    Bug 10861: (follow-up) various refactoring

    This patch refactors the previous code and moves the logic from the pl
    to a new routine.

    Same test plan as previous patch.

    /!\ new unit test filename.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Bug 10861: Reintroduced the cardnumber length check (client side)

    Previous patches has removed the pattern attribute of the input, it was
    not needed. This patch reintroduces it. It will only work for new
    browser version.

    Moreover, it manages with the ',XX' format (see UT).

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Squashed the last two follow-ups. The pattern test did not work fully for me
    in Firefox 26 (very recent). But I see the message when I clear the field.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit c898f23f139866e2adb1fa46422f5cf32c5a1328
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Dec 11 13:46:15 2013 +0100

    Bug 10861: (follow-up) for typo in patrons.pref

    I'd rather have a comma than a coma :)

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

    Then again, if the cookies are really, really good, a cookie-induced
    coma would not be the worst thing.

commit 834abff631a4ea9bc779424d2096551d63dd13bb
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Apr 19 09:58:02 2013 +0200

    Bug 10861: Add a check on cardnumber length

    Some libraries would like to add a check on the cardnumber length.
    This patch adds the ability to restrict the cardnumber to a specific
    length (strictly equal to XX, or length > XX or min < length < max).
    This restriction is checked on inserting/updating a patron or on importing
    patrons.

    This patch adds:
    - 1 new syspref CardnumberLength. 2 formats: a number or a range
      (xx,yy).

    - 1 new unit test file t/Members/checkcardnumber.t for the
    C4::Members::checkcardnumber routine.

    Test plan:
    1/ Fill the pref CardnumberLength with '5,8'
    2/ Create a new patron with an invalid cardnumber (123456789)
    3/ Check that you cannot save
    4/ With Firebug, replace the pattern attribute value (for the cardnumber
    input) with ".{5,10}"
    5/ You are allowed to save but an error occurred.
    6/ Try the same steps for update.
    7/ Go to the import borrowers tool.
    8/ Play with the import borrowers tool. We must test add/update patrons
    and the "record matching" field (cardnumber or a uniq patron attribute)

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested adding, updating; importing and ran unit test.
    Preliminary QA comments on Bugzilla

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                      |   64 ++++++++++++----
 installer/data/mysql/updatedatabase.pl             |   10 +++
 .../prog/en/modules/admin/preferences/patrons.pref |    5 ++
 .../prog/en/modules/members/memberentrygen.tt      |   41 ++++++----
 .../prog/en/modules/tools/import_borrowers.tt      |    6 ++
 kohaversion.pl                                     |    2 +-
 members/memberentry.pl                             |   21 +++++-
 t/Members/cardnumber.t                             |   79 ++++++++++++++++++++
 t/db_dependent/Members.t                           |   16 +++-
 tools/import_borrowers.pl                          |   13 +++-
 10 files changed, 221 insertions(+), 36 deletions(-)
 create mode 100644 t/Members/cardnumber.t

hooks/post-receive
-- 
main Koha release repository