[koha-commits] main Koha release repository branch master updated. v3.14.00-591-g0b5b8ce
Git repo owner
gitmaster at git.koha-community.org
Wed Mar 12 15:33:43 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 0b5b8cef348b61761305dd0bbc574699404c7c69 (commit)
via 5c1691a8013bd38d6bae8b00a8950e1417695176 (commit)
via 0039eee40c6f70023bfb93e8d3d011b47da6867a (commit)
via 09fa6f09587b930670633639e306b1141632fce3 (commit)
via cd21ac754223f9edd4b16e7a9d247ba3e21330ed (commit)
via 6c264b24d12bafb8d0bc6eecdc7e188a622d7389 (commit)
via 635d5441112171170bd3f2de7fdbf9a9feb62f48 (commit)
via 18456ea5fc605d0c6dc58a860fe963bfbd3ba972 (commit)
via 3273f823508f445cfdbf0ad5f60b7f4c546f0ee2 (commit)
via 0b35290011a48938b55a069c2e44eee688bf70c8 (commit)
via a443d16692fbda6243628fb9d5c1dedc738404f6 (commit)
via ffb9e312a956ceb5e3b57c34bc6f5b055b494f5a (commit)
from 556eb677186b738c036fd13a7cc3461c3f8c3d48 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0b5b8cef348b61761305dd0bbc574699404c7c69
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Feb 24 11:35:52 2014 -0500
Bug 11832: fix JavaScript error on staff client place hold screen if record has no items
If a hold operation is blocked because the title has no items attached
the patron search autocomplete JavaScript triggers an error. This patch
modifies the template so that the JS is loaded only when items are
present.
To test, find a title which has no items attached. View the holds page
for that title. There should be no JavaScript error. Patron search
autocomplete should still work correctly for titles which have items
attached.
Deleted all items from a biblio record. Clicked the holds tab and
confirmed using firebug Javascript error occurs. Applied patch,
confirmed that the Javascript error described in comment 1 no
longer happens. Went to another biblio with items, and confirmed
patron auto-complete still functions.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 5c1691a8013bd38d6bae8b00a8950e1417695176
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Feb 21 15:27:41 2014 -0500
Bug 11821: disable catalog edit menu items and provide explanations when actions cannot be done
Biblio edit menu items which are disabled should trigger a tooltip
on hover and an alert on click with explanations. This patch implements
this for the relevent menu items.
To test, apply the patch for Bug 11829 if necessary. Find a record which
has no items attached. Test the following views:
- Normal
- MARC
- Labeled MARC
- ISBD
- Items
Test these Edit menu items:
- Edit items in a batch
- Delete items in a batch
- Delete all items
Hovering over these menu items should trigger an explanatory tooltip.
Clicking the menu items should trigger a similar alert.
Next, locate a title with items attached. On the same pages above, test
the Edit -> Delete record menu item. Hovering should trigger an
explanatory tooltip. Clicking it should trigger a similar alert.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, works nicely.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 0039eee40c6f70023bfb93e8d3d011b47da6867a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Feb 25 15:55:03 2014 -0500
Bug 11833 - fix filtering on saved report subgroup
Filtering the list of saved reports by subgroup doesn't work because the
filtering JavaScript was not updated when the table columns changed with
Bug 3134. This patch corrects the target column for filtering.
To test you must have multiple saved reports within one group, and at
least one of those in a subgroup.
- Apply the patch and go to Reports -> Use saved.
- Click the tab for the group which contains your reports.
- Choose the subgroup you want to filter on from the subgroup dropdown.
The list of reports should be correctly filtered by your subgroup.
NOTE: It seems weird to have the number of columns displayed change
when filtered, but this patch does correct the filtering.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes all tests and QA script.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 09fa6f09587b930670633639e306b1141632fce3
Author: Isaac Brodsky <isaac at isaacbrodsky.com>
Date: Thu Feb 27 09:10:33 2014 -0600
Bug 1047: Punctuation in site names no longer breaks Edit/Delete z39.50 server administration
The template used to show the Z39.50 server administration page had a
bug that caused it to not correctly escape generated query strings.
Because the Z39.50 server name is used to lookup the server in order
to edit or delete it, when the server name is not passed correctly in
the query string, it is impossible to bring up the edit or delete forms
(without manually entering the escaped string.)
This patch corrects which template is filter used to escape those query
strings.
To test:
(1) Login to intranet, go to Administration -> Z39.50 servers
(2) Select "New Z3.50 Server". Enter a server name that contains an
ampersand (&), e.g.: "FOO & BAR". Enter other details and submit.
Click OK to confirmation message.
(3) In the server list, click on the server name, the "Edit" or "Delete"
buttons for the server.
The correct and full server details should be brought up.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit cd21ac754223f9edd4b16e7a9d247ba3e21330ed
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Feb 21 20:07:01 2014 +0000
Bug 11820: remove dead code in basket group management
There was some code in acqui/basketgroup.pl that was apparently
intended to let one create a basket group for no (or an unknown)
vendor. However, this code was never reached, as there is nothing
in the templates that invokes basketgroup.pl with 'add' as the
operation that doesn't also pass the vendor ID along.
This patch removes that dead code.
To test:
[1] Create a new basket group for a vendor and verify that it is
created correctly.
[2] Edit an existing basket group, including moving baskets in and
and out of, and verify that it works.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
No regressions found, passes all tests and QA script.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 6c264b24d12bafb8d0bc6eecdc7e188a622d7389
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 5 10:35:47 2014 -0500
Bug 11686: make "please note your reason here..." translatable
Through some quirk of the translation script a predefined value on a
text input is not properly translated even though the string appears in
the po file. On the suggestions form the problem can be solved by using
the HTML5 placeholder attribute.
To test you must have existing suggestions to manage. Apply the patch
and:
- Update a translation by running tranlsate update [language code]
- Install/reinstall the translation by running translate install
[language code]
- In the English templates:
- Navigate to Acquisitions -> Suggestions and find the "Mark selected
as:" section below the table of existing suggestions.
- Select "Other" from the "choose a reason" field. A text input field
should appear with the placeholder text "please note your reason
here."
- In the templates you updated and installed, follow the same procedure
above. The placeholder text should now appear with the correct
translation.
- In both English and translated templates using this bulk-status option
should save your chosen status correctly with the correct reason,
whether that reason be predefined or manually entered.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes tests and QA script.
Tested successfully with German - nice to see this fixed!
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 635d5441112171170bd3f2de7fdbf9a9feb62f48
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jan 31 14:23:03 2014 +0100
Bug 11648 - Use word item instead of copy - opac prog
Sometimes, the word copy/copies is use to speak about item/items.
It would be better to use only item because translation of the word
copy depends on context, it should be used only when speaking about
copy like in "copy and paste".
This patch replaces copy/copies in opac prog theme.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 18456ea5fc605d0c6dc58a860fe963bfbd3ba972
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jan 31 14:22:45 2014 +0100
Bug 11648 - Use word item instead of copy - opac bootstrap
Sometimes, the word copy/copies is use to speak about item/items.
It would be better to use only item because translation of the word
copy depends on context, it should be used only when speaking about
copy like in "copy and paste".
This patch replaces copy/copies in opac bootstrap theme.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 3273f823508f445cfdbf0ad5f60b7f4c546f0ee2
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jan 31 14:22:05 2014 +0100
Bug 11648 - Use word item instead of copy - intranet
Sometimes, the word copy/copies is use to speak about item/items.
It would be better to use only item because translation of the word
copy depends on context, it should be used only when speaking about
copy like in "copy and paste".
This patch replaces copy/copies in intranet.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
String changes, no regressions found.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 0b35290011a48938b55a069c2e44eee688bf70c8
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Jan 14 12:21:43 2014 +0100
Bug 11550: Add UT for C4::Acquisition::GetOrder
If GetOrder is called with a nonexistent ordernumber or without any
ordernumber, it should return undef.
Test plan:
prove t/db_dependent/Acquisition.t
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Updated number of tests to 68, tests and QA script all happy now.
Looked at a few pages in aquisition using GetOrder as well.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit a443d16692fbda6243628fb9d5c1dedc738404f6
Author: Galen Charlton <gmc at esilibrary.com>
Date: Wed Mar 12 14:09:30 2014 +0000
Bug 10012: DBRev 3.15.00.024
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit ffb9e312a956ceb5e3b57c34bc6f5b055b494f5a
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Feb 21 18:14:05 2014 +0000
Bug 10012: remove last traces of NoZebra
This patch removes the last traces of NoZebra:
[1] The DBIC schema class for the nozebra table
[2] References to the NoZebra and NoZebraIndexes sysprefs
in the Italian SQL scripts.
[3] Deleting the NoZebraIndexes syspref if it's still present.
To test:
[1] Verify that after applying the patch and running the DB upgrade,
that "NoZebraIndexes" is no longer to be found in the
systempreferences table.
[2] Verify that "nozebra" is not referenced anywhere in the source
code except for the database update scripts.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: wajasu <matted-34813 at mypacks.net>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 2 +
Koha/Schema/Result/Nozebra.pm | 64 --------------
acqui/basketgroup.pl | 90 ++++++++------------
.../mysql/it-IT/necessari/system_preferences.sql | 2 -
installer/data/mysql/updatedatabase.pl | 9 ++
.../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 42 +++++++--
.../prog/en/modules/admin/z3950servers.tt | 4 +-
.../prog/en/modules/help/cataloguing/additem.tt | 2 +-
.../en/modules/reports/guided_reports_start.tt | 8 +-
.../prog/en/modules/reserve/request.tt | 10 +--
.../prog/en/modules/suggestion/suggestion.tt | 3 +-
.../prog/en/modules/tools/inventory.tt | 2 +-
.../bootstrap/en/modules/opac-MARCdetail.tt | 2 +-
.../bootstrap/en/modules/opac-overdrive-search.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 14 +--
.../bootstrap/en/modules/opac-results-grouped.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 6 +-
.../bootstrap/en/xslt/NORMARCslim2OPACResults.xsl | 6 +-
.../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 6 +-
.../opac-tmpl/prog/en/modules/opac-MARCdetail.tt | 2 +-
.../prog/en/modules/opac-overdrive-search.tt | 2 +-
.../opac-tmpl/prog/en/modules/opac-reserve.tt | 14 +--
.../prog/en/modules/opac-results-grouped.tt | 2 +-
.../opac-tmpl/prog/en/modules/opac-results.tt | 2 +-
.../prog/en/xslt/MARC21slim2OPACResults.xsl | 6 +-
.../prog/en/xslt/NORMARCslim2OPACResults.xsl | 6 +-
.../prog/en/xslt/UNIMARCslim2OPACResults.xsl | 6 +-
kohaversion.pl | 2 +-
t/db_dependent/Acquisition.t | 7 +-
30 files changed, 142 insertions(+), 185 deletions(-)
delete mode 100644 Koha/Schema/Result/Nozebra.pm
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list