[koha-commits] main Koha release repository branch master updated. v3.14.00-634-gcb62a47
Git repo owner
gitmaster at git.koha-community.org
Wed Mar 26 17:32:35 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via cb62a47bbf6fde22ac3bc4e33481c403b8c2c193 (commit)
via 17cf2657ef7fe0e293cdf4956b75f8e39c0aeeed (commit)
from ed10e5226cc8e9852dfee3f5520976695cb99412 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit cb62a47bbf6fde22ac3bc4e33481c403b8c2c193
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Feb 27 08:40:55 2014 -0500
Bug 11694: [QA Followup] strip out time portion when setting suspension date for individual hold
This patch fixes an issue originally reported by bug 11702.
RM note: the patch is clear enough and doesn't break existing tests,
but on the other hand, I have been completely unable to reproduce
the original issue.
To test:
[1] Verify that prove -v t/db_dependent/Holds.t passes
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 17cf2657ef7fe0e293cdf4956b75f8e39c0aeeed
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 5 16:11:29 2014 -0500
Bug 11694: Improve handling of individual hold suspension in Bootstrap OPAC
This patch changes the way the controls to suspend and resume holds are
displayed on the OPAC for a logged-in user when using the Bootstrap
theme. Instead of showing all the suspend options in the table cell a
link will trigger a modal with the controls. This makes the table more
compact and readable.
The patch adds a span and class to the dateformat include so that the
dateformat hint can be hidden if JavaScript is enabled (and thus the
datepicker will use the correct format automatically).
A new class has been added to the CSS, ".js-show" to be used for
elements which should be hidden if JavaScript is disabled and made
visible by JavaScript if it is enabled.
To test you must have RequestOnOpac, SuspendHoldsOpac, and the bootstrap
theme enabled.
Apply the patch and test with AutoResumeSuspendedHolds enabled:
1. Log in to the OPAC and place a hold.
2. View the list of your holds in the OPAC.
3. Click the "Suspend" link for your new hold. A modal window should
appear allowing you to specify a suspend-until date.
4. Specify a suspend-until date. Test the "clear" link and confirm that
it clears the date.
5. Specify a suspend-until date and submit.
6. Confirm that the hold has been suspended with the specified
resumption date.
7. Click the "Resume" link on the suspended hold to resume.
8. Click the "Suspend" link again and submit without specifying a date.
9. Confirm that the hold has been suspended indefinitely.
Follow the same steps above with JavaScript disabled. The "suspend
until" options will appear inside the table as before and everything
should work correctly.
Test with AutoResumeSuspendedHolds disabled. No modal dialog should
appear when the "Suspend" link is clicked. The hold should simply be
suspended indefinitely.
Test again with JavaScript disabled. There should be no change in
functionality.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, works as described.
Happy about the fallback for users without Javascript.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Reserves.pm | 8 +-
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2741 +-------------------
.../opac-tmpl/bootstrap/css/right-to-left.css | 2 +-
.../bootstrap/en/includes/date-format.inc | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 78 +-
koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 36 +
6 files changed, 99 insertions(+), 2768 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list