From gitmaster at git.koha-community.org Fri May 2 22:03:03 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 May 2014 20:03:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-973-g160ed32 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 160ed321bee5806d9f58b064a27b1c31c9ae3fe4 (commit) from 0456f6ade08d3d741d5da6eb912c0f40e08deb8b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 160ed321bee5806d9f58b064a27b1c31c9ae3fe4 Author: Galen Charlton Date: Fri May 2 20:25:22 2014 +0000 Bug 11182: (follow-up) fix regression where session branch wasn't initialized C4::Context->userenv() won't return a valid value until the user session set up, e.g., via get_template_and_user(). Consequently, the change introduced by a previous commit for bug 11182 ended up making it appear that when checking an item that fills a hold that it always needs to be transferred. This patch fixes the regression and moves the "no-branch-set" check to where it belongs. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: circ/returns.pl | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 2 22:54:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 May 2014 20:54:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1014-ge50bccb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e50bccb9fb6aa4e97021c3cef622f8a548b67bc6 (commit) via f3681addc3168cdc34eb2b3ba558b4bd786696a3 (commit) via b967a82f1c25768e5bca1bb46cfa44fc5f25b353 (commit) via e25c42715ae88bb3691fb660cd5039d68b1f6166 (commit) via 3fabce47aeddde8a6eb0cafedbb984a018b8d20c (commit) via 7ca4f590acf99089aa5423ec0f3d086540d4f390 (commit) via 7f1bb7c6b2a0a4489d5ba2a4f42d2e60a645f510 (commit) via b35931016392930ec502b6e3d37653bc93bf264b (commit) via 6a06fc9b6c3fc8c150f8cb420b181cf49d3ef800 (commit) via 08ed927dc182e5165eda1a3bed92e59729adad7b (commit) via 76dde86fcea815565399cb3d6ac4ed3a653ba60a (commit) via ca052b2558629052574c4a66425e9e6268392ca8 (commit) via 04ac36aa7c8529871610bf2594acfc31a3b80db5 (commit) via 9575986ed126cdcd550817fadaeb0d49a541a33c (commit) via 9270f064635ee16910d2a3d1e3e491e6bac22976 (commit) via 6b1c114cc698a2ff944a30eaa367a0c0ce4922a4 (commit) via c4abafce3321785f55b504343a8ec8226100cbca (commit) via abb3647d039d8ff88e0e3984b99861b73cdf9b19 (commit) via 7e878d42a0039a176b63681b6593013c36c126c6 (commit) via 777814a2608a2376cd44ce2b410bb0b7fa465190 (commit) via 90c9510e0af070e9227050eae1e287cbe05b169e (commit) via 3c581bad5a8ba8bb2fc29b9c8c5ac21bfbb1686a (commit) via ca871ea334962296b209c3d38e7bd725a0109db3 (commit) via 45a6e7efd1c0df56320055b8dd9c56ab6899197c (commit) via 2d6fe5f63e79f37cf86c3e3885d32c38a6a6aa99 (commit) via ca68b94c276d34e7bdf8ea5ceee26602379c4ebc (commit) via c50c4d1e89c6565e50b2905fa4ad48922e327864 (commit) via 06c12fd1999224c7126ca1d81b6fe7886eab51b9 (commit) via a657ac6833894b5e0f584df2383cf5b9d0cb6265 (commit) via b717e3d2df4c68947b4273f6e1716b1f1f1e5b6b (commit) via 4138c35c0020956b8e13e1758e26413d0693ecf2 (commit) via dc95637ef00cbd695034dcca6645551571f1907a (commit) via e778fb80c118f3cf934268d29acf705b6eb398db (commit) via d268d154f108c6922633b63e2abfdafead24fc69 (commit) via cc8090b15ad511fe61a9250f0869430093b4fca6 (commit) via 9ac4591de91dd21878fc94b644d74182f9a6db84 (commit) via f7537bc9388313bc3c328288cc961f81c9a7b30d (commit) via 7ae384a0b1ca177d76e841bf67a5bb27bd4a6488 (commit) via f131dc6c3b3f800acdd985b0a20e1649a380e772 (commit) via e421ec49259b42b75851218ce3d85e80cd590096 (commit) via 82145411141c29c6c4b8849a1ae11fefb65ceabc (commit) from 160ed321bee5806d9f58b064a27b1c31c9ae3fe4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e50bccb9fb6aa4e97021c3cef622f8a548b67bc6 Author: Galen Charlton Date: Fri May 2 21:17:49 2014 +0000 Bug 9016: (follow-up) standardize case of message transport type columns Signed-off-by: Galen Charlton commit f3681addc3168cdc34eb2b3ba558b4bd786696a3 Author: Galen Charlton Date: Fri May 2 21:11:30 2014 +0000 Bug 9016: (follow-up) treat missing transports for overdue notices as warnings Signed-off-by: Galen Charlton commit b967a82f1c25768e5bca1bb46cfa44fc5f25b353 Author: Galen Charlton Date: Fri May 2 21:01:45 2014 +0000 Bug 9016: (follow-up) treat missing transports for predue and item due notices as warnings, not fatal errors Signed-off-by: Galen Charlton commit e25c42715ae88bb3691fb660cd5039d68b1f6166 Author: Galen Charlton Date: Fri May 2 20:54:55 2014 +0000 Bug 9016: (follow-up) treat missing transports for hold available notices as warnings, not fatal errors This patch fixes a situation where a patron that has preferences set for transport of a notice via a method that is not supported for that notice type can result in a failure. Rather than make it a fatal error during checkin, simply log a warning and skip. Signed-off-by: Galen Charlton commit 3fabce47aeddde8a6eb0cafedbb984a018b8d20c Author: Galen Charlton Date: Fri May 2 19:40:42 2014 +0000 Bug 9016: (follow-up) move insertAtCaret plugin out of language-specific directory Signed-off-by: Galen Charlton commit 7ca4f590acf99089aa5423ec0f3d086540d4f390 Author: Jonathan Druart Date: Thu Feb 6 11:41:35 2014 +0100 Bug 11696: ensure that print overdue notices use the print template This reordering avoids the case where a print notice is sent with an email or sms template is no email or SMS is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 7f1bb7c6b2a0a4489d5ba2a4f42d2e60a645f510 Author: Galen Charlton Date: Fri May 2 19:30:51 2014 +0000 Bug 3.15.00.041: DBrev 11867 Signed-off-by: Galen Charlton commit b35931016392930ec502b6e3d37653bc93bf264b Author: Jonathan Druart Date: Fri May 2 17:03:56 2014 +0200 Bug 11867: (follow-up) Change the sql query in order to win beauty prices Signed-off-by: Galen Charlton commit 6a06fc9b6c3fc8c150f8cb420b181cf49d3ef800 Author: Jonathan Druart Date: Thu Feb 27 14:57:55 2014 +0100 Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages Signed-off-by: Galen Charlton commit 08ed927dc182e5165eda1a3bed92e59729adad7b Author: Olli-Antti Kivilahti Date: Fri Jan 3 15:29:48 2014 +0200 Bug 10833: (follow-up) add message transport type to a warning message Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 76dde86fcea815565399cb3d6ac4ed3a653ba60a Author: Jonathan Druart Date: Fri Sep 6 11:39:51 2013 +0200 Bug 10833: Multi transport types for advanced notices Test plan: - Choose 2 patrons P1 and P2 - Edit "Patron messaging preferences" and check SMS + email with 2 days in advance for P1 check email with 5 days in advance for P2 - defined a message for the letter code PREDUE for sms and email (tools/letters.pl). - select 2 barcodes (B1, B2). * checkout B1 to P1 with a due date = NOW - 2 days * checkout B2 to P2 with a due date = NOW - 5 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/advance_notices.pl -c - retry the previous sql query, you should have X + 3 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code PREDUE 1 message for P2, email and the letter code PREDUE Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit ca052b2558629052574c4a66425e9e6268392ca8 Author: Jonathan Druart Date: Wed Apr 23 17:35:33 2014 +0200 Bug 10832: (follow-up) add the transport type in the warning message If no template is defined for a letter and the needed MTT, we should display the MTT. Signed-off-by: Galen Charlton commit 04ac36aa7c8529871610bf2594acfc31a3b80db5 Author: Jonathan Druart Date: Thu Feb 13 14:54:45 2014 +0100 Bug 10832: (follow-up) fix case where some print overdue notices were not being sent If overdues should be sent to some patron (on the same branch), only the first one was notified. This patch fixes this issue. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 9575986ed126cdcd550817fadaeb0d49a541a33c Author: Jonathan Druart Date: Fri Sep 6 11:23:44 2013 +0200 Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - define a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 9270f064635ee16910d2a3d1e3e491e6bac22976 Author: Olli-Antti Kivilahti Date: Wed Jan 15 16:25:17 2014 +0200 Bug 11561: restore previous behavior of generation of hold print notices This patch prevents duplicate hold available print notices from being sent and enforces making a print notice if no other transports can be used. ------------------------- - REPLICATING THE ISSUE - ------------------------- 1. Set a Patrons "Hold filled"-messaging preference to SMS + Email 2. Remove the SMS number (sms notification number) and all email addresses. 3. Make a reservation for this Patron. 4. Check-in the reserved Item. 5. message_queue-table has two generated print notices for the Hold_filled event. One for both failed message transport types, email and sms. 1. Set a Patrons "Hold filled"-messaging preference to empty, remove all checks from boxes. 2. Make a reservation for this Patron 3. Check-in the reserved Item. 4. message_queue-table has no message for the Hold-filled event. This is problematic because a Patron should get some kind of a notification for a filled Hold. ----------------------------- - AFTER APPLYING THIS PATCH - ----------------------------- If all message transport types for "Hold filled" fail, a print notice is queued in the message_queue table. Only one print message is queued even if many transports attempts fail. Signed-off-by: Galen Charlton commit 6b1c114cc698a2ff944a30eaa367a0c0ce4922a4 Author: Galen Charlton Date: Fri May 2 19:01:37 2014 +0000 Bug 10845: (follow-up) update how a test case counts print hold available notices Signed-off-by: Galen Charlton commit c4abafce3321785f55b504343a8ec8226100cbca Author: Galen Charlton Date: Fri May 2 19:01:07 2014 +0000 Bug 10845: DBrev 3.15.00.040 Signed-off-by: Galen Charlton commit abb3647d039d8ff88e0e3984b99861b73cdf9b19 Author: Jonathan Druart Date: Thu May 1 15:41:31 2014 +0200 Bug 10845: (follow-up) fix message_transport_type parameter for Itiva cronjob The message_transport_type param should passed to GetPreparedLetter, not part of the "tables" parameter. Signed-off-by: Galen Charlton commit 7e878d42a0039a176b63681b6593013c36c126c6 Author: Jonathan Druart Date: Wed Apr 23 16:48:54 2014 +0200 Bug 10845: (follow-up) add the MTT in the die message If no template is defined for the HOLD letter and the needed MTT, we should display the MTT. Signed-off-by: Galen Charlton commit 777814a2608a2376cd44ce2b410bb0b7fa465190 Author: Jonathan Druart Date: Mon Sep 9 16:58:22 2013 +0200 Bug 10845: Multi transport types for holds The HOLD_PRINT and HOLD_PHONE notices become useless. This patch modifies existing notices in order to group them into the main notice type 'HOLD', with any pre-existing print and phone templates in the appropriate places. Test plan: - Apply the patch and execute the update database entry. - Verify that your previous HOLD_PHONE and HOLD_PRINT are displayed when editing the HOLD notice (under phone and print). - Choose a patron and check SMS, email, phone for "Hold filled" (on the patron messaging preferences). - Place a hold. - Check the item in and confirm the hold. - If the patron has an email *and* a SMS number, 2 new messages are put into the message_queue table: 1 sms and 1 email. If the patron does not have 1 of them, there are 2 new messages: 1 sms/email and 1 print. If the user has neither of them, there is 1 new message: 1 print. - The generated messages should correspond with the notices defined, depending the message transport type. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Just noting that if email and SMS are disabled in the msg prefs, the user will not have a print message. And if the SMS driver fails, the record status in message_queue is 'failed', but staff may not be aware of that. Signed-off-by: Galen Charlton commit 90c9510e0af070e9227050eae1e287cbe05b169e Author: Jonathan Druart Date: Mon Sep 9 17:12:21 2013 +0200 Bug 10845: Remove the notice code HOLD_PRINT in seed data This patch converts the HOLD_PRINT notice to a HOLD notice with a message transport type of 'print'. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 3c581bad5a8ba8bb2fc29b9c8c5ac21bfbb1686a Author: Galen Charlton Date: Fri May 2 18:32:02 2014 +0000 Bug 11868: (follow-up) correct case of "SMS" Signed-off-by: Galen Charlton commit ca871ea334962296b209c3d38e7bd725a0109db3 Author: Jonathan Druart Date: Thu Feb 27 14:30:50 2014 +0100 Bug 11868: MTT: disable SMS and phone if not in use On both pages "Notices and slips" and "Overdue rules", it would be great to disable SMS and phone if there are not in use. This patch implements this. Test plan: 1/ Edit a notice 2/ Enable/disable the SMSSendDriver pref and verify the sms block is enabled/disabled. 3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone block is enabled/disabled. 4/ Go on tools/overdues.pl 5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes are enabled/disabled. 6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone checkboxes are enabled/disabled. Signed-off-by: Olli-Antti Kivilahti --------------- Testing report: --------------- Followed the test plan. Reviewed the code modifications. Feature works as expected. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 45a6e7efd1c0df56320055b8dd9c56ab6899197c Author: Galen Charlton Date: Fri May 2 18:05:09 2014 +0000 Bug 9016: (follow-up) update DBIC schema classes Signed-off-by: Galen Charlton commit 2d6fe5f63e79f37cf86c3e3885d32c38a6a6aa99 Author: Galen Charlton Date: Fri May 2 18:03:37 2014 +0000 Bug 9016: DBRev 3.15.00.039 Signed-off-by: Galen Charlton commit ca68b94c276d34e7bdf8ea5ceee26602379c4ebc Author: Marcel de Rooy Date: Fri Mar 28 09:50:11 2014 +0100 Bug 9016: (QA Follow-up) Remove warning from content.length test If the letter.content is undef, the content.length test in the letter template will trigger warning: Argument "" isn't numeric in numeric gt (>). This patch eliminates that warning. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit c50c4d1e89c6565e50b2905fa4ad48922e327864 Author: Jonathan Druart Date: Thu Mar 27 16:18:07 2014 +0100 Bug 9016: (follow-up) Improve number of characters display when mtt=sms Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 06c12fd1999224c7126ca1d81b6fe7886eab51b9 Author: Jonathan Druart Date: Thu Mar 27 16:01:22 2014 +0100 Bug 9016: (follow-up) Add some validation on the letter form 1/ Code and Name are mandatory. 2/ At least 1 template should be filled on saving. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit a657ac6833894b5e0f584df2383cf5b9d0cb6265 Author: Jonathan Druart Date: Thu Mar 27 16:00:57 2014 +0100 Bug 9016: (follow-up) FIX letter name is not displayed on editing a letter If the name is not in email, the name is not correctly retrieved. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit b717e3d2df4c68947b4273f6e1716b1f1f1e5b6b Author: Jonathan Druart Date: Thu Mar 13 09:30:22 2014 +0100 Bug 9016: (follow-up) letter name is not displayed on editing a letter On editing a letter, the letter name is not displayed. So if you save it, the letter name is erased with an empty string. Signed-off-by: Olli-Antti Kivilahti Tested by setting the "Name"-field in letter.pl, saving, re-editing and verifying that the email is present in the letter's "Name"-field. The letter "Name" is replicated for each template in the DB, but that doesn't incur any performance penalty. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 4138c35c0020956b8e13e1758e26413d0693ecf2 Author: Jonathan Druart Date: Wed Mar 12 18:42:40 2014 +0100 Bug 9016: (follow-up) additional mtt's name should be displayed in header If you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit dc95637ef00cbd695034dcca6645551571f1907a Author: Jonathan Druart Date: Thu Mar 6 15:18:12 2014 +0100 Bug 9016: (follow-up) make GetLetters return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. Signed-off-by: Olli-Antti Kivilahti --------------- Testing report: --------------- Testing this subroutine from a test stub. Calling the method without arguments and with argument 'circulation' and 'circulat'. Works as supposed to. Related Bug 11931 discovered but not within the scope of this featureset. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit e778fb80c118f3cf934268d29acf705b6eb398db Author: Jonathan Druart Date: Mon Feb 24 16:13:35 2014 +0100 Bug 9016: (follow-up) various fixes * Fixes POD of GetMessageTransportTypes. * Removes the useless map in GetMessageTransportTypes. * Textual: "You must specify a title and a content" -> "Please specify title and content". * Reintroduces << and >> around the field name. * Change message for the update DB entry. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit d268d154f108c6922633b63e2abfdafead24fc69 Author: Kyle M Hall Date: Fri Feb 7 08:54:24 2014 -0500 Bug 9016: (follow-up) add insertAtCaret library to about page Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit cc8090b15ad511fe61a9250f0869430093b4fca6 Author: Jonathan Druart Date: Mon Feb 3 14:15:38 2014 +0100 Bug 9016: (follow-up) fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 9ac4591de91dd21878fc94b644d74182f9a6db84 Author: Jonathan Druart Date: Mon Dec 16 09:48:39 2013 +0100 Bug 9016: (follow-up) fix tab characters and POD. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit f7537bc9388313bc3c328288cc961f81c9a7b30d Author: Jonathan Druart Date: Fri Nov 8 13:40:07 2013 +0100 Bug 9016: (follow-up) fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 7ae384a0b1ca177d76e841bf67a5bb27bd4a6488 Author: Jonathan Druart Date: Fri Sep 6 09:36:42 2013 +0200 Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit f131dc6c3b3f800acdd985b0a20e1649a380e772 Author: Jonathan Druart Date: Mon Sep 9 16:52:29 2013 +0200 Bug 9016: (follow-up) GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit e421ec49259b42b75851218ce3d85e80cd590096 Author: Jonathan Druart Date: Fri Sep 6 10:28:39 2013 +0200 Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 82145411141c29c6c4b8849a1ae11fefb65ceabc Author: Jonathan Druart Date: Fri Sep 6 10:27:04 2013 +0200 Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 71 ++-- C4/Overdues.pm | 33 ++ C4/Reserves.pm | 69 ++-- Koha/Schema/Result/Letter.pm | 39 +- Koha/Schema/Result/MessageTransportType.pm | 38 +- Koha/Schema/Result/Overduerule.pm | 24 +- Koha/Schema/Result/OverduerulesTransportType.pm | 145 +++++++ ...-4246-Talking-Tech-itiva-phone-notifications.pl | 14 +- .../data/mysql/de-DE/mandatory/sample_notices.sql | 38 +- .../data/mysql/en/mandatory/sample_notices.sql | 38 +- .../data/mysql/es-ES/mandatory/sample_notices.sql | 30 +- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 38 +- installer/data/mysql/it-IT/necessari/notices.sql | 36 +- installer/data/mysql/kohastructure.sql | 21 +- .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 38 +- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 36 +- .../data/mysql/ru-RU/mandatory/sample_notices.sql | 34 +- installer/data/mysql/updatedatabase.pl | 100 +++++ .../lib/jquery/plugins/jquery.insertatcaret.js | 46 +++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 6 + .../prog/en/modules/help/tools/letter.tt | 8 +- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 398 +++++++++++--------- .../prog/en/modules/tools/overduerules.tt | 224 +++++------ kohaversion.pl | 2 +- misc/cronjobs/advance_notices.pl | 146 ++++--- misc/cronjobs/overdue_notices.pl | 126 ++++--- .../thirdparty/TalkingTech_itiva_outbound.pl | 9 +- t/db_dependent/Letters.t | 13 +- t/db_dependent/Overdues.t | 77 ++++ t/db_dependent/Reserves.t | 5 +- tools/letter.pl | 167 +++++--- tools/overduerules.pl | 126 +++++-- 32 files changed, 1469 insertions(+), 726 deletions(-) create mode 100644 Koha/Schema/Result/OverduerulesTransportType.pm create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.insertatcaret.js create mode 100644 t/db_dependent/Overdues.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 3 00:31:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 May 2014 22:31:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1021-g81064f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 81064f4e2a524b7807a424a320b72a3f21707e7d (commit) via 9ab9686250a31b6027d57a294739893ff31ca833 (commit) via 80c68171bdefeebf90a958af330d43514a687c5f (commit) via b3f5867bb70d8aa66d9cbecab760dcec12b3faae (commit) via 0b2e9dbf620afeca2ec4a82b583c6787d8f1208b (commit) via 892111c84d5bbfbc16b39ea93f734a200a8694f7 (commit) via 1b618cac3dc1436ba38c78ea5219afc6822f5f5a (commit) from e50bccb9fb6aa4e97021c3cef622f8a548b67bc6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81064f4e2a524b7807a424a320b72a3f21707e7d Author: Galen Charlton Date: Fri May 2 22:48:02 2014 +0000 Bug 10694: (follow-up) display the note about restricted patrons consistently This patch ensures that the note displayed when checking in a loan to a restricted patron (and setting the return date) is displayed whether or not the circulation staffer has chosen the make the return date override sticky. Signed-off-by: Galen Charlton commit 9ab9686250a31b6027d57a294739893ff31ca833 Author: Galen Charlton Date: Fri May 2 22:46:23 2014 +0000 Bug 10694: (follow-up) fix problems with the new Borrowers plugin TT plugins should *not* be duplicating business logic found in other modules. This patch replaces the copy-and-paste of the old IsDebarred logic with a call to the appropriate routine and updates the POD. Signed-off-by: Galen Charlton commit 80c68171bdefeebf90a958af330d43514a687c5f Author: Galen Charlton Date: Fri May 2 22:00:45 2014 +0000 Bug 10694: (follow-up) remove truncate table from test case Doing a truncate of a table in MySQL causes an implicit commit. Consequently, they should not be used in DB-dependent test cases, as they will cause the changes to NOT be rolled back. Signed-off-by: Galen Charlton commit b3f5867bb70d8aa66d9cbecab760dcec12b3faae Author: Galen Charlton Date: Fri May 2 21:48:14 2014 +0000 Bug 10694: DBrev 3.15.00.042 Signed-off-by: Galen Charlton commit 0b2e9dbf620afeca2ec4a82b583c6787d8f1208b Author: Kyle M Hall Date: Wed Apr 23 07:38:11 2014 -0400 Bug 10694: (follow-up) add unit tests, improve AddReturn POD Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 892111c84d5bbfbc16b39ea93f734a200a8694f7 Author: Kyle M Hall Date: Sun Oct 20 18:39:15 2013 -0400 Bug 10694: (follow-up) fix various issues - new TT plugin for Borrowers, that at present supplies a method for determining if the patron is restricted - setting the default value of SpecifyReturnDate to false during upgrade to avoid an unwelcome surprise - validate the return date on the client side before allowing the form to be submitted. Signed-off-by: Petter Goksoyr Asen Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 1b618cac3dc1436ba38c78ea5219afc6822f5f5a Author: Kyle M Hall Date: Fri Sep 13 11:26:30 2013 -0400 Bug 10694 - Allow arbitrary backdating of returns Sometimes libraries need to backdate returns further back in time than Koha's dropbox mode will allow. The returns backdating will check in an item as if it had been returned on the specified date, and will reduce any fine accordingly. This feature is activated by a new system preference, SpecifyReturnDate. Test Plan: 1) Apply this patch 2) Check out an item, and backdate the due date by 1 month or so * This issue needs to generate a fine 3) Run fines.pl to generate the fine 4) Browse to returns.pl 5) Specify a return date of the day after the specified due date 6) Check the borrowers issue history, you should see the backdated return date, rather than today's date 7) Check the fine, it should be reduced to a fine for a single day overdue, rather than the previous larger fine. Signed-off-by: Kyle M Hall Signed-off-by: Barbara Knibbs Signed-off-by: Petter Goksoyr Asen Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 49 +++++++++----- Koha/Template/Plugin/{Koha.pm => Borrowers.pm} | 28 ++++---- circ/returns.pl | 32 ++++++++- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 12 ++++ .../intranet-tmpl/prog/en/includes/calendar.inc | 28 ++++++++ .../en/modules/admin/preferences/circulation.pref | 6 ++ .../intranet-tmpl/prog/en/modules/circ/returns.tt | 71 +++++++++++++++++++- kohaversion.pl | 2 +- t/db_dependent/Circulation_issue.t | 12 +++- 10 files changed, 207 insertions(+), 34 deletions(-) copy Koha/Template/Plugin/{Koha.pm => Borrowers.pm} (59%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 3 01:00:40 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 May 2014 23:00:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1025-gc4f1765 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c4f17650132c9b74aa56c40a3a2bec2bdbc4477e (commit) via 98edbf00cc10c908820eb1126a176ed12a04300d (commit) via 0cada7a323db7f9871b67a07e3343642543b64e0 (commit) via 35bec75d66637bd3c4cff499ed7fb534b8d09f35 (commit) from 81064f4e2a524b7807a424a320b72a3f21707e7d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c4f17650132c9b74aa56c40a3a2bec2bdbc4477e Author: Fridolin Somers Date: Wed Feb 26 17:14:04 2014 +0100 Bug 11369: (follow-up) generate searchid in browser.js The search browser feature uses nearly only the browser.js file. That is why I propose to move the searchid generation from search.pl to browser.js. We then use Date.getTime() to use current timestamp as searchid, prefixed by 'scs_' like before. Test by using test plan of main patch : Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes tests and QA script. Tested the browse functionality in staff by using the different options (back to results, next, previous, etc) and the batch modifications for items. An old cookie can cause a Javascript error, but after restarting the browser/deleting cookies it all works correctly. Signed-off-by: Galen Charlton commit 98edbf00cc10c908820eb1126a176ed12a04300d Author: Fridolin Somers Date: Wed Feb 26 17:03:13 2014 +0100 Bug 11369: (follow-up) Correct usage of me.searchid in browser.js In browser.js, at creation of browser, the searchid is transmited to JS object into me.searchid. To be consistant, me.searchid should always be use, never searchid alone. In browseRecords function, setting searchid as parameter is useless because it is defined in me.searchid. Test with test plan of Bug 10404 Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 0cada7a323db7f9871b67a07e3343642543b64e0 Author: Olli-Antti Kivilahti Date: Wed Dec 11 14:28:53 2013 +0200 Bug 11369: fix issue that can cause staff client searches to stop working This patch fixes an issue where too many search cursor cookies overflow the HTTP-header size after making multiple searches in the staff client. To replicate this issue, make multiple searches in catalogue/search.pl. 50+ Should be enough to cause the HTTP-request header to overgrow. One can verify this issue by observing the searchCookie growth in browser's stored cookies. ------------- - TEST PLAN - ------------- Keep making searches. One should never have more than 10 searchCookies. Browser might display only 9, because for some reason the newest js-generated cookie is not included in Firefox's cookies listing. ------------ - DRAWBACK - ------------ Removing these cookies disables the search cursor for traversing search results (next/previous) for the removed cookie. This maybe be problematic in some cases, (for ex when multiple search tabs need to be open and they need to be traversed) One easy solution is to grow the amount of stored searchCookies from 10 to 20, but 10 is chosen so there will be plenty of room for other cookies as well. Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 35bec75d66637bd3c4cff499ed7fb534b8d09f35 Author: Olli-Antti Kivilahti Date: Tue Dec 10 19:12:01 2013 +0200 Bug 11369 - Updating the jquery.cookie.js-plugin The current jquery.cookie-plugin crashes when trying to fetch all cookies using $.cookie(); Downloaded the newest plugin version and minified it. Now works as intended. Encountered an issue with the plugin now returning null when no cookies are found, and applied a fix in browser.js. ------------- - Test plan - ------------- Plugin is used in browser.js and batchMod.js so testing both Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: catalogue/search.pl | 4 +-- koha-tmpl/intranet-tmpl/js/browser.js | 33 +++++++++++++++----- .../lib/jquery/plugins/jquery.cookie.min.js | 2 +- 3 files changed, 29 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 3 20:10:15 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 03 May 2014 18:10:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1037-ge88117b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e88117b5fab293137bb74f57095a1ad1cdb7dbfa (commit) via 62d6b44ada4b942cd7668bd0e1fcc7b50b1fe320 (commit) via bc57a22c462e15a02bf4648bcbc349604f155061 (commit) via 772c095ea31a45743dd6bdefeda576e95808f67c (commit) via efdde38768c71105d56bb33b19c3fe335edea0a8 (commit) via 4de746a65ace55f78affb8474c45c2129d4620a7 (commit) via c0569f0b1e3d955869db411fc7456e6e7722dbd7 (commit) via 30e94f0c53723355e331d02e1437897cc25d7d62 (commit) via bd5d32731816d2ddd7430f1f59f29bb8c7476f6f (commit) via 4ba1f40f30e525066b95ddf5c25ec0dc4fe28aca (commit) via 56f3c32fe31c087ea82ae5661ca22cbc3671be34 (commit) via 86be6d7550ca048d19886797ee63bfafafe8fe0a (commit) from c4f17650132c9b74aa56c40a3a2bec2bdbc4477e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e88117b5fab293137bb74f57095a1ad1cdb7dbfa Author: Owen Leonard Date: Fri Feb 14 09:53:41 2014 -0500 Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden. Signed-off-by: Jonathan Druart It is unusual to open the action list above the button, but it works. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 62d6b44ada4b942cd7668bd0e1fcc7b50b1fe320 Author: Galen Charlton Date: Sat May 3 18:32:34 2014 +0000 Bug 11578: (follow-up) fix JavaScript error Fix error that can occur when using the DataTable filter to filter the table down to just one fund. Signed-off-by: Galen Charlton commit bc57a22c462e15a02bf4648bcbc349604f155061 Author: Jonathan Druart Date: Wed Apr 30 12:34:08 2014 +0200 Bug 11578: (follow-up) fix budgets grouping If 2 budgets (budget periods) have the same description, the funds will be grouped into the same "block". This patch adds a distinction adding the id of the budget next to the description. Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 772c095ea31a45743dd6bdefeda576e95808f67c Author: Jonathan Druart Date: Wed Apr 30 12:12:07 2014 +0200 Bug 11578: (follow-up) fix funds grouping The datatables sort options were wrong. The funds for a budget could be ungrouped. To reproduce: - Create 3 budgets A, B, C. - Create 1 or more funds for A, B, C - Mark B and C as inactive. - Create another fund for A - Go on the fund list view, click on "show inactive funds" => The last fund is not grouped without other funds of budget A. Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit efdde38768c71105d56bb33b19c3fe335edea0a8 Author: Jonathan Druart Date: Wed Apr 30 11:54:29 2014 +0200 Bug 11578: (follow-up) fix show inactive link Before this patch, the inactive funds were displayed by default. The active funds should be displayed by default. Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 4de746a65ace55f78affb8474c45c2129d4620a7 Author: Jonathan Druart Date: Mon Apr 28 19:52:29 2014 +0200 Bug 11578: QA follow-up This patch removes the error raised by tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt FAIL tt_valid lines 310 Actually, it fails because translate script does not match strings in attribute value. In this case, we don't want to translate. This fix is not necessary. This patch also adds the licence for the new jQuery treetable plugin. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit c0569f0b1e3d955869db411fc7456e6e7722dbd7 Author: Jonathan Druart Date: Tue Apr 22 16:03:33 2014 +0200 Bug 11578: (follow-up) hide filters if a budget (budgetperiod) is chosen If a budget_period_id is given, the filters should not be displayed. Moreover, it does not make sense to display the links for displaying/hiding inactive budgets in this case. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 30e94f0c53723355e331d02e1437897cc25d7d62 Author: Jonathan Druart Date: Fri Feb 14 10:39:41 2014 +0100 Bug 11578: (follow-up) align budget names Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit bd5d32731816d2ddd7430f1f59f29bb8c7476f6f Author: Jonathan Druart Date: Fri Feb 14 10:38:35 2014 +0100 Bug 11578: (follow-up) hide inactive budgets by default This patch hides inactive budgets by default. They can be shown/hidden using 2 new links "Hide/Show inactive budgets". Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 4ba1f40f30e525066b95ddf5c25ec0dc4fe28aca Author: Jonathan Druart Date: Fri Jan 17 15:35:09 2014 +0100 Bug 11578: (follow-up) add some CSS Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 56f3c32fe31c087ea82ae5661ca22cbc3671be34 Author: Jonathan Druart Date: Fri Jan 17 15:29:18 2014 +0100 Bug 11578: Improve the funds list view The current funds list view does not allow to search in the table and the ergonomics of the page is quite bad. This patch add the datatables plugin combined to the treetable plugin in order to offer a better view of the budgets/funds. Test plan: - Verify there is no regression on this page: try to add/modify/delete a fund and a budget. - Verify the funds hierarchy is correctly displayed. - Filter the funds using the branch and the budget filters. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 86be6d7550ca048d19886797ee63bfafafe8fe0a Author: Jonathan Druart Date: Fri Jan 17 15:24:37 2014 +0100 Bug 11578: Upgrade the treetable jquery plugin This patch upgrade the treetable jquery plugin to the last version (3.1.0). It is only used on the funds list view. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 2 +- admin/aqbudgets.pl | 98 ++-- .../jquery/plugins/treetable/jquery.treetable.js | 620 ++++++++++++++++++++ .../treetable/stylesheets/jquery.treetable.css | 36 ++ .../stylesheets/jquery.treetable.theme.default.css | 83 +++ .../plugins/treetable/stylesheets/screen.css | 28 + koha-tmpl/intranet-tmpl/prog/en/css/datatables.css | 7 + .../intranet-tmpl/prog/en/css/staff-global.css | 6 + .../treetable/images/toggle-collapse-dark.png | Bin 2886 -> 0 bytes .../treetable/images/toggle-collapse-light.png | Bin 2864 -> 0 bytes .../treetable/images/toggle-expand-dark.png | Bin 2894 -> 0 bytes .../treetable/images/toggle-expand-light.png | Bin 2863 -> 0 bytes .../plugins/treetable/jquery.treeTable.min.js | 13 - .../treetable/stylesheets/jquery.treeTable.css | 43 -- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 + .../prog/en/modules/admin/aqbudgets.tt | 262 +++++---- 16 files changed, 984 insertions(+), 217 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/treetable/jquery.treetable.js create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/treetable/stylesheets/jquery.treetable.css create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/treetable/stylesheets/jquery.treetable.theme.default.css create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/treetable/stylesheets/screen.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/treetable/images/toggle-collapse-dark.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/treetable/images/toggle-collapse-light.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/treetable/images/toggle-expand-dark.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/treetable/images/toggle-expand-light.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/treetable/jquery.treeTable.min.js delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/treetable/stylesheets/jquery.treeTable.css hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun May 4 20:23:38 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 May 2014 18:23:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1040-ge7c2a20 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e7c2a2031f470ab5e22d431bab7076dd0fd51654 (commit) via 08e594f149a120d0b43e2c5795f1342290231e13 (commit) via 6b75d95680a28f68bdc50e2259a648f0e2071871 (commit) from e88117b5fab293137bb74f57095a1ad1cdb7dbfa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e7c2a2031f470ab5e22d431bab7076dd0fd51654 Author: Galen Charlton Date: Sun May 4 18:41:33 2014 +0000 Bug 11763: (follow-up) do not display anything in actions column if user cannot manage a budget Signed-off-by: Galen Charlton commit 08e594f149a120d0b43e2c5795f1342290231e13 Author: Jonathan Druart Date: Mon Apr 14 13:11:12 2014 +0200 Bug 12019: ensure that it is optional to define an owner if a fund is restricted Before this patch, the C4::Budgets::CanUserUseBudget assumed that budget_owner_id was set if a restriction (budget_permission) exists. see && $budget->{budget_owner_id} && $budget->{budget_owner_id} != $borrower->{borrowernumber} Actually a restriction could exists on users and/or library without being forced to define an owner. Test plan: Create a fund A without restriction Create a fund B restricted to an owner Create a fund C restricted to a non defined owner Create a fund D restricted to owner and users (try defining/no defining an owner and/or users) Create a fund E restricted to owner, users and library (try defining/no defined an owner and/or users) With different logged in users, try to show/edit these differents funds. The restriction should be correctly applied. Signed-off-by: Katrin Fischer Tested various permission combinatons, visibility of funds is now ok. - not superlibrarian, no buget_manage_all, no owner, no users, no library, no restrictions on the fund = visible - changed: library = staff patron library, restriction = Owner, users and library = visible - changed: library = not staff patron library = invisible - changed: budget_manage_all = visible - changed: owner = staff patron no budget_manage_all = visible - changed: no owner, user = staff patron = visible - changed: no user, owner = another user, restriction = owner = invisible - changed: budget_manage_all = visible - changed: no budget_manage_all but superlibrarian = visible ... Passes tests and QA script, also t/Budgets/* Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 6b75d95680a28f68bdc50e2259a648f0e2071871 Author: Jonathan Druart Date: Wed Apr 2 13:27:08 2014 +0200 Bug 12019: FIX budget_owner_id node is duplicated The input witht the budget_owner_id id is duplicated. It breaks the jQuery selector $('#budget_owner_id').val(''); Signed-off-by: marjorie barry-vila Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 58 ++++++++++++++------ .../prog/en/modules/admin/aqbudgets.tt | 4 +- t/Budgets/CanUserModifyBudget.t | 14 ++--- t/Budgets/CanUserUseBudget.t | 14 ++--- 4 files changed, 56 insertions(+), 34 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun May 4 20:50:11 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 May 2014 18:50:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1042-g13fe2e0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 13fe2e013d88945aaa372f0c394a2464ca986786 (commit) via 0519c428ef2cede505e3eed1ae8220c57ef199cb (commit) from e7c2a2031f470ab5e22d431bab7076dd0fd51654 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13fe2e013d88945aaa372f0c394a2464ca986786 Author: Galen Charlton Date: Sun May 4 19:13:44 2014 +0000 Bug 11665: (follow-up) simplify code This patch replaces some of the logic with more direct Boolean expressions. Signed-off-by: Galen Charlton commit 0519c428ef2cede505e3eed1ae8220c57ef199cb Author: Jacek Ablewicz Date: Sun Feb 2 18:04:00 2014 +0100 Bug 11665: An ability to place orders directly from hold ratios list This enhancement introduces a possibility to place orders from hold ratios list: - new option "Add order to basket" -> "From titles w/ highest hold ratios"; (user gets redirected from acqusition to "hold ratios" list in circulation) - "N to order" in "Items needed" column now becomes a link - when clicked, user gets redirected back to acquisition, directly to order form for a choosen title (suggested quantity "N to order" is being preserved) - in the "Items needed" column, there is an additional indication if there are any pending (not yet received) orders for a given title This solution is not exactly ideal.. most important drawback: to use it librarian needs both acquisition & circulation priviledges; if not having both - new options will not show / wouldn't be active. But it requires relatively small amount of changes in the code. To test: - apply patch, - test new functions (try to place some orders using an newly added option, examine resulting order records etc.) - check modified hold ratios list for possible problems (for user with only circulation priviledges, additional information regarding pending orders should be still visible, but not the link to order form) - ensure the two following existing options for adding orders to basket ("From an existing record", "From a new (empty) record") a still working properly. Signed-off-by: Owen Leonard Minor edit in signoff: Changed "w/" to "with" Signed-off-by: Katrin Fischer This works nicely in my tests, neat new addition. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: acqui/neworderempty.pl | 9 +++++-- circ/reserveratios.pl | 28 ++++++++++++++++++++ .../en/includes/acquisitions-add-to-basket.inc | 1 + .../prog/en/modules/circ/reserveratios.tt | 7 ++++- 4 files changed, 42 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun May 4 21:04:46 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 May 2014 19:04:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1045-g454bef0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 454bef0b795ad5ab38b659b0366d9edd1f592dd7 (commit) via 0b672721995928bc47c2fe71a8de5ffe495cff5c (commit) via b99df4f7620d741ec71630db361aeda2cd975339 (commit) from 13fe2e013d88945aaa372f0c394a2464ca986786 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 454bef0b795ad5ab38b659b0366d9edd1f592dd7 Author: Jonathan Druart Date: Mon Mar 24 10:11:47 2014 +0100 Bug 10613: (follow-up) fix QA issues This patch fixes the following QA issue: FAIL acqui/invoice.pl FAIL valid Useless use of private variable in void context Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer Patch passes all tests and QA script. Specifically checked the t/db_depenedent/Acq* tests. A test plan could be: 0) Add a value in the gist pref (0.1 or 0.25 or something else easy). 1) a) Create a supplier "10613 0 0" with List item price includes tax: No Invoice item price includes tax: No Tax: 10% b) Create a supplier "10613 0 1" with List item price includes tax: No Invoice item price includes tax: Yes Tax: 10% c) Create a supplier "10613 1 0" with List item price includes tax: Yes Invoice item price includes tax: No Tax: 10% d) Create a supplier "10613 1 1" with List item price includes tax: Yes Invoice item price includes tax: Yes Tax: 10% 2) Create a basket for each supplier a) 00 List price: 10.00 (11.00 with 10% taxes) b) 01 List price: 10.00 (11.00 with 10% taxes) c) 10 List price: 10.00 (9.09 without taxes) d) 11 List price: 10.00 (9.09 without taxes) Note: Information on the basket page is shown correctly. If you look at the list of ordered items for the fund, the list price is used. 3) Create 1+ order(s) with 1+ item(s) for each basket with a discount and a gst value. 4) Close the baskets 5) Receive the items Left actual price as suggested: a) 00 Actual cost: 10.00 b) 01 Actual cost: 11.00 c) 10 Actual cost: 9.09 d) 11 Actual cost: 10.00 Calculations on the invoice page now all appear to be correct. Note: When you take a look at the 'ordered' list for the fund, the actual price is used as entered. 6) Go on acqui/invoice.pl?invoiceid=XX acqui/basket.pl?basketno=YY for each basket/invoice, click on the "Show all details" checkbox and verify that the values are all correct. Calculations are exactly the same for tax registered yes and no. Signed-off-by: Galen Charlton commit 0b672721995928bc47c2fe71a8de5ffe495cff5c Author: Jonathan Druart Date: Fri Oct 25 13:51:03 2013 +0200 Bug 10613: (follow-up) fix typo supplierid vs booksellerid GetInvoiceDetails returns a hashref with a key named booksellerid, not supplierid. The bookseller was not retrieved from the DB and the listincgst value was always false. Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit b99df4f7620d741ec71630db361aeda2cd975339 Author: Jonathan Druart Date: Fri Jul 19 11:44:51 2013 +0200 Bug 10613: calculate the GST rate correctly on the invoice page. Test plan: Defined a GST rate on creating an order, receive it and check that all prices are correctly calculated. /!\ Behavior change function of supplier parameters (Include/Don't include tax for list prices and invoice prices) Notes: patch tested with Bug 11755 applied first; confirmed that: - price calculations are correct for all combinations of listincgst/invoiceincgst settings in the vendor record - unitprice (aka "Actual cost") is taken into account on the invoice page instead of rrp/ecost, like it should. Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: acqui/invoice.pl | 138 ++++++++------------ .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 98 +++++++++----- 2 files changed, 121 insertions(+), 115 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun May 4 23:32:37 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 May 2014 21:32:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1073-gbbd3db8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bbd3db8c84af321485d93352ee6ccb83a96b61be (commit) via 3db3c984d14113ddc6d9926bcd2ee34fab8c3de5 (commit) via bfb88cc4e0bd5fe62a46ec9c617690dd3099c878 (commit) via b8340153c4098aba6c85479f5d9f267b1e7af070 (commit) via 01fb9837d760d76365cca805fb082ae023cd8c26 (commit) via 8c1112eb1edf5f510372f53ca16c08fa8c0a1bcb (commit) via e4e058decf80426a0547925313df431cb45b7aa5 (commit) via cfcf15eee2283e9f66d854d0f05176759ccc9189 (commit) via dbd45fc4c90f4c0b513989f61d9f444ae4b3a6a1 (commit) via e7ef292577cc626a6b5066008b841e815ea66c1e (commit) via 953c9d511bf94f3904541feb81568b893505bb1a (commit) via dee6710fc80b54eb673e09b056534dbef5e31866 (commit) via 5d69ebdc4cf2108073881cce3382f570ed76208e (commit) via 061ab30ac1abbcb55451b98a1b10a74f354a764d (commit) via 271b48bfd3f24686c5cae31d094d8543d8e53981 (commit) via 3e211aa2a8b91b38eb38fa214973fc18e7bea2cf (commit) via bde00182377905170d49ad230de197086fb489e1 (commit) via 0d40dda9bc060b1d5e8281a014633eb87c5cee25 (commit) via a6affb44e29aa1d71875865bcfc821fcc4f22cea (commit) via 511113ce89d7cf9e784ba344d6ae55e7174acc0e (commit) via 9eee2b508853a22e9baf26122de537e5cabf0a18 (commit) via b9619a485efbb209fecbf6bc7bb8b0ecd7091c98 (commit) via 9997918f0209408fedfee99bd41a9e38cc508d47 (commit) via 4924f7bd59f5d7713cd5aa0ca09a3fc405285062 (commit) via 59bd868c98f700551bb6c1b56df03ab269a9601e (commit) via 3c8c0591e2344ba6e44df16319b47065d23d652e (commit) via f87f2579d237a258179be5b1442ed693a0caef34 (commit) via 2f2d7b9368fc5d8c9a14b4ffb4f441b2128dbef4 (commit) from 454bef0b795ad5ab38b659b0366d9edd1f592dd7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bbd3db8c84af321485d93352ee6ccb83a96b61be Author: Galen Charlton Date: Sun May 4 21:55:02 2014 +0000 Bug 10875: (follow-up) make displaying/hiding inactive funds work cross-browser This uses the idea introduced by the patch for bug 8659 by Maxime Pelletier. Signed-off-by: Galen Charlton commit 3db3c984d14113ddc6d9926bcd2ee34fab8c3de5 Author: Galen Charlton Date: Sun May 4 21:29:41 2014 +0000 Bug 7180: (follow-up) restore ability to select bibs in middle of import batch This patch repairs the JavaScript that selectively removes unselected bibs from the form submission, fixing a problem where selecting bibs from the middle or end of the list would cause them to be ordered without the appropriate quantities, funds, and prices. Signed-off-by: Galen Charlton commit bfb88cc4e0bd5fe62a46ec9c617690dd3099c878 Author: Galen Charlton Date: Sun May 4 21:12:33 2014 +0000 Bug 7180: (follow-up) fix regression on bug 6074 This patch ensures that bibs selected for ordering are marked as imported in their import batch. Signed-off-by: Galen Charlton commit b8340153c4098aba6c85479f5d9f267b1e7af070 Author: Galen Charlton Date: Sun May 4 21:06:50 2014 +0000 Bug 7180: (follow-up) fix warnings This patch fixes some warnings (not introduced by the main patches) regarding fetching the number of bibs in a batch and fetching the list of batches. Signed-off-by: Galen Charlton commit 01fb9837d760d76365cca805fb082ae023cd8c26 Author: Jonathan Druart Date: Fri Apr 25 11:14:00 2014 +0200 Bug 10875: (follow-up) preselect the fund located in the record It is useless to copy the fund list in a new node. It seems easier to hide/show inactive/active funds. This patch also adds a "(inactive)" marker in the fund list for inactive funds. If the fund located in the record is inactive, it is displayed by default and cannot be hidden. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 8c1112eb1edf5f510372f53ca16c08fa8c0a1bcb Author: Jonathan Druart Date: Wed Sep 11 10:01:34 2013 +0200 Bug 10875: ensure adding order from a staged file does not display inactive funds by default When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as described. - Loading the page, a fund needs to be selected. Before the patch the first fund was preselected. - Checking the checkbox, inactive funds show up, but are not visible otherwise. - If the fund is selected from the MARC file, the correct fund will be selected, even if it's inactive. Signed-off-by: Galen Charlton commit e4e058decf80426a0547925313df431cb45b7aa5 Author: Galen Charlton Date: Sun May 4 20:14:09 2014 +0000 Bug 7180: (follow-up) require an authenticated session to use the AJAX authval dropbox Signed-off-by: Galen Charlton commit cfcf15eee2283e9f66d854d0f05176759ccc9189 Author: Galen Charlton Date: Sun May 4 20:06:39 2014 +0000 Bug 7180: (follow-up) point to new location of the jQuery checkboxes plugin Signed-off-by: Galen Charlton commit dbd45fc4c90f4c0b513989f61d9f444ae4b3a6a1 Author: Galen Charlton Date: Sun May 4 20:01:10 2014 +0000 Bug 7180: DBRev 3.15.00.043 Signed-off-by: Galen Charlton commit e7ef292577cc626a6b5066008b841e815ea66c1e Author: Galen Charlton Date: Sun May 4 20:00:04 2014 +0000 Bug 7180: (follow-up) use "MARC record" instead of "marcrecord" Signed-off-by: Galen Charlton commit 953c9d511bf94f3904541feb81568b893505bb1a Author: Jonathan Druart Date: Wed Apr 23 09:56:26 2014 +0200 Bug 7180: (follow-up) reset statistic values on reloading the page On the "Default accounting details", if a dropdown list was created for a statistic value, on reloading the page it still exist. It should not given the fund value is reset. The CGIsort variable is useless and can be remove: the dropdown list is generated using the ajax call. Signed-off-by: Galen Charlton commit dee6710fc80b54eb673e09b056534dbef5e31866 Author: Jonathan Druart Date: Wed Apr 16 11:01:24 2014 +0200 Bug 7180: (follow-up) fix various issues 1/ showmarc.pl takes the importid for staged files. 2/ small note to indicate that the vendor's discount will be used if no discount is filled. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 5d69ebdc4cf2108073881cce3382f570ed76208e Author: Jonathan Druart Date: Tue Apr 15 16:31:18 2014 +0200 Bug 7180: (follow-up) fix various issues * fix calculation of discount * add CSS for unselected rows * fix Javascript error * correct capitalization * use ?Statistic? instead of ?Planning value? * improve description of system preference Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 061ab30ac1abbcb55451b98a1b10a74f354a764d Author: Jonathan Druart Date: Thu Mar 6 17:19:20 2014 +0100 Bug 7180: (follow-up) remove disused script fetch_sort_dropbox.pl Test plan: git grep fetch_sort_dropbox should return no result. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 271b48bfd3f24686c5cae31d094d8543d8e53981 Author: Jonathan Druart Date: Fri Sep 27 16:42:44 2013 +0200 Bug 7180: (followup) fix case where discount was divided by 100 twice. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 3e211aa2a8b91b38eb38fa214973fc18e7bea2cf Author: Jonathan Druart Date: Mon Sep 16 12:45:52 2013 +0200 Bug 7180: (follow-up) remove useless rrp variable Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit bde00182377905170d49ad230de197086fb489e1 Author: Jonathan Druart Date: Thu Sep 12 14:59:56 2013 +0200 Bug 7180: (follow-up) restore the "Add order" link Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 0d40dda9bc060b1d5e8281a014633eb87c5cee25 Author: Kyle M Hall Date: Thu Sep 12 08:35:41 2013 -0400 Bug 7180: (follow-up) correct minor language issues Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit a6affb44e29aa1d71875865bcfc821fcc4f22cea Author: Jonathan Druart Date: Thu Sep 12 11:44:25 2013 +0200 Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 511113ce89d7cf9e784ba344d6ae55e7174acc0e Author: Jonathan Druart Date: Wed Sep 11 09:35:16 2013 +0200 Bug 7180: (follow-up) update license version Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 9eee2b508853a22e9baf26122de537e5cabf0a18 Author: Jonathan Druart Date: Tue Sep 10 10:31:11 2013 +0200 Bug 7180: make neworderempty code use getAuthValueDropbox. The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link authorized values to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit b9619a485efbb209fecbf6bc7bb8b0ecd7091c98 Author: Jonathan Druart Date: Tue Sep 10 10:30:25 2013 +0200 Bug 7180: (follow-up) change syspref description - the blank line is now useless - add an example for the syspref value Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 9997918f0209408fedfee99bd41a9e38cc508d47 Author: Katrin Fischer Date: Mon Sep 9 22:53:49 2013 +0200 Bug 7180: (follow-up) fix minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 4924f7bd59f5d7713cd5aa0ca09a3fc405285062 Author: Jonathan Druart Date: Mon Jul 15 10:05:06 2013 +0200 Bug 7180: (follow-up) ensure that the default quantity is 1 Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 59bd868c98f700551bb6c1b56df03ab269a9601e Author: Jonathan Druart Date: Mon Jul 1 15:59:14 2013 +0200 Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 3c8c0591e2344ba6e44df16319b47065d23d652e Author: Jonathan Druart Date: Thu Mar 21 13:27:39 2013 +0100 Bug 7180: Add UT for C4::Budgets::GetBudgetByCode Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit f87f2579d237a258179be5b1442ed693a0caef34 Author: Jonathan Druart Date: Wed Mar 20 12:32:07 2013 +0100 Bug 7180: (follow-up) fix getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 2f2d7b9368fc5d8c9a14b4ffb4f441b2128dbef4 Author: Jonathan Druart Date: Thu Mar 8 17:25:06 2012 +0100 Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 Ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviour still exists. But now you can *select* which records you want to ordered. For these ones you can specify independently quantity, price, budget, sort1 and sort2. The cherry on the cake is that you can pre-fill these fields with values from the MARC record. Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, fields should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 26 + acqui/addorderiso2709.pl | 206 ++++--- acqui/ajax-getauthvaluedropbox.pl | 84 +++ acqui/fetch_sort_dropbox.pl | 107 ---- acqui/neworderempty.pl | 35 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 + .../intranet-tmpl/prog/en/css/staff-global.css | 6 + koha-tmpl/intranet-tmpl/prog/en/js/acq.js | 94 +--- .../prog/en/modules/acqui/addorderiso2709.tt | 579 ++++++++++++-------- .../prog/en/modules/acqui/neworderempty.tt | 59 +- .../en/modules/admin/preferences/acquisitions.pref | 7 +- kohaversion.pl | 2 +- t/db_dependent/Budgets.t | 16 +- 14 files changed, 672 insertions(+), 557 deletions(-) create mode 100755 acqui/ajax-getauthvaluedropbox.pl delete mode 100755 acqui/fetch_sort_dropbox.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun May 4 23:58:42 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 May 2014 21:58:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1078-gf13c72e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f13c72ebee0d6312512b88cd1c61e24b4e181902 (commit) via 11b9bd0f4a62ec690abd675cfabeef7705605439 (commit) via 95e14edc1c8815e9a46eec3c9355420eb3203603 (commit) via 8d5c38fd4760f804515b13b7f79b9a5dbfff988b (commit) via 94d3aed746b8f925dd8832b104137741415b886c (commit) from bbd3db8c84af321485d93352ee6ccb83a96b61be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f13c72ebee0d6312512b88cd1c61e24b4e181902 Author: Galen Charlton Date: Sun May 4 22:21:17 2014 +0000 Bug 9593: (follow-up) don't make currency.isocode required This patch changes the price parsing so that it can fall back on the currency name if an ISO code is not supplied; this allows for handling the very common situation where the currency name as entered was already the same as the ISO code. Signed-off-by: Galen Charlton commit 11b9bd0f4a62ec690abd675cfabeef7705605439 Author: Galen Charlton Date: Sun May 4 22:05:31 2014 +0000 Bug 9593: update DBIC files Signed-off-by: Galen Charlton commit 95e14edc1c8815e9a46eec3c9355420eb3203603 Author: Galen Charlton Date: Sun May 4 22:04:14 2014 +0000 Bug 9593: DBRev 3.15.00.044 Signed-off-by: Galen Charlton commit 8d5c38fd4760f804515b13b7f79b9a5dbfff988b Author: Kyle M Hall Date: Tue Apr 22 07:13:19 2014 -0400 Bug 9593: (QA Followup) - use "ISO" instead of "iso" - move hint text Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 94d3aed746b8f925dd8832b104137741415b886c Author: Lyon3 Team Date: Tue Apr 15 12:13:05 2014 +0200 Bug 9593: improve parsing of prices from staged files Initial bug : When there's a round price with no decimals after it, or when the symbol is after the digits, the price is not captured by regular expression in MungeMarcPrice routine and the variable is not initialized. Enhancement : The MungeMarcPrice routine had been widely modified. It's still possible to priority pick the active currency but unlike the previous mechanism that worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string including it like '$US'. Moreover, an 'isocode' column had been added in currency table (editable in the staffo interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests, especially t/db_dependent/MungeMarcPrice.t Checked currencies can be added, edited and deleted. Notes: new ISO code field is mandatory. Sample sql files need to be updated (bug 12146) Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 76 ++++++++++++-------- Koha/Schema/Result/Currency.pm | 12 +++- admin/currency.pl | 7 +- installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 ++ .../prog/en/modules/admin/currency.tt | 18 ++++- kohaversion.pl | 2 +- t/db_dependent/MungeMarcPrice.t | 74 +++++++++++++++++++ 8 files changed, 160 insertions(+), 37 deletions(-) create mode 100755 t/db_dependent/MungeMarcPrice.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 00:52:17 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 May 2014 22:52:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1088-gea543fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ea543fdee0ce6c3b43386536d51b56f0c5f92036 (commit) via 781bedff8d5673aa9a66999ae04668e2f503d117 (commit) via eade80277fb316096e5af7159816d1ab7b0cfcaa (commit) via 82db730d71c0f96b2dbf5ec0f4321b2cf6045593 (commit) via cfcdc1c4dd30f38d7faf5134c46f23114ce7dae3 (commit) via e33a016a1c56682e984d763653c0aacd6645c037 (commit) via 14def333db6a6533f0756878e75a87531d25a3d3 (commit) via f6defdf25acb6c7be9c25f8e18e5126e5bb0874c (commit) via 915788ff778113e76b6efff07bb8c4d9a47ba7c8 (commit) via 0514a7483cbc39f4572ceb0d6b7a4d8243631855 (commit) from f13c72ebee0d6312512b88cd1c61e24b4e181902 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ea543fdee0ce6c3b43386536d51b56f0c5f92036 Author: Galen Charlton Date: Sun May 4 23:11:34 2014 +0000 Bug 766: (follow-up) improve usage comments in new TT include Signed-off-by: Galen Charlton commit 781bedff8d5673aa9a66999ae04668e2f503d117 Author: Galen Charlton Date: Sun May 4 23:10:17 2014 +0000 Bug 766: (follow-up) point acqui/ajax-getauthvaluedropbox.pl at the new location of GetAuthvalueDropbox Signed-off-by: Galen Charlton commit eade80277fb316096e5af7159816d1ab7b0cfcaa Author: Galen Charlton Date: Sun May 4 23:08:03 2014 +0000 Bug 766: (follow-up) move copyright statement back to the top Signed-off-by: Galen Charlton commit 82db730d71c0f96b2dbf5ec0f4321b2cf6045593 Author: Jonathan Druart Date: Wed Apr 23 15:45:46 2014 +0200 Bug 766: Update POD for AuthorisedValues TT plugin Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit cfcdc1c4dd30f38d7faf5134c46f23114ce7dae3 Author: Jonathan Druart Date: Tue Apr 22 13:30:01 2014 +0200 Bug 766: (follow-up) fix encoding issues This patch deals with the current master code. It should be removed when patches for bug 11944 will be pushed. Signed-off-by: Bernardo Gonzalez Kriegel No side effects. Signed-off-by: Katrin Fischer Fixes encoding problem, until this can be resolved properly. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit e33a016a1c56682e984d763653c0aacd6645c037 Author: Jonathan Druart Date: Mon Mar 17 12:36:55 2014 +0100 Bug 766: Use a TT include instead of a method in the AV plugin Signed-off-by: Bernardo Gonzalez Kriegel This gives a koha-qa error, but on another user/env not. Really don't know Signed-off-by: Katrin Fischer I see the same error, but can't see where this is coming from, code seems to work ok. Works as described, no regressions found. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 14def333db6a6533f0756878e75a87531d25a3d3 Author: Jonathan Druart Date: Thu Mar 6 17:12:26 2014 +0100 Bug 766: remove disused routine buildCGISort buildCGISort can be deleted. Test plan: git grep buildCGISort should return no result. Signed-off-by: Bernardo Gonzalez Kriegel No more buildCGISort Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit f6defdf25acb6c7be9c25f8e18e5126e5bb0874c Author: Jonathan Druart Date: Thu Mar 6 17:08:37 2014 +0100 Bug 766: Use the new plugin to generate sort dropdown list - memberentry Now we can use the method plugin from the memberentry form. Test plan: 1/ Create a patron and verify sort1 and sort2 dropdown list are correctly generated. 2/ Select values. 3/ Save. 4/ Edit the patron and verify the selected values are displayed. Signed-off-by: Bernardo Gonzalez Kriegel Works as described. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 915788ff778113e76b6efff07bb8c4d9a47ba7c8 Author: Jonathan Druart Date: Thu Mar 6 17:07:08 2014 +0100 Bug 766: Create a plugin routine to build dropdown list On this way, dropdown list could be generated from the templates. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 0514a7483cbc39f4572ceb0d6b7a4d8243631855 Author: Jonathan Druart Date: Thu Mar 6 17:05:53 2014 +0100 Bug 766: Move GetAuthvalueDropbox to C4::Koha GetAuthvalueDropbox is in C4::Budgets, this does not make sense. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 40 ----------- C4/Input.pm | 53 -------------- C4/Koha.pm | 38 ++++++++++ Koha/Template/Plugin/AuthorisedValues.pm | 75 +++++++++++++------- acqui/ajax-getauthvaluedropbox.pl | 4 +- admin/aqplan.pl | 1 - .../prog/en/includes/av-build-dropbox.inc | 29 ++++++++ .../prog/en/modules/members/memberentrygen.tt | 16 ++--- members/memberentry.pl | 14 +--- 9 files changed, 125 insertions(+), 145 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 01:00:52 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 May 2014 23:00:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1090-gc221194 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c221194a94d42d44057c33bfe47957dca15f3415 (commit) via 24dd5ea3d21caf3018525ea69c5f03d5ebeb44d3 (commit) from ea543fdee0ce6c3b43386536d51b56f0c5f92036 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c221194a94d42d44057c33bfe47957dca15f3415 Author: Galen Charlton Date: Sun May 4 23:24:06 2014 +0000 Bug 11466: (follow-up) add additional test This adds an additional test case to document the behavior that if AdvancedSearchTypes contains 'itemtypes' or /is/ 'itemtypes', that it returns the same results. Signed-off-by: Galen Charlton commit 24dd5ea3d21caf3018525ea69c5f03d5ebeb44d3 Author: Olli-Antti Kivilahti Date: Thu Jan 2 10:21:49 2014 +0200 Bug 11466: improve selection of item types for purchase order desired format list This patch ensures that the list of desired formats for a purchase suggestion includes the list of item types so long as the AdvancedSearchTypes system preference includes 'itemtypes'. -------------- -- Synopsis -- -------------- When system preference AdvancedSearchTypes has other values than 'itemtypes', for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl is not populated with available itemtypes. This patch fixes the issue by broadening the strict comparison of ($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc' to ($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc' Unit tests included --------------- -- Test plan -- --------------- REPLICATING THE ISSUE 1. Set system preference AdvancedSearchTypes to itemtypes|loc 2. Go to opac-suggestions.pl and observe Item type dropdown list 2.1. List should have itemtypes available for selection Signed-off-by: Nicole C. Engard Tests worked as expected. Placed a suggestion and saw the whole list of item types, chose one, saved, checked staff and it loaded as expected. Changed item type in staff and it applied in both views. Signed-off-by: Katrin Fischer Works as described, passes all tests including new regression tests. Restores old functionality. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 2 +- t/db_dependent/Suggestions.t | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 02:17:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 00:17:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1091-g16cd299 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 16cd2996a484b2105d66043855c36d5e13a82987 (commit) from c221194a94d42d44057c33bfe47957dca15f3415 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 16cd2996a484b2105d66043855c36d5e13a82987 Author: Lyon3 Team Date: Mon Jan 13 12:09:01 2014 +0100 Bug 8231: display warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late. Test plan : 1) Apply the patch 2) Go to a borrower checkout page and checkout some documents with different passed duedate using "Specify due date" function. Checkout out one with the default duedate. 3) Check in the document with the bigger delay : You will get the message : 'X is now restricted until ...' 4) Check in one of the document with a smaller delay : You'll get a different message : 'Reminder : Patron was earlier restricted until...'. 5) Check in the document which is not late : You 'll get the same message as the previous one Signed-off-by: JMBroust Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 24 ++++++++++++++++---- circ/returns.pl | 3 +++ .../intranet-tmpl/prog/en/modules/circ/returns.tt | 3 +++ 3 files changed, 25 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 02:21:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 00:21:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1092-g700568b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 700568bb894b2810b093d51e9aa83a56174eed98 (commit) from 16cd2996a484b2105d66043855c36d5e13a82987 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 700568bb894b2810b093d51e9aa83a56174eed98 Author: Tomas Cohen Arazi Date: Thu Apr 24 14:19:52 2014 -0300 Bug 11117: Fix text mixup in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows properly. To reproduce: - Have facets to show some right to left text (example on the bug report) in English language templates. - Enable the displayFacetCount. - Check it displays like the attached screenshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Still work as described. Checked in Arabic with Arabic records. No koha-qa errors Signed-off-by: Katrin Fischer Passes all tests and QA script. Confirmed bug and that the patch fixes it, tested in staff, prog, ccsr and bootstrap. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 4 ++++ koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 12 ++++++++++-- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 8 ++++---- koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 4 ++++ koha-tmpl/opac-tmpl/ccsr/en/css/opac.css | 4 ++++ koha-tmpl/opac-tmpl/prog/en/css/opac.css | 4 ++++ koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc | 10 +++++++++- 8 files changed, 40 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 02:35:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 00:35:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1095-gb2ba10b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b2ba10b40b1f5fa379e28284e3a629e5657d18fc (commit) via 9f45310d761c85167ff23d8cc217d513138a6ea5 (commit) via 84805701972fc6d580e40105f755613b4136b981 (commit) from 700568bb894b2810b093d51e9aa83a56174eed98 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b2ba10b40b1f5fa379e28284e3a629e5657d18fc Author: Jonathan Druart Date: Mon Jan 27 14:45:21 2014 +0100 Bug 11278: (follow-up) Return an exit value (1) if the module is not found. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 9f45310d761c85167ff23d8cc217d513138a6ea5 Author: Marcel de Rooy Date: Mon Nov 25 14:24:42 2013 +0100 Bug 11278: Followup for customize command line parameter The initial patch for this bug did not include a specific command line option for customization. If a module LocalChanges.pm existed, it would be used without asking. This patch adds a command line option enabling the customization option and offering the extra possibility of using another module name. If no file name is passed, we default to LocalChanges. Without the -custom option, behavior is as it was. Also some POD lines are added to document the feature. Test plan: [1] Make a LocalChanges.pm in migration_tools. Verify that it is not used, if you do not enable the -cust parameter. [2] Run the script again with -cust. Verify that it is called now. [3] Copy LocalChanges.pm to Whatever.pm. Make some change. Run with -cust Whatever and verify that the new module is used. [4] Copy Whatever.pm to another dir, make some change. Run with -cust and the full name. Verify that the latest change was used. [5] Run without any option. Check the pod documentation. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 84805701972fc6d580e40105f755613b4136b981 Author: Marcel de Rooy Date: Thu Nov 21 11:29:59 2013 +0100 Bug 11278: Adjusting bulkmarcimport.pl for customization routine and verbose printing This patch makes two adjustments: [1] For the verbose option, verbose level 2 now means print the formatted version of each record. [2] If a module LocalChanges.pm is found in misc/migration_tools, the routine "customize" in this module is called for each marc record. This allows you to make local changes to these marc records before importing them. Test plan: [1] Test the verbose option: a single -v for medium verbosity and two -v to dump a human-readable version of the record to standard output. (Do not yet copy LocalChanges.pm in the folder.) You may used the attached example file on Bugzilla: perl misc/migration_tools/bulkmarcimport.pl -file zztest01.xml -v -v -b -m XML -t | more Note the option t for test; no records will be imported. [2] Copy LocalChanges.pm in the migration_tools folder. You may use the example provided on Bugzilla (in a patch). If you use the example module, check the contents of 001, 005 and 590 fields. (The -v -v option allows you to easily check that.) Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: misc/migration_tools/bulkmarcimport.pl | 39 ++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 03:06:03 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 01:06:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1099-g53114f0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 53114f0b21cd2f80947bec44a04a7c30cf118e57 (commit) via 9fe024667f03077cd9e07f3bcb0c7353d4e3cf4f (commit) via ebcb64e9fa51fd7f02918d9543abeeac4f8ab46d (commit) via 99dbc5cdf7d7e4d9e83378fbf4d0fb5d5c2de38e (commit) from b2ba10b40b1f5fa379e28284e3a629e5657d18fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 53114f0b21cd2f80947bec44a04a7c30cf118e57 Author: Galen Charlton Date: Mon May 5 01:30:45 2014 +0000 Bug 7442: (follow-up) apply change to Bootstrap theme Signed-off-by: Galen Charlton commit 9fe024667f03077cd9e07f3bcb0c7353d4e3cf4f Author: Galen Charlton Date: Mon May 5 01:27:33 2014 +0000 Bug 7442: (follow-up) restore display of heading type for non-UNIMARC This patch restores the display of the authority type summary for MARC21, where at present the heading type (i.e., "Topical Term", "Personal Names") come over for display in the template. Signed-off-by: Galen Charlton commit ebcb64e9fa51fd7f02918d9543abeeac4f8ab46d Author: Fridolyn SOMERS Date: Thu Jul 18 18:13:12 2013 +0200 Bug 7442 (follow-up) ensuring that summary is display when searching on all types of authorities This patch corrects a small bug : Authorities search on all types does not show summary because it is computed with selected type (which is empty) instead of using found authority type. Test plan : - Go to intranet autorities search - Perform a search on all authorities types - Look at results => Without this patch, results rows do not display the autority summary, only authorized headings Signed-off-by: Fr?d?ric Demians Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 99dbc5cdf7d7e4d9e83378fbf4d0fb5d5c2de38e Author: Fridolyn SOMERS Date: Thu Jul 18 13:59:07 2013 +0200 Bug 7442: fix crash when selecting an authority with 200$x or 200$y (UNIMARC) From a biblio record, if one wants to add a 600$a information, a pop-up appears. On this new window, on search terms typed and validated, a table result is displayed, with a column "Get It!" allowing the selection of an authority. From here, different cases: 1) If we have a simple authority with 200$a and 200$b subfields, a link "choose" is displayed, working correctly. 2) If the authority has different occurences of 200$a/200$b, numeric links (1 2 and so on) are displayed, one for each occurence. In the example of my screenshot, the line with a "Paul, Korky -- Pauline, Korkette" summary possesses two links : "1" will add "Paul, Korky" whereas "2" will add "Pauline, Korkette" (couldn't come up with a better name ;)). 3) If the authority has 200$x or 200$y subfields defined, several links are also created, when it should not be the case. In our example, "Niclausse, Paul -- Expositions" will create a link "1" for "Niclausse, Paul" and a link "2" for "Expositions". Clicking on the 2nd link leads to the following error: Software error: Can't call method "subfields" on an undefined value at /home/asaurat/workspace/versions/community/authorities/blinddetail-biblio-search.pl line 86. Only the cases 1 and 2 should be handled. The creation of links for subfields like 200$x or 200$y should be removed. This problem is caused by the use of " -- " has separator of authorities with several headings, but also in some heading between main part and subdivisions. This patch corrects this by using an array in authorities summary so that presentation is computed in template. I've choosen to use the pipe separator between authorities with several headings. This may be changed to be configurable. Test plan : - Edit an authority type summary : for example subject (heading on 250) : summary "[250a][ -- 250x]" - Create an authority A1 with one heading and a subdivision : for example a subject : 250$a "History" 250$x "20th century" - Create an authority A2 with several headings. for example a subject : 250$a "History" 250$a "Legends" - Rebuild Zebra queue - Go to OPAC and click on "Authority search" and search on "History" => You will find A1 and A2 : History -- 20th century History | Legends - Go to intranet autorities search and search on "History" => You will find A1 and A2 : History -- 20th century History | Legends - Edit a record using this autorities type as thesaurus : for example on 606$a - Click on thesaurus link and search on "History" => You will find A1 and A2 : History -- 20th century ; 0 times ; choose ; Edit authority History | Legends ; 0 times ; 1 2 ; Edit authority - Click on link "2" to chosse "Legends" => You get "Legends" in heading field : for example 606$a Signed-off-by: Fr?d?ric Demians I can confirm the problem and the solution. I have tested the patch on a large DB with authorities having multiples headings. There is no regression on bug 4838. Signed-off-by: Katrin Fischer Passes all tests and QA script. Without the patch I couldn't choose between multiple headings in the authority plugin, but with the patch it works as described. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 37 ++++++++++++-------- authorities/auth_finder.pl | 14 -------- .../en/includes/authorities-search-results.inc | 9 ++++- .../modules/authorities/searchresultlist-auth.tt | 6 ++-- .../en/includes/authorities-search-results.inc | 9 ++++- .../en/includes/authorities-search-results.inc | 9 ++++- 6 files changed, 49 insertions(+), 35 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 03:58:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 01:58:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1112-ge56e27f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e56e27f5640f246e9baaa871bd121e03c22a7772 (commit) via 275e389afb9703504847e40dcd6567c883cf8a1a (commit) via ed30c16dc2e26a63a9349060e80cd62b55017450 (commit) via 626f6c63a14b2d58c1088e336d138997ae225b2f (commit) via c1673f2db842d3d8f92df242878b9ef155e8efda (commit) via 4db91211aa1a4a0a06d63315d6de043e5a93fa89 (commit) via fd3985eb6c94e06007ec0af364ae672e766775b1 (commit) via b1b0d88e114357a7bb4adb6d1a55c7dd767796c1 (commit) via 25b2cd1c6526b10bc6a726c4ef8296b87a38de02 (commit) via b1451ab1273bc8039d8b85c83422dc1c29db385d (commit) via 6ae5a267bc011a0fbecb91f98192582ed868ffd2 (commit) via 42c829837cef09fa5449ec415ec2926784830ddb (commit) via 80b7a8153dca1bc8f97976e3686c6527766deef3 (commit) from 53114f0b21cd2f80947bec44a04a7c30cf118e57 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e56e27f5640f246e9baaa871bd121e03c22a7772 Author: Galen Charlton Date: Mon May 5 02:12:40 2014 +0000 Bug 6739: (follow-up) tweak wording Signed-off-by: Galen Charlton commit 275e389afb9703504847e40dcd6567c883cf8a1a Author: Galen Charlton Date: Mon May 5 02:07:32 2014 +0000 Bug 6739: (follow-up) add unit tests for GetMemberDetails()->{is_expired} Signed-off-by: Galen Charlton commit ed30c16dc2e26a63a9349060e80cd62b55017450 Author: Galen Charlton Date: Mon May 5 02:00:36 2014 +0000 Bug 6739: (follow-up) update DBIC schema classes Signed-off-by: Galen Charlton commit 626f6c63a14b2d58c1088e336d138997ae225b2f Author: Galen Charlton Date: Mon May 5 01:57:56 2014 +0000 Bug 6739: (follow-up) do NOT activate new feature by default during upgrade The previous behavior falls in the category of (arguably) buggy behavior that nonetheless should not be silently changed on the folks who would have to deal with patron complaints. Signed-off-by: Galen Charlton commit c1673f2db842d3d8f92df242878b9ef155e8efda Author: Galen Charlton Date: Mon May 5 01:57:34 2014 +0000 Bug 6739: DBRev 3.15.00.045 Signed-off-by: Galen Charlton commit 4db91211aa1a4a0a06d63315d6de043e5a93fa89 Author: Jonathan Druart Date: Wed Jan 15 11:53:56 2014 +0100 Bug 6739: (follow-up) template changes for the bootstrap theme Signed-off-by: Katrin Fischer Passes QA script, t, xt and t/db_dependent/Members*. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default! * Ran database update succesfully. * Note: Expired patrons are now blocked by default in new AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block f) category: don't block syspref: don't block Holds and renewals were always possible. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Verified holds and renewals are still blocked, when the user has a restriction with a date in the future. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) Holds and renewals blocked. b) category: use syspref (default) syspref: don't block Holds an renewals possible. c) category: block syspref: don't block Holds and renewals blocked. d) category: block syspref: block Holds and renewals blocked. e) category: don't block sypref: block Holds and renewals possible. f) category: don't block syspref: don't block Holds and renewals possible. Signed-off-by: Galen Charlton commit fd3985eb6c94e06007ec0af364ae672e766775b1 Author: Jonathan Druart Date: Wed Jan 15 11:38:38 2014 +0100 Bug 6739: (follow-up) fix conflicts with some others bugs. See comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit b1b0d88e114357a7bb4adb6d1a55c7dd767796c1 Author: Katrin Fischer Date: Sun Sep 22 16:20:19 2013 +0200 Bug 6739: (follow-up) yet more fixes - Fixes a typo in one of the OPAC messages: "you account" - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization "Don't Block" in system preference description. - Adding . to the end of the warning, when renewals are blocked. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 25b2cd1c6526b10bc6a726c4ef8296b87a38de02 Author: Fridolyn SOMERS Date: Thu Jul 11 12:39:16 2013 +0200 Bug 6739: (follow-up) more fixes Some corrections : - opac-reserve.tt : opening

instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : instead of , maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. Signed-off-by: Katrin Fischer 2014-04-06 Update: Will repeat and amend above test plan on last patch in this series. Signed-off-by: Galen Charlton commit b1451ab1273bc8039d8b85c83422dc1c29db385d Author: Fridolyn SOMERS Date: Thu Jul 11 11:27:51 2013 +0200 Bug 6739: (follow-up) fix more issues Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces "opac actions such as placing a hold or reserve" by "opac actions such as placing holds or renrw books" - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo "categori" and syspref name case Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 6ae5a267bc011a0fbecb91f98192582ed868ffd2 Author: Kyle M Hall Date: Wed Jan 15 11:08:48 2014 +0100 Bug 6739: (follow-up) fix more issues * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 42c829837cef09fa5449ec415ec2926784830ddb Author: Kyle M Hall Date: Tue Mar 12 13:46:41 2013 -0400 Bug 6739: (follow-up) fix various issues - translation issues - wording issues Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 80b7a8153dca1bc8f97976e3686c6527766deef3 Author: Chris Hall Date: Mon Feb 20 10:07:13 2012 +1300 Bug 6739: make it possible to block expired patrons from OPAC actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the OPAC 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the OPAC 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the OPAC 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the OPAC Signed-off-by: Kyle M Hall Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Testing notes on last patch in series. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 34 +++++++- Koha/Schema/Result/Category.pm | 12 ++- admin/categorie.pl | 81 +++++++++++++++++--- installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/sysprefs.sql | 3 +- installer/data/mysql/updatedatabase.pl | 20 ++++- .../prog/en/modules/admin/categorie.tt | 24 ++++++ .../prog/en/modules/admin/preferences/opac.pref | 6 ++ .../prog/en/modules/admin/preferences/patrons.pref | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 + .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 35 +++++++-- .../opac-tmpl/prog/en/modules/opac-reserve.tt | 3 + koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 52 +++++++++---- kohaversion.pl | 2 +- opac/opac-renew.pl | 66 +++++++++------- opac/opac-reserve.pl | 12 +++ opac/opac-user.pl | 18 +++-- t/db_dependent/Members.t | 9 ++- 18 files changed, 311 insertions(+), 73 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 04:01:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 02:01:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1113-gbd65c6e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bd65c6e95b538c072cecd688f20a9adcfe2cc4e5 (commit) from e56e27f5640f246e9baaa871bd121e03c22a7772 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd65c6e95b538c072cecd688f20a9adcfe2cc4e5 Author: Fridolin Somers Date: Wed Jan 29 17:26:15 2014 +0100 Bug 11635: remove duplicate definition of 995$r in UNIMARC record.abs Test plan : - Create a fresh install UNIMARC flavor and GRS1 indexing for biblios - Re-indexe database - Perform a search with index "itemtype" (and then "itype") on an existing value of 995$r. For example : itemtype:BOOK => Check you get results Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: etc/zebradb/marc_defs/unimarc/biblios/record.abs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 04:34:05 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 02:34:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1124-gb16336c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b16336caf8132d73ae71d78b4efe38df56029b81 (commit) via 18cce456d9685fcf16936a18936873c142cb8aab (commit) via 7f595f8cb8ff04b2cc026c28aa6de276e6d61b5f (commit) via 7bd83146023faf2cdc45196d33ef46204421768c (commit) via 6cbd3265a43d0a8f35496abffd1bfc78481cdb8a (commit) via b288e7557c97f4c39114abb921e9eb6e62f002a8 (commit) via 0d1ae02441934d02470e51db95706b6dddeb20b5 (commit) via 50e326e5c2ea88e0fe34d919d0f6f5613c8ec3cd (commit) via 83868756031cf0a50c3e68552885b23aa745ab5b (commit) via e6d80297504a952f28144be6eb6b3abc0688f968 (commit) via ba41b7da79507b39bfa59965639d92be56db2496 (commit) from bd65c6e95b538c072cecd688f20a9adcfe2cc4e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b16336caf8132d73ae71d78b4efe38df56029b81 Author: Galen Charlton Date: Mon May 5 02:58:29 2014 +0000 Bug 10807: (follow-up) remove comment about routine that is no longer present Signed-off-by: Galen Charlton commit 18cce456d9685fcf16936a18936873c142cb8aab Author: Galen Charlton Date: Mon May 5 02:55:41 2014 +0000 Bug 10807: (follow-up) use 24-hour time when storing search times to session This ensures that if an anonymous session is converted to a logged-in session, that search history times from the anonymous session get stored corectly. Signed-off-by: Galen Charlton commit 7f595f8cb8ff04b2cc026c28aa6de276e6d61b5f Author: Galen Charlton Date: Mon May 5 02:40:09 2014 +0000 Bug 10807: (follow-up) update DBIC schema classes Signed-off-by: Galen Charlton commit 7bd83146023faf2cdc45196d33ef46204421768c Author: Galen Charlton Date: Mon May 5 02:39:07 2014 +0000 Bug 10807: DBrev 3.15.00.046 Signed-off-by: Galen Charlton commit 6cbd3265a43d0a8f35496abffd1bfc78481cdb8a Author: Katrin Fischer Date: Mon Apr 21 22:03:04 2014 +0200 Bug 10807: (follow-up) change wording of tabs Changed the tabs from Catalog and Authority to Catalog searches and Authority searches to be a bit more specific. Signed-off-by: Galen Charlton commit b288e7557c97f4c39114abb921e9eb6e62f002a8 Author: Jonathan Druart Date: Thu Dec 19 15:22:02 2013 +0100 Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 0d1ae02441934d02470e51db95706b6dddeb20b5 Author: Jonathan Druart Date: Tue Sep 24 11:13:32 2013 +0200 Bug 10807: (follow-up) make the new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values. Signed-off-by: Katrin Fischer commit 50e326e5c2ea88e0fe34d919d0f6f5613c8ec3cd Author: Jonathan Druart Date: Mon Sep 23 13:39:07 2013 +0200 Bug 10807: (follow-up) fix UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 83868756031cf0a50c3e68552885b23aa745ab5b Author: Jonathan Druart Date: Mon Sep 23 13:35:58 2013 +0200 Bug 10807: (follow-up) Change the GPL version to v3+ Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit e6d80297504a952f28144be6eb6b3abc0688f968 Author: Owen Leonard Date: Wed Sep 11 09:55:14 2013 -0400 Bug 10807: (follow-up) wording tweak; take OpacAuthorities into account This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit ba41b7da79507b39bfa59965639d92be56db2496 Author: Jonathan Druart Date: Fri Aug 30 14:01:15 2013 +0200 Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in an anonymous user sessin. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: DB or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer All patches together pass QA script and tests. Also, new tests in t/db_dependent/ pass. Tested in all 4 OPAC themes, being logged in and anonymous. Anonymous search history will be appended to personal search history after logging in. Also verified that cleanup_database still purges search history, now also including the authority searchs. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 61 ++--- C4/Search.pm | 23 -- C4/Search/History.pm | 268 ++++++++++++++++++++ Koha/Schema/Result/SearchHistory.pm | 18 +- installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/updatedatabase.pl | 9 + .../opac-tmpl/bootstrap/en/includes/masthead.inc | 4 +- .../opac-tmpl/bootstrap/en/includes/usermenu.inc | 2 +- .../bootstrap/en/modules/opac-search-history.tt | 161 +++++++++--- koha-tmpl/opac-tmpl/ccsr/en/includes/top-bar.inc | 2 +- koha-tmpl/opac-tmpl/ccsr/en/includes/usermenu.inc | 2 +- koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc | 2 +- koha-tmpl/opac-tmpl/prog/en/includes/usermenu.inc | 2 +- .../prog/en/modules/opac-search-history.tt | 229 ++++++++++++----- kohaversion.pl | 2 +- opac/opac-authorities-home.pl | 33 +++ opac/opac-search-history.pl | 169 ++++++------ opac/opac-search.pl | 59 +++-- .../History.t} | 27 +- t/db_dependent/Search/History.t | 248 ++++++++++++++++++ t/db_dependent/Search_SearchHistory.t | 14 +- 21 files changed, 1034 insertions(+), 302 deletions(-) create mode 100644 C4/Search/History.pm rename t/{db_dependent/Auth_SearchHistorySession.t => Search/History.t} (55%) create mode 100644 t/db_dependent/Search/History.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 04:47:04 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 02:47:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1128-gd89e100 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d89e100dda471f2c63fbf0cef4fd2aae0e407e64 (commit) via 2d0e81802a3a594851e0c4aa7e3800a8862e7922 (commit) via 19b54d37f65025e0d718166082d9f190be080b25 (commit) via a6a954efa83a4d87eee8a8b1a0864b60f01eaa7f (commit) from b16336caf8132d73ae71d78b4efe38df56029b81 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d89e100dda471f2c63fbf0cef4fd2aae0e407e64 Author: Galen Charlton Date: Mon May 5 03:08:58 2014 +0000 Bug 10862: DBrev 3.15.00.047 Signed-off-by: Galen Charlton commit 2d0e81802a3a594851e0c4aa7e3800a8862e7922 Author: Jonathan Druart Date: Thu Sep 12 11:52:43 2013 +0200 Bug 10862: (follow-up) make sure that queries that return only one result get recorded Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton commit 19b54d37f65025e0d718166082d9f190be080b25 Author: Jonathan Druart Date: Wed Sep 11 10:36:19 2013 +0200 Bug 10862: (follow-up) fix a couple of issues This followup fixes a couple of issues: - disable the feature by default. - use the datatables include file. - fix the syspref description. - replace "History search" with "Search history". - replace biblio with catalog Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton commit a6a954efa83a4d87eee8a8b1a0864b60f01eaa7f Author: Jonathan Druart Date: Mon Sep 2 17:02:02 2013 +0200 Bug 10862: Add search history to the intranet interface Like OPAC, the search history is now available for intranet. This is controlled by the EnableSearchHistory system preference. Test plan: 1/ Switch on the 'EnableSearchHistory' syspref. 3/ Launch some biblio and authority searches. 4/ Go on your search history page (top right, under "Set library"). 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 2 + authorities/authorities-home.pl | 21 ++++ catalogue/search-history.pl | 100 ++++++++++++++++++++ catalogue/search.pl | 28 +++++- installer/data/mysql/sysprefs.sql | 3 +- installer/data/mysql/updatedatabase.pl | 9 ++ .../intranet-tmpl/prog/en/includes/header.inc | 5 + .../en/modules/admin/preferences/searching.pref | 7 ++ .../prog/en/modules/catalogue/search-history.tt} | 85 +++++++---------- kohaversion.pl | 2 +- 10 files changed, 206 insertions(+), 56 deletions(-) create mode 100755 catalogue/search-history.pl copy koha-tmpl/{opac-tmpl/prog/en/modules/opac-search-history.tt => intranet-tmpl/prog/en/modules/catalogue/search-history.tt} (71%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 04:58:37 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 02:58:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1129-gda08f65 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via da08f65e11fbd33ad6a572a1234d031efd2a3647 (commit) from d89e100dda471f2c63fbf0cef4fd2aae0e407e64 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit da08f65e11fbd33ad6a572a1234d031efd2a3647 Author: Liz Rea Date: Mon Apr 7 10:23:05 2014 +1200 Bug 11684: avoid mixed content warnings using SSL with Amazon - opac-readingrecord and opac-user To test: 0) It goes without saying that images being looked at should continue to be the proper size and look ok. 1) In the staff client, change the OPAC system preference opacthemes to 'bootstrap'. 2) Enable Amazon images in the system preferences 3) Issue a book you know will have images for a known user 4) Issue a book you know will have images for intentionally overdue for the same user 5) git reset --hard origin/master 6) In OPAC, log in as the user. -- On the 'your summary' tab on the left (which is default), a) In the 'Checked out' tab, there should be at least two books. The two books issued should have http images. b) In the 'Overdue' tag, there should be at least one book. The image for the overdue book issued should have http images. 7) Click the 'your reading history' tab on the left. -- The images for the two books issued should have http images. 8) Apply the patch 9) Repeat steps 6-7, but all the images in question should have https images now. 10) In the staff client, change the OPAC system preference opacthemes to 'prog'. 11) Repeat steps 5-9 12) Run the koha QA test tool Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Passes all tests and QA script. Checked reading history, overdoes, and checkouts in bootstrap and prog OPAC. Amazon image URL is now https://. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 ++-- koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt | 2 +- koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 05:07:16 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 03:07:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1132-g41db1ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 41db1ee32f1d89f5d677eec2df05f2050a01e191 (commit) via 54ada7d0697e01987a0ac6db494e8516bc8c58fe (commit) via 3f2300e13296e5fbb887ea0806f00920fba3db5e (commit) from da08f65e11fbd33ad6a572a1234d031efd2a3647 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 41db1ee32f1d89f5d677eec2df05f2050a01e191 Author: Liz Rea Date: Wed Dec 4 09:52:19 2013 +1300 Bug 10944: follow-up for Bootstrap Amazon images on https OPAC see test plan for previous patch, only bootstrap theme instead of prog. :) Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 54ada7d0697e01987a0ac6db494e8516bc8c58fe Author: Robin Sheat Date: Fri Oct 4 16:13:20 2013 +1300 Bug 10944: fix mixed content warnings for covers on staff client This switches the URLs used to access Amazon's cover images to the SSL image server, preventing warnings when using this on a secure site. To test: * Enable Amazon images in the sysprefs, all other cover images off. * Do a search in the staff client. Using firebug or similar, inspect the images that indicate both "no image found" and the covers. * Are they all https, and showing correctly? Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 3f2300e13296e5fbb887ea0806f00920fba3db5e Author: Liz Rea Date: Wed Sep 25 14:50:24 2013 +1200 Bug 10944: fix mixed content warnings in opac results and detail with Amazon images on https It's probably going to become more popular to run Koha in SSL environments. Currently on SSL, with Amazon images enabled, a SSL enabled site will either not show Amazon images (IE, some versions of Firefox?), or show a warning to users about mixed secure and insecure content (Firefox, Chrome). Since we now have the using_https template variable, it makes sense to use it. To test: In each browser you have access to, and preferably with SSL set up (you can set up a self signed cert for your dev install by following, more or less, the instructions here: https://wiki.debian.org/Self-Signed_Certificate) For the apache config, just copy the one for the OPAC, but set it to use 443 instead of 80 for the port, and point it to your keys per the instructions above. ** note that using a self signed cert on your dev install will prompt you when you connect the first time that OMG I CAN'T VERIFY THIS IS COOL. You did it yourself, if you can't trust yourself... then who can you trust? * Enable Amazon images in the system preferences * Do a search that you know will have images for, verify that without SSL 1. the images show 2. the image source is from an Amazon url that uses http:// 3. the images are the right size, and look ok * Do the same using https, verify that with SSL 1. the images show 2. the image source is from an Amazon url that uses https:// 3. the images are the right size, and look ok Clicking on the image should link to the item on Amazon. This patch also corrects a problem with the Amazon URL used on the images - it was pointing to a feature that is currently unavailable. That's fixed here. All you need to check is that it goes to a valid Amazon endpoint that doesn't show an error. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 14 +++++++------- .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 9 +++++++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++++ koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 13 ++++++++++++- koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt | 2 +- 6 files changed, 34 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 05:15:24 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 03:15:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1133-g19131a9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 19131a9d8ee85dd28033856d02f8573625ce74f8 (commit) from 41db1ee32f1d89f5d677eec2df05f2050a01e191 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 19131a9d8ee85dd28033856d02f8573625ce74f8 Author: Nu?o L?pez Ans?tegui Date: Tue Nov 26 18:38:43 2013 +0100 Bug 11309: avoid creating duplicate numbering patterns during upgrade to 3.14.x To test: 1/ Install Koha 3.12 2/ Create some subscriptions. Ensure you have at least two subscriptions with the same numbering pattern, with one of the keys everyX/addX/whenmorethanX/settoX set to NULL 3/ Remember this numbering pattern. 4/ Upgrade to 3.14 5/ Run updatedatabase.pl 6/ The numbering pattern is duplicated Now repeat steps 1 to 4, then apply the patch and run updatedatabase.pl. Numbering pattern should not be duplicated. Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 05:44:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 03:44:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1138-g1df244d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1df244d5786d020aa9298adeaf5330d261c0f431 (commit) via 2bd3aaa58e7b45a0e38344a66bc7be3a0f2f8236 (commit) via 3070650200a80de23a4744da1b5490f98c6e36e2 (commit) via a1febe1c1e714be1a9355f9d520ba39a02a9622a (commit) via 179a7f8d767c7a042bc0c91f97ee979115b40259 (commit) from 19131a9d8ee85dd28033856d02f8573625ce74f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1df244d5786d020aa9298adeaf5330d261c0f431 Author: Galen Charlton Date: Mon May 5 04:08:34 2014 +0000 Bug 8952: (follow-up) apply link change for social networks to Bootstrap theme Signed-off-by: Galen Charlton commit 2bd3aaa58e7b45a0e38344a66bc7be3a0f2f8236 Author: Galen Charlton Date: Mon May 5 04:03:26 2014 +0000 Bug 8952: (follow-up) remove hard-coded LFTL ID added by a previous patch Signed-off-by: Galen Charlton commit 3070650200a80de23a4744da1b5490f98c6e36e2 Author: Jonathan Druart Date: Thu May 23 17:28:25 2013 +0200 Bug 8952: (follow-up) using_https does not deal with Plack When using Plack, the https method returns 'OFF'. We have to test this value before sending the value to templates. Test plan: 1/ Fill your OPACBaseUrl 2/ Configure apache for using http 3/ Check the social networks links (should be http://OPACBaseUrl) 4/ Launch Plack 5/ Check the social networks link (should be http://OPACBaseUrl) 6/ Stop Plack 7/ Configure apache for using https sudo openssl req -x509 -nodes -days 365 -newkey rsa:1024 -out /etc/apache2/server.crt -keyout /etc/apache2/server.key and add in you virtualhost (with :443) SSLEngine on SSLCertificateFile /etc/apache2/server.crt SSLCertificateKeyFile /etc/apache2/server.key a2enmod ssl service apache2 restart 8/ Check the social networks links (should be https://OPACBaseUrl) FIXME: Under Plack, with ssl actived, the CGI->https() method always returns 'OFF'. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit a1febe1c1e714be1a9355f9d520ba39a02a9622a Author: Jonathan Druart Date: Thu Oct 25 09:29:28 2012 +0200 Bug 8952: (follow-up) change occurrences of using_https Signed-off-by: Corey Fuimaono Verified. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 179a7f8d767c7a042bc0c91f97ee979115b40259 Author: Owen Leonard Date: Wed Oct 24 12:30:33 2012 -0400 Bug 8952: Add http:// to url in social media links on opac-detail This patch adds a variable to the template, "protocol" based on whether "using_https" is set. The appropriate protocol is inserted before social media links. To test, confirm that OPACBaseURL is set and lacks "http(s)://" Social media links should include correct URLs. A follow-up patch could copy use of this [% protocol %] variable in other parts of this template which duplicate large chunks of HTML based on [% using_https %]. Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 8 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 17 +++-- koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 78 +++++++------------- 3 files changed, 46 insertions(+), 57 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 05:49:42 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 03:49:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1139-g735381b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 735381b371b128fed13b8b34c97746af21a17282 (commit) from 1df244d5786d020aa9298adeaf5330d261c0f431 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 735381b371b128fed13b8b34c97746af21a17282 Author: Colin Campbell Date: Wed Aug 14 16:21:26 2013 +0100 Bug 10729: Add phrases configuration for ICU Add a separate phrases-icu.xml for phrase indexes The file is based on that distributed with zebra with a couple of additions to reflect Koha usage This patch adds a separate tokenizer variable for phrase indexes so that default.idx is correctly rewritten for sites using icu indexing Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer - Applied patch - perl Makefile.PL --prev-install-log ../koha-dev/misc/koha-install-log - make upgrade - Restarted Zebra server - Did a full reindex of bibliographic and authorities - Checked various searches - Links records to authorities - Checked created links work correctly I couldn't find a regression with this patch. Passes all tests and QA script. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 4 ++++ etc/zebradb/etc/default.idx | 2 +- etc/zebradb/etc/{words-icu.xml => phrases-icu.xml} | 4 +--- rewrite-config.PL | 1 + 4 files changed, 7 insertions(+), 4 deletions(-) copy etc/zebradb/etc/{words-icu.xml => phrases-icu.xml} (62%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 05:53:40 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 03:53:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1140-gcf7d0c3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cf7d0c3a99d42fae2d23f9dafba136814dafa492 (commit) from 735381b371b128fed13b8b34c97746af21a17282 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cf7d0c3a99d42fae2d23f9dafba136814dafa492 Author: Galen Charlton Date: Mon May 5 04:18:22 2014 +0000 Bug 7442: (follow-up) adjust UNIMARC test case to match change in BuildSummary() Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: t/db_dependent/AuthoritiesMarc.t | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 06:25:15 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 04:25:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1147-g801c5e7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 801c5e77d0a7bdab5d2457d47b2fb2b852310c56 (commit) via d24b24adee9d686c100b8b4e298abbb3ad89a950 (commit) via 76e39750b7d1f767b9fd93ce328ab25a829898e3 (commit) via fe32727fc55823ab1a3edba70597b89856cd0ea3 (commit) via 061cff837d1667b0f714fbbfba59c2caed098d6b (commit) via 75bd34df7acba7b20bc7981f2484e79e19032d4a (commit) via 114f3dd49998be21643f83bec644f9837c6bdecc (commit) from cf7d0c3a99d42fae2d23f9dafba136814dafa492 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 801c5e77d0a7bdab5d2457d47b2fb2b852310c56 Author: Julian Maurice Date: Mon Mar 17 23:25:37 2014 +0100 Bug 11848: Fix C4::Context::interface, add POD and UT 1/ Edit a Perl script, for example mainpage.pl 2/ add "use Koha::I18N;" to the top of file 3/ add a translatable message somewhere in the script (this have to be after the call to get_template_and_user). For example: warn gettext("This is a translated warning"); 4/ Create or update the PO files with misc/translator/translate create LANGCODE or misc/translator/translate update LANGCODE (LANGCODE should be enable in syspref 'languages') 5/ In misc/translator/po/LANGCODE-messages.po you should have your string, translate it (using a text editor or a PO file editor, make sure you don't have the "fuzzy" flag for this string). 6/ Go to mainpage.pl with active language being English with your browser and check your logs. You should see your string "This is a translated warning". 7/ Now change language to LANGCODE. Check your logs, you should have the string translated. Note: I chose to name the sub 'gettext' because it's the default keyword for xgettext for Perl. We can change it to whatever we want. Signed-off-by: Bernardo Gonzalez Kriegel Follow test plan, work as described. No koha-qa errors. Tests pass Fixed small merge conflict on t/Context.t Signed-off-by: Katrin Fischer Passes all tests and QA script. Copied test plan from bug. Signed-off-by: Galen Charlton commit d24b24adee9d686c100b8b4e298abbb3ad89a950 Author: Julian Maurice Date: Wed Feb 26 16:45:59 2014 +0100 Bug 11848: Make Koha::I18N easier to use Instead of writing use CGI; use Koha::I18N; my $cgi = new CGI; my $lh = Koha::I18N->get_handle_from_context($cgi, 'intranet'); print $lh->maketext('my translatable text'); you can now write use Koha::I18N; print gettext('my translatable text'); Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 76e39750b7d1f767b9fd93ce328ab25a829898e3 Author: Julian Maurice Date: Wed Feb 26 13:20:37 2014 +0100 Bug 11848: Move language detection function in C4::Languages Also store interface (intranet, opac) in context to not have to pass it as parameter. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Signed-off-by: Katrin Fischer Comments on last patch. Signed-off-by: Galen Charlton commit fe32727fc55823ab1a3edba70597b89856cd0ea3 Author: Marcel de Rooy Date: Thu Aug 15 15:19:32 2013 +0200 Bug 8044: (follow-up) ensure Modern::Perl is imported first Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 061cff837d1667b0f714fbbfba59c2caed098d6b Author: Julian Maurice Date: Mon Aug 20 13:51:27 2012 +0200 Bug 8044: (follow-up) add copyright block and use Modern::Perl Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 75bd34df7acba7b20bc7981f2484e79e19032d4a Author: Julian Maurice Date: Mon Aug 20 10:55:50 2012 +0200 Bug 8044: (follow-up) fix warning and error messages in translate.pl CHARSET is now automatically replaced by UTF-8, and 'update' creates the PO file if it does not exist. Also do not try to create PO files if POT file creation failed (when there is no messages to translate for example). + add some verbosity + add Locale::Maketext and Locale::Maketext::Lexicon to Koha dependencies Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 114f3dd49998be21643f83bec644f9837c6bdecc Author: Julian Maurice Date: Fri May 4 14:33:10 2012 +0200 Bug 8044: new module for translating strings in Perl source files You have to use the new module Koha::I18N Code example: use Koha::I18N; use CGI; my $input = new CGI; my $lh = Koha::I18N->get_handle_from_context($input, 'intranet'); print $lh->maketext("Localized string!"); PO files are in misc/translator/po/LANG-messages.po. Creation of PO files are integrated to existing workflow, so to create PO file for a language, just run in misc/translator: ./translate create LANG To update: ./translate update LANG You can then translate the PO with your favorite editor. Strings will be localized at runtime. Signed-off-by: Marcel de Rooy Works as advertised. Some details needing further attention noted on bug report. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 7 +++- C4/Context.pm | 25 +++++++++++ C4/Installer/PerlDependencies.pm | 10 +++++ C4/Languages.pm | 59 ++++++++++++++++++++++++-- C4/Templates.pm | 51 +--------------------- Koha/I18N.pm | 58 +++++++++++++++++++++++++ catalogue/search.pl | 5 ++- misc/translator/LangInstaller.pm | 86 ++++++++++++++++++++++++++++++++++++++ opac/opac-search.pl | 4 +- t/Context.t | 16 ++++++- t/{Templates.t => Languages.t} | 9 ++-- 11 files changed, 269 insertions(+), 61 deletions(-) create mode 100644 Koha/I18N.pm rename t/{Templates.t => Languages.t} (79%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 06:26:44 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 04:26:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1148-ge4f2326 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e4f2326063047ce818ea12d6506a74cd01170476 (commit) from 801c5e77d0a7bdab5d2457d47b2fb2b852310c56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e4f2326063047ce818ea12d6506a74cd01170476 Author: Galen Charlton Date: Mon May 5 04:51:42 2014 +0000 Bug 11848: (follow-up) update license statment Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: Koha/I18N.pm | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 06:42:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 04:42:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1151-g8e364c4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8e364c4c6adc45bef191a297ce7757d63fa1e806 (commit) via 507944e41bec4987c9ef8c75c436332bdb727df2 (commit) via 98309138a694f70383b36c03148ca291a835d5b9 (commit) from e4f2326063047ce818ea12d6506a74cd01170476 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e364c4c6adc45bef191a297ce7757d63fa1e806 Author: Jonathan Druart Date: Tue Nov 19 14:30:21 2013 +0100 Bug 11262: Don't require hardcoded translations for seasonal numbering pattern to work This patch removes the use of POSIX::strftime which is based on the locales of the system. The DateTime module translates month and day name with success, without any locale installed. For the saesons, I use the way used in Koha: write the word in templates. On this way the translate script will match them and allow translators to translate them. This patch adds a regression: the season names are not translated following the locale selected. This could be done when bug 8044 will be pushed. Test plan: 0/ Update your po files and translate the season name. 1/ Create a numbering pattern using season. example: Name: Seasonal Numbering formula: {X} X: Season, Add=1, Every=1, Set back to 0 when more than 3, formatting "name of season" And test the prediction pattern with: frequency: 1/3 month First issue : 2013-09-21 length: 12 months X begins with 2 (21th Septembre is Fall) 2/ Click on the test pattern button, you should get: Fall 21/09/2013 Winter 21/12/2013 Spring 21/03/2014 Summer 21/06/2014 Change the locale and verify the season names are *not* translated. Change the Koha language and verify the season names are translated. 3/ Create a numbering pattern using day or month name. example: Name: day Numbering formula: {X} X: day, Add=1, Every=1, Set back to 0 when more than 6, formatting "name of day" Frequency: 1/day First issue: 2013-11-18 length: 1 month X begins with 0 You should get: Monday 18/11/2013 Tuesday 19/11/2013 Wednesday 20/11/2013 [...] Sunday 15/12/2013 Monday 16/12/2013 Tuesday 17/12/2013 change the locale and verify the day names are translated. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Tested on top of Bug 11265 and Bug 11263, and solved merge conflict Updating PO file gives seasons to translate. Tested using seasons, day and month Only note is different behavior 1) To use seasons you need to use staff in desired language 2) To use day and month only need to select locale Signed-off-by: Kyle M Hall No regressions found. Passes koha-qa.pl, t and xt Signed-off-by: Katrin Fischer Tested this again on top of 11263 and it works as described. Signed-off-by: Galen Charlton commit 507944e41bec4987c9ef8c75c436332bdb727df2 Author: Jonathan Druart Date: Thu Dec 12 11:27:26 2013 +0100 Bug 11263: Use all languages instead of just the translated ones This patch produces the same dropdown list as the one in the adv search. With this way, it won't be necessary to install additional templates to fill the locale list. Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 98309138a694f70383b36c03148ca291a835d5b9 Author: Jonathan Druart Date: Tue Nov 19 14:21:38 2013 +0100 Bug 11263: do not use system locales settings for subscriptions The locales list for subscriptions should not be retrieved from the locales of the system. This patch retrieves the locales list from the Koha DB (in the same way as pref language and opaclanguages). Test plan: Edit a subscription (or a numbering pattern) and verify the list of languages is the same as languages available in Koha. Note: with this patch we loose the saeson translation, it is normal. See report linked. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors. New locale is retrieved from installed languages. I wonder if that list can be restricted to 'enabled' ones (parsing syspref language value). Signed-off-by: Katrin Fischer Passes QA script and all tests. Works according to description. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 48 +++++++++----------- .../prog/en/modules/serials/serials-collection.tt | 12 ++++- .../en/modules/serials/showpredictionpattern.tt | 14 +++++- .../prog/en/modules/serials/subscription-add.tt | 8 ++-- .../modules/serials/subscription-numberpatterns.tt | 4 +- serials/subscription-add.pl | 17 ++++--- serials/subscription-numberpatterns.pl | 14 +++--- 7 files changed, 68 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 06:47:02 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 04:47:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1152-g4bc46db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4bc46dbbcb93ca43b2fd138cf65f51893978b3ad (commit) from 8e364c4c6adc45bef191a297ce7757d63fa1e806 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4bc46dbbcb93ca43b2fd138cf65f51893978b3ad Author: Fridolin Somers Date: Tue Apr 8 16:48:31 2014 +0200 Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like: https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for login and password Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Normal login still works with/without CAS. Passes all tests and QA script. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 06:52:58 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 04:52:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1154-gb57d985 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b57d98517c5a9572a54412f7f4e5d872acfa85c3 (commit) via c8a18f5eefd81dc07512faa962064effdfb88de9 (commit) from 4bc46dbbcb93ca43b2fd138cf65f51893978b3ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b57d98517c5a9572a54412f7f4e5d872acfa85c3 Author: Fridolin Somers Date: Thu Apr 10 13:12:19 2014 +0200 Bug 11219: (follow-up) fetch only URL parameters This followup corrects the fact that when using $query->url(), both GET and POST params are get. Using $query->url_param() will only get params directly in URL. Test plan : - Enable CAS - Go to login page : cgi-bin/koha/opac-user.pl - Try to connect with local login using random login and password (they will be transmitted by POST) - You stay to login page - Look at CAS login URL => Without this patch it will contain the random login and password as parameters of opac-user.pl => With this patch it does not contain any parameter Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit c8a18f5eefd81dc07512faa962064effdfb88de9 Author: Fridolyn SOMERS Date: Fri Nov 8 11:12:57 2013 +0100 Bug 11219: make CAS authentication work with URL parameters Bug 10029 tries to fix the use of URL parameters in CAS authentication. But is does not work. The full URL must be used in all methods of C4::Auth_with_cas. Also, in checkpw_cas(), the 'ticket' parameter must be removed to find the original URL. This patch removes the 'ticket' parameter from query before calling checkpw_cas() since the ticket is passed as method arguemnt. In C4::Auth_with_cas, many methods use the same code to get the CAS handler and the service URI. This patch adds a private method _get_cas_and_service() to do the job. Test plan: - Enable CAS - Go to opac without been logged-in - Try to place hold on a record => You get to /cgi-bin/koha/opac-reserve.pl?biblionumber=XXX showing authentication page => Check that CAS link contains query param "biblionumber" - Click on CAS link and log in => Check you return well logged-in to reserve page with biblionumber param - Check CAS loggout - Check Proxy CAS auth Signed-off-by: Koha team AMU Signed-off-by: Katrin Fischer Passes all tests in t, xt, and t/db_dependent/Auth.t. Also passes QA script. As I have no working CAS server, I focused on regression testing: Activated Persona and casAuthentication. - Verified normal login against database still works. - Verified Persona login works. Note: With Persona you are always forwarded to the patron account - so you have to search for the record again before you can place a hold. - Verified that the CAS URL contains the biblionumber when logging in while placing a hold. Signed-off-by: Katrin Fischer Retested 2014-04-12 Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 1 + C4/Auth_with_cas.pm | 69 ++++++++++++++++++++++++++++----------------------- 2 files changed, 39 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 06:57:39 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 04:57:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1155-gc251f75 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c251f7524081e428b24620d2755a210347da2052 (commit) from b57d98517c5a9572a54412f7f4e5d872acfa85c3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c251f7524081e428b24620d2755a210347da2052 Author: Matthias Meusburger Date: Mon Oct 14 11:24:29 2013 +0200 Bug 11048: Fix logout redirection for CAS authentication The logout redirection function after a CAS authentication was misused. This patch fixes it, and allows the CAS server to redirect the user back to the opac after logout. Signed-off-by: Chris Cormack From the Authen::Cas::Client documentation logout_url [%args] "logout_url()" returns the CAS server's logout URL which can be used to redirect users to end authenticated sessions. %args may contain the following optional parameter: * url => $url If present, the CAS server will present the user with a link to the given URL once the user has logged out. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Change only affects CAS authentication and is correct according to the module documentation. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_cas.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 07:01:43 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 05:01:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1157-ge92b6e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e92b6e3dff75e20baeb818828739a4d80945cb60 (commit) via 997246cf4fb1b9c040e9b18c0ff264249db55cd9 (commit) from c251f7524081e428b24620d2755a210347da2052 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e92b6e3dff75e20baeb818828739a4d80945cb60 Author: Galen Charlton Date: Mon May 5 05:26:18 2014 +0000 Bug 4397: (follow-up) adjust unit test reflect return of display version of scan terms Signed-off-by: Galen Charlton commit 997246cf4fb1b9c040e9b18c0ff264249db55cd9 Author: Tomas Cohen Arazi Date: Fri Feb 28 15:26:10 2014 -0300 Bug 4397: fix scan index search results for non-latin characters The Zoom specification defines that a ScanSet should provide a way to retrieve terms suitable for displaying and another one for using on further searches [1]. The Net::Z3950::ZOOM implementation actually provides both [2] but we were using the wrong one. Using $scanset->display_term(...) instead of $scanset->term(...) fixes the problem. To test: - Do a index scan search (advanced search > more options > check 'index scan') - Notice non-latin characters are replaced by one or more '@' symbols. - Apply the patch - Re-do the search, everything shows as it should. - Try to follow any of the terms (clicking on them) and notice that it actually gives you relevant results (i.e. is not searching for @!!!!). [1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3 [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_term() Sponsored-by: Universidad Nacional de Cordoba Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart I reproduced the issue and I confirm this patch fixes it. I put "Fu?" in a title, reindex the record. Launch a search on Title checking the "scan index" checkbox. And the non-latin characters are well displayed. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 2 +- t/db_dependent/Search.t | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 13:04:28 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 11:04:28 +0000 Subject: [koha-commits] main Koha release repository branch 3.8.x updated. v3.08.23-2-ge7c7f7a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.8.x has been updated via e7c7f7af023172aea3fb02e4c1fa356c99f69fec (commit) via 3a28bf01cfde06009c833b3c335432f2ed1d149e (commit) from 042b6f170bac364b41435c759de376f0f8b93b45 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e7c7f7af023172aea3fb02e4c1fa356c99f69fec Author: Jonathan Druart Date: Mon Nov 12 10:18:30 2012 +0100 Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference" Signed-off-by: Mason James commit 3a28bf01cfde06009c833b3c335432f2ed1d149e Author: Jonathan Druart Date: Fri Nov 9 18:34:40 2012 +0100 Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline). Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 16:41:38 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 14:41:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1160-g0423b43 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0423b43b1761a9c5d86888426643d69015b15e3a (commit) via 3ee1695174f21bf683f7387767424f16480f5052 (commit) via 42678f3abfce12c49d23edbe58d228cd46463997 (commit) from e92b6e3dff75e20baeb818828739a4d80945cb60 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0423b43b1761a9c5d86888426643d69015b15e3a Author: Kyle M Hall Date: Mon May 5 07:54:56 2014 -0400 Bug 8769: (follow-up) undo change to value of $today Signed-off-by: Galen Charlton commit 3ee1695174f21bf683f7387767424f16480f5052 Author: Kyle M Hall Date: Wed Apr 23 07:44:12 2014 -0400 Bug 8769: (follow-up) remove unnecessary module import Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 42678f3abfce12c49d23edbe58d228cd46463997 Author: Kyle M Hall Date: Fri Oct 4 09:53:11 2013 -0400 Bug 8769: Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. Signed-off-by: Benjamin Rokseth Works as notified, second date field in SIP checkin (return date) is used as return date. Return shows up in history with correct date. Comments: - patron is fined if return date is before issue date, but that is largely irrelevant anyway. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 1 + C4/SIP/ILS.pm | 2 +- C4/SIP/ILS/Transaction/Checkin.pm | 16 +++++++++++++++- 3 files changed, 17 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 16:52:29 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 14:52:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1163-g7134663 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7134663f48e81260204bbc3715d0e06af41590ca (commit) via 0a366e19decc8bf8d8d9ecf854e10ce3d3a19363 (commit) via 159e99f3bc90f0e9463a6e8a96ae477d762625ee (commit) from 0423b43b1761a9c5d86888426643d69015b15e3a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7134663f48e81260204bbc3715d0e06af41590ca Author: Jonathan Druart Date: Fri May 2 16:54:51 2014 +0200 Bug 11209: (follow-up) message content must also match for new message to be considered a duplicate If the template contains dynamic parts, the message won't be considerated as duplicated. Signed-off-by: Marcel de Rooy Duplicate messages will be queued, but when sending the queued messages duplicates are found and are marked as failed. Signed-off-by: Galen Charlton commit 0a366e19decc8bf8d8d9ecf854e10ce3d3a19363 Author: Jonathan Druart Date: Tue Dec 3 12:17:50 2013 +0100 Bug 11209: (follow-up) check if a notice has been already sent today The previous patch checks if a notice has already been sent when the current notices has been sent in queue. Which is wrong! We have to check if a similar notice has been sent today. This patch has been created after an observation on a production server: If a user place on holds several items, he will receive 1 SMS per hold. Here we only want 1 SMS for all holds. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton commit 159e99f3bc90f0e9463a6e8a96ae477d762625ee Author: Jonathan Druart Date: Wed Nov 6 14:56:35 2013 +0100 Bug 11209: Don't sent the same SMS message for the same user the same day For PREDUE messages, one message is sent to the message_queue table for each items in advance, meaning that the patron could receive duplicate notices. The SMS part for DUE and PREDUE often do not contain dynamic parts, only a standard message. Note that this patch *only* affects the SMS transport. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 17:26:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 15:26:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1168-g15a5140 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 15a5140f3673185136d6465b300813ff1c0097d4 (commit) via 41b138b78344f3c199b9e9b50bdead5ff1cd52eb (commit) via b94f375e48eb16a4a45c5ef4ae93e82c0bd0da9d (commit) via f867435fbbd20a7c2a382df4500da0273ba6111f (commit) via f2ad0d74240bd02ad5e33921c6207dc289f9c922 (commit) from 7134663f48e81260204bbc3715d0e06af41590ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 15a5140f3673185136d6465b300813ff1c0097d4 Author: Galen Charlton Date: Mon May 5 15:50:45 2014 +0000 Bug 10195: (follow-up) tidying up code and eliminate warning if record does not have 942$n Signed-off-by: Galen Charlton commit 41b138b78344f3c199b9e9b50bdead5ff1cd52eb Author: Galen Charlton Date: Mon May 5 15:46:48 2014 +0000 Bug 10195: (follow-up) add blocked record template for Bootstrap Signed-off-by: Galen Charlton commit b94f375e48eb16a4a45c5ef4ae93e82c0bd0da9d Author: Galen Charlton Date: Mon May 5 15:37:20 2014 +0000 Bug 10195: (follow-up) update license; use Modern::Perl Signed-off-by: Galen Charlton commit f867435fbbd20a7c2a382df4500da0273ba6111f Author: Galen Charlton Date: Mon May 5 15:35:05 2014 +0000 Bug 10195: DBRev 3.15.00.048 Signed-off-by: Galen Charlton commit f2ad0d74240bd02ad5e33921c6207dc289f9c922 Author: Mirko Tietgen Date: Thu Jul 4 00:50:43 2013 +0200 Bug 10195: hide bib details page for OPAC-suppressed bibs Records hidden with OpacSuppression are filtered from the search results, but the opac-detail page is still visible if you know the biblio number. This patch hides the detail page for suppressed biblios by redirecting (controlled by the syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining that the record is blocked (including optional explanatory text from the syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a biblio with that number exists in the system. Test plan: Make sure you have at least one record with 942$n == 1. Set OpacSuppression to "Don't hide". Do an OPAC search that should bring up your hidden record and other records. Observe that your record is found. Open the detail page for the record. Observe that it is accessible. Copy the URL for later(!). Set OpacSuppression to "Hide". Leave OpacSuppressionByIPRange blank. Set OpacSuppressionRedirect to "an explanatory page ('This record is blocked')." Leave OpacSuppressionMessage blank for now. Disable queryparser(!) (because of bug 10542). Do a full zebra reindex. Do an OPAC search that should bring up your hidden record and other records. Observe that your record is not found. Open the opac-detail URL of the record (the one you copied before). Observe that you are redirected to opac-blocked and it displays a short standard message. Edit OpacSuppressionMessage and input some text. Open the opac-detail URL of the record again (the one you copied before). Observe that the text you entered in OpacSuppressionMessage is displayed under the standard text you have seen before. Set OpacSuppressionRedirect to "the 404 error page ('Not found')." Open the opac-detail URL of the record again (the one you copied before). Observe that you are redirected to Koha's 404 error page. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 ++ installer/data/mysql/updatedatabase.pl | 8 +++++ .../en/modules/admin/preferences/cataloguing.pref | 11 ++++++- .../opac-tmpl/bootstrap/en/modules/opac-blocked.tt | 31 +++++++++++++++++++ .../en/modules/{errors/500.tt => opac-blocked.tt} | 22 ++++++++------ kohaversion.pl | 2 +- patron_lists/lists.pl => opac/opac-blocked.pl | 28 +++++++---------- opac/opac-detail.pl | 32 ++++++++++++++++++++ 8 files changed, 107 insertions(+), 29 deletions(-) create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-blocked.tt copy koha-tmpl/opac-tmpl/prog/en/modules/{errors/500.tt => opac-blocked.tt} (55%) copy patron_lists/lists.pl => opac/opac-blocked.pl (59%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 17:38:25 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 15:38:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1169-gfd0e8ff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fd0e8ff0adeff322c3defea0b4f6b29bde7ffa51 (commit) from 15a5140f3673185136d6465b300813ff1c0097d4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fd0e8ff0adeff322c3defea0b4f6b29bde7ffa51 Author: Tomas Cohen Arazi Date: Thu Aug 29 16:03:11 2013 -0300 Bug 10003: bash-completion for koha-list and other scripts This patch implements bash-completion for the following commands: - koha-list - koha-enable - koha-disable - koha-email-enable - koha-email-disable - koha-enable-sip - koha-start-sip - koha-restart-sip - koha-stop-sip - koha-start-zebra - koha-stop-zebra - koha-restart-zebra It is implemented in a way that it removes already used or mutually exclusive parameters (instance names, option switches). I already have written completion for other (more complex) commands, but I belive a simpler patch is better to start with. IMPORTANT: this patch relies on having the koha-list command available in the path. To test: - Make sure you have bash-completion installed and enabled (IRC might help us if you encounter problems). - Apply the patch. Option 1: - Pick the debian/koha-common.bash-completion file and do $ cp debian/koha-common.bash-completion /etc/bash_completion.d/koha-common - Open a new bash shell (I do it opening a new terminal on my Ubuntu box). - Type one of the listed commands... And repeatedly press . - Enjoy, and signoff if you belive it is usable. Otherwise report back. Option 2: - run: $ . debian/koha-common.bash-completion - Type one of the listed commands... And repeatedly press . - Enjoy, and signoff if you belive it is usable. Otherwise report back. Tests: - Some koha-list option switches are mutually exclusive, -h should be available in any context - koha-enable should only autocomplete disabled instances - koha-disable should only autocomplete enabled instances - koha-email-enable should only autocomplete email-disabled instances - koha-email-disable should only autocomplete email-enabled instances - koha-*-zebra scripts should only autocomplete enabled instances. - koha-*-sip scripts should only autocomplete sip-enabled instances. Regards To+ Note: writing bash-completion routines is a bit hacky, I tried to make it the simplest way I could. Your comments are welcome. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: debian/koha-common.bash-completion | 171 ++++++++++++++++++++++++++++++++++++ debian/rules | 2 +- 2 files changed, 172 insertions(+), 1 deletion(-) create mode 100644 debian/koha-common.bash-completion hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 18:02:49 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 16:02:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1171-g05949b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 05949b49bc749fe0004b781c9b5606ecf6316782 (commit) via 758453442bf400c0fa373040c92c2acbb9f1d3ce (commit) from fd0e8ff0adeff322c3defea0b4f6b29bde7ffa51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 05949b49bc749fe0004b781c9b5606ecf6316782 Author: Galen Charlton Date: Mon May 5 16:27:01 2014 +0000 Bug 11262: (follow-up) base generation of day name on a week starting with Sunday, not Monday This fixes test failures reported by t/db_dependent/Serials/GetNextSeq.t. Signed-off-by: Galen Charlton commit 758453442bf400c0fa373040c92c2acbb9f1d3ce Author: Galen Charlton Date: Mon May 5 16:16:56 2014 +0000 Bug 6739: (follow-up) handle case where patron has no expiration date set Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 5 ++++- C4/Serials.pm | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 18:52:59 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 16:52:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1173-g7acd7f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7acd7f43a703c3aa853ea6e58153584c24ca6d09 (commit) via 2afadcc3583c466759f2c4da6970a3cc96a1ba36 (commit) from 05949b49bc749fe0004b781c9b5606ecf6316782 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7acd7f43a703c3aa853ea6e58153584c24ca6d09 Author: Fridolyn SOMERS Date: Fri Feb 1 17:52:11 2013 +0100 Bug 9532: fix reservability check when bib-level item types are in use When itemtype is defined on biblio (item-level_itypes syspref), the method C4::Reserves::CanItemBeReserved uses item->{itemtype}. But ithe item comes from C4::Items::GetItem and it does not have an 'itemtype' key; in this method the item type value is always in 'itype' key. This patch corrects it. Test plan: You should have itemtype on biblio and 'item-level_itypes' syspref set to biblio. This test plan is with ReservesControlBranch on ItemHomeLibrary. - Choose a branch, a borrower category and an item type, for example 'NYC', 'CHILD' and 'DVD' - Set an issuing rule for 'NYC', CHILD' and 'DVD' with 'Holds allowed' set to 10 - Set an issuing rule for 'NYC', CHILD' and all item types with 'Holds allowed' set to 0 - Choose an item of a biblio with itemtype 'DVD', that can be reserved, with 'NYC' as homebranch - Choose a borrower with category 'CHILD' - Try to request the item for the borrower => without the patch, you can => with the patch, you can't You may check reserve is allowed with 'Holds allowed' > 0 on issuing rule for 'DVD'. Signed-off-by: Liz Rea Great test plan - thanks! Confirmed the bug, and the fix. Looks good to me. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 2afadcc3583c466759f2c4da6970a3cc96a1ba36 Author: Galen Charlton Date: Mon May 5 17:16:37 2014 +0000 Bug 9532: add regression test To test: [1] Run prove -v t/db_dependent/Holds.t. The last test should fail. [2] Apply the main patch. [3] Run step 1 again. This time the tests should all pass. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 18 +++++++++--------- t/db_dependent/Holds.t | 43 +++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 50 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 19:26:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 17:26:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1174-gdd64903 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dd64903489a264e6e0c83035ab5b631f51f20507 (commit) from 7acd7f43a703c3aa853ea6e58153584c24ca6d09 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dd64903489a264e6e0c83035ab5b631f51f20507 Author: Katrin Fischer Date: Tue Feb 11 16:29:13 2014 +0100 Bug 11741: Correct display of < > in XSLT result lists < and > are incorrectly transformed into HTML entities on the XSLT result list when using the GRS-1 indexing mode. Example: Record: Result list: <TEST> HTML source: &lt;TEST&gt To test: - catalog a record that contains > and < - Reindex, without using the -x option - Confirm the display is correct - Reindex again, using the -x option - Confirm the display is now broken - Apply patch - Reindex again with and without -x - Verify that now the display is always correct Signed-off-by: Tomas Cohen Arazi Note: the problem is only visible in GRS-1 setup. It works as expected. No behaviour change in DOM. I believe we shouldn't be (de)escaping data ad-hoc, but it seems that GRS-1 needs it because it doesn't handle HTML entities properly. This fix is OK for GRS-1, unneeded for DOM and probably any other modern search engine. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/XSLT.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 19:35:05 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 17:35:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1179-g89752a1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 89752a126d005cc763d93eb5e543b1f829bed039 (commit) via 5bee287cd447665407c20e91625aba6e0dbacd1d (commit) via 9ee4f41555059cd0f7b7b32ac7c7219d37e3939f (commit) via 4e936f9c42742894a64e96519bc646e0197c4f5e (commit) via b47eac0a6e86ed863921969ff2be703f54f46f52 (commit) from dd64903489a264e6e0c83035ab5b631f51f20507 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 89752a126d005cc763d93eb5e543b1f829bed039 Author: Galen Charlton Date: Mon May 5 17:59:53 2014 +0000 Bug 5377: (follow-up) update DBIC schema classes Signed-off-by: Galen Charlton commit 5bee287cd447665407c20e91625aba6e0dbacd1d Author: Galen Charlton Date: Mon May 5 17:58:35 2014 +0000 Bug 5377: DBrev 3.15.00.049 Signed-off-by: Galen Charlton commit 9ee4f41555059cd0f7b7b32ac7c7219d37e3939f Author: Jonathan Druart Date: Thu Feb 20 12:40:35 2014 +0100 Bug 5377: (follow-up) there is no index on deletedbiblioitems.issn This patch removes a trailing space and remove the issn index deletion (it does not exist on deletedbiblioitems). Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 4e936f9c42742894a64e96519bc646e0197c4f5e Author: Kyle M Hall Date: Thu Feb 20 06:26:25 2014 -0500 Bug 5377: (follow-up) alter deletedbiblioitems to match biblioitems Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit b47eac0a6e86ed863921969ff2be703f54f46f52 Author: Kyle M Hall Date: Wed Feb 19 16:39:17 2014 -0500 Bug 5377: widen columns to better accommodate multiple ISBN and ISSN Test Plan: 1) Apply this patch 2) Create a record with 5 ISBNs and 5 ISSNs 3) Create a new report from the following SQL, or execute it from the mysql console: SELECT isbn, issn FROM biblioitems ORDER BY biblionumber DESC LIMIT 1 4) Note that all your ISBNs and ISSNs are listed, separated by the pipe character ( | ) Signed-off-by: Chris Cormack This might be slow to run on big databases, because of the 2 index rebuilds, however it changes no functionality just increases the field size which is safe enough (we store multiple now already) Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Biblioitem.pm | 14 ++++++-------- Koha/Schema/Result/Deletedbiblioitem.pm | 14 ++++++-------- installer/data/mysql/kohastructure.sql | 14 +++++++------- installer/data/mysql/updatedatabase.pl | 26 ++++++++++++++++++++++++++ kohaversion.pl | 2 +- 5 files changed, 46 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 21:08:47 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 19:08:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1184-g036f2a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 036f2a50e11dab97ef8509f2f585c4cc407ea728 (commit) via e67463e8b18565d677ea57e63bdbb6a56992037f (commit) via 8d5d319f6258e1356860663410329ada72daef60 (commit) via c1b782b6346b2324d3ef39e602bc9b53c876ce13 (commit) via ed4b60fa1dca40d0d0bcf4880fd5f2892a15f90f (commit) from 89752a126d005cc763d93eb5e543b1f829bed039 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on The original patch did not correctly construction ISBN phrase searches when QP is on. Unfortunately, when attempting to fix that, I discovered that there's a deep bug in QP that makes it generate incorrect search queries when combining more than two atoms in with the || operator. Consequently, until that can be fixed, this patch ensures that if UseQueryParser is on, AggressiveMatchOnISBN has no effect. To state it anther way, AggressiveMatchOnISBN works only when QP is not in use. Signed-off-by: Galen Charlton commit e67463e8b18565d677ea57e63bdbb6a56992037f Author: Galen Charlton Date: Mon May 5 18:25:10 2014 +0000 Bug 10500: DBRev 3.15.00.050 Signed-off-by: Galen Charlton commit 8d5d319f6258e1356860663410329ada72daef60 Author: Kyle M Hall Date: Wed Apr 16 11:03:54 2014 -0400 Bug 10500: (follow-up) add checks for empty isbn Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit c1b782b6346b2324d3ef39e602bc9b53c876ce13 Author: Jonathan Druart Date: Fri Sep 13 10:43:09 2013 +0200 Bug 10500: (follow-up) adjust for name of UNIMARC ISBN indexes In UNIMARC, the isbn index is ISBN. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit ed4b60fa1dca40d0d0bcf4880fd5f2892a15f90f Author: Kyle M Hall Date: Thu Jun 20 10:45:44 2013 -0400 Bug 10500: Improve ISBN matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 115 ++++++++++++++++++-- C4/Matcher.pm | 16 ++- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 20 ++++ .../en/modules/admin/preferences/cataloguing.pref | 8 ++ kohaversion.pl | 2 +- t/Koha.t | 8 +- 7 files changed, 160 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 22:10:23 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 20:10:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1186-ge590436 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e590436ee4c85ccb2bc0c556185895e15ca37ce1 (commit) via 67abcc64433ba945416c7c8e8bf8aecc8c932f14 (commit) from 036f2a50e11dab97ef8509f2f585c4cc407ea728 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e590436ee4c85ccb2bc0c556185895e15ca37ce1 Author: Marcel de Rooy Date: Wed Mar 26 15:25:43 2014 +0100 Bug 9612: Zconn parameters and elementSetName in _new_Zconn This patch makes a few adjustments in C4::Context::Zconn. It does no longer pass the (ignored) auth, syntax parameters to _new_Zconn. Note that auth was not completely ignored in theory, but we never pass auth=1 [while not having user/password in koha-conf]. Furthermore, it removes the elementSetName for dom indexing. Using marcxml here does not make a difference. It only adds a constraint on what is in the dom-config files. (It could probably be removed there now..) Two cosmetic code changes: Removes unused label retry. And moved 'servername' into the database name option. Test plan: When using Zebra with dom indexing, do a biblio and authority search. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 67abcc64433ba945416c7c8e8bf8aecc8c932f14 Author: Marcel de Rooy Date: Thu Mar 20 13:24:11 2014 +0100 Bug 9612: fix SRU response for DOM indexing This patch makes changes to koha-conf.xml by removing the fallback section from biblioserver and authserver. The information is in a include file on the same server (no need to fall back) and moreover, some information is not up-to-date and should be moved elsewhere. The patch also simplifies the DOM retrieval-info files for auth and bib. And eliminates superfluous F and usmarc from the dom-config files. (I felt the urge to remove marcxml too, but left it for now; see also the second patch.) For reference, look at the marcxml example files of Zebra. NOTE: This patch does not deal with the Debian package installs. In the same way koha-conf-site.xml.in, and *-retrieval-info-* could be adjusted. Test plan: [1] Run at least a dev install in order to copy the new files to your Zebra folders. Choose for DOM indexing. Enable the SRU server on port 9998 (small edit in koha-conf.xml). [2] Restart Zebra and reindex -a -b -x. [3] Verify if a search from Koha still functions as expected. Check the SRU output on port 9998. NOTE: If you do not pass recordSchema, you should get back a marc response now (instead of index schema). Bonus: Add your server as a Z3950 target to another Koha install. And perform a Z3950 search from the other server to your new install. Bonus: Check response from the auth and biblio socket via yaz-client. [4] Reindex again with -a -b but without -x. [5] Repeat Koha search, SRU response (Z3950, yaz-client). Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 29 ++-- etc/koha-conf.xml | 198 +---------------------- etc/zebradb/authorities/etc/dom-config-marc.xml | 7 +- etc/zebradb/authorities/etc/dom-config.xml | 7 +- etc/zebradb/biblios/etc/dom-config-marc.xml | 7 +- etc/zebradb/biblios/etc/dom-config.xml | 7 +- etc/zebradb/retrieval-info-auth-dom.xml | 6 +- etc/zebradb/retrieval-info-bib-dom.xml | 6 +- 8 files changed, 24 insertions(+), 243 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 23:19:06 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 21:19:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1190-g0e59a18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0e59a18f8e4613afbfb13471fcbed2aee77ef5ce (commit) via fc1f90abc1e408b3ff23e4a5210c29719d76fde3 (commit) via 6a9323ab343c4bb6ffbcf9a69d48947822f691db (commit) via 6dd221223f1a1bd4c8b15e0342b66f75ddc32b9d (commit) from e590436ee4c85ccb2bc0c556185895e15ca37ce1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0e59a18f8e4613afbfb13471fcbed2aee77ef5ce Author: Galen Charlton Date: Mon May 5 21:42:13 2014 +0000 Bug 10857: (follow-up) make it possible to remove facets that contain diacritics Signed-off-by: Galen Charlton commit fc1f90abc1e408b3ff23e4a5210c29719d76fde3 Author: Jonathan Druart Date: Fri Jan 10 17:22:47 2014 +0100 Bug 10857: (follow-up) update Bootstrap theme Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 6a9323ab343c4bb6ffbcf9a69d48947822f691db Author: Julian Maurice Date: Mon Nov 4 15:19:13 2013 +0100 Bug 10857: (follow-up) encode 'limit' parameter values to allow facets with '&' character. Signed-off-by: sonia bouis Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 6dd221223f1a1bd4c8b15e0342b66f75ddc32b9d Author: Jonathan Druart Date: Tue Jun 11 11:31:49 2013 +0200 Bug 10857: add ability to remove active facets when refining search results When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link "[x]" at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets Signed-off-by: sonia bouis Signed-off-by: Katrin Fischer Patches pass all tests and QA script. Nice feature! Tested in Boostrap and Prog, adding end removing multiple facets in different sequences, adding and removing the availability limit. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 4 +-- catalogue/search.pl | 16 ++++++++- .../intranet-tmpl/prog/en/includes/facets.inc | 34 ++++++++++++------ .../bootstrap/en/includes/opac-facets.inc | 22 +++++++++--- .../opac-tmpl/prog/en/includes/opac-facets.inc | 38 ++++++++++++++------ opac/opac-search.pl | 15 +++++++- 6 files changed, 100 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 23:31:25 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 21:31:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1193-g845af19 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 845af199157ffb82f93d33682ea9910fb38af8b7 (commit) via 8e71489c33115254a8a95be7a4b1a82b605918c9 (commit) via a97926a999e979c64cf4a278fe0dd3a8250f60b6 (commit) from 0e59a18f8e4613afbfb13471fcbed2aee77ef5ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 845af199157ffb82f93d33682ea9910fb38af8b7 Author: Bernardo Gonzalez Kriegel Date: Sun Apr 20 20:23:51 2014 -0300 Bug 8375: (follow-up) fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. Added a FIXME for the hardcoded forced oblique -chris_n Signed-off-by: Chris Nighswonger Signed-off-by: Galen Charlton commit 8e71489c33115254a8a95be7a4b1a82b605918c9 Author: Dobrica Pavlinusic Date: Thu Jul 19 23:57:28 2012 +0200 Bug 8375: Use TrueType fonts in PDF::Reuse Since built-in PDF fonts suport just Latin-1 encoding, we have to switch to TrueType fonts to correctly encode all UTF-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to TrueType fonts which are included in koha-conf.xml under new section. Without this directive in kona-conf.xml code will still use Latin-1 built-in pdf fonts. Signed-off-by: Kyle M Hall Signed-off-by: Chris Nighswonger Signed-off-by: Galen Charlton commit a97926a999e979c64cf4a278fe0dd3a8250f60b6 Author: Galen Charlton Date: Fri May 31 14:16:05 2013 -0700 bug 9854: add ttf-dejavu as dependency for Debian packages ttf-dejavu (i.e., the core and extra DejaVu TrueType) fonts are used by the proposed fix for bug 8375. To test, build and install the Koha packages for Debian and verify that the ttf-dejavu package is installed. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Chris Nighswonger Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Creators/Lib.pm | 1 + C4/Creators/PDF.pm | 15 +++++++++++++-- C4/Labels/Label.pm | 4 +++- debian/control | 2 ++ debian/control.in | 2 ++ etc/koha-conf.xml | 17 +++++++++++++++++ labels/label-create-pdf.pl | 7 +++---- 7 files changed, 41 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 23:35:00 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 21:35:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1194-gbd43952 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bd4395235c384f0a44248874449bf8d75f07cc5b (commit) from 845af199157ffb82f93d33682ea9910fb38af8b7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd4395235c384f0a44248874449bf8d75f07cc5b Author: Galen Charlton Date: Mon May 5 21:59:50 2014 +0000 Bug 10807: (follow-up) exclude C4::Search::History from t/00-load.t Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: t/00-load.t | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 5 23:49:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 21:49:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1196-g2626311 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2626311e5e6a635e97ff9041be1c57217a081acc (commit) via b2484b22f7d08d215d615df056c2d007fab0c151 (commit) from bd4395235c384f0a44248874449bf8d75f07cc5b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2626311e5e6a635e97ff9041be1c57217a081acc Author: Paul Poulain Date: Tue Oct 22 01:38:59 2013 +0200 Bug 10798: (follow-up) replace tabs by spaces Signed-off-by: Paul Poulain Signed-off-by: Galen Charlton commit b2484b22f7d08d215d615df056c2d007fab0c151 Author: Martin Renvoize Date: Wed Aug 28 16:00:37 2013 +0100 Bug 10798: make OPAC_SEARCH_LIMIT behaves better with search groups Since the addition of search groups to Koha, the branch limiting parameter in multiple PAC by URL support should also support limiting by these search groups. This patch adds this ability. Signed-off-by: Srdjan Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 00:12:04 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 22:12:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1197-gb35665b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b35665ba9dd1f209b500cc160a36d3b4dde1bb74 (commit) from 2626311e5e6a635e97ff9041be1c57217a081acc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b35665ba9dd1f209b500cc160a36d3b4dde1bb74 Author: Kyle M Hall Date: Fri Nov 22 09:15:31 2013 -0500 Bug 11287: make patron import tool take new restrictions system into account The import patrons tool will add restrictions in the previous style ( directly to the borrowers table ). This will actually work, but will result in the restriction being un-removable, and will be overwritten by any new restrictions. Test Plan: 1) Apply this patch 2) Import new patrons with debarrments, note the debarment is created correctly 3) Import existing patrons with overwrite enabled, note that any new debarrment is added, and any existing debarrment is ignored Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: Koha/Borrower/Debarments.pm | 2 +- tools/import_borrowers.pl | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 01:16:24 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 23:16:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.14.00-1199-g2cd3b00 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2cd3b00e902ef91bed0c4bec822f31ed9c16e992 (commit) via 6d1baba171e3916fc927e03f6d20017abeaf474f (commit) from b35665ba9dd1f209b500cc160a36d3b4dde1bb74 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2cd3b00e902ef91bed0c4bec822f31ed9c16e992 Author: Galen Charlton Date: Mon May 5 23:27:44 2014 +0000 DBRev 3.15.00.051: mark Koha 3.16 beta Signed-off-by: Galen Charlton commit 6d1baba171e3916fc927e03f6d20017abeaf474f Author: Galen Charlton Date: Mon May 5 23:26:31 2014 +0000 release notes for Koha 3.16.0-beta Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 6 + kohaversion.pl | 2 +- misc/release_notes/release_notes_3_16_0.txt | 1265 +++++++++++++++++++++++++++ 3 files changed, 1272 insertions(+), 1 deletion(-) create mode 100644 misc/release_notes/release_notes_3_16_0.txt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 01:16:40 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 May 2014 23:16:40 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.16.00-beta created. v3.16.00-beta Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.16.00-beta has been created at 30a58c58bee8c973753325a98800124330455c6e (tag) tagging 2cd3b00e902ef91bed0c4bec822f31ed9c16e992 (commit) replaces v3.14.00 tagged by Galen Charlton on Mon May 5 23:29:09 2014 +0000 - Log ----------------------------------------------------------------- Koha 3.16.0 beta -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlNoHsUACgkQ+ECRQ8R3E0O3GACbBEExs5kg8LlG1pVE+tUP/r5N /J8An1vFjT6CSlHW/BXqyX953w3ypeun =jmpg -----END PGP SIGNATURE----- A. Sassmannshausen (2): Bug 11762 - intranet & prog: Re-order 245 $a $b $h in results. Bug 11762 - bootstrap: Re-order 245 $a $b $h in results. Adrien Saurat (1): Bug 9865: make SIP msg encoding configurable via SIPconfig.xml Aleisha Amohia (1): Bug 11541: increase test coverage of Installer.pm Amit Gupta (1): Bug 11777: ensure "created by" is displayed by the order receiving page Bernardo Gonzalez Kriegel (21): Bug 5031: (follow-up) correct tabs Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update Bug 7934: generate separate PO files for help pages Translation update - split staff UI and help files Bug 11330: fix inconsistent field/subfield descriptions on MARC21 bibliographic frameworks Bug 11453: Update EN default UNIMARC bibliographic framework Bug 11094 - Bootstrap theme: fix typo "loaction" Bug 11973 - Fix Armenian language description Bug 11993: fix untranslatable confirm popup in request.tt Bug 11393: fix display of Thai in language menu when Thai translation is installed Bug 10818: improve display and translatability of sysprefs OAI-PMH:ConfFile's description Bug 10790: fix misalignment in item type form when noItemTypeImages is off Bug 11885: (follow-up) remove tabs Bug 5052: make it possible to pick a language if all choices are sublanguage Bug 12081: make tmpl_process3.pl delete ts temp files Bug 11508: fix untranslatable pull-down in auth_subfields_structure.pl Bug 11639: fix untranslatable strings in 007 builder Bug 11646: fix untranslatable confirm popup in field 006 and 008 builders Bug 11497: remove TT construct for picking a default string that i18n toolchain fails to pick up Bug 11227: remove some JavaScript from staff PO files Bug 8375: (follow-up) fix font code and alignment Blou (3): Bug 11035: Replace shortcut plugin jquery.hotkeys.min.js Bug 11035: (follow-up) update offline circ manifest Bug 11752: display the correct frequency for serial subscriptions in OPAC details Chris Cormack (17): Bug 11307: Fix potential XSS attack in public catalog RSS feed Bug 11307: (follow-up) apply fix to bootstrap theme (master and 3.14.x only) Bug 11308: fix RSS page in bootstrap theme Bug 11322: fix XSS bug in purchase suggestions pages Bug 11322: fix XSS bug in purchase suggestions - OPAC Bug 11322: rscrub bad data before storing suggestions in the DB Bug 11341: fix XSS bug in opac-search.pl (facets) Bug 11290: fix display of patron home page for certain translations Bug 11192: (follow-up) fix a little typo Bug 11457: avoid spurious test failure in t/db_dependent/Bookseller.t Bug 7965: Silence warns in staff log Bug 11452: Add unit tests for Koha::Template::Plugin::Cache Bug 7143: Updating about page and history Bug 11660: remove disused tools/pdfViewer.pl Bug 11661: sanitize file names supplied to edithelp.pl Bug 7143: Updating history with new developers Bug 9915: Allow sql_params to be passed to a report using the OPAC svc/report interface Chris Hall (1): Bug 6739: make it possible to block expired patrons from OPAC actions Chris Nighswonger (1): Bug 12040: Add 3 parameters to runreport.pl for SMTP authentication Claire Stent (1): Bug 11101: add CSS selector to item types facet label in OPAC Colin Campbell (12): Bug 10996: Allow numeric subfields to be stripped on export Bug 11032: Check a valid MARC::Record passed to Biblio Bug 10983: Remove unused private subroutines from C4::Budgets Bug 6331: (follow-up) do not populate deleteditems.marc Bug 11474: Remove errors caused by use of given/when statement Bug 11468: Remove given/when from Koha::Dateutils Bug 11480: Fix invalid assumptions in JSONStream test Bug 10789: Remove unnecessary calls to $sth->finish in C4::Acquisitions Bug 11478: Replace experimental given/when keywords Bug 11479: Remove experimental given/when keywords Bug 12131: Remove unused dependency on Exporter Bug 10729: Add phrases configuration for ICU Dan Scott (1): Bug 11786: Improve RDFa structured data schema.org mappings Daniel Barker (1): Bug 8168: Fixing header of non CSV files for overdue notices David Cook (10): Bug 11502: make library filter in "Holds To Pull" more precise Bug 11473 - Fix log viewer template conditions Bug 11473 - Remove boilerplate in log viewer template Bug 11473 - Improve wording in log viewer template Bug 11473 - add 'biblio' and 'item' to cataloguing logging info Bug 11477 - Add names for librarian and borrowers in the logs Bug 11486: Show renewal count on 'check out' and 'details' tabs in patron record Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults Bug 11465: Show counts and amounts on OPAC 'your summary' tabs Bug 12127: fix incorrect DataTable types in Holds to Pull list Dobrica Pavlinusic (2): Bug 7844: Plack intranet tooling for developers Bug 8375: Use TrueType fonts in PDF::Reuse Doug Kingston (3): Bug 6435: Add daemon mode to rebuild_zebra.pl Bug 6435: (follow-up) rebuild_zebra -daemon option now smarter Bug 11078: Add locking to rebuild_zebra Emma Heath (1): Bug 11540: increase test coverage of Charset.pm Francesca Moore (3): Bug 11522: improve formating of self-registration form Bug 11312: make facets selectable using an ID -- opac-bootstrap Bug 11231: remove reference to ambiguous notes column from two hold request reports Fridolin SOMERS (1): Bug 11516: make OPAC search term highlighting work in results browser Fridolin Somers (17): Bug 11649 - Always use words "copy number" - intranet Bug 11649 - Always use words "copy number" - opac bootstrap Bug 11649 - Always use words "copy number" - opac prog Bug 11707: fix editing additional attributes for patron whose category code includes a space Bug 11648 - Use word item instead of copy - intranet Bug 11648 - Use word item instead of copy - opac bootstrap Bug 11648 - Use word item instead of copy - opac prog Bug 11845 - set overlay and import status translatable in addorderiso2709.tt Bug 11366: make "no group" option in acq basket group drop-down translatable Bug 11563: restore preventing the enter key from submitting several forms Bug 11846: Correct database update for restrictions with date 9999-12-31 Bug 12071: improve generation of Z39.50 search links Bug 11369: (follow-up) Correct usage of me.searchid in browser.js Bug 11369: (follow-up) generate searchid in browser.js Bug 11635: remove duplicate definition of 995$r in UNIMARC record.abs Bug 12046: Authentication using CAS - bootstrap Bug 11219: (follow-up) fetch only URL parameters Fridolyn SOMERS (33): Bug 10809: use branches template plugin in serials search Bug 11245: fix typo in modborrowers.tt javascript string Bug 11146: Show a go back link on no permission page Bug 11275: make deleteditems.materials be of type text Bug 11214: improve create/edit routing list links in serial collection page Bug 7484: keep selected values when changing search type on authority search form Bug 11059: (follow-up) restore time in staged dates in addorderiso2709.tt Bug 11091: revamp search limit options for new subscription bib search form Bug 11091: (follow-up) perltidy on serials/subscription-bib-search.pl Bug 10808: make authority search form retain drop-down selections Bug 10808: (follow-up) reformat auth_finder.pl Bug 11009: Do not display circulation history of anonymous patron Bug 11249: Add Db indexes on borrowers names Bug 7518: certain searches with quotation marks don't work Bug 11166: make library filter in funds administration page more precise Bug 6331: remove obsolete column deleteditems.marc Bug 6331: (follow-up) update timestamp when deleting items Bug 11338: prevent deletion of items that are captured for holds Bug 10429: improve display of library and library filter on serials claim page Bug 11313: supply empty value in mandatory comboboxs in MARC record editors Bug 10544: ensure that stocknumber searches work for MARC21 Bug 10544: add Number-local-acquisition in known indexes Bug 10544 - add Number-local-acquisition in QueryParser config Bug 3445: add more indexes on the action_logs table Bug 9578: avoid a search crash when attempting to sort results of invalid query Bug 11069: increase title ranking in relevance when using QueryWeightFields Bug 11254: make reservoir search normalize ISBNs Bug 7442: fix crash when selecting an authority with 200$x or 200$y (UNIMARC) Bug 7442 (follow-up) ensuring that summary is display when searching on all types of authorities Bug 6739: (follow-up) fix more issues Bug 6739: (follow-up) more fixes Bug 11219: make CAS authentication work with URL parameters Bug 9532: fix reservability check when bib-level item types are in use Fr?d?ric Demians (6): Bug 11304: fix display of detail page holdings tab in translated Bootstrap theme Bug 11277: fix errors with search facet links in Bootstrap theme Bug 11663: fix display of holding tab in Bootstap OPAC when opacbookbag syspref is disabled Bug 12073: don't show link URLs when printing Bootstrap OPAC detail page Bug 12048: restore ability of superlibrarian to see other libraries' subscriptions Bug 12080: restore effect of superserials permission Fr?d?rick (3): Bug 11359: Add the borrower's cardnumber and phonenumber to the branch overdues report Bug 11869: Add more informations to the patron account printing page Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record. Gaetan Boisson (1): Bug 11417: make sure remove_unused_authorities.pl accepts --test Galen Charlton (314): Merge branch 'new/bug11205' Merge branch 'new/bug11216' Merge branch 'new/bug11137' Merge branch 'new/bug10684_take2' Merge branch 'new/bug11196' Merge branch 'new/bug11240' Merge branch 'new/bug10670' Bug 9261: (follow-up) improving implementation of page title and breadcrumbs Merge branch 'new/bug10671' Merge branch 'new/bug11185' Merge branch 'new/bug11163' Merge branch 'new/bug11221' Merge branch 'new/bug8854' Merge branch 'new/bug11269' Merge branch '3.14.x' Merge branch '3.14.x' DBRev 3.15.00.000: on to what comes after Pi Bug 6435: (follow-up) make -daemon really imply -a and -b Bug 11040: DBRev 3.15.00.001 Bug 11275: DBRev 3.15.00.002 Bug 11275: (follow-up) update DBIC schema class files Bug 7791: (follow-up) adjust wording of basket deletion confirmation dialog Bug 11035: (follow-up) move shortcut.js Bug 11035: (follow-up) update licenses section Bug 11111: (follow-up) fix column sorting on parcels page Bug 2546: DBRev 3.15.00.003 Bug 11333: use jQuery validator plugin for CSV profiles forms Bug 10970: (follow-up) update framework only for MARC21 installations Bug 10970: DBRev 3.15.00.004 Bug 11112: (follow-up) repair Koha::Calendar->add_holiday() Bug 11112: (follow-up) add FIXME Bug 11009: (follow-up) tweak wording and remove potential log noise Bug 8230: DBrev 3.15.00.005 Bug 8230: (follow-up) don't link to basket unless user has appropriate permissions Bug 8230: (follow-up) fix detection of cancelled orders Bug 8230: (follow-up) repair regression on order search Bug 8230: (follow-up) update POD for C4::Acquisition::GetHistory Bug 10852: (follow-up) tweak wording of serials search form Bug 10852: (follow-up) fix POD for C4::Serials::NewSubscription Bug 10852: (follow-up) regression tests Bug 10852: (follow-up) update the POD for C4::Serials::SearchSubscriptions Bug 11249: DBRev 3.15.00.006 Bug 7518: regression test double-quote in search operand Bug 9807: (follow-up) quell warning if invoice price not set Merge branch '3.16-help-split' of https://github.com/bgkriegel/koha-translate Bug 9673: DBRev 3.15.00.007 Bug 9673: (follow-up) update DBIx::Class schema classes Bug 11179: (follow-up) add comment to item-status.inc Bug 10626: (follow-up) replace use of KohaAuthorisedValues in the Bootstrap theme Bug 11155: remove old PostgreSQL schema and MARC framework scripts Bug 11384: rename the collections_tracking.ctId column Bug 11384: (follow-up) update DBIC schema classes Bug 11384: DBRev 3.15.00.008 Bug 11391: drop default value on suggestions.suggesteddate column Bug 11391: (follow-up) update DBIC schema classes Bug 11391: DBRev 3.15.00.009 Bug 6331: DBRev 3.15.00.010 Bug 6331: (follow-up) update DBIC schema classes Bug 9940: (follow-up) add language-original to QP search field list Bug 11338: add unit tests for DelItemCheck Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl Bug 11338: (follow-up) take IndependentBranches into account for DelItemCheck() test Bug 8018: DBRev 3.15.00.011 Bug 11445: regression test for duplicate hold notifications Bug 11445: avoid sending duplicate hold waiting notifications Bug 11402: (follow-up) add one more unit test Bug 11208: regression test for failing SMS messages Bug 10277: (follow-up) if no userenv is set, act like a superlibrarian Bug 11066: (follow-up) add regression test Bug 11336: (follow-up) correct change to POD for GetReserve() Bug 11336: (follow-up) improve POD for _FixPriority() Bug 11470: fix occassional spurious test failure in Circulation_transfers.t Bug 7002: fix some invalid superlibrarian permission checks Bug 11474: (follow-up) correct typos in POD Bug 11336: (follow-up) fix typo in previous follow-up Bug 6886: (follow-up) remove redundant test for singleBranchMode Bug 10863: DBRev 3.15.00.012 Bug 10863: (follow-up) set correct description for manage_restrictions permission during upgrade Bug 10863: (follow-up) give limited circ operator way to proceed Bug 11260: (follow-up) remove inadvertant change to English sample_z3950_servers.sql Bug 11260: (follow-up) repair German sample_z3950_servers.sql Bug 11483: (follow-up) fix typos Bug 10774: (follow-up) tweak styling of buttons on Bootstrap theme Bug 10952: (follow-up) clear seach history from session after saving it to DB Bug 10952: (follow-up) remove mention of KohaOpacRecentSearches cookie Bug 11509: (follow-up) fix a couple typos Bug 11389: reenable Pg as a DB scheme that Koha can connect to Bug 11535: sanitize input from patron self-registration form Bug 11537: (follow-up) mock C4::Context::preference Bug 11545: (follow-up) move Languages.t to t/db_dependent Bug 11541: (follow-up) update tests Bug 11541: (follow-up) move Installer.t to t/db_dependent Bug 7143: add another name to the about page Bug 10691: (follow-up) replace HTML comments with TT contents Bug 10987: (follow-up) fix display of authorities containing only one see from or see also lnik Bug 9788: (follow-up) update the bootstrap theme Bug 11473: (follow-up) ensure link to item is construct correctly Bug 11477: (follow-up) improve display of user/patrons in logs tool Bug 11237: DBRev 3.15.00.013 Bug 10922: (follow-up) remove display of form parameter Bug 11415: DBRev 3.15.00.014 Bug 10907: DBRev 3.15.00.015 Bug 10907: (follow-up) fix table sorting Bug 10907: (follow-up) fix typo... Bug 11533: fix authority searching with no sorting when QueryParser is enabled Bug 11314: (follow-up) make another "All" translatable Bug 11439: (follow-up) adjust for change in list returned by OCLC XISBN Bug 9823: (follow-up) improve POD for C4::Reserves::GetReservesFromBiblionumber Bug 11616: (follow-up) remove tablesorter CSS Bug 11268: DBRev 3.15.00.016 Bug 11268: (follow-up) update DBIC schema classes Bug 11513: (follow-up) format enrollment end date consistently Bug 10811: (follow-up) use "local-number" rather than "Local-Number" Bug 11619: (follow-up) fix QueryParser.t Bug 11662: remove disused member-picupload.pl Bug 11666: add permission check for MARC framework import/export Bug 11666: remove SQL as an option for MARC framework exports and imports Bug 11757: remove dependency on POE Bug 11310: update the XSLT for the Bootstrap theme Bug 11772: (follow-up) make warning about no active currency a link to currency setup page Bug 11779: (follow-up) improve GetLoggedInBranchcode() and add test cases Bug 11777: add regression test Bug 11644: (follow-up) add FIXME Bug 10544: (follow-up) update MARC21 DOM index definitions Bug 11202: (follow-up) update number of expected tests for t/QueryParser.t Bug 11611: DBRev 3.15.00.017 Bug 7372: DBRev 3.15.00.018 Bug 7372: (follow-up) remove last traces of roadtype table and admin pages Bug 10580: (follow-up) tweak wording about looking for zebrasrv & zebraidx Bug 11256: DBRev 3.15.00.019 Bug 11256: (follow-up) tweak description of the OpacMaxItemsToDisplay syspref Bug 11096: add regression tests for indexing/retrieving large MARC records Bug 11078: (follow-up) tidy code Bug 11866: (follow-up) repair security issue introduced by main patch Bug 11860: (follow-up) standardize spelling of "call number" Bug 10558: (follow-up) choose label for matching records correctly Bug 11224: (follow-up) incorporate test for bug 11777 Bug 11224: (follow-up) apply tidying Bug 11224: (follow-up) clean up unit test for bug 10723 Bug 8918: (follow-up) tidy code and description of CalculatePriority() Bug 10452: (follow-up) remove duplicate check of damaged status Bug 10955: (follow-up) improve usage information Bug 11605: (follow-up) use DT defaults for the new Ajax staged batch page Bug 11343: DBRev 3.15.00.020 Bug 11343: tweak wording of the syspref editor for MaxItemsForBatch Bug 3445: DBRev. 3.15.00.021 Bug 10611: (follow-up) cache DBMS driver code in context object Bug 10777: (follow-up) improve CSS3 for Zebra-striping report email output Bug 11751: DBrev 3.15.00.022 Bug 10861: DBrev 3.15.00.023 Bug 10861: (follow-up) use minlength/maxlength rather than pattern for client-side validation Bug 108661: (follow-up) enshrine letting CardnumberLength specify just a maximum Bug 10012: remove last traces of NoZebra Bug 10012: DBRev 3.15.00.024 Bug 11820: remove dead code in basket group management Bug 11459: use drop-down to set OrderPdfFormat syspref Bug 11928: DBRev 3.15.00.025 Bug 11647: (follow-up) add comment expressing that user must be logged in Bug 11934: (follow-up) tidy up whitespace Bug 11973: DBRev 3.15.00.026 Bug 11701: (follow-up) move unit tests to t/db_dependent Bug 11906: regression test for using DBIC to store & fetch UTF8 strings Bug 11906: ensure that Koha::Database uses UTF8 mode when connecting to databases Bug 12000: ensure that hold resumption dates can be set only to future dates Bug 7567: DBRev 3.15.00.027 Bug 7567: (follow-up) make tests of get_opac_new more readable Bug 7567: (follow-up) construct values clause in SQL statement more idiomatically Bug 7413: DBRev 3.15.00.028 Bug 7413: update DBIC schema classes Bug 7413: (follow-up) validate norenewalbefore values better Bug 7413: (follow-up) improve return of GetSoonestRenewDate() Bug 7413: (follow-up) add direct unit tests Bug 7413: (follow-up) teach renew interface about too_soon Bug 7413: (follow-up) tweak description of the AllowRenewalLimitOverride syspref bug 10865: (follow-up) allow patrons to make their public lists private when OpacAllowPublicListCreation is off Bug 11441: (follow-up) improve utility help text Bug 11598: (follow-up) improve help text for --html and --text options Bug 11563: (follow-up) remove some tabs Bug 12076: better detect an untranslatable template construct Bug 11846: DBrev 3.15.00.029 Bug 11797: add regression test Bug 11797: (follow-up) fix MARC21 branch of bug more idiomatically Bug 12052: DBrev 3.15.00.023 Bug 11630: (follow-up) tighten up code Bug 11484: (follow-up) standardize capitalization of "Z39.50" Bug 12079: ensure that CheckReserves() includes reserve_id in its response Bug 9448: (follow-up) tweak description of new permissions Bug 9448: DBRev 3.15.00.031 Bug 9448: (follow-up) prevent unauthorized operator from bypassing check on forgiving overdue fines Bug 11869: (follow-up) only display active fines Bug 12048: add regression test Bug 12098: (follow-up) deal with FIXMEs in t/db_dependent/Serials_2.t Bug 12098: (follow-up) put can_show_subscription() into use Bug 11689: (follow-up) fix another warning when running Serials.t Bug 11148: (follow-up) add more test cases Bug 9578: add regression test Bug 9578: (follow-up) bump up number of MARC21/DOM tests Bug 11699: (follow-up) fix errors in the POD for ModReceiveOrder Bug 11699: (follow-up) update one more test that uses ModReceiveOrder Bug 9416: DBrev 3.15.00.032 Bug 9416: (follow-up) update DBIC schema classes Bug 9416: (follow-up) reconcile with work done on bug 11699 Bug 9416: (follow-up) teach ordering from staged files about the notes fields Bug 11489: (follow-up) fix tab Bug 10951: DBrev 3.15.00.032 Bug 10951: (follow-up) use Koha.Preference() template function Bug 10951: (follow-up) tweak description of the NoLoginInstructions system preferences Bug 10951: (follow-up) add support for NoLoginInstructions to Bootstrap theme Bug 10986: DBRev 3.15.00.034 Bug 10986: (follow-up) add unit tests for getLanguages() and language filter Bug 10986: (follow-up) improve POD Bug 9972: (follow-up) add new indexes to the QueryParser config Bug 9972: (follow-up) enable Lexile searches to work using QueryParser Bug 11596: (follow-up) ensure all warnings are reported Bug 9288: (follow-up) more tweaks Bug 9032: DBrev 3.15.00.035 Bug 9032: (follow-up) wording tweaks Bug 9032: (follow-up) add libemail-valid-perl as a Debian dependency Bug 9032: (follow-up) code tidying Bug 9032: (follow-up) restore documented intepretation of virtualshelfshares.sharedate Bug 9915: (follow-up) use SQL placeholders Bug 8262: (follow-up) correct comment Bug 11552: (follow-up) fix a typo in a comment Bug 7308: (follow-up) tweak style of child fund amounts Bug 11551: (follow-up) standardize label of order number / order line Bug 11027: (follow-up) change label "Branch" to "Library" Bug 11027: (follow-up) update unit test to reflect new columns returned by GetLateOrders Bug 7288: (follow-up) various fixes Bug 7288: (follow-up) add unit test for is_linked_to_subscriptions flag Bug 10859: DBRev 3.15.00.036 Bug 10859: (follow-up) clarify logic on multiple loans on same bib Bug 10942: (follow-up) create a /etc/koha/koha-common.conf Bug 10942: (follow-up) make AUTOMATIC_TRANSLATIONS_UPDATE default to yes Bug 12112: remove disused routine C4::Breeding::ImportBreeding() Bug 12111: (follow-up) ensure that vendor note is not editable during order receiving Bug 12134: (follow-up) fix one of the IsDebarred() tests Bug 11351: (follow-up) fix typos in seed SIP2 media types Bug 11351: DBrev 3.15.00.037 Bug 11351: (follow-up) update DBIC schema classes Bug 11351: (follow-up) ensure itemtypes.sip_media_type is set to NULL when cleared Bug 12100: (follow-up) fix regression Bug 11334: (follow-up) add spans for new facets Bug 11334: DBRev 3.15.00.038 Bug 11182: (follow-up) improve initialization of the $waiting_holds variable Bug 7844: (follow-up) don't test koha.psgi for ability to compile (yet) Bug 11334: (follow-up) teach the search tests to mock the DisplayLibraryFacets syspref Bug 6273: (follow-up) fix various issues Bug 11182: (follow-up) fix regression where session branch wasn't initialized Bug 9016: DBRev 3.15.00.039 Bug 9016: (follow-up) update DBIC schema classes Bug 11868: (follow-up) correct case of "SMS" Bug 10845: DBrev 3.15.00.040 Bug 10845: (follow-up) update how a test case counts print hold available notices Bug 3.15.00.041: DBrev 11867 Bug 9016: (follow-up) move insertAtCaret plugin out of language-specific directory Bug 9016: (follow-up) treat missing transports for hold available notices as warnings, not fatal errors Bug 9016: (follow-up) treat missing transports for predue and item due notices as warnings, not fatal errors Bug 9016: (follow-up) treat missing transports for overdue notices as warnings Bug 9016: (follow-up) standardize case of message transport type columns Bug 10694: DBrev 3.15.00.042 Bug 10694: (follow-up) remove truncate table from test case Bug 10694: (follow-up) fix problems with the new Borrowers plugin Bug 10694: (follow-up) display the note about restricted patrons consistently Bug 11578: (follow-up) fix JavaScript error Bug 11763: (follow-up) do not display anything in actions column if user cannot manage a budget Bug 11665: (follow-up) simplify code Bug 7180: (follow-up) use "MARC record" instead of "marcrecord" Bug 7180: DBRev 3.15.00.043 Bug 7180: (follow-up) point to new location of the jQuery checkboxes plugin Bug 7180: (follow-up) require an authenticated session to use the AJAX authval dropbox Bug 7180: (follow-up) fix warnings Bug 7180: (follow-up) fix regression on bug 6074 Bug 7180: (follow-up) restore ability to select bibs in middle of import batch Bug 10875: (follow-up) make displaying/hiding inactive funds work cross-browser Bug 9593: DBRev 3.15.00.044 Bug 9593: update DBIC files Bug 9593: (follow-up) don't make currency.isocode required Bug 766: (follow-up) move copyright statement back to the top Bug 766: (follow-up) point acqui/ajax-getauthvaluedropbox.pl at the new location of GetAuthvalueDropbox Bug 766: (follow-up) improve usage comments in new TT include Bug 11466: (follow-up) add additional test Bug 7442: (follow-up) restore display of heading type for non-UNIMARC Bug 7442: (follow-up) apply change to Bootstrap theme Bug 6739: DBRev 3.15.00.045 Bug 6739: (follow-up) do NOT activate new feature by default during upgrade Bug 6739: (follow-up) update DBIC schema classes Bug 6739: (follow-up) add unit tests for GetMemberDetails()->{is_expired} Bug 6739: (follow-up) tweak wording Bug 10807: DBrev 3.15.00.046 Bug 10807: (follow-up) update DBIC schema classes Bug 10807: (follow-up) use 24-hour time when storing search times to session Bug 10807: (follow-up) remove comment about routine that is no longer present Bug 10862: DBrev 3.15.00.047 Bug 8952: (follow-up) remove hard-coded LFTL ID added by a previous patch Bug 8952: (follow-up) apply link change for social networks to Bootstrap theme Bug 7442: (follow-up) adjust UNIMARC test case to match change in BuildSummary() Bug 11848: (follow-up) update license statment Bug 4397: (follow-up) adjust unit test reflect return of display version of scan terms Bug 10195: DBRev 3.15.00.048 Bug 10195: (follow-up) update license; use Modern::Perl Bug 10195: (follow-up) add blocked record template for Bootstrap Bug 10195: (follow-up) tidying up code and eliminate warning if record does not have 942$n Bug 6739: (follow-up) handle case where patron has no expiration date set Bug 11262: (follow-up) base generation of day name on a week starting with Sunday, not Monday Bug 9532: add regression test Bug 5377: DBrev 3.15.00.049 Bug 5377: (follow-up) update DBIC schema classes Bug 10500: DBRev 3.15.00.050 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on Bug 10857: (follow-up) make it possible to remove facets that contain diacritics bug 9854: add ttf-dejavu as dependency for Debian packages Bug 10807: (follow-up) exclude C4::Search::History from t/00-load.t release notes for Koha 3.16.0-beta DBRev 3.15.00.051: mark Koha 3.16 beta Holger Mei?ner (7): Bug 11554: Capitalization fix in patron account on fines tab Bug 7413: Add issuingrules.norenewalbefore to database Bug 7413: Add "No renewal before" to the circulation and fine rules Bug 7413: Code and intranet template changes Bug 7413: OPAC bootstrap theme changes Bug 7413: OPAC prog theme changes Bug 7413: Unit test Ian Walls (1): Bug 6273: add support for recording type of payment made via SIP2 Isaac Brodsky (1): Bug 1047: Punctuation in site names no longer breaks Edit/Delete z39.50 server administration JaTara Barnes (1): Bug 11415: Add syspref to toggle SCO receipt printing Jacek Ablewicz (9): Bug 9224: Make acqui/finishreceive.pl Plack-compatible Bug 9948: fix creation/updating of items when partially receiving an order Bug 11798: fix problems with column sorting and row visibility in invoices table Bug 11352: fix unexpected data loss issues with batch patron deletion/anonymization Bug 11914: fix two issues when creating an order from a suggestion Bug 11680: fix case where tax rate changes unexpectedly on editing an order Bug 11680: (follow-up) fix unexpected tax rate changes on edit Bug 11986: fix searching by tags in OPAC when DOM mode is in use Bug 11665: An ability to place orders directly from hold ratios list Janusz Kaczmarek (1): Bug 11652: ensure that merging authority records corrects biblios Jared Camins-Esakov (1): Bug 10688: Don't prefix index inappropriately Jesse Maseto (2): Bug 11731 - Fixed typo in message_transport_types.txt file. Bug 11695 - Fixed typo in marc21_field_008.xml Jesse Weaver (1): Bug 11978 - Fix URLs displayed in OverDrive search Jonathan Druart (235): Bug 9261: (follow-up) QA improvements and GPL version change Bug 9261: (follow-up) make title required when adding a new suggestion Bug 11207: fix issue where SMS number couldn't be cleared when editing patron Bug 11061: remove unused routine Koha::Calendar::_mock_init Bug 11238: contruct links to the appropriate manual version dynamically Bug 11171: Display basket group name on the supplier list page Bug 11171: (follow-up) fix a javascript error Bug 11286: fix bug preventing adding a new subfield to an authority framework Bug 5031: CSV profiles: validate required content fields Bug 11111: display the basket group name on the parcel page Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname Bug 2546: make description of standard fine types translatable Bug 11265: ensure current locale is selected when editing a subscription Bug 11225: remove \n from some strings to be translated Bug 8683: ensure clear button clears all item fields on order form Bug 10605: fix encoding issue in basket email (OPAC) Bug 10605: fix encoding issue on basket email (INTRANET) Bug 11112: Koha::Calendar needs some caching Bug 8334: (follow-up) remove commented JS code Bug 11261: make sample serial numbering patterns mandatory during installation Bug 11261: make sample serial frequencies mandatory during installation Bug 11255: allow "relevance ascending" as a sort option Bug 11124: disallow trying to run the staff benchmark script as the DB account Bug 8230: Display acquisition details on the catalogue detail page Bug 8230: (follow-up) reflect the fact that order statuses are now alphabetic codes Bug 10852: serials search improvements Bug 10852: (follow-up) rename the "expiration date" filter name Bug 9673: QA followup Bug 11279: (follow-up) remove unnecessary check on number of quotes Bug 11414: warn user about dangerous MARC modification rules Bug 9940: (follow-up) FIX comment: language-original is 101$c, not $h Bug 10453: fix unintended password reset when updating child to adult Bug 11439: UT: fix XISBN.t test failure Bug 11439: UT: Improve XISBN.t Bug 10138: (follow-up) FIX sql errors Bug 11075: 'select all' for export no longer clears renew checkboxes Bug 10277: Add UT for C4::Context::IsSuperLibrarian Bug 11208: If no smsalertnumber is defined, the message is marked as failed Bug 11131: display authority summary correctly when searching by all authority types Bug 11336: update hold queue priorities correctly when deleting holds Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction Bug 11475: fix return link after editing/deleting items in batch Bug 11543: (followup) add one more test Bug 9788: QA followup Bug 11018: allow adding order from a reverted MARC batch Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived Bug 11237: Update default value for pref AcqItemSetSubfieldsWhenReceived Bug 11312: make facets selectable using an ID [staff] Bug 11312: make facets selectable using an ID [opac-prog] Bug 11312: make facets selectable using an ID [opac-bootstrap] Bug 11141: retain pending order filters during receiving. Bug 11141: (follow-up) ensure filters are kept if the receive is cancelled Bug 11549: Add regression test Bug 11549: make it possible to receive and cancel the receipt of a transferred order Bug 11549: (follow-up) interpolated variables into SQL statements should not be allowed Bug 11429: Manage display for basketgroup without name Bug 11397: Remove the itemnumber list on the Acquisition detail tab Bug 11486: Don't display the number of remaining renewals if == 0 Bug 11608: Delete unused commented lines in template Bug 11314: (follow-up) make "All" translatable Bug 11571: fix breakage of -f option for translate script Bug 9823: Refactor return from GetReservesFromBiblionumber Bug 11616: remove jQuery tablesorter plugin Bug 11488: make string "Are you sure you want to write off ..." translatable Bug 10851: add additional "missing" statuses for serials issues Bug 10851: (follow-up) fix issues reported by QA script Bug 10851: (follow-up) FIX bad c/p (variable name) Bug 11687: remove disused script statecollection.pl Bug 11737: (follow-up) remove extra fnReloadAjax.js Bug 11202: FIX UT for QueryParser.t Bug 7372: Move road types from the roadtype table to the ROADTYPE AV Bug 11562: re-sort sysprefs.sql Bug 11256: Opac: Set a number of items to display on a biblio detail page. Bug 11256: Opac: Set a number of items to display on a biblio detail page - bootstrap Bug 11471: Display the currency for baskets in a basketgroup Bug 11866: (follow-up) ensure that empty toolbar is not displayed Bug 11587 - Add UT for IsSuperLibrarian if flags == 0 Bug 11555: (follow-up) use 20 rather 25 for one of the default DT row counts Bug 11605: fallback to default DataTables settings where possible Bug 11605: (follow-up) fix regression Bug 11343: The max number of items to process in a batch is hardcoded Bug 10611: Use mysql_auto_reconnect instead of ping Bug 11751: remove dead code related to handling members of institution patrons Bug 11170: make the pending order list only display orders to receive Bug 11170: (follow-up) improve a bit of unnecessarily convoluted logic Bug 11755: ensure that SearchOrders returns booksellerid Bug 10837: make it possible to export serial claims as CSV even when no notice defined Bug 11675: check allocated total correctly when editing a fund that has a parent fund Bug 10861: Add a check on cardnumber length Bug 10861: (follow-up) various refactoring Bug 11550: Add UT for C4::Acquisition::GetOrder Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters" Bug 11127: OPAC suggestions form - complain when trying to 'delete selected' without having selected any Bug 11127: (follow-up) define a specific message for suggestions Bug 9366: add widget to bib editor to control display of the MARC tags Bug 11637: don't try to guess publication dates for irregular subscriptions Bug 8168: (follow-up) Use semicolon as default CSV delimiter Bug 11957: reomve disused sample_only_param_tables.sql Bug 11939: set active currency for non-English sample data Bug 7567: QA followup: FIX SQL query Bug 7567: QA followup: remove useless $parameters hashref Bug 11855: remove unused template file Bug 10865: (follow-up) Move a li tag to avoid overlapping tags Bug 11885: (follow-up) add a CSS class to set subfield code bold Bug 11995: restore ability of serialsUpdate.pl to calculate next serial issue dates Bug 11960: replace unnecessary call of GetMemberDetails by CanBookBeRenewed Bug 11563: (follow-up) improve selector for adding noEnterSubmit to select elements Bug 11797: fix odd number of elements in hash (UNIMARC) Bug 12052: New syspref to display message on the OPAC patron summary page Bug 11630: (follow-up) unit tests can be independent of DB Bug 10533: move JavaScript functions for basket groups to a separate file Bug 12098: Fix C4::Serials::can_edit_subscription Bug 12098: Refactor can_*_subscription in C4::Serials Bug 11689: Take new serial missing statuses into account in more places Bug 11689: Add unit tests for serials statuses Bug 11689: (follow-up) fix warnings generated when running Serials.t Bug 11148: remove two superflous routines from Koha::DateUtils Bug 11148: Add a as_due_date parameter to the output_pref routine Bug 11148: (follow-up) restore useful test removed by previous patch Bug 10090: display item type description instead of code on acq ordered and spent pages Bug 9216: make columns.def file translatable Bug 11699: fixed saving notes entered when receiving orders Bug 11699: change ModReceiveOrder to used named parameters Bug 11489: (OPAC prog theme) show facets only if there is a result to display Bug 10951: The new pref NoLoginInstructions should be empty by default. Bug 10986: QA followup - fix various issues Bug 11912: (follow-up) Use the common way to mock syspref Bug 11243: make vendor list distinguish between active and canceled items Bug 11243: update vendor list to also display canceled bib counts Bug 11243: UT: unit tests for GetBasketsInfosByBookseller Bug 8258: Use patron's library's notice for DUEDGST and PREDUEDGST Bug 11248: fix encoding issue on emailing a list (INTRANET) Bug 11248: fix encoding issue on emailing a list (OPAC) Bug 11552: allow searching on original order number after a transfer Bug 7308: (follow-up) change color style for fund child Bug 11551: Add unit tests for using GetHistory to search by order number Bug 7288: add filter on subscriptions in the invoices table Bug 7288: (follow-up) set a boolean if the invoice if linked to subscriptions Bug 10859: Alert if a borrower already has an issue for the same biblio Bug 10859: (follow-up) improve wording Bug 10859: (follow-up) GetIssues.t - Execute unit tests in a transaction Bug 12134: Add unit tests to reflect the change in IsDebarred Bug 12134: (follow-up) add more unit tests to reflect the change in IsDebarred Bug 11351 - Add support for SIP2 media types - French file Bug 11679: Add the new dependency OpenOffice::OODoc Bug 11679: Add ODS as an export format for reports Bug 9016: Create a message for each transport type. Bug 9016: Define different transport types for overdues Bug 9016: (follow-up) GetMessageTransportTypes returns an arrayref, not hashref Bug 9016: DB changes: new table overduerules_transport_types Bug 9016: (follow-up) fix unit tests Bug 9016: (follow-up) fix tab characters and POD. Bug 9016: (follow-up) fix some translate issues Bug 9016: (follow-up) various fixes Bug 9016: (follow-up) make GetLetters return all letters Bug 9016: (follow-up) additional mtt's name should be displayed in header Bug 9016: (follow-up) letter name is not displayed on editing a letter Bug 9016: (follow-up) FIX letter name is not displayed on editing a letter Bug 9016: (follow-up) Add some validation on the letter form Bug 9016: (follow-up) Improve number of characters display when mtt=sms Bug 11868: MTT: disable SMS and phone if not in use Bug 10845: Remove the notice code HOLD_PRINT in seed data Bug 10845: Multi transport types for holds Bug 10845: (follow-up) add the MTT in the die message Bug 10845: (follow-up) fix message_transport_type parameter for Itiva cronjob Bug 10832: Multi transport types for overdue notices Bug 10832: (follow-up) fix case where some print overdue notices were not being sent Bug 10832: (follow-up) add the transport type in the warning message Bug 10833: Multi transport types for advanced notices Bug 11867: MTT: Manage *_PHONE notices Bug 11867: (follow-up) Change the sql query in order to win beauty prices Bug 11696: ensure that print overdue notices use the print template Bug 11578: Upgrade the treetable jquery plugin Bug 11578: Improve the funds list view Bug 11578: (follow-up) add some CSS Bug 11578: (follow-up) hide inactive budgets by default Bug 11578: (follow-up) align budget names Bug 11578: (follow-up) hide filters if a budget (budgetperiod) is chosen Bug 11578: QA follow-up Bug 11578: (follow-up) fix show inactive link Bug 11578: (follow-up) fix funds grouping Bug 11578: (follow-up) fix budgets grouping Bug 12019: FIX budget_owner_id node is duplicated Bug 12019: ensure that it is optional to define an owner if a fund is restricted Bug 10613: calculate the GST rate correctly on the invoice page. Bug 10613: (follow-up) fix typo supplierid vs booksellerid Bug 10613: (follow-up) fix QA issues Bug 7180: Order from staged file improvements Bug 7180: (follow-up) fix getAuthValueDropbox should display the selected value Bug 7180: Add UT for C4::Budgets::GetBudgetByCode Bug 7180: QA followup Bug 7180: (follow-up) ensure that the default quantity is 1 Bug 7180: (follow-up) change syspref description Bug 7180: make neworderempty code use getAuthValueDropbox. Bug 7180: (follow-up) update license version Bug 7180: QA followup Bug 7180: (follow-up) restore the "Add order" link Bug 7180: (follow-up) remove useless rrp variable Bug 7180: (followup) fix case where discount was divided by 100 twice. Bug 7180: (follow-up) remove disused script fetch_sort_dropbox.pl Bug 7180: (follow-up) fix various issues Bug 7180: (follow-up) fix various issues Bug 7180: (follow-up) reset statistic values on reloading the page Bug 10875: ensure adding order from a staged file does not display inactive funds by default Bug 10875: (follow-up) preselect the fund located in the record Bug 766: Move GetAuthvalueDropbox to C4::Koha Bug 766: Create a plugin routine to build dropdown list Bug 766: Use the new plugin to generate sort dropdown list - memberentry Bug 766: remove disused routine buildCGISort Bug 766: Use a TT include instead of a method in the AV plugin Bug 766: (follow-up) fix encoding issues Bug 766: Update POD for AuthorisedValues TT plugin Bug 11278: (follow-up) Return an exit value (1) if the module is not found. Bug 6739: (follow-up) fix conflicts with some others bugs. Bug 6739: (follow-up) template changes for the bootstrap theme Bug 10807: Add an authority search history for the OPAC Bug 10807: (follow-up) Change the GPL version to v3+ Bug 10807: (follow-up) fix UT t/db_dependent/Search_SearchHistory.t Bug 10807: (follow-up) make the new field search_history.type should be a varchar(16) Bug 10807: Add an authority search history for the OPAC - bootstrap Bug 10862: Add search history to the intranet interface Bug 10862: (follow-up) fix a couple of issues Bug 10862: (follow-up) make sure that queries that return only one result get recorded Bug 8952: (follow-up) change occurrences of using_https Bug 8952: (follow-up) using_https does not deal with Plack Bug 11263: do not use system locales settings for subscriptions Bug 11263: Use all languages instead of just the translated ones Bug 11262: Don't require hardcoded translations for seasonal numbering pattern to work Bug 11209: Don't sent the same SMS message for the same user the same day Bug 11209: (follow-up) check if a notice has been already sent today Bug 11209: (follow-up) message content must also match for new message to be considered a duplicate Bug 5377: (follow-up) there is no index on deletedbiblioitems.issn Bug 10500: (follow-up) adjust for name of UNIMARC ISBN indexes Bug 10857: add ability to remove active facets when refining search results Bug 10857: (follow-up) update Bootstrap theme Joy Nelson (1): Bug 11066: make RIS and Bibtex exports RDA compatible Juan Romay Sieira (1): Bug 11441: enhance remove_unused_authorities.pl ability to select records Julian Maurice (26): Bug 10952: Store anonymous search history in session Bug 10952: (follow-up) comments fixes and unit tests Bug 10952: (follow-up) Always flush session after deletion Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber Bug 11579: Show ordernumber in basket.pl tables Bug 11860: Display subscription callnumber in OPAC detail page Bug 8918: Fix reserve priority in ILS-DI Bug 8918: Add a unit test for CalculatePriority Bug 8918: (follow-up) allow t/db_dependent/Reserves.t to pass if marcflavour is UNIMARC Bug 11861: Add ISSN column in serials claims table Bug 11386: standardize validation of the subscription add/edit form Bug 11701: Unit tests for C4::Context::Zconn Bug 11701: Fix C4::Context::Zconn Bug 12003: Do not calculate next pubdate for irregular subscriptions Bug 7308: Show ordered amount in aqbudgets.pl Bug 7308: rework aqbudgets.pl table Bug 11551: Allow to search on parent ordernumber in histsearch.pl Bug 11864: (code cleanup) re-indent parcel.tt and rename a variable Bug 11864: Show parent order line in received orders table Bug 8044: new module for translating strings in Perl source files Bug 8044: (follow-up) fix warning and error messages in translate.pl Bug 8044: (follow-up) add copyright block and use Modern::Perl Bug 11848: Move language detection function in C4::Languages Bug 11848: Make Koha::I18N easier to use Bug 11848: Fix C4::Context::interface, add POD and UT Bug 10857: (follow-up) encode 'limit' parameter values Katrin Fischer (31): Bug 11279: regression test for picking random quote Bug 11279: Improve how a new quote of the day is selected Bug 11228: Improve hint on patron notification when adding/editing subscriptions Bug 10626: (follow-up) remove final invocation of KohaAuthorisedValues Bug 10797: Move styling of simple search from element to CSS file Bug 8018: (follow-up) fixing some wrong capitalization Bug 11336: (follow-up) fixing capitalization in templates Bug 11260: Update German web installer for 3.14 Bug 11260: Update German web installer - frequencies and numberpatterns Bug 11260: Follow up - normalizing frequencies in English sample file a bit Bug 11330: (follow-up) fix description of 951 tag in the default framework Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC Bug 11495: Make "Select titles to: " translatable Bug 11828: Add German translation of layout2pages PDF template Bug 11828: (follow-up) add new option to OrderPdfFormat Bug 7267: Add account number to French PDF template Bug 7267: Add account number to English PDF templates Bug 7267: Add account number to German PDF template Bug 9216: (follow-up) Make description in columns.def more specific Bug 11248: (follow-up) fix template for translated list emails in staff Bug 7308: (follow-up) removing line breaks for better translatability Bug 10859: (follow-up) fix order in sysprefs.sql Bug 12114: Fix encoding problem with reports JSON web service (opac) Bug 12114: Fix encoding problem with reports JSON web service (staff) Bug 11856: Add publication year and edition to English acq PDF templates Bug 11856: Add publication year and edition to German acq PDF template Bug 11856: Add publication year and edition to French acq PDF template Bug 7180: (follow-up) fix minor issues Bug 6739: (follow-up) yet more fixes Bug 10807: (follow-up) change wording of tabs Bug 11741: Correct display of < > in XSLT result lists Ketan Kulkarni (2): Bug 10318: Show primary email in patron search results Bug 11087: Make the Pay Fines tab the default tab Kyle M Hall (88): Bug 9261 - Allow librarians to make purchase suggestions for patrons Bug 9261: (follow-up) fix various issues identified during QA Bug 9261: (follow-up) fix various issues identified during QA Bug 9261: (follow-up) remove references to deprecated YUI widget Bug 9261: (follow-up) remove reference to deprecated DHTMLcalendar Bug 11283: make restriction type translatable Bug 10852: (follow-up) switch from KohaAuthorisedValues to AuthorisedValues Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Bug 10626: (follow-up) replace another use of KohaBranchName Bug 9673 - Track when items are marked as lost or withdrawn Bug 11179: make OPAC course details page display status of checked out items correctly Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Bug 10626: (follow-up) replace an instance of KohaAuthorisedValues Bug 11410: ensure cataloging search finds results for searches with ampersands Bug 10834 - Add Sort 1 and Sort 2 to list of searchable patron fields Bug 11282: fix overwriting of existing restrictions when adding new one Bug 11419: display Z39.50 search errors more completely Bug 10277 - Add C4::Context->IsSuperLibrarian() Bug 11342: fix error in OPAC self registration form if BorrowersTitles is empty Bug 6886: ensure that singleBranchMode does not display library name for reference copies Bug 6886: (follow-up) replace needless with Bug 10774: Allow individual holds to be suspended and resumed from the OPAC Bug 10774: (QA Followup) Add support for bootstrap opac theme Bug 11541: (follow-up) repair some warnings Bug 11415 (QA Followup) fix whitespace Bug 11314: restore ability to see only 5 entries on parcel.pl Bug 11268: increase size of biblioitems.url Bug 11779: fix unexpected change in logged-in library when changing overdue notice triggers Bug 11783: ensure CD field in SIP patron information response is populated Bug 11644: fix occasional failure to update fund amount due to floating-point math Bug 11796: fix display of search result facets if facet happens to have exactly six entries Bug 11746 - Add edit item links to record details page Bug 11746 [QA Followup] display edit item link only if user has permission to edit items Bug 11768: Show patron cardnumber in OPAC personal details Bug 11866: do not require special permissions to view course reserves in staff interface Bug 10558 - Convert records table in manage-marc-import.pl to Ajax DataTable Bug 10558 [QA Follow-up] Bug 10452: make AllowHoldsOnDamagedItems control using damaged items to fulfill holds Bug 10452: [QA Followup] - Unit tests Bug 10955 - Add ability to skip deletions in zebraqueue Bug 11555: Make "All" one of the default options for datatables Bug 10861: (follow-up) Clarify preference description Bug 11531: make it possible to edit transport cost for a new libraries Bug 11923: fix option to sort contents of MARC record batches by citation descending Bug 11694: [QA Followup] strip out time portion when setting suspension date for individual hold Bug 11598: Add --text option to overdue_notices similar to --html option Bug 11563: (follow-up) change .live() to .on() Bug 11563: (follow-up) add noEnterSubmit class to pulldowns Bug 11630: (QA Followup) Move code to subroutine, add unit tests Bug 11484: Add option to cleanup_database.pl to purge Z39.50 search records from reservoir Bug 9448: Add separate permission for writing off fees Bug 9448: (follow-up) rephrase permission description Bug 9448: (QA Followup) Hide 'Forgive overdue charges' for returns if user does not have writeoff permission Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy Bug 12080: (follow-up) fix test failure and warnings in Bookseller.t Bug 11416: fix case where serials item editor was incorrectly hiding fields Bug 11489: in OPAC search, display "no results" when the only search result is suppressed Bug 9288 - Add a script to test SIP from the command line Bug 9288: (follow-up) add --terminator option; use Modern::Perl Bug 9288: (follow-up) use specified terminator for both input and output Bug 9288: (follow-up) minor code tweaks Bug 9288: (follow-up) remove function prototype Bug 12114: (QA Followup) Use JSON instead of JSON::XS Bug 12134: ensure that patrons are not restricted even when the last restriction has expired Bug 11351 - Add support for SIP2 media types Bug 11518: Add new method to K::S::R::Item that will always return the correct itemtype Bug 11518: (follow-up) Change method name from 'itemtype' to 'effective_itemtype' for clarity Bug 11518: (follow-up) retrieve syspref value using DBIC Bug 11518: (follow-up) Make unit tests pass Bug 11334: add ability to control which library fields are used for facets Bug 11334: (follow-up) fix errors in database update Bug 9865 (follow-up) give better usage examples in example SIPconfig.xml Bug 9016: (follow-up) add insertAtCaret library to about page Bug 10694 - Allow arbitrary backdating of returns Bug 10694: (follow-up) fix various issues Bug 10694: (follow-up) add unit tests, improve AddReturn POD Bug 7180: (follow-up) correct minor language issues Bug 9593: (QA Followup) Bug 6739: (follow-up) fix various issues Bug 6739: (follow-up) fix more issues Bug 8769: Allow SIP2 return backdating Bug 8769: (follow-up) remove unnecessary module import Bug 8769: (follow-up) undo change to value of $today Bug 5377: widen columns to better accommodate multiple ISBN and ISSN Bug 5377: (follow-up) alter deletedbiblioitems to match biblioitems Bug 10500: Improve ISBN matching when importing records Bug 10500: (follow-up) add checks for empty isbn Bug 11287: make patron import tool take new restrictions system into account Liz Rea (6): Bug 11138 - Add auto_unsuspend_reserves to crontab.example Bug 11138: add auto_unsuspend_holds to daily crontab (Debian package) Bug 12032: disable automatic URL conversion by TinyMCE in news Bug 11684: avoid mixed content warnings using SSL with Amazon - opac-readingrecord and opac-user Bug 10944: fix mixed content warnings in opac results and detail with Amazon images on https Bug 10944: follow-up for Bootstrap Amazon images on https OPAC Lyon3 Team (3): Bug 11059: fix date sorting of import batches in basket add form Bug 9593: improve parsing of prices from staged files Bug 8231: display warning at check in if borrower is restricted Magnus Enger (4): Bug 11004: Make xmlControlfield.js use the marcflavour syspref to look for XML files Bug 11188 - Make gather_print_notices.pl die on failed open() Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC Bug 10782 - Add a koha-mysqlcheck script Marc V?ron (3): Bug 11772: Show warning on About page:System information if no active currency is defined Bug 11773: fix crash in sco-main.pl if no active currency is set Bug 11784 - fix displaying patron images in self checkout Marcel de Rooy (48): Bug 7491: improve description of the item-level_itypes syspref Bug 7143: New release team for Koha 3.16 Bug 7143: Cleaning up docs/history.txt Bug 7143: Adding RMaint for 3.8 to release team Bug 11124: QA Follow-up resolving a warning and three typos Bug 11124: QA Follow-up adding optional dependency HTTPD::Bench::ApacheBench Bug 11398: A typo occurred with occured Bug 9788: Improvements when calling GetReservesFromItemnumber Bug 9788: (follow-up) removing the alldates parameter from GetReservesFromItemnumber Bug 9788: (follow-up) for expirationdate in Letter.pm Bug 9788: (follow-up) Unit tests for changed routine GetReservesFromItemnumber Bug 11329: Check for MARC record existence in opac-showmarc Bug 11329: Check for MARC record existence in catalogue/showmarc Bug 9823: QA follow-up for GetReservesFromBiblionumber calls Bug 11619: remove duplicate key in QueryParser config Bug 10789: Follow-up: Fix typo "infermation" Bug 10789: Follow-up: restored second SQL parameter in GetLastOrderReceivedFromSubscriptionid Bug 11732: Eliminate warning on undefined branchcode Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm Bug 11803: use $dbh consistently in _koha_modify_item Bug 11078: QA Follow-up for missing file permissions on lockfile Bug 8918: (follow-up) improve descriptions of two related sysprefs Bug 8918: (follow-up) more unit tests for CalculatePriority Bug 8918: (follow-up) support creating brief UNIAMRC bibs in Reserves.t Bug 11170: (follow-up) fix typo 'occured' in parcels.tt Bug 10861: (follow-up) for typo in patrons.pref Bug 9075: Rename "type" to "material type" on staff XSLT detail and results Bug 9075: Rename "type" to "material type" on OPAC XSLT detail and results Bug 11855: Tiny code cleanup in members Bug 9032: add ability to invite another to share a private list Bug 9032: (follow-up) add new dependency Email::Valid Bug 9032: (follow-up) Plackify opac-shareshelf.pl Bug 9032: add ability to accept list share invitations and remove shares Bug 9032: Unit tests for sharing lists Bug 9032: enforce consistent behavior when deleting lists Bug 9032: (follow-up) add support for bootstrap theme Bug 9032: new SHARE_INVITE & SHARE_ACCEPT notifications Bug 9032: (follow-up): send cookie with redirect Bug 9032: (follow-up) loop variable and Cancel button Bug 9032: (follow-up) adding new notices to non-English installer files Bug 8262: explicitly warn that database admin account cannot create lists Bug 12100: ensure that messaging preferences displays saved Days in Advance Bug 9016: (QA Follow-up) Remove warning from content.length test Bug 11278: Adjusting bulkmarcimport.pl for customization routine and verbose printing Bug 11278: Followup for customize command line parameter Bug 8044: (follow-up) ensure Modern::Perl is imported first Bug 9612: fix SRU response for DOM indexing Bug 9612: Zconn parameters and elementSetName in _new_Zconn Mark Tompsett (26): Bug 11242: fix opac-MARCdetail.pl display and warnings Bug 11316 - plugin icon missing tooltip in addbiblio.pl Bug 11513: fix log warning noise in patron category editor Bug 11491: add option to supply field names in reports web service output Bug 11491: (QA follow-up) updated license and use Modern::Perl Bug 11587 - IsSuperLibrarian generates warnings (UT) Bug 11587: get rid of warnings generated by IsSuperLibrarian with anonymous sessions Bug 11928 - Remove unused table aqorderdelivery Bug 7567: add tests for C4::NewsChannel Bug 7567: (code cleanup) update license and use Modern::Perl Bug 7567: (code cleanup) update License tools/koha-news.pl Bug 7567 - Clean up sample news files Bug 7567: (code cleanup) remove excess line Bug 7567 - Correct Filtering and Default dropdown values Bug 7567: (code cleanup) remove finish calls Bug 7567: convert news add/update routines to take hashref; fix bugs Bug 7567 - Added branchcode to opac_news Bug 7567 - Schema update for opac_news Bug 7567 - Use, display, filter News by library Bug 12060: remove extraneous tags from header.inc Bug 11885: (follow-up) make default styling consistent with previous look Bug 11797: fix odd number of elements in hash warning (MARC21) Bug 11253: tools/inventory.pl: fix handling of inventory date Bug 12115: follow-up fix for tools/inventory's output_pref issues Bug 11182: remove spurious logged warnings in circulation Bug 11182: remove another warning in circulation Martin Renvoize (1): Bug 10798: make OPAC_SEARCH_LIMIT behaves better with search groups Mason James (2): Bug 10825: don't display enum/chron twice for items received via the serials module Bug 10823: add class info to enumchron data in detail.tt, for better styling Mathieu Saby (27): Bug 11189: Rename "Print" label in UNIMARC advanced search Bug 7791: add ability to delete records when deleting a basket Bug 7791: (follow-up) tidy up some cruft in the main patch Bug 7791: (follow-up) add warning after deletion if some records were not deleted Bug 9807 : Make it possible to view a basket group without reopening it Bug 9807: (follow-up) fix variable name Bug 9807: (follow-up) reindent basketgroup.tt Bug 9940: Add a new index for the original language of a document Bug 10138: Add some authorized values in French installer; small fixes in frameworks Bug 11192: Fix lf and ff07-02 definition in ccl.properties Bug 11056: Delete dead code in basketgroup.pl Bug 11435: Show basketgroup information in Acquisition tab in catalogue page Bug 11429: Add a link to basketgroup in basket detail page Bug 10922: Display whether prices are include or don't include tax when creating a new order Bug 11246: remove reference to fields 780 and 785 in UNIMARC XSLT files for Bootstrap OPAC Bug 11202: Improve UNIMARC biblio indexing Bug 11611: Rephrase description and examples of 5 MARC related sysprefs Bug 11224 : Add UT to routines of C4::Acquisition returning order(s) Bug 9416: add new order vendor note field Bug 9416: (follow-up) update acquisitions unit tests Bug 9416: (follow-up) fix neworderempty and templates Bug 11027: Add a column for basketgroups in late orders table and improve other columns Bug 11027: (follow-up) Create link to baskets/basketgroups only if user have required permissions Bug 11027: (follow-up) hide link if no basketgroup and use real branch name Bug 12111: Improving templates regarding order notes Bug 12111: (follow-up) fix breadcrumbs wording for vendor note Bug 10893: fix location facet in UNIMARC Matthias Meusburger (3): Bug 11412: fix potential bulkmarcimport crash when searching for duplicates in authorities Bug 11850: Add -append option to bulkmarcimport.pl to append to logfile Bug 11048: Fix logout redirection for CAS authentication Mirko Tietgen (2): Bug 9972: Add/change some zebra indexes (MARC21) Bug 10195: hide bib details page for OPAC-suppressed bibs Nicholas van Oudtshoorn (1): Bug 10777: email HTML reports with the proper Content-Type Nicolas Legrand (1): Bug 11934 - Replace given by if-else statements Nicole C. Engard (7): Bug 11383: Add help file for MARC modification templates Bug 11403: Add missing help file to new Renew page Bug 11483: Add missing serial help files Bug 11608: Remove the word 'library' from funds list Bug 11272 - add second submit button to inventory form Bug 11918 : Fix typo on authorized values page Bug 11403: (follow-up) Fix typo in renew help Nu?o L?pez Ans?tegui (1): Bug 11309: avoid creating duplicate numbering patterns during upgrade to 3.14.x Olli-Antti Kivilahti (5): Bug 11561: restore previous behavior of generation of hold print notices Bug 10833: (follow-up) add message transport type to a warning message Bug 11369 - Updating the jquery.cookie.js-plugin Bug 11369: fix issue that can cause staff client searches to stop working Bug 11466: improve selection of item types for purchase order desired format list Owen Leonard (111): Bug 2693: add ability to filter by reviewer name on tag review page Bug 2310: display tooltips explaining why patron menu items are disabled Bug 10661: format mandatory item fields the same on all forms Bug 11179: (follow-up) apply fix to Boostrap theme Bug 11503: fix several typos Bug 11381: improve styling of IDreamBooks content in bootstrap theme Bug 11505: fix untranslatable table headers in Label batch manager Bug 11503: [Follow-up] fix another typo Bug 11476: remove extra empty option from title pull-down in OPAC self-registration Bug 11534: fix bug that made it impossible to remove instructors from a course Bug 11636 - make it possible to remove patrons from patron list during add process Bug 11692: fix display of additional bib information in OPAC "most popular" pag Bug 11721 - Use new DataTables include in suggestions template Bug 11670 - Remove sorting from patron lists action columns Bug 11737 - Use new DataTables include in quotes management template Bug 11739 - Use new DataTables include in notices template Bug 11735 - Use new DataTables include in calendar template Bug 11748 - Remove unused jquery.uitablefilter.js plugin Bug 11764 - Move repeatedly redefined function toUC() into staff-global.js Bug 11765 - Remove unused function isDate from templates Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form Bug 11618: ensure jQuery timepicker is picked up by the i18n toolchain Bug 11743 - Remove unused DataTables plugin from OPAC theme directories Bug 11709: revisions to Bootstrap OPAC lists interface Bug 11756: improve default sorting on hold ratios report Bug 11771 - Use validation plugin when creating new MARC framework tag Bug 11749 - Remove unused jQuery plugin jquery.hoverIntent.minified.js from the staff client Bug 11766 - Use validation plugin when creating new authority type Bug 11767 - Use validation plugin when creating new authority framework tag Bug 11740 - Use new DataTables include in quotes upload template Bug 11411 - Bootstrap theme (enhancement) for (right to left) Bug 10714: Redirect to list contents view upon save after initiating edit from list contents view (staff) Bug 10714 [Follow-up] Redirect to list contents view upon cancel after initiating edit from list contents view (staff) Bug 11785 - Use validation plugin when uploading local cover images Bug 11787 - Use validation plugin when adding new vendor Bug 11788 - Use validation plugin when creating new course Bug 11795 - Use validation plugin when creating new Z39.50 server Bug 11793 - Use validation plugin when creating new item type Bug 11792 - Use validation plugin when creating new currency Bug 11791 - Use validation plugin when creating new city Bug 9677 - Style button on notices and slips page with Bootstrap Bug 11789 - Use validation plugin when creating new list Bug 10751: standardize validation of title in staff purchase suggestions form Bug 11819 - Don't show catalog edit menu if user has no edit permissions Bug 11809: don't display 'Clear date' on OPAC patron details form if date of birth is required Bug 11717 - Use new DataTables include in member templates Bug 11710 - Use new DataTables include in cataloging Z39.50 search template Bug 11716 - Use new DataTables include in label manage template Bug 11736 - Use new DataTables include in Koha news templates Bug 11805 - Use validation plugin when creating new basket in Acquisitions Bug 11829: fix JavaScript error on staff client biblio details pages if template variables are undefined Bug 11802 - corrects for the patron purchase suggestions page Bug 11328 - Show local cover images in staff client search results Bug 11794 - restore functioning of opacSerialDefaultTab Bug 10558: (follow-up) styling improvements Bug 11713 - Use new DataTables include in course reserves templates Bug 11686: make "please note your reason here..." translatable Bug 11833 - fix filtering on saved report subgroup Bug 11821: disable catalog edit menu items and provide explanations when actions cannot be done Bug 11832: fix JavaScript error on staff client place hold screen if record has no items Bug 11718 - Use new DataTables include in reports templates Bug 10415 - Add course reserves to staff client home page Bug 11938: fix capitalization: Serial prediction pattern preview - Publication Date Bug 11935: fix capitalization: OPAC prog theme, checkouts tab Bug 11694: Improve handling of individual hold suspension in Bootstrap OPAC Bug 11877 - Eliminate use of deprecated jQuery .live() method Bug 11806 - Use validation plugin when creating new OAI set Bug 11878 - Eliminate use of deprecated jQuery .toggle() method usage Bug 11738: Use new DataTables include in batch patron modification template Bug 11671 - Restructure patron lists add form for improved usability Bug 11946 - add table sorters to label batches Bug 12018 - add table sorting to patron card batches Bug 12034: standardize alerts referring to lists and list items Bug 11570 - Upgrade jQueryUI to latest version in the staff client Bug 7567: (follow-up) Modify DataTables configuration Bug 11711 - Use new DataTables include in circ templates Bug 11734 - Use new DataTables include in batch modification templates Bug 12056: fix untranslatable strings in calendar Bug 10865: Don't show list permissions when adding public lists/sharing lists is not allowed Bug 10865: (Follow-up) Add CSS style for form hints Bug 11951: fix OPAC search suggestions template error Bug 12069: redirect to staff login if you access members/mod_debarment.pl when logged out Bug 12075: fix keyboard shortcuts broken by jQueryUI upgrade Bug 12058: make OverDrive search results page show cart, lists, and login links Bug 12102 - Move humanmsg jQuery plugin outside of language-specific directory Bug 9032: (follow-up) adjust the "share a list" template Bug 12094: fix default tab selection broken by jQueryUI upgrade Bug 12117 - Remove unused image myshadow.png from the staff client Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js Bug 12103 - Move ajaxfileupload jQuery plugin outside of language-specific directory Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory Bug 12101 - Move Greybox library outside of language-specific directory Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory Bug 12119 - Move jeditable jQuery plugin outside of language-specific directory outside of language-specific directory Bug 12118 - remove unnecessary YUI assets included in offline circ manifest Bug 11769 - Use validation plugin when creating new MARC framework Bug 11769: (follow-up) style required fields Bug 11724: Make Funds/Status on suggestions page sortable/searchable Bug 7125: make MARC framework tag form not suggest that one can change the form Bug 11719 - Use new DataTables include in serials templates Bug 11719: (follow-up) fix column sorting configuration Bug 11719: (follow-up) fixed two more sorting issues Bug 12088: Improve date handling and sorting in holds to pull report Bug 12089: Remove use of dt_add_type_uk_date() - Members Bug 12089: Remove use of dt_add_type_uk_date() - Budgets Bug 12089: Remove use of dt_add_type_uk_date() - Circulation Bug 12089: Remove use of dt_add_type_uk_date() - Acquisitions Bug 12089: Remove use of dt_add_type_uk_date() - JavaScript Bug 11763 - Consolidate fund action links into menu Bug 10807: (follow-up) wording tweak; take OpacAuthorities into account Bug 8952: Add http:// to url in social media links on opac-detail Pablo Bianchi (1): Bug 8018: MARC framework max subfield length should default to 9999 Pasi Kallinen (6): Bug 12024: fix add to list opening the list adding UI in two windows Bug 11885: fix inconsistent HTML in MARC Details Bug 11630: improve parsing of age restriction markers Bug 11588: fix untranslatable subscription frequency units Bug 11631: Make i18n toolchain ignore useless strings Bug 12138 - Use placeholders in translatable Javascript strings Paul Poulain (1): Bug 10798: (follow-up) replace tabs by spaces Peggy Thrasher (1): Bug 11040: Add CircAutoPrintQuickSlip option to print regular slip Rachel Dustin (1): Bug 11105: wrap places OPAC facet in a span Robin Sheat (8): Bug 11284: Packaging updates for master branch Bug 10735: prevent koha-dump from aborting if backupdir undefined Bug 10646 - warn if mod_rewrite is not enabled Bug 11051: remove unneccessary SQL queries in GetBranches Bug 11705 - change versioning of build-git-snapshot Bug 11947 - renumber reserves when hold is confirmed Bug 10942: (follow-up) debconfing the update option Bug 10944: fix mixed content warnings for covers on staff client Roman Amor (2): Bug 11543: Increasing test coverage for Category.pm Bug 11363: make units in label printer profile form translatable Samuel Crosby (1): Bug 9654: add space between amount and currency symbol in basket group display Sophie Meynieux (7): Bug 11125: Correct display for patron messaging preferences on OPAC Bug 9210: wrap long lines in printed hold notices Bug 11628: add missing staffaccess permission to French userflags.sql file Bug 11760: In notices, output road type description rather than code Bug 11647: require that user log into OPAC to request email subscription notifications Bug 11647: (follow-up) test if user is logged in before proposing to subscribe or unsubcribe from serial routing list Bug 11647 : (follow-up) Add template modification for bootstrap theme Srdjan (5): Bug 11183: get rid of some log noise from the OPAC Bug 11077: Correct more warnings in C4/Auth.pm bug_10781: Remove C4::ILSDI::Utility Bug 11184: correct attribute cloning for the patron editor Bug 11182: get rid of some warnings in circulation St?phane Delaune (1): Bug 11730: ensure that C4::Charset loads C4::Context Tim Hannah (1): Bug 11104: Wraps series label in a span for CSS selectability. Tom Houlker (1): Bug 11539: removing 2 unused files Tomas Cohen Arazi (35): Bug 11077: remove uninitialized value $pki_field warning Bug 10905: fix links to author tracings when UseAuthoritiesForTracings is on Bug 8018: (followup) make the default more explicit Bug 8921: make koha-common*.deb depend on cron-daemon Bug 11402: make Labels::_guide_box return undef if undefned data is passed Bug 11439: (follow up) add missing rollback call Bug 11499: (regression tests) indexing modes not properly set on generated koha-conf.xml Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode Bug 11510: koha-translate usage message fixes Bug 11509: improve usage information printed by koha-create Bug 10896: Add a --verbose option to koha-translate Bug 11540: (follow-up) add a couple of tests more Bug 10691: use authority ID in see-also links in authority search results (staff) Bug 10691: use authority ID in see-also links in authority search results (OPAC) Bug 10691: (follow-up) restore behaviour for control field ($w) Bug 10987: remove duplicate 'see also' and 'see from' labels from authority search results Bug 11533: (regression test) QP breaks authority search Bug 11655: koha-translate --list no longer shows 'en' Bug 11509: (trivial rmaint followup) wrong parameter count Bug 11704: Make */svc/report print the correct headers Bug 10580: adjust Makefile.PL to reflect that Zebra no longer optional in Koha setup Bug 11096: Wrap each test set configuration in Search.t into a subtest Bug 11096: support the retrieval of large MARCXML records Bug 7234: koha-common Debian package now includes koha-sites.conf Bug 9114: Make frameworks import/export routines correctly use UTF-8 Bug 11912: (regression tests) GetMarcISBN wrongly prepends a space to ISBNs Bug 11912: fix problem where GetMarcISBN wrongly prepends a space to ISBNs Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API Bug 11596: report warnings on the about patch if indexing options in koha-conf.xml are missing Bug 10942: Provide a way for package upgrades to update template translations Bug 10942: (QA followup) make warnings to to STDERR Bug 11182: (QA followup) fix warning if itemBarcodeFallbackSearch set Bug 11117: Fix text mixup in facets where RTL text + facet count showed Bug 4397: fix scan index search results for non-latin characters Bug 10003: bash-completion for koha-list and other scripts Vitor FERNANDES (1): Bug 8334 - Authority UNIMARC 100 field plugin Zeno Tajoli (3): Bug 11222: fix crash that can occur in search for items to add to label batch Bug 11174: fix OPAC search links built from authority 5xx fields Bug 11939: set active currency when using English sample data alex_h (2): Bug 11537: Increasing test coverage for C4::Log bug 11544: increasing test coverage for Installer_PerlModules.pm blou (3): Bug 10951 - Adding NoLoginInstructions to system preferences Bug 10951 - Tweaked opac-auth.tt sentence. Bug 10986: add system preference to limit the list of languages in advanced search daniel (1): bug 11542: Increase test coverage for Print.pm merllissia (1): Bug 11545: Increasing test coverage for Languages.pm ?ByWater (1): Bug 11572: ensure that running Z39.50 search from staff search results detects ISBN ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 16:13:16 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 06 May 2014 14:13:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-2-g51a4a50 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 51a4a5099f0846ad1289b51a3f314ffe62e4c4bf (commit) via 694ad0f8ccee1d868ef63caafd4fe520a3e57930 (commit) from 2cd3b00e902ef91bed0c4bec822f31ed9c16e992 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 51a4a5099f0846ad1289b51a3f314ffe62e4c4bf Author: Jonathan Druart Date: Tue Apr 15 16:47:20 2014 +0200 Bug 9063: rename num_biblios to num_records in addorderiso2709.{pl,tt} Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 694ad0f8ccee1d868ef63caafd4fe520a3e57930 Author: Magnus Enger Date: Mon May 5 10:43:26 2014 +0200 Bug 12185 - Remove extra "f" from parcel.tt There is a typoed "f" outside of the HTML on line 279 of koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt This patch removes that extra "f". To test: It should be sufficient to look at line 279 before and after the patch has been applied. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: acqui/addorderiso2709.pl | 8 ++++---- .../intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 16:19:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 06 May 2014 14:19:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-3-gacd0a91 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via acd0a91b112fa2368a6b4ccee570d4df044cfc71 (commit) from 51a4a5099f0846ad1289b51a3f314ffe62e4c4bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit acd0a91b112fa2368a6b4ccee570d4df044cfc71 Author: Matthias Meusburger Date: Tue Apr 29 14:22:48 2014 +0200 Bug 12161: fix regression on serials receiving Serial receiving was broken when "create an item record when receiving this serial" is used for the subscription. This bug was introduced by the patch for bug 12138. Signed-off-by: Pasi Kallinen Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 17:39:19 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 06 May 2014 15:39:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-4-g646d2aa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 646d2aa32584454e319c94816822c169921f5a76 (commit) from acd0a91b112fa2368a6b4ccee570d4df044cfc71 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 646d2aa32584454e319c94816822c169921f5a76 Author: Robin Sheat Date: Wed Apr 30 16:28:21 2014 +1200 Bug 12163 - fix adding new quotes Something changed somewhere (maybe a new jQuery or datatables version) and the javascript that redrew the table row after a new quote was saved stopped working. This fixes the call to the datatables function so that it matches the API. Note that although the new quote didn't appear to be added, reloading the page shows that it had been. To test: * Go and add a quote. * Note that when you press enter after finishing the quote, the line stops being an editor, and becomes just a display, like it should. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 20:28:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 06 May 2014 18:28:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-5-gf7ef93e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f7ef93e758850e991091e7268b8d1b1453082df4 (commit) from 646d2aa32584454e319c94816822c169921f5a76 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f7ef93e758850e991091e7268b8d1b1453082df4 Author: Galen Charlton Date: Tue May 6 18:52:12 2014 +0000 Bug 8375: (follow-up) adjust StrWidth to account for TTF fonts This patch fixes an issue caught by the test case where StrWidth() based its calculations on the internal Adobe font rather than a TrueType font in use. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Creators/PDF.pm | 12 ++++++++++++ t/Creators.t | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 6 22:59:51 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 06 May 2014 20:59:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-6-gac3e5e5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ac3e5e514794825c088fad3cead5254029e52550 (commit) from f7ef93e758850e991091e7268b8d1b1453082df4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ac3e5e514794825c088fad3cead5254029e52550 Author: Galen Charlton Date: Tue May 6 21:24:40 2014 +0000 Bug 8375: (follow-up) adjust another test case for change in fonts Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Labels/t_Layout.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 7 02:36:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 07 May 2014 00:36:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-7-g34e136a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 34e136a485c58c6911de59899f94a0543e483b0a (commit) from ac3e5e514794825c088fad3cead5254029e52550 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 34e136a485c58c6911de59899f94a0543e483b0a Author: Galen Charlton Date: Wed May 7 01:00:34 2014 +0000 Bug 8375: (follow-up) final adjustment to t/Creators.t This patch adjusts the test so that it can pass successfully without a valid context (in which case C4::Creators::PDF defaults to the built-in fonts) or with one (in which case it uses the TrueType fonts). Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: t/Creators.t | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 7 17:39:30 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 07 May 2014 15:39:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-8-gf8f7382 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f8f7382ef7267d53b61462773e300e517c48e9e8 (commit) from 34e136a485c58c6911de59899f94a0543e483b0a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f8f7382ef7267d53b61462773e300e517c48e9e8 Author: Mathieu Saby Date: Fri Dec 20 23:21:32 2013 +0100 Bug 11433: (code cleanup) remove unused 'attachbasket' op value in basket.pl This patch cleans code in basket.pl In basket.pl, some code is supposed to be executed if $op eq 'attachbasket'. But it is never the case (grep attachbasket * -r), so this condition can be removed. No functional change expected. Regression test only : * Make a complete acquisition process, from the creation of a basket to the closure of a basketgroup, and check everything is OK * On a basket page, try to change the basketgroup it belongs to, and check everything is OK * On a basketgroup page, try to edit the content of a basketgroup (put a new basket in it, change the deliverybranch...), and check everything is OK * On a basketgroup page, try to reopen a closed basketgroup, and close an open basketgroup, and check everything is OK Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: acqui/basket.pl | 3 --- 1 file changed, 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 7 18:05:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 07 May 2014 16:05:18 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-1-g9236575 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 923657526c2d7ac6d39ce5fd998c8249f43e3f51 (commit) from 926a87444319da127435ad0f6641b0dd3a6fda3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 923657526c2d7ac6d39ce5fd998c8249f43e3f51 Author: Chris Cormack Date: Sat Nov 23 11:04:00 2013 +1300 Bug 11290: fix display of patron home page for certain translations To test 1) In a fresh Koha, generate translation into XX 2) Select XX for the staff interface (i.e. enable it, and choose it) 3) Go to the Patrons page 4) Everything looks fine 5) In the admin page, create a patron category with any non-ASCII character. 6) Go back to the Patrons page, everything is broken 7) Apply patch 8) regenerate translation 9) Go back to the Patrons page, everything looks fine 10) Switch to english it still looks fine Signed-off-by: Tomas Cohen Arazi Tried with ru-RU and fixes the problem. Signed-off-by: Katrin Fischer Passes all tests and QA script. Problem is also visible on untranslated templates changing one of the sample category descriptions to include diacritics. [RM note: I wasn't able to reproduce this on an unstranslated template -- I tried using Arabic, Cyrllic, and Spanish characters] Signed-off-by: Galen Charlton (cherry picked from commit 3e1b781adc253722209e46385fb3248ae8d668f9) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 7 18:10:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 07 May 2014 16:10:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-5-g4e3a505 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 4e3a5051e6fd0ed63bf611ec697aecd4139d6b5a (commit) via 7ee0085b2ea8a33f25d731a4239f93c7be244219 (commit) via e597446b9934e8216ccccf4a12cfe1657a959efd (commit) via 5a280ab8e360cf46c852872c9687b075c74af7eb (commit) from 923657526c2d7ac6d39ce5fd998c8249f43e3f51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4e3a5051e6fd0ed63bf611ec697aecd4139d6b5a Author: Fridolin Somers Date: Wed Feb 26 17:14:04 2014 +0100 Bug 11369: (follow-up) generate searchid in browser.js The search browser feature uses nearly only the browser.js file. That is why I propose to move the searchid generation from search.pl to browser.js. We then use Date.getTime() to use current timestamp as searchid, prefixed by 'scs_' like before. Test by using test plan of main patch : Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes tests and QA script. Tested the browse functionality in staff by using the different options (back to results, next, previous, etc) and the batch modifications for items. An old cookie can cause a Javascript error, but after restarting the browser/deleting cookies it all works correctly. Signed-off-by: Galen Charlton (cherry picked from commit c4f17650132c9b74aa56c40a3a2bec2bdbc4477e) Signed-off-by: Fridolin Somers commit 7ee0085b2ea8a33f25d731a4239f93c7be244219 Author: Fridolin Somers Date: Wed Feb 26 17:03:13 2014 +0100 Bug 11369: (follow-up) Correct usage of me.searchid in browser.js In browser.js, at creation of browser, the searchid is transmited to JS object into me.searchid. To be consistant, me.searchid should always be use, never searchid alone. In browseRecords function, setting searchid as parameter is useless because it is defined in me.searchid. Test with test plan of Bug 10404 Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 98edbf00cc10c908820eb1126a176ed12a04300d) Signed-off-by: Fridolin Somers commit e597446b9934e8216ccccf4a12cfe1657a959efd Author: Olli-Antti Kivilahti Date: Wed Dec 11 14:28:53 2013 +0200 Bug 11369: fix issue that can cause staff client searches to stop working This patch fixes an issue where too many search cursor cookies overflow the HTTP-header size after making multiple searches in the staff client. To replicate this issue, make multiple searches in catalogue/search.pl. 50+ Should be enough to cause the HTTP-request header to overgrow. One can verify this issue by observing the searchCookie growth in browser's stored cookies. ------------- - TEST PLAN - ------------- Keep making searches. One should never have more than 10 searchCookies. Browser might display only 9, because for some reason the newest js-generated cookie is not included in Firefox's cookies listing. ------------ - DRAWBACK - ------------ Removing these cookies disables the search cursor for traversing search results (next/previous) for the removed cookie. This maybe be problematic in some cases, (for ex when multiple search tabs need to be open and they need to be traversed) One easy solution is to grow the amount of stored searchCookies from 10 to 20, but 10 is chosen so there will be plenty of room for other cookies as well. Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 0cada7a323db7f9871b67a07e3343642543b64e0) Signed-off-by: Fridolin Somers commit 5a280ab8e360cf46c852872c9687b075c74af7eb Author: Olli-Antti Kivilahti Date: Tue Dec 10 19:12:01 2013 +0200 Bug 11369 - Updating the jquery.cookie.js-plugin The current jquery.cookie-plugin crashes when trying to fetch all cookies using $.cookie(); Downloaded the newest plugin version and minified it. Now works as intended. Encountered an issue with the plugin now returning null when no cookies are found, and applied a fix in browser.js. ------------- - Test plan - ------------- Plugin is used in browser.js and batchMod.js so testing both Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 35bec75d66637bd3c4cff499ed7fb534b8d09f35) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: catalogue/search.pl | 4 +-- koha-tmpl/intranet-tmpl/js/browser.js | 33 +++++++++++++++----- .../lib/jquery/plugins/jquery.cookie.min.js | 2 +- 3 files changed, 29 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 7 18:17:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 07 May 2014 16:17:18 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-10-g63fd484 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 63fd484189b713dc5621cf8f467bbb10a5899032 (commit) via 0b85d44a562e05850d642de7395227c0939d4bcf (commit) via 835343a1ef10c6606d625df2096b8bba518ee01d (commit) via a489bf50f22ff664a73a1b795a76aa5e837b4e3e (commit) via bbe90f900059cac7f470954473a406081c897bc1 (commit) from 4e3a5051e6fd0ed63bf611ec697aecd4139d6b5a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 63fd484189b713dc5621cf8f467bbb10a5899032 Author: Galen Charlton Date: Fri Apr 11 17:51:50 2014 +0000 Bug 11563: (follow-up) remove some tabs Signed-off-by: Galen Charlton (cherry picked from commit c16cadf21656e6c1796c7eac28db33ead02cf59d) Signed-off-by: Fridolin Somers commit 0b85d44a562e05850d642de7395227c0939d4bcf Author: Jonathan Druart Date: Tue Mar 25 09:30:14 2014 +0100 Bug 11563: (follow-up) improve selector for adding noEnterSubmit to select elements Test plan: To test on modified pages: - Press enter when cursor is on input or select and verify the form is not submitted. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 2aafa78f08c60797e47cbe790cef1f1899a5297d) Signed-off-by: Fridolin Somers commit 835343a1ef10c6606d625df2096b8bba518ee01d Author: Kyle M Hall Date: Fri Mar 7 09:05:31 2014 -0500 Bug 11563: (follow-up) add noEnterSubmit class to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combination of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit db3d4a0d7d2b97a021be1464a99b8084c31b62cb) Signed-off-by: Fridolin Somers commit a489bf50f22ff664a73a1b795a76aa5e837b4e3e Author: Kyle M Hall Date: Wed Feb 26 12:51:11 2014 -0500 Bug 11563: (follow-up) change .live() to .on() The jquery event handler .live() has been deprecated. It is recommended that .on() be used instead. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 1226f901cef989915ee68e7ac7d1b1acf9fba91c) Signed-off-by: Fridolin Somers commit bbe90f900059cac7f470954473a406081c897bc1 Author: Fridolin Somers Date: Tue Feb 25 12:13:13 2014 +0100 Bug 11563: restore preventing the enter key from submitting several forms Several forms that take patron or item barcodes as input stopped preventing the enter key (which is often sent by barcode scanners) from submitting the form. The code binding the CSS class noEnterSubmit to the handler preventing submission when hitting the enter key was no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event handlers for HTML generated with JavaScript. Also sets noEnterSubmit to use the checkEnter(e) function, as that has broader browser compatibility. Also corrects a small bug, for IE, window.event must be used, not event alone. Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Works as described, tested in Firefox and Chromium. Passes tests and QA script. Signed-off-by: Galen Charlton (cherry picked from commit e5ab2203745d7c70e1c4d2f54cea967710a88b96) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 30 ++++++++++---------- .../prog/en/modules/cataloguing/additem.tt | 2 +- .../prog/en/modules/members/mancredit.tt | 2 +- .../prog/en/modules/members/maninvoice.tt | 2 +- .../prog/en/modules/members/memberentrygen.tt | 2 +- 5 files changed, 19 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 7 18:50:35 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 07 May 2014 16:50:35 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-12-g6f9e61d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 6f9e61df9a9fec128fda5c264d6a99d2451e839d (commit) via 740bd016a035d4e8b2fcfc385c10dbbe979ec227 (commit) from 63fd484189b713dc5621cf8f467bbb10a5899032 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f9e61df9a9fec128fda5c264d6a99d2451e839d Author: Jonathan Druart Date: Fri Jan 24 16:07:08 2014 +0100 Bug 11608: Delete unused commented lines in template On the way, these lines are commented and can be deleted safely. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Removes an HTML comment with unused code. Signed-off-by: Galen Charlton (cherry picked from commit fb8e159daad8556832d45c9581e32b76aee02e1c) Signed-off-by: Fridolin Somers commit 740bd016a035d4e8b2fcfc385c10dbbe979ec227 Author: Nicole C. Engard Date: Fri Jan 24 08:34:27 2014 -0600 Bug 11608: Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Signed-off-by: Jonathan Druart Amended patch: remove a space Signed-off-by: Katrin Fischer Works as described. Signed-off-by: Galen Charlton (cherry picked from commit b865e1a024331fbbb76570f84afc9302a7340f7d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 7 23:32:43 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 07 May 2014 21:32:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-9-g76cfc45 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 76cfc45682c1c08a4db777428e8ed163bc578a50 (commit) from f8f7382ef7267d53b61462773e300e517c48e9e8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 76cfc45682c1c08a4db777428e8ed163bc578a50 Author: Kyle M Hall Date: Wed May 7 12:04:48 2014 -0400 Bug 12212: fix error that prevented sysprefs.sql from loading The line for inserting AggressiveMatchOnISBN didn't have the right number of columns. Test Plan: 1) Attempt to run the web installer OR try to import the sysprefs.sql into your db 2) Apply this patch 3) Try again, no errors should be reported this time Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 8 18:16:27 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 08 May 2014 16:16:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-18-g6f0215d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6f0215da9efcd1d7dba02aba5dde327f8d17b13f (commit) via fb8d47bedac13944d8efd6eec8286c3eff574782 (commit) via 769f18a6a95b3757cb830b0765d93149d03a6495 (commit) via 0b06e4ee189c13964a461800e512757871ad22fa (commit) via c2dae3288b5fb4e99b7e7f616e4e2d4ea391b1f9 (commit) via 6f4a45c47d68951a9dcebfbd212373ac3c685d62 (commit) via e26d4f23e5689587aaa17d8dcaf9ef2c0ea9a79c (commit) via 36284b7f5fd6e62f335f159e7776e866957a17bc (commit) via 88f0735be3fffc86be7875ea908b66d882118f99 (commit) from 76cfc45682c1c08a4db777428e8ed163bc578a50 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f0215da9efcd1d7dba02aba5dde327f8d17b13f Author: Owen Leonard Date: Thu Apr 24 12:41:29 2014 -0400 Bug 9723: display time due for hourly loans in the public catalog Due dates in the OPAC don't display the time items are due, and thus items which are on hourly loans don't display an accurate due date and time. This patch corrects this by adding (and using) a new "as_due_date" option to the KohaDates plugin made possible by Bug 11148. Thanks to Galen for providing the changes to KohaDates.pm. To test, enable an hourly loan period for an itemtype in your collection. View the display of date due on the following pages: - Patron details (opac-user.pl) - Log into the OPAC as a user who has something checked out which circulates by the hour. - Bibliographic details (opac-detail.pl) - View the details for an item which is circulates by the hour and is checked out. - Course reserves details (opac-course-details.pl) - View the contents of a course reserve, one of which should be an item which circulates by the hour and is checked out. Due dates for hourly items should show both date and time and be formatted correctly. Due dates for non-hourly loans should show only the date. Test in both prog and Bootstrap themes. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit fb8d47bedac13944d8efd6eec8286c3eff574782 Author: Galen Charlton Date: Thu May 8 16:36:10 2014 +0000 Bug 4068: (follow-up) use URI::Escape This allows for suggestions that contain characters such as the ampersand to have their status changed. Signed-off-by: Galen Charlton commit 769f18a6a95b3757cb830b0765d93149d03a6495 Author: Kyle M Hall Date: Tue May 6 08:49:15 2014 -0400 Bug 4068: ensure accepting a suggestion does not hide the 'pending' tab Prior to this patch: 1) Moving a suggestion from status 'pending' to 'accepted - After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' - After saving only tab 'pending' is shown. Test Plan: 1) Verify the bug by taking the actions listed above 2) Apply this patch 3) Verify the bug no longer exists Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart It is not very elegant but I have nothing else to suggest. Signed-off-by: Galen Charlton commit 0b06e4ee189c13964a461800e512757871ad22fa Author: Owen Leonard Date: Tue May 6 11:02:48 2014 -0400 Bug 12195 - Remove duplicated plugin jquery.dataTables.min.js All templates in the staff client now load the DataTables jquery plugin through a single include file, datatables.inc, which points to a copy of the plugin in intranet-tmpl/lib/jquery/plugins. This patch removes the unused copy of the plugin found in intranet-tmpl/prog/en/lib/jquery/plugins. To test, search the Koha source for references to jquery.dataTables.min.js. There should be no files which point to the redundant file. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit c2dae3288b5fb4e99b7e7f616e4e2d4ea391b1f9 Author: Owen Leonard Date: Tue May 6 11:20:58 2014 -0400 Bug 12196 - Remove unused jquery.qtip.js plugin The qTip jQuery plugin is not longer used anywhere in Koha. This patch removes it. To test, apply the patch and search the Koha source for references to the plugin. There should be none. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 6f4a45c47d68951a9dcebfbd212373ac3c685d62 Author: Galen Charlton Date: Tue May 6 20:08:17 2014 +0000 Bug 12198: (follow-up) fix warning when opening guarantor search form To test: [1] Verify that act of running a guarantor search does not result in the following warning message in the Apache log: "guarantor_search.pl: Use of uninitialized value $member in string ne at guarantor_search.pl line 63" Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit e26d4f23e5689587aaa17d8dcaf9ef2c0ea9a79c Author: Kyle M Hall Date: Tue May 6 12:36:30 2014 -0400 Bug 12198: (code cleanup) remove unused variables, tidy code To test: [1] Perform searches for guarantors and verify that there are no regressions. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 36284b7f5fd6e62f335f159e7776e866957a17bc Author: Kyle M Hall Date: Tue May 6 12:26:49 2014 -0400 Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search The script members/guarantor_search.pl made the following call: my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); Not only does this call always fail because borrowerid is not a valid key, but the results are never even used in the template! Test Plan: 1) Apply this patch 2) Verify the gurantor search works as before, No changes in behavior should be noted Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 88f0735be3fffc86be7875ea908b66d882118f99 Author: Robin Sheat Date: Wed Apr 30 15:33:44 2014 +1200 Bug 9048 - fix quote editor under Plack The ajax responder for the quote editor was using the wrong error codes. These have been fixed. Also, a small fixup to get rid of some annoying warnings. To test: * Under plack, * Add/edit/delete a quote. * Make sure that things don't crash. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: Koha/Template/Plugin/KohaDates.pm | 4 +- .../en/lib/jquery/plugins/jquery.dataTables.min.js | 156 -------------------- .../prog/en/lib/jquery/plugins/jquery.qtip.js | 15 -- .../bootstrap/en/modules/opac-course-details.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 6 +- .../prog/en/modules/opac-course-details.tt | 2 +- koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +- koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 6 +- members/guarantor_search.pl | 130 ++++++++-------- suggestion/suggestion.pl | 16 +- tools/quotes/quotes_ajax.pl | 21 +-- 12 files changed, 99 insertions(+), 263 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.qtip.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 9 16:23:51 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 May 2014 14:23:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-26-g31781ff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 31781ffb02c3a806e0956ca07dfc24beab0b88dd (commit) via d514c21aed640be48dfbc70d3976ec0f865bb370 (commit) via 0625685f7c3940b6c811547fa3ea4449821e8d87 (commit) via 795700d8f084b1512f2b972ebb76d0110c48e818 (commit) via 6973e3b7d50777a147a29f2f3d213a6175c9eb74 (commit) via 4e7e8a5544297aa6d02eb86b4a621e25a19e9e0b (commit) via 606e902838f866cdf92c2bb66a4666d8d66c0498 (commit) via 9b2431e83a8cb9120f9f536f72c0546021b0b054 (commit) from 6f0215da9efcd1d7dba02aba5dde327f8d17b13f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31781ffb02c3a806e0956ca07dfc24beab0b88dd Author: Kyle M Hall Date: Fri May 9 09:35:03 2014 -0400 Bug 12214: (follow-up) Clean up reports-toolbar.inc, show Edit link when SQL has errors Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit d514c21aed640be48dfbc70d3976ec0f865bb370 Author: Galen Charlton Date: Thu May 8 16:12:32 2014 +0000 Bug 12214: (follow-up) correct POD of C4::Reports::Guided::execute_query() Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 0625685f7c3940b6c811547fa3ea4449821e8d87 Author: Pasi Kallinen Date: Thu May 8 10:11:29 2014 +0300 Bug 12214: display SQL errors in reports to users When a user runs a report containing an SQL error, no error is shown to the user. This patch fixes this. To test: 1) Run a report with known good SQL. 2) No error is shown. 3) Run a report with bad SQL (eg. a typo in field name) 4) No error is shown. 5) Apply patch 6) Repeat 1-4. For the bad SQL report, the database error should be shown. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 795700d8f084b1512f2b972ebb76d0110c48e818 Author: Galen Charlton Date: Thu May 8 16:09:07 2014 +0000 Bug 12214: add regression test for reporting error when running report with SQL error To test: [1] Run prove -v t/db_dependent/Reports_Guided.t. Last test should fail. [2] Apply the main patch. [3] Run step 1 again. This time, all tests should pass. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74 Author: Galen Charlton Date: Thu May 8 15:13:15 2014 +0000 Bug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge() This patch consolidates the code for constructing the parameters for GetBorrowersToExpunge() into a subroutine. As a side-effect, this fixes a regression introduced by the main patch where no patrons would be deleted when filtering by expiration date. To test: [1] Follow the test plan in the main patch. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 4e7e8a5544297aa6d02eb86b4a621e25a19e9e0b Author: Jonathan Druart Date: Thu Mar 20 16:41:29 2014 +0100 Bug 11975: improve the batch patron deletion code This patch tries to improve the code for the cleanborrowers.pl tool. - use KohaDates plugin and Koha::DateUtils for date management, removing a dependency on C4::Dates - replace variables step1, step2 and step3 with step - add a JavaScript check if no action if checked Test plan: - Backup your DB - Play with the Patron deletion/anonymisation tool and try to find something inconsistent. If you don't find something different, it works! Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 606e902838f866cdf92c2bb66a4666d8d66c0498 Author: Julian Maurice Date: Wed May 7 10:40:58 2014 +0200 Bug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 9b2431e83a8cb9120f9f536f72c0546021b0b054 Author: Julian Maurice Date: Mon Apr 28 11:50:04 2014 +0200 Bug 11843: prevent manual history from being overwritten if subscription switched to automatic history Test plan: 1/ Create a new subscription, with manual history enabled 2/ Edit history by clicking on "Edit history" under Planning tab (add some text) 3/ Receive some serials, see that received and missing issues are not updated in Summary tab 4/ Edit subscription and disable manual history 5/ Receive some serials, see that received and missing issues are updated, but your notes have been kept. 6/ Edit serials and change status from/to missing or not available. Check that missing issues are updated correctly. 7/ Edit serials and change status from/to arrived. Check that received issues are updated correctly. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 5 +- C4/Serials.pm | 75 +++++----------- .../prog/en/includes/reports-toolbar.inc | 32 +++++-- .../prog/en/modules/tools/cleanborrowers.tt | 33 ++++--- reports/guided_reports.pl | 2 +- t/db_dependent/Reports_Guided.t | 15 +++- t/db_dependent/Serials.t | 8 +- tools/cleanborrowers.pl | 92 +++++++++++--------- 8 files changed, 139 insertions(+), 123 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 9 16:50:36 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 May 2014 14:50:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-27-g76e8bb0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 76e8bb0fabd4a9ef85fd2dc5ad604c446a50f751 (commit) from 31781ffb02c3a806e0956ca07dfc24beab0b88dd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 76e8bb0fabd4a9ef85fd2dc5ad604c446a50f751 Author: Marcel de Rooy Date: Thu Apr 10 14:40:01 2014 +0200 Bug 12065: use encode_qp consistently when sending basket/shelf QP-encode both mail header and mail body when sending baskets or shelves. There is no need to Encode qp-encoded strings. Note that this does not solve all possible encoding problems in the mail sent. This is related to decoding CGI parameters and use of TT. That problem is addressed in bug 11944. Test plan: Verify if sending a basket from opac and staff still works. Check if sending a shelf (list) from opac and staff still functions as expected. Signed-off-by: Bernardo Gonzalez Kriegel Cart/List sent form opac/staff works No koha-qa errors Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: basket/sendbasket.pl | 12 +++--------- opac/opac-sendbasket.pl | 3 ++- opac/opac-sendshelf.pl | 3 ++- virtualshelves/sendshelf.pl | 3 ++- 4 files changed, 9 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 12 16:07:36 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 12 May 2014 14:07:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-28-ge7bf506 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e7bf50600d053238d354ec2989f3fbe542c47aaa (commit) from 76e8bb0fabd4a9ef85fd2dc5ad604c446a50f751 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e7bf50600d053238d354ec2989f3fbe542c47aaa Author: Owen Leonard Date: Thu Apr 24 15:21:59 2014 -0400 Bug 9724: ensure hourly loans show time due in SCO Due dates in the self checkout module don't display the time items are due, and thus items which are on hourly loans don't display an accurate due date and time. This patch corrects this by adding the "as_due_date => 1" parameter added by Bug 9723. To test, apply the patch for Bug 9723 if necessary. Enable an hourly loan period for an itemtype in your collection. Log into the self-checkout system and check out an item which circulates by the hour. The due date and time should be displayed correctly. Check out an item which does not circulate hourly. The due date should be displayed as a date only. Test in both prog and Bootstrap themes. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 4 ++-- koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 13 15:45:33 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 13 May 2014 13:45:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-32-g739def8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 739def89dddf2fda76d998a6eebcb08304aaf3cd (commit) via 5bf1935736e33f95a8b1e472d77d39f1e148bf4f (commit) via cf9b9bfbca6a1d43254b1561be03bf14cd73312e (commit) via 8f223865275968312c786b577f9bf833cf5dfe82 (commit) from e7bf50600d053238d354ec2989f3fbe542c47aaa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 739def89dddf2fda76d998a6eebcb08304aaf3cd Author: Robin Sheat Date: Tue May 13 15:34:38 2014 +1200 Bug 12234 - build script version update Make the script build 3.16 packages. To be updated to 3.17 once master splits off again. Signed-off-by: Galen Charlton commit 5bf1935736e33f95a8b1e472d77d39f1e148bf4f Author: Robin Sheat Date: Mon Dec 30 15:04:26 2013 +1300 Bug 12234 - changelog updates from 3.14 series Signed-off-by: Galen Charlton commit cf9b9bfbca6a1d43254b1561be03bf14cd73312e Author: Robin Sheat Date: Tue May 13 11:12:53 2014 +1200 Bug 12234 - dependency changes to allow master to build A run of update-control, adding bash-completion as a build-time dependency, allowing update-control to ignore anything that doesn't have a package but isn't marked as "required" by Koha, added dependencies that we don't use but is needed by something we do use. All fairly mundane. Signed-off-by: Galen Charlton commit 8f223865275968312c786b577f9bf833cf5dfe82 Author: Galen Charlton Date: Wed May 7 17:43:25 2014 +0000 Bug 12206: fix HTML in other holdings list in staff search results page To test: [1] View, in the staff interface, a record with alternate holdings (as controlled by the AlternateHoldingsField system preference). [2] Verify that the HTML list is closed correctly. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 13 ++++++ debian/build-git-snapshot | 2 +- debian/changelog | 44 ++++++++++++++++++++ debian/control | 12 +++++- debian/control.in | 2 +- debian/list-deps | 3 ++ .../prog/en/modules/catalogue/results.tt | 2 +- 7 files changed, 74 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 04:29:47 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 02:29:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-38-gb77d69a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b77d69abbeb95bb55d7c93d2a132d89db22bf3e4 (commit) via 9a045d4a9f9f29a837e7975e8f7f7162c3324d57 (commit) via b33bbcebab1e1f70c9400ec30cb8d35537edfa1d (commit) via 01107420d72bf88bba9dd086151ad912aea5bef1 (commit) via 3da8c33b7766134ed4ad1c61224ec73760ed9d4a (commit) via 648957ca8be72508307d94693792d216b7ae18a4 (commit) from 739def89dddf2fda76d998a6eebcb08304aaf3cd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b77d69abbeb95bb55d7c93d2a132d89db22bf3e4 Author: Koha SAB CINECA Date: Wed May 14 17:57:50 2014 +0200 Bug 11241: update the Italian MARC21 setup for 3.16 To test: - Apply this patch. - Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you prefer) - Install it-IT templates on command line - Run the webinstaller using it-IT - Follow the steps and choose all under 'opzionali' => SUCCESS: no errors => Sign this => Extra: see the cataloguing frameworks and check if you like the translation Signed-off-by: Bernardo Gonzalez Kriegel All files load ok, no errors. Signed-off-by: Katrin Fischer Web installer loads all files without errors. Verified 3 bibliographic frameworks and 5 authority types appear to be translated correctly. Signed-off-by: Galen Charlton commit 9a045d4a9f9f29a837e7975e8f7f7162c3324d57 Author: Robin Sheat Date: Thu May 15 10:39:26 2014 +1200 Bug 12259 - fix version numbers in dependencies This sets the version numbers of the modules added by bug 12234 to more sensible values (in this case, the versions included in Debian Squeeze.) Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit b33bbcebab1e1f70c9400ec30cb8d35537edfa1d Author: Jonathan Druart Date: Wed May 14 09:11:57 2014 +0200 Bug 12251: fix error in sample_notices.sql (ru-RU) Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 01107420d72bf88bba9dd086151ad912aea5bef1 Author: Jonathan Druart Date: Wed May 14 09:11:38 2014 +0200 Bug 12251: fix error in sample_notices.sql (fr-FR) Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 3da8c33b7766134ed4ad1c61224ec73760ed9d4a Author: Tomas Cohen Arazi Date: Tue May 13 18:50:27 2014 -0300 Bug 12251: fix error in sample_notices.sql (es-ES) On bug 10845 some lines from sample_notices.sql were ommited when adding the trailing parameter. This produces some errors when installing using 'es-ES' sample data; and, in some conditions I couldn't reproduce right now, occasional C4/NewsChannel.pm errors due to mandatory message transport data incompletely loaded. To reproduce: - Make sure your setup has the es-ES translations installed and up-to-date (translation should raise lots of warnings) - With a cleaned (DROP DATABASE ... ; CREATE DATABASE ...;) run the webinstaller - Choose es-ES for the webinstaller. - Follow the steps and choose all the sample data. => Errors related to sample_notices.sql and sample_notices_message_transports.sql show. To fix: - Apply this patch. - Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you prefer) - Run the webinstaller using es-ES - Follow the steps and choose all sample data. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 648957ca8be72508307d94693792d216b7ae18a4 Author: Magnus Enger Date: Thu May 15 08:38:47 2014 +0200 Bug 12209 - Fix currency symbol for NOK Dunno why, but the currency symbol for NOK was given as "$", when it should be "kr". To test: - Empty the "currency" table in the DB: DELETE FROM currency; - Load in the file changed by this patch: sudo koha-mysql < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql (if you are testing on a (gitified) package install) - Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl - Add a budget and a fund, and check that "kr" is displayed in the list of funds (currency symbols seem to be missing from the list of budgets) Signed-off-by: Bernardo Gonzalez Kriegel file loads ok, kr currency active, no errors Signed-off-by: Katrin Fischer Works as described, no problems found. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 4 +- .../data/mysql/es-ES/mandatory/sample_notices.sql | 8 +- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 2 +- .../marc21/mandatory/authorities_normal_marc21.sql |10416 +---- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 6313 +-- .../marc21/optional/marc21_fastadd_framework.sql | 274 +- .../optional/marc21_holdings_coded_values.sql | 247 +- .../optional/marc21_holdings_coded_values.txt | 2 + .../optional/marc21_simple_bib_frameworks.sql |47457 ++++++++++---------- .../data/mysql/nb-NO/2-Valgfritt/parameters.sql | 4 +- .../data/mysql/ru-RU/mandatory/sample_notices.sql | 2 +- 11 files changed, 29606 insertions(+), 35123 deletions(-) copy installer/data/mysql/{pl-PL => it-IT/marcflavour/marc21}/optional/marc21_holdings_coded_values.sql (52%) create mode 100644 installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_holdings_coded_values.txt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 09:45:39 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 07:45:39 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-13-g1bf1dac Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1bf1dacc7b2ec64b9b17d9b3947209918b3ba02f (commit) from 6f9e61df9a9fec128fda5c264d6a99d2451e839d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1bf1dacc7b2ec64b9b17d9b3947209918b3ba02f Author: Jonathan Druart Date: Wed Mar 5 13:44:49 2014 +0100 Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters" This reverts commit c9905750e53e2e1615842ac696d5eeb0a8ac07fc. Test plan: 1/ Open a bib record with more than 1 item , 2/ Select all items 3/ Chose Modify selected items 4/ put you "? ? ?" in notes 5/ Verify the items have been updated correctly 6/ put you "???" in notes 7/ Verify the items have been updated correctly 8/ put you "? ? ? ???" in notes 9/ Verify the items have been updated correctly Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Confirmed bug on master and that the patch fixes it. Passes all tests and the QA script. Signed-off-by: Galen Charlton (cherry picked from commit e55d89be20acb58deb45a30c113bf0f07170fd33) ----------------------------------------------------------------------- Summary of changes: tools/batchMod.pl | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 09:49:32 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 07:49:32 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-14-g964d8cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 964d8cbe4c1ebbcc90c10ee9ff808ab09431cec1 (commit) from 1bf1dacc7b2ec64b9b17d9b3947209918b3ba02f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 964d8cbe4c1ebbcc90c10ee9ff808ab09431cec1 Author: Fr?d?ric Demians Date: Sat Feb 1 09:49:38 2014 +0100 Bug 11663: fix display of holding tab in Bootstap OPAC when opacbookbag syspref is disabled Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variables are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a bulleted list Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes QA script and all tests. Confirmed display problem exists without the patch and is solved by it. Ideally we would avoid having the cart messages in the template when the feature is deactivated, but this is ok for now. Signed-off-by: Galen Charlton (cherry picked from commit e3c203aebb939af63aefc81f77474adc0234ca4c) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 10:07:43 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 08:07:43 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-15-ga2c471d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via a2c471dc40fc9a049e554282eb0507e0d94a2cf0 (commit) from 964d8cbe4c1ebbcc90c10ee9ff808ab09431cec1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2c471dc40fc9a049e554282eb0507e0d94a2cf0 Author: Owen Leonard Date: Wed Jan 29 12:17:09 2014 -0500 Bug 11636 - make it possible to remove patrons from patron list during add process If your patrons have card numbers with leading zeroes this causes problems removing patron entries during the process of adding patrons to an existing list. This patch refactors the relevant JavaScript to correct the problem and to remove inline "onclick" from generated HTML. This patch also includes a fix for Bug 11632 - Untranslatable string "Remove" in patron lists. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Tools -> Patron lists. 3. Click "Add patrons" on an existing list. 4. Perform a patron search and choose one of the results. 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and test again. The "remove" link should now work. To test the fix for Bug 11632, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for patron_lists/list.tt. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script, works as described. Signed-off-by: Galen Charlton (cherry picked from commit f3d5887870bad581e312b40bd474b38b5788122d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 11:49:53 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 09:49:53 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-17-g1de3d85 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1de3d85574568b8eef769dc5d16af879b920b65f (commit) via 82f5b527d8cb79e8d1309b42faa461bcea12924d (commit) from a2c471dc40fc9a049e554282eb0507e0d94a2cf0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1de3d85574568b8eef769dc5d16af879b920b65f Author: Galen Charlton Date: Mon Mar 10 22:48:03 2014 +0000 Bug 10611: (follow-up) cache DBMS driver code in context object Rather than use a package-level variable, use an object-level one. Signed-off-by: Galen Charlton (cherry picked from commit 7d39b3c72ea2422b09e3411bef974d87aecdabf9) Signed-off-by: Fridolin Somers Conflicts: C4/Context.pm commit 82f5b527d8cb79e8d1309b42faa461bcea12924d Author: Jonathan Druart Date: Tue Jul 16 11:53:47 2013 +0200 Bug 10611: Use mysql_auto_reconnect instead of ping DBD::Mysql provides a mysql_auto_reconnect flag. Using it avoids the time required to do a $dbh->ping(). Benchmarks: use Modern::Perl; use C4::Context; for ( 1 .. 1000 ) { $dbh = C4::Context->dbh; } * without this patch on a local DB: perl t.pl 0,49s user 0,02s system 98% cpu 0,525 total * without this patch on a remote DB: perl t.pl 0,52s user 0,05s system 1% cpu 37,358 total * with this patch on a local DB: perl t.pl 0,46s user 0,04s system 99% cpu 0,509 total * with this patch on a remote DB: perl t.pl 0,49s user 0,02s system 56% cpu 0,892 total Testing the auto reconnect: use Modern::Perl; use C4::Context; my $ping = $dbh->ping; say $ping; $dbh->disconnect; $ping = $dbh->ping; say $ping; Signed-off-by: Bernardo Gonzalez Kriegel Comment: Real improvement. No koha-qa errors prove t/db_dependent/Circulation_issuingrules.t produces no error prove t/db_dependent/Context.t produces no error Test 1) dumped Koha DB, load it on a non-local server 2) run sample script whit and without patch, local and remote use Modern::Perl; use C4::Context; for ( 1 .. 100000 ) { my $dbh = C4::Context->dbh; } Main difference I note is with remote server a) without patch real 0m16.357s user 0m2.592s sys 0m2.132s b) with patch real 0m0.259s user 0m0.240s sys 0m0.012s I think this could be good for DBs placed on remote servers Bug 10611: add a "new" parameter to C4::Context->dbh When dbh->disconnect is called and the mysql_auto_reconnect flag is set, the dbh is not recreated: the old one is used. Adding a new flag, we can now force the C4::Context->dbh method to return a new dbh. Signed-off-by: Bernardo Gonzalez Kriegel Bug 10611: Followup: remove useless calls to dbh->disconnect These 3 calls to disconnect are done at the end of the script, they are useless. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Paul Poulain Signed-off-by: Galen Charlton (cherry picked from commit 4ae3665ad8afb5d283d989c4622a91690e1c4f8a) Signed-off-by: Fridolin Somers Conflicts: C4/Context.pm ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 18 ++++++++++++++---- installer/install.pl | 2 -- misc/cronjobs/j2a.pl | 1 - sms/sms_listen.pl | 1 - t/db_dependent/Context.t | 5 +---- 5 files changed, 15 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 12:11:40 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 10:11:40 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-20-ge5c0783 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via e5c0783d20de75ca6f3599b2061ba64216b45c59 (commit) via 849f178cd804bd6e54f2c02deb9d7b9837f255e4 (commit) via e25da1fa432ea43cede897b5b8c5adc485fa6da6 (commit) from 1de3d85574568b8eef769dc5d16af879b920b65f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e5c0783d20de75ca6f3599b2061ba64216b45c59 Author: Fridolin Somers Date: Fri May 16 12:36:16 2014 +0200 Bug 11415: DBRev 3.14.06.001 commit 849f178cd804bd6e54f2c02deb9d7b9837f255e4 Author: Kyle M Hall Date: Fri Jan 10 09:15:25 2014 -0500 Bug 11415 (QA Followup) fix whitespace This patch also fixes a JavaScript syntax error if the SelfCheckReceiptPrompt system preference is off. Signed-off-by: Galen Charlton (cherry picked from commit 6254f5f07ab84ef7d6b6518d8f39bde9987a92e4) Signed-off-by: Fridolin Somers commit e25da1fa432ea43cede897b5b8c5adc485fa6da6 Author: JaTara Barnes Date: Sun Jan 5 00:33:31 2014 -0600 Bug 11415: Add syspref to toggle SCO receipt printing This patch adds the SelfCheckReceiptPrompt to control whether receipts are automatically printed when a patron finishes a SCO session. This is on by default during new installations and upgrades. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 9cc3b69a0cf1adfc7c50c25ef6d57c2e027e8950) Conflicts: installer/data/mysql/updatedatabase.pl ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 +++++++ .../prog/en/modules/admin/preferences/circulation.pref | 7 +++++++ koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 10 +++++++--- koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt | 9 ++++++--- kohaversion.pl | 2 +- 6 files changed, 29 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 12:16:13 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 10:16:13 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-22-gc69dfd1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via c69dfd1de219230187928fe258dff9a9ca3b8f2f (commit) via 6bef116c046af6db031f0243add63afdf7fd0f1b (commit) from e5c0783d20de75ca6f3599b2061ba64216b45c59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c69dfd1de219230187928fe258dff9a9ca3b8f2f Author: Galen Charlton Date: Fri Jan 31 15:30:29 2014 +0000 Bug 11616: (follow-up) remove tablesorter CSS This patch removes CSS rules that applied only to use of the jQuery tablesorter plugin, which is now gone. To test: [1] Verify that git grep -l headerSort does not turn up any results. Signed-off-by: Galen Charlton (cherry picked from commit 1a5da08342182c739f2f5b790038c6ff04c748ea) Signed-off-by: Fridolin Somers commit 6bef116c046af6db031f0243add63afdf7fd0f1b Author: Jonathan Druart Date: Mon Jan 27 12:22:21 2014 +0100 Bug 11616: remove jQuery tablesorter plugin DataTables has replaced the tablesorter plugin for client-side sorting of tables in Koha. There is no table using this plugin, so this patch removes it and remaining references to it. REVISED TEST PLAN ----------------- 1) Apply the patch 2) Home -> Koha administration -> Authorized values 3) Change the 'Show category:' drop down value, and play with the sorting of columns. -- should sort as expected. 4) Search the catalogue -> look for a biblio with high circulation 5) Click one of the name links. 6) Click the Items tab on the left. 7) Scroll down and click the (View item's checkout history) link in the History area. -- There was no sorting prior to the patch, so afterwards it should display the same. 8) git grep -i tablesorter -- Only a reference in staff-global.css and release texts. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit 166720982e59a929aac9191d89af57a57545ff15) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/css/staff-global.css | 14 -- .../lib/jquery/plugins/jquery.tablesorter.min.js | 2 - .../lib/jquery/plugins/jquery.tablesorter.pager.js | 184 -------------------- .../prog/en/modules/admin/authorised_values.tt | 2 +- .../prog/en/modules/circ/bookcount.tt | 2 - koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css | 15 +- koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css | 13 -- .../lib/jquery/plugins/jquery.tablesorter.min.js | 2 - koha-tmpl/opac-tmpl/ccsr/en/css/opac.css | 13 -- koha-tmpl/opac-tmpl/prog/en/css/opac.css | 13 -- 10 files changed, 2 insertions(+), 258 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.tablesorter.min.js delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.tablesorter.pager.js delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.tablesorter.min.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 16 14:22:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 16 May 2014 12:22:22 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-23-gfe4e5ed Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via fe4e5eded2c4531600f700cbd1f0b0582f316bbb (commit) from c69dfd1de219230187928fe258dff9a9ca3b8f2f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe4e5eded2c4531600f700cbd1f0b0582f316bbb Author: Pasi Kallinen Date: Thu Apr 24 11:01:52 2014 +0300 Bug 11631: Make i18n toolchain ignore useless strings This patch removes several types of strings from the PO files that cannot be usefully translated, including ones that consist entirely of punctuation and/or HTML entities. Test: 1) Update PO files of some lang, xx-YY-*po cd misc/translator perl translate update xx-YY 2) Do it again, just in case 3) rm po/xx-YY*po~ 4) Extract all msgid's, sorted cat po/xx-YY*po | egrep "^msgid" | sort | uniq > xx-YY-pre 5) Apply the patch 6) Repeat 1-3 7) Repeat 4 again, other file cat po/xx-YY*po | egrep "^msgid" | sort | uniq > xx-YY-post 8) Do a diff, inspect results, only strings with %s and \s diff xx-YY-pre xx-YY-post | less Signed-off-by: Bernardo Gonzalez Kriegel Works as described, 380 strings less to 'translate' No koha-qa errors. Signed-off-by: Katrin Fischer Tested according to test plan, works as described. Signed-off-by: Galen Charlton (cherry picked from commit c2295530401f53653386ff07a43c668a6a574d65) ----------------------------------------------------------------------- Summary of changes: misc/translator/xgettext.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 09:02:40 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 07:02:40 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-24-g6162e63 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 6162e63b2223101210724572da5b8af6365c6990 (commit) from fe4e5eded2c4531600f700cbd1f0b0582f316bbb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6162e63b2223101210724572da5b8af6365c6990 Author: Jonathan Druart Date: Wed Feb 5 10:39:26 2014 +0100 Bug 11687: remove disused script statecollection.pl It can be removed. Test plan: git grep statecollection returns no occurrence. Signed-off-by: Holger Meissner Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit b2d08f8359c187f92e1df46ad29b83852fb03079) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: serials/statecollection.pl | 97 -------------------------------------------- 1 file changed, 97 deletions(-) delete mode 100755 serials/statecollection.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:21:58 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:21:58 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-25-gc24c92f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via c24c92fd440a8f3e9e4b6c9003cc1887511d901a (commit) from 6162e63b2223101210724572da5b8af6365c6990 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c24c92fd440a8f3e9e4b6c9003cc1887511d901a Author: Owen Leonard Date: Fri Feb 7 16:02:06 2014 -0500 Bug 11721 - Use new DataTables include in suggestions template This patch modifies the template for the suggestions page to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Sorting is now configured to exclude articles when sorting the title column. To test, apply the patch and view the suggestions page (Acquisitions -> Suggestions). Sorting of suggestions should work correctly. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Note: the columsn fund and status are not sortable/searchable before and after applying the patch. Signed-off-by: Galen Charlton (cherry picked from commit 2f379f3fa78ea12c3955addfa733fb8d8cdb0c2b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:23:54 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:23:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-26-g1ca711c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1ca711c79154dac5ca812ede42b137a5ec5d8d04 (commit) from c24c92fd440a8f3e9e4b6c9003cc1887511d901a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1ca711c79154dac5ca812ede42b137a5ec5d8d04 Author: Owen Leonard Date: Mon Feb 3 12:03:14 2014 -0500 Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. --------------------------------------------------------------------- Created to patron lists and confirmed the collums 'add patrons', 'edit' and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' are still sortable. The size of buttons are smaller. I also agree this is an improvement. Signed-off-by: Petter Goksoyr Asen Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 9ac83cdaafb267e1a76aa957b86b7e7b8955d819) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/patron_lists/lists.tt | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:25:36 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:25:36 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-27-ga47eb5e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via a47eb5ea549b63d8fb410f966124c7ef0fdc3227 (commit) from 1ca711c79154dac5ca812ede42b137a5ec5d8d04 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a47eb5ea549b63d8fb410f966124c7ef0fdc3227 Author: Tomas Cohen Arazi Date: Thu Feb 6 17:30:24 2014 -0300 Bug 11704: Make */svc/report print the correct headers To test: 1 - Go through the first comments instructions to reproduce and verify the bug is present (OPAC and STAFF) 2 - Apply the patch 3 - Repeat step 1 and notice * characters are not broken anymore * the header is correct 4 - Sign off Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit aace5d436dbab1f13e2e1c06d0b4ed5f1ec13ced) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: opac/svc/report | 5 ++++- svc/report | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:29:49 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:29:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-28-gac797fe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via ac797fed25a591f6d1529f3b88ef3ea8cd2fbb36 (commit) from a47eb5ea549b63d8fb410f966124c7ef0fdc3227 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ac797fed25a591f6d1529f3b88ef3ea8cd2fbb36 Author: Janusz Kaczmarek Date: Fri Jan 31 16:12:10 2014 +0100 Bug 11652: ensure that merging authority records corrects biblios When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Note: new record count on the authority record will show after reindexing. Signed-off-by: Jared Camins-Esakov Signed-off-by: Galen Charlton (cherry picked from commit 0070a7f6afb30b6f7ae8bc0eb073a4c39e0f783a) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: authorities/merge.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:33:03 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:33:03 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-30-gbd5393a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via bd5393a4fdb05f9cc6af4a538f8f842154f32d6a (commit) via 98babf0a0af53a913ac90b395cad30af3a11d043 (commit) from ac797fed25a591f6d1529f3b88ef3ea8cd2fbb36 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd5393a4fdb05f9cc6af4a538f8f842154f32d6a Author: Jonathan Druart Date: Tue Feb 11 10:28:23 2014 +0100 Bug 11737: (follow-up) remove extra fnReloadAjax.js the file dataTables.fnReloadAjax.js exists in the interface and themelang directories. It is only used in quotes.tt. So the unused one can be removed. test plan: git grep fnReloadAjax.js should return only 1 ref (quotes.tt) Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit e0d7d998c2025fdb8ed1caf4303f754e05164c97) Signed-off-by: Fridolin Somers commit 98babf0a0af53a913ac90b395cad30af3a11d043 Author: Owen Leonard Date: Mon Feb 10 14:30:26 2014 -0500 Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Signed-off-by: merlissia Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 326ccb57ce8c537630b117bc92bd49ca4947c52b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../lib/jquery/plugins/dataTables.fnReloadAjax.js | 50 -------------------- .../intranet-tmpl/prog/en/modules/tools/quotes.tt | 8 ++-- 2 files changed, 3 insertions(+), 55 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/dataTables.fnReloadAjax.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:34:30 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:34:30 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-31-g1d38c4e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1d38c4e9b297eca2d562b2c4ff387c9ab6d543f2 (commit) from bd5393a4fdb05f9cc6af4a538f8f842154f32d6a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1d38c4e9b297eca2d562b2c4ff387c9ab6d543f2 Author: Owen Leonard Date: Mon Feb 10 15:07:52 2014 -0500 Bug 11739 - Use new DataTables include in notices template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Notices & Slips page. To test, view the Notices & Slips page (tools/letter.pl). Confirm that the table of notices is sorted correctly. Signed-off-by: merlissia Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 26696e3b299ff9ca96d7a834a172f6534ef952d5) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:36:05 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:36:05 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-32-g7d6daf4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 7d6daf4ceb6680fd9a86dba38d219511df250d7c (commit) from 1d38c4e9b297eca2d562b2c4ff387c9ab6d543f2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d6daf4ceb6680fd9a86dba38d219511df250d7c Author: Owen Leonard Date: Mon Feb 10 12:59:07 2014 -0500 Bug 11735 - Use new DataTables include in calendar template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the calendar template and corrects some table sorting configuration errors. To test you should have multiple calendar entries in various categories of holiday: Unique holidays, repeating yearly holidays, repeating weekly holidays, and exceptions. Sorting of date columns should work regardless of your dateformat system preference. Signed-off-by: merlissia Signed-off-by: Jonathan Druart Note: Day of week is not correctly sorted: Sundays, Mondays, Thursdays. But it is not a regression. It is caused by the ugly way to display weekdays (document.write). Signed-off-by: Galen Charlton (cherry picked from commit ef65eee25e2946adf20650d61781363f735058b6) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:41:17 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:41:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-33-gab85f0c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via ab85f0c5d03df5cbdeecac94cc9ae5e4b327a083 (commit) from 7d6daf4ceb6680fd9a86dba38d219511df250d7c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ab85f0c5d03df5cbdeecac94cc9ae5e4b327a083 Author: Galen Charlton Date: Fri Feb 14 00:24:56 2014 +0000 Bug 11757: remove dependency on POE The last use of the POE family of Perl modules went away with the removal of zebraqueue_daemon.pl per bug 9001. Consequently, this patch removes POE as a dependency. To test: [1] Verify that "git grep POE" and "git grep libpoe" report nothing. [2] Verify that koha_perl_deps.pl -a does not report POE as a dependency. [3] (extra credit) verify that Debian packages can be built that do not list libpoe-perl as a dependency. This patch also updates some distro-specific installation instructions and scripts, but makes no representations about whether those instructions currently work. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit b67dac81cceaab356486001292cff40977682fff) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 ----- INSTALL.fedora7 | 1 - INSTALL.opensuse | 1 - debian/control | 2 -- install_misc/debian.packages | 1 - install_misc/ubuntu.10.04.packages | 1 - install_misc/ubuntu.12.04.packages | 1 - install_misc/ubuntu.packages | 1 - 8 files changed, 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:43:44 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:43:44 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-34-gf7f9b41 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via f7f9b415a3f40475edf0373e7885ab873728bfbe (commit) from ab85f0c5d03df5cbdeecac94cc9ae5e4b327a083 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f7f9b415a3f40475edf0373e7885ab873728bfbe Author: Owen Leonard Date: Wed Feb 12 09:49:57 2014 -0500 Bug 11748 - Remove unused jquery.uitablefilter.js plugin This patch removes a jQuery plugin which was added for use with the old tablesorter plugin. Since the tablesorter plugin has been removed and replaced with DataTables this plugin can also be removed. To test, apply the patch and search for instances of the plugin: grep -r -l "jquery.uitablefilter.js" * There should be no results. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 42b71b87cc21ff69072116c7e42b02ad1f85932b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../en/lib/jquery/plugins/jquery.uitablefilter.js | 90 -------------------- 1 file changed, 90 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.uitablefilter.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:45:52 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:45:52 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-35-g46b69c5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 46b69c5a9f07df0ab5f42fd8260063e1763ccc82 (commit) from f7f9b415a3f40475edf0373e7885ab873728bfbe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46b69c5a9f07df0ab5f42fd8260063e1763ccc82 Author: Sophie Meynieux Date: Tue Jan 28 17:16:18 2014 +0100 Bug 11628: add missing staffaccess permission to French userflags.sql file Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart This permission exists in other installer files (for all other languages). Signed-off-by: Galen Charlton (cherry picked from commit 1b08f924513daadaff1258659e17d5caf0a53ea4) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/fr-FR/1-Obligatoire/userflags.sql | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:47:54 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:47:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-36-g656d2d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 656d2d070d92086bd2423c9200c536e62efa7296 (commit) from 46b69c5a9f07df0ab5f42fd8260063e1763ccc82 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 656d2d070d92086bd2423c9200c536e62efa7296 Author: Owen Leonard Date: Fri Feb 14 12:22:19 2014 -0500 Bug 11764 - Move repeatedly redefined function toUC() into staff-global.js toUC() is repeatedly declared on many administration templates. This function, used to transform user input to uppercase, can be added to staff-global.js to prevent repetition. To test, confirm that transformation to uppercase is working on the following Administration pages when text is entered in a form field and focus is moved to the next field: - Authority types -> New: Test the "Authority type" field. - MARC bibliographic framework -> New framework: Test the "Framework code" field. - Patron types and categories -> New category: Test the "Category code" field. - Currencies and exchange rates -> New currency: Test the "Currency" field. - Item types -> New item type: Test the "Item type" field. - Z39.50 client targets -> New Z39.50 server: Test the "Z39.50 server" field. The following pages do not call the toUC function despite the fact that they included it: auth_tag_structure.tt printers.tt roadtype.tt stopwords.tt systempreferences.tt Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart tools/letter.tt declares this js function and don't use it. Signed-off-by: Galen Charlton (cherry picked from commit 3c7edd1cbef811de89d6ee0b54cd690dd36d6ff4) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 6 ++++++ .../intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt | 6 ------ koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt | 6 ------ .../intranet-tmpl/prog/en/modules/admin/biblio_framework.tt | 4 ---- koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt | 6 ------ koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt | 5 ----- koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 6 ------ koha-tmpl/intranet-tmpl/prog/en/modules/admin/printers.tt | 6 ------ koha-tmpl/intranet-tmpl/prog/en/modules/admin/roadtype.tt | 6 ------ koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt | 5 ----- .../intranet-tmpl/prog/en/modules/admin/systempreferences.tt | 6 ------ koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt | 6 ------ 12 files changed, 6 insertions(+), 62 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:49:34 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:49:34 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-37-g330d25d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 330d25dd4c4ee13c1076e5736ed87319310e9556 (commit) from 656d2d070d92086bd2423c9200c536e62efa7296 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 330d25dd4c4ee13c1076e5736ed87319310e9556 Author: Owen Leonard Date: Fri Feb 14 12:52:34 2014 -0500 Bug 11765 - Remove unused function isDate from templates Several administration templates declare but do not use the JavaScript function isDate(). This patch removes the declarations. To test, apply the patch and search for instances of "isDate" in Koha templates, includes, and JavaScript files. There should be no results. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart I'm not sure this function has ever been used. This patch removes the toUC in tools/letter.tt too. Signed-off-by: Galen Charlton (cherry picked from commit 1aeb1d7e0b4c027b0277f5f5878a3b047abd4b82) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/auth_tag_structure.tt | 7 ------- .../intranet-tmpl/prog/en/modules/admin/categorie.tt | 7 ------- .../intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 7 ------- .../intranet-tmpl/prog/en/modules/admin/printers.tt | 7 ------- .../intranet-tmpl/prog/en/modules/admin/roadtype.tt | 7 ------- .../prog/en/modules/admin/systempreferences.tt | 7 ------- .../prog/en/modules/admin/z3950servers.tt | 7 ------- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 17 ++--------------- 8 files changed, 2 insertions(+), 64 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:53:16 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:53:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-38-g0e0b39d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 0e0b39deafed3376bc65af9bf9ee7ec678c60d35 (commit) from 330d25dd4c4ee13c1076e5736ed87319310e9556 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0e0b39deafed3376bc65af9bf9ee7ec678c60d35 Author: Marc V?ron Date: Sat Feb 15 17:07:55 2014 +0100 Bug 11773: fix crash in sco-main.pl if no active currency is set If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. This patch tests for active currency and simply does not display a currency symbol if appropriate. Test plan: 1) Make sure you have a patron with debts and no currency defined as active. (Home ? Administration ? Currencies & Exchange rates ? Currencies ) 2) Go to Self checkout module and try to checkout an item to this patron Result: Crash with error message "Can't use an undefined value as a HASH..." 3) Apply patch 4) Reload and try to checkout again Expected result: Message "You owe the library..." without currency symbol 5) Define a currency as active and try to checkout again Expected result: Message "You owe..." with currency symbol Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 1db56c834b297eb7fd968691f66ef3517771cba5) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: opac/sco/sco-main.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 15:56:48 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 13:56:48 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-39-gd3bdf5d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via d3bdf5de9fc1265def455878963253af93694d2e (commit) from 0e0b39deafed3376bc65af9bf9ee7ec678c60d35 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3bdf5de9fc1265def455878963253af93694d2e Author: Owen Leonard Date: Tue Feb 11 13:02:03 2014 -0500 Bug 11743 - Remove unused DataTables plugin from OPAC theme directories The Bootstrap and CCSR theme directories contain older copies of the DataTables plugin which is no longer in use. This patch removes them both. To test, apply the patch and confirm that DataTables still work on the following pages in both the Bootstrap and CCSR OPAC themes: - The Cart. Add items to the Cart, open it and confirm that the table is sorted correctly. - The detail page: View the detail page for a title (opac-detail.pl) with multiple items and confirm that the table of items is sorted correctly. - A subscription's "full history" page: Navigate to the detail page of a subscription in your catalog which has received multiple issues. From the subscriptions tab click the "More details" link, then the "Full history" link. Confirm that the table of issues is sorted correctly. - Search history: Enable the EnableOpacSearchHistory system preference. Perform a few searches so that your current session will record them. View the search history page and confirm that the tables of current and past searches are sorted correctly. - Suggestions (enable 'suggestion' system pref if necessary) - Tags (enable TagsEnabled if necessary) - Most popular (enable OpacTopissue if necessary) - User summary (opac-user.pl): Checkouts, overdues, and holds tables should all sort correctly. - Self checkout: Enable WebBasedSelfCheck if necessary. Check out as a patron who has multiple existing checkouts. Confirm that the table is sorted correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Existing uses of datatables.min.js don't point to the theme directory. Signed-off-by: Galen Charlton (cherry picked from commit d3c565f12c5c9136588a17e6497d860f6c5e95ed) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../lib/jquery/plugins/jquery.dataTables.min.js | 153 -------------------- .../en/lib/jquery/plugins/jquery.dataTables.min.js | 153 -------------------- 2 files changed, 306 deletions(-) delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.dataTables.min.js delete mode 100644 koha-tmpl/opac-tmpl/ccsr/en/lib/jquery/plugins/jquery.dataTables.min.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:01:49 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:01:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-42-gfe4cb67 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via fe4cb677742d6820a2f54aea02146186c3d5baae (commit) via b1e4073208ceb902e391820c650b7f89111a4ab8 (commit) via 3c6db9c780c01ef430117d5bf943826cd2b996f7 (commit) from d3bdf5de9fc1265def455878963253af93694d2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe4cb677742d6820a2f54aea02146186c3d5baae Author: Marcel de Rooy Date: Tue Feb 18 16:26:07 2014 +0100 Bug 10789: Follow-up: restored second SQL parameter in GetLastOrderReceivedFromSubscriptionid Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit e27ea08887a0332692c37b05b15021b14b1bef78) Signed-off-by: Fridolin Somers commit b1e4073208ceb902e391820c650b7f89111a4ab8 Author: Marcel de Rooy Date: Tue Feb 18 16:04:46 2014 +0100 Bug 10789: Follow-up: Fix typo "infermation" Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit 201af593f885ecb11c76d02baa6e27ef5e744e30) Signed-off-by: Fridolin Somers commit 3c6db9c780c01ef430117d5bf943826cd2b996f7 Author: Colin Campbell Date: Sun Dec 8 22:26:18 2013 +0000 Bug 10789: Remove unnecessary calls to $sth->finish in C4::Acquisitions C4::Acquisitions contained a number of unnecessary calls to $sth->finish. Removed these and the associated variables introduced to cache query results between fetch and the return Where finish was the end of the routine I have added an explicit return to document that no data is returned. A number of places made query calls and fetched a single row. Such a case could require an explicit finish. These assume that they are looking up with a unique key. To remove assumptions and isolate the code from future changes I've switched these to fetching all and returning the first row. I have commented these cases. For fuller explanation see perldoc DBI What I tested: Edit existing basket, chnged name Modify order line, change vendor price Create new basket and add order Delet this order Delte this basket New Basket, new order, user added, user removed Add contract to vendor, change details, delete contract Search order biblio Create basket group, add basket to group, remove basket from group Delete basket group Receive order Everything behaved as I expected Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit 2fac9a76450835337b015956a6f3150586aa5a17) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 139 ++++++++++++++++++++++------------------------------- 1 file changed, 58 insertions(+), 81 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:06:02 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:06:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-43-gacec28b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via acec28bc4c9319da4490eb940ef54d0875c97c48 (commit) from fe4cb677742d6820a2f54aea02146186c3d5baae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit acec28bc4c9319da4490eb940ef54d0875c97c48 Author: St?phane Delaune Date: Mon Feb 10 10:52:59 2014 +0100 Bug 11730: ensure that C4::Charset loads C4::Context C4::Charset::SetMarcUnicodeFlag() fetches system preference values, so since it invokes routines in C4::Context, it should load the module. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit b9d2a832db6d2a75d6466a349b769e8285d1f0c8) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Charset.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:08:20 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:08:20 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-44-gca66845 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via ca668451a71b178dbb37539c329af1de9726513e (commit) from acec28bc4c9319da4490eb940ef54d0875c97c48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ca668451a71b178dbb37539c329af1de9726513e Author: Owen Leonard Date: Fri Feb 14 08:48:46 2014 -0500 Bug 11756: improve default sorting on hold ratios report The DataTables plugin doesn't by default take multiple columns into account when sorting. The hold ratios report presents a situation where it makes sense to sort by default based on two columns: hold count and title, since there are likely to be many titles with the same hold count. This patch adds sorting by default on holds (descending) and title (ascending). It also modifies the configuration of the title sort to exclude articles when sorting. To test, view the hold ratios report. If necessary use the filter form to reduce the minimum hold ratio and generate more results. Confirm that the correct columns can be sorted. Note that by default one can manually trigger sorting on two columns by shift-clicking the second column header. Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton (cherry picked from commit 7514dc897cc49683915112229667ec1f654873ae) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/circ/reserveratios.tt | 12 ++++++++++++ 1 file changed, 12 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:15:32 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:15:32 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-45-gf6c7edb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via f6c7edbff198a8e3e821aaebcaaf3582d005106e (commit) from ca668451a71b178dbb37539c329af1de9726513e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f6c7edbff198a8e3e821aaebcaaf3582d005106e Author: Owen Leonard Date: Fri Feb 14 16:24:10 2014 -0500 Bug 11771 - Use validation plugin when creating new MARC framework tag The page for adding a new tag to a MARC framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. The patch also moves some tag markup creation out of the script and into the template where it belongs. To test, apply the patch and go to Administration -> MARC bibliographic framework -> MARC structure -> New tag. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing tag should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Great improvement! Before this patch, I got a JS alert but the form was submitted anyway. Signed-off-by: Galen Charlton (cherry picked from commit d90b4b6a08aa946fd40d1c1a45d1cc4ad64c30e5) ----------------------------------------------------------------------- Summary of changes: admin/marctagstructure.pl | 12 ++----- .../prog/en/modules/admin/marctagstructure.tt | 37 +++++++++----------- 2 files changed, 19 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:18:32 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:18:32 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-46-g881607f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 881607f8ff6688c5824acbd4e51c4f63e34aa564 (commit) from f6c7edbff198a8e3e821aaebcaaf3582d005106e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 881607f8ff6688c5824acbd4e51c4f63e34aa564 Author: Owen Leonard Date: Wed Feb 12 10:12:58 2014 -0500 Bug 11749 - Remove unused jQuery plugin jquery.hoverIntent.minified.js from the staff client The jQuery plugin jquery.hoverIntent.minified.js is used only in the OPAC, not the staff client. This patch removes it from the staff client. To test, apply the patch and search for instances of "hoverIntent." Only references in OPAC templates should be returned. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 6fd26558894869c0e80666007cab3b9edb090008) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/lib/jquery/plugins/jquery.hoverIntent.minified.js | 9 --------- 1 file changed, 9 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.hoverIntent.minified.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:21:49 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:21:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-47-gf0d2331 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via f0d2331759cc2a868e9ce114b6051081b0ce47a5 (commit) from 881607f8ff6688c5824acbd4e51c4f63e34aa564 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f0d2331759cc2a868e9ce114b6051081b0ce47a5 Author: Owen Leonard Date: Fri Feb 14 13:11:04 2014 -0500 Bug 11766 - Use validation plugin when creating new authority type The new authority type entry form uses custom form validation JavaScript. This patch removes it in favor of using HTML5 validation attributes and Koha's built-in validation plugin. To test, go to Administration -> Authority types and click "New authority type." Try submitting the form without entering any data. You should see a warning about required fields. Upon entering text in those fields the warning should disappear. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit ac9d872fefc867d4f068d425bcfcb929435809bd) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/authtypes.tt | 43 ++++---------------- 1 file changed, 7 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:25:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:25:01 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-48-g8fed0f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 8fed0f89d59cc8a7c32bcec6a3b8b8c7b8313c60 (commit) from f0d2331759cc2a868e9ce114b6051081b0ce47a5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8fed0f89d59cc8a7c32bcec6a3b8b8c7b8313c60 Author: Owen Leonard Date: Fri Feb 14 14:29:47 2014 -0500 Bug 11767 - Use validation plugin when creating new authority framework tag The page for adding a new tag to an authority framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. The patch also moves some tag markup out of the script and into the template where it belongs. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> New tag. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing tag should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 5ee8268a8df6ac193aa0500f4b801a3d359c1838) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: admin/auth_tag_structure.pl | 6 +- .../prog/en/modules/admin/auth_tag_structure.tt | 61 ++++++-------------- 2 files changed, 19 insertions(+), 48 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:27:16 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:27:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-49-gb9af176 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via b9af17600a903730c530dc83ebd7fb38c8b24d83 (commit) from 8fed0f89d59cc8a7c32bcec6a3b8b8c7b8313c60 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b9af17600a903730c530dc83ebd7fb38c8b24d83 Author: Owen Leonard Date: Mon Feb 10 15:29:06 2014 -0500 Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart No regression found. Signed-off-by: Galen Charlton (cherry picked from commit 7d05394ff2b27f7e08e41b908b445a33414edc0e) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:37:30 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:37:30 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-50-g8a59c43 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 8a59c43fc329d660239c2e23a2b4f84bd745610b (commit) from b9af17600a903730c530dc83ebd7fb38c8b24d83 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8a59c43fc329d660239c2e23a2b4f84bd745610b Author: Marc V?ron Date: Tue Feb 18 01:18:23 2014 +0100 Bug 11784 - fix displaying patron images in self checkout I suppose this bug was introduced with Bug 10636 (patronimage should have borrowernumber as PK, not cardnumber) To test: - Have a Patron with image. Configure everything to show image in SCO. - Go to SCO and log in patron - Image does not show up (broken link) - Apply patch - Test with prog, ccsr and bootstrap themes - Image should display Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 9d5fadb9831f03ab80489f9f18467a1796fc9447) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +- koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:41:11 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:41:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-52-g1b02c03 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1b02c031a34e7e3e3caabbe0184fb5fe71447d95 (commit) via f08154588cb07d8d85b25d13a566c2c689148577 (commit) from 8a59c43fc329d660239c2e23a2b4f84bd745610b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1b02c031a34e7e3e3caabbe0184fb5fe71447d95 Author: Galen Charlton Date: Wed Feb 19 16:40:06 2014 +0000 Bug 11779: (follow-up) improve GetLoggedInBranchcode() and add test cases This patch adjusts the new GetLoggedInBranchcode() template function so that it returns the empty string rather than undef if there is no active user environment. That way, there won't be lots of undefined value warnings if/when this function gets used in the OPAC. This patch also adds test cases. To test: [1] Verify that there are no regressions in the main test plan for this bug. [2] Verify that prove -v t/db_dependent/Koha_template_plugin_Branches.t passes. Signed-off-by: Galen Charlton (cherry picked from commit 065a3a5efa9b90723460a607ac85591c17945b00) Signed-off-by: Fridolin Somers commit f08154588cb07d8d85b25d13a566c2c689148577 Author: Kyle M Hall Date: Tue Feb 18 07:43:44 2014 -0500 Bug 11779: fix unexpected change in logged-in library when changing overdue notice triggers Steps to reproduce: 1) Log into staff intranet 2) Set logged in branch 3) Browse to tools/overdue notice triggers 4) Select a branch from the pulldown that is not your logged in branch 5) use the "Check out" bar at the top of the page to search for a patron to check out to 6) Once you have landed here, click the "check out" tab link again, or the Edit button ( any action really ) 7) Note your logged in branch has now changed to the once selected when editing the notice/status triggers This is due to the way the patron search passes the branchcode to be used via the form. This form assumes the branchcode variable is always the currently logged in branch, which may not and is not always the case. Test Plan: 1) Apply this patch 2) Repeat the steps to reproduce above 3) Note your logged in branch does not change Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Funny bug :) This patch fixes the described issue and should not introduce regression. Signed-off-by: Galen Charlton (cherry picked from commit 858083c8e907bde4efa6842cd45ff91bf1f6e24f) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/Template/Plugin/Branches.pm | 9 +++++++++ .../intranet-tmpl/prog/en/includes/patron-search-box.inc | 6 ++++-- t/db_dependent/Koha_template_plugin_Branches.t | 13 +++++++++++-- 3 files changed, 24 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:44:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:44:01 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-53-gb322f5f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via b322f5f13388fd7d64e9d2c3f8bd8c2cc1f60eeb (commit) from 1b02c031a34e7e3e3caabbe0184fb5fe71447d95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b322f5f13388fd7d64e9d2c3f8bd8c2cc1f60eeb Author: Kyle M Hall Date: Tue Feb 18 09:47:32 2014 -0500 Bug 11783: ensure CD field in SIP patron information response is populated If a patron has a record-level hold that is unavailable, any patron information request will send back an empty CD field when this field should have an item barcode in it [RM note: this actually isn't universally true -- the SIP2 standard is silent as to what is supposed to go in the CD field. Some SIP2 devices do indeed want an item barcode, but others are known to just want a display of the title and author of the request in question. Providing an option is the topic of a new enhancement request, however.] This is due to a minor error in ILS::Patron::_get_outstanding_holds where GetItemnumbersForBiblio is assumed to return an array but in reality returns an arrayref. Test Plan: 1) Create a record level hold for a patron and record 2) Using SIP2, make a patron information request 3) Note the empty CD fields 4) Apply this patch, restart SIP server 5) Repeat step 2 6) Note the CD field now has a barcode Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart I did not test this patch but the following code shows me it is correct: use C4::Items; use Data::Dumper; my $biblionumber = 5035; my $itemnumber = (GetItemnumbersForBiblio($biblionumber))[0]; say Dumper $itemnumber; $itemnumber = (GetItemnumbersForBiblio($biblionumber))->[0]; say Dumper $itemnumber; displays: $VAR1 = [ '23168', '23169', '23170', '23171', '23172' ]; $VAR1 = '23168'; Signed-off-by: Galen Charlton (cherry picked from commit 37a0e888199f1a1f8eefd38ad6ada786403fe034) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:46:35 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:46:35 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-55-gc0a0051 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via c0a00518e4ba03b00e6a8f1e4bf9b448f69a9d49 (commit) via 46cb2b9e630dec3be30f73cbf5f22f3baeb17c5e (commit) from b322f5f13388fd7d64e9d2c3f8bd8c2cc1f60eeb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0a00518e4ba03b00e6a8f1e4bf9b448f69a9d49 Author: Galen Charlton Date: Wed Feb 19 17:09:34 2014 +0000 Bug 11777: add regression test This patch adds a regression test for ensuring that the authorisedby field is returned by SearchOrders(). To test: [1] Upon applying the main patch, verify that prove -v t/db_dependent/Acquisition.t passes. Signed-off-by: Galen Charlton (cherry picked from commit a97f21ad3ba53ecd30089c7f802ab9b3ad430806) Signed-off-by: Fridolin Somers commit 46cb2b9e630dec3be30f73cbf5f22f3baeb17c5e Author: Amit Gupta Date: Tue Feb 18 14:57:44 2014 +0530 Bug 11777: ensure "created by" is displayed by the order receiving page This fixes a regression introduced by the patches for bug 10723. To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Click on Receive shipment button. 6) Click on receive link on the right hand side you will be able to see a staff user name in the "created by" field. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit ed6e2b57a1d47f413aa4f5f691e82b849daa8468) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 1 + t/db_dependent/Acquisition.t | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:50:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:50:01 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-57-g5415226 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 54152268aea7fdeb0a48b8c1ced00dde61bb9c59 (commit) via 984758cd3c76276366be05149324df6a17916cad (commit) from c0a00518e4ba03b00e6a8f1e4bf9b448f69a9d49 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 54152268aea7fdeb0a48b8c1ced00dde61bb9c59 Author: Galen Charlton Date: Wed Feb 19 20:04:22 2014 +0000 Bug 11644: (follow-up) add FIXME Arithmetic with monetary amounts is a *hard* problem -- or if not hard, at least super-fiddly, particularly since in theory a Koha database could have to deal with dozens of currencies if used by a large research library. This patch adds a FIXME implicitly commenting on the poor state of affairs of available monetary calculation modules on CPAN. Signed-off-by: Galen Charlton (cherry picked from commit 7efc10542be6d836c52cf598174e28f84a9d6470) Signed-off-by: Fridolin Somers commit 984758cd3c76276366be05149324df6a17916cad Author: Kyle M Hall Date: Thu Jan 30 12:39:19 2014 -0500 Bug 11644: fix occasional failure to update fund amount due to floating-point math When attempting to update a fund, if the amount unalloccated for the fund is equal to the total, you can be prevented from saving. This is due to imprecise floating point number comparison in check_parent_total.pl Test Plan: 1) Create a fund where the amount unallocated is equal to the amount unallocated for the budget period 2) Edit the fund, attempt to change the name of the fund 3) Note you recieve an error and cannot save 4) Apply this patch 5) Repeat step 2 6) Note you can now update the fund Signed-off-by: Sean McGarvey Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit ba689152e431217c8dd02d6ce0b8d14ae8d9f5da) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: admin/check_parent_total.pl | 8 ++++++++ 1 file changed, 8 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 16:54:28 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 14:54:28 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-61-g36988e2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 36988e28d3d642241e21efc3beabf9fab4604af1 (commit) via ff2930f843f247db889ded1c88995ed94adc6c24 (commit) via 8b3ccda27ec8df3244d81d22454f00a22e21fc58 (commit) via b2b1d1522e5f235f391565911c24e9a6a6699049 (commit) from 54152268aea7fdeb0a48b8c1ced00dde61bb9c59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36988e28d3d642241e21efc3beabf9fab4604af1 Author: Galen Charlton Date: Wed Feb 19 20:35:08 2014 +0000 Bug 10544: (follow-up) update MARC21 DOM index definitions This patch updates the MARC21 DOM index definitions to index the 952$i as 'Number-local-acquisition' rather than 'stocknumber'. To test (for a MARC21/DOM setup): [1] Copy the MARC21 biblio-zebra-indexdefs.xsl over to the active Zebra configuration directory. [2] Reindex the bib records. [3] Verify that 'stocknumber', 'inv', and 'number-local-acquisition' searches work. Signed-off-by: Galen Charlton (cherry picked from commit aaff735269bc2df1df030727ee85a12e7a28db11) Signed-off-by: Fridolin Somers commit ff2930f843f247db889ded1c88995ed94adc6c24 Author: Fridolyn SOMERS Date: Wed Jul 24 12:39:59 2013 +0200 Bug 10544 - add Number-local-acquisition in QueryParser config This patch adds the Number-local-acquisition into QueryParser configuration file. Like in ccl.properties, "Number-local-acquisition" is the main index name and "stocknumber" and "inv" are aliases. Test plan : Enable QueryParser : - Enable UseQueryParser syspref - Edit your koha-conf.xml - Add to "config" node : [your path]/etc/searchengine/queryparser.yaml, adapt [your patch] to your install configuration folder - If needed copy from sources "etc/searchengine/queryparser.yaml" into your install configuration folder Test search : - Add Number-local-acquisition on an existing subfield in records.abs. For example on item barcode field - Reindex Zebra database - Choose a value of this field that will match some results. For example : "0*" will match all barcodes beginning with zero - In intranet, enter this URL : /cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0*&sort_by=relevance => You get some results - In intranet, enter this URL : /cgi-bin/koha/catalogue/search.pl?idx=inv&q=0*&sort_by=relevance => You get the same results - In intranet, enter this URL : /cgi-bin/koha/catalogue/search.pl?idx=number-local-acquisition&q=0*&sort_by=relevance => You get the same results Signed-off-by: Marcel de Rooy Comments on case sensitivity of index names in QueryParser, see Bugzilla. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit f62e45dc92d0209e17c798a39f3425e9a2332586) Signed-off-by: Fridolin Somers commit 8b3ccda27ec8df3244d81d22454f00a22e21fc58 Author: Fridolyn SOMERS Date: Wed Jul 24 12:37:00 2013 +0200 Bug 10544: add Number-local-acquisition in known indexes Adding Number-local-acquisition in C4::Search known indexes allows to search without using "ccl=" prefix. Also corrects in ccl.properties : inv must be an alias of Number-local-acquisition. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit b0f39cee0de80568d78903b1926fa6eeefb6f16e) Signed-off-by: Fridolin Somers commit b2b1d1522e5f235f391565911c24e9a6a6699049 Author: Fridolyn SOMERS Date: Fri Jul 5 16:35:45 2013 +0200 Bug 10544: ensure that stocknumber searches work for MARC21 Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for number 1062. In this case, Number-local-acquisition must be used in record.abs and stocknumber can be an alias of it in ccl.properties. Test plan (for MARC21/GRS1): - drop zebra database (rebuild_zebra.pl -r ...) - reindex - test in simple search : ccl=Number-local-acquisition,alwaysmatches='' => you get all records with a stocknumber - test in simple search : ccl=stocknumber,alwaysmatches='' => you get the same results Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 10e1cbeb1421a6351ac0df4d0c76a8ae79d4dd9d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 1 + etc/searchengine/queryparser.yaml | 7 ++++--- etc/zebradb/ccl.properties | 5 +++-- etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml | 4 ++-- etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl | 2 +- etc/zebradb/marc_defs/marc21/biblios/record.abs | 2 +- 6 files changed, 12 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 17:01:21 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 15:01:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-39-g15e7849 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 15e78498ac14dc28b3adf73ffda7938d1d47f9cb (commit) from b77d69abbeb95bb55d7c93d2a132d89db22bf3e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 15e78498ac14dc28b3adf73ffda7938d1d47f9cb Author: Koha SAB CINECA Date: Wed May 14 12:39:42 2014 +0200 Bug 12240 - update of Italian SQL files (non-MARC setup) To test: - Apply this patch. - Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you prefer) - Install it-IT templates on command line - Run the webinstaller using it-IT - Follow the steps and choose all under 'necessari' => SUCCESS: no errors => Extra: see the italian installation and control the translation Signed-off-by: Bernardo Gonzalez Kriegel Tested doing it-IT install, all files selected, all load ok. No koha-qa errors Signed-off-by: Katrin Fischer Ran the Italian web installer, no errors. Checked some of the changed data, like the translated notices, in the interface. No problems found. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/it-IT/necessari/auth_val.sql | 21 ++++- .../data/mysql/it-IT/necessari/csv_profiles.sql | 2 + .../data/mysql/it-IT/necessari/csv_profiles.txt | 3 + installer/data/mysql/it-IT/necessari/notices.sql | 98 ++++++++++---------- .../mysql/it-IT/necessari/patron_categories.sql | 7 +- .../mysql/it-IT/necessari/sample_creator_data.sql | 45 +++++++++ .../mysql/it-IT/necessari/sample_creator_data.txt | 1 + .../mysql/it-IT/necessari/sample_frequencies.sql | 24 ++--- .../mysql/it-IT/necessari/sample_frequencies.txt | 2 +- .../it-IT/necessari/sample_numberpatterns.sql | 8 +- .../it-IT/necessari/sample_numberpatterns.txt | 2 +- .../data/mysql/it-IT/necessari/sample_quotes.sql | 7 ++ .../data/mysql/it-IT/necessari/sample_quotes.txt | 1 + installer/data/mysql/it-IT/necessari/userflags.sql | 4 +- .../data/mysql/it-IT/necessari/userpermissions.sql | 39 ++++---- 15 files changed, 165 insertions(+), 99 deletions(-) create mode 100644 installer/data/mysql/it-IT/necessari/csv_profiles.sql create mode 100644 installer/data/mysql/it-IT/necessari/csv_profiles.txt create mode 100644 installer/data/mysql/it-IT/necessari/sample_creator_data.sql create mode 100644 installer/data/mysql/it-IT/necessari/sample_creator_data.txt create mode 100644 installer/data/mysql/it-IT/necessari/sample_quotes.sql create mode 100644 installer/data/mysql/it-IT/necessari/sample_quotes.txt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 17:02:38 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 15:02:38 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-64-g91c7ea2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 91c7ea239f93c838f5f3b306ef2fee6255f1fef2 (commit) via 67a1293b7e6411ed664964173aa583ee0386d042 (commit) via f732638fcbde5fa7479c4d5d5cc29b2e59ea0e8e (commit) from 36988e28d3d642241e21efc3beabf9fab4604af1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 91c7ea239f93c838f5f3b306ef2fee6255f1fef2 Author: Galen Charlton Date: Wed Feb 19 21:00:32 2014 +0000 Bug 11202: (follow-up) update number of expected tests for t/QueryParser.t Signed-off-by: Galen Charlton (cherry picked from commit c9dd8b8bc3d07d1f4fc132759758f337e3d23196) Signed-off-by: Fridolin Somers commit 67a1293b7e6411ed664964173aa583ee0386d042 Author: Jonathan Druart Date: Mon Feb 3 13:17:17 2014 +0100 Bug 11202: FIX UT for QueryParser.t Test plan: prove t/QueryParser.t Signed-off-by: Galen Charlton (cherry picked from commit 0e92d21d0ed8683e2905812377e7f4dcf2a0a882) Signed-off-by: Fridolin Somers commit f732638fcbde5fa7479c4d5d5cc29b2e59ea0e8e Author: Mathieu Saby Date: Tue Nov 5 12:33:04 2013 +0100 Bug 11202: Improve UNIMARC biblio indexing This patch makes the following changes to UNIMARC biblio indexing : A. Changes to UNIMARC conf files 1. add comments to biblio-koha-indexdefs.xml 2. make biblio-koha-indexdefs.xml more compact by grouping some declarations Ex : 200$f and 200$g => one declaration for 200$fg 3. suppress unneeded declarations (indexing of some 4XX fields and 6XX fields not in unimarc format) 4. unindex some (sub)fields unneeded by most users (318, 207,230,210a, 215, 4XXd) 5. change the way 308 field is indexed (no visible changes) 6. replace Title-host with Host-item -- see bug 11119 7. index 208 in Material-Type -- see bug 11119 8. index 100 pos 8-9 and 9-12 in pubdate:y and pubdate:n 9. index 100 pos 8-9 in pubdate:s instead of 210$d 10. Index all subfields of note 334 and 327 in note index 11. Index 304 and 327 in title index as well as note index 327 can contain a list of titles included in a work 304 can contain the title of the original work in case of a translation 12. Index 314 in author index as well as note index 314 can contain authors not mentionned in 200$f/g (the 4th, 5th etc. author) 13. Index 328 note in Dissertation-information as well as note 14. Index 328$t in Title B. Changes to ccl.properties : 1. add a new index Dissertation-information (1056) 2. fix EAN, pubdate and acqdate (they were not linked with bib1 attributes) C. Changes to Search.pm 1. add Dissertation-information and suppress Title-host and UPC D. Changes to QP config file queryparser.yaml 1. add Dissertation-information 2 fix EAN, pubdate and acqdate Test plan : If you cannot test in GRS1, test only in DOM, as GRS will be deprecated. 1. Apply the patch in a UNIMARC Koha running with DOM and ICU 2. copy src/etc/searchengine/queryparser.yaml into the main config directory of QP 3. copy src/etc/zebradb/ccl.properties into the main config directory of Zebra 4. copy src/etc/zebradb/marc_defs/unimarc/biblio/* into the main config directory of Zebra 5. reindex biblios (rebuild_zebra.pl -r -b -x -v) 6. test note index : make some searches on 334$b or 327$b 7. test author index : make some searches on 314 field 8. test title index : make some searches on 304 and 327 field, make a search on 328$t subfield 9. test dissertation-information index : make some searches on 328 field 10. In a record, put in the dates of 100 fields the values "1000" (1st date) and "1001" (2d date) ; try to search a book written in year 1000, you should find the record ; idem for year 1001 11. make some searches and sort by date. It should work better as before, especially if you have values like "c2009" or "impr. 2010" in 210 field 12. Regression test : make some searches on several indexes, like EAN, etc. It should work as before Test 10-12 with and without Queryparser activated. Be careful: with Queryparser activated, the index names (title, dissertation-information...) must be entered in lowercase only. Of course, to test search and sort by dates, you need to have full records, with dates in 100 field as well as 210 field. Signed-off-by: Paola Rossi Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit b6118db2f595cec027dc9c809dcfb639ec4a320b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 3 +- etc/searchengine/queryparser.yaml | 15 +- etc/zebradb/ccl.properties | 22 +- .../unimarc/biblios/biblio-koha-indexdefs.xml | 878 +++++++------------- .../unimarc/biblios/biblio-zebra-indexdefs.xsl | 753 ++--------------- etc/zebradb/marc_defs/unimarc/biblios/record.abs | 130 ++- t/QueryParser.t | 10 +- 7 files changed, 480 insertions(+), 1331 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 17:04:35 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 15:04:35 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-65-gd937008 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via d93700833b0c816731e2675cc436979358c0081f (commit) from 91c7ea239f93c838f5f3b306ef2fee6255f1fef2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d93700833b0c816731e2675cc436979358c0081f Author: Marcel de Rooy Date: Mon Feb 10 13:28:16 2014 +0100 Bug 11732: Eliminate warning on undefined branchcode When you run the Reserves test, you have the warnings: Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 138. Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 148. This patch removes that warning. Test plan: Run the Reserves.t again. Revised Test Plan ----------------- Run the following on the command line prompt before and after applying the patch: perl -e "use C4::Letters; *C4::Context::userenv= sub { return {} }; my \$blah=C4::Letters::getletter('circulation','DUE', 'BRA');" Before the patch there will be errors (as above), after there will not. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart IndependentBranches must be on. Signed-off-by: Galen Charlton (cherry picked from commit 518870223669e8d4e3893401d18da0610ac1f6c7) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 17:18:08 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 15:18:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-41-ga18ce86 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a18ce86e83740a58e9c10a2f99354a8b84d9a8bd (commit) via 59c569ce92a72dc6d60a16e76fb8c4eebc741fcc (commit) from 15e78498ac14dc28b3adf73ffda7938d1d47f9cb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a18ce86e83740a58e9c10a2f99354a8b84d9a8bd Author: Kyle M Hall Date: Tue May 13 07:20:39 2014 -0400 Bug 12243: ensure that records with invalid ISBNs do not cause searches to fail Some types of invalid ISBNs, when run through C4::Koha::NormalizeISBN can produce ISBN objects that contain invalid ISBNs. This can be reproduced with an ISBN that has an invalid prefix, group code or publisher code. An example ISBN would be "0788893777 (2 DVD 45th ed)". When attempting to look up a record with such an ISBN, you will get an error along the lines of: Can't call method "as_string" on an undefined value Instead of checking for the BAD_ISBN state, we should be checking for the GOOD_ISBN state via the method is_valid. Test Plan: 1) Edit a record, add the following ISBN to your record: 0788893777 (2 DVD 45th ed) 2) When Koha redirects to the record, you should see the error message described 3) Apply this patch 4) Reload the page, you should now see your record Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 59c569ce92a72dc6d60a16e76fb8c4eebc741fcc Author: Galen Charlton Date: Mon May 19 15:37:34 2014 +0000 Bug 12243: add regression test This patch adds a regression test for C4::Koha::NormalizeISBN throwing an exception when trying to parse an invalid ISBN. To test: [1] Run prove -v t/Koha.t. The last test should fail. [2] Apply the main patch for this bug. [3] Run prove -v t/Koha.t again. This time, the test should pass. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 2 +- t/Koha.t | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 18:02:21 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 16:02:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-44-gbafeb88 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bafeb881c99142fd3abf507a3c5bcddd2c12932a (commit) via b97e691ef87bf3fd89f38ba0b1772d8fcac44b33 (commit) via 8bc2fb4df6e14a97c3aa7a62fbacc4bc7cf5772d (commit) from a18ce86e83740a58e9c10a2f99354a8b84d9a8bd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bafeb881c99142fd3abf507a3c5bcddd2c12932a Author: Galen Charlton Date: Mon May 19 16:25:53 2014 +0000 Bug 12271: (follow-up) fix minor errors in Bootstrap theme To test: [1] Verify that prove -v xt/author/valid-templates.t passes. Signed-off-by: Galen Charlton commit b97e691ef87bf3fd89f38ba0b1772d8fcac44b33 Author: Galen Charlton Date: Mon May 19 16:14:28 2014 +0000 Bug 12271: (follow-up) teach valid-templates.t how to include specified templates Two of the template includes in the Bootstrap theme cannot be tested all by themselves because they require that the template that includes them define BLOCKs. This patch ensures that they are excluded from individual testing; they will get exercised sufficiently by being including by all of the other Bootstrap templates. Signed-off-by: Galen Charlton commit 8bc2fb4df6e14a97c3aa7a62fbacc4bc7cf5772d Author: Fridolin Somers Date: Fri May 16 11:25:19 2014 +0200 Bug 12271: add Bootstrap templates to valid-templates.t tests valid-templates.t actually tests the templates and includes of only the "prog" theme at opac and intranet. It does not test the opac templates and includes of bootstrap theme, nor ccsr. This is critical since this test is used for patch integrations in release maintenance. This patch adds the test of bootstrap opac theme. I did not manage to add the ccsr theme since it is not a real theme, meaning it has no templates and not all includes. Test by runnning perl xt/author/valid-templates.t and looking at the logs. Signed-off-by: Bernardo Gonzalez Kriegel Now there are 902 lines, bootstrap tested (1 error detected!) No koha-qa errors Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../bootstrap/en/modules/opac-results-grouped.tt | 6 +-- .../bootstrap/en/modules/search/results.tt | 3 ++ xt/author/valid-templates.t | 47 +++++++++++++++++--- 3 files changed, 47 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 18:17:52 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 16:17:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-47-gbd3cab4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bd3cab4a9356c9ce5b1e659ff64536ce3d5ca462 (commit) via 4af38b9908d497a1699bc3abd3f597858692f7b1 (commit) via 5b898a09bb065c9c104b50fc3562d4310cda6819 (commit) from bafeb881c99142fd3abf507a3c5bcddd2c12932a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd3cab4a9356c9ce5b1e659ff64536ce3d5ca462 Author: Mark Tompsett Date: Wed May 14 23:51:20 2014 -0400 Bug 7841: quell warnings in C4::Languages This patch removes some sources of warning messages thrown by C4::Languages, particular getTranslatedLanguages() when running Koha's web installer. TEST PLAN --------- 1) Apply first patch 2) prove -v t/db_dependent/Languages.t -- There will be uninitialized string messages, etc. 3) Apply second patch (this one) 4) prove -v t/db_dependent/Languages.t -- Only one carp message will remain. Signed-off-by: Bernardo Gonzalez Kriegel Test pass, no warnings, no koha-qa errors Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 4af38b9908d497a1699bc3abd3f597858692f7b1 Author: Galen Charlton Date: Mon May 19 16:40:23 2014 +0000 Bug 7841: add a direct regression test This patch adds a direct regression test for verifying that no warnings are generated when getTranslatedLanguages() is called without a defined current language, as might happen during installation. Signed-off-by: Galen Charlton commit 5b898a09bb065c9c104b50fc3562d4310cda6819 Author: Mark Tompsett Date: Wed May 14 23:38:12 2014 -0400 Bug 7841: add unit tests to detect no functional changes to getTranslatedLanguages() When called with undef, floody messages appear in the error logs. Less floody messages appear when using 'en' as the language. This patch adds tests to verify that the behavior of getTranslatedLanguages() doesn't change when a subsequent patch updates it to not generate the warnings. TEST PLAN --------- 1) apply the patch 2) prove -v t/db_dependent/Languages.t -- All the tests should pass, including the last two which a) check that when undef is used no language is marked as current. b) check that when 'en' is used there is a language marked as current. Signed-off-by: Bernardo Gonzalez Kriegel Test pass, no koha-qa errors Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Languages.pm | 9 ++++++--- t/db_dependent/Languages.t | 21 ++++++++++++++++++++- 2 files changed, 26 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 18:22:33 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 16:22:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-48-gfb2345a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fb2345a3021116d94c74fb989cb65b156fbd646f (commit) from bd3cab4a9356c9ce5b1e659ff64536ce3d5ca462 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fb2345a3021116d94c74fb989cb65b156fbd646f Author: Marcel de Rooy Date: Wed May 7 14:21:33 2014 +0200 Bug 9612: (follow-up) restore elementSetName in Context.pm Restore elementSetName to marcxml for DOM indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: [1] Do not yet apply this patch. [2] Rebuild zebra index with the zebra config of commit 036f2a50e11dab97ef8509f2f585c4cc407ea728. [3] (Go back to master.) Restart your zebra server (no config change). You will have results without details. Apply this patch: you see details. Reset to master: no details again. [4] Install new zebra config from master. Search again: you still see no details. Restart zebra server. Search: you see details. Apply this patch. Search: still details. Restart zebra server. Search: still details. Signed-off-by: Marcel de Rooy Tested in a non-package environment (manual dev install). The package environment should work now too (results in step 4c might differ). Progress on bug 12012 would be appropriate to sync all changes. Tested the response of the SRU server too. Signed-off-by: Marc Veron I tested starting on a VM with Koha 3.15.00.019 installed. Did git pull -> Koha 3.15.00.051 Result: No details in search results. Applied patch. Result: Search results display fine. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 2 +- etc/zebradb/authorities/etc/dom-config-marc.xml | 1 - etc/zebradb/authorities/etc/dom-config.xml | 1 - etc/zebradb/biblios/etc/dom-config-marc.xml | 1 - etc/zebradb/biblios/etc/dom-config.xml | 1 - 5 files changed, 1 insertion(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 18:34:35 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 16:34:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-57-ga23c452 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a23c452b334c05249de4298ae971b2331a5b6ded (commit) via f0bc18951c7857885e1b12b445de039bf6d55d98 (commit) via a990de106d7e00d6af2c8cd8e71e16c1f6fb3756 (commit) via 16196fc62c81c95c2592b1b7939abd5f20417c34 (commit) via 5889f893cb88b710c1c39ff89b337686565f5d83 (commit) via c08e215a5544dd8429302ce042b794ff4677a7fb (commit) via ee1f77441ed445cf8c4588adcb01aac798ee5e59 (commit) via 1aaa9fe535e0d29d95722c01ac14af0fdf90e43e (commit) via d087cd933749567690a5b2d22240fe72ebec5794 (commit) from fb2345a3021116d94c74fb989cb65b156fbd646f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a23c452b334c05249de4298ae971b2331a5b6ded Author: Bernardo Gonzalez Kriegel Date: Tue May 13 19:47:02 2014 -0300 Bug 12244 - followup to fix tabs Only tab removing Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit f0bc18951c7857885e1b12b445de039bf6d55d98 Author: Nicole C. Engard Date: Tue May 13 08:48:52 2014 -0500 Bug 12244 - Update Acq Help for 3.16 This updates the basket help. To test: * Open a basket * Click help and confirm it's right and there Signed-off-by: Bernardo Gonzalez Kriegel Help ok Final comment: koha-qa complains about tabs, removed in followup Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit a990de106d7e00d6af2c8cd8e71e16c1f6fb3756 Author: Nicole C. Engard Date: Tue May 13 08:37:17 2014 -0500 Bug 12244 - Update Admin Help for 3.16 This patch updates 3 help files. To test: * Visit Administration > Patron Categories * Click help * Confirm it's there and right * Visit Administration > Currencies * Click help * Confirm it's there and right * Visit Administration > Circ Rules * Click help * Confirm it's there and right Signed-off-by: Bernardo Gonzalez Kriegel Help ok. One comment: on circ rules, I think that "you're" can be correct, but I prefer "you are" Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 16196fc62c81c95c2592b1b7939abd5f20417c34 Author: Nicole C. Engard Date: Tue May 13 08:27:17 2014 -0500 Bug 12244 - Update authorized values help for 3.16 This patch adds a few new values to the authorized values help To test: * Visit Administration > Authorized Values * Click help * Confirm help is there and correct Signed-off-by: Bernardo Gonzalez Kriegel New values ok Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 5889f893cb88b710c1c39ff89b337686565f5d83 Author: Nicole C. Engard Date: Tue May 13 08:19:56 2014 -0500 Bug 12244 - Update Notices Help Files Updates the 2 notices help files with new info. To test: * Visit Tools > Notices & Slips * Click help and confirm it's there and right * Visit Tools > Overdue notices/status triggers * Click help and confirm it's there and right Signed-off-by: Bernardo Gonzalez Kriegel Long help ok Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit c08e215a5544dd8429302ce042b794ff4677a7fb Author: Nicole C. Engard Date: Tue May 13 07:52:48 2014 -0500 Bug 12244 - Update Search Help for 3.16 This patch updates the search help file. To test: * Visit Search * Click help * Confirm help is there and correct Signed-off-by: Bernardo Gonzalez Kriegel Help ok Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit ee1f77441ed445cf8c4588adcb01aac798ee5e59 Author: Nicole C. Engard Date: Tue May 13 07:46:29 2014 -0500 Bug 12244 - Update cataloging help for 3.16 This patch adds a bit to the addbiblio help file. To test: * Go to Cataloging * Click add new * Click help * Confirm help is there and correct Signed-off-by: Bernardo Gonzalez Kriegel Help is ok Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 1aaa9fe535e0d29d95722c01ac14af0fdf90e43e Author: Nicole C. Engard Date: Tue May 13 07:38:18 2014 -0500 Bug 12244 - Update Patron help files for 3.16 This updates the patron help file and adds a missing help file. To test: * Go to a patron record * Click help and confirm text is correct * Go to patron's purchase suggestions * Click help and confirm that help file is there and correct Signed-off-by: Bernardo Gonzalez Kriegel Both text are correct, link still points to 3.14 manual, but depends on a value that must change with new release. Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit d087cd933749567690a5b2d22240fe72ebec5794 Author: Nicole C. Engard Date: Tue May 13 07:24:17 2014 -0500 Bug 12244 - Koha 3.16 Circ Help Updates This patch updates the check in help (the only change for 3.16). To test: * Visit Circulation > Check in * Click Help * Confirm that help text is right Signed-off-by: Bernardo Gonzalez Kriegel Help is right Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/help/acqui/basket.tt | 25 +- .../en/modules/help/admin/authorised_values.tt | 2 + .../prog/en/modules/help/admin/categorie.tt | 55 ++--- .../prog/en/modules/help/admin/currency.tt | 2 + .../prog/en/modules/help/admin/smart-rules.tt | 3 + .../prog/en/modules/help/catalogue/search.tt | 8 +- .../prog/en/modules/help/cataloguing/addbiblio.tt | 31 +-- .../prog/en/modules/help/circ/returns.tt | 2 + .../prog/en/modules/help/members/moremember.tt | 14 ++ .../modules/help/members/purchase-suggestions.tt | 13 ++ .../prog/en/modules/help/tools/letter.tt | 240 ++++++++++++++++---- .../prog/en/modules/help/tools/overduerules.tt | 14 +- 12 files changed, 297 insertions(+), 112 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/help/members/purchase-suggestions.tt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 20:29:52 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 18:29:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-58-gceb0177 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ceb017765fc3430f188b5cbdd71d994c15359508 (commit) from a23c452b334c05249de4298ae971b2331a5b6ded (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ceb017765fc3430f188b5cbdd71d994c15359508 Author: Bernardo Gonzalez Kriegel Date: Mon May 19 15:40:50 2014 -0300 Translation update for 3.16.00 release New languages: Belarusian be-BY Faroese fo-FO Rwandan rw-RW Swahili sw-KE Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../po/am-Ethi-i-opac-t-prog-v-3006000.po | 7617 +- .../po/am-Ethi-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/am-Ethi-opac-bootstrap.po | 8482 +- misc/translator/po/am-Ethi-opac-ccsr.po | 344 +- misc/translator/po/am-Ethi-pref.po |54418 +++++++- misc/translator/po/am-Ethi-staff-help.po | 848 +- .../po/ar-Arab-i-opac-t-prog-v-3006000.po | 7876 +- .../po/ar-Arab-i-staff-t-prog-v-3006000.po |37628 ++---- misc/translator/po/ar-Arab-opac-bootstrap.po | 8574 +- misc/translator/po/ar-Arab-opac-ccsr.po | 367 +- misc/translator/po/ar-Arab-pref.po |64364 ++++++++- misc/translator/po/ar-Arab-staff-help.po | 3494 +- .../translator/po/az-AZ-i-opac-t-prog-v-3006000.po | 7624 +- .../po/az-AZ-i-staff-t-prog-v-3006000.po |135854 ++++++++----------- misc/translator/po/az-AZ-opac-bootstrap.po | 8492 +- misc/translator/po/az-AZ-opac-ccsr.po | 344 +- misc/translator/po/az-AZ-pref.po |72026 +++++++++- misc/translator/po/az-AZ-staff-help.po |12431 +- ...3006000.po => be-BY-i-opac-t-prog-v-3006000.po} | 8425 +- ...006000.po => be-BY-i-staff-t-prog-v-3006000.po} |138598 ++++++++----------- ...U-opac-bootstrap.po => be-BY-opac-bootstrap.po} | 8550 +- .../po/{ru-RU-opac-ccsr.po => be-BY-opac-ccsr.po} | 401 +- misc/translator/po/be-BY-pref.po |20026 +++ .../{nn-NO-staff-help.po => be-BY-staff-help.po} |18337 +-- misc/translator/po/ben-i-opac-t-prog-v-3006000.po | 7801 +- misc/translator/po/ben-i-staff-t-prog-v-3006000.po |36581 ++--- misc/translator/po/ben-opac-bootstrap.po | 8471 +- misc/translator/po/ben-opac-ccsr.po | 352 +- misc/translator/po/ben-pref.po |60298 ++++++++- misc/translator/po/ben-staff-help.po | 896 +- .../po/bg-Cyrl-i-opac-t-prog-v-3006000.po | 7756 +- .../po/bg-Cyrl-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 8461 +- misc/translator/po/bg-Cyrl-opac-ccsr.po | 344 +- misc/translator/po/bg-Cyrl-pref.po |39878 +++++- misc/translator/po/bg-Cyrl-staff-help.po | 848 +- .../translator/po/ca-ES-i-opac-t-prog-v-3006000.po | 8516 +- .../po/ca-ES-i-staff-t-prog-v-3006000.po |125495 ++++++++---------- misc/translator/po/ca-ES-opac-bootstrap.po |10059 +- misc/translator/po/ca-ES-opac-ccsr.po | 393 +- misc/translator/po/ca-ES-pref.po |42010 +++++- misc/translator/po/ca-ES-staff-help.po | 9316 +- .../translator/po/cs-CZ-i-opac-t-prog-v-3006000.po | 7736 +- .../po/cs-CZ-i-staff-t-prog-v-3006000.po |37233 ++---- misc/translator/po/cs-CZ-opac-bootstrap.po | 8543 +- misc/translator/po/cs-CZ-opac-ccsr.po | 371 +- misc/translator/po/cs-CZ-pref.po |89696 ++++++++++++- misc/translator/po/cs-CZ-staff-help.po | 970 +- .../translator/po/da-DK-i-opac-t-prog-v-3006000.po | 7764 +- .../po/da-DK-i-staff-t-prog-v-3006000.po |37056 ++---- misc/translator/po/da-DK-opac-bootstrap.po | 8721 +- misc/translator/po/da-DK-opac-ccsr.po | 376 +- misc/translator/po/da-DK-pref.po |34584 ++++- misc/translator/po/da-DK-staff-help.po | 1958 +- .../translator/po/de-CH-i-opac-t-prog-v-3006000.po |10016 +- .../po/de-CH-i-staff-t-prog-v-3006000.po |44884 ++----- misc/translator/po/de-CH-opac-bootstrap.po |11081 +- misc/translator/po/de-CH-opac-ccsr.po | 372 +- misc/translator/po/de-CH-pref.po |53750 +++++++- misc/translator/po/de-CH-staff-help.po | 1134 +- .../translator/po/de-DE-i-opac-t-prog-v-3006000.po | 7788 +- .../po/de-DE-i-staff-t-prog-v-3006000.po |37439 ++---- misc/translator/po/de-DE-opac-bootstrap.po | 8555 +- misc/translator/po/de-DE-opac-ccsr.po | 372 +- misc/translator/po/de-DE-pref.po |52093 +++++++- misc/translator/po/de-DE-staff-help.po | 1095 +- .../translator/po/el-GR-i-opac-t-prog-v-3006000.po | 8797 +- .../po/el-GR-i-staff-t-prog-v-3006000.po |135112 ++++++++----------- misc/translator/po/el-GR-opac-bootstrap.po | 8518 +- misc/translator/po/el-GR-opac-ccsr.po | 428 +- misc/translator/po/el-GR-pref.po | 380 +- misc/translator/po/el-GR-staff-help.po | 7154 +- .../translator/po/en-GB-i-opac-t-prog-v-3006000.po | 7659 +- .../po/en-GB-i-staff-t-prog-v-3006000.po |136854 ++++++++----------- misc/translator/po/en-GB-opac-bootstrap.po | 8498 +- misc/translator/po/en-GB-opac-ccsr.po | 355 +- misc/translator/po/en-GB-pref.po |92744 ++++++++++++- misc/translator/po/en-GB-staff-help.po |10907 +- .../translator/po/en-NZ-i-opac-t-prog-v-3006000.po | 7671 +- .../po/en-NZ-i-staff-t-prog-v-3006000.po |37274 ++---- misc/translator/po/en-NZ-opac-bootstrap.po | 8495 +- misc/translator/po/en-NZ-opac-ccsr.po | 362 +- misc/translator/po/en-NZ-pref.po | 286 +- misc/translator/po/en-NZ-staff-help.po | 3112 +- .../translator/po/es-ES-i-opac-t-prog-v-3006000.po | 7799 +- .../po/es-ES-i-staff-t-prog-v-3006000.po |37739 ++---- misc/translator/po/es-ES-opac-bootstrap.po | 8663 +- misc/translator/po/es-ES-opac-ccsr.po | 376 +- misc/translator/po/es-ES-pref.po | 401 +- misc/translator/po/es-ES-staff-help.po | 1107 +- misc/translator/po/eu-i-opac-t-prog-v-3006000.po | 7667 +- misc/translator/po/eu-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/eu-opac-bootstrap.po | 8519 +- misc/translator/po/eu-opac-ccsr.po | 356 +- misc/translator/po/eu-pref.po |93470 ++++++++++++- misc/translator/po/eu-staff-help.po | 848 +- .../po/fa-Arab-i-opac-t-prog-v-3006000.po | 7747 +- .../po/fa-Arab-i-staff-t-prog-v-3006000.po |121930 +++++++---------- misc/translator/po/fa-Arab-opac-bootstrap.po | 8460 +- misc/translator/po/fa-Arab-opac-ccsr.po | 344 +- misc/translator/po/fa-Arab-pref.po |98384 +++++++++++++- misc/translator/po/fa-Arab-staff-help.po | 8527 +- .../translator/po/fi-FI-i-opac-t-prog-v-3006000.po | 8255 +- .../po/fi-FI-i-staff-t-prog-v-3006000.po |127279 ++++++++---------- misc/translator/po/fi-FI-opac-bootstrap.po |25051 ++-- misc/translator/po/fi-FI-opac-ccsr.po | 376 +- misc/translator/po/fi-FI-pref.po | 488 +- misc/translator/po/fi-FI-staff-help.po | 3641 +- ...3006000.po => fo-FO-i-opac-t-prog-v-3006000.po} | 8286 +- ...006000.po => fo-FO-i-staff-t-prog-v-3006000.po} |37549 ++---- ...K-opac-bootstrap.po => fo-FO-opac-bootstrap.po} | 8572 +- misc/translator/po/fo-FO-opac-ccsr.po | 560 + misc/translator/po/fo-FO-pref.po |26696 ++++ .../po/{eu-staff-help.po => fo-FO-staff-help.po} | 878 +- .../translator/po/fr-CA-i-opac-t-prog-v-3006000.po | 7713 +- .../po/fr-CA-i-staff-t-prog-v-3006000.po |37227 ++---- misc/translator/po/fr-CA-opac-bootstrap.po | 8516 +- misc/translator/po/fr-CA-opac-ccsr.po | 364 +- misc/translator/po/fr-CA-pref.po |24836 +++- misc/translator/po/fr-CA-staff-help.po | 2237 +- .../translator/po/fr-FR-i-opac-t-prog-v-3006000.po | 7753 +- .../po/fr-FR-i-staff-t-prog-v-3006000.po |37356 ++---- misc/translator/po/fr-FR-opac-bootstrap.po | 8559 +- misc/translator/po/fr-FR-opac-ccsr.po | 376 +- misc/translator/po/fr-FR-pref.po | 3152 +- misc/translator/po/fr-FR-staff-help.po | 915 +- misc/translator/po/gl-i-opac-t-prog-v-3006000.po | 8268 +- misc/translator/po/gl-i-staff-t-prog-v-3006000.po |37209 ++---- misc/translator/po/gl-opac-bootstrap.po | 8445 +- misc/translator/po/gl-opac-ccsr.po | 594 +- misc/translator/po/gl-pref.po |16252 ++- misc/translator/po/gl-staff-help.po | 7395 +- .../po/he-Hebr-i-opac-t-prog-v-3006000.po | 7731 +- .../po/he-Hebr-i-staff-t-prog-v-3006000.po |37158 ++---- misc/translator/po/he-Hebr-opac-bootstrap.po | 8456 +- misc/translator/po/he-Hebr-opac-ccsr.po | 344 +- misc/translator/po/he-Hebr-pref.po |70124 +++++++++- misc/translator/po/he-Hebr-staff-help.po | 6397 +- misc/translator/po/hi-i-opac-t-prog-v-3006000.po | 7628 +- misc/translator/po/hi-i-staff-t-prog-v-3006000.po |136296 ++++++++----------- misc/translator/po/hi-opac-bootstrap.po | 8468 +- misc/translator/po/hi-opac-ccsr.po | 344 +- misc/translator/po/hi-pref.po |40706 +++++- misc/translator/po/hi-staff-help.po |12610 +- .../translator/po/hr-HR-i-opac-t-prog-v-3006000.po | 8103 +- .../po/hr-HR-i-staff-t-prog-v-3006000.po |37427 ++---- misc/translator/po/hr-HR-opac-bootstrap.po | 8651 +- misc/translator/po/hr-HR-opac-ccsr.po | 376 +- misc/translator/po/hr-HR-pref.po |24362 +++- misc/translator/po/hr-HR-staff-help.po | 2281 +- .../translator/po/hu-HU-i-opac-t-prog-v-3006000.po | 7984 +- .../po/hu-HU-i-staff-t-prog-v-3006000.po |127259 ++++++++---------- misc/translator/po/hu-HU-opac-bootstrap.po | 8504 +- misc/translator/po/hu-HU-opac-ccsr.po | 458 +- misc/translator/po/hu-HU-pref.po |81370 +++++++++++- misc/translator/po/hu-HU-staff-help.po |10769 +- .../po/hy-Armn-i-opac-t-prog-v-3006000.po | 7721 +- .../po/hy-Armn-i-staff-t-prog-v-3006000.po |38996 ++---- misc/translator/po/hy-Armn-opac-bootstrap.po | 9504 +- misc/translator/po/hy-Armn-opac-ccsr.po | 375 +- misc/translator/po/hy-Armn-pref.po |85430 +++++++++++- misc/translator/po/hy-Armn-staff-help.po | 1834 +- .../translator/po/id-ID-i-opac-t-prog-v-3006000.po | 9404 +- .../po/id-ID-i-staff-t-prog-v-3006000.po |37501 ++---- misc/translator/po/id-ID-opac-bootstrap.po | 8525 +- misc/translator/po/id-ID-opac-ccsr.po | 344 +- misc/translator/po/id-ID-pref.po |96700 +++++++++++++- misc/translator/po/id-ID-staff-help.po | 1449 +- .../translator/po/is-IS-i-opac-t-prog-v-3006000.po | 7639 +- .../po/is-IS-i-staff-t-prog-v-3006000.po |125217 ++++++++---------- misc/translator/po/is-IS-opac-bootstrap.po | 8477 +- misc/translator/po/is-IS-opac-ccsr.po | 348 +- misc/translator/po/is-IS-pref.po |65166 ++++++++- misc/translator/po/is-IS-staff-help.po | 9937 +- .../translator/po/it-IT-i-opac-t-prog-v-3006000.po | 7748 +- .../po/it-IT-i-staff-t-prog-v-3006000.po |46309 ++----- misc/translator/po/it-IT-opac-bootstrap.po |12157 +- misc/translator/po/it-IT-opac-ccsr.po | 364 +- misc/translator/po/it-IT-pref.po |60538 ++++++++- misc/translator/po/it-IT-staff-help.po | 2195 +- .../po/ja-Jpan-JP-i-opac-t-prog-v-3006000.po | 8000 +- .../po/ja-Jpan-JP-i-staff-t-prog-v-3006000.po |124653 ++++++++---------- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 8733 +- misc/translator/po/ja-Jpan-JP-opac-ccsr.po | 354 +- misc/translator/po/ja-Jpan-JP-pref.po |55602 +++++++- misc/translator/po/ja-Jpan-JP-staff-help.po | 9769 +- .../po/kn-Knda-i-opac-t-prog-v-3006000.po | 7611 +- .../po/kn-Knda-i-staff-t-prog-v-3006000.po |37048 ++---- misc/translator/po/kn-Knda-opac-bootstrap.po | 8469 +- misc/translator/po/kn-Knda-opac-ccsr.po | 344 +- misc/translator/po/kn-Knda-pref.po |75360 ++++++++++- misc/translator/po/kn-Knda-staff-help.po | 4665 +- .../po/ko-Kore-KP-i-opac-t-prog-v-3006000.po | 7746 +- .../po/ko-Kore-KP-i-staff-t-prog-v-3006000.po |37292 ++---- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 8441 +- misc/translator/po/ko-Kore-KP-opac-ccsr.po | 344 +- misc/translator/po/ko-Kore-KP-pref.po |36688 +++++- misc/translator/po/ko-Kore-KP-staff-help.po | 8349 +- misc/translator/po/ku-i-opac-t-prog-v-3006000.po | 7705 +- misc/translator/po/ku-i-staff-t-prog-v-3006000.po |132702 ++++++++----------- misc/translator/po/ku-opac-bootstrap.po | 8533 +- misc/translator/po/ku-opac-ccsr.po | 359 +- misc/translator/po/ku-pref.po |67018 +++++++++- misc/translator/po/ku-staff-help.po | 4384 +- .../po/lo-Laoo-i-opac-t-prog-v-3006000.po | 7675 +- .../po/lo-Laoo-i-staff-t-prog-v-3006000.po |37064 ++---- misc/translator/po/lo-Laoo-opac-bootstrap.po | 8504 +- misc/translator/po/lo-Laoo-opac-ccsr.po | 356 +- misc/translator/po/lo-Laoo-pref.po |82656 +++++++++++- misc/translator/po/lo-Laoo-staff-help.po | 3349 +- .../translator/po/mi-NZ-i-opac-t-prog-v-3006000.po | 7618 +- .../po/mi-NZ-i-staff-t-prog-v-3006000.po |71908 ++++------ misc/translator/po/mi-NZ-opac-bootstrap.po | 8486 +- misc/translator/po/mi-NZ-opac-ccsr.po | 347 +- misc/translator/po/mi-NZ-pref.po |28712 +++- misc/translator/po/mi-NZ-staff-help.po | 9675 +- misc/translator/po/mon-i-opac-t-prog-v-3006000.po | 7622 +- misc/translator/po/mon-i-staff-t-prog-v-3006000.po |134557 ++++++++----------- misc/translator/po/mon-opac-bootstrap.po | 8488 +- misc/translator/po/mon-opac-ccsr.po | 347 +- misc/translator/po/mon-pref.po |86682 +++++++++++- misc/translator/po/mon-staff-help.po |13466 +- misc/translator/po/mr-i-opac-t-prog-v-3006000.po | 7670 +- misc/translator/po/mr-i-staff-t-prog-v-3006000.po |37050 ++---- misc/translator/po/mr-opac-bootstrap.po | 8473 +- misc/translator/po/mr-opac-ccsr.po | 344 +- misc/translator/po/mr-pref.po |67920 +++++++++- misc/translator/po/mr-staff-help.po | 3145 +- .../translator/po/ms-MY-i-opac-t-prog-v-3006000.po | 7674 +- .../po/ms-MY-i-staff-t-prog-v-3006000.po |36998 ++---- misc/translator/po/ms-MY-opac-bootstrap.po | 8510 +- misc/translator/po/ms-MY-opac-ccsr.po | 348 +- misc/translator/po/ms-MY-pref.po | 1592 +- misc/translator/po/ms-MY-staff-help.po | 1572 +- .../translator/po/nb-NO-i-opac-t-prog-v-3006000.po |10295 +- .../po/nb-NO-i-staff-t-prog-v-3006000.po |133017 ++++++++----------- misc/translator/po/nb-NO-opac-bootstrap.po |12001 +- misc/translator/po/nb-NO-opac-ccsr.po | 367 +- misc/translator/po/nb-NO-pref.po | 3208 +- misc/translator/po/nb-NO-staff-help.po | 2778 +- .../translator/po/ne-NE-i-opac-t-prog-v-3006000.po | 7613 +- .../po/ne-NE-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/ne-NE-opac-bootstrap.po | 8433 +- misc/translator/po/ne-NE-opac-ccsr.po | 344 +- misc/translator/po/ne-NE-pref.po |26866 +++- misc/translator/po/ne-NE-staff-help.po | 848 +- .../translator/po/nl-BE-i-opac-t-prog-v-3006000.po | 8218 +- .../po/nl-BE-i-staff-t-prog-v-3006000.po |120127 +++++++---------- misc/translator/po/nl-BE-opac-bootstrap.po | 9422 +- misc/translator/po/nl-BE-opac-ccsr.po | 374 +- misc/translator/po/nl-BE-pref.po |46717 ++++++- misc/translator/po/nl-BE-staff-help.po | 4313 +- .../translator/po/nl-NL-i-opac-t-prog-v-3006000.po | 7709 +- .../po/nl-NL-i-staff-t-prog-v-3006000.po |36618 ++---- misc/translator/po/nl-NL-opac-bootstrap.po |10366 +- misc/translator/po/nl-NL-opac-ccsr.po | 347 +- misc/translator/po/nl-NL-pref.po |66476 +++++++++- misc/translator/po/nl-NL-staff-help.po | 917 +- .../translator/po/nn-NO-i-opac-t-prog-v-3006000.po | 7761 +- .../po/nn-NO-i-staff-t-prog-v-3006000.po |134164 ++++++++----------- misc/translator/po/nn-NO-opac-bootstrap.po | 8480 +- misc/translator/po/nn-NO-opac-ccsr.po | 344 +- misc/translator/po/nn-NO-pref.po |52132 +++++++- misc/translator/po/nn-NO-staff-help.po |14555 +- misc/translator/po/pbr-i-opac-t-prog-v-3006000.po | 7584 +- misc/translator/po/pbr-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/pbr-opac-bootstrap.po | 8449 +- misc/translator/po/pbr-opac-ccsr.po | 344 +- misc/translator/po/pbr-pref.po | 5622 +- misc/translator/po/pbr-staff-help.po | 848 +- .../translator/po/pl-PL-i-opac-t-prog-v-3006000.po | 7969 +- .../po/pl-PL-i-staff-t-prog-v-3006000.po |37154 ++---- misc/translator/po/pl-PL-opac-bootstrap.po | 8812 +- misc/translator/po/pl-PL-opac-ccsr.po | 383 +- misc/translator/po/pl-PL-pref.po |31804 ++++- misc/translator/po/pl-PL-staff-help.po | 1905 +- misc/translator/po/prs-i-opac-t-prog-v-3006000.po | 7722 +- misc/translator/po/prs-i-staff-t-prog-v-3006000.po |37029 ++---- misc/translator/po/prs-opac-bootstrap.po | 8449 +- misc/translator/po/prs-opac-ccsr.po | 344 +- misc/translator/po/prs-pref.po |38118 +++++- misc/translator/po/prs-staff-help.po | 3989 +- .../translator/po/pt-BR-i-opac-t-prog-v-3006000.po | 8005 +- .../po/pt-BR-i-staff-t-prog-v-3006000.po |38532 ++---- misc/translator/po/pt-BR-opac-bootstrap.po | 9489 +- misc/translator/po/pt-BR-opac-ccsr.po | 377 +- misc/translator/po/pt-BR-pref.po | 8474 +- misc/translator/po/pt-BR-staff-help.po | 3345 +- .../translator/po/pt-PT-i-opac-t-prog-v-3006000.po | 8006 +- .../po/pt-PT-i-staff-t-prog-v-3006000.po |39101 ++---- misc/translator/po/pt-PT-opac-bootstrap.po | 9576 +- misc/translator/po/pt-PT-opac-ccsr.po | 374 +- misc/translator/po/pt-PT-pref.po | 7310 +- misc/translator/po/pt-PT-staff-help.po | 2235 +- .../translator/po/ro-RO-i-opac-t-prog-v-3006000.po | 7718 +- .../po/ro-RO-i-staff-t-prog-v-3006000.po |128875 ++++++++---------- misc/translator/po/ro-RO-opac-bootstrap.po | 8477 +- misc/translator/po/ro-RO-opac-ccsr.po | 351 +- misc/translator/po/ro-RO-pref.po |58766 ++++++++- misc/translator/po/ro-RO-staff-help.po | 9357 +- .../translator/po/ru-RU-i-opac-t-prog-v-3006000.po | 8331 +- .../po/ru-RU-i-staff-t-prog-v-3006000.po |137924 ++++++++----------- misc/translator/po/ru-RU-opac-bootstrap.po | 8528 +- misc/translator/po/ru-RU-opac-ccsr.po | 391 +- misc/translator/po/ru-RU-pref.po |10000 +- misc/translator/po/ru-RU-staff-help.po | 9711 +- ...3006000.po => rw-RW-i-opac-t-prog-v-3006000.po} | 7799 +- ...006000.po => rw-RW-i-staff-t-prog-v-3006000.po} |36561 ++--- ...K-opac-bootstrap.po => rw-RW-opac-bootstrap.po} | 8431 +- misc/translator/po/rw-RW-opac-ccsr.po | 552 + misc/translator/po/rw-RW-pref.po |33361 +++++ .../po/{eu-staff-help.po => rw-RW-staff-help.po} | 848 +- .../translator/po/sd-PK-i-opac-t-prog-v-3006000.po | 7737 +- .../po/sd-PK-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/sd-PK-opac-bootstrap.po | 8454 +- misc/translator/po/sd-PK-opac-ccsr.po | 347 +- misc/translator/po/sd-PK-pref.po |96094 +++++++++++++- misc/translator/po/sd-PK-staff-help.po | 848 +- .../translator/po/sk-SK-i-opac-t-prog-v-3006000.po | 8207 +- .../po/sk-SK-i-staff-t-prog-v-3006000.po |37241 ++---- misc/translator/po/sk-SK-opac-bootstrap.po | 8605 +- misc/translator/po/sk-SK-opac-ccsr.po | 368 +- misc/translator/po/sk-SK-pref.po |49510 ++++++- misc/translator/po/sk-SK-staff-help.po | 963 +- .../translator/po/sl-SI-i-opac-t-prog-v-3006000.po | 7738 +- .../po/sl-SI-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/sl-SI-opac-bootstrap.po | 8423 +- misc/translator/po/sl-SI-opac-ccsr.po | 347 +- misc/translator/po/sl-SI-pref.po |47394 ++++++- misc/translator/po/sl-SI-staff-help.po | 848 +- .../translator/po/sq-AL-i-opac-t-prog-v-3006000.po |11112 +- .../po/sq-AL-i-staff-t-prog-v-3006000.po |37415 ++---- misc/translator/po/sq-AL-opac-bootstrap.po | 8455 +- misc/translator/po/sq-AL-opac-ccsr.po | 344 +- misc/translator/po/sq-AL-pref.po |62095 ++++++++- misc/translator/po/sq-AL-staff-help.po | 872 +- .../po/sr-Cyrl-i-opac-t-prog-v-3006000.po | 7685 +- .../po/sr-Cyrl-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 8486 +- misc/translator/po/sr-Cyrl-opac-ccsr.po | 344 +- misc/translator/po/sr-Cyrl-pref.po |53272 +++++++- misc/translator/po/sr-Cyrl-staff-help.po | 848 +- .../translator/po/sv-SE-i-opac-t-prog-v-3006000.po | 7695 +- .../po/sv-SE-i-staff-t-prog-v-3006000.po |37434 ++---- misc/translator/po/sv-SE-opac-bootstrap.po | 9743 +- misc/translator/po/sv-SE-opac-ccsr.po | 376 +- misc/translator/po/sv-SE-pref.po |100492 +++++++++++++- misc/translator/po/sv-SE-staff-help.po | 2227 +- ...3006000.po => sw-KE-i-opac-t-prog-v-3006000.po} | 7847 +- ...006000.po => sw-KE-i-staff-t-prog-v-3006000.po} |36645 ++---- ...K-opac-bootstrap.po => sw-KE-opac-bootstrap.po} | 8447 +- misc/translator/po/sw-KE-opac-ccsr.po | 549 + misc/translator/po/sw-KE-pref.po |16022 +++ .../po/{eu-staff-help.po => sw-KE-staff-help.po} | 872 +- .../translator/po/ta-LK-i-opac-t-prog-v-3006000.po | 7748 +- .../po/ta-LK-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/ta-LK-opac-bootstrap.po | 8423 +- misc/translator/po/ta-LK-opac-ccsr.po | 344 +- misc/translator/po/ta-LK-pref.po |78044 ++++++++++- misc/translator/po/ta-LK-staff-help.po | 848 +- misc/translator/po/ta-i-opac-t-prog-v-3006000.po | 7602 +- misc/translator/po/ta-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/ta-opac-bootstrap.po | 8471 +- misc/translator/po/ta-opac-ccsr.po | 344 +- misc/translator/po/ta-pref.po |68686 +++++++++- misc/translator/po/ta-staff-help.po | 848 +- misc/translator/po/tet-i-opac-t-prog-v-3006000.po | 9746 +- misc/translator/po/tet-i-staff-t-prog-v-3006000.po |133214 ++++++++----------- misc/translator/po/tet-opac-bootstrap.po | 9895 +- misc/translator/po/tet-opac-ccsr.po | 465 +- misc/translator/po/tet-pref.po |38252 +++++- misc/translator/po/tet-staff-help.po | 7288 +- .../translator/po/th-TH-i-opac-t-prog-v-3006000.po | 7621 +- .../po/th-TH-i-staff-t-prog-v-3006000.po |36621 ++---- misc/translator/po/th-TH-opac-bootstrap.po | 8491 +- misc/translator/po/th-TH-opac-ccsr.po | 347 +- misc/translator/po/th-TH-pref.po |78986 ++++++++++- misc/translator/po/th-TH-staff-help.po | 1106 +- .../translator/po/tl-PH-i-opac-t-prog-v-3006000.po | 7730 +- .../po/tl-PH-i-staff-t-prog-v-3006000.po |36738 ++---- misc/translator/po/tl-PH-opac-bootstrap.po | 8463 +- misc/translator/po/tl-PH-opac-ccsr.po | 360 +- misc/translator/po/tl-PH-pref.po |86353 +++++++++++- misc/translator/po/tl-PH-staff-help.po | 2479 +- .../translator/po/tr-TR-i-opac-t-prog-v-3006000.po | 7917 +- .../po/tr-TR-i-staff-t-prog-v-3006000.po |39051 ++---- misc/translator/po/tr-TR-opac-bootstrap.po | 8741 +- misc/translator/po/tr-TR-opac-ccsr.po | 383 +- misc/translator/po/tr-TR-pref.po |91086 ++++++++++++- misc/translator/po/tr-TR-staff-help.po | 1939 +- .../translator/po/uk-UA-i-opac-t-prog-v-3006000.po | 8403 +- .../po/uk-UA-i-staff-t-prog-v-3006000.po |139037 +++++++++----------- misc/translator/po/uk-UA-opac-bootstrap.po | 8616 +- misc/translator/po/uk-UA-opac-ccsr.po | 393 +- misc/translator/po/uk-UA-pref.po |32774 ++++- misc/translator/po/uk-UA-staff-help.po | 9776 +- .../po/ur-Arab-i-opac-t-prog-v-3006000.po | 7608 +- .../po/ur-Arab-i-staff-t-prog-v-3006000.po |36559 ++--- misc/translator/po/ur-Arab-opac-bootstrap.po | 8435 +- misc/translator/po/ur-Arab-opac-ccsr.po | 347 +- misc/translator/po/ur-Arab-pref.po | 4276 +- misc/translator/po/ur-Arab-staff-help.po | 848 +- .../translator/po/vi-VN-i-opac-t-prog-v-3006000.po | 9529 +- .../po/vi-VN-i-staff-t-prog-v-3006000.po |36718 ++---- misc/translator/po/vi-VN-opac-bootstrap.po | 8501 +- misc/translator/po/vi-VN-opac-ccsr.po | 360 +- misc/translator/po/vi-VN-pref.po |92784 ++++++++++++- misc/translator/po/vi-VN-staff-help.po | 1097 +- .../po/zh-Hans-CN-i-opac-t-prog-v-3006000.po | 7981 +- .../po/zh-Hans-CN-i-staff-t-prog-v-3006000.po |38652 ++---- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 9074 +- misc/translator/po/zh-Hans-CN-opac-ccsr.po | 509 +- misc/translator/po/zh-Hans-CN-pref.po |76359 ++++++++++- misc/translator/po/zh-Hans-CN-staff-help.po | 906 +- .../po/zh-Hans-TW-i-opac-t-prog-v-3006000.po | 8031 +- .../po/zh-Hans-TW-i-staff-t-prog-v-3006000.po |38711 ++---- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 9148 +- misc/translator/po/zh-Hans-TW-opac-ccsr.po | 442 +- misc/translator/po/zh-Hans-TW-pref.po |81707 +++++++++++- misc/translator/po/zh-Hans-TW-staff-help.po | 920 +- 420 files changed, 5252655 insertions(+), 4315191 deletions(-) copy misc/translator/po/{ru-RU-i-opac-t-prog-v-3006000.po => be-BY-i-opac-t-prog-v-3006000.po} (65%) copy misc/translator/po/{ru-RU-i-staff-t-prog-v-3006000.po => be-BY-i-staff-t-prog-v-3006000.po} (61%) copy misc/translator/po/{ru-RU-opac-bootstrap.po => be-BY-opac-bootstrap.po} (64%) copy misc/translator/po/{ru-RU-opac-ccsr.po => be-BY-opac-ccsr.po} (51%) create mode 100644 misc/translator/po/be-BY-pref.po copy misc/translator/po/{nn-NO-staff-help.po => be-BY-staff-help.po} (79%) copy misc/translator/po/{ta-LK-i-opac-t-prog-v-3006000.po => fo-FO-i-opac-t-prog-v-3006000.po} (58%) copy misc/translator/po/{ta-i-staff-t-prog-v-3006000.po => fo-FO-i-staff-t-prog-v-3006000.po} (58%) copy misc/translator/po/{ta-LK-opac-bootstrap.po => fo-FO-opac-bootstrap.po} (56%) create mode 100644 misc/translator/po/fo-FO-opac-ccsr.po create mode 100644 misc/translator/po/fo-FO-pref.po copy misc/translator/po/{eu-staff-help.po => fo-FO-staff-help.po} (95%) copy misc/translator/po/{ta-LK-i-opac-t-prog-v-3006000.po => rw-RW-i-opac-t-prog-v-3006000.po} (58%) copy misc/translator/po/{pbr-i-staff-t-prog-v-3006000.po => rw-RW-i-staff-t-prog-v-3006000.po} (58%) copy misc/translator/po/{ta-LK-opac-bootstrap.po => rw-RW-opac-bootstrap.po} (55%) create mode 100644 misc/translator/po/rw-RW-opac-ccsr.po create mode 100644 misc/translator/po/rw-RW-pref.po copy misc/translator/po/{eu-staff-help.po => rw-RW-staff-help.po} (95%) copy misc/translator/po/{ta-LK-i-opac-t-prog-v-3006000.po => sw-KE-i-opac-t-prog-v-3006000.po} (58%) copy misc/translator/po/{pbr-i-staff-t-prog-v-3006000.po => sw-KE-i-staff-t-prog-v-3006000.po} (58%) copy misc/translator/po/{ta-LK-opac-bootstrap.po => sw-KE-opac-bootstrap.po} (55%) create mode 100644 misc/translator/po/sw-KE-opac-ccsr.po create mode 100644 misc/translator/po/sw-KE-pref.po copy misc/translator/po/{eu-staff-help.po => sw-KE-staff-help.po} (95%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 21:37:46 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 19:37:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-61-g9d9c413c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9d9c413c42dc124c7ef26c779c2c0758b4735ae4 (commit) via 833eef4e08b7e8891c86b5e898c43f3aaeab6ff5 (commit) via 49ebd6068783f5551ef3688f3fe4681f1a0e3b8e (commit) from ceb017765fc3430f188b5cbdd71d994c15359508 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d9c413c42dc124c7ef26c779c2c0758b4735ae4 Author: Galen Charlton Date: Mon May 19 19:56:14 2014 +0000 Bug 12288: (follow-up) test for defined values This patch adjusts the test so that if an "ISBN" is not defined (because the source string did not specify a valid ISBN), it doesn't result in a warning once the warnings stricture is enabled in C4::Koha. Signed-off-by: Galen Charlton commit 833eef4e08b7e8891c86b5e898c43f3aaeab6ff5 Author: Kyle M Hall Date: Mon May 19 08:37:28 2014 -0400 Bug 12288: fix search errors with AggressiveMatchOnISBN turned on This patch fixes a problem where search errors like this in the logs when running a stage import with the AggressiveMatchOnISBN syspref turned on: search failed (isbn,phr=978-0-7517-9745-9 or isbn,phr=0-7517-9745-6 or isbn,phr=978-0-7517-9745-9 or isbn,phr=0751797456 or isbn,phr=9780751797459 or isbn,phr=978-0-7517-9759-6 or isbn,phr=0-7517-9759-6 or isbn,phr=978-0-7517-9759-6 or isbn,phr=0751797596 or isbn,phr=9780751797596 or isbn,phr= or isbn,phr= or isbn,phr= or isbn,phr= or isbn,phr=) CCL parsing error (10014) Search word expected ZOOM at /usr/share/koha/lib/C4/Matcher.pm line 688. This is most easily seen when running the script from command line /misc/stage_file.pl. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton commit 49ebd6068783f5551ef3688f3fe4681f1a0e3b8e Author: Galen Charlton Date: Mon May 19 19:29:44 2014 +0000 Bug 12288: add regression test To test: [1] Run prove -v t/Koha.t. The last test should fail. [2] Apply the main patch for this bug. [3] Run prove -v t/Koha.t again. This time, all tests should pass. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 3 +++ t/Koha.t | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 23:26:27 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 21:26:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-65-g2c5f927 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2c5f927689c24323128e88cfa26ffe9adcfbd832 (commit) via 624c953b354a21f556ed499726d233dead6aa40f (commit) via 92c765307198b0624dcb80b342beedef412cccf7 (commit) via 7ec644da06382eb0018a3fad88ef61b35a05e2aa (commit) from 9d9c413c42dc124c7ef26c779c2c0758b4735ae4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2c5f927689c24323128e88cfa26ffe9adcfbd832 Author: Robin Sheat Date: Tue May 13 13:39:04 2014 +1200 Bug 11404: (follow-up) only ask user if there are instances needing upgrading There's no point asking the user if they want their Apache Koha configuration updated if there's no configuration needing updated. This also fixes a case where the updating would have failed when running on Apache 2.4. Signed-off-by: Tomas Cohen Arazi I agree with adding that checks, and the conditions rewrite seems cleaner than my first approach. So, I sign it. Signed-off-by: Galen Charlton commit 624c953b354a21f556ed499726d233dead6aa40f Author: Tomas Cohen Arazi Date: Tue May 6 15:13:19 2014 -0300 Bug 11404: Make the install process aware of the changes This patch makes the install scripts take care of the new file and prompt for user confirmation on the apache file renaming step. Both prompt and the renaming actions depend on the fact that there are instances with their files missing the .conf appendix. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton commit 92c765307198b0624dcb80b342beedef412cccf7 Author: Tomas Cohen Arazi Date: Mon May 5 11:50:55 2014 -0300 Bug 11404: koha-functions.sh introduced for reuse As asked by Robin, a bash lib of functions is introduced with the common functions to be reused. Most of the scripts are modified (reduced) to include this file and the repeated functions cleaned. No noticeable change in behaviour should be noticed. As I've been todl in #debian-mentors, it is used that files for inclusion should be installed at the apps directory (i.e. /usr/share/koha/) so this patch makes the install script put the file in the bin/ directory. All koha-* scripts assume the file is there already (and fail otherwise). Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton commit 7ec644da06382eb0018a3fad88ef61b35a05e2aa Author: Tomas Cohen Arazi Date: Mon Dec 16 14:32:40 2013 -0300 Bug 11404: add support for Apache 2.4's config file convention Apache 2.4 expects the sites definition files use the sufix '.conf' To reproduce: - Install the 'koha-common' package on Debian 7 or Ubuntu 13.10+ (both known to include Apache 2.4). - Create an instance (for example testlibrary) using the supplied commands: $ koha-create --create-db testlibrary > FAIL: apache reports an error like this: "ERROR: Site testlibrary does not exist!" This patch adds a test on the Apache version and appends the ".conf" sufix if needed. To test: 1st step: koha-create gets fixed: -- The hard way -- - Apply the patch, and build the koha-common package on top of this commit. - Install the built package on an Apache 2.4 Debian-based distro (Debian 7 or Ubuntu 13.10 will work) - Create a test instance: $ koha-create --create-db testlibrary > SUCCESS: no more apache sites related error. -- The easy way -- - Apply the patch, and copy the koha-create into an Apache 2.4 Debian-based distro - Create a test instance using the koha-create script you just copied: $ ./koha-create --create-db testlibrary > SUCCESS: no more apache sites related error. 2nd step: the rest of the touched scripts keep working as usual koha-disable koha-dump koha-enable koha-list koha-remove koha-restart-zebra koha-stop-zebra koha-start-zebra They should all keep working. Can be tested "the easy way" too. Note: there might be another issues regarding Apache 2.4 deployments like the need for $ a2enmod access_compat and perhaps some directory permissions tweak, which I think should be properly documented on the install instructions. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: debian/koha-common.config | 16 ++++ debian/koha-common.install | 1 + debian/koha-common.postinst | 50 ++++++++++ debian/koha-common.templates | 8 ++ debian/scripts/koha-create | 75 +++++++++++---- debian/scripts/koha-disable | 59 ++++-------- debian/scripts/koha-dump | 19 ++-- debian/scripts/koha-email-disable | 39 ++------ debian/scripts/koha-email-enable | 39 ++------ debian/scripts/koha-enable | 48 ++-------- debian/scripts/{koha-enable => koha-functions.sh} | 90 +++++++++--------- debian/scripts/koha-list | 51 ++-------- debian/scripts/koha-mysql | 9 +- debian/scripts/koha-mysqlcheck | 9 +- debian/scripts/koha-rebuild-zebra | 28 ++---- debian/scripts/koha-remove | 17 +++- debian/scripts/koha-reset-passwd | 11 ++- debian/scripts/koha-restart-zebra | 57 ++--------- debian/scripts/koha-restore | 11 ++- debian/scripts/koha-start-zebra | 104 ++++++--------------- debian/scripts/koha-stop-zebra | 92 +++++------------- debian/scripts/koha-translate | 14 +-- 22 files changed, 340 insertions(+), 507 deletions(-) copy debian/scripts/{koha-enable => koha-functions.sh} (50%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 23:39:45 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 21:39:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-68-g1387c65 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1387c65c0d344ad49206f6e181990e704a542d26 (commit) via dd36f80e2ccfe64c59648543997778b295959a4d (commit) via 75f00c3e304738f2eb77acbb60242e3c0fe4d6c2 (commit) from 2c5f927689c24323128e88cfa26ffe9adcfbd832 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1387c65c0d344ad49206f6e181990e704a542d26 Author: Galen Charlton Date: Mon May 19 22:04:45 2014 +0000 Bug 12168: (follow-up) correct typos in test descriptions Signed-off-by: Galen Charlton commit dd36f80e2ccfe64c59648543997778b295959a4d Author: Jonathan Druart Date: Thu May 1 14:23:51 2014 +0200 Bug 12168: Add unit tests for GetBudgetHierarchySpent & GetBudgetHierarchyOrdered Test plan: prove t/db_dependent/Budgets.t Note: This addition may sound overkill but I found this bug developing bug 12164 and I will reuse all of that. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton commit 75f00c3e304738f2eb77acbb60242e3c0fe4d6c2 Author: Jonathan Druart Date: Thu May 1 14:12:18 2014 +0200 Bug 12168: fix spent and ordered budget values are wrong when depth >= 2 A really weird (and old) code process the calculation for the spent and ordered sublevel funds. It only takes into account the direct children. So if you have: fund1 (spent=100) parent of fund11 (spent=10) parent of fund111 (spent=1), you get: fund | base-level | total spent fund1 | 100 | 110 fund11 | 10 | 11 fund111 | 1 | 1 which is wrong, it should be fund | base-level | total spent fund1 | 100 | 111 fund11 | 10 | 11 fund111 | 1 | 1 Test plan: - Create 1 budget and 3 funds with the same structure as above. - Create some orders and receive them (not all). - Go on the fund list view and verify the values are correct. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 89 ++++++++++----------- admin/aqbudgets.pl | 3 - t/db_dependent/Budgets.t | 194 ++++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 234 insertions(+), 52 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 19 23:48:32 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 21:48:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-70-g36135f2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 36135f2d5646d91a46dcebed947fdcca8f336dfd (commit) via 1ab0b36c04512ce50aa6ba9728e30cda9bb7e98d (commit) from 1387c65c0d344ad49206f6e181990e704a542d26 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36135f2d5646d91a46dcebed947fdcca8f336dfd Author: Katrin Fischer Date: Sat May 17 12:36:07 2014 +0200 Bug 12113: Update German web installer for 3.16 Changes: - Translates new notices SHARE_ACCEPT und SHARE_INVITE - Copies subtag_registry.sql from en as after applying patch from bug 12275 - so 'Laotisch' will show up correctly - Rephrases and corrects spelling for user permissions - Translates new authorized value SIP_MEDIA_TYPE - Improves translations of creator sample data - Improves translations of sample patron categories - translations in po files were changed accordingly To test: - Run the web installer, install all mandatory and optional sample data - Check everything is installed without errors - Verify changes listed above in the interface Signed-off-by: Bernardo Gonzalez Kriegel Installer works ok, values ok No errors Signed-off-by: Brendan Gallagher Signed-off-by: Galen Charlton commit 1ab0b36c04512ce50aa6ba9728e30cda9bb7e98d Author: Katrin Fischer Date: Sat May 17 12:23:53 2014 +0200 Bug 12275: Small corrections to English web installer - Corrects the German translation for 'Laotisch' - Adds an icon to the reference item type - Corrects capitalization for user permissions To test: - Run English web installer, make sure to select the sample item types and all mandatory data - Check user permissions appear correctly - Check icon for REF itemtype is shown correctly - Check that languages in Advanced Search appear as normal - Install German and check in language list on advanced search 'Laotisch' now appears Signed-off-by: Bernardo Gonzalez Kriegel Works well following test plan. No errors Signed-off-by: Brendan Gallagher Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../data/mysql/de-DE/mandatory/sample_notices.sql | 27 ++++++++++---------- .../data/mysql/de-DE/mandatory/subtag_registry.sql | 4 +-- installer/data/mysql/de-DE/mandatory/userflags.sql | 10 ++++---- .../data/mysql/de-DE/mandatory/userpermissions.sql | 6 ++--- installer/data/mysql/de-DE/optional/auth_val.sql | 18 ++++++------- .../data/mysql/de-DE/optional/csv_profiles.sql | 2 +- .../mysql/de-DE/optional/patron_categories.sql | 2 +- .../mysql/de-DE/optional/patron_categories.txt | 6 ++--- .../mysql/de-DE/optional/sample_creator_data.sql | 6 ++--- .../data/mysql/en/mandatory/subtag_registry.sql | 2 +- installer/data/mysql/en/mandatory/userflags.sql | 6 ++--- .../data/mysql/en/mandatory/userpermissions.sql | 4 +-- .../data/mysql/en/optional/sample_itemtypes.sql | 2 +- 13 files changed, 47 insertions(+), 48 deletions(-) mode change 100644 => 100755 installer/data/mysql/de-DE/mandatory/subtag_registry.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 20 00:37:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 22:37:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-72-g1e0fb1c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1e0fb1cb2d0dd29724c63c9b831694bc3233e540 (commit) via c609e5627103883c34812a43999f36ec5eb88b1a (commit) from 36135f2d5646d91a46dcebed947fdcca8f336dfd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e0fb1cb2d0dd29724c63c9b831694bc3233e540 Author: Katrin Fischer Date: Sat May 17 15:35:42 2014 +0200 Bug 10964: Update German default bibliographic and authority frameworks This updates the German default frameworks for bibliographic records and authorities using the files created from the po files on Pootle. To test: - Run the web installer, make sure all mandatory data is selected - Verify there are no SQL errors - Check cataloguing behaves normally - Check adding authorities behaves normally Signed-off-by: Bernardo Gonzalez Kriegel Tested using webinstaller. No errors Signed-off-by: Brendan Gallagher Signed-off-by: Galen Charlton commit c609e5627103883c34812a43999f36ec5eb88b1a Author: Katrin Fischer Date: Sun May 18 09:58:48 2014 +0200 Bug 10964: Update German simple and fast add frameworks This updates the German simple and fast add frameworks using the files created from the po files on Pootle. To test: - Run the web installer, make sure all mandatory data is selected - Verify there are no SQL errors - Check cataloguing behaves normally - Check adding authorities behaves normally Signed-off-by: Bernardo Gonzalez Kriegel Tested using webinstaller Checked No errors Signed-off-by: Brendan Gallagher Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../marc21/mandatory/authorities_normal_marc21.sql | 7997 ++------------------ .../marc21/mandatory/marc21_framework_DEFAULT.sql | 1105 ++- .../marc21/optional/marc21_fastadd_framework.sql | 270 +- .../optional/marc21_simple_bib_frameworks.sql | 3753 +++++---- 4 files changed, 3786 insertions(+), 9339 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 20 00:52:20 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 22:52:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-beta-74-g1d767a0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1d767a0977180e1989b66f8edd168314f6f0af72 (commit) via fff8ae56c49cd33f2655a4a00cff2ef51854c8e1 (commit) from 1e0fb1cb2d0dd29724c63c9b831694bc3233e540 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1d767a0977180e1989b66f8edd168314f6f0af72 Author: Galen Charlton Date: Mon May 19 23:16:06 2014 +0000 DBRev 3.15.00.052: mark Koha 3.16 RC Signed-off-by: Galen Charlton commit fff8ae56c49cd33f2655a4a00cff2ef51854c8e1 Author: Galen Charlton Date: Mon May 19 23:14:31 2014 +0000 update release notes for Koha 3.16.0-rc Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 6 + kohaversion.pl | 2 +- misc/release_notes/release_notes_3_16_0.txt | 213 ++++++++++++++++----------- 3 files changed, 137 insertions(+), 84 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 20 00:52:30 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 May 2014 22:52:30 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.16.00-rc created. v3.16.00-rc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.16.00-rc has been created at 9e350be800ed60627e45a0815d53ce0e266cc925 (tag) tagging 1d767a0977180e1989b66f8edd168314f6f0af72 (commit) replaces v3.16.00-beta tagged by Galen Charlton on Mon May 19 23:18:01 2014 +0000 - Log ----------------------------------------------------------------- Koha 3.16.0 RC -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlN6kSkACgkQ+ECRQ8R3E0POwQCeIEPeRkCfiGY60fxm+6/cLRfc bgAAn1vbo6J0NPn6gYWSDJ9nrm3w9xoR =nQTt -----END PGP SIGNATURE----- Bernardo Gonzalez Kriegel (2): Bug 12244 - followup to fix tabs Translation update for 3.16.00 release Fridolin Somers (1): Bug 12271: add Bootstrap templates to valid-templates.t tests Galen Charlton (18): Bug 8375: (follow-up) adjust StrWidth to account for TTF fonts Bug 8375: (follow-up) adjust another test case for change in fonts Bug 8375: (follow-up) final adjustment to t/Creators.t Bug 12198: (follow-up) fix warning when opening guarantor search form Bug 4068: (follow-up) use URI::Escape Bug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge() Bug 12214: add regression test for reporting error when running report with SQL error Bug 12214: (follow-up) correct POD of C4::Reports::Guided::execute_query() Bug 12206: fix HTML in other holdings list in staff search results page Bug 12243: add regression test Bug 12271: (follow-up) teach valid-templates.t how to include specified templates Bug 12271: (follow-up) fix minor errors in Bootstrap theme Bug 7841: add a direct regression test Bug 12288: add regression test Bug 12288: (follow-up) test for defined values Bug 12168: (follow-up) correct typos in test descriptions update release notes for Koha 3.16.0-rc DBRev 3.15.00.052: mark Koha 3.16 RC Jonathan Druart (6): Bug 9063: rename num_biblios to num_records in addorderiso2709.{pl,tt} Bug 11975: improve the batch patron deletion code Bug 12251: fix error in sample_notices.sql (fr-FR) Bug 12251: fix error in sample_notices.sql (ru-RU) Bug 12168: fix spent and ordered budget values are wrong when depth >= 2 Bug 12168: Add unit tests for GetBudgetHierarchySpent & GetBudgetHierarchyOrdered Julian Maurice (2): Bug 11843: prevent manual history from being overwritten if subscription switched to automatic history Bug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t Katrin Fischer (4): Bug 12275: Small corrections to English web installer Bug 12113: Update German web installer for 3.16 Bug 10964: Update German simple and fast add frameworks Bug 10964: Update German default bibliographic and authority frameworks Koha SAB CINECA (2): Bug 11241: update the Italian MARC21 setup for 3.16 Bug 12240 - update of Italian SQL files (non-MARC setup) Kyle M Hall (7): Bug 12212: fix error that prevented sysprefs.sql from loading Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search Bug 12198: (code cleanup) remove unused variables, tidy code Bug 4068: ensure accepting a suggestion does not hide the 'pending' tab Bug 12214: (follow-up) Clean up reports-toolbar.inc, show Edit link when SQL has errors Bug 12243: ensure that records with invalid ISBNs do not cause searches to fail Bug 12288: fix search errors with AggressiveMatchOnISBN turned on Magnus Enger (2): Bug 12185 - Remove extra "f" from parcel.tt Bug 12209 - Fix currency symbol for NOK Marcel de Rooy (2): Bug 12065: use encode_qp consistently when sending basket/shelf Bug 9612: (follow-up) restore elementSetName in Context.pm Mark Tompsett (2): Bug 7841: add unit tests to detect no functional changes to getTranslatedLanguages() Bug 7841: quell warnings in C4::Languages Mathieu Saby (1): Bug 11433: (code cleanup) remove unused 'attachbasket' op value in basket.pl Matthias Meusburger (1): Bug 12161: fix regression on serials receiving Nicole C. Engard (8): Bug 12244 - Koha 3.16 Circ Help Updates Bug 12244 - Update Patron help files for 3.16 Bug 12244 - Update cataloging help for 3.16 Bug 12244 - Update Search Help for 3.16 Bug 12244 - Update Notices Help Files Bug 12244 - Update authorized values help for 3.16 Bug 12244 - Update Admin Help for 3.16 Bug 12244 - Update Acq Help for 3.16 Owen Leonard (4): Bug 12196 - Remove unused jquery.qtip.js plugin Bug 12195 - Remove duplicated plugin jquery.dataTables.min.js Bug 9723: display time due for hourly loans in the public catalog Bug 9724: ensure hourly loans show time due in SCO Pasi Kallinen (1): Bug 12214: display SQL errors in reports to users Robin Sheat (7): Bug 12163 - fix adding new quotes Bug 9048 - fix quote editor under Plack Bug 12234 - dependency changes to allow master to build Bug 12234 - changelog updates from 3.14 series Bug 12234 - build script version update Bug 12259 - fix version numbers in dependencies Bug 11404: (follow-up) only ask user if there are instances needing upgrading Tomas Cohen Arazi (4): Bug 12251: fix error in sample_notices.sql (es-ES) Bug 11404: add support for Apache 2.4's config file convention Bug 11404: koha-functions.sh introduced for reuse Bug 11404: Make the install process aware of the changes ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 20 09:17:25 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 20 May 2014 07:17:25 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-68-g704d0cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 704d0cf4b21aaca2bd3d21ea5bb2186ae6d3c848 (commit) via 3d79aad0a45c3714e597323cd0e804c30ab08325 (commit) via 786eba26cde8a1954dc4ed957d9b481c43441c44 (commit) from d93700833b0c816731e2675cc436979358c0081f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 704d0cf4b21aaca2bd3d21ea5bb2186ae6d3c848 Author: Galen Charlton Date: Mon May 19 16:25:53 2014 +0000 Bug 12271: (follow-up) fix minor errors in Bootstrap theme To test: [1] Verify that prove -v xt/author/valid-templates.t passes. Signed-off-by: Galen Charlton (cherry picked from commit bafeb881c99142fd3abf507a3c5bcddd2c12932a) Signed-off-by: Fridolin Somers commit 3d79aad0a45c3714e597323cd0e804c30ab08325 Author: Galen Charlton Date: Mon May 19 16:14:28 2014 +0000 Bug 12271: (follow-up) teach valid-templates.t how to include specified templates Two of the template includes in the Bootstrap theme cannot be tested all by themselves because they require that the template that includes them define BLOCKs. This patch ensures that they are excluded from individual testing; they will get exercised sufficiently by being including by all of the other Bootstrap templates. Signed-off-by: Galen Charlton (cherry picked from commit b97e691ef87bf3fd89f38ba0b1772d8fcac44b33) Signed-off-by: Fridolin Somers commit 786eba26cde8a1954dc4ed957d9b481c43441c44 Author: Fridolin Somers Date: Fri May 16 11:25:19 2014 +0200 Bug 12271: add Bootstrap templates to valid-templates.t tests valid-templates.t actually tests the templates and includes of only the "prog" theme at opac and intranet. It does not test the opac templates and includes of bootstrap theme, nor ccsr. This is critical since this test is used for patch integrations in release maintenance. This patch adds the test of bootstrap opac theme. I did not manage to add the ccsr theme since it is not a real theme, meaning it has no templates and not all includes. Test by runnning perl xt/author/valid-templates.t and looking at the logs. Signed-off-by: Bernardo Gonzalez Kriegel Now there are 902 lines, bootstrap tested (1 error detected!) No koha-qa errors Signed-off-by: Galen Charlton (cherry picked from commit 8bc2fb4df6e14a97c3aa7a62fbacc4bc7cf5772d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../bootstrap/en/modules/opac-results-grouped.tt | 6 +-- .../bootstrap/en/modules/search/results.tt | 3 ++ xt/author/valid-templates.t | 47 +++++++++++++++++--- 3 files changed, 47 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 20 15:47:02 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 20 May 2014 13:47:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-rc-1-g3f9a8cc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3f9a8ccc18c8d97ac4167e313f4d3a685a9000dc (commit) from 1d767a0977180e1989b66f8edd168314f6f0af72 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3f9a8ccc18c8d97ac4167e313f4d3a685a9000dc Author: Katrin Fischer Date: Mon May 19 00:28:25 2014 +0200 Bug 12282: fix RESERVESLIP in German sample notices Accidentally the ISSUESLIP got copied to the RESERVESLIP. This adds the correct text and formatting to the RESERVESLIP. To test: - Run the German web installer on an empty database - Check that the ISSUESLIP and RESERVESLIP notices are different and display correctly Signed-off-by: Bernardo Gonzalez Kriegel Tested using webinstaller, all optionals, all ok. ISSUESLIP(Ausleihquittung) longer than RESERVESLIP(Vormerkung) No errors Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../data/mysql/de-DE/mandatory/sample_notices.sql | 28 ++++++-------------- 1 file changed, 8 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:08:04 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:08:04 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-69-gd64145b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via d64145b2c61ebbd1bd34f276dc1e107382b4ad59 (commit) from 704d0cf4b21aaca2bd3d21ea5bb2186ae6d3c848 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d64145b2c61ebbd1bd34f276dc1e107382b4ad59 Author: Colin Campbell Date: Mon Jan 6 11:53:29 2014 +0000 Bug 11478: Replace experimental given/when keywords The keywords given and when are flagged experimental in perl 5.18 and subject to change. This patch replaces the construct by an if/elsif To test: [1] Verify that prove -v t/SimpleMARC.t passes. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 08d15a6fd1b51435b92f1056f6735c8317636068) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/SimpleMARC.pm | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:10:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:10:01 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-70-g8893ac5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 8893ac58fc4a4c2621ddd0002487a0f00a45f48c (commit) from d64145b2c61ebbd1bd34f276dc1e107382b4ad59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8893ac58fc4a4c2621ddd0002487a0f00a45f48c Author: Colin Campbell Date: Mon Jan 6 12:06:29 2014 +0000 Bug 11479: Remove experimental given/when keywords Replace constructs using given and when by if/else feature now generates compilation warnings in 5.18 and is liable to change behaviour. This patch: * replaces the construct with if/else * reformats the if branching using perltidy to remove the now redundant indent To test: [1] Verify that prove -v t/db_dependent/MarcModificationTemplates.t passes. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 11faf9fde8da48c58e853d5538a8e3bbd2ae41c5) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/MarcModificationTemplates.pm | 90 ++++++++++++++++++++++----------------- 1 file changed, 50 insertions(+), 40 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:15:08 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:15:08 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-72-g7d40a4c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 7d40a4c9081d50b15652f80a0d65d8a60f7a57b5 (commit) via 3ef4918dc7afcc58ea180d40768344a558799931 (commit) from 8893ac58fc4a4c2621ddd0002487a0f00a45f48c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d40a4c9081d50b15652f80a0d65d8a60f7a57b5 Author: Owen Leonard Date: Wed Feb 19 15:06:36 2014 -0500 Bug 10714 [Follow-up] Redirect to list contents view upon cancel after initiating edit from list contents view (staff) This follow-up corrects the "cancel" action on list edit actions based on whether the edit was initiated from the list of lists or the list contents view. To test, view the list of lists and click the edit link next to one of them. Click the cancel link. You should return to the list of lists you were just viewing. View the contents of a list. Choose "Edit list" from the edit menu. Click the cancel link on the edit screen. You should return to the list contents view from which you initiated the edit action. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 6a323ce4ce914e757d5c1c999237ad2c0efc15e9) Signed-off-by: Fridolin Somers commit 3ef4918dc7afcc58ea180d40768344a558799931 Author: Owen Leonard Date: Mon Aug 12 15:30:16 2013 -0400 Bug 10714: Redirect to list contents view upon save after initiating edit from list contents view (staff) In the staff client, if you initiate a list edit from the list contents view you should be redirected to that same view after saving your changes. The OPAC already works this way. To test, view the contents of an existing list. Click the "Edit list" item under the "Edit" menu. Click save on the list edit form and you should be redirected back to the contents view of that list. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit daa98e73f8baf178f2b0f32b4988d2414519ea4b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/virtualshelves-toolbar.inc | 2 +- .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:18:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:18:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-73-gfc50362 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via fc50362c231ceb9a410dcbcbce94b8124db1aa13 (commit) from 7d40a4c9081d50b15652f80a0d65d8a60f7a57b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fc50362c231ceb9a410dcbcbce94b8124db1aa13 Author: Owen Leonard Date: Tue Feb 18 12:13:39 2014 -0500 Bug 11785 - Use validation plugin when uploading local cover images When uploading local cover images the form should not be submitted if no file has been selected. The existing form validation script doesn't work. This patch adds HTML5 validation attributes and use of Koha's built-in form validation plugin. To test, apply the patch and go to Tools -> Upload local cover image. Try to submit the form without selecting a file to upload. You should be prevented from doing so. Choose a file and confirm that the upload completes correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 7faff33c8b9bd670cf7813f4cefb7aee38709ebb) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/upload-images.tt | 21 +++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:33:26 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:33:26 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-74-g17281f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 17281f8a6624c06170ec68d3b7ff472378d263dc (commit) from fc50362c231ceb9a410dcbcbce94b8124db1aa13 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17281f8a6624c06170ec68d3b7ff472378d263dc Author: Owen Leonard Date: Tue Feb 18 14:52:26 2014 -0500 Bug 11787 - Use validation plugin when adding new vendor The vendor entry form uses some custom JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Also corrected: Minor validation issue. To test, apply the patch and go to Acquisitions -> New vendor. Try submitting the form without entering a vendor name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing vendor should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 03675fd55320f3a9bc3d4c7475bc3b9696920bd9) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/acqui/supplier.tt | 21 +++++++------------- 1 file changed, 7 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:36:49 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:36:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-75-gcb9915e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via cb9915e75e20a694fc78ba8bf4ac664b1c66934b (commit) from 17281f8a6624c06170ec68d3b7ff472378d263dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb9915e75e20a694fc78ba8bf4ac664b1c66934b Author: Owen Leonard Date: Tue Feb 18 15:26:30 2014 -0500 Bug 11788 - Use validation plugin when creating new course The page for adding a new course includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Course reserves -> New course. Try submitting the form without entering a department, course number, and/or course name. This should trigger validation warnings. Submission of the form with valid data should work correctly. Editing an existing course should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 4e9b5110d90c3ac60c61f710ff5892b9720e643e) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/course_reserves/course.tt | 45 ++++---------------- 1 file changed, 8 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:39:17 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:39:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-76-gb303105 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via b303105dc90910fd0b5faddc1a9495bd8034d213 (commit) from cb9915e75e20a694fc78ba8bf4ac664b1c66934b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b303105dc90910fd0b5faddc1a9495bd8034d213 Author: Owen Leonard Date: Wed Feb 19 13:05:19 2014 -0500 Bug 11795 - Use validation plugin when creating new Z39.50 server The page for adding a new Z39.50 server includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Z39.50 client targets -> New Z39.50 server. Try submitting the form with any of the following error conditions: - Missing Z39.50 server name - Missing hostname - Missing port - Non-numeric port - Missing database - Non-numeric rank - Non-numeric timeout These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing Z39.50 server should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Amended patch: replace tabs with spaces Signed-off-by: Galen Charlton (cherry picked from commit 19bf1e9a40ab5a8f3c86fb07dd6429bfc44f703b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/z3950servers.tt | 74 +++++++------------- 1 file changed, 25 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:42:00 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:42:00 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-77-g4478890 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 4478890d55acd9171148a038b9362300b3ad7db9 (commit) from b303105dc90910fd0b5faddc1a9495bd8034d213 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4478890d55acd9171148a038b9362300b3ad7db9 Author: Owen Leonard Date: Wed Feb 19 12:29:34 2014 -0500 Bug 11793 - Use validation plugin when creating new item type The page for adding a new item type includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Item types -> New item type. Try submitting the form with the following error conditions: - Missing item type - Missing description - A non-number in the "rental charge" field These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing item type should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 1d9b86aabccf1bc916b6b27e568ad984caf081f6) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/itemtypes.tt | 60 ++++---------------- 1 file changed, 11 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:45:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:45:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-78-g865e583 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 865e58399ca0bd6f1ce27a1323b75ffa99cefe2a (commit) from 4478890d55acd9171148a038b9362300b3ad7db9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 865e58399ca0bd6f1ce27a1323b75ffa99cefe2a Author: Owen Leonard Date: Wed Feb 19 11:59:33 2014 -0500 Bug 11792 - Use validation plugin when creating new currency The page for adding a new currency includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Currencies & Exchange rates -> New currency. Try submitting the form without entering a currency, rate, and/or symbol. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing currency should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 5dc093b30e8d949f39a67bf2ac40f219f6167d0a) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/currency.tt | 37 +++++--------------- 1 file changed, 8 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:47:23 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:47:23 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-79-g1e6c33c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1e6c33c41b1b6c94bb8bc84626ed64da42abe6d5 (commit) from 865e58399ca0bd6f1ce27a1323b75ffa99cefe2a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e6c33c41b1b6c94bb8bc84626ed64da42abe6d5 Author: Owen Leonard Date: Wed Feb 19 11:36:30 2014 -0500 Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Note: This patch changes the behavior. Before the patch, only 1 out of city and zip was required. Now both are. Since the 2 inputs were marked as required, I think they should be. Signed-off-by: Galen Charlton (cherry picked from commit d95ad086a35a7927bb7bc02453a1a1341387dc6a) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/cities.tt | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:49:27 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:49:27 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-80-gdc842ba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via dc842baa70e5dcf232f15cff232409fdcd833014 (commit) from 1e6c33c41b1b6c94bb8bc84626ed64da42abe6d5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dc842baa70e5dcf232f15cff232409fdcd833014 Author: Kyle M Hall Date: Wed Feb 19 15:26:24 2014 -0500 Bug 11796: fix display of search result facets if facet happens to have exactly six entries If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart This patch should provide a regression test but I really don't know how to write it. Signed-off-by: Galen Charlton (cherry picked from commit e7286e05137276f0a916f06d60a13c22c93294b2) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:55:32 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:55:32 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-82-g388130d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 388130d4b52194e240a7d6631eef33cfdf20fc3d (commit) via 09073898e2100d8d5e8e905e4eb2cf93f1bd141d (commit) from dc842baa70e5dcf232f15cff232409fdcd833014 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 388130d4b52194e240a7d6631eef33cfdf20fc3d Author: Fridolin Somers Date: Wed May 21 10:19:51 2014 +0200 Bug 11611: DBRev 3.14.06.002 Signed-off-by: Fridolin Somers commit 09073898e2100d8d5e8e905e4eb2cf93f1bd141d Author: Mathieu Saby Date: Sun Jan 26 19:55:46 2014 +0100 Bug 11611: Rephrase description and examples of 5 MARC related sysprefs This patch rephrases the description or examples of 5 sysprefs: 1/ MARCAuthorityControlField008: "MARC" -> "MARC21" 2/ itemcallnumber: "Examples" -> "Examples (for MARC21 records)" 3/ DefaultLanguageField008: "Range 35-37" -> "Range 35-37 of MARC21 records" 4/ MARCOrgCode: "new MARC records" -> "new MARC21 records" 5/ UNIMARCAuthorityField100 description: "Do NOT include the date (position 00-05)." -> "position 08-35. Do NOT include the date (position 00-07)." It also adds description in SQL systempreferences table for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode. Test plan: - Apply and run updatedatabase.pl - Check the changes are taken into account in syspref administration page - Check the changes are taken into account in systempreferences table (for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 68a7f7f4456078b1b9dc6fd1ba16f11ba45267fc) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 8 ++++---- installer/data/mysql/updatedatabase.pl | 21 ++++++++++++++++++++ .../en/modules/admin/preferences/authorities.pref | 4 ++-- .../en/modules/admin/preferences/cataloguing.pref | 6 +++--- kohaversion.pl | 2 +- 5 files changed, 31 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 09:58:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 07:58:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-83-g857711e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 857711eea8a2a5899b5f94ce25103bfc283c5c40 (commit) from 388130d4b52194e240a7d6631eef33cfdf20fc3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 857711eea8a2a5899b5f94ce25103bfc283c5c40 Author: Ketan Kulkarni Date: Thu Nov 21 14:37:58 2013 +0530 Bug 11087: Make the Pay Fines tab the default tab Since paying fines is the most likely action when clicking on the Fines tab, the pay fines tab should be the default rather than the account summary. http://bugs.koha-community.org/show_bug.cgi?id=11087 Signed-off-by: Holger Mei?ner Signed-off-by: Katrin Fischer Verified by accessing the fines pages from the various patron account pages. Signed-off-by: Galen Charlton (cherry picked from commit 65ae7a950de83b7bc9e741d0cc31a79d4797c579) ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:04:28 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:04:28 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-84-gfdeb2a0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via fdeb2a0cad0b686617d8376842408bb437fa26c4 (commit) from 857711eea8a2a5899b5f94ce25103bfc283c5c40 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdeb2a0cad0b686617d8376842408bb437fa26c4 Author: Nicole C. Engard Date: Fri Jan 24 09:47:53 2014 -0600 Bug 11272 - add second submit button to inventory form The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit 40ba1763afc40cd47b23892a3248fd877dc8edce) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:09:24 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:09:24 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-85-g1bfb679 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1bfb679a084aadabcee0c51dd2828da8746baba3 (commit) from fdeb2a0cad0b686617d8376842408bb437fa26c4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1bfb679a084aadabcee0c51dd2828da8746baba3 Author: Jonathan Druart Date: Wed Jan 15 16:24:00 2014 +0100 Bug 11562: re-sort sysprefs.sql The QA tools does not manage to catch error sorting on the sysprefs.sql file if it is already badly sorted. This patch tidies up the sysprefs file. TEST PLAN --------- [1] Verify that loading sysprefs.sql into an empty Koha database (or one whose system preferences table is is empty) works. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton RM note: I must point out that there ZERO functionality associated with the order that system preferences occur in that SQL script; they are sorted solely in an attempt to reduce the likelihood of merge conflicts during the development process. Consequently, I dislike language that suggests it is an "error" if sysprefs.sql happens to not be perfectly sorted; it is at most an inconvenience. (cherry picked from commit 988dc3b64af00d34f535b811f4093782ac7925a1) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:14:21 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:14:21 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-87-g8d988db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 8d988dbdcaebfe3d1cc325e5342951dbc0e3ed1b (commit) via 996060aa92aa091a991ebe25cd2cd255b0d9d694 (commit) from 1bfb679a084aadabcee0c51dd2828da8746baba3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d988dbdcaebfe3d1cc325e5342951dbc0e3ed1b Author: Galen Charlton Date: Fri Feb 21 17:38:42 2014 +0000 Bug 10580: (follow-up) tweak wording about looking for zebrasrv & zebraidx Signed-off-by: Galen Charlton (cherry picked from commit 1d276d58099fa60666bccc13c7b9d839946946c1) Signed-off-by: Fridolin Somers commit 996060aa92aa091a991ebe25cd2cd255b0d9d694 Author: Tomas Cohen Arazi Date: Fri Jan 24 10:40:03 2014 -0300 Bug 10580: adjust Makefile.PL to reflect that Zebra no longer optional in Koha setup Running Makefile.PL asks the user whether to install the Zebra configuration files and different texts relate to the user having chosen to use Zebra. This patch removes references to choosing to use Zebra and removes the related variables from the code. To test: - Apply the patch - Go through the different install modes - Verify that nothing nothing is broken Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 0b989fe0b2097d747da1fd6d04aa8aecc5652d06) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 235 ++++++++++++++++++++++++----------------------------- rewrite-config.PL | 1 - 2 files changed, 108 insertions(+), 128 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:17:17 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:17:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-88-g84a9b31 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 84a9b3192e82484dba6cbe041028b0c8818eb41b (commit) from 8d988dbdcaebfe3d1cc325e5342951dbc0e3ed1b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 84a9b3192e82484dba6cbe041028b0c8818eb41b Author: Marcel de Rooy Date: Thu Feb 20 12:54:32 2014 +0100 Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm This routine is no longer used. Test plan: Do a grep on the name. (Bonus points:) Verify if you can perform some actions on lists. No more occurences of _biblionumber_sth found Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 5e0d450875f24d1f9ef6620b033b5179633589da) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/VirtualShelves.pm | 11 ----------- 1 file changed, 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:37:35 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:37:35 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-89-gf5e8df8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via f5e8df8e4b60ab70ab524c6dab2ec4c7d55539f8 (commit) from 84a9b3192e82484dba6cbe041028b0c8818eb41b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f5e8df8e4b60ab70ab524c6dab2ec4c7d55539f8 Author: Jonathan Druart Date: Tue Feb 18 15:07:38 2014 +0100 Bug 11471: Display the currency for baskets in a basketgroup On editing a basketgroup, the currency for baskets in a basketgroup is always '0'. With this patch, the currency is correctly displayed. TEST PLAN ========= 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box 4) Click '+ New basket' because a vendor name 5) Type 'Test Basket' into basket name 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box 10) Click 'Search' 11) Click 'Order' on any one of the results 12) Click 'Add Item' in the 'Item' box 13) Select a Fund from the dropdown in the 'Accounting details' box 14) Click 'Save' 15) Click 'Close the basket' 16) Click 'Yes, close (Y)' without checking attach to a basket group 17) Click the 'Basket groups' tab 18) Click '+ New basket group' 19) Notice the listing in the 'Ungrouped baskets'. 20) Drag and drop the entry into the 'Baskets in this group' text area 21) Click 'Save' 22) Click 'Edit' 23) Notice it displays incorrectly. (e.g. Total: 0 0) 24) Apply the patch (git bz apply 11471) 25) Refresh the page 26) Notice it displays the currency correctly. (e.g. Total: 0 USD) NOTE: If there is a space issue, see Bug 9654. This can be applied separately from that bug. 27) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 7a2dec05eddc979b5a957a651e393838c13560c4) Signed-off-by: Fridolin Somers Conflicts: acqui/basketgroup.pl ----------------------------------------------------------------------- Summary of changes: acqui/basketgroup.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:42:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:42:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-90-g1aaee6f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1aaee6fbf1693d24810928cadcdeb4f3a48fd78e (commit) from f5e8df8e4b60ab70ab524c6dab2ec4c7d55539f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1aaee6fbf1693d24810928cadcdeb4f3a48fd78e Author: Owen Leonard Date: Tue Feb 18 15:37:31 2014 -0500 Bug 11789 - Use validation plugin when creating new list The page for adding a new list includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Other edits: Minor validation fixes. To test, apply the patch and go to Lists -> New list. Try submitting the form without entering a list name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing list should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 4677bb52616794457f616571479aab6425be75f9) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/virtualshelves/shelves.tt | 41 +++++++------------- 1 file changed, 13 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:44:37 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:44:37 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-91-gc905704 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via c9057046766fc695385449766d29e011d08de574 (commit) from 1aaee6fbf1693d24810928cadcdeb4f3a48fd78e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c9057046766fc695385449766d29e011d08de574 Author: Marcel de Rooy Date: Thu Feb 20 19:39:10 2014 +0100 Bug 11803: use $dbh consistently in _koha_modify_item This is just some code cleanup, no behavior change expected. Also replacing errstr with err in testing the results. (See DBI.) Test plan: Modify an item and save it. Followed test plan. No problems found. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit a07b32f4f9090ba0c50c3e510f0be56b8805faeb) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 10:57:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 08:57:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-92-g0092cd7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 0092cd702e706a3564bcfd1dcdc1457615c09bb1 (commit) from c9057046766fc695385449766d29e011d08de574 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0092cd702e706a3564bcfd1dcdc1457615c09bb1 Author: Owen Leonard Date: Fri Feb 21 09:22:50 2014 -0500 Bug 10751: standardize validation of title in staff purchase suggestions form The form for adding a new purchase suggestion in the staff client indicates that the title field is required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Acquisitions -> Suggestions -> New purchase suggestion. Try submitting the form without entering a title. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing suggestion should also work correctly. The patch displays a message 'Required' near the title field. After submitting a empty title it changes to 'This field is required' Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart The title field is required since commit d565fb02e9fca2ac9c506e4e7d44fd8b0d66f06a This one makes it more consistent with formatting. It makes sense. Signed-off-by: Galen Charlton (cherry picked from commit 59b9078a3f7cf240bd814ee611e8f553d043491e) Signed-off-by: Fridolin Somers Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 11:01:15 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 09:01:15 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-93-gd56d855 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via d56d855914fbb6fc512fdffe86961822680176b6 (commit) from 0092cd702e706a3564bcfd1dcdc1457615c09bb1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d56d855914fbb6fc512fdffe86961822680176b6 Author: Fridolin Somers Date: Fri Feb 7 10:13:39 2014 +0100 Bug 11707: fix editing additional attributes for patron whose category code includes a space When editing additional attributes of a patron of a category with a code with space (ie "CAT 3"), the Javascript is broken and Additional attributes are not displayed. This patch corrects by adding simple quotes around category code in JS code. Test plan : - Create an patron additional attribute - Create a new patron category with a space in code. ie "CAT 3" - Create a new patron of this category : /cgi-bin/koha/members/memberentry.pl?op=add&categorycode=CAT 3 => Without patch the JS is broken (Syntax error, unrecognized expression: [data-category_code=CAT 3]) and additional attributes are not displayed. => With patch the JS is not broken and additional attributes are displayed and can be edited. Signed-off-by: Marc V?ron In current Koha version it is not possible to create category codes with blanks. To test, I changed an existing category code directly in the database. Then I followed the Test plan. Without patch, attribute types were not displayed. With patch, they were displayed as expected. Signed-off-by: Katrin Fischer I recommend not using codes with spaces and fix existing ones. Koha doesn't allow you to add category codes with spaces, so the only way to do it is via SQL. This patch fixes a problem and passes all tests. Signed-off-by: Galen Charlton (cherry picked from commit 521d7173720b4acbf4ecf40ed114520d500c5f6a) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 11:07:11 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 09:07:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-94-g2579238 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 257923800cdc7e87b2ae29a1e98b502fe7b8b3c6 (commit) from d56d855914fbb6fc512fdffe86961822680176b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 257923800cdc7e87b2ae29a1e98b502fe7b8b3c6 Author: Owen Leonard Date: Fri Feb 21 14:52:22 2014 -0500 Bug 11819 - Don't show catalog edit menu if user has no edit permissions Currently if the logged in user lacks any cataloging permissions the bibliographic detail page (catalogue/detail.pl) still shows the Edit button, but with an empty dropdown menu. This patch corrects the toolbar include so that the button will not appear at all. To test, view the biblio detail page as a user with various combinations of the following permissions: - edit_items - edit_catalogue - items_batchmod - items_batchdel The edit button should appear with the correct set of links when the user has any combination of the above permissions. If user has none the button should not appear. Followed test plan, patch behaves as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as expected, passes all tests and QA script. Template only change. Signed-off-by: Galen Charlton (cherry picked from commit a8ebfa4702e2492388b6f60a11921a8ab69d677b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 11:15:26 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 09:15:26 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-95-gbfd2ea3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via bfd2ea3efe77805182bfa5dc7daa88ffdfb7fb5e (commit) from 257923800cdc7e87b2ae29a1e98b502fe7b8b3c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bfd2ea3efe77805182bfa5dc7daa88ffdfb7fb5e Author: Owen Leonard Date: Fri Feb 7 15:24:06 2014 -0500 Bug 11717 - Use new DataTables include in member templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all member pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Patron details (members/moremember.pl) - The checkouts, relatives' checkouts, and holds tables have been modified to exclude articles when sorting of titles. - Notices (members/notices.pl) - Circulation history (members/readingrec.pl) - Statistics (members/statistics.pl) - Update child to adult patron (members/update-child.pl) - This is the page which appears in a pop-up when you update a child patron to an adult (from the "More" menu in the toolbar when viewing patron details). Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit a31bf519a9aff560f3157ad7821be3a0afe3d98f) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/moremember.tt | 12 +++++------- koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt | 4 +--- .../intranet-tmpl/prog/en/modules/members/readingrec.tt | 6 ++---- .../intranet-tmpl/prog/en/modules/members/statistics.tt | 6 ++---- .../intranet-tmpl/prog/en/modules/members/update-child.tt | 6 ++---- 5 files changed, 12 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 11:32:19 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 09:32:19 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-96-gb4d0404 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via b4d04043eddc42aa098ae21204164582d3b5444e (commit) from bfd2ea3efe77805182bfa5dc7daa88ffdfb7fb5e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b4d04043eddc42aa098ae21204164582d3b5444e Author: Owen Leonard Date: Fri Feb 7 11:35:17 2014 -0500 Bug 11710 - Use new DataTables include in cataloging Z39.50 search template This patch modifies the template for the cataloging Z39.50 search template to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. To test, go to cataloging and choose "New from Z39.50." Perform a search and confirm that table sorting still works correctly. Signed-off-by: wajasu Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 18d5f288040fdf2d2b65b569685d60a11d3b86fc) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 11:39:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 09:39:18 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-97-g8e3eb1d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 8e3eb1de412755553006116d0ccfc5d919706aeb (commit) from b4d04043eddc42aa098ae21204164582d3b5444e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e3eb1de412755553006116d0ccfc5d919706aeb Author: Owen Leonard Date: Fri Feb 7 14:54:27 2014 -0500 Bug 11716 - Use new DataTables include in label manage template This patch modifies the template for the label manage pages to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. To test, view the following pages and confirm that table sorting is working correctly: Manage layouts (/cgi-bin/koha/labels/label-manage.pl?label_element=layout) Manage templates (/cgi-bin/koha/labels/label-manage.pl?label_element=template) Manage profiles (/cgi-bin/koha/labels/label-manage.pl?label_element=profile) Manage batches (/cgi-bin/koha/labels/label-manage.pl?label_element=batch) Signed-off-by: wajasu Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 3fc7ea191c45ea430f362e4a883a34ebfbd0c330) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 11:48:48 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 09:48:48 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-98-gbe5c3c1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via be5c3c1f4a19f4a06e3faba91f45cfb7da328436 (commit) from 8e3eb1de412755553006116d0ccfc5d919706aeb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit be5c3c1f4a19f4a06e3faba91f45cfb7da328436 Author: Owen Leonard Date: Mon Feb 10 14:13:11 2014 -0500 Bug 11736 - Use new DataTables include in Koha news templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Koha news page. To test you should have existing news items with varying creation and expiration dates. Apply the patch and confirm that table sorting works correctly for all settings of the dateformat system preference. C4::NewsChannels.pm has been modified so that it now passes an unformatted date to the template, where the KohaDates plugin is used to apply the correct formatting. Sorting is based on the unformatted date. Also corrected: Capitalization errors. Signed-off-by: wajasu Signed-off-by: Katrin Fischer Works as described, no problems found. Also passes tests and QA script. Signed-off-by: Galen Charlton (cherry picked from commit a4a014e365a6d27d1105096861a19f94aa5372f7) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/NewsChannels.pm | 2 -- .../intranet-tmpl/prog/en/modules/tools/koha-news.tt | 17 +++++++++-------- 2 files changed, 9 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 11:54:29 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 09:54:29 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-99-g90cce3c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 90cce3c059f63be213aa665377d1b6221c4c4ca1 (commit) from be5c3c1f4a19f4a06e3faba91f45cfb7da328436 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 90cce3c059f63be213aa665377d1b6221c4c4ca1 Author: Owen Leonard Date: Thu Feb 20 15:42:37 2014 -0500 Bug 11805 - Use validation plugin when creating new basket in Acquisitions The page for adding a new basket in Acquisitions includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Acquisitions -> Choose a vendor -> New basket. Try submitting the form without entering a basket name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing basket should also work correctly. Patch works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as expected, passes all tests and QA script. Tried adding a new basket with/without basket name and editing an existing basket editing/emptying the basket name. Signed-off-by: Galen Charlton (cherry picked from commit cd089028b8c5e8f2b15ed2d41ce79bb37873662d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/acqui/basketheader.tt | 27 +++----------------- 1 file changed, 4 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 21 20:57:08 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 21 May 2014 18:57:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-rc-3-g09c4d12 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 09c4d12d73194aeeb3d26ff3df33edb1ee467002 (commit) via 8ec1ffafea89fcb98d67e090a799398a434af18d (commit) from 3f9a8ccc18c8d97ac4167e313f4d3a685a9000dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 09c4d12d73194aeeb3d26ff3df33edb1ee467002 Author: Jonathan Druart Date: Tue May 20 13:39:26 2014 +0200 Bug 12274: Invoice detail: don't crash on certain billing dates Bug 10613 sent the billingdate as a string. The template wants a DateTime object. To reproduce: 1/ Go on a invoice detail page 2/ Select a billing date 3/ Boom without the patch [Tue May 20 13:39:18 2014] invoice.pl: Template process failed: undef error - The 'day' parameter ("2014") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Not all dates will make it go 'boom' but 31/07/2014 did. Signed-off-by: Galen Charlton commit 8ec1ffafea89fcb98d67e090a799398a434af18d Author: Jacek Ablewicz Date: Sat May 17 10:30:15 2014 +0200 Bug 12274: handle closed invoices properly on invoice details page Trivial fix for small regression (closed invoices are displayed as "Open" on details page, and it's not possible to reopen the closed invoice using "Save" button) introduced by bug 10613. Test plan: 1) Create and close some invoices 2) Note that closed invoices are erroneously displayed as "Open" on individual invoice[s] details page 3) Apply patch 4) Check previously closed invoices; their status on details page should now be properly displayed as "Closed on ..." (and an option for reopening would reappear as well) 5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button do work as expected for individual open / closed invoices respectivelly. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Works as described. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: acqui/invoice.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 16:09:30 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 14:09:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-rc-4-g6b92843 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6b928438ce06f7f7d664766b8206001c57bea817 (commit) from 09c4d12d73194aeeb3d26ff3df33edb1ee467002 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b928438ce06f7f7d664766b8206001c57bea817 Author: Bernardo Gonzalez Kriegel Date: Thu May 22 09:39:57 2014 -0300 Translation updates for 3.16.00 final release Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: misc/translator/po/am-Ethi-pref.po |55350 +---------- .../po/ar-Arab-i-opac-t-prog-v-3006000.po | 60 +- misc/translator/po/ar-Arab-pref.po |65156 +------------ misc/translator/po/az-AZ-pref.po |73140 +------------- misc/translator/po/be-BY-pref.po |18122 +--- misc/translator/po/ben-pref.po |61384 +----------- misc/translator/po/bg-Cyrl-pref.po |40644 +------- .../po/ca-ES-i-staff-t-prog-v-3006000.po | 20 +- misc/translator/po/ca-ES-opac-bootstrap.po | 86 +- misc/translator/po/ca-ES-pref.po |42690 +------- .../translator/po/cs-CZ-i-opac-t-prog-v-3006000.po | 12 +- .../po/cs-CZ-i-staff-t-prog-v-3006000.po | 962 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 35 +- misc/translator/po/cs-CZ-pref.po |91042 +---------------- misc/translator/po/cs-CZ-staff-help.po | 219 +- misc/translator/po/da-DK-pref.po |35446 +------ .../po/de-CH-i-staff-t-prog-v-3006000.po | 8 +- misc/translator/po/de-CH-pref.po |55960 ++--------- .../translator/po/de-DE-i-opac-t-prog-v-3006000.po | 8 +- .../po/de-DE-i-staff-t-prog-v-3006000.po | 12 +- misc/translator/po/de-DE-opac-bootstrap.po | 8 +- misc/translator/po/de-DE-pref.po |53366 +--------- misc/translator/po/en-GB-pref.po |93624 +----------------- misc/translator/po/en-NZ-opac-bootstrap.po | 130 +- misc/translator/po/en-NZ-pref.po | 110 +- .../translator/po/es-ES-i-opac-t-prog-v-3006000.po | 2 +- .../po/es-ES-i-staff-t-prog-v-3006000.po | 42 +- misc/translator/po/es-ES-opac-bootstrap.po | 2077 +- misc/translator/po/es-ES-staff-help.po | 145 +- misc/translator/po/eu-pref.po |91760 +----------------- misc/translator/po/fa-Arab-pref.po |98730 +------------------ .../po/fi-FI-i-staff-t-prog-v-3006000.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-pref.po |27928 +----- misc/translator/po/fr-CA-pref.po |23342 +---- .../po/fr-FR-i-staff-t-prog-v-3006000.po | 18 +- misc/translator/po/fr-FR-pref.po | 2668 - misc/translator/po/gl-i-opac-t-prog-v-3006000.po | 2 +- misc/translator/po/gl-pref.po |13652 +-- misc/translator/po/he-Hebr-pref.po |70610 +------------- misc/translator/po/hi-pref.po |40834 +------- misc/translator/po/hr-HR-pref.po |24082 +---- misc/translator/po/hu-HU-pref.po |82534 +--------------- misc/translator/po/hy-Armn-pref.po |85680 +--------------- misc/translator/po/id-ID-pref.po |97344 +------------------ misc/translator/po/is-IS-pref.po |66006 +------------ misc/translator/po/it-IT-pref.po |62890 ++---------- misc/translator/po/ja-Jpan-JP-pref.po |56338 +---------- misc/translator/po/kn-Knda-pref.po |76100 +-------------- misc/translator/po/ko-Kore-KP-pref.po |37138 +------ misc/translator/po/ku-pref.po |67816 +------------ misc/translator/po/lo-Laoo-pref.po |83680 +--------------- misc/translator/po/mi-NZ-pref.po |28494 +----- misc/translator/po/mon-pref.po |87218 +---------------- misc/translator/po/mr-pref.po |68520 +------------ misc/translator/po/ms-MY-pref.po | 1334 - .../po/nb-NO-i-staff-t-prog-v-3006000.po | 2202 +- misc/translator/po/nb-NO-opac-bootstrap.po | 131 +- misc/translator/po/nb-NO-pref.po | 1 - misc/translator/po/ne-NE-pref.po |26592 +---- misc/translator/po/nl-BE-pref.po |47572 +-------- misc/translator/po/nl-NL-pref.po |67316 +------------ misc/translator/po/nn-NO-pref.po |53368 +--------- misc/translator/po/pbr-pref.po | 5336 - misc/translator/po/pl-PL-pref.po |31874 +----- misc/translator/po/prs-pref.po |38244 +------- misc/translator/po/pt-BR-opac-bootstrap.po | 27 +- misc/translator/po/pt-BR-pref.po | 8066 +- misc/translator/po/pt-PT-pref.po | 6698 +- misc/translator/po/ro-RO-pref.po |60690 +----------- misc/translator/po/ru-RU-pref.po | 9470 +- .../translator/po/rw-RW-i-opac-t-prog-v-3006000.po | 2 +- .../po/rw-RW-i-staff-t-prog-v-3006000.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-pref.po |34322 +------ misc/translator/po/sd-PK-pref.po |96852 +------------------ .../translator/po/sk-SK-i-opac-t-prog-v-3006000.po | 10 +- .../po/sk-SK-i-staff-t-prog-v-3006000.po | 1273 +- misc/translator/po/sk-SK-pref.po |50716 +--------- misc/translator/po/sl-SI-pref.po |48082 +-------- misc/translator/po/sq-AL-pref.po |63640 +----------- misc/translator/po/sr-Cyrl-pref.po |54488 +---------- misc/translator/po/sv-SE-pref.po |101886 +------------------- .../translator/po/sw-KE-i-opac-t-prog-v-3006000.po | 2 +- .../po/sw-KE-i-staff-t-prog-v-3006000.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-pref.po |10672 -- misc/translator/po/ta-LK-pref.po |79126 +-------------- misc/translator/po/ta-pref.po |68918 +------------ misc/translator/po/tet-pref.po |38716 +------- misc/translator/po/th-TH-pref.po |80274 +-------------- misc/translator/po/tl-PH-pref.po |87382 +---------------- .../po/tr-TR-i-staff-t-prog-v-3006000.po | 40 +- misc/translator/po/tr-TR-opac-bootstrap.po | 226 +- misc/translator/po/tr-TR-pref.po |92398 +----------------- misc/translator/po/tr-TR-staff-help.po | 21 +- misc/translator/po/uk-UA-pref.po |33206 +------ misc/translator/po/ur-Arab-pref.po | 4004 +- misc/translator/po/vi-VN-pref.po |94710 +----------------- misc/translator/po/zh-Hans-CN-pref.po |77316 +-------------- .../po/zh-Hans-TW-i-staff-t-prog-v-3006000.po | 8 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 6 +- misc/translator/po/zh-Hans-TW-pref.po |82590 +--------------- 103 files changed, 225617 insertions(+), 3317446 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 18:30:02 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 16:30:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-rc-5-ga672240 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a672240a7575d25c554cbbf003abee00aa3f7e89 (commit) from 6b928438ce06f7f7d664766b8206001c57bea817 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a672240a7575d25c554cbbf003abee00aa3f7e89 Author: Jonathan Druart Date: Tue May 20 16:07:17 2014 +0200 Bug 12292: ensure that patrons are not displayed as restricted even when the last restriction has expired This is the same issue as bug 12134, but for the patron deatils page. Test Plan: 1) Add a manual restriction to a patron and wait until the expiration date of the restriction has passed. This can be simulated by modifying borrowers.debarred for a borrower and setting the date in the past. 2) Go on the detail page for a patron (members/moremember.pl) 3) Note the warning message "Patron is restricted until XX/XX/XXXX View restrictions" 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: members/moremember.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 21:51:15 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 19:51:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-rc-7-g3c1c323 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3c1c323de47b9265fd2ac925e68998043ce9afc2 (commit) via 7cfa7291227e1e4035bde0743a03b47f3a13fc5d (commit) from a672240a7575d25c554cbbf003abee00aa3f7e89 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3c1c323de47b9265fd2ac925e68998043ce9afc2 Author: Galen Charlton Date: Thu May 22 20:16:25 2014 +0000 update release notes for 3.16.0 (human) Manual edit of the release notes to hopefully make them more useful. Also added reminder about the deprecation of the prog and CCSR public catalog themes. Signed-off-by: Galen Charlton commit 7cfa7291227e1e4035bde0743a03b47f3a13fc5d Author: Galen Charlton Date: Thu May 22 17:11:19 2014 +0000 update of release notes for 3.16.0 (automatic) Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_3_16_0.txt | 1634 +++++++++++++++------------ 1 file changed, 908 insertions(+), 726 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 22:06:09 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 20:06:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-rc-8-g50078d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 50078d04c6c3e3e85d6f8ed3645368f7a69402e5 (commit) from 3c1c323de47b9265fd2ac925e68998043ce9afc2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 50078d04c6c3e3e85d6f8ed3645368f7a69402e5 Author: Galen Charlton Date: Thu May 22 20:28:23 2014 +0000 stamp Koha 3.16.0 Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 6 ++++++ kohaversion.pl | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 22:06:20 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 20:06:20 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.16.00 created. v3.16.00 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.16.00 has been created at 6c079fe107eaf1fb3a387ae2204e35ece41130ee (tag) tagging 50078d04c6c3e3e85d6f8ed3645368f7a69402e5 (commit) replaces v3.16.00-rc tagged by Galen Charlton on Thu May 22 20:29:57 2014 +0000 - Log ----------------------------------------------------------------- Koha release 3.16.0 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlN+XkUACgkQ+ECRQ8R3E0MseQCgpgOXYXgemBnfxKXU9ZUFOjig 620An1QWHoYdkpXLO+BPP25TyBqonyeZ =ganD -----END PGP SIGNATURE----- Bernardo Gonzalez Kriegel (1): Translation updates for 3.16.00 final release Galen Charlton (3): update of release notes for 3.16.0 (automatic) update release notes for 3.16.0 (human) stamp Koha 3.16.0 Jacek Ablewicz (1): Bug 12274: handle closed invoices properly on invoice details page Jonathan Druart (2): Bug 12274: Invoice detail: don't crash on certain billing dates Bug 12292: ensure that patrons are not displayed as restricted even when the last restriction has expired Katrin Fischer (1): Bug 12282: fix RESERVESLIP in German sample notices ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 22:37:35 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 20:37:35 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x created. v3.16.00 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been created at 50078d04c6c3e3e85d6f8ed3645368f7a69402e5 (commit) - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 22:42:37 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 20:42:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-1-g18c0ba9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 18c0ba94845324b232fdb3473987b70d1c756f67 (commit) from 50078d04c6c3e3e85d6f8ed3645368f7a69402e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 18c0ba94845324b232fdb3473987b70d1c756f67 Author: Galen Charlton Date: Thu May 22 21:08:20 2014 +0000 DBRev 3.17.00.000: ever onward Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 6 ++++++ kohaversion.pl | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 22:50:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 20:50:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-4-g68fd61f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 68fd61fe9f709eb677498e59f03c03a29c28f311 (commit) via ef00aeb33a92743563af4a30012ce3547aed76e0 (commit) via 3046d719f10b8581543cee83a7fdb903d1a15e7f (commit) from 18c0ba94845324b232fdb3473987b70d1c756f67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 68fd61fe9f709eb677498e59f03c03a29c28f311 Author: Fridolin Somers Date: Wed May 7 17:58:45 2014 +0200 Bug 12211: fix wrong home link in bootstrap public catalog login page In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl Signed-off-by: Bernardo Gonzalez Kriegel Link ok, no errors. Signed-off-by: Katrin Fischer Works as described. Signed-off-by: Galen Charlton commit ef00aeb33a92743563af4a30012ce3547aed76e0 Author: Owen Leonard Date: Fri May 2 14:33:54 2014 -0400 Bug 12106: fix capitalization: "Patron Attributes" on tools/patron import There are three instances of incorrectly-capitalized "Patron Attributes" on the patron import page. This patch corrects them. To test, view the patron import page (Tools -> Import patrons). Confirm that instances of the phrase "patron attributes" in the bottom-most fieldset are correctly capitalized. Followed test plan, works Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit 3046d719f10b8581543cee83a7fdb903d1a15e7f Author: Galen Charlton Date: Tue May 6 17:52:35 2014 +0000 Bug 12184: fix typo "retricted" on checkin page To test: [1] Check an item that belongs to a restricted patron and specify a non-default return date. [2] Verify that the warning message contains "restricted" rather than "retricted". Signed-off-by: Galen Charlton Signed-off-by: Magnus Enger Patch applies and makes sense. (I have not checked the actual UI, but that should not be necessary for such a simple typo correction.) Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- .../intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 22:50:01 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 20:50:01 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.00-3-gc5de0df Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via c5de0df104c65289a04d7d16f5b56daa7667b13b (commit) via b11371f672bb11b74b2cd283bcdae4640a8ee296 (commit) via c85f0081adea46689c80fe8e08df3f71b2d6b819 (commit) from 50078d04c6c3e3e85d6f8ed3645368f7a69402e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c5de0df104c65289a04d7d16f5b56daa7667b13b Author: Fridolin Somers Date: Wed May 7 17:58:45 2014 +0200 Bug 12211: fix wrong home link in bootstrap public catalog login page In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl Signed-off-by: Bernardo Gonzalez Kriegel Link ok, no errors. Signed-off-by: Katrin Fischer Works as described. Signed-off-by: Galen Charlton commit b11371f672bb11b74b2cd283bcdae4640a8ee296 Author: Owen Leonard Date: Fri May 2 14:33:54 2014 -0400 Bug 12106: fix capitalization: "Patron Attributes" on tools/patron import There are three instances of incorrectly-capitalized "Patron Attributes" on the patron import page. This patch corrects them. To test, view the patron import page (Tools -> Import patrons). Confirm that instances of the phrase "patron attributes" in the bottom-most fieldset are correctly capitalized. Followed test plan, works Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit c85f0081adea46689c80fe8e08df3f71b2d6b819 Author: Galen Charlton Date: Tue May 6 17:52:35 2014 +0000 Bug 12184: fix typo "retricted" on checkin page To test: [1] Check an item that belongs to a restricted patron and specify a non-default return date. [2] Verify that the warning message contains "restricted" rather than "retricted". Signed-off-by: Galen Charlton Signed-off-by: Magnus Enger Patch applies and makes sense. (I have not checked the actual UI, but that should not be necessary for such a simple typo correction.) Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- .../intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 23:21:16 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 21:21:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-6-g82791bf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 82791bfecd9b27bc368946c734b6bf28e7e3bd84 (commit) via 8cf9be4f10c7c22ebec797dc57ffe1e37eb6f171 (commit) from 68fd61fe9f709eb677498e59f03c03a29c28f311 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 82791bfecd9b27bc368946c734b6bf28e7e3bd84 Author: Marc V?ron Date: Thu Apr 10 08:42:46 2014 +0200 Bug 10936: (prog theme) remove duplicate 'Standard number' option in Advanced search TEST PLAN --------- 1) Set opacthemes system preference to prog 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time Signed-off-by: Bernardo Gonzalez Kriegel Work as described on prog theme, no more duplicate. No koha-qa errors Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 8cf9be4f10c7c22ebec797dc57ffe1e37eb6f171 Author: Jesse Maseto Date: Fri Mar 28 11:02:18 2014 -0400 Bug 10936: remove duplicate 'Standard number' option in Advanced search This patch removes the duplicate 'Standard number' option under the more options of the OPAC advanced search correctly following updates from Katrin. TEST PLAN --------- 1) Set opacthemes system preference to bootstrap 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 3 +-- koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 22 23:21:16 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 22 May 2014 21:21:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.00-5-g6ae855d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 6ae855d725d5a64e833542d91dfa09c49f049b4a (commit) via 58a9b3aa49cbc81fb8867c77fa2f01c91fa8a7f3 (commit) from c5de0df104c65289a04d7d16f5b56daa7667b13b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ae855d725d5a64e833542d91dfa09c49f049b4a Author: Marc V?ron Date: Thu Apr 10 08:42:46 2014 +0200 Bug 10936: (prog theme) remove duplicate 'Standard number' option in Advanced search TEST PLAN --------- 1) Set opacthemes system preference to prog 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time Signed-off-by: Bernardo Gonzalez Kriegel Work as described on prog theme, no more duplicate. No koha-qa errors Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton commit 58a9b3aa49cbc81fb8867c77fa2f01c91fa8a7f3 Author: Jesse Maseto Date: Fri Mar 28 11:02:18 2014 -0400 Bug 10936: remove duplicate 'Standard number' option in Advanced search This patch removes the duplicate 'Standard number' option under the more options of the OPAC advanced search correctly following updates from Katrin. TEST PLAN --------- 1) Set opacthemes system preference to bootstrap 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 3 +-- koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 23 14:44:29 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 May 2014 12:44:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-7-g3de4948 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3de4948bdad26dda9e8122054c87ad448352ebc8 (commit) from 82791bfecd9b27bc368946c734b6bf28e7e3bd84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3de4948bdad26dda9e8122054c87ad448352ebc8 Author: Galen Charlton Date: Tue May 6 20:24:52 2014 +0000 Bug 12190: fold the "Creators" system preference tab into "Tools" The "Creators" tab in the system preferences editor had only one preference. In order to consolidate the display as well as to address the issue that "creators" doesn't have much of a connection to "patron cards", the ImageLimit system preference is moved to the Tools tab by this patch. To test: [1] Verify that the ImageLimit preference now shows up in the Tools tab in the system preference editor (along with an existing Tools preference, MaxItemsForBatch. [2] Verify that the sysprefs editor no longer has a "Creators" tab. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/prefs-menu.inc | 1 - .../prog/en/modules/admin/preferences/creators.pref | 7 ------- .../prog/en/modules/admin/preferences/tools.pref | 17 ++++++++++++----- .../prog/en/modules/help/admin/preferences.tt | 3 +-- 4 files changed, 13 insertions(+), 15 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/creators.pref hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 23 14:57:00 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 May 2014 12:57:00 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.00-7-gf9d481e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via f9d481e513e6d5794309517ff036ff1714130d7e (commit) via 07ad0dba705365b567e711504b90fac8ca578398 (commit) from 6ae855d725d5a64e833542d91dfa09c49f049b4a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f9d481e513e6d5794309517ff036ff1714130d7e Author: Jonathan Druart Date: Thu May 22 13:00:07 2014 +0200 Bug 12023: (follow-up) fix redirect to step 3 This patch fixes the redirection to step 3. If you go on installer/install.pl and Koha is already installed, you should be redirected to the step 3. Without this patch, the script raised an internal error (500). Signed-off-by: Jonathan Druart Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton commit 07ad0dba705365b567e711504b90fac8ca578398 Author: Robin Sheat Date: Wed Apr 2 17:20:08 2014 +1300 Bug 12023 - move InstallAuth.pm to be in C4 InstallAuth was in the installer directory, which meant that Plack was unable to find it, and so running the webinstaller would fail. This moves it into C4, Test plan: * Make sure the web installer runs under plack * Make sure the web installer runs under non-plack Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: {installer => C4}/InstallAuth.pm | 5 +---- installer/install.pl | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) rename {installer => C4}/InstallAuth.pm (99%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 23 14:57:02 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 May 2014 12:57:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-9-g62a061a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 62a061a15753c892b72b434ae8764044c9f1baed (commit) via c2391b796bf9f519291f8597801dca2155ba250b (commit) from 3de4948bdad26dda9e8122054c87ad448352ebc8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 62a061a15753c892b72b434ae8764044c9f1baed Author: Jonathan Druart Date: Thu May 22 13:00:07 2014 +0200 Bug 12023: (follow-up) fix redirect to step 3 This patch fixes the redirection to step 3. If you go on installer/install.pl and Koha is already installed, you should be redirected to the step 3. Without this patch, the script raised an internal error (500). Signed-off-by: Jonathan Druart Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton commit c2391b796bf9f519291f8597801dca2155ba250b Author: Robin Sheat Date: Wed Apr 2 17:20:08 2014 +1300 Bug 12023 - move InstallAuth.pm to be in C4 InstallAuth was in the installer directory, which meant that Plack was unable to find it, and so running the webinstaller would fail. This moves it into C4, Test plan: * Make sure the web installer runs under plack * Make sure the web installer runs under non-plack Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: {installer => C4}/InstallAuth.pm | 5 +---- installer/install.pl | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) rename {installer => C4}/InstallAuth.pm (99%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 23 15:04:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 May 2014 13:04:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-12-gc6ae9ef Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c6ae9efbc371d30824022612020cf58e5b92b9fd (commit) via 4219063f341f0e7305501abc27f9f20537d4718e (commit) via ad6d36776362a398a46acef0d00ca67a7d7a11c7 (commit) from 62a061a15753c892b72b434ae8764044c9f1baed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c6ae9efbc371d30824022612020cf58e5b92b9fd Author: Galen Charlton Date: Fri May 23 13:29:39 2014 +0000 Bug 10330: DBRev 3.17.00.001 Signed-off-by: Galen Charlton commit 4219063f341f0e7305501abc27f9f20537d4718e Author: Mark Tompsett Date: Thu Apr 10 00:13:29 2014 -0400 Bug 10330: (follow-up) fix missed case of authoritysep $ git grep authoritysep This showed: 1) the updatedatabase.pl script, as expected, 2) lots of po files, 3) a test file that was missed. TEST PLAN --------- 1) prove -v t/db_dependent/Search.t 2) Run koha QA test tools Signed-off-by: Bernardo Gonzalez Kriegel Work (both patches). Test pass. No koha-qa errors Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton commit ad6d36776362a398a46acef0d00ca67a7d7a11c7 Author: Kyle M Hall Date: Fri May 24 07:54:42 2013 -0400 Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 2 +- C4/Biblio.pm | 12 ++++++------ cataloguing/value_builder/unimarc_field_210c_bis.pl | 2 +- cataloguing/value_builder/unimarc_field_225a.pl | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 7 +++++++ .../prog/en/modules/admin/preferences/cataloguing.pref | 2 +- kohaversion.pl | 2 +- t/db_dependent/Search.t | 2 +- 9 files changed, 20 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 23 15:12:51 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 May 2014 13:12:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-13-gda3939b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via da3939ba7042c4e1cc68d074b402c4dba8ef3f21 (commit) from c6ae9efbc371d30824022612020cf58e5b92b9fd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit da3939ba7042c4e1cc68d074b402c4dba8ef3f21 Author: Owen Leonard Date: Mon May 12 10:25:38 2014 +0200 Bug 12147: Convert action links on invoices pages to a menu Prior to this patch, the column for displaying the action links was too narrow, leading to an ugly display. This patch groups "action" links into a menu as was done with Bug 11763. This patch also converts the date column sorting configuration to use header class instead of an index. This patch also corrects a couple of HTML markup errors: An improperly-closed and an improperly closed