[koha-commits] main Koha release repository branch master updated. v3.14.00-1014-ge50bccb
Git repo owner
gitmaster at git.koha-community.org
Fri May 2 22:54:31 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e50bccb9fb6aa4e97021c3cef622f8a548b67bc6 (commit)
via f3681addc3168cdc34eb2b3ba558b4bd786696a3 (commit)
via b967a82f1c25768e5bca1bb46cfa44fc5f25b353 (commit)
via e25c42715ae88bb3691fb660cd5039d68b1f6166 (commit)
via 3fabce47aeddde8a6eb0cafedbb984a018b8d20c (commit)
via 7ca4f590acf99089aa5423ec0f3d086540d4f390 (commit)
via 7f1bb7c6b2a0a4489d5ba2a4f42d2e60a645f510 (commit)
via b35931016392930ec502b6e3d37653bc93bf264b (commit)
via 6a06fc9b6c3fc8c150f8cb420b181cf49d3ef800 (commit)
via 08ed927dc182e5165eda1a3bed92e59729adad7b (commit)
via 76dde86fcea815565399cb3d6ac4ed3a653ba60a (commit)
via ca052b2558629052574c4a66425e9e6268392ca8 (commit)
via 04ac36aa7c8529871610bf2594acfc31a3b80db5 (commit)
via 9575986ed126cdcd550817fadaeb0d49a541a33c (commit)
via 9270f064635ee16910d2a3d1e3e491e6bac22976 (commit)
via 6b1c114cc698a2ff944a30eaa367a0c0ce4922a4 (commit)
via c4abafce3321785f55b504343a8ec8226100cbca (commit)
via abb3647d039d8ff88e0e3984b99861b73cdf9b19 (commit)
via 7e878d42a0039a176b63681b6593013c36c126c6 (commit)
via 777814a2608a2376cd44ce2b410bb0b7fa465190 (commit)
via 90c9510e0af070e9227050eae1e287cbe05b169e (commit)
via 3c581bad5a8ba8bb2fc29b9c8c5ac21bfbb1686a (commit)
via ca871ea334962296b209c3d38e7bd725a0109db3 (commit)
via 45a6e7efd1c0df56320055b8dd9c56ab6899197c (commit)
via 2d6fe5f63e79f37cf86c3e3885d32c38a6a6aa99 (commit)
via ca68b94c276d34e7bdf8ea5ceee26602379c4ebc (commit)
via c50c4d1e89c6565e50b2905fa4ad48922e327864 (commit)
via 06c12fd1999224c7126ca1d81b6fe7886eab51b9 (commit)
via a657ac6833894b5e0f584df2383cf5b9d0cb6265 (commit)
via b717e3d2df4c68947b4273f6e1716b1f1f1e5b6b (commit)
via 4138c35c0020956b8e13e1758e26413d0693ecf2 (commit)
via dc95637ef00cbd695034dcca6645551571f1907a (commit)
via e778fb80c118f3cf934268d29acf705b6eb398db (commit)
via d268d154f108c6922633b63e2abfdafead24fc69 (commit)
via cc8090b15ad511fe61a9250f0869430093b4fca6 (commit)
via 9ac4591de91dd21878fc94b644d74182f9a6db84 (commit)
via f7537bc9388313bc3c328288cc961f81c9a7b30d (commit)
via 7ae384a0b1ca177d76e841bf67a5bb27bd4a6488 (commit)
via f131dc6c3b3f800acdd985b0a20e1649a380e772 (commit)
via e421ec49259b42b75851218ce3d85e80cd590096 (commit)
via 82145411141c29c6c4b8849a1ae11fefb65ceabc (commit)
from 160ed321bee5806d9f58b064a27b1c31c9ae3fe4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e50bccb9fb6aa4e97021c3cef622f8a548b67bc6
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 21:17:49 2014 +0000
Bug 9016: (follow-up) standardize case of message transport type columns
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit f3681addc3168cdc34eb2b3ba558b4bd786696a3
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 21:11:30 2014 +0000
Bug 9016: (follow-up) treat missing transports for overdue notices as warnings
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit b967a82f1c25768e5bca1bb46cfa44fc5f25b353
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 21:01:45 2014 +0000
Bug 9016: (follow-up) treat missing transports for predue and item due notices as warnings, not fatal errors
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit e25c42715ae88bb3691fb660cd5039d68b1f6166
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 20:54:55 2014 +0000
Bug 9016: (follow-up) treat missing transports for hold available notices as warnings, not fatal errors
This patch fixes a situation where a patron that has preferences
set for transport of a notice via a method that is not supported
for that notice type can result in a failure. Rather than
make it a fatal error during checkin, simply log a warning and skip.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 3fabce47aeddde8a6eb0cafedbb984a018b8d20c
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 19:40:42 2014 +0000
Bug 9016: (follow-up) move insertAtCaret plugin out of language-specific directory
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 7ca4f590acf99089aa5423ec0f3d086540d4f390
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Feb 6 11:41:35 2014 +0100
Bug 11696: ensure that print overdue notices use the print template
This reordering avoids the case where a print notice is sent with an
email or sms template is no email or SMS is defined.
Test plan:
Check print, sms and email for an overdue rule
Don't define an email address and generate an overdue for a user
Define 3 templates for the notice used
Launch the cronjob script and verify the print notice is generated using
the print template.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 7f1bb7c6b2a0a4489d5ba2a4f42d2e60a645f510
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 19:30:51 2014 +0000
Bug 3.15.00.041: DBrev 11867
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit b35931016392930ec502b6e3d37653bc93bf264b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri May 2 17:03:56 2014 +0200
Bug 11867: (follow-up) Change the sql query in order to win beauty prices
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 6a06fc9b6c3fc8c150f8cb420b181cf49d3ef800
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Feb 27 14:57:55 2014 +0100
Bug 11867: MTT: Manage *_PHONE notices
The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should
be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE).
Test plan:
1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices
2/ Execute the update DB entry
3/ Verify the 3 notices have been merged into "phone" template of the
HOLD, PREDUE and OVERDUE notices
4/ Verify there is no regression in the Talking Tech feature (how?)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No koha-qa errors
Verified that notices are merged
TalkingTech_itiva_outbound.pl runs without problem... but can't produce
any output, may be not correctly configured (my setup), no warnings
nor log messages
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 08ed927dc182e5165eda1a3bed92e59729adad7b
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Fri Jan 3 15:29:48 2014 +0200
Bug 10833: (follow-up) add message transport type to a warning message
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 76dde86fcea815565399cb3d6ac4ed3a653ba60a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Sep 6 11:39:51 2013 +0200
Bug 10833: Multi transport types for advanced notices
Test plan:
- Choose 2 patrons P1 and P2
- Edit "Patron messaging preferences" and
check SMS + email with 2 days in advance for P1
check email with 5 days in advance for P2
- defined a message for the letter code PREDUE for sms and email
(tools/letters.pl).
- select 2 barcodes (B1, B2).
* checkout B1 to P1 with a due date = NOW - 2 days
* checkout B2 to P2 with a due date = NOW - 5 days
- into the mysql cli, note the value of unsent message:
select count(*) from message_queue where status != "send";
- launch the cronjob:
perl misc/cronjobs/advance_notices.pl -c
- retry the previous sql query, you should have X + 3 unsent messages
(depending of current checkouts in your DB!).
- view all unsent message:
select borrowernumber, letter_code, message_transport_type, content
from message_queue where status != "send";
You should see:
2 messages for P1, 1 for sms, 1 for email and the letter code PREDUE
1 message for P2, email and the letter code PREDUE
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit ca052b2558629052574c4a66425e9e6268392ca8
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 23 17:35:33 2014 +0200
Bug 10832: (follow-up) add the transport type in the warning message
If no template is defined for a letter and the needed MTT, we
should display the MTT.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 04ac36aa7c8529871610bf2594acfc31a3b80db5
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Feb 13 14:54:45 2014 +0100
Bug 10832: (follow-up) fix case where some print overdue notices were not being sent
If overdues should be sent to some patron (on the same branch), only the
first one was notified.
This patch fixes this issue.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 9575986ed126cdcd550817fadaeb0d49a541a33c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Sep 6 11:23:44 2013 +0200
Bug 10832: Multi transport types for overdue notices
Test plan:
- define some complex overdue rules (tools/overduerules.pl).
For example:
First overdue from 2 to 5 days by sms and email with letter code L1
Second overdue from 5 to 15 days by email with letter code L2
Third overdue from 15 days by print with letter code L3
- define a message for each transport type selected (tools/letters.pl).
- select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3).
* checkout B1 to P1 with a due date = NOW + 3 days
* checkout B2 to P2 with a due date = NOW + 10 days
* checkout B3 to P3 with a due date = NOW + 20 days
- into the mysql cli, note the value of unsent message:
select count(*) from message_queue where status != "send";
- launch the cronjob:
perl misc/cronjobs/overdue_notices.pl
- retry the previous sql query, you should have X + 4 unsent messages
(depending of current checkouts in your DB!).
- view all unsent message:
select borrowernumber, letter_code, message_transport_type, content
from message_queue where status != "send";
You should see:
2 messages for P1, 1 for sms, 1 for email and the letter code L1
1 message for P2, 1 for email and the letter code L2
1 message for P3, 1 for print and the letter code L3
- Specific case: If a user don't have a smsalertnumber and a sms is
required or if a user don't have an email defined and an email is
required, a print notice is generated.
A print notice is generated only 1 time per borrower and per level.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 9270f064635ee16910d2a3d1e3e491e6bac22976
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Wed Jan 15 16:25:17 2014 +0200
Bug 11561: restore previous behavior of generation of hold print notices
This patch prevents duplicate hold available print notices from being
sent and enforces making a print notice if no other transports can be
used.
-------------------------
- REPLICATING THE ISSUE -
-------------------------
1. Set a Patrons "Hold filled"-messaging preference to SMS + Email
2. Remove the SMS number (sms notification number) and all email
addresses.
3. Make a reservation for this Patron.
4. Check-in the reserved Item.
5. message_queue-table has two generated print notices for the
Hold_filled event.
One for both failed message transport types, email and sms.
1. Set a Patrons "Hold filled"-messaging preference to empty, remove all
checks from boxes.
2. Make a reservation for this Patron
3. Check-in the reserved Item.
4. message_queue-table has no message for the Hold-filled event. This is
problematic because a Patron should get some kind of a notification
for a filled Hold.
-----------------------------
- AFTER APPLYING THIS PATCH -
-----------------------------
If all message transport types for "Hold filled" fail, a print notice is
queued in the message_queue table. Only one print message is queued even
if many transports attempts fail.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 6b1c114cc698a2ff944a30eaa367a0c0ce4922a4
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 19:01:37 2014 +0000
Bug 10845: (follow-up) update how a test case counts print hold available notices
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit c4abafce3321785f55b504343a8ec8226100cbca
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 19:01:07 2014 +0000
Bug 10845: DBrev 3.15.00.040
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit abb3647d039d8ff88e0e3984b99861b73cdf9b19
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu May 1 15:41:31 2014 +0200
Bug 10845: (follow-up) fix message_transport_type parameter for Itiva cronjob
The message_transport_type param should passed to GetPreparedLetter, not
part of the "tables" parameter.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 7e878d42a0039a176b63681b6593013c36c126c6
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 23 16:48:54 2014 +0200
Bug 10845: (follow-up) add the MTT in the die message
If no template is defined for the HOLD letter and the needed MTT, we
should display the MTT.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 777814a2608a2376cd44ce2b410bb0b7fa465190
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Sep 9 16:58:22 2013 +0200
Bug 10845: Multi transport types for holds
The HOLD_PRINT and HOLD_PHONE notices become useless.
This patch modifies existing notices in order to group them into the
main notice type 'HOLD', with any pre-existing print and phone
templates in the appropriate places.
Test plan:
- Apply the patch and execute the update database entry.
- Verify that your previous HOLD_PHONE and HOLD_PRINT are displayed
when editing the HOLD notice (under phone and print).
- Choose a patron and check SMS, email, phone for "Hold filled"
(on the patron messaging preferences).
- Place a hold.
- Check the item in and confirm the hold.
- If the patron has an email *and* a SMS number, 2 new messages are put
into the message_queue table: 1 sms and 1 email.
If the patron does not have 1 of them, there are 2 new messages: 1
sms/email and 1 print.
If the user has neither of them, there is 1 new message: 1 print.
- The generated messages should correspond with the notices defined,
depending the message transport type.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Just noting that if email and SMS are disabled in the msg prefs, the user
will not have a print message.
And if the SMS driver fails, the record status in message_queue is 'failed',
but staff may not be aware of that.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 90c9510e0af070e9227050eae1e287cbe05b169e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Sep 9 17:12:21 2013 +0200
Bug 10845: Remove the notice code HOLD_PRINT in seed data
This patch converts the HOLD_PRINT notice to a HOLD notice
with a message transport type of 'print'.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 3c581bad5a8ba8bb2fc29b9c8c5ac21bfbb1686a
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 18:32:02 2014 +0000
Bug 11868: (follow-up) correct case of "SMS"
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit ca871ea334962296b209c3d38e7bd725a0109db3
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Feb 27 14:30:50 2014 +0100
Bug 11868: MTT: disable SMS and phone if not in use
On both pages "Notices and slips" and "Overdue rules", it would be great
to disable SMS and phone if there are not in use. This patch implements
this.
Test plan:
1/ Edit a notice
2/ Enable/disable the SMSSendDriver pref and verify the sms block is
enabled/disabled.
3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
the phone block is enabled/disabled.
4/ Go on tools/overdues.pl
5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes
are enabled/disabled.
6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
the phone checkboxes are enabled/disabled.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
---------------
Testing report:
---------------
Followed the test plan. Reviewed the code modifications.
Feature works as expected.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 45a6e7efd1c0df56320055b8dd9c56ab6899197c
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 18:05:09 2014 +0000
Bug 9016: (follow-up) update DBIC schema classes
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 2d6fe5f63e79f37cf86c3e3885d32c38a6a6aa99
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri May 2 18:03:37 2014 +0000
Bug 9016: DBRev 3.15.00.039
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit ca68b94c276d34e7bdf8ea5ceee26602379c4ebc
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Mar 28 09:50:11 2014 +0100
Bug 9016: (QA Follow-up) Remove warning from content.length test
If the letter.content is undef, the content.length test in the letter
template will trigger warning:
Argument "" isn't numeric in numeric gt (>).
This patch eliminates that warning.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit c50c4d1e89c6565e50b2905fa4ad48922e327864
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Mar 27 16:18:07 2014 +0100
Bug 9016: (follow-up) Improve number of characters display when mtt=sms
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 06c12fd1999224c7126ca1d81b6fe7886eab51b9
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Mar 27 16:01:22 2014 +0100
Bug 9016: (follow-up) Add some validation on the letter form
1/ Code and Name are mandatory.
2/ At least 1 template should be filled on saving.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit a657ac6833894b5e0f584df2383cf5b9d0cb6265
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Mar 27 16:00:57 2014 +0100
Bug 9016: (follow-up) FIX letter name is not displayed on editing a letter
If the name is not in email, the name is not correctly retrieved.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit b717e3d2df4c68947b4273f6e1716b1f1f1e5b6b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Mar 13 09:30:22 2014 +0100
Bug 9016: (follow-up) letter name is not displayed on editing a letter
On editing a letter, the letter name is not displayed. So if you save
it, the letter name is erased with an empty string.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Tested by setting the "Name"-field in letter.pl, saving, re-editing and verifying
that the email is present in the letter's "Name"-field.
The letter "Name" is replicated for each template in the DB, but that doesn't
incur any performance penalty.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 4138c35c0020956b8e13e1758e26413d0693ecf2
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Mar 12 18:42:40 2014 +0100
Bug 9016: (follow-up) additional mtt's name should be displayed in header
If you insert a new line in your message_transport_types table, the
overdues configuration table did not displayed an header.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit dc95637ef00cbd695034dcca6645551571f1907a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Mar 6 15:18:12 2014 +0100
Bug 9016: (follow-up) make GetLetters return all letters
GetLetters only returns letters with a mtt = email. It should return all
letter codes in the DB.
The message_transport_type parameter is never used.
To reproduce the issue:
Create a notice with a sms template and no email template.
Go on the overdue rules configucation page.
The notice does not appear in the notice list.
Signed-off-by: Olli-Antti Kivilahti <kivilahtio at ProBook6570b>
---------------
Testing report:
---------------
Testing this subroutine from a test stub. Calling the method without arguments
and with argument 'circulation' and 'circulat'.
Works as supposed to.
Related Bug 11931 discovered but not within the scope of this featureset.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit e778fb80c118f3cf934268d29acf705b6eb398db
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Feb 24 16:13:35 2014 +0100
Bug 9016: (follow-up) various fixes
* Fixes POD of GetMessageTransportTypes.
* Removes the useless map in GetMessageTransportTypes.
* Textual: "You must specify a title and a content" ->
"Please specify title and content".
* Reintroduces << and >> around the field name.
* Change message for the update DB entry.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit d268d154f108c6922633b63e2abfdafead24fc69
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Feb 7 08:54:24 2014 -0500
Bug 9016: (follow-up) add insertAtCaret library to about page
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit cc8090b15ad511fe61a9250f0869430093b4fca6
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Feb 3 14:15:38 2014 +0100
Bug 9016: (follow-up) fix some translate issues
On tools/letter.pl and tools/overduerules.pl, some strings were not
translatable. This patch should fix that.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 9ac4591de91dd21878fc94b644d74182f9a6db84
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Dec 16 09:48:39 2013 +0100
Bug 9016: (follow-up) fix tab characters and POD.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit f7537bc9388313bc3c328288cc961f81c9a7b30d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Nov 8 13:40:07 2013 +0100
Bug 9016: (follow-up) fix unit tests
The unit tests should insert overdue rules.
+ Fix the doc for GetOverdueMessageTransportTypes
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 7ae384a0b1ca177d76e841bf67a5bb27bd4a6488
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Sep 6 09:36:42 2013 +0200
Bug 9016: DB changes: new table overduerules_transport_types
This patch adds:
- a new table overduerules_transport_types.
- a new column letter.message_transport_type.
- a new primary key for letter.
- fill the new table with existing values.
Test plan:
After applying this patch and executing the updatedatabase entry, verify
that the overduerules_transport_types table contains a row for each
entry in the overduerules table.
The message_transport_type column should contain 'email'.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit f131dc6c3b3f800acdd985b0a20e1649a380e772
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Sep 9 16:52:29 2013 +0200
Bug 9016: (follow-up) GetMessageTransportTypes returns an arrayref, not hashref
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit e421ec49259b42b75851218ce3d85e80cd590096
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Sep 6 10:28:39 2013 +0200
Bug 9016: Define different transport types for overdues
This patch adds:
- a new routine C4::Overdues::GetOverdueMessageTransportTypes.
- the ability to define one or more transport types for an overdue
level.
Test plan:
- go on tools/overduerules.pl.
- verify that previous rules still exist and that the 'email' checkboxes
is checked if a rule is defined.
- redefined rules at different levels and check the transport type
needed. Currently, only email, sms and print are relevant
- Save the changes.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 82145411141c29c6c4b8849a1ae11fefb65ceabc
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Sep 6 10:27:04 2013 +0200
Bug 9016: Create a message for each transport type.
This patch adds:
- a new jquery plugin : insertatcaret.
- the ability to define a notice template for each transport type.
- a new routine C4::Letters::GetMessageTransportTypes.
Test plan:
- Go on tools/letter.pl and check that all existing notices are still
there.
- Modify one. A new empty message is present for sms, print, etc. The
email message is filled with the existant value.
- Add a message for sms for example (don't forget the subject) and save.
- edit again and verify the sms message has been saved.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 71 ++--
C4/Overdues.pm | 33 ++
C4/Reserves.pm | 69 ++--
Koha/Schema/Result/Letter.pm | 39 +-
Koha/Schema/Result/MessageTransportType.pm | 38 +-
Koha/Schema/Result/Overduerule.pm | 24 +-
Koha/Schema/Result/OverduerulesTransportType.pm | 145 +++++++
...-4246-Talking-Tech-itiva-phone-notifications.pl | 14 +-
.../data/mysql/de-DE/mandatory/sample_notices.sql | 38 +-
.../data/mysql/en/mandatory/sample_notices.sql | 38 +-
.../data/mysql/es-ES/mandatory/sample_notices.sql | 30 +-
.../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 38 +-
installer/data/mysql/it-IT/necessari/notices.sql | 36 +-
installer/data/mysql/kohastructure.sql | 21 +-
.../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 38 +-
.../data/mysql/pl-PL/mandatory/sample_notices.sql | 36 +-
.../data/mysql/ru-RU/mandatory/sample_notices.sql | 34 +-
installer/data/mysql/updatedatabase.pl | 100 +++++
.../lib/jquery/plugins/jquery.insertatcaret.js | 46 +++
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 6 +
.../prog/en/modules/help/tools/letter.tt | 8 +-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 398 +++++++++++---------
.../prog/en/modules/tools/overduerules.tt | 224 +++++------
kohaversion.pl | 2 +-
misc/cronjobs/advance_notices.pl | 146 ++++---
misc/cronjobs/overdue_notices.pl | 126 ++++---
.../thirdparty/TalkingTech_itiva_outbound.pl | 9 +-
t/db_dependent/Letters.t | 13 +-
t/db_dependent/Overdues.t | 77 ++++
t/db_dependent/Reserves.t | 5 +-
tools/letter.pl | 167 +++++---
tools/overduerules.pl | 126 +++++--
32 files changed, 1469 insertions(+), 726 deletions(-)
create mode 100644 Koha/Schema/Result/OverduerulesTransportType.pm
create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.insertatcaret.js
create mode 100644 t/db_dependent/Overdues.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list