[koha-commits] main Koha release repository branch master updated. v3.14.00-1090-gc221194

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c221194a94d42d44057c33bfe47957dca15f3415 (commit)
       via  24dd5ea3d21caf3018525ea69c5f03d5ebeb44d3 (commit)
      from  ea543fdee0ce6c3b43386536d51b56f0c5f92036 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c221194a94d42d44057c33bfe47957dca15f3415
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Sun May 4 23:24:06 2014 +0000

    Bug 11466: (follow-up) add additional test
    
    This adds an additional test case to document the behavior
    that if AdvancedSearchTypes contains 'itemtypes' or /is/
    'itemtypes', that it returns the same results.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 24dd5ea3d21caf3018525ea69c5f03d5ebeb44d3
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Thu Jan 2 10:21:49 2014 +0200

    Bug 11466: improve selection of item types for purchase order desired format list
    
    This patch ensures that the list of desired formats for a purchase
    suggestion includes the list of item types so long as the
    AdvancedSearchTypes system preference includes 'itemtypes'.
    
    --------------
    -- Synopsis --
    --------------
    
    When system preference AdvancedSearchTypes has other values than 'itemtypes',
    for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl
    is not populated with available itemtypes.
    
    This patch fixes the issue by broadening the strict comparison of
    ($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc'
    to
    ($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc'
    
    Unit tests included
    
    ---------------
    -- Test plan --
    ---------------
    
    REPLICATING THE ISSUE
    1. Set system preference  AdvancedSearchTypes to itemtypes|loc
    2. Go to opac-suggestions.pl and observe Item type <select> dropdown list
    2.1. List should have only the default value
    
    AFTER APPLYING THIS PATCH
    1. Set system preference  AdvancedSearchTypes to itemtypes|loc
    2. Go to opac-suggestions.pl and observe Item type <select> dropdown list
    2.1. List should have itemtypes available for selection
    
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
    Tests worked as expected. Placed a suggestion and saw the whole
    list of item types, chose one, saved, checked staff and it loaded
    as expected. Changed item type in staff and it applied in both
    views.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes all tests including new regression tests.
    Restores old functionality.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm                   |    2 +-
 t/db_dependent/Suggestions.t |   15 ++++++++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository