[koha-commits] main Koha release repository branch master updated. v3.14.00-1099-g53114f0

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  53114f0b21cd2f80947bec44a04a7c30cf118e57 (commit)
       via  9fe024667f03077cd9e07f3bcb0c7353d4e3cf4f (commit)
       via  ebcb64e9fa51fd7f02918d9543abeeac4f8ab46d (commit)
       via  99dbc5cdf7d7e4d9e83378fbf4d0fb5d5c2de38e (commit)
      from  b2ba10b40b1f5fa379e28284e3a629e5657d18fc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 53114f0b21cd2f80947bec44a04a7c30cf118e57
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 5 01:30:45 2014 +0000

    Bug 7442: (follow-up) apply change to Bootstrap theme
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 9fe024667f03077cd9e07f3bcb0c7353d4e3cf4f
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 5 01:27:33 2014 +0000

    Bug 7442: (follow-up) restore display of heading type for non-UNIMARC
    
    This patch restores the display of the authority type summary for
    MARC21, where at present the heading type (i.e., "Topical Term",
    "Personal Names") come over for display in the template.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit ebcb64e9fa51fd7f02918d9543abeeac4f8ab46d
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Thu Jul 18 18:13:12 2013 +0200

    Bug 7442 (follow-up) ensuring that summary is display when searching on all types of authorities
    
    This patch corrects a small bug :
    
    Authorities search on all types does not show summary because it is computed
    with selected type (which is empty) instead of using found authority type.
    
    Test plan :
    - Go to intranet autorities search
    - Perform a search on all authorities types
    - Look at results
      => Without this patch, results rows do not display the autority summary, only
         authorized headings
    
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 99dbc5cdf7d7e4d9e83378fbf4d0fb5d5c2de38e
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Thu Jul 18 13:59:07 2013 +0200

    Bug 7442: fix crash when selecting an authority with 200$x or 200$y (UNIMARC)
    
    From a biblio record, if one wants to add a 600$a information, a pop-up
    appears.  On this new window, on search terms typed and validated, a table
    result is displayed, with a column "Get It!" allowing the selection of an
    authority.  From here, different cases:
    
    1) If we have a simple authority with 200$a and 200$b subfields, a link
       "choose" is displayed, working correctly.
    
    2) If the authority has different occurences of 200$a/200$b, numeric links (1 2
       and so on) are displayed, one for each occurence.  In the example of my
       screenshot, the line with a "Paul, Korky -- Pauline, Korkette" summary
       possesses two links : "1" will add "Paul, Korky" whereas "2" will add
       "Pauline, Korkette" (couldn't come up with a better name ;)).
    
    3) If the authority has 200$x or 200$y subfields defined, several links are
       also created, when it should not be the case.  In our example, "Niclausse,
       Paul -- Expositions" will create a link "1" for "Niclausse, Paul" and a link
       "2" for "Expositions".  Clicking on the 2nd link leads to the following
       error: Software error: Can't call method "subfields" on an undefined value
       at
       /home/asaurat/workspace/versions/community/authorities/blinddetail-biblio-search.pl
       line 86.  Only the cases 1 and 2 should be handled. The creation of links
       for subfields like 200$x or 200$y should be removed.
    
    This problem is caused by the use of " -- " has separator of authorities with
    several headings, but also in some heading between main part and subdivisions.
    This patch corrects this by using an array in authorities summary so that
    presentation is computed in template. I've choosen to use the pipe separator
    between authorities with several headings. This may be changed to be
    configurable.
    
    Test plan :
    
    - Edit an authority type summary : for example subject (heading on 250) :
      summary "[250a][ -- 250x]"
    - Create an authority A1 with one heading and a subdivision : for example a
      subject : 250$a "History" 250$x "20th century"
    - Create an authority A2 with several headings. for example a subject : 250$a
      "History" 250$a "Legends"
    - Rebuild Zebra queue
    - Go to OPAC and click on "Authority search" and search on "History"
      => You will find A1 and A2 :
        History -- 20th century
        History | Legends
    - Go to intranet autorities search and search on "History"
      => You will find A1 and A2 :
        History -- 20th century
        History | Legends
    - Edit a record using this autorities type as thesaurus : for example on 606$a
    - Click on thesaurus link and search on "History"
      => You will find A1 and A2 :
        History -- 20th century ; 0 times ; choose ; Edit authority
        History | Legends       ; 0 times ; 1 2    ; Edit authority
    - Click on link "2" to chosse "Legends"
      => You get "Legends" in heading field : for example 606$a
    
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    
    I can confirm the problem and the solution. I have tested the patch on a large
    DB with authorities having multiples headings. There is no regression on bug
    4838.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Without the patch I couldn't choose between multiple headings
    in the authority plugin, but with the patch it works as described.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/AuthoritiesMarc.pm                              |   37 ++++++++++++--------
 authorities/auth_finder.pl                         |   14 --------
 .../en/includes/authorities-search-results.inc     |    9 ++++-
 .../modules/authorities/searchresultlist-auth.tt   |    6 ++--
 .../en/includes/authorities-search-results.inc     |    9 ++++-
 .../en/includes/authorities-search-results.inc     |    9 ++++-
 6 files changed, 49 insertions(+), 35 deletions(-)


hooks/post-receive
-- 
main Koha release repository