[koha-commits] main Koha release repository branch master updated. v3.14.00-1157-ge92b6e3

Git repo owner gitmaster at git.koha-community.org
Mon May 5 07:01:43 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e92b6e3dff75e20baeb818828739a4d80945cb60 (commit)
       via  997246cf4fb1b9c040e9b18c0ff264249db55cd9 (commit)
      from  c251f7524081e428b24620d2755a210347da2052 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e92b6e3dff75e20baeb818828739a4d80945cb60
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 5 05:26:18 2014 +0000

    Bug 4397: (follow-up) adjust unit test reflect return of display version of scan terms
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 997246cf4fb1b9c040e9b18c0ff264249db55cd9
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Feb 28 15:26:10 2014 -0300

    Bug 4397: fix scan index search results for non-latin characters
    
    The Zoom specification defines that a ScanSet should provide a way
    to retrieve terms suitable for displaying and another one for using
    on further searches [1].
    
    The Net::Z3950::ZOOM implementation actually provides both [2] but we
    were using the wrong one.
    
    Using $scanset->display_term(...) instead of $scanset->term(...) fixes
    the problem.
    
    To test:
    - Do a index scan search (advanced search > more options > check
      'index scan')
    - Notice non-latin characters are replaced by one or more '@' symbols.
    - Apply the patch
    - Re-do the search, everything shows as it should.
    - Try to follow any of the terms (clicking on them) and notice that
      it actually gives you relevant results (i.e. is not searching for
       @!!!!).
    
    [1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3
    [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_term()
    
    Sponsored-by: Universidad Nacional de Cordoba
    
    Followed test plan. Patch behaves as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    I reproduced the issue and I confirm this patch fixes it.
    I put "Fuß" in a title, reindex the record. Launch a search on Title
    checking the "scan index" checkbox. And the non-latin characters are
    well displayed.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm            |    2 +-
 t/db_dependent/Search.t |    5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list