[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-5-g4e3a505

Wed May 7 18:10:31 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  4e3a5051e6fd0ed63bf611ec697aecd4139d6b5a (commit)
       via  7ee0085b2ea8a33f25d731a4239f93c7be244219 (commit)
       via  e597446b9934e8216ccccf4a12cfe1657a959efd (commit)
       via  5a280ab8e360cf46c852872c9687b075c74af7eb (commit)
      from  923657526c2d7ac6d39ce5fd998c8249f43e3f51 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4e3a5051e6fd0ed63bf611ec697aecd4139d6b5a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Feb 26 17:14:04 2014 +0100

    Bug 11369: (follow-up) generate searchid in browser.js

    The search browser feature uses nearly only the browser.js file.
    That is why I propose to move the searchid generation from search.pl
    to browser.js.
    We then use Date.getTime() to use current timestamp as searchid,
    prefixed by 'scs_' like before.

    Test by using test plan of main patch :
    Too many search cursor cookies overflow HTTP-header size, when
    making multiple searches in the staff client

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes tests and QA script.
    Tested the browse functionality in staff by using the different
    options (back to results, next, previous, etc) and the batch
    modifications for items. An old cookie can cause a Javascript error,
    but after restarting the browser/deleting cookies it all works
    correctly.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit c4f17650132c9b74aa56c40a3a2bec2bdbc4477e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 7ee0085b2ea8a33f25d731a4239f93c7be244219
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Feb 26 17:03:13 2014 +0100

    Bug 11369: (follow-up) Correct usage of me.searchid in browser.js

    In browser.js, at creation of browser, the searchid is transmited to
    JS object into me.searchid.
    To be consistant, me.searchid should always be use, never searchid alone.
    In browseRecords function, setting searchid as parameter is useless
    because it is defined in me.searchid.

    Test with test plan of Bug 10404

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 98edbf00cc10c908820eb1126a176ed12a04300d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit e597446b9934e8216ccccf4a12cfe1657a959efd
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Wed Dec 11 14:28:53 2013 +0200

    Bug 11369: fix issue that can cause staff client searches to stop working

    This patch fixes an issue where too many search cursor cookies overflow
    the HTTP-header size after making multiple searches in the staff client.

    To replicate this issue, make multiple searches in catalogue/search.pl.
    50+ Should be enough to cause the HTTP-request header to overgrow.
    One can verify this issue by observing the searchCookie growth in
    browser's stored cookies.

    -------------
    - TEST PLAN -
    -------------

    Keep making searches.
    One should never have more than 10 searchCookies. Browser might display
    only 9, because for some reason the newest js-generated cookie is not
    included in Firefox's cookies listing.

    ------------
    - DRAWBACK -
    ------------

    Removing these cookies disables the search cursor for traversing search
    results (next/previous) for the removed cookie. This maybe be problematic
    in some cases,
    (for ex when multiple search tabs need to be open and they need to be
     traversed)
    One easy solution is to grow the amount of stored searchCookies from 10 to
    20, but 10 is chosen so there will be plenty of room for other cookies as
    well.

    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 0cada7a323db7f9871b67a07e3343642543b64e0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 5a280ab8e360cf46c852872c9687b075c74af7eb
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Tue Dec 10 19:12:01 2013 +0200

    Bug 11369 - Updating the jquery.cookie.js-plugin

    The current jquery.cookie-plugin crashes when trying to fetch
    all cookies using $.cookie();
    Downloaded the newest plugin version and minified it.
    Now works as intended.

    Encountered an issue with the plugin now returning null when
    no cookies are found, and applied a fix in browser.js.

    -------------
    - Test plan -
    -------------
    Plugin is used in browser.js and batchMod.js so testing both

    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 35bec75d66637bd3c4cff499ed7fb534b8d09f35)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 catalogue/search.pl                                |    4 +--
 koha-tmpl/intranet-tmpl/js/browser.js              |   33 +++++++++++++++-----
 .../lib/jquery/plugins/jquery.cookie.min.js        |    2 +-
 3 files changed, 29 insertions(+), 10 deletions(-)

hooks/post-receive
-- 
main Koha release repository