[koha-commits] main Koha release repository branch master updated. v3.16.00-beta-41-ga18ce86

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a18ce86e83740a58e9c10a2f99354a8b84d9a8bd (commit)
       via  59c569ce92a72dc6d60a16e76fb8c4eebc741fcc (commit)
      from  15e78498ac14dc28b3adf73ffda7938d1d47f9cb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a18ce86e83740a58e9c10a2f99354a8b84d9a8bd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue May 13 07:20:39 2014 -0400

    Bug 12243: ensure that records with invalid ISBNs do not cause searches to fail
    
    Some types of invalid ISBNs, when run through C4::Koha::NormalizeISBN
    can produce ISBN objects that contain invalid ISBNs. This can be
    reproduced with an ISBN that has an invalid prefix, group code or
    publisher code. An example ISBN would be "0788893777 (2 DVD 45th ed)".
    
    When attempting to look up a record with such an ISBN, you will get an
    error along the lines of: Can't call method "as_string" on an undefined
    value
    
    Instead of checking for the BAD_ISBN state, we should be checking for
    the GOOD_ISBN state via the method is_valid.
    
    Test Plan:
    1) Edit a record, add the following ISBN to your record:
       0788893777 (2 DVD 45th ed)
    2) When Koha redirects to the record, you should see the error message
       described
    3) Apply this patch
    4) Reload the page, you should now see your record
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 59c569ce92a72dc6d60a16e76fb8c4eebc741fcc
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 19 15:37:34 2014 +0000

    Bug 12243: add regression test
    
    This patch adds a regression test for C4::Koha::NormalizeISBN
    throwing an exception when trying to parse an invalid ISBN.
    
    To test:
    
    [1] Run prove -v t/Koha.t.  The last test should fail.
    [2] Apply the main patch for this bug.
    [3] Run prove -v t/Koha.t again.  This time, the test
        should pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm |    2 +-
 t/Koha.t   |    8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository