[koha-commits] main Koha release repository branch master updated. v3.16.00-beta-47-gbd3cab4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  bd3cab4a9356c9ce5b1e659ff64536ce3d5ca462 (commit)
       via  4af38b9908d497a1699bc3abd3f597858692f7b1 (commit)
       via  5b898a09bb065c9c104b50fc3562d4310cda6819 (commit)
      from  bafeb881c99142fd3abf507a3c5bcddd2c12932a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bd3cab4a9356c9ce5b1e659ff64536ce3d5ca462
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed May 14 23:51:20 2014 -0400

    Bug 7841: quell warnings in C4::Languages
    
    This patch removes some sources of warning messages thrown by
    C4::Languages, particular getTranslatedLanguages() when running
    Koha's web installer.
    
    TEST PLAN
    ---------
    1) Apply first patch
    2) prove -v t/db_dependent/Languages.t
       -- There will be uninitialized string messages, etc.
    3) Apply second patch (this one)
    4) prove -v t/db_dependent/Languages.t
       -- Only one carp message will remain.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Test pass, no warnings, no koha-qa errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 4af38b9908d497a1699bc3abd3f597858692f7b1
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 19 16:40:23 2014 +0000

    Bug 7841: add a direct regression test
    
    This patch adds a direct regression test for verifying that
    no warnings are generated when getTranslatedLanguages() is called
    without a defined current language, as might happen during
    installation.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5b898a09bb065c9c104b50fc3562d4310cda6819
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed May 14 23:38:12 2014 -0400

    Bug 7841: add unit tests to detect no functional changes to getTranslatedLanguages()
    
    When called with undef, floody messages appear in the error
    logs. Less floody messages appear when using 'en' as the
    language.  This patch adds tests to verify that the behavior of
    getTranslatedLanguages() doesn't change when a subsequent
    patch updates it to not generate the warnings.
    
    TEST PLAN
    ---------
    1) apply the patch
    2) prove -v t/db_dependent/Languages.t
       -- All the tests should pass, including the last two which
          a) check that when undef is used no language is marked
              as current.
          b) check that when 'en' is used there is a language marked
              as current.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Test pass, no koha-qa errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Languages.pm            |    9 ++++++---
 t/db_dependent/Languages.t |   21 ++++++++++++++++++++-
 2 files changed, 26 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository