[koha-commits] main Koha release repository branch master updated. v3.16.00-43-gd1e76b1

Mon May 26 02:47:22 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d1e76b1d97c5199168a1de72e58fea86c06a786e (commit)
       via  4ca89b6bc3cbca1da8e3bfce1f56e07ca5c5973c (commit)
       via  83ae8927495135d189448272efb46568268b7543 (commit)
       via  976b1dbb7ef4b5a95d74379ef2e57c079a3662f5 (commit)
       via  0f657f7a5f55eac2036c526fbc5eab069a08713c (commit)
       via  8ca8d182f36650ad71139bc6b887a176034281fd (commit)
       via  c8f38bfb3db03e051fe21da563cfa630c8436ca4 (commit)
      from  750a9ec97cbc44c6d1d8a6c595019cee7d96ef8e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d1e76b1d97c5199168a1de72e58fea86c06a786e
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 26 01:02:45 2014 +0000

    Bug 7825: DBrev 3.17.00.003

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 4ca89b6bc3cbca1da8e3bfce1f56e07ca5c5973c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jan 20 11:36:48 2014 +0100

    Bug 7825: (follow-up) do not preselect item when OpacItemHolds is 'force' - bootstrap

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Retested with all 3 themes, works as expected.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 83ae8927495135d189448272efb46568268b7543
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jan 20 11:36:33 2014 +0100

    Bug 7825: (follow-up) do not preselect item when OpacItemHolds is 'force'

    This patch changes the default behavior for the 'force' value.
    If the pref is set to force, no item is preselected and the item list is
    shown.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 976b1dbb7ef4b5a95d74379ef2e57c079a3662f5
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Jan 14 09:38:32 2014 +0100

    Bug 7825: (follow-up) fix the force value for the bootstrap theme

    If the pref was set to 'force', the item selection was not shown.
    .copiesrow should be hidden before showing specific #copiesrow_ID

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.

    Works on template level, tested with Boostrap and Prog theme
    with all 3 possible seetings of OPACItemHolds:

    1) no = offer only title level holds
    2) yes = offer both title and item level holds
    3) force = offer only item level holds

    Also ran some additional tests on the Boostrap theme with
    deactivated Javascript.

    Note: I like this, but I think when "force" is selected the
    item list needs to be shown by default. I am also not happy about
    preselecting the first item.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 0f657f7a5f55eac2036c526fbc5eab069a08713c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jan 13 09:41:22 2014 +0100

    Bug 7825: (follow-up) clarify the yes and no values

    The value of the pref should be '1' (for yes) or '0' (for no).
    The options could be kept as 'yes' and 'no': since the ImplicitTyping is
    set, yes/no would become '1/0'. But I think it is preferable not to use
    the yes/no value in order not to introduce a bug here if ImplicitTyping
    is unset later.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 8ca8d182f36650ad71139bc6b887a176034281fd
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 18 14:48:53 2013 +0100

    Bug 7825: Changed OPACItemHolds syspref to be no|yes|force choice - bootstrap

    Same test plan as previous patch but with the bootstrap theme set.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit c8f38bfb3db03e051fe21da563cfa630c8436ca4
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Mar 26 21:34:34 2012 +1300

    Bug 7825: Changed OPACItemHolds syspref to be no|yes|force choice

    Currently, the Koha system preference OPACItemHolds allows a library
    system to choose to allow patrons to place bib and item level holds from
    the OPAC, or to allow patrons only to place bib level holds only from
    the OPAC.

    This patch set adds a third option, "force", which *requires* that
    patrons place item level holds from the opac, with no option of making a
    bib level hold.

    This patch modifies the system preference OPACItemHolds to be of the
    type "Choice", with the choices being "no", "yes", "force". The patch
    does not alter the currently set value of OPACItemHolds for database
    updates, only adding the additional option.

    Test Plan:
    1) Set OPACItemHolds to "no". Check that OPAC holds behave as it is now
    (no "Place On" column, no "Select a specific copy" table, making a
    reserve is successful)
    2) Set OPACItemHolds to "yes". Check that OPAC holds behave as it is now
    ( "Place On" column is there, "Select a specific copy" table shows when
    "A specific copy" is selected, making a reserve is successful)
    3) Set OPACItemHolds to "force". Check that OPAC holds behave as follows:
      -  no "Place On" column is present
      -  "Select a specific copy" table is opened
      -  making a reserve is successful

    This patch is a squashed patch of the 3 following patches:

    Amended opac-reserve.tt accordingly

    Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com>

    Bug 7825: Followup prevent submission without choosing an item

    + Fix some ergonomic issues in opac-reserve

    Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com>

    Bug 7825: Updatedatabase should only change the type and options values.

    The value field should not be changed. We have to keep '1' for 'yes' and ''
    for 'no'.

    Original patch is from Srdjan Jankovic.

    Signed-off-by: Koha team AMU <koha.aixmarseille at gmail.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Testing notes on 4th patch.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 installer/data/mysql/sysprefs.sql                  |    2 +-
 installer/data/mysql/updatedatabase.pl             |    7 +
 .../prog/en/modules/admin/preferences/opac.pref    |    5 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |  189 +++++++++++------
 .../opac-tmpl/prog/en/modules/opac-reserve.tt      |  217 +++++++++++---------
 kohaversion.pl                                     |    2 +-
 6 files changed, 257 insertions(+), 165 deletions(-)

hooks/post-receive
-- 
main Koha release repository