[koha-commits] main Koha release repository branch master updated. v3.16.00-75-g5f6f7e0

Mon May 26 05:33:49 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  5f6f7e002c649ac690a50cd70da889e871f60f8d (commit)
       via  bb961cbba665551ede2d567f61c71b694f3195a4 (commit)
       via  3bcc0321812b153e3a487c65a1bd0edd75172f03 (commit)
       via  21df671131732c90fd69a60d15fbc1c271872d6f (commit)
       via  93ba8d0b704e514750e5d8b849f82c7a8060a11e (commit)
       via  41caa8e970034337ad36b376c50de2b0ccc6a14a (commit)
      from  1f5e92fec68a98806f355204a8b48178396c51da (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5f6f7e002c649ac690a50cd70da889e871f60f8d
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon May 26 03:59:11 2014 +0000

    Bug 11826: (follow-up) run perltidy on Koha/XSLT_Handler.pm

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit bb961cbba665551ede2d567f61c71b694f3195a4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 12 12:47:01 2014 +0200

    Bug 11826: (follow-up) enable printing warnings

    Conform former (implicit) behavior the handler now prints warnings by
    default (via STDERR to logfile).
    This can be adjusted by: $engine->print_warns(0);

    Test plan:
    Generate some error on a XSLT file (e.g. wrong path).
    Check if your log contains the associated error(s)/warning(s).

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 3bcc0321812b153e3a487c65a1bd0edd75172f03
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Mar 10 13:54:36 2014 +0100

    Bug 11826: Use XSLT handler object in showmarc, Record.pm

    Modifies showmarc and opac-showmarc to use new XSLT handler.
    Removes cardview.pl as obsolete script.
    Modifies C4/Record.pm and a typo in the test Record.t.

    Test plan:
    [1] catalogue/showmarc: Go to Cataloging. Search. Click Card.
    [2] opac-showmarc: Go to opac detail, MARC view.
        Open URL for plain view in new tab.
        Change URL: Change viewas=html to viewas=card
    [3] Verify that there are no references in the codebase to cardview.pl
    [4] C4/Record.pm: Run the Record.t test in db_dependent.
        This test uses marc2modsxml, triggering the change.
        Additional: export to MODS from opac-detail.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Views Ok. Test pass. No more cardview. No koha-qa errors

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 21df671131732c90fd69a60d15fbc1c271872d6f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Mar 10 10:57:33 2014 +0100

    Bug 11826: Use the XSLT handler in C4/XSLT module

    Incorporate the new object into C4/XSLT module.
    The handler object needed one adjustment to allow for passing URLs.
    Removed the GetURI function; it is no longer needed.
    Added some documentation lines.
    Moved a file-level lexical upwards in the code for visibility.
    Removed some tabs (on two lines).

    Note: The handler could perhaps be moved up to the Context module, or
    be saved in a global ('our') variable.  But I would rather not do that
    now, making testing not too complex at this moment.

    Test plan:
    Enable XSLT preferences for opac and intranet.
    Check result and detail pages.
    Check individual list display (virtual shelves).
    Force an XSLT error by editing one of your xsl files. Check the
    corresponding display.
    Put an URL in one the XSLT prefs (could just be to your own server).
    Check the display.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Running XSLTParse4Display in a loop showed no significant performance
    change.
    One pass cost me around 0.012 sec (except for the first pass).

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Results, detail, url and list view Ok
    No koha-qa errors

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 93ba8d0b704e514750e5d8b849f82c7a8060a11e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Feb 21 17:21:55 2014 +0100

    Bug 11826: Add unit tests for Koha::XSLT_Handler

    Test plan:
    Verify if XSLT_Handler.t passes.
    You could also sabotage the test by removing one of the test xsl files.
    Or you could 'repair' the bad xsl file (test02). Remove the second line
    redefining the xsl variable.
    In all those cases the unit test should fail now.. Discard your changes :)

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Test pass. No koha-qa errors.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 41caa8e970034337ad36b376c50de2b0ccc6a14a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Feb 21 17:20:29 2014 +0100

    Bug 11826: Add XSLT handler object to Koha namespace

    In achieving the goals of umbrella report 6536 (Z3950 improvements), this
    report adds a XSLT handler object to the Koha namespace.
    A follow-up adds unit tests for this module.
    This patch does not yet incorporate the new object into Z3950 search. So
    it does not change any behavior and is therefore harder to test.

    Test plan:
    Run the unit tests of the follow-up patch on report 11826.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    I tested the new module in two additional ways:

    [1] Made a simple script (four lines as below) that ran a larger xml file
        with 1500 records through a test XSLT file modifying the title.

        my $eng= Koha::XSLT_Handler->new;
        open my $fh1, '<', '_example_file';
        my @xml= <$fh1>;
        print $eng->transform( join('', @xml), '_example_xsl_file');

    [2] Incorporated the object into my local changes of Breeding.pm (based on
        older work, not ready for submittal now).
        Ran transformation on Z3950 search results. Worked well :)

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Test runs Ok. No koha-qa errors.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Record.pm                           |   12 +-
 C4/XSLT.pm                             |   99 +++++-----
 Koha/XSLT_Handler.pm                   |  324 ++++++++++++++++++++++++++++++++
 catalogue/cardview.pl                  |   60 ------
 catalogue/showmarc.pl                  |   13 +-
 opac/opac-showmarc.pl                  |   20 +-
 t/db_dependent/Record.t                |    2 +-
 t/db_dependent/XSLT_Handler.t          |  119 ++++++++++++
 t/db_dependent/XSLT_Handler/test01.xsl |   24 +++
 t/db_dependent/XSLT_Handler/test02.xsl |   13 ++
 t/db_dependent/XSLT_Handler/test03.xsl |   17 ++
 11 files changed, 554 insertions(+), 149 deletions(-)
 create mode 100644 Koha/XSLT_Handler.pm
 delete mode 100755 catalogue/cardview.pl
 create mode 100644 t/db_dependent/XSLT_Handler.t
 create mode 100644 t/db_dependent/XSLT_Handler/test01.xsl
 create mode 100644 t/db_dependent/XSLT_Handler/test02.xsl
 create mode 100644 t/db_dependent/XSLT_Handler/test03.xsl

hooks/post-receive
-- 
main Koha release repository