[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-102-gd85a7da

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  d85a7da1fc01bbdbc3366f5f2573438773533196 (commit)
       via  12366e2581754ed52d382a1cb931dd5e6bd8b581 (commit)
       via  82d6e097f5469708841bc150920681a203de58f8 (commit)
      from  90cce3c059f63be213aa665377d1b6221c4c4ca1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d85a7da1fc01bbdbc3366f5f2573438773533196
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Thu Jan 30 16:48:26 2014 +0000

    Bug 9823: (follow-up) improve POD for C4::Reserves::GetReservesFromBiblionumber
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 7b58255028da6a9cc4652b32913b01b47e651f1f)
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 12366e2581754ed52d382a1cb931dd5e6bd8b581
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jan 24 09:59:03 2014 +0100

    Bug 9823: QA follow-up for GetReservesFromBiblionumber calls
    
    The template params holds and holdcount are not used in the ISBD template.
    Removed the associated code from catalogue/ISBDdetail.pl.
    Same applies for catalogue/MARCdetail.pl and labeledMARCdetail.pl.
    Same applies also for catalogue/imageviewer.pl.
    Same applies also for catalogue/moredetail.pl.
    
    In catalogue detail.tt only the number of holds is used. Removed the code
    that passed the holds array to the template.
    
    For consistency opac-detail should also incorporate future holds into its
    holds count; added the all_dates parameter for that reason.
    
    The Reserves module is no longer needed in moredetail. Removed it. Checked
    the other scripts also.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit e536fd087d540065d2ccbe12925695bb770d4314)
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 82d6e097f5469708841bc150920681a203de58f8
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Mar 18 14:37:18 2013 +0000

    Bug 9823: Refactor return from GetReservesFromBiblionumber
    
    The return from GetReservesFromBiblionumber contains an unnecessary
    extra variable. In scalar context an array returns its element count.
    Maintaining a separate count can lead to unforeseen bugs
    and imposes ugly constructions on the subroutine's users.
    
    Remove the useless count variable from the return
    
    This patch also changes the parameters: now the routine takes a hashref.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Placed biblio holds, future holds and item holds. Works as expected.
    Tested Holds.t and Reserves.t. Pass.
    Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on
    one item. Fine.
    C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find
    them anymore. Looks good.
    Handled a few unneeded calls in QA follow-up.
    Left only one point to-do for serials/routing-preview.pl. See Bugzilla.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 8b685c1e80db99f24d3ee965b8f8d2badb243153)
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                   |    2 +-
 C4/ILSDI/Services.pm           |    4 ++--
 C4/Reserves.pm                 |   27 ++++++++++++++++++++-------
 C4/SIP/ILS/Item.pm             |    4 ++--
 acqui/parcel.pl                |    4 ++--
 catalogue/ISBDdetail.pl        |    2 --
 catalogue/MARCdetail.pl        |    2 --
 catalogue/detail.pl            |    6 ++++--
 catalogue/imageviewer.pl       |    2 --
 catalogue/labeledMARCdetail.pl |    2 --
 catalogue/moredetail.pl        |    3 ---
 opac/opac-detail.pl            |    4 ++--
 opac/opac-reserve.pl           |    4 ++--
 reserve/request.pl             |    5 +++--
 serials/routing-preview.pl     |    5 +++--
 t/db_dependent/Holds.t         |   10 +++++-----
 16 files changed, 46 insertions(+), 40 deletions(-)


hooks/post-receive
-- 
main Koha release repository