[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.06-103-g719a0a9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  719a0a966e621aa673c10b68541dc05168c5adc6 (commit)
      from  d85a7da1fc01bbdbc3366f5f2573438773533196 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 719a0a966e621aa673c10b68541dc05168c5adc6
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Feb 24 10:21:20 2014 -0500

    Bug 11829: fix JavaScript error on staff client biblio details pages if template variables are undefined
    
    The JavaScript included in cat-toolbar.inc expects several variables to
    be passed to the template for use in calculations. Several scripts
    do not pass the required variables to the template, leading to a JS
    error.
    
    This patch re-adds (See Bug 9823) hold count calculation to the required
    scripts and copies the acquisitions-related count calculation from
    detail.pl into related bibliographic detail scripts so that the
    commonly-included cat-toolbar.inc can receive correct values.
    
    To test, locate a bibliographic record which has no holds and is not
    used in a current or deleted order, but which has a local cover image
    attached. Check the following views to confirm there is no JavaScript
    error:
    
    - Normal
    - MARC
    - Labeled MARC
    - ISBD
    - Items
    - Images (from the Images tab on the "Normal" detail page)
    
    Next, locate a bibliographic record with no items attached which is used
    in an Acquisitions order. On each of the pages listed above, choose
    "Delete record" from the Edit menu. This should trigger a warning that
    the record is used in an order. Cancel the deletion.
    
    Finally, delete the order which references the bibliographic record. On
    each of the pages listed above, choose "Delete record" again. This
    should trigger a warning that the record is used in a deleted order.
    Cancel the deletion.
    
    I went through the test plan, everything works OK.
    It resolves Bug 11831 as well.
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    - Printing from MARC and ISBD view works again
    - No more Javascript errors found
    - Deleting a record with attached order gives the correct warning,
      both for ordered and cancelled.
    
    Passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 63d7386ed00f73be837a57aeb12d75c6893ca0bd)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 catalogue/ISBDdetail.pl        |   32 ++++++++++++++++++++++++++++++++
 catalogue/MARCdetail.pl        |   31 +++++++++++++++++++++++++++++++
 catalogue/imageviewer.pl       |   32 ++++++++++++++++++++++++++++++++
 catalogue/labeledMARCdetail.pl |   32 ++++++++++++++++++++++++++++++++
 catalogue/moredetail.pl        |   31 +++++++++++++++++++++++++++++++
 5 files changed, 158 insertions(+)


hooks/post-receive
-- 
main Koha release repository