[koha-commits] main Koha release repository branch master updated. v3.16.00-78-g35a88a5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  35a88a5c4477d446f080411cb7b2280b9a81c64e (commit)
       via  954017be8a322a1c39c1794544e025355bcf94d4 (commit)
      from  c4f7164cb92c63043c4877aef79714c5461496c9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 35a88a5c4477d446f080411cb7b2280b9a81c64e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed May 21 13:17:54 2014 +0200

    Bug 12301: Remove warnings on translate scripts
    
    Using perl v5.18, the following is warned on updating/installing
    templates:
      Smartmatch is experimental at ./translate line 54.
    
    Moreover, the following should exist with previous perl versions:
    
    perlcritic xgettext
    Subroutine prototypes used at line 29, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 44, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 60, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 72, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 89, column 1.  See page 194 of PBP.
    (Severity: 5)
    Variable declared in conditional statement at line 105, column 13.
    Declare variables outside of the condition.  (Severity: 5)
    Subroutine prototypes used at line 127, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 136, column 1.  See page 194 of PBP.
    (Severity: 5)
    Variable declared in conditional statement at line 190, column 7.
    Declare variables outside of the condition.  (Severity: 5)
    Subroutine prototypes used at line 237, column 1.  See page 194 of PBP.
    (Severity: 5)
    Bareword file handle opened at line 238, column 5.  See pages 202,204 of
    PBP.  (Severity: 5)
    Two-argument "open" used at line 238, column 5.  See page 207 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 277, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 311, column 1.  See page 194 of PBP.
    (Severity: 5)
    Bareword file handle opened at line 350, column 9.  See pages 202,204 of
    PBP.  (Severity: 5)
    Two-argument "open" used at line 350, column 9.  See page 207 of PBP.
    (Severity: 5)
    Bareword file handle opened at line 353, column 5.  See pages 202,204 of
    PBP.  (Severity: 5)
    Bareword file handle opened at line 359, column 5.  See pages 202,204 of
    PBP.  (Severity: 5)
    Two-argument "open" used at line 359, column 5.  See page 207 of PBP.
    (Severity: 5)
    
    perl -wc xgettext.pl
    \1 better written as $1 at TmplTokenizer.pm line 474.
    main::token_negligible_p() called too early to check prototype at
    xgettext.pl line 52.
    xgettext.pl syntax OK
    
    Test plan:
    Apply this patch and verify the warnings/errors does not appear anymore
    and no regression is found on creating/updating/installing templates.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Work as described, no koha-qa errros.
    Tested with perl v5.18.2
    No warnings, no problem detected on create/update/install i18n files
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 954017be8a322a1c39c1794544e025355bcf94d4
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue May 27 10:12:20 2014 +0200

    Bug 12315: fix sending of duplicate advanced notices (and sending advanced notices to wrong patron)
    
    Bug 10833 introduced a variable loop but does not reset it every
    iteration.
    
    So the first patron receives correct letters, but the following ones
    received all the previous ones as well as their own notices
    
    Test plan:
    0/ Delete the content of the message_queue table.
    1/ Define advanced notices sent 2 days in advance for 2 patrons.
    2/ Check 1 item out for each one and specify a due date today + 2 days.
    3/ Launch the advance_notices.pl script.
    4/ Before this patch, you got 3 notices. Now, you get 2 notices, 1 for
       each patron.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Work well, no errors.
    
    Tested following test plan, printing on screen or saving into db,
    3 messages before, 2 after (advance_notices.pl -v -n -m 2 -c)
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/cronjobs/advance_notices.pl |    1 +
 misc/translator/TmplTokenizer.pm |    2 +-
 misc/translator/translate        |    2 +-
 misc/translator/xgettext.pl      |   75 ++++++++++++++++++++------------------
 4 files changed, 42 insertions(+), 38 deletions(-)


hooks/post-receive
-- 
main Koha release repository