[koha-commits] main Koha release repository branch master updated. v3.16.00-79-g789c562

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  789c562e188ce2705fb94cc79403a7616cb092e3 (commit)
      from  35a88a5c4477d446f080411cb7b2280b9a81c64e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 789c562e188ce2705fb94cc79403a7616cb092e3
Author: David Cook <dcook at prosentient.com.au>
Date:   Wed May 21 13:22:10 2014 +1000

    Bug 11014 - Slip Print Problem in Chrome
    
    Currently, slips cannot be printed in circulation, members, or the
    self check out when using Chrome.
    
    This patch adds a timer of 1ms which allows Chrome's custom code to
    prevent "window.close" occuring before the user has dealt with the
    print window.
    
    This patch also allows admins to use the 'IntranetSlipPrinterJS'
    system preference to override the slip printing code by centralizing
    all the slip printing code in slip-print.inc, and including this JS
    anywhere it's needed in the staff client.
    
    I haven't used this include in the OPAC SCO but perhaps it would make
    sense to do so as well (even if it isn't referred to in the syspref's
    name).
    
    _TEST PLAN_
    1) Using Chrome on Windows (not sure if this is an issue on other OSes),
    try to print a slip in the following locations:
    
    Fines Tab -> Print button
    koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt:
    
    Details tab -> Print button -> Print slip || Print quick slip
    koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt:
    
    Details tab -> Print button -> Print summary
    koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt:
    
    Fines tab -> Accounts tab -> Print (Manual invoice of $5 sundry)
    koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt:
    
    Checkout tab -> Print button
    koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt:
    
    Finish button
    koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt
    
    2) Note that each time you try to print, a new print page is created
    but closed before you have a chance to print.
    
    3) Apply the patch
    
    4) Repeat Step 1
    
    5) Note that the print page now doesn't close until after you've
    chosen to print or cancel.
    
    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc     |   10 ++++++++++
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt   |   11 +----------
 .../prog/en/modules/members/moremember-print.tt             |    8 ++------
 .../prog/en/modules/members/moremember-receipt.tt           |    8 ++------
 .../intranet-tmpl/prog/en/modules/members/printfeercpt.tt   |    8 ++------
 .../intranet-tmpl/prog/en/modules/members/printinvoice.tt   |    8 ++------
 koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt   |    2 +-
 7 files changed, 20 insertions(+), 35 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc


hooks/post-receive
-- 
main Koha release repository