[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.00-21-g3f08275

Git repo owner gitmaster at git.koha-community.org
Fri May 30 21:19:04 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  3f08275a006b6e471c40e2050254e2c2879dc871 (commit)
       via  dc38bf4f6ccaaef36ebc098949170e0d8d55ba3c (commit)
       via  593e6660ceafff39ba2972b998fd207af1813f9d (commit)
      from  566d27d97aed3303585adf9c5d46d3eb67ab9872 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3f08275a006b6e471c40e2050254e2c2879dc871
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue May 27 10:12:20 2014 +0200

    Bug 12315: fix sending of duplicate advanced notices (and sending advanced notices to wrong patron)
    
    Bug 10833 introduced a variable loop but does not reset it every
    iteration.
    
    So the first patron receives correct letters, but the following ones
    received all the previous ones as well as their own notices
    
    Test plan:
    0/ Delete the content of the message_queue table.
    1/ Define advanced notices sent 2 days in advance for 2 patrons.
    2/ Check 1 item out for each one and specify a due date today + 2 days.
    3/ Launch the advance_notices.pl script.
    4/ Before this patch, you got 3 notices. Now, you get 2 notices, 1 for
       each patron.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Work well, no errors.
    
    Tested following test plan, printing on screen or saving into db,
    3 messages before, 2 after (advance_notices.pl -v -n -m 2 -c)
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit dc38bf4f6ccaaef36ebc098949170e0d8d55ba3c
Author: David Cook <dcook at prosentient.com.au>
Date:   Wed May 21 13:22:10 2014 +1000

    Bug 11014 - Slip Print Problem in Chrome
    
    Currently, slips cannot be printed in circulation, members, or the
    self check out when using Chrome.
    
    This patch adds a timer of 1ms which allows Chrome's custom code to
    prevent "window.close" occuring before the user has dealt with the
    print window.
    
    This patch also allows admins to use the 'IntranetSlipPrinterJS'
    system preference to override the slip printing code by centralizing
    all the slip printing code in slip-print.inc, and including this JS
    anywhere it's needed in the staff client.
    
    I haven't used this include in the OPAC SCO but perhaps it would make
    sense to do so as well (even if it isn't referred to in the syspref's
    name).
    
    _TEST PLAN_
    1) Using Chrome on Windows (not sure if this is an issue on other OSes),
    try to print a slip in the following locations:
    
    Fines Tab -> Print button
    koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt:
    
    Details tab -> Print button -> Print slip || Print quick slip
    koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt:
    
    Details tab -> Print button -> Print summary
    koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt:
    
    Fines tab -> Accounts tab -> Print (Manual invoice of $5 sundry)
    koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt:
    
    Checkout tab -> Print button
    koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt:
    
    Finish button
    koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt
    
    2) Note that each time you try to print, a new print page is created
    but closed before you have a chance to print.
    
    3) Apply the patch
    
    4) Repeat Step 1
    
    5) Note that the print page now doesn't close until after you've
    chosen to print or cancel.
    
    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 593e6660ceafff39ba2972b998fd207af1813f9d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed May 21 13:17:54 2014 +0200

    Bug 12301: Remove warnings on translate scripts
    
    Using perl v5.18, the following is warned on updating/installing
    templates:
      Smartmatch is experimental at ./translate line 54.
    
    Moreover, the following should exist with previous perl versions:
    
    perlcritic xgettext
    Subroutine prototypes used at line 29, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 44, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 60, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 72, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 89, column 1.  See page 194 of PBP.
    (Severity: 5)
    Variable declared in conditional statement at line 105, column 13.
    Declare variables outside of the condition.  (Severity: 5)
    Subroutine prototypes used at line 127, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 136, column 1.  See page 194 of PBP.
    (Severity: 5)
    Variable declared in conditional statement at line 190, column 7.
    Declare variables outside of the condition.  (Severity: 5)
    Subroutine prototypes used at line 237, column 1.  See page 194 of PBP.
    (Severity: 5)
    Bareword file handle opened at line 238, column 5.  See pages 202,204 of
    PBP.  (Severity: 5)
    Two-argument "open" used at line 238, column 5.  See page 207 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 277, column 1.  See page 194 of PBP.
    (Severity: 5)
    Subroutine prototypes used at line 311, column 1.  See page 194 of PBP.
    (Severity: 5)
    Bareword file handle opened at line 350, column 9.  See pages 202,204 of
    PBP.  (Severity: 5)
    Two-argument "open" used at line 350, column 9.  See page 207 of PBP.
    (Severity: 5)
    Bareword file handle opened at line 353, column 5.  See pages 202,204 of
    PBP.  (Severity: 5)
    Bareword file handle opened at line 359, column 5.  See pages 202,204 of
    PBP.  (Severity: 5)
    Two-argument "open" used at line 359, column 5.  See page 207 of PBP.
    (Severity: 5)
    
    perl -wc xgettext.pl
    \1 better written as $1 at TmplTokenizer.pm line 474.
    main::token_negligible_p() called too early to check prototype at
    xgettext.pl line 52.
    xgettext.pl syntax OK
    
    Test plan:
    Apply this patch and verify the warnings/errors does not appear anymore
    and no regression is found on creating/updating/installing templates.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Work as described, no koha-qa errros.
    Tested with perl v5.18.2
    No warnings, no problem detected on create/update/install i18n files
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/includes/slip-print.inc  |   10 +++
 .../prog/en/modules/circ/printslip.tt              |   11 +--
 .../prog/en/modules/members/moremember-print.tt    |    8 +--
 .../prog/en/modules/members/moremember-receipt.tt  |    8 +--
 .../prog/en/modules/members/printfeercpt.tt        |    8 +--
 .../prog/en/modules/members/printinvoice.tt        |    8 +--
 .../bootstrap/en/modules/sco/printslip.tt          |    2 +-
 misc/cronjobs/advance_notices.pl                   |    1 +
 misc/translator/TmplTokenizer.pm                   |    2 +-
 misc/translator/translate                          |    2 +-
 misc/translator/xgettext.pl                        |   75 ++++++++++----------
 11 files changed, 62 insertions(+), 73 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list