[koha-commits] main Koha release repository branch master updated. v3.16.00-971-g1e5097d
Git repo owner
gitmaster at git.koha-community.org
Fri Nov 7 19:18:27 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 1e5097d0fa62037ab9fad093f42629064f97b610 (commit)
via d7de9609ca9023900f03f368e174152f95862b38 (commit)
via 3eb293e9dac6267065f7cd8279ffded3a95e1b88 (commit)
via a71b96295fb07084e4f87ac1a471e89355f3c5a4 (commit)
via d536bb46f72b3c2479c5fa6fae242e3531fdae7b (commit)
via 8dfc4326e8cd63e41726d3a162286cd1f9736011 (commit)
via 81ff0a449dc9404d87b6324df362900f642bbef2 (commit)
via fed11629e79fbb30beabe65dbed11155ac848f9a (commit)
via 1c2744a83f99027386f9409ad43e725707ae45f8 (commit)
via 9e977e85c54efe176526b9638991801dfd64d74e (commit)
via f9e3891050cc07761c6781658dd1c25dba70d6d1 (commit)
via ba3c3df6f951a363412d171f3a995d48a4f3b096 (commit)
via b27c2e6026cb16d8a77f0b8aa90a9d9e121b1784 (commit)
via 5afb6a30cac4b7df33e0123348734bb493e8d0a3 (commit)
from aef500f6a3168be665d2a38e9aa2c745c6e24c78 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1e5097d0fa62037ab9fad093f42629064f97b610
Author: Katrin Fischer <katrin.fischer at bsz-bw.de>
Date: Thu Aug 28 13:32:35 2014 +0200
Bug 12334: Make it easy to hide parts of material type and format information in results
With the system preferences DisplayIconsXSLT and DisplayOPACiconsXSLT we control
the visibility of the material type, format and audience information in staff
and OPAC.
Sometimes a library might only want to hide a part of that information - for
example, hide audience but keep the material type icon.
This patch adds CSS classes to make it easier to style this section of the page
and hide parts of the information.
To test:
- Verify that OPAC and staff result lists for various types of materials
still display nicely.
- Take a look at the HTML and verify, that label and text are now
wrapped into a new span with a results_* class.
- Try hiding a part of the information, for example in OpacUserCSS:
.results_material_type {
display none;
}
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as described... but for a missing colon on example CSS
.results_material_type {
display: none;
}
No koha-qa errors
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d7de9609ca9023900f03f368e174152f95862b38
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Nov 7 15:19:30 2014 -0300
Bug 12250: DBRev 3.17.00.049
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3eb293e9dac6267065f7cd8279ffded3a95e1b88
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sat Nov 1 20:04:49 2014 -0300
Bug 12250: Update descriptions for languages, scripts and regions
This patch adds/updates languages, scripts and regions to
reflect what we currently have on translation server.
Languages, scripts and regions are ordered by respective code
To test:
1. Apply the patch
2. run updatedatabase.pl, must run without errors
3. Go to advanced search (opac/staff), more options, and check
language pulldown (verify you have an empty AdvancedSearchLanguages
syspref)
4. Remove contents from language_descriptions, language_rfc4646_to_iso639,
language_script_bidi, language_script_mappin and language_subtag_registry
5. Load installer/data/mysql/mandatory/subtag_registry.sql,
must load without errors
6. Repeat 3
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Tested the SQL, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a71b96295fb07084e4f87ac1a471e89355f3c5a4
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Sep 30 12:19:21 2014 +0200
Bug 12627: Fix default values
The default value for *by and *date fields is NULL.
But without this patch, the values are 0 or 0000-00-00.
It comes from the fact that the form set to an empty string the values
and DBIX::Class does not consider them as undefined.
This patch is very ugly, not sure how we can fix that.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
No regressions found, adding and editing suggestions from
OPAC and staff.
Passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d536bb46f72b3c2479c5fa6fae242e3531fdae7b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Sep 30 12:56:35 2014 +0200
Bug 12627: Bug 12627: Fix default values - TT changes
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 8dfc4326e8cd63e41726d3a162286cd1f9736011
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Sep 30 11:25:27 2014 +0200
Bug 12627: Fix date management
C4::Dates->today returns a string formatted depending on the dateformat
syspref.
Before the original patch, SQLHelper managed both format (string
formatted and DateTime.
Now DBIX::Class only manages DateTime, so the call to NewSuggestion and
ModSuggestion should pass a DateTime object
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 81ff0a449dc9404d87b6324df362900f642bbef2
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Sep 29 15:24:36 2014 +0200
Bug 12627: Remove warnings
suggestion.pl: keys on reference is experimental
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit fed11629e79fbb30beabe65dbed11155ac848f9a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Sep 29 15:18:31 2014 +0200
Bug 12627: DBIx::Class is case sensitive for column names
STATUS should be "STATUS", not "status".
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1c2744a83f99027386f9409ad43e725707ae45f8
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date: Fri Aug 8 15:11:18 2014 +0200
Bug 12627: SQLHelper replacement - C4::Suggestions
With this patch, the subroutines NewSuggestion and ModSuggestion use DBIx::Class instead of C4::SQLHelper.
Moreover, the tests and the .pl have been adapted.
Test plan:
1) Apply the patch.
2) Execute the unit tests by launching :
prove t/db_dependent/Suggestions.t
3) The result has to be a success without error or warning :
t/db_dependent/Suggestions.t .. ok
All tests successful.
Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU)
Result: PASS
4) Log in the intranet, create a suggestion and verify the created suggestion.
5) Edit a suggestion from the intranet and verify the suggestion is correctly modified.
6) Log in the OPAC and verify you can add a suggestion.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass, suggestion created on staff and opac,
suggestion edited without problems, no koha-qa errors.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes tests and QA script:
Also tested:
- adding suggestion from staff and OPAC
- edit suggestion from staff
- deleting suggestion from OPAC
- changing to a normal status (email got created)
- changing to a custom status (SUGGEST_STATUS)
- display of custom status in OPAC
No problems found.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9e977e85c54efe176526b9638991801dfd64d74e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Oct 21 14:31:25 2014 -0400
Bug 13123 - Duplicate label ids for language and opaclanguages
When enabling or disabling a OPAC language choice clicking the label
triggers the checkbox under the language preference instead. This is
because both <label>s have the same id.
This patch adds a modifier to each label and corresponding id attribute
in order to make them unique.
To test, go to Administration -> System preferences -> I18N/L10N.
Clicking the "English (en)" label under the "language" system preference
should toggle the corresponding checkbox. Clicking the "English (en)"
label under the "opaclanguages" system preference should toggle the
correct checkbox.
Further tests:
- Install an English 'sub-language' like en-GB and confirm that
checkbox labels work correctly.
- Install a non-English language and confirm that checkbox labels work
correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, template changes only.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit f9e3891050cc07761c6781658dd1c25dba70d6d1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Oct 15 12:36:27 2014 -0400
Bug 13089 - Tab key triggers JavaScript error in the checkEnter function
Tabbing through fields in the patron add form or MARC editor triggers a
JavaScript error for each tab. The cause seems to be some JS which was
designed to accommodate differences between Mozilla browsers and
Internet Explorer. A slight modification seems to work just as well in
Firefox and IE.
To test, apply the patch and clear your browser cache if necessary. To
look for JavaScript errors, open the Developer Tools console in Firefox,
Chrome, or Internet Explorer (or in Firefox's Firebug console).
Create a new patron and use the tab key to move between inputs. No error
should be reported in the console. Test typing in fields and pressing
enter. The form should not be submitted.
Test in all available browsers, including at least IE11, IE10, and IE9.
Reproduced with FF 32
Tested with FF 32, Chrome 38, IE 11 and IE Emulations 8,9,10
No JavaScript errors found. Enter does not submit.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tested in Chromium, confirmed the problem and that the patch fixes it.
Passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit ba3c3df6f951a363412d171f3a995d48a4f3b096
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Nov 5 03:06:42 2014 -0500
Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm
While testing a bug, warnings in the opac error log were
building up due to a particular line in C4::Auth. After
reviewing the code, it was discovered that removal of the
OpacMainUserBlockMobile system preference created this.
Since the system preference no longer exists, and is not
used, the line was deleted from C4/Auth.pm to prevent this
warning from occuring.
TEST PLAN
----------
1) Go to any OPAC page.
2) Check your opac error log.
-- there should be something about uninitialized values
used in C4/Auth.pm around line 443.
3) Apply the patch
4) Refresh the page.
-- that same error should not be triggered.
5) prove -v t/db_dependent/Auth.t
-- this runs the get_template_and_user function
which had the parameter removed.
6) run the koha qa test tools
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b27c2e6026cb16d8a77f0b8aa90a9d9e121b1784
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Sep 30 09:27:16 2014 +0200
Bug 12979: Fix error on layout3pagesfr
The format method was not called.
Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
No regressions found, passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5afb6a30cac4b7df33e0123348734bb493e8d0a3
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Sep 23 11:32:14 2014 +0200
Bug 12979: Price formatting should only be defined at one place
There are some places where the price format is defined.
All these occurrences should be removed use the way introduced by bug
12844.
Test plan:
1/ Verify you don't see any price formatting change on the basketgroup pdf
(for layout2pages, payout2pagesde, layout3pages and layout3pagesfr).
2/ On admin/aqbudgetperiods.pl, the budget total should be unchanged
too.
Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 1 -
C4/Suggestions.pm | 48 +-
acqui/acqui-home.pl | 1 -
acqui/addorderiso2709.pl | 1 -
acqui/pdfformat/layout2pages.pm | 31 +-
acqui/pdfformat/layout2pagesde.pm | 31 +-
acqui/pdfformat/layout3pages.pm | 83 +-
acqui/pdfformat/layout3pagesfr.pm | 81 +-
admin/aqbudgetperiods.pl | 14 +-
admin/aqbudgets.pl | 1 -
admin/aqplan.pl | 1 -
installer/data/mysql/mandatory/subtag_registry.sql | 1505 +++++++++++++++-----
installer/data/mysql/updatedatabase.pl | 382 +++++
koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 2 -
.../prog/en/modules/admin/preferences.tt | 12 +-
.../prog/en/modules/suggestion/suggestion.tt | 17 +-
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 27 +-
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 27 +-
kohaversion.pl | 2 +-
opac/opac-suggestions.pl | 5 +-
suggestion/suggestion.pl | 74 +-
t/db_dependent/Suggestions.t | 21 +-
22 files changed, 1778 insertions(+), 589 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list