[koha-commits] main Koha release repository branch master updated. v3.16.00-1051-g900670b
Git repo owner
gitmaster at git.koha-community.org
Fri Nov 14 13:32:40 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 900670bd3bd3d1984dbd23e86e78706ff15288f9 (commit)
via 878fa77c30732eb5f37f9bd050286b10b74fb881 (commit)
via 628aea461aac5261ad8ab7880af2865d0128f760 (commit)
via 0f3a04609cb85b454252226915e76ff277af7054 (commit)
via ae4e7e2800fc2f708fc541d07f9978c72ecc7854 (commit)
via 0be1dce1f7142aae8a87133a90a22659a75143bc (commit)
via dd385fc2e9e6a2381ff0052582df6f072193cdb2 (commit)
from 9e07b59d5bd330bc03c222603d1845f31fa8fd20 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 900670bd3bd3d1984dbd23e86e78706ff15288f9
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Nov 12 20:39:05 2014 -0300
Bug 13075: (followup) remove remaining warnings
There's no point creating a MARC record with undef subfields
for testing holds. This patch avoids that so no warnings are shown.
To test:
- Run
$ prove t/db_dependent/Holds.t
=> FAIL: verify several warnings show
- Apply the patch
- Re-run
=> SUCCESS: no warnings showed.
- Sign off :-D
Regards
NOTE: Not noticable under Ubuntu 12.04 LTS, but verifiable under
Debian Wheezy.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 878fa77c30732eb5f37f9bd050286b10b74fb881
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sat Oct 11 20:02:35 2014 -0400
Bug 13075: Silence warnings and improve Charset testing.
Calls to C4/Charset.pm's NormalizeString function with an
undefined string were triggering warnings when running:
prove -v t/db_dependent/Holds.t
Sadly, t/Charset.t was also lacking calls to NormalizeString.
TEST PLAN
---------
1) prove -v t/db_dependent/Holds.t
-- This should generate the uninitialized string warnings.
Make sure CPL and MPL are in your branches to save
yourself from headaches due to expected data.
2) cat t/Charset.t
-- note there are no function calls to NormalizeString.
You can see other shortfalls in the tests beyond
NormalizeString with: grep ^sub C4/Charset.pm
3) prove -v t/Charset.t
4) Apply patch
5) prove -v t/Charset.t
-- Run as before with more tests.
6) cat t/Charset.t
-- note there are now function calls to NormalizeString.
7) prove -v t/db_dependent/Holds.t
-- Nice and clean run! :)
8) koha-qa.pl -v 2 -c 1
-- all should be Ok.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 628aea461aac5261ad8ab7880af2865d0128f760
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Nov 9 23:27:47 2014 +0100
Bug 12779: Capitalization on add/edit subscription form
To test:
- Add or edit a new or existing subscription in the serials
module
Patch changes "biblio" to "record" and fixes capitalization:
Search for record | Create record
Patch behaves as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0f3a04609cb85b454252226915e76ff277af7054
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Nov 12 10:02:15 2014 +0100
Bug 13232: Search patrons by a first letter should not redirect to a patron detail page
Bug 12833 allows to find a patron with his cardnumber.
But this won't never append if the firstletter parameter is given.
Actually the firstletter param is the only one to take into account if
it exists.
Test plan:
Search patrons by a first letter and verify that the feature is back.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
To reproduce the problem you need at least one borrower with a blank
cardnumber
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
works as descrobed, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit ae4e7e2800fc2f708fc541d07f9978c72ecc7854
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Nov 10 10:56:12 2014 -0300
Bug 6681: (qa followup) document the existence of the sample files
As requestedby people testing the patch, I add references to the new
xslt files on the Z39.50/SRU servers help.
Example usages are also provided.
Test:
- Apply the patch
- Go to the help page on the 'Z39.50/SRU Servers' page
=> SUCCESS: Notice there's a section documenting XSLT file(s) usage
and provides some examples that cover the introduced files.
- Sign off
Thanks
Tomas
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
Help page does shed some light to the XSLT usage. Enough to my taste.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0be1dce1f7142aae8a87133a90a22659a75143bc
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Nov 3 15:44:36 2014 -0300
Bug 6681: introduce XSLT scripts to remove items and links
This patch adds the following sample files:
- Del952.xsl
- Del995.xsl
- Del9LinksExcept952.xsl
- Del9LinksExcept995.xsl
Thay can be used on the new SRU/Z39.50 XSLT processing feature. At the same
time they can be used to solve this bug.
To test:
- Have an SRU/Z39.50 target configured
- Have a search that returns at least a record with the following
properties:
* It contains $9 links
* It contains items (952 or 995 fields in MARC21/NORMARC and UNIMARC respectively).
MARC21/NORMARC test:
- Do a Z39.50/SRU cataloguing search that retrieves the desired record
- Verify it includes $9 and 952 field(s) by clicking on the MARC link
- Edit your Z39.50 target and add Del952.xsl to the "XSLT File(s) for transforming results:" field
- Re-run the search
=> SUCCESS: the MARC view of the imported record doesn't contain the 952 field
- Edit your Z39.50 target and add Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field
- Re-run the search
=> SUCCESS: the MARC view contains the 952 field (including the $9 subfield), and
all other $9 subfields have been removed
- Edit your Z39.50 target and add
Del952.xsl, Del9LinksExcept952.xsl
to the "XSLT File(s) for transforming results:" field (both, comma separated)
- Re-run the search
=> SUCCESS: the MARC view doesn't contain $9 subfields nor items.
- Repeat for UNIMARC, replacing 952 for 995.
- Sign off :-D
Regards
Tomas
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested under MARC21. Works fine. (Additionally verified 995 with xsltproc.)
As noted on Bugzilla, we could still improve documentation but imo no need
to block these example transformations.
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
I can't resist to put my own signature on this patch, confirming it works as
described with z39.50 Unimarc targets.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit dd385fc2e9e6a2381ff0052582df6f072193cdb2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 13 20:15:22 2014 -0500
Bug 13253 - Unnecessary white space above checkouts table in circulation
On the new checkouts page there is some padding above the checkouts,
relatives' checkouts, and holds tables caused by extra markup in the
table's sDom configuration (http://legacy.datatables.net/ref#sDom):
<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t
This creates several empty <div>s which don't serve any purpose. This
patch simplifies it to:
rt
To test, apply the patch, clear your browser cache, and check out to a
patron who has items checked out, holds on their account, and child
records attached which also have checkouts.
The padding above the table of checkouts, the table of relatives'
checkouts, and the table of holds should match that on the sides.
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Checked per plan on both Check Out and Details pages, spacing appears correct.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Charset.pm | 1 +
koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 4 +--
koha-tmpl/intranet-tmpl/prog/en/js/holds.js | 2 +-
.../prog/en/modules/admin/z3950servers.tt | 2 +-
.../prog/en/modules/help/admin/z3950servers.tt | 26 +++++++++++++++++++-
.../prog/en/modules/serials/subscription-add.tt | 8 +++---
koha-tmpl/intranet-tmpl/prog/en/xslt/Del952.xsl | 17 +++++++++++++
koha-tmpl/intranet-tmpl/prog/en/xslt/Del995.xsl | 17 +++++++++++++
.../prog/en/xslt/Del9LinksExcept952.xsl | 16 ++++++++++++
.../prog/en/xslt/Del9LinksExcept995.xsl | 16 ++++++++++++
svc/members/search | 7 +++++-
t/Charset.t | 11 ++++++++-
t/db_dependent/Holds.t | 7 +++---
13 files changed, 120 insertions(+), 14 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/xslt/Del952.xsl
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/xslt/Del995.xsl
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/xslt/Del9LinksExcept952.xsl
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/xslt/Del9LinksExcept995.xsl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list