[koha-commits] main Koha release repository branch master updated. v3.16.00-1060-g5160117
Git repo owner
gitmaster at git.koha-community.org
Fri Nov 14 14:59:35 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 51601176c6ad9ff5bfc73502b472d4647bab96f1 (commit)
via 57dff1e63f5778a427390215f82909a82f54eccd (commit)
via 87faa1f8304dc5db12e2cd968ac8a2cb6ab6e176 (commit)
via 55acc1036b24ee42c36dac192eb88e3aa314b1e4 (commit)
via 1c26e98f06efeeb7ea96eb85be7ac2c65f95f6ed (commit)
via 85255ef18f68e4c9899081777863b95db4a08fca (commit)
via 1be9f1a0e70d55eeca841f2c3becbbbf9f988b39 (commit)
via b1d1a034b24fdd2264c61584854917d3d19d3b14 (commit)
via 290341d8dbd085e9d60aa38e7c03fa840a85cb3a (commit)
from 900670bd3bd3d1984dbd23e86e78706ff15288f9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 51601176c6ad9ff5bfc73502b472d4647bab96f1
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date: Fri Nov 7 13:04:22 2014 +0100
Bug 13220 - Shipment date not saved when creating an invoice which has a duplicated number
When creating an invoice which has a duplicated number, if the user chooses to 'Create new invoice anyway', previously entered shipment date (todays date by default) is not being saved, because the date value is passed to the script in the wrong format (acqui/parcels.pl expects shipmentdate parameter to be in the system-configured date format, but what it's getting in such cases is ISO-formatted date instead). As a consequence (when receiving orders from invoice whith empty shipment date) 'datereceived' field in order records are also not being populated. Here and there, Koha is using datereceived field to establish if the order was received or not received, so such not-quite-complete orders:
- can be cancelled from the basket (even when they are de facto already received),
- it's not possible to cancel receipt of those orders from the invoice (because Koha is considering them as not yet received).
To reproduce:
1) Make sure you have some system date format configured in your test environment which is different from ISO format (e.g., DD/MM/YYYY) and the AcqWarnOnDuplicateInvoice syspref is enabled
2) Create some invoice with e.g. '11111' number,
3) Create another invoice with the same number (using 'Create new invoice anyway' button)
4) Try to create yet another invoice with the same number; observe that already existing invoice created in step 3) does have empty shipment date.
5) Optional: create some orders and receive them from the invoice with empty shipment date; observe that such orders are not being treated as received in all places (e.g. it's not possible to cancel receipts of such orders, and the message displayed is not in any way helpfull to determine why not).
To test:
1) Apply patch
2) Retest
3) Ensure that the issue is no longer reproductible, and that there are no apparent regressions of any kind.
Signed-off-by: simith <simith at inlibro.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tiny change fixing a bad bug. No problems found, passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 57dff1e63f5778a427390215f82909a82f54eccd
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Nov 12 17:14:32 2014 +0100
Bug 13226: 9999-12-31 should not considered as a valid date
DateTime::Format::DateParse (called in Koha::DateUtils::dt_from_string)
does not manage to parse 9999-12-31 if a time zone is given.
my $date = DateTime->new(year => 9999, month => 12, day => 31);
=> OK
DateTime::Format::DateParse->parse_datetime( '9999-12-31' );
=> OK
DateTime::Format::DateParse->parse_datetime( '9999-12-31',
'America/Los_Angeles' );
=> KO (~20sec on my laptop)
It should not be considered as a valid date when the letter is parsed.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Note that to reproduce the problem you much be checking in items from an
account which has been restricted indefinitely (either manually or by
the overdues process). With this patch such checkins go from taking
around 50 seconds (in my test system) to around 7 to 10 seconds.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Good catch! Works as described, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 87faa1f8304dc5db12e2cd968ac8a2cb6ab6e176
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Nov 14 10:08:08 2014 -0300
Bug 11401: dependency updates
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 55acc1036b24ee42c36dac192eb88e3aa314b1e4
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Nov 14 09:58:40 2014 -0300
Bug 11401: DBIx updates
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1c26e98f06efeeb7ea96eb85be7ac2c65f95f6ed
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Nov 14 09:46:07 2014 -0300
Bug 11401: DBRev 3.17.00.055
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 85255ef18f68e4c9899081777863b95db4a08fca
Author: Magnus Enger <digitalutvikling at gmail.com>
Date: Thu Nov 13 18:43:29 2014 +0000
Bug 11401: QA followup - Make the tests pass
The configs in koha-conf.xml needed to be mocked. There was also
a problem with how the NorwegianPatronDBEndpoint syspref was
getting checked in the .pm.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1be9f1a0e70d55eeca841f2c3becbbbf9f988b39
Author: Magnus Enger <digitalutvikling at gmail.com>
Date: Wed Oct 29 10:26:11 2014 +0100
Bug 11401: QA followup
1) Be more careful when checking the NorwegianPatronDBEnable syspref.
Before:
if ( C4::Context->preference('NorwegianPatronDBEnable') == 1 ) {
After:
if ( C4::Context->preference('NorwegianPatronDBEnable') && C4::Context->preference('NorwegianPatronDBEnable') == 1 ) {
This should avoid complaints if the syspref is not initialized.
2) Fix some empty =head2 POD sections
3) Fix some indentation in patrons.pref, to make xt/yaml_valid.t happy
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
I couldn't find any regressions with adding, editing and deleting members.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b1d1a034b24fdd2264c61584854917d3d19d3b14
Author: Magnus Enger <digitalutvikling at gmail.com>
Date: Wed Oct 29 10:31:26 2014 +0100
Bug 11401: QA followup - fix pod
The QA script was complaining about some dodgy POD in C4/Members.pm,
that was not introduced by bug 11401. This patch fixes the POD, to
keep the QA script happy.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 290341d8dbd085e9d60aa38e7c03fa840a85cb3a
Author: Magnus Enger <digitalutvikling at gmail.com>
Date: Wed Sep 17 10:16:45 2014 +0200
Bug 11401: Add support for Norwegian national library card
This patch makes it possible to sync patron data between Koha and the
Norwegian national patron database, in both directions.
In order to use this, the following information is necessary:
- a username/password from the Norwegian national database of libraries
("Base Bibliotek"), available to all Norwegian libraries
- a special key in order to decrypt and encrypt PIN-codes/passwords,
which is only available to Norwegian library system vendors
- a norwegian library vendor username/password
See http://www.lanekortet.no/ for more information (in Norwegian).
While this is of course an implementation of a specific synchronization scheme
for borrower data, attempts have been made to prepare the ground for other sync
schemes that might be implemented later. Especially the structure of the new
borrower_sync table might be reviewed with an eye to how it might fit other
schemes.
To test:
Since the password and cryptographic key needed to use this functionality
is only available to Norwegian library system vendors, only regression testing
can be done on the submitted code. Suggested things to check:
- Apply the patch and make sure the database update is done. This should add
the new "borrower_sync" table and five new systmpreferences under the
"Patrons" > "Norwegian patron database" category:
- NorwegianPatronDBEnable
- NorwegianPatronDBEndpoint
- NorwegianPatronDBUsername
- NorwegianPatronDBPassword
- NorwegianPatronDBSearchNLAfterLocalHit
- Check that patrons can be created, edited and deleted as usual, when
NorwegianPatronDBEnable is set to "Disable"
- Check that the new tests in t/NorwegianPatronDB.pm run ok, e.g. on a
gitified setup:
$ sudo koha-shell -c "PERL5LIB=/path/to/kohaclone prove -v t/NorwegianPatronDB.t" instancename
- Check that all the other tests still run ok
- Check that the POD in the new files itroduced by this patch looks ok:
- Koha/NorwegianPatronDB.pm
- members/nl-search.pl
- misc/cronjobs/nl-sync-from-koha.pl
- misc/cronjobs/nl-sync-to-koha.pl
- t/NorwegianPatronDB.t
Sponsored-by: Oslo Public Library
Update 2014-09-18:
- Rebase on master
- Split out changes to Koha::Schema
- Incorporate new way of authenticating with NL
Update 2014-10-21:
- Rebase on master
- Use Module::Load to load Koha::NorwegianPatronDB in non-NL-specific
scripts and modules
- Fix the version number of Digest::SHA
- Fix a missing semicolon in kohastructure.sql
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer/PerlDependencies.pm | 20 +
C4/Letters.pm | 1 +
C4/Members.pm | 54 +-
Koha/NorwegianPatronDB.pm | 678 ++++++++++++++++++++
Koha/Schema/Result/Borrower.pm | 19 +-
Koha/Schema/Result/BorrowerSync.pm | 122 ++++
debian/control | 6 +
installer/data/mysql/kohastructure.sql | 18 +
installer/data/mysql/sysprefs.sql | 5 +
installer/data/mysql/updatedatabase.pl | 27 +-
.../prog/en/includes/members-toolbar.inc | 48 +-
.../prog/en/includes/nl-search-form.tt | 9 +
.../intranet-tmpl/prog/en/modules/acqui/parcels.tt | 2 +-
.../prog/en/modules/admin/preferences/patrons.pref | 22 +
.../prog/en/modules/members/deletemem.tt | 42 +-
.../prog/en/modules/members/member.tt | 6 +
.../prog/en/modules/members/memberentrygen.tt | 13 +
.../prog/en/modules/members/moremember.tt | 9 +
.../prog/en/modules/members/nl-search.tt | 176 +++++
kohaversion.pl | 2 +-
members/deletemem.pl | 28 +-
members/memberentry.pl | 19 +-
members/moremember.pl | 14 +
members/nl-search.pl | 161 +++++
misc/cronjobs/nl-sync-from-koha.pl | 202 ++++++
misc/cronjobs/nl-sync-to-koha.pl | 192 ++++++
t/00-load.t | 1 +
t/NorwegianPatronDB.t | 599 +++++++++++++++++
28 files changed, 2461 insertions(+), 34 deletions(-)
create mode 100644 Koha/NorwegianPatronDB.pm
create mode 100644 Koha/Schema/Result/BorrowerSync.pm
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/nl-search-form.tt
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt
create mode 100755 members/nl-search.pl
create mode 100644 misc/cronjobs/nl-sync-from-koha.pl
create mode 100644 misc/cronjobs/nl-sync-to-koha.pl
create mode 100644 t/NorwegianPatronDB.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list