[koha-commits] main Koha release repository branch master updated. v3.18.00-beta-12-gb601923
Git repo owner
gitmaster at git.koha-community.org
Wed Nov 19 15:31:24 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via b60192397c30cc25d8f9ff4eec5f021111ef9c2d (commit)
via 535a224b8710e8218bae40649d72b626d8fc412d (commit)
via f7d31f3916fef9c9475f5af9ba18bf4aaac017ee (commit)
via e2a169dc9d0f233f680e03fff2002d0d7346ae43 (commit)
via 0a41d247b57abe4a4eac25b40516653c3453bc6f (commit)
via 752c8bf043f6255bd53d7ffcaa2dfec1abc918a8 (commit)
via 206157beb1ee607ba3a2f171c55ed395c54ccf14 (commit)
via 428a744843e82da676bb32bb8828061b4fc2a383 (commit)
via 340e23ece5afd6c8fa944140687e2c0fdc7ff634 (commit)
via 1e98ff655db0e85ee3a2564dadcd8a397b21c505 (commit)
via 2ca4841ea4daa109cb4310a22d88de15d915c373 (commit)
via 255f02cad1822965685adac729a19b17769652ea (commit)
from 6cd7c24c11d46bed02601b0e63e62ade2995df8d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b60192397c30cc25d8f9ff4eec5f021111ef9c2d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Sep 23 08:18:45 2014 -0400
Bug 12376 - blinking cursor not clear in larger resolutions
This patch slightly alters the padding on <input> and <textarea> so that
the cursor is more visible.
To test, apply the patch and clear your browser cache. View a variety of
pages in the staff client and confirm that the change does not adversely
affect the display of forms.
Small change that enhances user experience.
Patch behaves as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, small CSS change.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 535a224b8710e8218bae40649d72b626d8fc412d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Nov 12 11:40:14 2014 -0500
Bug 13234 [Follow-up] Make on-site checkouts visible in OPAC
This follow-up makes a few changes to the template:
1. The "show all" / "show 50" links have been modified to show the
current state.
2. The tabs are only shown if the OnSiteCheckouts preference is turned
on.
3. The DataTables configuration has been modified so that title sorting
ignores articles, sorting on the the first column is disabled, and
sorting by date works regardless of your dateformat preference.
4. Some indentation has been corrected and markup comments added.
To test the opacreadinghistory preference must be enabled. Log in to
the OPAC as a patron who has some on-site checkouts as well as regular
checkouts. With OnSiteCheckouts enabled, view the reading history page
and confirm that the tabs work correctly. Test the table sorting
controls.
With OnSiteCheckouts disabled, confirm that the tabs do not appear.
Test the "Show all items"/"Show last 50 items" links and confirm that
the behavior is correct.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Works as described, passes tests and QA script.
Good addition to the new on-site feature.
Note: It would be nice to show the 'on-site' note also in the
liste of checkouts on the summary page!
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit f7d31f3916fef9c9475f5af9ba18bf4aaac017ee
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Nov 12 11:52:46 2014 +0100
Bug 13234: On-site checkouts - OPAC
This patch introduces the code lost in bug 10860 for the OPAC side.
Test plan:
Go on opac-readingrecord.pl and verify the tabs work as expected and the
"show all items" and "show 50 items" links.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e2a169dc9d0f233f680e03fff2002d0d7346ae43
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Sat Nov 15 13:20:31 2014 +0100
Bug 13242: Add a UT to t/DateUtils.t for testing DateTime bug
A bug in DateTime slow down drastically date parsing when the dates are in the
far distant future:
https://metacpan.org/pod/DateTime#Determining-the-Local-Time-Zone-Can-Be-Slow
This UT tests this situation which affects Koha::DateUtils function
dt_from_string() and output_pref().
TO TEST:
- Apply the patch containing the UT
- prove -v t/DateUtils.t
- You see that parsing a 9999-01-01 that take forever (ie more than 1s)
- Apply the patch containing the fix
- prove -v t/DateUtils.t
- No more complain.
Followed test plan. Test behaves as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Works as described - check-ins are now much faster.
Passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0a41d247b57abe4a4eac25b40516653c3453bc6f
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Sat Nov 15 13:23:06 2014 +0100
Bug 13242: Fix DateUtils for 'infinite' dates (ie year 9999)
TEST PLAN:
- Method 1--with UT
- Use the UT associated to this bug, without applying this patch, and then
after applying this patch
- Method 2--using Koha
- Without this patch
- Find a borrower with several checkouts that are not overdue.
- Debarred the borrower
- Go on circ/circulation-home.pl page
- Select Check in tab, and do a check in
- It required more than 20s to display the return.pl page
- Apply the patch, and repeat previous steps
=> return.pl is immediately displayed.
Followed method 2. Time problem no longer exists.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 752c8bf043f6255bd53d7ffcaa2dfec1abc918a8
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Nov 18 10:56:52 2014 +0100
Bug 13276: use t::lib::Mocks::mock_dbh
To use this patch, patch from bug 13274 should be applied too.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 206157beb1ee607ba3a2f171c55ed395c54ccf14
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Nov 17 22:51:16 2014 -0500
Bug 13276: t/XSLT.t shouldn't depend on the DB
To reproduce:
- Stop your MySQL server:
$ sudo service mysql stop
- Run
$ prove t/XSLT.t
=> FAIL: some tests fail because of mysql stopped
To test (MySQL still stopped)
- Apply the patch
- Run
$ prove t/XSLT.t
=> SUCCESS: tests pass because the ycan be loaded regardless of
the absence of the DB server
- Sign off :-D
Regards
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tests pass without db connection for me now.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 428a744843e82da676bb32bb8828061b4fc2a383
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Nov 18 10:45:02 2014 +0100
Bug 13274: Mock new_dbh in t::lib::Mocks
This patch suggests to create a routine to mock C4::Context::_new_dbh.
NOTE: Works the same with and without this secondary patch.
koha-qa tests fine. Less cutting and pasting in the future.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 340e23ece5afd6c8fa944140687e2c0fdc7ff634
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Nov 17 22:25:09 2014 -0500
Bug 13274: t/00-load.t shouldn't depend on the DB
To reproduce:
- Stop your MySQL server:
$ sudo service mysql stop
- Run
$ prove t/00-load.t
=> FAIL: some tests fail because of mysql stopped
To test (MySQL still stopped)
- Apply the patch
- Run
$ prove t/00-load.t
=> SUCCESS: tests pass because the ycan be loaded regardless of
the absence of the DB server
- Sign off :-D
NOTE: Even seems to grab more than expected, which is good.
349 tests in master vs 364 in this branch = 16,
but removed block is only 13 (lines 20-32).
Also ran koha-qa test tool. :)
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Works as described, tests passing now without database available.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1e98ff655db0e85ee3a2564dadcd8a397b21c505
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Nov 18 13:20:19 2014 -0500
Bug 12971 [QA Followup] - Fix error caused by patron not having any checkouts
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
This successfully fixes the problem observed when a patron has no
checkouts.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 2ca4841ea4daa109cb4310a22d88de15d915c373
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Nov 18 07:40:24 2014 -0500
Bug 12971: [QA Followup]
* Makes the status column display "Overdue!" if overdue
* Fixes the due date formatting
* Sorts the checkouts by date due ( oldest to newest )
Note: I found no evidence that this data was previously sorted,
so I kept it simple. Sorting based on system preferences could
be a future enhancement.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
This fixes the issues described for patrons with existing checkouts.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 255f02cad1822965685adac729a19b17769652ea
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Nov 17 12:31:05 2014 -0500
Bug 12971 - Regression: Patron print summary doesn't show checkouts
A patron's print summary should contain a list of checked out items
as it did in 3.16.2 and earlier.
Please note, as of 3.16.2 reserves were no longer part of the print
summary and thus are not part of this bug fixing patch.
Test Plan:
1) Find a patron with checked out items
2) Choose Print -> Print summary
3) Note the lack of a list of checkouts
4) Apply this patch
5) Reload the page
5) Print the summary again
6) Note the list of checkouts
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Works as described, apart from the missing status information
that Owen already noted on the bug.
Passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/DateUtils.pm | 8 +-
.../intranet-tmpl/prog/en/css/staff-global.css | 5 +-
.../prog/en/includes/members-toolbar.inc | 2 +-
.../prog/en/modules/members/moremember-print.tt | 196 ++++++++---------
.../bootstrap/en/modules/opac-readingrecord.tt | 231 ++++++++++++--------
members/summary-print.pl | 104 +++++++++
opac/opac-readingrecord.pl | 1 -
t/00-load.t | 48 ++--
t/DateUtils.t | 22 +-
t/XSLT.t | 28 ++-
t/lib/Mocks.pm | 12 +
11 files changed, 426 insertions(+), 231 deletions(-)
create mode 100755 members/summary-print.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list