[koha-commits] main Koha release repository branch master updated. v3.18.00-beta-78-g8fd15d9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8fd15d90bf91cea0921fe65f147f640acca8ddf7 (commit)
       via  6e7192f0d7a465fda091803baecf52ab88f550d4 (commit)
      from  421761e2743ab260092a5234b7b8b1c33c64107f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8fd15d90bf91cea0921fe65f147f640acca8ddf7
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Oct 9 16:10:24 2014 +0200

    Bug 13053 - Do not use template cache when from commandline
    
    You may define in config a folder (usually /tmp) for TT cache :
    template_cache_dir in etc/koha-conf.xml.
    
    Some perl pages may be launched from commandline, like tools/export.pl.
    Also, the script gather_print_notices.pl uses C4::Templates.
    
    The problem is that when script is launched from Apache, the Unix owner of cache files will be www-data. When script is launched from commandline, like in a cronjob, the Unix owner will be different (like a user named "koha"), causing a crash because cache files can only be read by its owner.
    
    This script disables the template cache if perl script is called from commandline. This cache is certainly only useful for web access.
    Using GATEWAY_INTERFACE env var comes from tools/export.pl
    
    Test plan :
    - Use a dev install of koha installed in a user home, ie "/home/kohadev"
    - Define a folder for template_cache_dir in etc/koha-conf.xml. For example : <template_cache_dir>/tmp</template_cache_dir>
    - Check there is no cached templates already in this forder
    - Create a file "bib.list" containing a few existing biblionumbers
    - As user kohadev, launch : tools/export.pl --record-type=bibs --id_list_file=bib.list
    - Look at cache folder
    => Without patch you see cache files owned by user kohadev
    => With patch there are no cache files
    - Use the Koha interfaces OPAC and Intranet
    => Without patch you get an error : Template process failed: file error - cache failed to write ...
    => With patch you have no error and cache files are generated with Apache user as owner
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, good test plan!
    Passes tests and QA script.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 6e7192f0d7a465fda091803baecf52ab88f550d4
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Sep 8 16:09:22 2014 +0200

    Bug 12886: shelfbrowser script should write headers
    
    opac/svc/shelfbrowser.pl does not write http headers.
    
    On a production server, this patch resolves a server internal error
    (500):
      Bad header=    <div id="shelfbrowser">
    
    I did not reproduce on my local instance, but this should be fixed.
    
    Test plan:
    Verify there is no regression on browsing a shelf (with "en" and translated
    templates)
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes tests and QA script, no regressions found.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Templates.pm          |    6 ++++--
 opac/svc/shelfbrowser.pl |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository