[koha-commits] main Koha release repository branch master updated. v3.16.00-693-ge3099d7
Git repo owner
gitmaster at git.koha-community.org
Thu Oct 16 17:50:33 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e3099d7c597c4b8d1dc7b61bd9d0d0484cbb77a1 (commit)
via 9b9b057c77ce982bf32ac797abfdd00f87102d75 (commit)
via 0df1c58f872679785b4f94fbb79ce4ec501070ec (commit)
via 2d8362773069cda4d82e94827141a83c1843db4a (commit)
via 6d3f1c1caf1ff8bcc320684ff737ea03df921eb0 (commit)
via fb90f71f717e7adc39c4d6d0f6bdb100f05e4695 (commit)
via 31878e1973caa15b309001da8754a5d134f15513 (commit)
via 89ee1aeab745a27000f6f897e2c727391e29b851 (commit)
via e8240f8c2b256bca4f7b6557a788db6ae541c563 (commit)
via ca86375872b1cc605918c33eb6c07ef85026ad4b (commit)
via 3c9004357d48944ce36d3964f7e6f1ba15702b71 (commit)
via 244cfaba71223f1861e7e6efdc3ada0b8fef0af0 (commit)
via 8e09a48e8cc38ced5263ad65d8287a8bb619e5dc (commit)
via 400b538078f9485afcbf4c4fcc4b40e59ec644d5 (commit)
from 31cff582d8b7403e45ad081d79ad8990372e0352 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e3099d7c597c4b8d1dc7b61bd9d0d0484cbb77a1
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Aug 19 10:09:38 2014 +0200
Bug 12646: Display all invoices on the same page
Only first 20 invoices were displayed on the page. Without pagination, DT
did not allow to show others.
This page explicitely removes the pagination option in order to display
all invoices on the page.
Test plan:
1/ Create 21+ invoices
2/ Go on acqui/invoices
3/ Verify all invoices are displayed.
Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9b9b057c77ce982bf32ac797abfdd00f87102d75
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Tue Sep 16 14:48:50 2014 -0300
Bug 12927: Problems with item information tab on acq order from staged page
This patch fixes a regression introduced (by me)
on Bug 12673.
I adds the code needed to display properly all fields
To test:
1) Check that 'AcqCreateItem' syspref is set to 'placing an order'
2) Satage a file with some items
3) Go to a Vendor, create a basket, clic add from staged file, select your file
4) On 'Item information' tab fields are displayed wrong
5) Apply the patch
6) Reload, display must now be fixed
Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0df1c58f872679785b4f94fbb79ce4ec501070ec
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Oct 16 12:34:19 2014 -0300
Bug 8446: (qa followup) Patch reintroduces SolR stuff
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 2d8362773069cda4d82e94827141a83c1843db4a
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Oct 16 12:25:44 2014 -0300
Bug 8446: (qa followup) Tests should be conditional on Test::DBIx::Class
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 6d3f1c1caf1ff8bcc320684ff737ea03df921eb0
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Oct 10 14:41:00 2014 +0000
BUG8446, QA Followup: Add Test::DBIx::Class to dependancies
- To correct tests after converting module to dbic, we need to add the
Test::DBIx::Class module as a dependancy.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
The dependency will probably need to be packaged by us until
it can get into Debian proper.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit fb90f71f717e7adc39c4d6d0f6bdb100f05e4695
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Sep 29 07:51:42 2014 +0000
BUG8446, QA Followup: Use DBIx::Class
- Convert Auth_with_shibboleth to use dbic stanzas.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 31878e1973caa15b309001da8754a5d134f15513
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Sep 23 14:49:15 2014 +0000
BUG8446, QA Followup: Minor Code Tidies
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 89ee1aeab745a27000f6f897e2c727391e29b851
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Sep 23 13:52:07 2014 +0000
BUG8446, QA Followup: Cleanup tabs and license
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e8240f8c2b256bca4f7b6557a788db6ae541c563
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jul 31 15:07:08 2014 +0000
BUG8446, Follow up: Add Unit Tests
Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit ca86375872b1cc605918c33eb6c07ef85026ad4b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jul 31 15:06:19 2014 +0000
BUG8446, Follow up: Refactor to clean up bad practice
- A number of issues were highlighted whilst writing sensible unit tests
for this module.
- Removed unnessesary call to context->new();
- Global variables are BAD!
- Croaking is a wimps way out, we should handle errors early and
properly.
Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3c9004357d48944ce36d3964f7e6f1ba15702b71
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Apr 1 12:15:40 2014 +0000
BUG8446, Follow up: Improve local login fallback
- Local fallback was not very well implemented, this patch adds
better handling for such cases allowing clearer failure messages
- This patch also adds the ability to use single sign on via the
top bar menu in the bootstrap theme.
BUG8446, Follow up: Adds perldoc documentation
- Add some documentation to the Auth_with_Shibboleth module
including some guidance as to configuration.
BUG8446, Follow up: Correct filenames to match guidlines
- Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match
other files present on the system.
BUG8446, Follow up: Correct paths after file rename
BUG8446, Follow up: Implemented single sign out
- This follow up rebases the code against 3.16+ which managed to break
some of the original logic.
- As a side effect of the rebasing, we've also implemented the single
sign out element. Upon logout, koha will request that the shibboleth
session is destroyed, and then clear the local koha session upon
return to koha. Due to the nature of shibboleth however, you will
only truly be signed out of the IdP if they properly support Single
Sign Out (which many do not). As a consequence, although you may
appear to be logged out in koha, you might find that upon clicking
'login' the IdP does NOT request your login details again, but instead
logs you silently back into your koha session. This is NOT a koha bug,
but a shibboleth implementation issue that is well known.
BUG8446, Follow up: Fixed bootstrap login via modal
- The bootstrap theme enable login from any opac page via modal. To
enable this with shibboleth we had to make some template parameters
globally accessible when shibboleth is enabled.
BUG8446, Follow up: Add template rules for Shibboleth and CAS
- Add template rules so that CAS and Shibboleth can coexist.
BUG8446, Follow up: Added default config to config file
BUG8446, Follow up: Embellished perldoc documentation
- Updated perldoc to correct detail about configuring shibboleth
authentication.
- Updated perldoc to include subroutines and their respective functions.
BUG8446, Follow up: Enable configuration of match field
- Added clearer, more flexible, configuration of shibboleth attribute to
koha borrower field matching for authentication
- Correcting of documentation to make it more clear to the current
implementation
- Minor refactoring of code to reduce some code duplication
Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 244cfaba71223f1861e7e6efdc3ada0b8fef0af0
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Mon Oct 21 10:17:08 2013 -0600
BUG8446, Follow up: Remove unnecessary sysprefs, move to config
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 8e09a48e8cc38ced5263ad65d8287a8bb619e5dc
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 29 14:16:27 2013 +0000
BUG8446, Follow up: Adds Shibboleth authentication
- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
work if koha is behind a reverse proxy.
- To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325
BUG8446, Follow up: Adds Shibboleth authentication
- Ensure user is returned to requested page after authentication
- Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345
BUG8446, Follow up: Remove unused imports from scripts
- Remove import of deprecated C4::Utils module from shibboleth
authentication module: Auth_with_shibboleth.pm
Signed-off-by: Jesse Weaver <pianohacker at gmail.com>
Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 400b538078f9485afcbf4c4fcc4b40e59ec644d5
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Wed Feb 15 14:57:02 2012 +0100
BUG8446: Adds Shibboleth authentication
- Use the shibbolethAuthentication syspref to enable Shibboleth authentication
- Configure the shibbolethLoginAttribute to specify which shibboleth user
attribute matches the koha login
- Make sure the OPACBaseURL is correctly set
BUG8446, Follow-up: Adds Shibboleth authentication
- Fix logout bug: shibboleth logout now occurs only when
the session is a shibboleth one.
- Do some refactoring: getting shibboleth username is now
done in C4::Auth_with_Shibboleth.pm (get_login_shib function)
BUG8446, Follow-up: Adds Shibboleth authentication
- Adds redirect to opac after logout
BUG8446, Follow-up: Adds Shibboleth authentication
- Shibboleth is not compatible with basic http authentication
in C4/Auth.pm. This patch fixes that.
BUG8446, Follow-up: Adds Shibboleth authentication
- Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
multiple vhosts.
BUG8446, Follow-up: Adds Shibboleth authentication
- Adds missing protocol for $ENV{'SERVER_NAME'}
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jesse Weaver <pianohacker at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tested with the feide idp.
- LDAP login and logout are working
- local login/logout are still working
- CAS login/logout are still working
Instructions for setup can be found on the wiki:
http://wiki.koha-community.org/wiki/Shibboleth_Configuration
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 113 ++++++++-
C4/Auth_with_shibboleth.pm | 268 ++++++++++++++++++++
C4/Context.pm | 4 +-
C4/Installer/PerlDependencies.pm | 5 +
etc/koha-conf.xml | 1 +
installer/data/mysql/updatedatabase.pl | 1 -
.../prog/en/modules/acqui/addorderiso2709.tt | 12 +
.../prog/en/modules/acqui/invoices.tt | 2 +-
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 12 +
.../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 58 ++++-
.../opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +-
koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt | 16 ++
koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt | 2 +-
opac/opac-main.pl | 1 -
opac/opac-user.pl | 2 +
t/Auth_with_shibboleth.t | 244 ++++++++++++++++++
16 files changed, 722 insertions(+), 21 deletions(-)
create mode 100644 C4/Auth_with_shibboleth.pm
create mode 100644 t/Auth_with_shibboleth.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list