[koha-commits] main Koha release repository branch master updated. v3.16.00-724-g99bfa09
Git repo owner
gitmaster at git.koha-community.org
Wed Oct 22 19:28:54 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 99bfa09cc66567811bb34a504d4507f0f20c6586 (commit)
via 41168fb551ceeb905b75e496eca02bb0076242be (commit)
via 8dfc399a2d42859ab510c9d86c73b6522a3c5335 (commit)
via a7e95356293692a9c4b8202e3600d5db64a2a7b9 (commit)
via f32b0e1243c0d93f42f9385285c3217e70ba7b2a (commit)
via b8b200836e7bfa2711dc5f0542f6f5ddbcf80174 (commit)
via 48b7e1ecef1d768442cd3aa391e7a68865429520 (commit)
via 22395e4168438fdceb00db3384c5082e7bae79e1 (commit)
from 7fafe2afb491c8aff468dc200c705c05b57f4991 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 99bfa09cc66567811bb34a504d4507f0f20c6586
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Oct 17 08:39:19 2014 -0400
Bug 13104 - Changing date or time format on a production server will create duplicate fines!
The system preference TimeFormat decides if times are formatted in 24
hour or 12 hour format. The issue at hand is that this changes the time
description for fines. Let us assume the time format is currently 24
hour, and there are overdue items with accruing fines. When the format
is changed to 12 hour, and fines.pl is run, it will begin looking for
fines with a 12 hour format. Since there are no, it will create a new
fine and you will now have two fines for the same item!
There are solutions which require database manipulation:
1) Update all existing fines from 24 hour to 12 hour format
2) Delete all existing accruing fines so they are all regenerated the
following night
The same situation applies to DateFormat.
The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does
not look for existing fines based on the description.
I believe the best course of action until bug 6427 is pushed to master
is to add a warning to the system preference to not alter it on a
production server with existing fines.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Adds some documentation to warn about the problem.
Tested the new addition shows up in po files.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 41168fb551ceeb905b75e496eca02bb0076242be
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Fri Oct 10 05:03:01 2014 +1300
Bug 12005 : Creating a new zebra connection for each time we need one
Zebra is not designed to have persistent connections, under cgi this
didn't matter the scripts would get a new connection each time, but
under plack we try to use dead connections
This patch changes it so plack works the same way that cgi did.
To test:
Apply this patch
Do some searches
Check everything still works
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 8dfc399a2d42859ab510c9d86c73b6522a3c5335
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Sep 8 13:21:17 2014 +0200
Bug 12884: Get rid of redefined subroutine warnings in dateaccessioned.pl
Instead of removing all warnings, we should remove warnings about the
redefined subroutines.
Test plan:
- link the dateaccessioned plugin with one of your biblio field
- edit an item
- verify they are no warnings in the Koha log file.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a7e95356293692a9c4b8202e3600d5db64a2a7b9
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Oct 16 11:10:50 2014 -0300
Bug 9859: Follow-up - Adding a simple unit test for nsb_clean
This tests uses the example given on the perl file on the
bug report.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit f32b0e1243c0d93f42f9385285c3217e70ba7b2a
Author: Stéphane Delaune <stephane.delaune at biblibre.com>
Date: Wed Mar 20 10:54:46 2013 +0100
Bug 9859: fix nsb_clean side effect
Signed-off-by: Mathieu Saby <mathieu.saby at univ-rennes2.fr>
This sub was causing 2 bugs :
- tools/exports.pl --clean was removing Â
- authority search plugin used in cataloging was removing  in suggested authorities displayed dynamicly (using ajax)
After applying the patch,
- NSB/NSE are still removed by nsb_clean
- tools/exports.pl --clean is no more removing Â
- authority search plugins is no more removing Â
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b8b200836e7bfa2711dc5f0542f6f5ddbcf80174
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Feb 21 09:44:21 2014 -0500
Bug 11812 - Add missing "required" indicator to fields which are required
Form fields in the staff client which are required should be configured
to be so by doing several things:
- Add a class "required" to the field's <label>
- Add a class "required" to the form field
- Add 'required="required"' to the form field
- Apppend a <span class="required">Required</span> after the form field.
Several places in the templates are missing the <span>. This patch adds
them.
To test, apply the patch and view the following pages to confirm that
the "Required" text appears:
- Acquisitions -> Add an order to a basket from a new (empty) record.
Title, quantity, and fund should indicate they are required.
- Administration -> Authority types -> New authority type. The
authority type and description fields should indicate they are
required.
- Administration -> Authority types -> MARC structure -> New tag. The
tag field should indicate it is required.
- Patron types and categories -> New category. Category code,
description, and category type should indicate that they are required.
FIXME: Enrollment period is required but the user must choose one. I'm
not sure how to handle that clearly.
- Tools -> CSV profiles. Profile name, profile type, and profile MARC
fields should indicate they are required on both the new and edit
forms.
- Administration -> Manage MARC modification templates. Under "Create a
new template" the name field should indicate that it is required.
- Tools -> Batch patron modification -> Submit a batch for editing. Any
fields which are required according to your BorrowerMandatoryField
system preference should indicate that they are required.
Patch behaves as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
QA Edits: Re-worded the "required" not on the batch patron edit form,
added a missing word to the help text on that page. On the csv-profiles
page I removed an unnecessary "javascript:" protocol from the markup.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works and passes QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 48b7e1ecef1d768442cd3aa391e7a68865429520
Author: Stéphane Delaune <stephane.delaune at biblibre.com>
Date: Wed Oct 15 15:23:35 2014 +0200
Bug 13085: bugfix to allow call of export.pl in commandline without id_list_file parameter
Test plan
1/ run ./tools/export.pl
2/ notice an error like cannot open 0: No such file or directory at ./tools/export.pl line 209.
3/ apply patch
4/ run again
5/ no errors
Signed-off-by: Chris <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, adding an additional check.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 22395e4168438fdceb00db3384c5082e7bae79e1
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Oct 22 09:31:01 2014 -0300
Bug 12068: (rm followup) remove useless newline introduced on merging
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Charset.pm | 7 ++--
C4/Context.pm | 35 +++++---------------
C4/Installer/PerlDependencies.pm | 1 -
cataloguing/value_builder/dateaccessioned.pl | 5 +--
.../prog/en/modules/acqui/neworderempty.tt | 3 ++
.../prog/en/modules/admin/auth_tag_structure.tt | 5 ++-
.../prog/en/modules/admin/authtypes.tt | 6 +++-
.../prog/en/modules/admin/categorie.tt | 17 ++++++++--
.../en/modules/admin/preferences/i18n_l10n.pref | 4 +--
.../prog/en/modules/tools/csv-profiles.tt | 30 ++++++++++++-----
.../modules/tools/marc_modification_templates.tt | 5 +--
.../prog/en/modules/tools/modborrowers.tt | 7 ++--
t/Charset.t | 7 +++-
tools/export.pl | 2 +-
14 files changed, 78 insertions(+), 56 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list