[koha-commits] main Koha release repository branch master updated. v3.16.00-782-gaa92304
Git repo owner
gitmaster at git.koha-community.org
Mon Oct 27 16:26:10 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via aa9230436d034f038ecccff7470bb3d6012d3441 (commit)
via be9dec3e13562fc8b68167b4e1d530d1465187e3 (commit)
via 2303b65d19db53b10f42f18f6dd2248e12dbcdfa (commit)
via f13eca42341ed096c92cc14d8064a39dc4a615f9 (commit)
via 65e6deb5fad8eeac8a94748c6760723769295cae (commit)
via d7f824e501a95893a8ab3db1740fe30f7ee48ed3 (commit)
from ca756f44d76df3074b4b53c97898f26ede65a711 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit aa9230436d034f038ecccff7470bb3d6012d3441
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Oct 27 12:28:23 2014 -0300
Bug 13088: DBRev 3.17.00.033
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit be9dec3e13562fc8b68167b4e1d530d1465187e3
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Oct 20 12:12:00 2014 -0300
Bug 13088: Allow the user to specify a max amount of facets to show
This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount)
to set the max facets to show for each facet category. It defaults to 20 if
the syspref is absent or empty.
To test:
- Have a search with lots of facet results (with some category showing the "See more" link).
- Jump to "See more", notice it shows more than 20 facet values.
- Apply the patch, reload the page.
=> SUCCESS It only shows 20 (default hardcoded value)
- Change the FacetsMaxCount syspref to other value (e.g. 15 or 100).
- Reload
=> SUCCESS: it shows the expected amount.
- Sign off :-D
Regards
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Test plan completed successfully
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Passes tests and QA script, works as described.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 2303b65d19db53b10f42f18f6dd2248e12dbcdfa
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Oct 20 13:46:28 2014 -0300
Bug 13088: Add a syspref so the user can chose the amount of facets to show
This patch introduces a syspref (FacetMaxCount) that controls how many
facets to show for each category (e.g. Author).
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit f13eca42341ed096c92cc14d8064a39dc4a615f9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Oct 21 14:05:31 2014 -0400
Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl
This patch converts an id to a class in order to avoid duplicate id
attributes on one page.
To test you must have XSLT enabled with the default setting. Perform a
search in the OPAC and confirm that the display of location looks
correct.
Run the resulting page through a validator using an in-browser tool like
Firefox's Html Validator addon or using the W3C's validator.w3.org. The
results should not complain of duplicate id attributes.
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
OK for me. Obvious mistake: I can confirm FF HTML validator reports it, and
stop reporting it after applying this patch.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
I can confirm this fix is correct.
Also, I found that jQuery doesn't like repeated ids in some cases
so this will make customizing easier.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 65e6deb5fad8eeac8a94748c6760723769295cae
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Oct 22 00:18:27 2014 -0400
Bug 13128 - Add span with id for logged in branch name, add hidden span for branchcode
It would be nice if there were a simple way to access the name and
branchcode of the currently logged in library, as well as the logged in
user via JavaScript ( via intranetuserjs ).
I propose the following:
1) Remove the whitespace surrounding the loggedinusername span
2) Wrap the logged in branch name with a span that has an id
3) Add the branchcode in a hidden span that has an id
Test Plan:
1) Apply this patch
2) Log into Koha
3) Inspect the html source code
4) Note the lack of whitespace within the tag <span class="loggedinusername">[% loggedinusername %]</span>
5) Note the logged in branch name is now surrounded by a span with an id
6) Note below that is a span containing the branchcode, also with an id.
7) Verify the branchcode span is hidden by default.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Small template change, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d7f824e501a95893a8ab3db1740fe30f7ee48ed3
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Oct 23 21:32:30 2014 -0300
Bug 13140: Add a notice on the About page about GRS-1 deprecated
This patch changes the text for zebra_auth_index_mode and zebra_bib_index_mode
entries missing on koha-conf.xml telling the user GRS-1 is deprecated.
It also adds another check for those preferences set to GRS-1, and shows a
warning message if set to grs1.
To test:
- Apply the patch and try all combinations:
- zebra_auth_index_mode and zebra_bib_index_mode missing
- zebra_auth_index_mode and zebra_bib_index_mode set to grs1
- Sign off :-D
Regards
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
I've played with the 3 related koha-conf.xml file parameters:
zebra_auth_index_moda, zebra_bib_index_mode missing, and use_zebra_facets.
Inconsitencies are properly reported in About page thanks to this patch. It
would be helpfull to admin upgrading their Koha installation.
And by the way, thanks Tomas for the new Zebra facets functionnality. It's a
'joy' to see it into Koha.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Search.pm | 5 +--
about.pl | 6 ++++
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 11 ++++++-
.../intranet-tmpl/prog/en/includes/header.inc | 8 ++---
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 34 ++++++++++++++++++--
.../en/modules/admin/preferences/searching.pref | 6 ++++
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 2 +-
kohaversion.pl | 2 +-
9 files changed, 64 insertions(+), 11 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list