[koha-commits] main Koha release repository branch master updated. v3.16.00-850-g32bb906

Thu Oct 30 04:30:01 CET 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  32bb90604be79ea97dacc7a02dcbce392ea303fb (commit)
       via  34d02c375fe7c0793c022662c6b233da4a341a0a (commit)
       via  19d3e550322f1ae057c7f6a0ad603ef5b32ce8e7 (commit)
       via  eedc8e3543863d85bf151c7142f886fa7bf67e85 (commit)
       via  53a6369ba32dfc6479f064eb018ee2d32026f45a (commit)
       via  407c2fe7c0e1597aee39905d59f370b2b89ebfc7 (commit)
       via  98a3aa4d8ff816fe2d51f7f148f14438ea8db4e0 (commit)
       via  4f6d1c7ae2e6b3f03a5d1ecc05bda67c9789873c (commit)
      from  68078b0ce739a3af2b8122c436744ae8cdffc840 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 32bb90604be79ea97dacc7a02dcbce392ea303fb
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Oct 22 20:51:22 2014 -0400

    Bug 12916 - Use of uninitialized values $max and $min in C4/Tags.pm

    When the stratify_tags function is called without any tags, the
    $min and $max variables are left undefined, which triggers a
    warning message about uninitialized values in the subtraction.

    TEST PLAN
    ---------
    1) prove -v t/db_dependent/Tags.t
       -- should succeed, but there is no test for empty tags.
    2) Make sure that you have no tags
    3) In Opac, go to 'Tag cloud'
    4) Check the opac error log file
       (e.g. ~/koha-dev/var/log/koha-opac-error_log) for entries
       regarding uninitialized values $max and $min in C4/Tags.pm
    5) apply this patch
    6) prove -v t/db_dependent/Tags.t
       -- should still succeed, though no tests are added.
    7) Reload page 'Tag cloud'
       -- Result: No additional warnings in opac error log file.

    Signed-off-by: Chris <chris at bigballofwax.co.nz>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    New and old tests pass. Works as described.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 34d02c375fe7c0793c022662c6b233da4a341a0a
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Oct 22 15:50:08 2014 -0400

    Bug 12916 - Missing Test to demonstrate warnings.

    Modifying C4/Tags.pm should have tests.

    TEST PLAN
    ---------
    1) Apply this test patch only.
    2) prove -v t/db_dependent/Tags.t
       -- should see two warnings.
    3) Apply the first patch.
    4) prove -v t/db_dependent/Tags.t
       -- no warnings.

    Signed-off-by: Chris <chris at bigballofwax.co.nz>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 19d3e550322f1ae057c7f6a0ad603ef5b32ce8e7
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Tue Oct 28 18:10:33 2014 -0300

    Bug 12901: (QA followup) correct copy and paste error

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Works as described now, no problems found.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit eedc8e3543863d85bf151c7142f886fa7bf67e85
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Sep 15 10:44:16 2014 -0300

    Bug 12901: (consistency followup) add buildBiblioDefaultViewURL to MARC21 XSLT

    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

    http://bugs.koha-community.org/show_bug.cgi?id=9828

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 53a6369ba32dfc6479f064eb018ee2d32026f45a
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Sep 15 10:43:39 2014 -0300

    Bug 12901: BiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT

    Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

    http://bugs.koha-community.org/show_bug.cgi?id=9828

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 407c2fe7c0e1597aee39905d59f370b2b89ebfc7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Oct 8 14:27:40 2014 +0200

    Bug 13028: Followup adding a -partial flag for partial compares

    If you compare the database with a partial pref file, you may not be
    interested in lots of lines saying that a pref is not in the file. You
    were already aware of that ;)
    If you add the -partial flag, these lines will be skipped.

    Test plan:
    Do as described above.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Works as described, passes tests and QA script.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 98a3aa4d8ff816fe2d51f7f148f14438ea8db4e0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Oct 6 14:09:53 2014 +0200

    Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194

    If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high.

    This is corrected by a better test of the hash value in the CheckVersionPref subroutine.

    Test plan:
    [1] Create a small pref file and remove the version pref (if present). You
    could for instance do a pref backup and remove most lines.
    [2] Use the restore option with and without this patch.
        So, something like:
            maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f 9999crucial.pref
    [3] Check on the error message and the pref count.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 4f6d1c7ae2e6b3f03a5d1ecc05bda67c9789873c
Author: Frédéric Demians <f.demians at tamil.fr>
Date:   Sat Oct 25 14:09:34 2014 +0200

    Bug 13145 UNIMARC 610 tag isn't displayed in OPAC when there is no $9 subfield

    On OPAC detail page, subject fields are not displayed when they are not linked
    to authorities ($9 subfield). This is due to a misplelling in UNIMARC XSL
    detail page.

    TO TEST:

    (1) On a Koha UNIMARC, find out a biblio record with a 610 field, without $9
        subfield. Something like:

        610 1 $a Aliment -- Approvisionnement -- Europe -- Histoire

        Or add such a field to an existing record.

    (2) Check that OPACXSLTDetailsDisplay is set to 'default'

    (3) See this record on OPAC detail page. You must see 'Subject: ' => nothing
        after the 'Subject' label. If your record contains several 610 fields
        without $9, the | character will appear, separating no content.

    (4) Apply the patch.

    (5) Reload the page seen at step (3): subject is displayed now.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, tested on a UNIMARC installation.
    Small XSLT change.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Tags.pm                                         |    2 +-
 .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl   |   26 ++++++++------------
 .../bootstrap/en/xslt/MARC21slimUtils.xsl          |   18 ++++++++++++++
 .../bootstrap/en/xslt/NORMARCslim2OPACResults.xsl  |   17 ++++++++++---
 .../bootstrap/en/xslt/NORMARCslimUtils.xsl         |   18 ++++++++++++++
 .../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl  |    9 +++++--
 .../bootstrap/en/xslt/UNIMARCslimUtils.xsl         |   21 +++++++++++++++-
 misc/maintenance/cmp_sysprefs.pl                   |   10 ++++++--
 t/db_dependent/Tags.t                              |   13 +++++++---
 9 files changed, 106 insertions(+), 28 deletions(-)

hooks/post-receive
-- 
main Koha release repository