From gitmaster at git.koha-community.org Mon Sep 1 15:46:34 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 01 Sep 2014 13:46:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-515-g738f100 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 738f1001af6239a8893c3050ca21ea99854805b8 (commit) via b23d5d84b07ce7011169c692ddc7569c9763c00e (commit) via f5b26fd0ce2978d06813cfe0814f587d9ca15085 (commit) via 1de8a7d8997d6a8a3dc1885c79f4b36f94adf759 (commit) via 88521dda625feb108a1f6734a700e3325abd0890 (commit) via eb4cb953ec3e4e48cec23c362ad29e6596854586 (commit) via b4cc38344004348268f168ec8400a3e24c7c1012 (commit) via db1929094fd06e835fb6a1f46cda7ce018a1f852 (commit) via 168871403c3bc8df91d6be65caba4bdd49745085 (commit) via aedb3e3df8fbe1b4731e2fbfc7453c84bd9925e5 (commit) via 91d5a8384939b6a6a6082ccaef69645ef31f91e2 (commit) via a06b1ac7285a6922e35141deeeada099be4962d5 (commit) via 8c7377d21d8ff3460d920b555c801d4bff322840 (commit) via fb0834e8f582e9e268ecef6de891ba5dc25c6fd9 (commit) via 5b0d410d2deb10777058c262f4f353b5bbafce7d (commit) via 7748facfa5e2e9f149ba85af8d988a113ced6177 (commit) via b124020968f978cd17a3b0784867ec2f0e1d2489 (commit) via 2e0671a1eda2099355e5e958d05f3a18953de987 (commit) via 88f26fa90742dbd422995d19e8f26e8d81638b65 (commit) from 4e1aaa4d589f1974ac9ec51e74367ac413a35699 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 738f1001af6239a8893c3050ca21ea99854805b8 Author: Robin Sheat Date: Wed May 22 14:38:08 2013 +1200 Bug 10308 - local subjects can use authorities too This adds entries for 690-699 to the authorities linker, so they get linked up like everything else. To Test: * make sure your framework doesn't have 690 set up to link to authorities (or it'll get linked as part of cataloguing.) * add a subject with some term to the 690$a field. * add an authority for TOPIC_TERM with the matching term. * make sure zebra is up to date. * run link_bibs_to_authorities.pl over your system. * check that the authority is now linked to your record. * repeat with the other 69x fields if you like. Signed-off-by: Bernardo Gonzalez Kriegel Tested using 696a (PERSO_NAME). Works as described, no errors Signed-off-by: Katrin Fischer This works as described, but linked authorities won't search correctly when clicking on the link on the detail page, as the 69x $9 is not indexed. Signed-off-by: Tomas Cohen Arazi commit b23d5d84b07ce7011169c692ddc7569c9763c00e Author: Tomas Cohen Arazi Date: Tue Jul 29 16:12:52 2014 -0300 Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit f5b26fd0ce2978d06813cfe0814f587d9ca15085 Author: Tomas Cohen Arazi Date: Tue Jul 29 16:09:18 2014 -0300 Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 1de8a7d8997d6a8a3dc1885c79f4b36f94adf759 Author: Tomas Cohen Arazi Date: Mon Sep 1 10:25:25 2014 -0300 Bug 6536: (RM followup) make DBIx::Class::Schema::Loader happy Signed-off-by: Tomas Cohen Arazi commit 88521dda625feb108a1f6734a700e3325abd0890 Author: Tomas Cohen Arazi Date: Mon Sep 1 10:11:34 2014 -0300 Bug 6536: DBRev 3.17.00.017 Signed-off-by: Tomas Cohen Arazi commit eb4cb953ec3e4e48cec23c362ad29e6596854586 Author: Marcel de Rooy Date: Thu Aug 28 15:17:34 2014 +0200 Bug 6536: Follow-up: Updating installer sql files for z3950servers (Part 2) This patch renames name to servername and type to servertype. Signed-off-by: Marcel de Rooy Tested all sql files by script. Signed-off-by: Tomas Cohen Arazi commit b4cc38344004348268f168ec8400a3e24c7c1012 Author: Marcel de Rooy Date: Thu Aug 28 14:59:56 2014 +0200 Bug 6536: Follow-up: Updating web installer sql files for z3950servers Removing icon, description and position from installer sql files. Not all files contained them. Signed-off-by: Marcel de Rooy I have run all sql files on an empty table by script. Signed-off-by: Tomas Cohen Arazi commit db1929094fd06e835fb6a1f46cda7ce018a1f852 Author: Tomas Cohen Arazi Date: Wed Aug 27 13:24:18 2014 -0300 Bug 6536: QA Follow-up for fixing a unit test under Perl 5.18 The last test on the first series, fails randomly on Perl 5.18: not ok 12 - Third query makes no difference # Failed test 'Third query makes no difference' # at t/db_dependent/Breeding.t line 104. # got: '' # expected: '1' # Looks like you failed 1 test of 12. not ok 1 - _build_query This change makes tests pass. Please consider if this needs to be fixed (i.e. sort order matters) or the test needs to be rewritten. Signed-off-by: Marcel de Rooy I agree with adding the sort. (The need for doing this in Perl 5.18 is another topic.) Signed-off-by: Tomas Cohen Arazi commit 168871403c3bc8df91d6be65caba4bdd49745085 Author: Marcel de Rooy Date: Wed Aug 27 16:56:11 2014 +0200 Bug 6536: QA Follow-up for removing warnings from QA tools Resolved: [1] FAIL C4/Breeding.pm FAIL critic ControlStructures::ProhibitMutatingListFunctions Signed-off-by: Marcel de Rooy No warnings anymore. Signed-off-by: Tomas Cohen Arazi commit aedb3e3df8fbe1b4731e2fbfc7453c84bd9925e5 Author: Marcel de Rooy Date: Wed Aug 27 16:45:56 2014 +0200 Bug 6536: QA Follow-up: Add some unit tests for Z3950Search in Breeding.pm This patch may serve as a starting point for more unit tests in this part of the code. In this patch most internal subroutines of Z3950Search are covered. In the XSLT part we reuse a XSL template from the XSLT_Handler.t test. It needed a little tweaking for namespaces. And added the indicators on the 990 field. Test plan: Run both Breeding.t and XSLT_Handler.t. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 91d5a8384939b6a6a6082ccaef69645ef31f91e2 Author: Marcel de Rooy Date: Mon Aug 25 14:52:58 2014 +0200 Bug 6536: QA Follow-up for string changes referring to Z39.50 Z39.50 search now includes SRU targets. This patch only touches strings referring to it. No changes in behavior. It replaces Z39.50 with Z39.50/SRU or external. Deletes obsolete template z3950/searchresult.tt: not in use for some time. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit a06b1ac7285a6922e35141deeeada099be4962d5 Author: Marcel de Rooy Date: Thu Aug 21 14:47:06 2014 +0200 Bug 6536: [QA Follow-up] Remove surrounding spaces in sru_fields This patch only removes surrouding spaces at comma and equals-sign while passing the options in sru_fields to the ZOOM object. Test plan: If you add spaces between options in sru_fields, searching should still work. E.g. sru_fields= sru = get , sru_version = 1.1 Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 8c7377d21d8ff3460d920b555c801d4bff322840 Author: Marcel de Rooy Date: Thu Jul 10 17:21:21 2014 +0200 Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit fb0834e8f582e9e268ecef6de891ba5dc25c6fd9 Author: Marcel de Rooy Date: Thu Jun 5 14:20:37 2014 +0200 Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. Signed-off-by: Giuseppe Angilella Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 5b0d410d2deb10777058c262f4f353b5bbafce7d Author: Marcel de Rooy Date: Thu Jun 5 08:55:09 2014 +0200 Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. Signed-off-by: Giuseppe Angilella Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 7748facfa5e2e9f149ba85af8d988a113ced6177 Author: Marcel de Rooy Date: Wed Jul 16 16:38:57 2014 +0200 Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. Signed-off-by: Giuseppe Angilella Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit b124020968f978cd17a3b0784867ec2f0e1d2489 Author: Marcel de Rooy Date: Thu May 22 10:08:42 2014 +0200 Bug 6536: Update DBIx schema of z3950servers for testing This patch adjusts the DBIx schema file for z3950servers table. This can be used for testing this set of patches. When the report is pushed, the RM should update the DBIx schema. Signed-off-by: Giuseppe Angilella Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 2e0671a1eda2099355e5e958d05f3a18953de987 Author: Marcel de Rooy Date: Thu May 1 15:07:12 2014 +0200 Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 88f26fa90742dbd422995d19e8f26e8d81638b65 Author: Marcel de Rooy Date: Thu May 22 15:37:29 2014 +0200 Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. Signed-off-by: Giuseppe Angilella Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 3 +- C4/Breeding.pm | 268 ++++++++++++-------- C4/Heading/MARC21.pm | 6 + Koha/Schema/Result/Z3950server.pm | 92 ++++--- acqui/z3950_search.pl | 14 +- patron_lists/lists.pl => admin/sru_modmapping.pl | 36 +-- admin/z3950servers.pl | 16 +- cataloguing/z3950_auth_search.pl | 2 +- cataloguing/z3950_search.pl | 14 +- .../mysql/de-DE/optional/sample_z3950_servers.sql | 2 +- .../mysql/en/optional/sample_z3950_servers.sql | 2 +- .../mysql/es-ES/optional/sample_z3950_servers.sql | 2 +- .../data/mysql/fr-FR/2-Optionel/z3950_BNF.sql | 2 +- installer/data/mysql/kohastructure.sql | 14 +- .../data/mysql/nb-NO/2-Valgfritt/z3950servers.sql | 12 +- .../mysql/pl-PL/optional/sample_z3950_servers.sql | 2 +- .../ru-RU/optional/z39-50servers_collection.sql | 18 +- .../uk-UA/optional/z39-50servers_collection.sql | 18 +- installer/data/mysql/updatedatabase.pl | 29 ++- .../intranet-tmpl/prog/en/includes/admin-menu.inc | 2 +- .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 +- .../prog/en/includes/z3950-admin-search.inc | 4 +- .../prog/en/modules/acqui/z3950_search.tt | 4 +- .../prog/en/modules/admin/admin-home.tt | 4 +- .../prog/en/modules/admin/sru_modmapping.tt | 91 +++++++ .../prog/en/modules/admin/z3950servers.tt | 77 ++++-- .../prog/en/modules/catalogue/results.tt | 2 +- .../prog/en/modules/cataloguing/addbiblio.tt | 4 +- .../prog/en/modules/cataloguing/addbooks.tt | 2 +- .../en/modules/cataloguing/z3950_auth_search.tt | 2 +- .../prog/en/modules/cataloguing/z3950_search.tt | 38 +-- .../prog/en/modules/z3950/searchresult.tt | 45 ---- kohaversion.pl | 2 +- t/db_dependent/Biblio.t | 12 +- t/db_dependent/Breeding.t | 181 +++++++++++++ t/db_dependent/XSLT_Handler/test01.xsl | 4 +- 36 files changed, 702 insertions(+), 328 deletions(-) copy patron_lists/lists.pl => admin/sru_modmapping.pl (57%) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping.tt delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/z3950/searchresult.tt create mode 100644 t/db_dependent/Breeding.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 1 16:06:51 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 01 Sep 2014 14:06:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-521-g19f2f0e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 19f2f0e7764675d52e31e81684c7939938f5a6f1 (commit) via 31847c7bd5a4d6fd77bf6c15e08764a44658a05e (commit) via 7a325b55d16fa9e2a5e8b725d5eb00844d674451 (commit) via b96a209ff70d2e74ac230f0f0acec22c74d5b9d6 (commit) via 16636c34d25054fd8d8f9dfbfcdfc6fe6fe7020b (commit) via ecab8f3dd225080e6339c267d886ddc7eb9143d2 (commit) from 738f1001af6239a8893c3050ca21ea99854805b8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 19f2f0e7764675d52e31e81684c7939938f5a6f1 Author: Jonathan Druart Date: Fri Jun 6 16:36:46 2014 +0200 Bug 12309: Adapt zipcode wording to match the other patron pages Replace "Zip code" with "Zip/Postal code" which is used in members/memberentry.pl and members/moremember.pl. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 31847c7bd5a4d6fd77bf6c15e08764a44658a05e Author: Owen Leonard Date: Thu May 22 09:23:45 2014 -0400 Bug 12309 - Add more fields to batch patron modification tool It would be helpful to be able to use the batch patron modification tool to update city, state, zipcode, and country. This patch adds this functionality. This patch corrects an error in the batch modification script which would have incorrectly marked first name as required if surname was required. This patch also converts the table sorting configuration to use table header class names instead of index-based sorting for columns containing dates. To test, apply the patch and submit a batch of patrons to the batch patron modification tool (Tools -> Batch patron modification). In the list of patrons which will be modified you should see columns for city, state, zipcode, and country. Table sorting should work correctly without errors, including the registration and expiry date columns. In the list of fields which can be batch modified you should see inputs for city, state zipcode, and country. These fields should correctly reflect mandatory/not mandatory based on the BorrowerMandatoryField system preference. Submit batch changes to a variety of fields and confirm that changes are applied correctly. On the page of results the table should correctly show all fields and be sorted correctly. Signed-off-by: cachan Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 7a325b55d16fa9e2a5e8b725d5eb00844d674451 Author: Bernardo Gonzalez Kriegel Date: Wed Apr 9 22:30:35 2014 -0300 Bug 12061 - tmpl_process3.pl - Include/exclude file by name This patch adds options to include/exclude files by matching their names. Also modifies current code to check only filenames (not dirs) Checking is case insensitive !! NOTE: The difference between -f and -m is subtle, but important. They differs mainly on update,: -f do a merge, -m a replace To test after patch: A) Include only 'normarc' 1. create cd misc/translator perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s normarc.po -r -m normarc - check provenance of strings egrep "^#:" normarc.po | cut -d":" -f2 | sort | uniq - only files with normarc in their names must be present 2. update perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s normarc.po -r -m normarc - repeat check 3. install mkdir test perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o ./test -s normarc.po -r -m normarc - check name of created files rm -rf test normarc.po B) Exclude 4. create perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s xnormarc.po -r -n normarc - check provenance egrep "^#:" xnormarc.po | cut -d":" -f2 | sort | uniq | grep -i normarc - there must be no results 5. update perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s xnormarc.po -r -n normarc - check provenance 6. install mkdir test perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o ./test -s xnormarc.po -r -n normarc - check files find test | grep -i normarc - there must be no results You can also try another combination, use for example "-m patron -m user -m bottom" (or use -n) or mixed "-m marc -n normarc", do create/install and look filenames Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit b96a209ff70d2e74ac230f0f0acec22c74d5b9d6 Author: Bernardo Gonzalez Kriegel Date: Sun Apr 6 21:39:08 2014 -0300 Bug 12061 - tmpl_process3.pl - Multiple source dir This patch adds the option to use multiple source dirs for tmpl_process3.pl on create/update actions. To test after patch: A) Old 1. install cd misc/translator perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s bootstrap.po -r 2. update perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap -s bootstrap.po -r 3. install mkdir test perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap -s bootstrap.po -r -o ./test -q - check same number of files ls -lR ../../koha-tmpl/opac-tmpl/bootstrap | wc -l ls -lR ./test | wc -l rm -f bootstrap.po B) New 4. create from multiple sources perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/prog/en -i ../../koha-tmpl/opac-tmpl/bootstrap/en -i ../../koha-tmpl/opac-tmpl/ccsr/en -s opac.po -r 5. update from multiple source perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/prog/en -i ../../koha-tmpl/opac-tmpl/bootstrap/en -i ../../koha-tmpl/opac-tmpl/ccsr/en -s opac.po -r 6. install (must give an error) perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/prog/en -i ../../koha-tmpl/opac-tmpl/bootstrap -s opac.po -r -o ./test 7. updated help perl tmpl_process3.pl --help Any other functionality must not be affected Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 16636c34d25054fd8d8f9dfbfcdfc6fe6fe7020b Author: Bernardo Gonzalez Kriegel Date: Sun Apr 6 19:21:47 2014 -0300 Bug 12061 - tmpl_process3.pl - Remove obsoleted strings/backups This patch modifies the update process for PO files, removing obsoleted strings. Currently they are removed manually as part of the standar procedure of strings update. Also backup files (*~) need to be removed manually. To test: 1. Update translation files for any language, ej. fi-FI (cd misc/translation; perl translate update fi-FI) 2. Check existence of obsoleted strings egrep "#~ msg" misc/translator/po/fi-FI-* 3. Check existence of backup files ls misc/translator/po/fi-FI-*~ 4. Reset to HEAD and clean 5. Apply the patch 6. Update again, check there are no more obsoleted strings nor backup files Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit ecab8f3dd225080e6339c267d886ddc7eb9143d2 Author: Liz Rea Date: Thu Aug 28 10:28:33 2014 +1200 Bug 12837 - barcode entry box out of alignment To test: Load up a circulation page, note that the middle of the barcode field doesn't line up with the Check-out button. note that the date-select tickbox is also not aligned with the rest of the things on it's line Apply the patch Reload the page, verify that things are now in alignment. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/css/staff-global.css | 4 +- .../prog/en/modules/tools/modborrowers.tt | 28 ++++++-- misc/translator/tmpl_process3.pl | 76 +++++++++++++------- tools/modborrowers.pl | 31 +++++++- 4 files changed, 102 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 2 15:41:33 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 02 Sep 2014 13:41:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-525-g5faef12 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5faef12f68671a0e6460e219c98c86ff86e478be (commit) via 063bf5d9fa08a332a92e16d79eee16d264ca281e (commit) via 48e0107684267762b55ae0eae3e3cfccbb34d92b (commit) via 14ad9131f95f9e3a51ff1e6bb7c82f6832522b2c (commit) from 19f2f0e7764675d52e31e81684c7939938f5a6f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5faef12f68671a0e6460e219c98c86ff86e478be Author: Tomas Cohen Arazi Date: Tue Sep 2 10:40:32 2014 -0300 Bug 12205: (regression tests) HoldsInNoissuesCharge controls GetMemberAccountBalance behaviour regarding hold charges Signed-off-by: Tomas Cohen Arazi commit 063bf5d9fa08a332a92e16d79eee16d264ca281e Author: Tomas Cohen Arazi Date: Mon Sep 1 12:58:22 2014 -0300 Bug 12205: DBRev 3.17.00.018 Signed-off-by: Tomas Cohen Arazi commit 48e0107684267762b55ae0eae3e3cfccbb34d92b Author: Chris Cormack Date: Wed May 7 10:15:20 2014 +1200 Bug 12205 : Add a system preference allowing hold charges to block circ Currently, if you have holds charges, they are not taken into consideration when circulating items. Manual Invoices, and rental charges are governed by a systempreference Holds are never counted And all other charges (overdues, lost items etc) are counted This patch adds a systempreference to allow Hold charges to be counted as well. To test 1/ Set a borrower category to have holds charges 2/ Place a hold for a borrower in that category 3/ Go to checkout, notice that charge is not showing or blocking on that screen 4/ apply patch 5/ notice that charge now shows on checkout Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 14ad9131f95f9e3a51ff1e6bb7c82f6832522b2c Author: Marc V?ron Date: Sun Jul 27 08:03:23 2014 +0200 Bug 12705 - News not possible for one sublanguage if two sublanguages are installed To test: - Install two language variants (e.g. de-DE and de-CH) - Create OPAC news for each of them - Verify that they are displayed in OPAC as appropriate Signed-off-by: Bernardo Gonzalez Kriegel Works Ok, no koha-qa errors Signed-off-by: Katrin Fischer Works ok, all installed languages now show up in the pull downs and display for the selected language in the OPAC. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 3 +- installer/data/mysql/updatedatabase.pl | 8 +++++ .../en/modules/admin/preferences/circulation.pref | 6 ++++ kohaversion.pl | 2 +- t/db_dependent/Members.t | 35 +++++++++++++++++++- tools/koha-news.pl | 13 +++++--- 6 files changed, 59 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 3 17:42:26 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 03 Sep 2014 15:42:26 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-125-g439a4b9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 439a4b9d0a7e5da7b918032d03bef880591a94aa (commit) via ba936a78961ee26c578e873ea0cbf3943f897fe6 (commit) via f023a5e0f38db3c1ef35b452749593aa1e87b7a9 (commit) via 39c43a4789e47db6bd9a94bb9769915c35f03586 (commit) from e91b21f5de0cf979bf83cbfba1ccd3f7fb48704e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 439a4b9d0a7e5da7b918032d03bef880591a94aa Author: Fridolin Somers Date: Wed Sep 3 17:33:45 2014 +0200 Increment version for 3.14.10 release Signed-off-by: Fridolin Somers commit ba936a78961ee26c578e873ea0cbf3943f897fe6 Merge: f023a5e 39c43a4 Author: Fridolin Somers Date: Wed Sep 3 17:29:54 2014 +0200 Merge remote-tracking branch 'translator/3.14.10-translate' into 3.14.x commit f023a5e0f38db3c1ef35b452749593aa1e87b7a9 Author: Fridolin Somers Date: Wed Sep 3 17:24:27 2014 +0200 Update release notes for 3.14.10 release Signed-off-by: Fridolin Somers commit 39c43a4789e47db6bd9a94bb9769915c35f03586 Author: Bernardo Gonzalez Kriegel Date: Mon Sep 1 13:36:20 2014 -0300 Translation updates for 3.14.10 release ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 6 + kohaversion.pl | 2 +- misc/release_notes/release_notes_3_14_10.txt | 438 + .../po/am-Ethi-i-opac-t-prog-v-3006000.po | 372 +- .../po/am-Ethi-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 516 +- misc/translator/po/am-Ethi-pref.po | 8 + .../po/ar-Arab-i-opac-t-prog-v-3006000.po | 423 +- .../po/ar-Arab-i-staff-t-prog-v-3006000.po | 2898 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 544 +- misc/translator/po/ar-Arab-pref.po | 8 + .../translator/po/az-AZ-i-opac-t-prog-v-3006000.po | 369 +- .../po/az-AZ-i-staff-t-prog-v-3006000.po | 2864 +- misc/translator/po/az-AZ-opac-bootstrap.po | 513 +- misc/translator/po/az-AZ-pref.po | 8 + .../translator/po/be-BY-i-opac-t-prog-v-3006000.po | 371 +- .../po/be-BY-i-staff-t-prog-v-3006000.po | 2874 +- misc/translator/po/be-BY-opac-bootstrap.po | 519 +- misc/translator/po/be-BY-pref.po | 8 + misc/translator/po/ben-i-opac-t-prog-v-3006000.po | 379 +- misc/translator/po/ben-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/ben-opac-bootstrap.po | 521 +- misc/translator/po/ben-pref.po | 8 + .../po/bg-Cyrl-i-opac-t-prog-v-3006000.po | 369 +- .../po/bg-Cyrl-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 513 +- misc/translator/po/bg-Cyrl-pref.po | 8 + .../translator/po/ca-ES-i-opac-t-prog-v-3006000.po | 377 +- .../po/ca-ES-i-staff-t-prog-v-3006000.po | 2875 +- misc/translator/po/ca-ES-opac-bootstrap.po | 521 +- misc/translator/po/ca-ES-opac-ccsr.po | 5 +- misc/translator/po/ca-ES-pref.po | 8 + .../translator/po/cs-CZ-i-opac-t-prog-v-3006000.po | 2116 +- .../po/cs-CZ-i-staff-t-prog-v-3006000.po |19702 ++++---------- misc/translator/po/cs-CZ-opac-bootstrap.po | 2438 +- misc/translator/po/cs-CZ-opac-ccsr.po | 52 +- misc/translator/po/cs-CZ-pref.po | 250 +- .../translator/po/da-DK-i-opac-t-prog-v-3006000.po | 371 +- .../po/da-DK-i-staff-t-prog-v-3006000.po | 2887 +- misc/translator/po/da-DK-opac-bootstrap.po | 515 +- misc/translator/po/da-DK-pref.po | 8 + .../translator/po/de-CH-i-opac-t-prog-v-3006000.po | 357 +- .../po/de-CH-i-staff-t-prog-v-3006000.po | 2835 +- misc/translator/po/de-CH-opac-bootstrap.po | 502 +- misc/translator/po/de-CH-pref.po | 8 + .../translator/po/de-DE-i-opac-t-prog-v-3006000.po | 390 +- .../po/de-DE-i-staff-t-prog-v-3006000.po | 2899 +- misc/translator/po/de-DE-opac-bootstrap.po | 536 +- misc/translator/po/de-DE-pref.po | 22 +- .../translator/po/el-GR-i-opac-t-prog-v-3006000.po | 380 +- .../po/el-GR-i-staff-t-prog-v-3006000.po | 2887 +- misc/translator/po/el-GR-opac-bootstrap.po | 523 +- misc/translator/po/el-GR-pref.po | 8 + .../translator/po/en-GB-i-opac-t-prog-v-3006000.po | 369 +- .../po/en-GB-i-staff-t-prog-v-3006000.po | 2872 +- misc/translator/po/en-GB-opac-bootstrap.po | 513 +- misc/translator/po/en-GB-pref.po | 8 + .../translator/po/en-NZ-i-opac-t-prog-v-3006000.po | 465 +- .../po/en-NZ-i-staff-t-prog-v-3006000.po | 2882 +- misc/translator/po/en-NZ-opac-bootstrap.po | 515 +- misc/translator/po/en-NZ-pref.po | 14 +- .../translator/po/es-ES-i-opac-t-prog-v-3006000.po | 2134 +- .../po/es-ES-i-staff-t-prog-v-3006000.po |20734 +++++++++++---- misc/translator/po/es-ES-opac-bootstrap.po | 2374 +- misc/translator/po/es-ES-pref.po | 17 +- misc/translator/po/eu-i-opac-t-prog-v-3006000.po | 378 +- misc/translator/po/eu-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/eu-opac-bootstrap.po | 534 +- misc/translator/po/eu-pref.po | 8 + .../po/fa-Arab-i-opac-t-prog-v-3006000.po | 369 +- .../po/fa-Arab-i-staff-t-prog-v-3006000.po | 2867 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 513 +- misc/translator/po/fa-Arab-pref.po | 8 + .../translator/po/fi-FI-i-opac-t-prog-v-3006000.po | 378 +- .../po/fi-FI-i-staff-t-prog-v-3006000.po | 2869 +- misc/translator/po/fi-FI-opac-bootstrap.po | 519 +- misc/translator/po/fi-FI-pref.po | 8 + .../translator/po/fo-FO-i-opac-t-prog-v-3006000.po | 376 +- .../po/fo-FO-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/fo-FO-opac-bootstrap.po | 513 +- misc/translator/po/fo-FO-pref.po | 8 + .../translator/po/fr-CA-i-opac-t-prog-v-3006000.po | 375 +- .../po/fr-CA-i-staff-t-prog-v-3006000.po | 2892 +- misc/translator/po/fr-CA-opac-bootstrap.po | 519 +- misc/translator/po/fr-CA-pref.po | 8 + .../translator/po/fr-FR-i-opac-t-prog-v-3006000.po | 371 +- .../po/fr-FR-i-staff-t-prog-v-3006000.po | 2895 +- misc/translator/po/fr-FR-opac-bootstrap.po | 521 +- misc/translator/po/fr-FR-pref.po | 8 + misc/translator/po/gl-i-opac-t-prog-v-3006000.po | 373 +- misc/translator/po/gl-i-staff-t-prog-v-3006000.po | 2863 +- misc/translator/po/gl-opac-bootstrap.po | 513 +- misc/translator/po/gl-pref.po | 8 + .../po/he-Hebr-i-opac-t-prog-v-3006000.po | 370 +- .../po/he-Hebr-i-staff-t-prog-v-3006000.po | 2865 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 514 +- misc/translator/po/he-Hebr-pref.po | 8 + misc/translator/po/hi-i-opac-t-prog-v-3006000.po | 374 +- misc/translator/po/hi-i-staff-t-prog-v-3006000.po | 2870 +- misc/translator/po/hi-opac-bootstrap.po | 518 +- misc/translator/po/hi-pref.po | 8 + .../translator/po/hr-HR-i-opac-t-prog-v-3006000.po | 371 +- .../po/hr-HR-i-staff-t-prog-v-3006000.po | 2874 +- misc/translator/po/hr-HR-opac-bootstrap.po | 517 +- misc/translator/po/hr-HR-pref.po | 8 + .../translator/po/hu-HU-i-opac-t-prog-v-3006000.po | 369 +- .../po/hu-HU-i-staff-t-prog-v-3006000.po | 2864 +- misc/translator/po/hu-HU-opac-bootstrap.po | 513 +- misc/translator/po/hu-HU-pref.po | 8 + .../po/hy-Armn-i-opac-t-prog-v-3006000.po | 395 +- .../po/hy-Armn-i-staff-t-prog-v-3006000.po | 2969 ++- misc/translator/po/hy-Armn-opac-bootstrap.po | 547 +- misc/translator/po/hy-Armn-pref.po | 28 +- .../translator/po/id-ID-i-opac-t-prog-v-3006000.po | 371 +- .../po/id-ID-i-staff-t-prog-v-3006000.po | 2860 +- misc/translator/po/id-ID-opac-bootstrap.po | 516 +- misc/translator/po/id-ID-pref.po | 8 + .../translator/po/is-IS-i-opac-t-prog-v-3006000.po | 372 +- .../po/is-IS-i-staff-t-prog-v-3006000.po | 2869 +- misc/translator/po/is-IS-opac-bootstrap.po | 516 +- misc/translator/po/is-IS-pref.po | 8 + .../translator/po/it-IT-i-opac-t-prog-v-3006000.po | 357 +- .../po/it-IT-i-staff-t-prog-v-3006000.po |27932 +++++++++++++------- misc/translator/po/it-IT-opac-bootstrap.po | 502 +- misc/translator/po/it-IT-pref.po | 14 +- .../po/ja-Jpan-JP-i-opac-t-prog-v-3006000.po | 369 +- .../po/ja-Jpan-JP-i-staff-t-prog-v-3006000.po | 3036 ++- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 513 +- misc/translator/po/ja-Jpan-JP-pref.po | 8 + .../po/kn-Knda-i-opac-t-prog-v-3006000.po | 369 +- .../po/kn-Knda-i-staff-t-prog-v-3006000.po | 2861 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 513 +- misc/translator/po/kn-Knda-pref.po | 8 + .../po/ko-Kore-KP-i-opac-t-prog-v-3006000.po | 369 +- .../po/ko-Kore-KP-i-staff-t-prog-v-3006000.po | 2865 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 513 +- misc/translator/po/ko-Kore-KP-pref.po | 8 + misc/translator/po/ku-i-opac-t-prog-v-3006000.po | 372 +- misc/translator/po/ku-i-staff-t-prog-v-3006000.po | 2878 +- misc/translator/po/ku-opac-bootstrap.po | 516 +- misc/translator/po/ku-pref.po | 17 +- .../po/lo-Laoo-i-opac-t-prog-v-3006000.po | 370 +- .../po/lo-Laoo-i-staff-t-prog-v-3006000.po | 2861 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 514 +- misc/translator/po/lo-Laoo-pref.po | 8 + .../translator/po/mi-NZ-i-opac-t-prog-v-3006000.po | 375 +- .../po/mi-NZ-i-staff-t-prog-v-3006000.po | 2873 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 518 +- misc/translator/po/mi-NZ-pref.po | 8 + misc/translator/po/mon-i-opac-t-prog-v-3006000.po | 369 +- misc/translator/po/mon-i-staff-t-prog-v-3006000.po | 2865 +- misc/translator/po/mon-opac-bootstrap.po | 513 +- misc/translator/po/mon-pref.po | 8 + misc/translator/po/mr-i-opac-t-prog-v-3006000.po | 375 +- misc/translator/po/mr-i-staff-t-prog-v-3006000.po | 2860 +- misc/translator/po/mr-opac-bootstrap.po | 519 +- misc/translator/po/mr-pref.po | 8 + .../translator/po/ms-MY-i-opac-t-prog-v-3006000.po | 375 +- .../po/ms-MY-i-staff-t-prog-v-3006000.po | 2900 +- misc/translator/po/ms-MY-opac-bootstrap.po | 519 +- misc/translator/po/ms-MY-pref.po | 8 + .../translator/po/nb-NO-i-opac-t-prog-v-3006000.po | 371 +- .../po/nb-NO-i-staff-t-prog-v-3006000.po | 2881 +- misc/translator/po/nb-NO-opac-bootstrap.po | 517 +- misc/translator/po/nb-NO-pref.po | 8 + .../translator/po/ne-NE-i-opac-t-prog-v-3006000.po | 369 +- .../po/ne-NE-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/ne-NE-opac-bootstrap.po | 513 +- misc/translator/po/ne-NE-pref.po | 8 + .../translator/po/nl-BE-i-opac-t-prog-v-3006000.po | 371 +- .../po/nl-BE-i-staff-t-prog-v-3006000.po | 2870 +- misc/translator/po/nl-BE-opac-bootstrap.po | 521 +- misc/translator/po/nl-BE-pref.po | 8 + .../translator/po/nl-NL-i-opac-t-prog-v-3006000.po | 372 +- .../po/nl-NL-i-staff-t-prog-v-3006000.po | 2862 +- misc/translator/po/nl-NL-opac-bootstrap.po | 521 +- misc/translator/po/nl-NL-pref.po | 8 + .../translator/po/nn-NO-i-opac-t-prog-v-3006000.po | 369 +- .../po/nn-NO-i-staff-t-prog-v-3006000.po | 2865 +- misc/translator/po/nn-NO-opac-bootstrap.po | 513 +- misc/translator/po/nn-NO-pref.po | 8 + misc/translator/po/pbr-i-opac-t-prog-v-3006000.po | 369 +- misc/translator/po/pbr-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/pbr-opac-bootstrap.po | 513 +- misc/translator/po/pbr-pref.po | 8 + .../translator/po/pl-PL-i-opac-t-prog-v-3006000.po | 371 +- .../po/pl-PL-i-staff-t-prog-v-3006000.po | 2879 +- misc/translator/po/pl-PL-opac-bootstrap.po | 529 +- misc/translator/po/pl-PL-pref.po | 8 + misc/translator/po/prs-i-opac-t-prog-v-3006000.po | 372 +- misc/translator/po/prs-i-staff-t-prog-v-3006000.po | 2857 +- misc/translator/po/prs-opac-bootstrap.po | 516 +- misc/translator/po/prs-pref.po | 8 + .../translator/po/pt-BR-i-opac-t-prog-v-3006000.po | 371 +- .../po/pt-BR-i-staff-t-prog-v-3006000.po | 2884 +- misc/translator/po/pt-BR-opac-bootstrap.po | 525 +- misc/translator/po/pt-BR-pref.po | 8 + .../translator/po/pt-PT-i-opac-t-prog-v-3006000.po | 370 +- .../po/pt-PT-i-staff-t-prog-v-3006000.po | 2856 +- misc/translator/po/pt-PT-opac-bootstrap.po | 516 +- misc/translator/po/pt-PT-pref.po | 8 + .../translator/po/ro-RO-i-opac-t-prog-v-3006000.po | 373 +- .../po/ro-RO-i-staff-t-prog-v-3006000.po | 2864 +- misc/translator/po/ro-RO-opac-bootstrap.po | 517 +- misc/translator/po/ro-RO-pref.po | 8 + .../translator/po/ru-RU-i-opac-t-prog-v-3006000.po | 371 +- .../po/ru-RU-i-staff-t-prog-v-3006000.po | 2874 +- misc/translator/po/ru-RU-opac-bootstrap.po | 519 +- misc/translator/po/ru-RU-pref.po | 8 + .../translator/po/rw-RW-i-opac-t-prog-v-3006000.po | 369 +- .../po/rw-RW-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/rw-RW-opac-bootstrap.po | 513 +- misc/translator/po/rw-RW-pref.po | 8 + .../translator/po/sd-PK-i-opac-t-prog-v-3006000.po | 371 +- .../po/sd-PK-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/sd-PK-opac-bootstrap.po | 515 +- misc/translator/po/sd-PK-pref.po | 8 + .../translator/po/sk-SK-i-opac-t-prog-v-3006000.po | 357 +- .../po/sk-SK-i-staff-t-prog-v-3006000.po | 2853 +- misc/translator/po/sk-SK-opac-bootstrap.po | 502 +- misc/translator/po/sk-SK-pref.po | 8 + .../translator/po/sl-SI-i-opac-t-prog-v-3006000.po | 369 +- .../po/sl-SI-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/sl-SI-opac-bootstrap.po | 513 +- misc/translator/po/sl-SI-pref.po | 8 + .../translator/po/sq-AL-i-opac-t-prog-v-3006000.po | 386 +- .../po/sq-AL-i-staff-t-prog-v-3006000.po | 2857 +- misc/translator/po/sq-AL-opac-bootstrap.po | 513 +- misc/translator/po/sq-AL-pref.po | 8 + .../po/sr-Cyrl-i-opac-t-prog-v-3006000.po | 369 +- .../po/sr-Cyrl-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 513 +- misc/translator/po/sr-Cyrl-pref.po | 8 + .../translator/po/sv-SE-i-opac-t-prog-v-3006000.po | 372 +- .../po/sv-SE-i-staff-t-prog-v-3006000.po | 2883 +- misc/translator/po/sv-SE-opac-bootstrap.po | 520 +- misc/translator/po/sv-SE-pref.po | 8 + .../translator/po/sw-KE-i-opac-t-prog-v-3006000.po | 370 +- .../po/sw-KE-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/sw-KE-opac-bootstrap.po | 513 +- misc/translator/po/sw-KE-pref.po | 8 + .../translator/po/ta-LK-i-opac-t-prog-v-3006000.po | 369 +- .../po/ta-LK-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/ta-LK-opac-bootstrap.po | 513 +- misc/translator/po/ta-LK-pref.po | 8 + misc/translator/po/ta-i-opac-t-prog-v-3006000.po | 369 +- misc/translator/po/ta-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/ta-opac-bootstrap.po | 513 +- misc/translator/po/ta-pref.po | 8 + misc/translator/po/tet-i-opac-t-prog-v-3006000.po | 373 +- misc/translator/po/tet-i-staff-t-prog-v-3006000.po | 2870 +- misc/translator/po/tet-opac-bootstrap.po | 523 +- misc/translator/po/tet-pref.po | 8 + .../translator/po/th-TH-i-opac-t-prog-v-3006000.po | 369 +- .../po/th-TH-i-staff-t-prog-v-3006000.po | 2855 +- misc/translator/po/th-TH-opac-bootstrap.po | 513 +- misc/translator/po/th-TH-pref.po | 8 + .../translator/po/tl-PH-i-opac-t-prog-v-3006000.po | 370 +- .../po/tl-PH-i-staff-t-prog-v-3006000.po | 2859 +- misc/translator/po/tl-PH-opac-bootstrap.po | 514 +- misc/translator/po/tl-PH-pref.po | 8 + .../translator/po/tr-TR-i-opac-t-prog-v-3006000.po | 2145 +- .../po/tr-TR-i-staff-t-prog-v-3006000.po |20006 ++++++++++---- misc/translator/po/tr-TR-opac-bootstrap.po | 2339 +- misc/translator/po/tr-TR-pref.po | 19 +- .../translator/po/uk-UA-i-opac-t-prog-v-3006000.po | 371 +- .../po/uk-UA-i-staff-t-prog-v-3006000.po | 2877 +- misc/translator/po/uk-UA-opac-bootstrap.po | 521 +- misc/translator/po/uk-UA-pref.po | 8 + .../po/ur-Arab-i-opac-t-prog-v-3006000.po | 369 +- .../po/ur-Arab-i-staff-t-prog-v-3006000.po | 2854 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 513 +- misc/translator/po/ur-Arab-pref.po | 8 + .../translator/po/vi-VN-i-opac-t-prog-v-3006000.po | 371 +- .../po/vi-VN-i-staff-t-prog-v-3006000.po | 2883 +- misc/translator/po/vi-VN-opac-bootstrap.po | 515 +- misc/translator/po/vi-VN-pref.po | 8 + .../po/zh-Hans-CN-i-opac-t-prog-v-3006000.po | 371 +- .../po/zh-Hans-CN-i-staff-t-prog-v-3006000.po | 2881 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 522 +- misc/translator/po/zh-Hans-CN-opac-ccsr.po | 1 + misc/translator/po/zh-Hans-CN-pref.po | 8 + .../po/zh-Hans-TW-i-opac-t-prog-v-3006000.po | 357 +- .../po/zh-Hans-TW-i-staff-t-prog-v-3006000.po | 2853 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 502 +- misc/translator/po/zh-Hans-TW-pref.po | 8 + 286 files changed, 206341 insertions(+), 146132 deletions(-) create mode 100644 misc/release_notes/release_notes_3_14_10.txt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 3 17:43:50 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 03 Sep 2014 15:43:50 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.14.10 created. v3.14.10 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.14.10 has been created at 65bcdf83925934c84a6ee4c58c57d33b32ea4cbb (tag) tagging 439a4b9d0a7e5da7b918032d03bef880591a94aa (commit) replaces v3.14.09 tagged by Fridolin Somers on Wed Sep 3 17:39:17 2014 +0200 - Log ----------------------------------------------------------------- Koha release 3.14.10 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAABAgAGBQJUBzYlAAoJECvJNkKAZAZuLekH+wdrZqE8vwAoqiaTcKVkM271 m1jd1B+YRSj9InPvFKpAF2hPYTFSEcQfmf3CYnznT6bVap2Fv+yxCup4YwomKmq0 6lhs1wUZMBGFv5fXyko6nGYhaLQp9pt26IVNMcCDuSKmwkVFJOKWf7sQFidBNL0E C8zu2GISzJo1wevp+lTZhJd2Czaa38NdzLnyGjeMt7srF+VCSZt3m3ZICEgFYM1P L7Uuci959f7yXYc+zpJ/u2+HbFUWVwM8l9EekudTv676f++fTWnB79aYngAORlnl MUUIU8MK52PpA5T0cpvRbQagKAeo9BS/fL4M3yfhAuzcPDl5aDTMvfBBY/WIO5I= =/+N1 -----END PGP SIGNATURE----- Adrien Saurat (1): Bug 9865: make SIP msg encoding configurable via SIPconfig.xml Bernardo Gonzalez Kriegel (5): Bug 11885: (follow-up) remove tabs Bug 5052: make it possible to pick a language if all choices are sublanguage Bug 12081: make tmpl_process3.pl delete ts temp files Bug 11508: fix untranslatable pull-down in auth_subfields_structure.pl Translation updates for 3.14.10 release Blou (1): Bug 11752: display the correct frequency for serial subscriptions in OPAC details Chris Cormack (1): Bug 7143: Updating history with new developers Colin Campbell (1): Bug 11468: Remove given/when from Koha::Dateutils Francesca Moore (1): Bug 11231: remove reference to ambiguous notes column from two hold request reports Fridolin Somers (6): Bug 12071: improve generation of Z39.50 search links Bug 11219: (follow-up) fetch only URL parameters Bug 12052: DBrev 3.14.09.001 Update release notes for 3.14.10 release Merge remote-tracking branch 'translator/3.14.10-translate' into 3.14.x Increment version for 3.14.10 release Fridolyn SOMERS (4): Bug 11219: make CAS authentication work with URL parameters Bug 9578: avoid a search crash when attempting to sort results of invalid query Bug 11069: increase title ranking in relevance when using QueryWeightFields Bug 11254: make reservoir search normalize ISBNs Fr?d?ric Demians (3): Bug 12073: don't show link URLs when printing Bootstrap OPAC detail page Bug 12048: restore ability of superlibrarian to see other libraries' subscriptions Bug 12080: restore effect of superserials permission Fr?d?rick (1): Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record. Galen Charlton (21): Bug 12079: ensure that CheckReserves() includes reserve_id in its response bug 10865: (follow-up) allow patrons to make their public lists private when OpacAllowPublicListCreation is off Bug 11441: (follow-up) improve utility help text Bug 12076: better detect an untranslatable template construct Bug 11797: add regression test Bug 11797: (follow-up) fix MARC21 branch of bug more idiomatically Bug 11484: (follow-up) standardize capitalization of "Z39.50" Bug 11148: (follow-up) add more test cases Bug 9578: add regression test Bug 11699: (follow-up) fix errors in the POD for ModReceiveOrder Bug 11699: (follow-up) update one more test that uses ModReceiveOrder Bug 10277: (follow-up) if no userenv is set, act like a superlibrarian Bug 7002: fix some invalid superlibrarian permission checks Bug 12048: add regression test Bug 12098: (follow-up) deal with FIXMEs in t/db_dependent/Serials_2.t Bug 12098: (follow-up) put can_show_subscription() into use Bug 11489: (follow-up) fix tab Bug 9972: (follow-up) add new indexes to the QueryParser config Bug 9972: (follow-up) enable Lexile searches to work using QueryParser Bug 9288: (follow-up) more tweaks Bug 11552: (follow-up) fix a typo in a comment Jacek Ablewicz (3): Bug 11914: fix two issues when creating an order from a suggestion Bug 11680: fix case where tax rate changes unexpectedly on editing an order Bug 11680: (follow-up) fix unexpected tax rate changes on edit Jonathan Druart (28): Bug 10865: (follow-up) Move a li tag to avoid overlapping tags Bug 11885: (follow-up) add a CSS class to set subfield code bold Bug 11995: restore ability of serialsUpdate.pl to calculate next serial issue dates Bug 11960: replace unnecessary call of GetMemberDetails by CanBookBeRenewed Bug 11797: fix odd number of elements in hash (UNIMARC) Bug 12052: New syspref to display message on the OPAC patron summary page Bug 10533: move JavaScript functions for basket groups to a separate file Bug 11148: remove two superflous routines from Koha::DateUtils Bug 11148: Add a as_due_date parameter to the output_pref routine Bug 11148: (follow-up) restore useful test removed by previous patch Bug 10090: display item type description instead of code on acq ordered and spent pages Bug 9216: make columns.def file translatable Bug 11699: fixed saving notes entered when receiving orders Bug 11699: change ModReceiveOrder to used named parameters Bug 10277: Add UT for C4::Context::IsSuperLibrarian Bug 11587 - Add UT for IsSuperLibrarian if flags == 0 Bug 12098: Fix C4::Serials::can_edit_subscription Bug 12098: Refactor can_*_subscription in C4::Serials Bug 10138: (follow-up) FIX sql errors Bug 11489: (OPAC prog theme) show facets only if there is a result to display Bug 11912: (follow-up) Use the common way to mock syspref Bug 11243: make vendor list distinguish between active and canceled items Bug 11243: update vendor list to also display canceled bib counts Bug 11243: UT: unit tests for GetBasketsInfosByBookseller Bug 8258: Use patron's library's notice for DUEDGST and PREDUEDGST Bug 11248: fix encoding issue on emailing a list (INTRANET) Bug 11248: fix encoding issue on emailing a list (OPAC) Bug 11552: allow searching on original order number after a transfer Juan Romay Sieira (1): Bug 11441: enhance remove_unused_authorities.pl ability to select records Julian Maurice (4): Bug 8044: new module for translating strings in Perl source files Bug 8044: (follow-up) fix warning and error messages in translate.pl Bug 8044: (follow-up) add copyright block and use Modern::Perl Bug 12003: Do not calculate next pubdate for irregular subscriptions Katrin Fischer (7): Bug 11828: Add German translation of layout2pages PDF template Bug 11828: (follow-up) add new option to OrderPdfFormat Bug 7267: Add account number to French PDF template Bug 7267: Add account number to English PDF templates Bug 7267: Add account number to German PDF template Bug 9216: (follow-up) Make description in columns.def more specific Bug 11248: (follow-up) fix template for translated list emails in staff Kyle M Hall (12): Bug 9865 (follow-up) give better usage examples in example SIPconfig.xml Bug 11484: Add option to cleanup_database.pl to purge Z39.50 search records from reservoir Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy Bug 11416: fix case where serials item editor was incorrectly hiding fields Bug 10277 - Add C4::Context->IsSuperLibrarian() Bug 12080: (follow-up) fix test failure and warnings in Bookseller.t Bug 11489: in OPAC search, display "no results" when the only search result is suppressed Bug 9288 - Add a script to test SIP from the command line Bug 9288: (follow-up) add --terminator option; use Modern::Perl Bug 9288: (follow-up) use specified terminator for both input and output Bug 9288: (follow-up) minor code tweaks Bug 9288: (follow-up) remove function prototype Marcel de Rooy (3): Bug 9075: Rename "type" to "material type" on staff XSLT detail and results Bug 9075: Rename "type" to "material type" on OPAC XSLT detail and results Bug 8044: (follow-up) ensure Modern::Perl is imported first Mark Tompsett (4): Bug 11885: (follow-up) make default styling consistent with previous look Bug 11797: fix odd number of elements in hash warning (MARC21) Bug 11587 - IsSuperLibrarian generates warnings (UT) Bug 11587: get rid of warnings generated by IsSuperLibrarian with anonymous sessions Mason James (1): Bug 10825: don't display enum/chron twice for items received via the serials module Mathieu Saby (1): Bug 10138: Add some authorized values in French installer; small fixes in frameworks Mirko Tietgen (1): Bug 9972: Add/change some zebra indexes (MARC21) Owen Leonard (9): Bug 11711 - Use new DataTables include in circ templates Bug 11734 - Use new DataTables include in batch modification templates Bug 12056: fix untranslatable strings in calendar Bug 10865: Don't show list permissions when adding public lists/sharing lists is not allowed Bug 10865: (Follow-up) Add CSS style for form hints Bug 11951: fix OPAC search suggestions template error Bug 12069: redirect to staff login if you access members/mod_debarment.pl when logged out Bug 12075: fix keyboard shortcuts broken by jQueryUI upgrade Bug 12058: make OverDrive search results page show cart, lists, and login links Pasi Kallinen (1): Bug 11885: fix inconsistent HTML in MARC Details Robin Sheat (1): Bug 11947 - renumber reserves when hold is confirmed Srdjan (1): Bug 11184: correct attribute cloning for the patron editor Tomas Cohen Arazi (3): Bug 11912: (regression tests) GetMarcISBN wrongly prepends a space to ISBNs Bug 11912: fix problem where GetMarcISBN wrongly prepends a space to ISBNs Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 3 19:15:59 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 03 Sep 2014 17:15:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-526-g56b4be2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 56b4be28258f183eceb4664ad75550b849c809c5 (commit) from 5faef12f68671a0e6460e219c98c86ff86e478be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 56b4be28258f183eceb4664ad75550b849c809c5 Author: Janet McGowan Date: Wed Sep 3 16:05:58 2014 +0000 Bug 12866: Fixes Display of Email in Alternate Address Incorrect display of Email Address in Alternate Address Patron Details Without patch, mail from primary address is displayed in Alternate address With patch, correct mail address is displayed Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, no problems found. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 5 16:00:48 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 05 Sep 2014 14:00:48 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-2-gc96d5f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via c96d5f6937ffc4e904e56103fb7acd83b46e57eb (commit) via dd1668325de59382b453f1a446634fcf2f6adc03 (commit) from 439a4b9d0a7e5da7b918032d03bef880591a94aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c96d5f6937ffc4e904e56103fb7acd83b46e57eb Author: Kyle M Hall Date: Mon Jun 16 07:30:03 2014 -0400 Bug 11292 [QA Followup] - Use noEnterSubmit instead of new keypress handler Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6f4baf2c59ff00b64a0beb891605c2dd4a7452a6) Signed-off-by: Fridolin Somers commit dd1668325de59382b453f1a446634fcf2f6adc03 Author: Kyle M Hall Date: Thu May 22 08:35:16 2014 -0400 Bug 11292 - barcode scanner clicking 'save' When cataloging a bib record if you scan an ISBN barcode in the barcode scanner clicks the 'save' button before the cataloging is done. This did not happen in 3.10, but is happening again in 3.12. Test Plan: 1) Open the marc editor 2) Focus on a field, hit the enter key 3) Note the record tries to save 4) Focus on an indicator, hit the enter key 5) Note the record tries to save 6) Apply this patch 7) Repeat steps 2 and 4, note the record no longer tries to save upon carriage return Signed-off-by: Christopher Brannon Patch tested with a sandbox. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a52a0a8811f6ad03c422c62280bc184a9e16996d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 5 16:03:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 05 Sep 2014 14:03:18 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-3-gb61580d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via b61580d52c66fb2c696080074e648a347376fe3d (commit) from c96d5f6937ffc4e904e56103fb7acd83b46e57eb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b61580d52c66fb2c696080074e648a347376fe3d Author: Fridolin Somers Date: Tue Apr 8 16:48:31 2014 +0200 Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like: https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for login and password Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Normal login still works with/without CAS. Passes all tests and QA script. Signed-off-by: Galen Charlton (cherry picked from commit 4bc46dbbcb93ca43b2fd138cf65f51893978b3ad) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 5 16:35:35 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 05 Sep 2014 14:35:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-537-ge69d6da Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e69d6dabc475dfa747d15576f6396e77a7d71c42 (commit) via 9a36f70e35afc3dcdba34678c3b18d960606aa16 (commit) via 51aba41fc30f255948574e9e38d4675558258e03 (commit) via dce2a6362ce5402f7e420f632b0e6f7b60cd5cec (commit) via 500369d807203c9e56cec6489672a38e8ac7b1b2 (commit) via 9e686e023f957e29ba32f84d667014a69f196706 (commit) via db739ee578b8d8134954912e534a9686590f652e (commit) via c6716d3e22244df153f294b351f67da9312c5053 (commit) via c14d91fcd01e2fd240334bdf18444ffa6db6b4a9 (commit) via 27d340959835107941e683a5d6aec64ebca782f2 (commit) via 80086f3ffb08efd333194c83e542ea55b66a87c9 (commit) from 56b4be28258f183eceb4664ad75550b849c809c5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e69d6dabc475dfa747d15576f6396e77a7d71c42 Author: Tomas Cohen Arazi Date: Fri Sep 5 11:33:27 2014 -0300 Bug 6149: (qa followup) sysprefs should be alphabetically sorted Signed-off-by: Tomas Cohen Arazi commit 9a36f70e35afc3dcdba34678c3b18d960606aa16 Author: Tomas Cohen Arazi Date: Fri Sep 5 10:57:52 2014 -0300 Bug 6149: DBRev 3.17.00.019 Signed-off-by: Tomas Cohen Arazi commit 51aba41fc30f255948574e9e38d4675558258e03 Author: Martin Renvoize Date: Tue Mar 11 09:05:51 2014 +0000 Bug 6149 - Follow-up [syspref] - Stopwords for Result Highlighting - global replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. Signed-off-by: Katrin Fischer Works as described, fixed some tabs and a typo. commit dce2a6362ce5402f7e420f632b0e6f7b60cd5cec Author: Martin Renvoize Date: Tue Nov 19 12:07:59 2013 +0000 Bug 6149: Follow-up [grouped] - Stopwords for Result Highlighting - Added functionaility to opac-results-grouped page Signed-off-by: Katrin Fischer commit 500369d807203c9e56cec6489672a38e8ac7b1b2 Author: Martin Renvoize Date: Mon Oct 28 12:12:30 2013 +0000 Bug 6149: Follow-up [bootstrap] - Stopwords for Result Highlighting - Added functionality to new bootstrap theme Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 9e686e023f957e29ba32f84d667014a69f196706 Author: Katrin Fischer Date: Sun Oct 27 15:34:49 2013 +0100 Bug 6149: Follow-up [defaults] - Stopwords for Result Highlighting - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit db739ee578b8d8134954912e534a9686590f652e Author: Martin Renvoize Date: Fri Aug 9 14:42:00 2013 +0100 Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Passes all tests and QA script, works as expected. commit c6716d3e22244df153f294b351f67da9312c5053 Author: charles Date: Wed Aug 6 16:44:19 2014 -0400 Bug 7498 - Cloning a budget, enable change of description Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) This new patch builds on the work of Bug 12164 by allowing the user to enter a new name (budget_period_description) for the cloned budget. A test was added to t/db_dependent/Budgets.t. Sponsored-by: CCSR Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi Edit: added the sponsored-by line. commit c14d91fcd01e2fd240334bdf18444ffa6db6b4a9 Author: Marcel de Rooy Date: Thu Sep 4 08:40:05 2014 +0200 Bug 12790: QA-follow-up: Mention required version in online Help For those who would not understand the two version numbers and come up with the idea to check the Help page, some text is added. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 27d340959835107941e683a5d6aec64ebca782f2 Author: Marc V?ron Date: Thu Aug 7 07:45:34 2014 +0200 Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch. In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print next to or underneath the module names. Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 80086f3ffb08efd333194c83e542ea55b66a87c9 Author: Robin Sheat Date: Thu Sep 4 16:30:34 2014 +1200 Bug 12869 - update the version in build-git-snapshot Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 14 ++++++++------ about.pl | 1 + admin/aqbudgetperiods.pl | 4 ++++ debian/build-git-snapshot | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 9 ++++++++- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 4 +++- .../prog/en/modules/admin/aqbudgetperiods.tt | 8 ++++++++ .../prog/en/modules/admin/preferences/opac.pref | 5 ++++- .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 5 ++++- koha-tmpl/intranet-tmpl/prog/en/modules/help/about.tt | 1 + koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 10 +++++++--- .../bootstrap/en/modules/opac-results-grouped.tt | 6 +++++- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 +++- koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 12 ++++++++---- .../opac-tmpl/prog/en/modules/opac-results-grouped.tt | 6 +++++- koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt | 4 +++- kohaversion.pl | 2 +- t/db_dependent/Budgets.t | 6 +++++- 19 files changed, 80 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 5 17:28:38 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 05 Sep 2014 15:28:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-547-gabdf719 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via abdf7194e2a9bc5e2c497e3d4d241c2e8de40ffc (commit) via a8458630a7aa5209701f224f0d159b604af350f7 (commit) via 36d1b3e29d89c2af04c50d4f9ae91cb18c391f97 (commit) via f5320c4bf873c8fe328d0fdc819fa11f05f346ef (commit) via 33db04fab8ca46168f541bc0d80eb6beced5ef82 (commit) via 77b0dd40988ca2f19ec73eaf821472fe9adf8268 (commit) via 38316529df82ae38dbc59344abb67f817986312c (commit) via e0e66612cc5555ce73d71f486e3f40e0e3414d29 (commit) via 3c1f7dae0aaefdb0041a1b3e030cbb47132f6672 (commit) via 3b092a899fda345c95f875012ba7338f2efc6398 (commit) from e69d6dabc475dfa747d15576f6396e77a7d71c42 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit abdf7194e2a9bc5e2c497e3d4d241c2e8de40ffc Author: Tomas Cohen Arazi Date: Fri Sep 5 12:18:34 2014 -0300 Bug 12582: DBRev 3.17.00.021 Signed-off-by: Tomas Cohen Arazi commit a8458630a7aa5209701f224f0d159b604af350f7 Author: Kyle M Hall Date: Wed Jul 16 07:44:12 2014 -0400 Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the value of the new system preference StaffSearchResultsDisplayBranch matches the current value of HomeOrHoldingBranch 4) Set the preference to home branch 5) Perform a staff catalog search with results having items with differing home and holding branches. 6) Note the home branch displays 7) Set the preference to holding branch 8) Repeat step 5 9) Note the holding branch displays Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer Works as described, logic is now tied to a new system preference. Passes tests and QA script. commit 36d1b3e29d89c2af04c50d4f9ae91cb18c391f97 Author: Marcel de Rooy Date: Wed Jul 9 15:56:54 2014 +0200 Bug 12330: [QA Follow-up] Consistency between opac-search and staff client In opac-search two regexes are added for the results of splitting the pref AdvancedSearchTypes, allowing spaces before and after the names. The same regexes should be added to catalogue/search.pl to have the same behavior there. Test plan: Set AdvancedSearchTypes to "itemtypes | ccode | loc " (no quotes). Check OPAC and staff with and without this patch. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit f5320c4bf873c8fe328d0fdc819fa11f05f346ef Author: Mark Tompsett Date: Thu May 29 18:31:03 2014 -0400 Bug 12330: OpacHiddenItems not affecting Advanced Search This patch affects only the area displayed on Advanced Search by setting the AdvancedSearchTypes OPAC system preference accordingly. Prior to this patch, no filtering based on OpacHiddenItems was done. This patch determines if itemtypes, collections, or shelving locations are hidden and prevents them from being shown. TEST PLAN --------- 1) Back up your DB (always handy) 2) Set the Searching system preference AdvancedSearchTypes to: 'itemtypes|ccode|loc' (without the single quotes). 3) Set the OPAC system preference OpacHiddenItems to include the lines: itype: [{list of itemtype codes separated by commas}] location: [{list of comma delimited shelving location codes}] ccode: [{list of comma delimited collection codes}] Make sure to exclude one value for each, so there will be at least one known thing on each tab. 4) Open the OPAC. 5) Click on 'Advanced Search' -- three tabs appear: Itemtypes, Collection, Shelving location -- Everything is visible 6) Set the Searching system preference AdvancedSearchTypes to: 'itemtypes | ccode | loc' (without the single quotes). 7) Refresh the OPAC. -- There will be three tabs, but ugliness ensues. 8) Apply the patch 9) Refresh the OPAC. -- You will see: Itemtypes, Collection, Shelving location -- Only excluded values from OpacHiddenItems will be seen. 10) Run koha qa test tools Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Marcel de Rooy Small rewording in comment only. Signed-off-by: Tomas Cohen Arazi commit 33db04fab8ca46168f541bc0d80eb6beced5ef82 Author: Marcel de Rooy Date: Wed Sep 3 13:43:50 2014 +0200 Bug 12864: Add LOC SRU server to sample z3950servers.sql Add LOC SRU server to sample servers installed. This patch modifies four language files: de, en, es and nb. For the other languages this may not be useful. Test plan: You could test this by using the webinstaller. But you could also (backup) and delete your records in z3950servers, and run the sample_z3950_servers.sql file from the command line. Check if you see the new SRU server. Tested using mysql. I truncated the table (to reset the IDs as well) and then ran the file. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 77b0dd40988ca2f19ec73eaf821472fe9adf8268 Author: Tomas Cohen Arazi Date: Fri Sep 5 11:51:53 2014 -0300 Bug 8735: DBRev 3.17.00.020 Signed-off-by: Tomas Cohen Arazi commit 38316529df82ae38dbc59344abb67f817986312c Author: Kyle M Hall Date: Wed Jun 4 14:22:23 2014 -0400 Bug 8735 [QA Followup 2] - Remove extra period, add bug number to db update Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit e0e66612cc5555ce73d71f486e3f40e0e3414d29 Author: Kyle M Hall Date: Thu Apr 17 14:33:16 2014 -0400 Bug 8735 [QA Followup] - Add Unit Tests Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 3c1f7dae0aaefdb0041a1b3e030cbb47132f6672 Author: Kyle M Hall Date: Tue Apr 23 12:32:03 2013 -0400 Bug 8735 - Expire holds waiting only on days the library is open - Followup - Switch from C4::Calendar to Koha::Calendar Test Plan: 1) Set ExpireReservesMaxPickUpDelay 2) Set ReservesMaxPickUpDelay to 1 3) Place a hold, set it to waiting 4) Using the MySQL console, modify the waiting date and set it to the day before yesterday. 5) Set today as a holiday for the pickup branch in question. 6) Run misc/cronjobs/holds/cancel_expired_holds.pl 7) The hold should remain unchanged 8) Remove today as a holiday 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again 10) The hold should now be canceled Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 3b092a899fda345c95f875012ba7338f2efc6398 Author: Kyle M Hall Date: Thu Sep 6 11:15:21 2012 -0400 Bug 8735 - Expire holds waiting only on days the library is open Signed-off-by: Leila Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 24 ++++++++++-- C4/Search.pm | 4 +- catalogue/search.pl | 2 + .../mysql/de-DE/optional/sample_z3950_servers.sql | 6 +++ .../mysql/en/optional/sample_z3950_servers.sql | 6 +++ .../mysql/es-ES/optional/sample_z3950_servers.sql | 6 +++ .../data/mysql/nb-NO/2-Valgfritt/z3950servers.sql | 6 +++ installer/data/mysql/sysprefs.sql | 2 + installer/data/mysql/updatedatabase.pl | 16 ++++++++ .../en/modules/admin/preferences/circulation.pref | 13 +++++++ kohaversion.pl | 2 +- opac/opac-search.pl | 20 ++++++++++ t/db_dependent/Holds.t | 39 +++++++++++++++++++- 13 files changed, 138 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 5 21:38:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 05 Sep 2014 19:38:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-550-gead0d88 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ead0d88c74bd0efba2d2ca0123c51ff2b6cf25fc (commit) via eefef42abda81e84e42d4a3951684092045886fa (commit) via 62d3a286c16b97c288af54bfd4b64bffbb5f6090 (commit) from abdf7194e2a9bc5e2c497e3d4d241c2e8de40ffc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ead0d88c74bd0efba2d2ca0123c51ff2b6cf25fc Author: Tomas Cohen Arazi Date: Wed Aug 20 11:39:27 2014 -0300 Bug 12788: (followup) minor optimization with proper tests This patch removes the $facets_info calculation from the _get_facets_data_from_record sub so it is not done for each record. It introduces a new sub, _get_facets_info that is called from the getRecords loop, that does the job only once. To test: - Apply on top of the previous patches - Run $ prove -v t/db_dependent/Search.t => SUCCESS: _get_facets_info gets tested and it passes for both MARC21 and UNIMARC. Facets rendering should remain unchaged on the UI. - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Nick Clemens Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit eefef42abda81e84e42d4a3951684092045886fa Author: Tomas Cohen Arazi Date: Wed Aug 20 00:48:07 2014 -0300 Bug 12788: facets calculation should skip 100 if ind1=z This patch adds a test for field 100, to skip it on facet calculation if ind1=z. To test: - Have IncludeSeeFromInSearches set. - Create a biblio record, when adding an author, create a new authority record that contains a 400$a field (see from). - Rebuild zebra db. - Search for the record making sure the search returns more than one record. => FAIL: the facets contain the 'see from' field. - Run $ prove -v t/db_dependent/Search.t => FAIL: it fails - Apply the patch - Run $ prove -v t/db_dependent/Search.t => SUCCESS: it passes - Re-run the search, notice the 'see from' doesn't show anymore on the facets. - Sign off :-D Edit: minor stylistic change Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Nick Clemens Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 62d3a286c16b97c288af54bfd4b64bffbb5f6090 Author: Tomas Cohen Arazi Date: Wed Aug 20 00:33:40 2014 -0300 Bub 12788: (regression test) refactor facet extraction code to allow testing This patch refactors the facet extraction loop into a proper function. The loop is changed so the MARC::Record objects are created only once instead of the old/current behaviour: once for each defined facet (in C4::Koha::getFacets). To test: - Apply the patch => SUCCESS: verify facets functionality remains unchanged. - Run: $ prove -v t/db_dependent/Search.t => SUCCESS: tests for _get_facets_data_from_record fail, because 100$a is considered for fields with indicator 1=z (field added by IncludeSeeFromInSearches syspref). - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Nick Clemens Signed-off-by: David Cook Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 128 ++++++++++++++++++++++++++++++++--------------- t/db_dependent/Search.t | 80 +++++++++++++++++++++++++++-- 2 files changed, 163 insertions(+), 45 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 8 15:55:05 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 08 Sep 2014 13:55:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-556-ge86371a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e86371a0aa3c024d3a60af71ab055c9415efb844 (commit) via 25df10e4d84aee069c795f4d02a73a9fee2da7c8 (commit) via 6f64bb2bd5aef173874b375676ce4858e9c933c5 (commit) via 0950e44fafcd74c868ff2d8f105f500bceac5881 (commit) via efba7b02dda5cd56cee6e1cde718980002605ff1 (commit) via bbdcc4c92754c04f1b070ccf746727a3f0eacb3f (commit) from ead0d88c74bd0efba2d2ca0123c51ff2b6cf25fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e86371a0aa3c024d3a60af71ab055c9415efb844 Author: Marc V?ron Date: Fri Aug 15 06:28:07 2014 +0200 Bug 12835 - Acquisitions: Show search terms in z39.50 results To test: - Go to Acquisitions, select a bookshop and a basket, click 'Add to basket':'From an external source' - Do a search - Your search terms should display at the top of the results page. - Repeat search with several combinations of search terms (with and without results). - Check the output for correct html. Fields Raw (any) and Standard ID removed / MV Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Passes QA script, works as described, no problems found. Signed-off-by: Tomas Cohen Arazi commit 25df10e4d84aee069c795f4d02a73a9fee2da7c8 Author: Marcel de Rooy Date: Tue Aug 26 17:06:57 2014 +0200 Bug 12828: Update Z39.50/SRU online help Test plan: Go to Z39.50/SRU servers, click Help and read the text. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Additions to help file, no problems found. Signed-off-by: Tomas Cohen Arazi commit 6f64bb2bd5aef173874b375676ce4858e9c933c5 Author: Marc V?ron Date: Tue Jul 29 16:56:44 2014 +0200 Bug 12746 - Remove empty onclick attribute from memberentrygen.tt This patch removes empty onclick attribute from memberentrygen.tt To test: Apply patch. Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes Go to Home > patrons and click 'New patron' Check HTML of 'Cancel' link Make sure that 'Cancel' link still works Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Changes the link to cancel adding a manual restriction. No regressions found. Signed-off-by: Tomas Cohen Arazi commit 0950e44fafcd74c868ff2d8f105f500bceac5881 Author: Tomas Cohen Arazi Date: Mon Sep 8 10:52:05 2014 -0300 Bug 12821: (qa followup) fix History -> Timeline on the help page Signed-off-by: Tomas Cohen Arazi commit efba7b02dda5cd56cee6e1cde718980002605ff1 Author: Tomas Cohen Arazi Date: Mon Aug 25 12:29:27 2014 -0300 Bug 12821: Capitalization: about page fixes This patch fixes several capitalization issues in the about page. To test: - Go to the about page => FAIL: you should see * Server Information (tab) * Koha Team (tab) * Koha Timeline (tab) * Additional Thanks To... (at the bottom of the Koha Team tab - Apply the patch and reload => SUCCESS: you should see * Server information * Koha team * Timeline * Additional thanks to... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer String changes, no problems found. Signed-off-by: Tomas Cohen Arazi commit bbdcc4c92754c04f1b070ccf746727a3f0eacb3f Author: Katrin Fischer Date: Mon Sep 8 11:28:49 2014 +0200 Bug 12765: Fix capitalization - "Try another search" To test: - Go to cataloguing - Perform a z39.50 search with no results - Check "Try another search" is displayed - Perform a z39.50 search with results - Verify display is correct as well. Signed-off-by: George Williams Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 8 +-- .../prog/en/modules/acqui/z3950_search.tt | 12 +++++ .../prog/en/modules/cataloguing/z3950_search.tt | 2 +- .../intranet-tmpl/prog/en/modules/help/about.tt | 2 +- .../prog/en/modules/help/admin/z3950servers.tt | 51 +++++++++++++------- .../prog/en/modules/members/memberentrygen.tt | 2 +- 6 files changed, 53 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 8 17:39:16 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 08 Sep 2014 15:39:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-563-g6c34c8b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c34c8b650c1894a7696fc26de72d25ce94f2b5d (commit) via 6405f8b53ff0fb1be38018b5ddba50fa9630bb37 (commit) via b338a40e807dbbb064073d8cc1779a1e7ba8a021 (commit) via f6b770686f9d7c4f3983a821a86597bd1e88e24e (commit) via 6069ed645ff0778fd2ec1003a02e55cb2cdbcf04 (commit) via 6af4da3695c4770e528cfe750da949e3e412658a (commit) via b0e5e2c7494e43662867d4049c1c8ecb1afecc80 (commit) from e86371a0aa3c024d3a60af71ab055c9415efb844 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c34c8b650c1894a7696fc26de72d25ce94f2b5d Author: Tomas Cohen Arazi Date: Mon Sep 8 12:28:41 2014 -0300 Bug 7817: (followup) add test on MARC bibliographic framework test Signed-off-by: Tomas Cohen Arazi commit 6405f8b53ff0fb1be38018b5ddba50fa9630bb37 Author: Tomas Cohen Arazi Date: Mon Sep 8 12:04:40 2014 -0300 Bug 7817: DBRev 3.17.00.022 Signed-off-by: Tomas Cohen Arazi commit b338a40e807dbbb064073d8cc1779a1e7ba8a021 Author: Marcel de Rooy Date: Mon Aug 25 13:24:03 2014 +0200 Bug 7817: QA Follow-up: Print a warning when permanent location is mapped Item field permanent location should not be mapped to the MARC structure. If a library did so, this dbrev will print a warning. If refers to report 12818 for help in moving the data to more_subfields_xml. Signed-off-by: Marcel de Rooy Tested by putting permanent_location in and out of the MARC structure. Signed-off-by: Tomas Cohen Arazi commit f6b770686f9d7c4f3983a821a86597bd1e88e24e Author: Marcel de Rooy Date: Mon Aug 18 13:25:48 2014 +0200 Bug 7817: Follow-up for original patch This patch removes the commented line for permanent_location. It adds a more general comment. Adjusts the exists check on permanent_location. Adds a reference to bug 12817 that will deal with paidfor similarly. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 6069ed645ff0778fd2ec1003a02e55cb2cdbcf04 Author: Olli-Antti Kivilahti Date: Wed Jun 18 18:31:13 2014 +0300 Bug 7817 - Items Permanent location (shelving location) is set to NULL when item is edited A quick fix to prevent more damages. No perceived side-effects so far. Signed-off-by: David Cook This is actually a perfectly good fix for this issue. I've changed the explanatory comment to explain why. Another option would be to remove the 'exists' check in the sub _do_column_fixes_for_mod(), but this is just as functional. Signed-off-by: Marcel de Rooy Detailed comment on Bugzilla. Adding a small follow-up. Signed-off-by: Tomas Cohen Arazi commit 6af4da3695c4770e528cfe750da949e3e412658a Author: Kyle M Hall Date: Thu Aug 28 13:47:18 2014 -0400 Bug 12467 [QA Followup] - Unit Tests Signed-off-by: Tomas Cohen Arazi commit b0e5e2c7494e43662867d4049c1c8ecb1afecc80 Author: Kyle M Hall Date: Mon Jun 23 12:21:16 2014 -0400 Bug 12467 - Lost items marked as not on loan even if they are! The cronjob longoverdue.pl does not require that an item marked as lost be returned automatically, but there is a line in ModItem that automatically marks the item's onloan as false if itemlost is set! Test Plan: 1) Mark an item as lost with longoverdue.pl, without --mark-returned 2) Inspect the db, note that items.onloan is now 0 3) Apply this patch 4) Mark repeat step 1 5) Inspect the db, noe that items.onloan is still 1 6) Test marking an item as lost from staff interface, ensure there are no regressions. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Patch works according to test plan and fixes a data loss bug. Some notes: - This patch would be nicer with a regression test. - Also checked that returning the item removes lost status and onloan still. - Tried to test with --mark-returned, but couldn't get it to return my item neither with nor without the patch. (see comment on bug report) Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 ++ C4/Items.pm | 10 +++--- admin/checkmarc.pl | 15 +++++++++ installer/data/mysql/updatedatabase.pl | 14 ++++++++ .../prog/en/modules/admin/checkmarc.tt | 34 ++++++++++++++++++++ kohaversion.pl | 2 +- t/db_dependent/Circulation.t | 12 +++++-- 7 files changed, 81 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 8 18:05:28 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 08 Sep 2014 16:05:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-564-gd908dad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d908dad443556a521127fdaea2c1999e12ed1dfe (commit) from 6c34c8b650c1894a7696fc26de72d25ce94f2b5d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d908dad443556a521127fdaea2c1999e12ed1dfe Author: Marc V?ron Date: Mon Jul 21 20:03:01 2014 +0200 Bug 12698 - If user changes home library in Opac change is not visible in staff client To test: - Set opacuserlogin and OPACPatronDetails to allow - Log in to OPAC, go to 'your personal details' - Change Home library - Go to staff client: Patrons requesting modifications (/cgi-bin/koha/members/members-update.pl) - Without patch, you do not see the change request, but can Approve, Deny or Ignore it - With patch, you see the change request, indicating the Home library (branchcode) Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi I "slightly" rewrote the patch so it applies on current master. ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 9 15:51:19 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 09 Sep 2014 13:51:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-573-g8af38d5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8af38d518fe4d3ef9a467b8db15a066c8ef48f9d (commit) via bfb20c9a7e6cfae9fd841a2be5d63d3337b8ddd8 (commit) via c8016e0a0c9efa433d9470f4dc5d209ea1553868 (commit) via d2a51dea68c8f6ba5543e1445c7c219c016b789f (commit) via a2786c6de70701966f53ec9087b79c9ff1185ce0 (commit) via daede131e0f936a2cc15d486127854db7eacfdc4 (commit) via 55ca3c5581de4b794020c8d555f3f472be641b71 (commit) via d036b9a4d16eb1cda7c992ec54b9b36d7c86402d (commit) via 0965dfcc15567216315ce73716abc469c0f27f53 (commit) from d908dad443556a521127fdaea2c1999e12ed1dfe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8af38d518fe4d3ef9a467b8db15a066c8ef48f9d Author: Tomas Cohen Arazi Date: Tue Sep 9 10:47:02 2014 -0300 Bug 12587: (qa followup) report name consistency Reports home should show the same report name (i.e. "Patrons with the most checkouts") the report itself uses. It is chosen as it is more idiomatic. Signed-off-by: Tomas Cohen Arazi commit bfb20c9a7e6cfae9fd841a2be5d63d3337b8ddd8 Author: Owen Leonard Date: Wed Jul 16 11:23:00 2014 -0400 Bug 12587 - Improve output of filter information on patrons with the most checkouts report This patch makes some changes to the way filter information is displayed after running the patrons with the most checkouts report. Before this patch several untranslatable English strings would be displayed, and library and item type codes would be shown instead of descriptions. To test, go to Reports -> Patrons checking out the most. Enter values for all the filter options: - Checkout date from - Checkout date to - Checkin date from - Checkin date to - Library - Item type - Patron category When you submit the form and view the results you should see your date submissions formatted according to your selected dateformat system preference. The library name and item type names should be shown instead of codes. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer Improves translatability of the filters output after running the report and the readability of them (removing codes). Note: it would be nice if the read-only would be removed from the date fields, as forcing people to use the date widget is a known accessibility issue. Signed-off-by: Tomas Cohen Arazi commit c8016e0a0c9efa433d9470f4dc5d209ea1553868 Author: Robin Sheat Date: Fri Aug 29 16:19:22 2014 +1200 Bug 12849 - fix URLs in sent lists This brings back the http(s) to the URLs in sent lists. Test plan: * make a list * send it to yourself * see that the URLs aren't clickable * apply the patch * repeat, except now the URLs are better Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer By removing this bit of code, the code in Auth.pm is used instead. The code there is not perfect, but the solution works and both list and cart use the same code. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi commit d2a51dea68c8f6ba5543e1445c7c219c016b789f Author: Tomas Cohen Arazi Date: Tue Sep 9 10:11:44 2014 -0300 Bug 12557: DBRev 3.17.00.023 Signed-off-by: Tomas Cohen Arazi commit a2786c6de70701966f53ec9087b79c9ff1185ce0 Author: Jonathan Druart Date: Thu Aug 21 11:02:48 2014 +0200 Bug 12557: Partially received - the change should affect the new order If the receipt in not on the whole order but only on a part of it, the change should be done on the itemnumber linked to the "new order", the one we are reverting. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit daede131e0f936a2cc15d486127854db7eacfdc4 Author: Jonathan Druart Date: Wed Aug 20 12:15:06 2014 +0200 Bug 12557: UT: The item is not created The UT was buggy. I have just fix that in another patch on bug 12555. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 55ca3c5581de4b794020c8d555f3f472be641b71 Author: Jonathan Druart Date: Fri Jul 11 12:09:32 2014 +0200 Bug 12557: Add a way to revert the changes made on items on receving Bug 8307 introduces the AcqItemSetSubfieldsWhenReceived pref. You can now update an item field on receiving (if you create items on ordering). But if the receipt is cancel, there is no way to revert these changes. This patch adds a new pref AcqItemSetSubfieldsWhenReceiptIsCancelled to allow to revert changes previously done on receiving Test plan: 0/ Set the AcqCreateItems to 'ordering' 1/ Fill AcqItemSetSubfieldsWhenReceived with o=1 (UNIMARC) or 7=1 (MARC21). 2/ Fill AcqItemSetSubfieldsWhenReceiptIsCancelled with o=2 (UNIMARC) or 7=2 (MARC21) 3/ Create an order with some items 4/ Receive the order and verify the notforloan value is set to 1 5/ Cancel the receipt and verify the notforloan value is set to 2 Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit d036b9a4d16eb1cda7c992ec54b9b36d7c86402d Author: Jonathan Druart Date: Fri Jul 11 12:08:07 2014 +0200 Bug 12557: DB changes - Add the AcqItemSetSubfieldsWhenReceiptIsCancelled pref Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi commit 0965dfcc15567216315ce73716abc469c0f27f53 Author: Jonathan Druart Date: Thu Aug 28 10:51:03 2014 +0200 Bug 12833: Patron search should search on extended attributes Before Bug 9811, the patron search searched on extended attributes. This patch restore this behavior. Test plan: 0/ Create a patron attribute PA 1/ Create a patron A (cardnumber CNA) with PA="foo" 2/ Create a patron B (cardnumber CNB) with PA="foo bar" 3/ Search for CNA should redirect on the patron detail page. 4/ Search for "foo" should display the search result with 2 results. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer 'Searchable' patron attributes can now be searched for again. Works as described, passes stests and QA script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 21 ++++++++ C4/Utils/DataTables/Members.pm | 9 ++++ installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 9 ++++ .../en/modules/admin/preferences/acquisitions.pref | 3 ++ .../prog/en/modules/reports/bor_issues_top.tt | 42 ++++++++++++++-- .../prog/en/modules/reports/reports-home.tt | 2 +- kohaversion.pl | 2 +- opac/opac-sendshelf.pl | 4 -- reports/bor_issues_top.pl | 2 +- svc/members/search | 14 +++++- t/db_dependent/Acquisition/CancelReceipt.t | 26 +++++++--- t/db_dependent/Utils/Datatables_Members.t | 53 +++++++++++++++++--- 13 files changed, 158 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 10 16:29:54 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 10 Sep 2014 14:29:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-4-g4adc01c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 4adc01c36d9ac8439f7e32df7a48551b9174f6be (commit) from b61580d52c66fb2c696080074e648a347376fe3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4adc01c36d9ac8439f7e32df7a48551b9174f6be Author: Fridolin Somers Date: Tue Jun 17 16:38:54 2014 +0200 Bug 12438 - Bad encoding in acquisition basket We noticed a bad encoding (diacritics replaced by ) in acquisition basket when updating a server to Debian Wheezy. We found it comes from a query containing biblio.title twice. Maybe the mysql newer version creates this side-effect. Test plan : - Create an order on a record containing a diacritic in title - Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x => Without the patch the record title is bad encoded (with ) => With this patch the record title is well encoded - Check also basket CSV export Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Good catch! Works as expected, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi Duplicated biblio.title is a (minor) bug, and should be removed. The side-effect of it solving an encoding problem might be seen as problematic: it hides a real problem. The efforts on 11944 actually solve this encoding problem (11944 merged into master actually fixes this), so I'm pushing it, for a short term solution for stable, with the hope that we will soon have 11944 pushed. BTW, non-diacritic but non-ASCII characters are not broken either. (cherry picked from commit 9fe36e0c705b958859babe565517554b722c66cd) ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 10 16:39:33 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 10 Sep 2014 14:39:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-9-g1925965 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 192596530321c68a2b4d9bbdafa06b4fc9f3b95e (commit) via 8a6ba33e6c2dfdfc0768346d928832e44ecf6953 (commit) via 373af346a7edb0b30080bcb7e904bebccfbab252 (commit) via 4c024dc67b0e0f02e792a2101c1c7ae8672b7fa8 (commit) via 5ddd866f2e73c80109185eae104039892c854f5e (commit) from 4adc01c36d9ac8439f7e32df7a48551b9174f6be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 192596530321c68a2b4d9bbdafa06b4fc9f3b95e Author: Galen Charlton Date: Mon Apr 21 04:15:11 2014 +0000 Bug 7308: (follow-up) tweak style of child fund amounts This patch changes the styling of the amounts of child funds in the funds table to use a more visible indication (i.e., italics rather than a font color of grey) and to use a a new CSS class, "child_fund_amount", rather than a hard-coded style. Signed-off-by: Galen Charlton (cherry picked from commit c3a52a9b200f3e87033ecd8f42938eaa6ddab410) Signed-off-by: Fridolin Somers commit 8a6ba33e6c2dfdfc0768346d928832e44ecf6953 Author: Jonathan Druart Date: Mon Oct 28 12:15:27 2013 +0100 Bug 7308: (follow-up) change color style for fund child Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 773f28ac0d81ce9544fe8052da117e5b0c1da4c7) Signed-off-by: Fridolin Somers commit 373af346a7edb0b30080bcb7e904bebccfbab252 Author: Katrin Fischer Date: Sun Jul 21 10:07:26 2013 +0200 Bug 7308: (follow-up) removing line breaks for better translatability Because of the lines breaks in the table headings the strings were separated in translation. Example: Base-level allocated - Base-level - allocated If you look at a smaller screen the table headings will still break without the additional
. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 3c54feb1b3e15ddeca23adad1bec45e29dfeb1d5) Signed-off-by: Fridolin Somers commit 4c024dc67b0e0f02e792a2101c1c7ae8672b7fa8 Author: Julian Maurice Date: Thu Oct 11 14:14:20 2012 +0200 Bug 7308: rework aqbudgets.pl table admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)". Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer Seems to work alright for me. Passes QA script and tests, after I fixed 2 tabs in admin/aqbudgets.pl. Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 1e808f180540a7552a9c1467ee685ac037d8c042) Signed-off-by: Fridolin Somers commit 5ddd866f2e73c80109185eae104039892c854f5e Author: Julian Maurice Date: Fri Apr 13 10:40:35 2012 +0200 Bug 7308: Show ordered amount in aqbudgets.pl Signed-off-by: C?dric Vita Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit dc3a90c41160493e9dfbf3353d755825c7f403b8) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 12 +-- admin/aqbudgets.pl | 47 +++++----- .../intranet-tmpl/prog/en/css/staff-global.css | 3 + .../prog/en/modules/admin/aqbudgets.tt | 96 ++++++++++++++++---- 4 files changed, 109 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 10 16:55:10 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 10 Sep 2014 14:55:10 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-11-ge199333 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via e1993334cff347b688d6164f6fb631e68258876c (commit) via 6efe23ba8f9ee248237fd0ffd04ec426b7c9ea2b (commit) from 192596530321c68a2b4d9bbdafa06b4fc9f3b95e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e1993334cff347b688d6164f6fb631e68258876c Author: Julian Maurice Date: Thu Jul 25 09:38:24 2013 +0200 Bug 11864: Show parent order line in received orders table Test plan: 1/ Go to the receipt page of a bookseller 2/ Choose an invoice for which you have already partially received some orders (or create an order an receive it partially) 3/ In the received orders table, under column Order line, you should now see the parent order line number in parenthesis Signed-off-by: remy juliette Signed-off-by: Katrin Fischer Passes all tests and QA script. Signed-off-by: Galen Charlton (cherry picked from commit 51c0e46033fffcbb07fb5456640e35fb41623707) Signed-off-by: Fridolin Somers commit 6efe23ba8f9ee248237fd0ffd04ec426b7c9ea2b Author: Julian Maurice Date: Thu Jul 25 09:25:21 2013 +0200 Bug 11864: (code cleanup) re-indent parcel.tt and rename a variable Signed-off-by: remy juliette Signed-off-by: Katrin Fischer Fixed 2 additional tabs. Signed-off-by: Galen Charlton (cherry picked from commit 906b7deffe88bf245d1b21c1e3b8df800034db2e) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 83 +++++++++++--------- 1 file changed, 44 insertions(+), 39 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 10 16:59:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 10 Sep 2014 14:59:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-12-g1d360b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1d360b8a0a4e1605d486d9b25a13f22944710caf (commit) from e1993334cff347b688d6164f6fb631e68258876c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1d360b8a0a4e1605d486d9b25a13f22944710caf Author: Owen Leonard Date: Mon Apr 21 12:55:23 2014 -0400 Bug 12117 - Remove unused image myshadow.png from the staff client myshadow.png was used by a jQuery plugin which has long been removed. This patch removes it. To test, search the Koha source for references to myshadow.png. There should be none. Followed test plan, patch removed file as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 5c573a7ad8d50788d3b5a78e58efb8c758a9ec0c) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/myshadow.png | Bin 5741 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/myshadow.png hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 10 17:05:34 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 10 Sep 2014 15:05:34 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-13-gf0791a8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via f0791a89ba8c5348ce54313aa1624bf6a99efd13 (commit) from 1d360b8a0a4e1605d486d9b25a13f22944710caf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f0791a89ba8c5348ce54313aa1624bf6a99efd13 Author: Bernardo Gonzalez Kriegel Date: Sat Mar 22 13:53:44 2014 -0300 Bug 11639: fix untranslatable strings in 007 builder This patch modifies marc21_field_007.tt to make some missing strings translatable To test: 1) Using your preferred language, xx-YY, updatepo files cd misc/translator perl translate update xx-YY 2) Check that missing strings are NOT present egrep -i "exact bit depth|pad with zero|use up to 6" po/xx-YY-i-staff-t-prog-v-3006000.po 3) Apply the patch 4) repeat 1) 5) Repeat 2), check that missing strings are present Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Template change, works as described. Signed-off-by: Galen Charlton (cherry picked from commit d944728a917b5645ef3248e9689638f565388025) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../cataloguing/value_builder/marc21_field_007.tt | 22 ++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 10 17:07:06 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 10 Sep 2014 15:07:06 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-14-g9c3e95f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 9c3e95f196efa590b8aea3fee6334c9bf0d66adf (commit) from f0791a89ba8c5348ce54313aa1624bf6a99efd13 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9c3e95f196efa590b8aea3fee6334c9bf0d66adf Author: Bernardo Gonzalez Kriegel Date: Sat Mar 22 14:50:03 2014 -0300 Bug 11646: fix untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described. Signed-off-by: Galen Charlton (cherry picked from commit a9f794a9c89465bdbf1b54ecd1c683c7825c8ae3) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/cataloguing/value_builder/marc21_field_006.tt | 2 +- .../prog/en/modules/cataloguing/value_builder/marc21_field_008.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 10 17:18:29 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 10 Sep 2014 15:18:29 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-15-gfd83e8f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via fd83e8fa0d053d841fda5df4356e28c75aa59f22 (commit) from 9c3e95f196efa590b8aea3fee6334c9bf0d66adf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fd83e8fa0d053d841fda5df4356e28c75aa59f22 Author: Magnus Enger Date: Mon Oct 14 21:10:31 2013 +0200 Bug 10782 - Add a koha-mysqlcheck script This patch adds the koha-mysqlcheck script, as a "frontend" for the mysqlcheck command. It can be used to check the integrity of database tables, as well as to repair them. See "man mysqlcheck" for more information. The script takes a Koha instance name as its only required parameter. Any other parameters provided before the instance name are passed directly to mysqlcheck, which means that all the functionality of mysqlcheck is available through this script. To test the script: - Apply the patch, build your own packages and install them, or - copy koha-mysqlcheck to a server already running off packages - Run some variations of the command, with and without arguments, and check that the output makes sense. E.g.: sudo koha-mysqlcheck myinstance sudo koha-mysqlcheck -e myinstance # Extended checks sudo koha-mysqlcheck -e -v myinstance # Extended checks and verbose - See "man mysqlcheck" for other relevant options To test the man page: - Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-mysqlcheck.xml $ man -l koha-mysqlcheck.8 - Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Galen Charlton (cherry picked from commit 25c932967f9def41b689b07f4536f398b612944b) ----------------------------------------------------------------------- Summary of changes: debian/docs/koha-mysqlcheck.xml | 44 ++++++++++++++++++++++++ debian/scripts/{koha-mysql => koha-mysqlcheck} | 38 ++++++++++++-------- 2 files changed, 67 insertions(+), 15 deletions(-) create mode 100644 debian/docs/koha-mysqlcheck.xml copy debian/scripts/{koha-mysql => koha-mysqlcheck} (52%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Sep 14 07:03:49 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 14 Sep 2014 05:03:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-579-g3fa6bf0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3fa6bf051af4d84d78e6899ea35d18418652b79b (commit) via cc063de044769e047e53d8afc636a22772af1d0e (commit) via 10622af4993045afe6d64c15d9f0d7a4bc4a7fc4 (commit) via 3e78a908f0fb7c904ab478d1c4f8ede4bab3c9ba (commit) via e261343aac9fab0b737962fe740c9f30b0d8d41b (commit) via d968df4743a50d6ae283977e438843340597b7ca (commit) from 8af38d518fe4d3ef9a467b8db15a066c8ef48f9d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3fa6bf051af4d84d78e6899ea35d18418652b79b Author: Dobrica Pavlinusic Date: Wed Sep 10 13:27:20 2014 +0200 Bug 12898 - Z39.50 title search doesn't work with multiple words This fixes regression introduced by Bug 6536 so that multiple words in title search will work. Test scenario: 1. try z39.50 search with more than one word 2. verify that no results apper 3. apply patch and re-run search 4. verify that there are results Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit cc063de044769e047e53d8afc636a22772af1d0e Author: Tomas Cohen Arazi Date: Sun Sep 14 01:55:33 2014 -0300 Bug 12898: (regression test) test terms inside double quotes Signed-off-by: Tomas Cohen Arazi commit 10622af4993045afe6d64c15d9f0d7a4bc4a7fc4 Author: Jonathan Druart Date: Wed Sep 10 16:21:09 2014 +0200 Bug 10226: Add unit tests for GetReservesFromItemnumber Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 3e78a908f0fb7c904ab478d1c4f8ede4bab3c9ba Author: Kyle M Hall Date: Wed Aug 27 08:29:05 2014 -0400 Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit e261343aac9fab0b737962fe740c9f30b0d8d41b Author: Owen Leonard Date: Mon Jul 14 12:49:27 2014 -0400 Bug 12574 - BiblioDefaultView doesn't affect XSLT results view The OPAC's XSLT results view does not respect the choice set in the BiblioDefaultView system preference. This patch adds a check of the preference to the OPAC's results view for MARC21. To test you must have the OPAC configured to use the XSLT view for search results. Perform any search and test the link to a title's detail page. Switching the values of the BiblioDefaultView should be correctly reflected in the search results links. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Works as described for XSLT view in OPAC. Notes: - maybe we should change the pref text from 'simple form' to 'normal view'. - the patch doesn't include changes to the title link generated from an 880 field - so those links will still lead to the wrong view. Signed-off-by: Tomas Cohen Arazi commit d968df4743a50d6ae283977e438843340597b7ca Author: Owen Leonard Date: Mon Jul 14 13:07:42 2014 -0400 Bug 10571 - IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT The staff client's XSLT results view does not respect the choice set in the IntranetBiblioDefaultView system preference. This patch adds a check of the preference to the staff client's results view for MARC21. To test you must have the staff client configured to use the XSLT view for search results. Perform any search and test the link to a title's detail page. Switching the value of the IntranetBiblioDefaultView preference should be correctly reflected in the search results links. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors. Only for MARC21 :( Signed-off-by: Katrin Fischer Works as described, no problems found. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Breeding.pm | 2 +- C4/Reserves.pm | 41 +++++++++++++------- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 21 +++++++++- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 18 ++++++++- t/db_dependent/Breeding.t | 15 +++++-- t/db_dependent/Holds.t | 7 +++- 6 files changed, 83 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 15 20:43:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 15 Sep 2014 18:43:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-581-g8a63c17 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8a63c17f79d63bcdb669b74b084b83b65295d246 (commit) via 692e0572e1a1f96412ac665d090ccb08cd4b9132 (commit) from 3fa6bf051af4d84d78e6899ea35d18418652b79b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8a63c17f79d63bcdb669b74b084b83b65295d246 Author: Robin Sheat Date: Mon Sep 15 14:08:03 2014 +1200 Bug 12918: fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: 1) prove -v t/db_dependent/Templates.t -- bombs! 2) apply patch 3) prove -v t/db_dependent/Templates.t -- works! Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 692e0572e1a1f96412ac665d090ccb08cd4b9132 Author: Robin Sheat Date: Thu Sep 4 17:02:21 2014 +1200 Bug 12870 - require a higher version of Test::Simple New test cases won't build with the version of this in squeeze. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: debian/control | 6 +++++- debian/control.in | 2 +- t/{ => db_dependent}/Templates.t | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) rename t/{ => db_dependent}/Templates.t (97%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 16 20:23:18 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 16 Sep 2014 18:23:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-586-g84b4ace Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 84b4ace746699318e16f5c7a07023dbb3af55efd (commit) via d8ed9130593d1d83be1674de076f7f2367039d9c (commit) via 7289214e30083ae6addb9137b0480ea5b68b8d71 (commit) via b8fae8489f013d55fac6c660e80bbd7aed31deff (commit) via 09c4417216c32d6af74da193933e95374b0ee7df (commit) from 8a63c17f79d63bcdb669b74b084b83b65295d246 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 84b4ace746699318e16f5c7a07023dbb3af55efd Author: Tomas Cohen Arazi Date: Fri Sep 5 12:41:20 2014 -0300 Bug 12879: Remove unnecesary diags from Holds.t There are two unnecessary diag statements: - Creating biblio instance for testing. - Creating item instance for testing. TEST PLAN --------- 1) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 # Creating biblio instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. # Creating item instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.13 cusr 0.11 csys = 1.28 CPU) Result: PASS -- They are in the first and fourth lines of this sample output 2) apply patch 3) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.78 cusr 0.09 csys = 0.88 CPU) Result: PASS -- They are no longer in the first and fourth lines of this sample output 4) run koha QA test tool Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit d8ed9130593d1d83be1674de076f7f2367039d9c Author: Owen Leonard Date: Wed Sep 10 08:56:24 2014 -0400 Bug 12899: Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 7289214e30083ae6addb9137b0480ea5b68b8d71 Author: Jacek Ablewicz Date: Sat Aug 23 16:36:21 2014 +0200 Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions In case when the staff user doesn't have (circulate) -> (override_renewals) permission granted, this code part var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; in circ/circulation.tt and members/moremember.tt leads to javascript error, because TT statement evaluates to empty string. To reproduce: - set AllowRenewalLimitOverride syspref to "Don't allow" (this step is possibly redundant / not quite relevant), - for testing purposes, log in as some (sample) staff user whitch does not have permission granted for "(override_renewals) Override blocked renewals", - have a look at some patron accounts (preferably, ones with 1+ check-out), observe that page layout is incorrect in "Check Out" and "Details" tab. To test: - apply patch, - retest and ensure that this issue is no longer reproductible, - make sure that there are no regressions of any kinds regarding renewal override permission for staff users (i.e, that it still works like intended). Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described, passes QA script and tests. Signed-off-by: Tomas Cohen Arazi commit b8fae8489f013d55fac6c660e80bbd7aed31deff Author: Dobrica Pavlinusic Date: Thu Sep 4 15:16:57 2014 +0200 Bug 12729 - Overdue items won't show as overdue in red in circulation It seems that Firefox date parser doesn't like our dates which are formatted in ISO format like "2014-08-06 00:00:00". This results in missing red color in overdue dates. So intead of munching different date formats and JavaScript (and having to support different browers) this patch moves check for overdue dates back to mysql and just transfers boolean value to JavaScript so it can show correct class for date_due. Test scenario: 1. find borrower with overdue checkouts 2. verify that all dates are black (and are in ISO format) 3. apply this patch 4. reload page and verify that overdue dates turned red Signed-off-by: Katrin Fischer Tested with different due dates (hourly and not) and different date formats. Passes tests and QA script. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 09c4417216c32d6af74da193933e95374b0ee7df Author: Jacek Ablewicz Date: Tue Sep 2 11:46:06 2014 +0200 Bug 12859 - Patron import tool doesn't import extened attributes values any longer To reproduce: 1/ define/set up extended pattron attribute in administration module, 2/ using "Tools -> Import patrons", try to import some sample patron record[s], having some arbitrary (non-empty) value assigned in 'pattron_attributes' CSV column for attribute defined in step 1/, 3/ observe that extended attribute defined in step 1/ was not imported (not added to the database), without any warnings. This patch restores a small code chunk which went AWOL somewhere around commit b4158f2d2485c9e57bd7f14362b210732bef9d35. To test: 1/ apply patch & retest, 3/ ensure that this issue is no longer reproductible, and there are no apparent regressions of any kind, 4/ make sure that the ability to specify default value for extended attributes added in bug Bug 12716 is still working as intended (= follow up the test plan for bug 12716). Signed-off-by: Petter Goksoyr Asen Patch fixes import of extended patron attributes. Step 1-3 in test plan confirmed. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/checkouts-table-footer.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 16 ++++++++++++---- .../intranet-tmpl/prog/en/modules/circ/circulation.tt | 3 ++- .../prog/en/modules/members/moremember.tt | 2 +- svc/checkouts | 2 ++ t/db_dependent/Holds.t | 6 ++---- tools/import_borrowers.pl | 3 +++ 7 files changed, 23 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 17 16:34:29 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 17 Sep 2014 14:34:29 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-16-g1abe244 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 1abe2442178ae6e87f51fd3a288769b1e33eb7f9 (commit) from fd83e8fa0d053d841fda5df4356e28c75aa59f22 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1abe2442178ae6e87f51fd3a288769b1e33eb7f9 Author: Owen Leonard Date: Thu Apr 17 15:18:36 2014 -0400 Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js This patch removes a redundant copy of the DataTables plugin jquery.dataTables.columnFilter.js and corrects two templates. The path to the plugin has been modified in acqui/parcel.tt: - Go to Acquisitions and search for a vendor. - Open the detail page for that vendor. - Click the "Receive shipments" button. - Select an invoice to view. - In the table of titles, confirm that the column header search forms work to filter column data. In the template for the Staged MARC management page the plugin has been removed as it is unused. A couple of markup corrects have been made. Confirm that table sorting is unaffected by going to Administration -> Staged MARC management, clicking a staged MARC file, and viewing the table of items in that batch. There should be no more remaining instances of this path in the templates: [% themelang %]/lib/jquery/plugins/jquery.dataTables.columnFilter.js Signed-off-by: Mark Tompsett NOTE: I believe the sort order of the Order Line column is strange, but unrelated to this patch. The search area functions (filtering, paging, page size, etc.) worked fine. Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 45ce7431d42cd470d7f7326d8935333014b1f62c) Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt ----------------------------------------------------------------------- Summary of changes: .../plugins/jquery.dataTables.columnFilter.js | 762 -------------------- .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- 2 files changed, 1 insertion(+), 763 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.columnFilter.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 17 16:38:29 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 17 Sep 2014 14:38:29 +0000 Subject: [koha-commits] main Koha release repository branch 3.14.x updated. v3.14.10-17-g79b0191 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.14.x has been updated via 79b0191649809ac198bc1f0a57e7db1a68e4df39 (commit) from 1abe2442178ae6e87f51fd3a288769b1e33eb7f9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 79b0191649809ac198bc1f0a57e7db1a68e4df39 Author: Galen Charlton Date: Sat Apr 19 21:57:08 2014 +0000 Bug 12112: remove disused routine C4::Breeding::ImportBreeding() This patch removes the ImportBreeding() routine, which lost its last caller as of the patch for bug 10462. To test: [1] Verify that prove -v t/Breeding.t passes. [2] Perform a Z39.50 search in the staff interface. [3] Perform a cataloguing reservoir search in the staff interface; verifying that cached records from the search done in step 2 are retrieved. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton (cherry picked from commit 990bb17e14efb8a2c16236c89ef5869dcfc48ad4) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Breeding.pm | 112 +++----------------------------------------------------- 1 file changed, 5 insertions(+), 107 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 18 01:11:55 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 17 Sep 2014 23:11:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-599-gcd69768 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cd69768f72493d9ec2f2e8015e6f435e9cff18f4 (commit) via eb4df0eff2960772522946bc451803a0af8fb87f (commit) via 84548dcba952e0a32db84ea26d0a3be272e5cec2 (commit) via 788d6bd724abf2573f699a90d0b7857e01264584 (commit) via 6d022bd4a40358d08b3ef3f2a5fd6fdde2f1a336 (commit) via 904b35645cb01de36ff72450decf80c55a80da08 (commit) via d02f87a2986bd20e513e02ab299a9b66af9ea08f (commit) via 17821c58ccbeeb719e283e7932064e6ea61d657e (commit) via 0270b8d3b6a8974fae64340cbfc6228692369d00 (commit) via 555d0d5898faccaf0d8c4c3c39630a23089b57c2 (commit) via b49bcfef092b86d875749ce79501aec77d055515 (commit) via 633f6c150ed26b3a22bdef24bf06fab9273c4eb1 (commit) via 282aa8ffced619b17be398065ed74b3cf44146d3 (commit) from 84b4ace746699318e16f5c7a07023dbb3af55efd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cd69768f72493d9ec2f2e8015e6f435e9cff18f4 Author: Kyle M Hall Date: Wed Aug 27 09:05:12 2014 -0400 Bug 10883 - AllowHoldDateInFuture can let a patron jump to the top of the holds list If a patron is allowed to add a future date for the hold using the "Hold starts on date" field, that patron can put a date in that is in the *past* which will cause them to move to the top of the holds queue ( assuming they make the past date far enough back that it is earlier than all the other hold dates ). Test Plan: 1) Enable future holds 2) Note you can use dates in the past for "hold starts on date" 3) Note you can use dates in the past for "hold expires on date" 4) Apply this patch 5) Refresh the page 6) Note you can no longer use dates in the past for those fields Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Changed subject: OpacAllowHoldDateInFuture to AllowHoldDateInFuture as this fix applies to staff. Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi commit eb4df0eff2960772522946bc451803a0af8fb87f Author: Tomas Cohen Arazi Date: Wed Sep 17 20:08:14 2014 -0300 Bug 11577: DBRev 3.17.00.024 Signed-off-by: Tomas Cohen Arazi commit 84548dcba952e0a32db84ea26d0a3be272e5cec2 Author: Martin Renvoize Date: Wed Aug 27 17:32:38 2014 +0000 Bug 11577 : Fixing a tiny copy/paste issue Signed-off-by: Tomas Cohen Arazi commit 788d6bd724abf2573f699a90d0b7857e01264584 Author: Chris Cormack Date: Tue Jul 29 17:58:57 2014 +1200 Bug 11577 : Fixing a tiny typo Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 6d022bd4a40358d08b3ef3f2a5fd6fdde2f1a336 Author: Holger Mei?ner Date: Thu May 22 10:21:09 2014 +0200 Bug 11577: Add Hochschule f?r Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 904b35645cb01de36ff72450decf80c55a80da08 Author: Holger Mei?ner Date: Mon May 19 14:00:48 2014 +0200 Bug 11577: Unit tests This patch fixes two unit tests that broke because of the new feature. Also adds some new test cases. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit d02f87a2986bd20e513e02ab299a9b66af9ea08f Author: Holger Mei?ner Date: Fri May 16 13:14:32 2014 +0200 Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 17821c58ccbeeb719e283e7932064e6ea61d657e Author: Holger Mei?ner Date: Thu May 15 16:48:02 2014 +0200 Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 0270b8d3b6a8974fae64340cbfc6228692369d00 Author: Holger Mei?ner Date: Wed May 21 15:45:35 2014 +0200 Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 555d0d5898faccaf0d8c4c3c39630a23089b57c2 Author: Holger Mei?ner Date: Wed May 21 15:15:11 2014 +0200 Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit b49bcfef092b86d875749ce79501aec77d055515 Author: Holger Mei?ner Date: Thu May 15 16:43:00 2014 +0200 Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Scheduled for automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 633f6c150ed26b3a22bdef24bf06fab9273c4eb1 Author: Holger Mei?ner Date: Thu May 15 16:30:39 2014 +0200 Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 282aa8ffced619b17be398065ed74b3cf44146d3 Author: Holger Mei?ner Date: Thu May 15 16:18:36 2014 +0200 Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 67 ++++++++++---------- admin/smart-rules.pl | 9 +-- circ/circulation.pl | 7 +- circ/renew.pl | 2 +- debian/koha-common.cron.daily | 1 + installer/data/mysql/kohastructure.sql | 3 + installer/data/mysql/updatedatabase.pl | 15 +++++ .../intranet-tmpl/prog/en/includes/strings.inc | 2 + koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 14 ++++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 1 + .../en/modules/admin/preferences/circulation.pref | 2 +- .../prog/en/modules/admin/smart-rules.tt | 14 ++++ .../prog/en/modules/circ/circulation.tt | 9 +++ .../intranet-tmpl/prog/en/modules/circ/renew.tt | 24 +++++++ .../prog/en/modules/reserve/request.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 3 + kohaversion.pl | 2 +- misc/cronjobs/automatic_renewals.pl | 60 ++++++++++++++++++ misc/cronjobs/crontab.example | 3 + opac/opac-user.pl | 6 +- t/db_dependent/Circulation.t | 32 +++++++++- t/db_dependent/Circulation_Issuingrule.t | 9 ++- 22 files changed, 241 insertions(+), 46 deletions(-) create mode 100644 misc/cronjobs/automatic_renewals.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 18 02:11:47 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 18 Sep 2014 00:11:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-600-gd15ceca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d15cecacedd58abdafa0b0276a3002af7b266090 (commit) from cd69768f72493d9ec2f2e8015e6f435e9cff18f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d15cecacedd58abdafa0b0276a3002af7b266090 Author: Tomas Cohen Arazi Date: Wed Sep 17 21:10:20 2014 -0300 Bug 11577: Update DBIx Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Issue.pm | 12 ++++++++++-- Koha/Schema/Result/Issuingrule.pm | 12 ++++++++++-- Koha/Schema/Result/OldIssue.pm | 12 ++++++++++-- 3 files changed, 30 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 18 02:35:09 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 18 Sep 2014 00:35:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-606-g33d7a28 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 33d7a28afa927ae190f819ffc98b578dcef4f296 (commit) via a6da517127aeb4c89c204e3a672831e0069ed4ba (commit) via 9d48d31130c554ee889d2ab4ff690fe9915af0ea (commit) via 5af96e0f78d676c202f634e45dff7def31d10c4f (commit) via 2217f98b7cf1da89ed3e4bcc2cc497fe01df724c (commit) via 55e5c82ab593c180e0b73f1cd13bbc71ee7a39c6 (commit) from d15cecacedd58abdafa0b0276a3002af7b266090 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33d7a28afa927ae190f819ffc98b578dcef4f296 Author: Tomas Cohen Arazi Date: Wed Sep 17 21:33:49 2014 -0300 Bug 12728: DBRev 3.17.00.025 commit a6da517127aeb4c89c204e3a672831e0069ed4ba Author: Marcel de Rooy Date: Thu Aug 21 13:06:20 2014 +0200 Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql This patch adds a dbrev. If people installed Koha after the initial dbrev (3.09.00.015), an install with sysprefs.sql did not add the pref. So they still could not have it. Test plan: If you have the pref, running an database update should not do anything. If you do not have the pref (delete it via mysql), it should be added. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 9d48d31130c554ee889d2ab4ff690fe9915af0ea Author: Marcel de Rooy Date: Thu Aug 7 14:16:24 2014 +0200 Bug 12728: Add StatisticsFields to sysprefs.sql Bug 7955: [Statistics tab for Patron checkouts] introduced the pref StatisticsFields but did not add it to the sql install file. Test plan: Run webinstaller or mysql ... < sysprefs.sql Verify that the new pref is in your systempreferences table. Signed-off-by: Bernardo Gonzalez Kriegel Run webinstall, new syspref loaded. No koha-qa errors. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 5af96e0f78d676c202f634e45dff7def31d10c4f Author: Jonathan Druart Date: Tue Aug 26 16:43:49 2014 +0200 Bug 12827: NewOrder needs more unit tests NewOrder should be more tested! This patch moves the existing unit tests into a new file and adds some unit tests. Note that there is no DB field aqorders.subscription, so the test in NewOrder can be removed. Test plan: prove t/db_dependent/Acquisition/NewOrder.t and prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Zeno Tajoli Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 2217f98b7cf1da89ed3e4bcc2cc497fe01df724c Author: Jonathan Druart Date: Tue Aug 26 16:06:10 2014 +0200 Bug 12827: NewOrder should not return basketno Since the basketno parameter is needed to insert an order, it is useless to return it. This patch changes the prototype for the C4::Acquisition::NewOrder subroutine. The return value is now a scalar containing the ordernumber created. Test plan: Verify there is no regression on an acquisition workflow: 1/ Create an order with several items 2/ Modify the order 3/ Receive some items 4/ Cancel the receipt 4/ Receive some items 5/ Receive all remaining items 6/ Cancel the receipt Signed-off-by: Zeno Tajoli Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 55e5c82ab593c180e0b73f1cd13bbc71ee7a39c6 Author: Jonathan Druart Date: Mon Sep 8 20:25:27 2014 +0200 Bug 12891: NewOrder does not return ordernumber if ordernumber is defined The behavior is quite weird, but $schema->resultset('Table')->create($data)->id does not return the id inserted if $data contains the key. To be more clear, in this case $schema->resultset('Aqorder')->create($new_order)->id returns an empty string because $new_order->{ordernumber} is an empty string! This was not caught by the unit tests, I added one. Test plan: - AcqCreateItem set to ordering - Create an order with items and verify items are correctly linked to the order. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Katrin Fischer Confirmed that without the patch the created item is not linked to the order (entry in aqorders_items). With the patch, it works as expected. Passes tests and Koha QA script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 37 ++++----- acqui/addorder.pl | 2 +- acqui/addorderiso2709.pl | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 +++ kohaversion.pl | 2 +- t/db_dependent/Acquisition.t | 47 +---------- t/db_dependent/Acquisition/CancelReceipt.t | 4 +- .../Acquisition/GetBasketsInfosByBookseller.t | 4 +- .../Acquisition/GetOrdersByBiblionumber.t | 6 +- t/db_dependent/Acquisition/Invoices.t | 6 +- t/db_dependent/Acquisition/NewOrder.t | 86 ++++++++++++++++++++ t/db_dependent/Acquisition/OrderFromSubscription.t | 2 +- t/db_dependent/Acquisition/TransferOrder.t | 2 +- t/db_dependent/Acquisition/close_reopen_basket.t | 4 +- t/db_dependent/Bookseller.t | 35 ++++---- t/db_dependent/Budgets.t | 4 +- 17 files changed, 155 insertions(+), 99 deletions(-) create mode 100644 t/db_dependent/Acquisition/NewOrder.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 18 02:57:34 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 18 Sep 2014 00:57:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-612-g9351cde Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9351cde90f4be04c98a5760e203ba7db40061dfb (commit) via 77e8cf024d4da039356db1e7e1c318d2bf4a77c2 (commit) via 3996fa7b47c519cbb7bd9adf3e76af5fd0d7bb24 (commit) via 781142224cde1df1c7cd08ca45f0d1ac7b763096 (commit) via f10f88266b7af19205bcd210b060dfd656945e53 (commit) via dbe1e920d3fd448fe5490442fb98f4a6599b71ac (commit) from 33d7a28afa927ae190f819ffc98b578dcef4f296 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9351cde90f4be04c98a5760e203ba7db40061dfb Author: Jacek Ablewicz Date: Sat Aug 2 10:13:16 2014 +0200 Bug 12697 - Surplus closing in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing in line 336 (= line 332, in case Bug 12521 is applied first): 336: which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl- several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible Signed-off-by: Bernardo Gonzalez Kriegel On top of 12521, don't know exactly what to reproduce, but surplus '' is real (33 open, 34 close). Everything looks correct, no koha-qa errors. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 77e8cf024d4da039356db1e7e1c318d2bf4a77c2 Author: Liz Rea Date: Thu Jul 3 10:09:22 2014 +1200 Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. Patch behaves as expected. Advanced search looks much better now. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Checked visually and with HTML validator. Signed-off-by: Tomas Cohen Arazi commit 3996fa7b47c519cbb7bd9adf3e76af5fd0d7bb24 Author: Marc V?ron Date: Wed Sep 10 16:10:21 2014 +0200 Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration This patch resolves the ambiguity of the word "Checked" for Z39.50 server administration. To test: Apply patch In staff client, go to Home:Administration:Z39.50/SRU servers Result: Column heading of 6th column should show "Preselected" (instead of "Checked") Edit or create new server for Z39.50 and SRU Result: Checkbox underneath "Password" should have label "Preselected (searched by default):" Click "Help" at top right of screen Result: Wording changed for selecting targets as default. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 781142224cde1df1c7cd08ca45f0d1ac7b763096 Author: Owen Leonard Date: Fri Sep 5 09:04:41 2014 -0400 Bug 12863 [CSS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch contains the revised and compiled CSS which will style the OPAC's new news markup to match the previous version. To test, apply the patch and clear your browser cache if necessary. View news in the OPAC and confirm that it is styled like it was before the patch making markup changes. CSS patch behaves as expected. Thanks to Owen for adding this. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit f10f88266b7af19205bcd210b060dfd656945e53 Author: Owen Leonard Date: Fri Sep 5 09:02:28 2014 -0400 Bug 12863 [LESS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This follow-up modifies the LESS file to add style to the new markup to match the previous markup. A subsequent patch will include the revised and compiled CSS. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit dbe1e920d3fd448fe5490442fb98f4a6599b71ac Author: Marc V?ron Date: Wed Sep 3 12:10:26 2014 +0200 Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch fixes broken HTML in OPAC news by replacing table display with divs. To test: Create multiple news for OPAC Validate with HTML validator or check source code Result: Error with nested p tags Table header thead is repeated for every news (not allowed) Bonus testing: Let a screen reader like NVDA read the news and try to understand it with closed eyes. Apply patch Result: No more HTML errors in news Screen reader reads news properly To style you can use classes newscontainer, newsitem, newsheader, newsbody and newsfooter. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/z3950servers.tt | 4 ++-- .../prog/en/modules/help/admin/z3950servers.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- .../bootstrap/en/modules/opac-advsearch.tt | 13 ++++------- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 16 ++++++------- koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 24 ++++++++++++++++++++ 6 files changed, 40 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 18 03:08:14 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 18 Sep 2014 01:08:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-615-ge2b0454 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e2b0454ed43622302aac49b6dae7f3388639269e (commit) via bb78928bef7185ead7156acd1ffc3fb278db2985 (commit) via 5d5481ed1900322eb67029478dd474290255c734 (commit) from 9351cde90f4be04c98a5760e203ba7db40061dfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e2b0454ed43622302aac49b6dae7f3388639269e Author: Jonathan Druart Date: Fri Aug 29 16:41:29 2014 +0200 Bug 12609: Add some unit tests for C4::Ratings Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit bb78928bef7185ead7156acd1ffc3fb278db2985 Author: Kyle M Hall Date: Fri Jul 18 10:42:03 2014 -0400 Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Also tested: - Adding a rating - Rating displayed on detail - Rating displayed on results - Modifying a rating - Change displayed correctly on detail and results Signed-off-by: Tomas Cohen Arazi commit 5d5481ed1900322eb67029478dd474290255c734 Author: Owen Leonard Date: Mon Sep 8 14:16:14 2014 -0400 Bug 12890 - Improve title and breadcrumbs when editing saved SQL report When editing an existing SQL report the page title and breadcrumbs are incomplete: Home > Reports > Guided reports wizard > This patch corrects this. To test, apply the patch and edit an existing SQL report. The page title and breadcrumbs should be more complete: Home > Reports > Guided reports wizard > Saved reports > Edit SQL report Patch behves as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Ratings.pm | 91 +++++++----- .../en/modules/reports/guided_reports_start.tt | 2 + t/db_dependent/Ratings.t | 146 ++++++++++++-------- 3 files changed, 142 insertions(+), 97 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 18 03:15:57 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 18 Sep 2014 01:15:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-616-ga414f41 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a414f413c82c71ce6d14aa1f416ec6fdf0300f13 (commit) from e2b0454ed43622302aac49b6dae7f3388639269e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a414f413c82c71ce6d14aa1f416ec6fdf0300f13 Author: Marc V?ron Date: Mon Jul 21 20:52:41 2014 +0200 Bug 4927 - OPAC advanced search has two call number entries; remove one? This patch removes the second Call number entry in OPAC Advanced search with Advanced option (for bootstrap). To test: - Go to OPAC, Advanced search, enable Advaced options - In dropdowns you see two entries "Call number" - Apply patch - Verify that the second "Call number" has disappeared (below ISSN) Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer Template change only - no problems found. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 5 ----- 1 file changed, 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 18 15:09:10 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 18 Sep 2014 13:09:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-622-g81b9d8b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 81b9d8b8aac5c67d01dbac64a1dfa9de880e021d (commit) via 3c1c5c04ceafb411dde1426967cb969a3969f80a (commit) via 45f474abdf935c928b4cd20e9823c96ca82af398 (commit) via 3ce2c0235ca8a1dc0d891e17cac5faeb6bea7caa (commit) via bf26d347c17907878f31e4d37d9204c96b44f14b (commit) via 2aded36d08fab552bab112fcec74247c68d45d22 (commit) from a414f413c82c71ce6d14aa1f416ec6fdf0300f13 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81b9d8b8aac5c67d01dbac64a1dfa9de880e021d Author: Jonathan Druart Date: Thu Sep 18 09:42:02 2014 +0200 Bug 12953: FIX NewOrder test The patch for bug 12827 has been written some days before bug 10402. One occurrence of NewOrder has not been modified. Test plan: prove t/db_dependent/Letters.t should return green. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 3c1c5c04ceafb411dde1426967cb969a3969f80a Author: Katrin Fischer Date: Mon Aug 18 11:02:01 2014 +0200 Bug 8868: Follow-up: Update boostrap documentation page Updates the bootstrap documentation page for CancelHold. commit 45f474abdf935c928b4cd20e9823c96ca82af398 Author: Julian Maurice Date: Wed Oct 3 13:23:04 2012 +0200 Bug 8868: ILS-DI: CancelHold needs to take a reserve_id CancelHold takes two parameters: patron_id and item_id. If item_id is considered as an itemnumber, holds on title can't be canceled. If item_id is considered as a biblionumber, all holds on this biblionumber (for a borrower) will be canceled. So CancelHold have to consider item_id as a reserve_id. - Added subroutine C4::Reserves::GetReserve - C4::ILSDI::Services::GetRecords now returns the reserve_id - Fix the text in the ilsdi.pl?service=Describe&verb=CancelHold page - Unit tests for CancelReserved and GetReserve - Do not delete row in reserves table if insert in old_reserves fails Signed-off-by: Leila and Sonia Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack Signing off, while noting a style issue in the patch review Signed-off-by: Katrin Fischer Passes tests and QA script. Placed and cancelled a hold using ILS-DI successfully. Adding a follow-up to also update the ils-di documentation page in the bootstrap theme. Signed-off-by: Tomas Cohen Arazi EDIT: I removed the changes it did to the prog theme. commit 3ce2c0235ca8a1dc0d891e17cac5faeb6bea7caa Author: Fridolin Somers Date: Wed Jun 11 12:25:19 2014 +0200 Bug 12405 - Search links on callnumber fails on intranet results page On intranet results page, the callnumber of items is a search like : /cgi-bin/koha/catalogue/search.pl?idx=callnum&q=[% result.itemcallnumber |url %] The callnumber should be URI-escaped to avoid special URI characters like & , ? ... If the callnumber contains some CCL words or parenthesis, the search will fail, it should be wrapped with double-quotes. This patch adds this to catalogue/results.pl and catalogue/shelves.pl : - uri TT filter instead of url - adds double-quotes using there URI code %22 since its in a HTML attribute using double-quotes Test plan : - Edit an item callnumber with : & ABC 123 - Index zebraqueue - Perform a search returning this item - Click on the callnumber => Without this patch you get no result, because URL parameters are : idx=callnum&q=& ABC 123 => With this patch you get results - Set syspref QueryWeightFields off (because this is no bug if on) - Edit an item callnumber with : AB(C) AND OR - Index zebraqueue - Perform a search returning this item - Click on the callnumber => Without this patch you get no result, because the search contains CCL words "OR" and "AND" => With this patch you get results Signed-off-by: Liz Rea Tested all with and without queryweightfields - all searches from clicked call numbers for given callnumbers fail without the patch, all are successful with the patch. Signed-off-by: Katrin Fischer Works as described - no problems found. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi commit bf26d347c17907878f31e4d37d9204c96b44f14b Author: Kyle M Hall Date: Fri Aug 15 09:07:07 2014 -0400 Bug 12763 [QA Followup] - Remove tabs and trailing space Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 2aded36d08fab552bab112fcec74247c68d45d22 Author: Marc V?ron Date: Fri Aug 1 20:30:04 2014 +0200 Bug 12763: Add more information for users to OPAC Error 404 page This patch adds more information to the OPAC 404 error page to make it more user friendly. To test: - Apply patch - Is the information clearly understandable and does it contain all necessary information? - Native speakers: Is the text correct? - Non native speakers: Is the text easy to translate? - Is the HTML correct? Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/ILSDI/Services.pm | 30 ++++-------- C4/Reserves.pm | 51 +++++++++++--------- .../prog/en/modules/catalogue/results.tt | 8 +-- .../prog/en/modules/virtualshelves/shelves.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/errors/404.tt | 22 ++++++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 2 +- t/db_dependent/Letters.t | 2 +- t/db_dependent/Reserves.t | 23 ++++++++- 8 files changed, 80 insertions(+), 60 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 19 21:40:46 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 19 Sep 2014 19:40:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-623-g2d4d3d1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2d4d3d1bf511bc277e1f05e34d0857cb98b9924c (commit) from 81b9d8b8aac5c67d01dbac64a1dfa9de880e021d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2d4d3d1bf511bc277e1f05e34d0857cb98b9924c Author: Rafal Kopaczka Date: Fri Sep 19 14:27:04 2014 +0200 Bug 12963: Columns misplaced in moremember.tt After applying Bug 12899, in moremember page, checkouts table has misplaced columns. Test plan: 1. Check out title for a user. Columns in Detail page at checkout tab are misplaced; there's no Due date column. 2. Aplly patch, everything shuld look fine now. Signed-off-by: Owen Leonard My bad! Thanks for catching this. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 06:42:25 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 04:42:25 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-1-g37fae34 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 37fae3408b66d5b94f9fa4f4c2e5c02f360a8041 (commit) from 9ca4fc14fb8504b49b343e9259404e663ec3c71b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 37fae3408b66d5b94f9fa4f4c2e5c02f360a8041 Author: Kyle M Hall Date: Fri Aug 15 12:45:44 2014 -0400 Bug 12371 - Links in every patron self-registration email points to a single borrower If multiple registrations are submitted, the first patron to register will be used for the first patron to click the registration confirmation link! Test Plan: 1) Submit 2 new patron registrations 2) Use the confirm link from the 2nd registration 3) Note you end up registering as the first submitted registration 4) Apply the patch 5) Repeat steps 1 and 2 6) Note you are now confirmed correctly Signed-off-by: Chris Cormack Test plan appears to work fine, I have a feeling the sql could be written better but can't come up with it on a Sunday morning Signed-off-by: Katrin Fischer Works as described and fixes a critical bug. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 06:44:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 04:44:22 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-3-g4d2b807 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 4d2b807967cd4aecff71899850282687aedf2687 (commit) via 3b91d70c1d76826c56925103c36bff3d03d31ea6 (commit) from 37fae3408b66d5b94f9fa4f4c2e5c02f360a8041 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4d2b807967cd4aecff71899850282687aedf2687 Author: Owen Leonard Date: Mon Jun 30 10:12:06 2014 -0400 Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the "Your fines" page. You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 3b91d70c1d76826c56925103c36bff3d03d31ea6 Author: Owen Leonard Date: Fri Jun 27 14:21:03 2014 -0400 Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details -> Fines) and the pay fines page (Patron details -> Fines -> Pay fines). You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/members/boraccount.tt | 20 ++++++++++++------ .../intranet-tmpl/prog/en/modules/members/pay.tt | 20 ++++++++++++------ .../opac-tmpl/bootstrap/en/modules/opac-account.tt | 22 +++++++++++++------- 3 files changed, 43 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 06:47:02 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 04:47:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-4-gb878725 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via b87872564800861585d93e2222db26d8fe224907 (commit) from 4d2b807967cd4aecff71899850282687aedf2687 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b87872564800861585d93e2222db26d8fe224907 Author: Katrin Fischer Date: Sun Jun 22 19:31:50 2014 +0200 Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. Signed-off-by: Bernardo Gonzalez Kriegel Tested, work as described on staff & opac for 710 detailed view. Add space and punctuation. No errors. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 28 +++++++------------- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 23 +++++++--------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 28 +++++++------------- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 23 +++++++--------- 4 files changed, 40 insertions(+), 62 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 06:50:26 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 04:50:26 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-6-g9111275 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 911127588b4c0b71a18f1f474324f302447eba09 (commit) via 273e86c045ad7e34a3eedeee0c5d3328af8a7605 (commit) from b87872564800861585d93e2222db26d8fe224907 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 911127588b4c0b71a18f1f474324f302447eba09 Author: Kyle M Hall Date: Wed Aug 6 17:36:18 2014 -0500 Bug 12432 [QA Followup] - Make "All" tab work when switching back to it Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 273e86c045ad7e34a3eedeee0c5d3328af8a7605 Author: Kyle M Hall Date: Mon Jul 28 10:18:59 2014 -0500 Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Passes all tests and QA script, works as described with the second patch applied as well. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/reports/guided_reports_start.tt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 06:53:03 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 04:53:03 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-7-g1155485 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 11554850c01da530ce338af0d4f5eed30f110791 (commit) from 911127588b4c0b71a18f1f474324f302447eba09 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 11554850c01da530ce338af0d4f5eed30f110791 Author: Fridolin Somers Date: Tue Jun 17 16:38:54 2014 +0200 Bug 12438 - Bad encoding in acquisition basket We noticed a bad encoding (diacritics replaced by ) in acquisition basket when updating a server to Debian Wheezy. We found it comes from a query containing biblio.title twice. Maybe the mysql newer version creates this side-effect. Test plan : - Create an order on a record containing a diacritic in title - Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x => Without the patch the record title is bad encoded (with ) => With this patch the record title is well encoded - Check also basket CSV export Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Good catch! Works as expected, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi Duplicated biblio.title is a (minor) bug, and should be removed. The side-effect of it solving an encoding problem might be seen as problematic: it hides a real problem. The efforts on 11944 actually solve this encoding problem (11944 merged into master actually fixes this), so I'm pushing it, for a short term solution for stable, with the hope that we will soon have 11944 pushed. BTW, non-diacritic but non-ASCII characters are not broken either. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 06:55:23 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 04:55:23 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-8-g6aff3a1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 6aff3a1742ae388f0ea58422637ac9e6b8a939af (commit) from 11554850c01da530ce338af0d4f5eed30f110791 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6aff3a1742ae388f0ea58422637ac9e6b8a939af Author: Jonathan Druart Date: Wed Aug 20 13:26:49 2014 +0200 Bug 12717: Library no longer receiving Overdue email for patrons without email address Bug 10832 changes the fallback behavior if a patron does not have email address: a print notice is generated into the message_queue table. But this can cause issue for some libraries. The script should sent an email and (generated csv, html, text file) with the list of all unsent notices. Test plan: 1/ Add overdue to a patron without email address (or smsalertnumber) 2/ Check email in the overdue rules configuration (or sms) 3/ Launch the overdue_notices.pl cronjob 4/ Verify the message_queue contain a print notice AND an email notice for the library Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer This works as described and restores the old behaviour for now, with the difference that you have a print notice generated and visible in the patron account notices tab that will say 'pending'. We will have to figure out how we can change the workflows nicely to have only one script deal with print notice in the future. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/overdue_notices.pl | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 06:57:37 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 04:57:37 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-9-g9d868b1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 9d868b1626fb15bd244542c41478759a52364b82 (commit) from 6aff3a1742ae388f0ea58422637ac9e6b8a939af (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d868b1626fb15bd244542c41478759a52364b82 Author: Jacek Ablewicz Date: Tue Jul 22 17:57:01 2014 +0200 Bug 12619 - Shipment date gets lost on finishing and/or editing the invoice To reproduce: - Create a new shipment, make sure to add a shipment date - Receive or not receive orders - Finish receiving with the button at the bottom of the page - Verify that shipment date is now empty To test: - reproduce the aforementioned issue - apply patch - confirm that the issue is no longer rerpoductible (= shipment date is not getting lost any longer), and that there are no apparent regresssions of any kind involving invoice shipment date entering and/or editing - sign off Signed-off-by: Aleisha Signed-off-by: Katrin Fischer Passes tests and QA script, fixes the issues, no problems found. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: acqui/invoice.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 07:06:49 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 05:06:49 +0000 Subject: [koha-commits] main Koha release repository branch MM-OPAC/theme_dep updated. v3.16.00-629-g1ba6863 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, MM-OPAC/theme_dep has been updated discards d4e127c0dd802173ef6ef5f3e7c63208e58bca82 (commit) discards c62454a89103e3d4a59a11a2a6aebda92574c31f (commit) discards 9a0b5b28b630340deb39ce0a925546aa8db31b64 (commit) discards 6fb05ea7e6ed2c79ef3c294aa87b3bb0aeee4f41 (commit) discards d6a6f4d4adbf68f84a971eab0625d63eaaa6a9c3 (commit) via 1ba6863ac4883fac8fe84f136a282ef20e662254 (commit) via e4d400d34b0dfc950349c950973952b9121c9752 (commit) via c304159fe80c2f3333ce6cb17fec8bd2fb4b241f (commit) via ae1b048a9c1f77a54a4099da63b717eae60b9099 (commit) via 9ccbe7af97cc53e5cf9d38a44a226b6ef7e17cec (commit) via 2c7c74ded8234e46372a2f44449cc96e34731ed3 (commit) via 2d4d3d1bf511bc277e1f05e34d0857cb98b9924c (commit) via 81b9d8b8aac5c67d01dbac64a1dfa9de880e021d (commit) via 3c1c5c04ceafb411dde1426967cb969a3969f80a (commit) via 45f474abdf935c928b4cd20e9823c96ca82af398 (commit) via 3ce2c0235ca8a1dc0d891e17cac5faeb6bea7caa (commit) via bf26d347c17907878f31e4d37d9204c96b44f14b (commit) via 2aded36d08fab552bab112fcec74247c68d45d22 (commit) via a414f413c82c71ce6d14aa1f416ec6fdf0300f13 (commit) via e2b0454ed43622302aac49b6dae7f3388639269e (commit) via bb78928bef7185ead7156acd1ffc3fb278db2985 (commit) via 5d5481ed1900322eb67029478dd474290255c734 (commit) via 9351cde90f4be04c98a5760e203ba7db40061dfb (commit) via 77e8cf024d4da039356db1e7e1c318d2bf4a77c2 (commit) via 3996fa7b47c519cbb7bd9adf3e76af5fd0d7bb24 (commit) via 781142224cde1df1c7cd08ca45f0d1ac7b763096 (commit) via f10f88266b7af19205bcd210b060dfd656945e53 (commit) via dbe1e920d3fd448fe5490442fb98f4a6599b71ac (commit) via 33d7a28afa927ae190f819ffc98b578dcef4f296 (commit) via a6da517127aeb4c89c204e3a672831e0069ed4ba (commit) via 9d48d31130c554ee889d2ab4ff690fe9915af0ea (commit) via 5af96e0f78d676c202f634e45dff7def31d10c4f (commit) via 2217f98b7cf1da89ed3e4bcc2cc497fe01df724c (commit) via 55e5c82ab593c180e0b73f1cd13bbc71ee7a39c6 (commit) via d15cecacedd58abdafa0b0276a3002af7b266090 (commit) via cd69768f72493d9ec2f2e8015e6f435e9cff18f4 (commit) via eb4df0eff2960772522946bc451803a0af8fb87f (commit) via 84548dcba952e0a32db84ea26d0a3be272e5cec2 (commit) via 788d6bd724abf2573f699a90d0b7857e01264584 (commit) via 6d022bd4a40358d08b3ef3f2a5fd6fdde2f1a336 (commit) via 904b35645cb01de36ff72450decf80c55a80da08 (commit) via d02f87a2986bd20e513e02ab299a9b66af9ea08f (commit) via 17821c58ccbeeb719e283e7932064e6ea61d657e (commit) via 0270b8d3b6a8974fae64340cbfc6228692369d00 (commit) via 555d0d5898faccaf0d8c4c3c39630a23089b57c2 (commit) via b49bcfef092b86d875749ce79501aec77d055515 (commit) via 633f6c150ed26b3a22bdef24bf06fab9273c4eb1 (commit) via 282aa8ffced619b17be398065ed74b3cf44146d3 (commit) via 84b4ace746699318e16f5c7a07023dbb3af55efd (commit) via d8ed9130593d1d83be1674de076f7f2367039d9c (commit) via 7289214e30083ae6addb9137b0480ea5b68b8d71 (commit) via b8fae8489f013d55fac6c660e80bbd7aed31deff (commit) via 09c4417216c32d6af74da193933e95374b0ee7df (commit) via 8a63c17f79d63bcdb669b74b084b83b65295d246 (commit) via 692e0572e1a1f96412ac665d090ccb08cd4b9132 (commit) via 3fa6bf051af4d84d78e6899ea35d18418652b79b (commit) via cc063de044769e047e53d8afc636a22772af1d0e (commit) via 10622af4993045afe6d64c15d9f0d7a4bc4a7fc4 (commit) via 3e78a908f0fb7c904ab478d1c4f8ede4bab3c9ba (commit) via e261343aac9fab0b737962fe740c9f30b0d8d41b (commit) via d968df4743a50d6ae283977e438843340597b7ca (commit) via 8af38d518fe4d3ef9a467b8db15a066c8ef48f9d (commit) via bfb20c9a7e6cfae9fd841a2be5d63d3337b8ddd8 (commit) via c8016e0a0c9efa433d9470f4dc5d209ea1553868 (commit) via d2a51dea68c8f6ba5543e1445c7c219c016b789f (commit) via a2786c6de70701966f53ec9087b79c9ff1185ce0 (commit) via daede131e0f936a2cc15d486127854db7eacfdc4 (commit) via 55ca3c5581de4b794020c8d555f3f472be641b71 (commit) via d036b9a4d16eb1cda7c992ec54b9b36d7c86402d (commit) via 0965dfcc15567216315ce73716abc469c0f27f53 (commit) via d908dad443556a521127fdaea2c1999e12ed1dfe (commit) via 6c34c8b650c1894a7696fc26de72d25ce94f2b5d (commit) via 6405f8b53ff0fb1be38018b5ddba50fa9630bb37 (commit) via b338a40e807dbbb064073d8cc1779a1e7ba8a021 (commit) via f6b770686f9d7c4f3983a821a86597bd1e88e24e (commit) via 6069ed645ff0778fd2ec1003a02e55cb2cdbcf04 (commit) via 6af4da3695c4770e528cfe750da949e3e412658a (commit) via b0e5e2c7494e43662867d4049c1c8ecb1afecc80 (commit) via e86371a0aa3c024d3a60af71ab055c9415efb844 (commit) via 25df10e4d84aee069c795f4d02a73a9fee2da7c8 (commit) via 6f64bb2bd5aef173874b375676ce4858e9c933c5 (commit) via 0950e44fafcd74c868ff2d8f105f500bceac5881 (commit) via efba7b02dda5cd56cee6e1cde718980002605ff1 (commit) via bbdcc4c92754c04f1b070ccf746727a3f0eacb3f (commit) via ead0d88c74bd0efba2d2ca0123c51ff2b6cf25fc (commit) via eefef42abda81e84e42d4a3951684092045886fa (commit) via 62d3a286c16b97c288af54bfd4b64bffbb5f6090 (commit) via abdf7194e2a9bc5e2c497e3d4d241c2e8de40ffc (commit) via a8458630a7aa5209701f224f0d159b604af350f7 (commit) via 36d1b3e29d89c2af04c50d4f9ae91cb18c391f97 (commit) via f5320c4bf873c8fe328d0fdc819fa11f05f346ef (commit) via 33db04fab8ca46168f541bc0d80eb6beced5ef82 (commit) via 77b0dd40988ca2f19ec73eaf821472fe9adf8268 (commit) via 38316529df82ae38dbc59344abb67f817986312c (commit) via e0e66612cc5555ce73d71f486e3f40e0e3414d29 (commit) via 3c1f7dae0aaefdb0041a1b3e030cbb47132f6672 (commit) via 3b092a899fda345c95f875012ba7338f2efc6398 (commit) via e69d6dabc475dfa747d15576f6396e77a7d71c42 (commit) via 9a36f70e35afc3dcdba34678c3b18d960606aa16 (commit) via 51aba41fc30f255948574e9e38d4675558258e03 (commit) via dce2a6362ce5402f7e420f632b0e6f7b60cd5cec (commit) via 500369d807203c9e56cec6489672a38e8ac7b1b2 (commit) via 9e686e023f957e29ba32f84d667014a69f196706 (commit) via db739ee578b8d8134954912e534a9686590f652e (commit) via c6716d3e22244df153f294b351f67da9312c5053 (commit) via c14d91fcd01e2fd240334bdf18444ffa6db6b4a9 (commit) via 27d340959835107941e683a5d6aec64ebca782f2 (commit) via 80086f3ffb08efd333194c83e542ea55b66a87c9 (commit) via 56b4be28258f183eceb4664ad75550b849c809c5 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (d4e127c0dd802173ef6ef5f3e7c63208e58bca82) \ N -- N -- N (1ba6863ac4883fac8fe84f136a282ef20e662254) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1ba6863ac4883fac8fe84f136a282ef20e662254 Author: Robin Sheat Date: Fri Jul 25 16:09:49 2014 +1200 Bug 12657 - remove references to prog and ccsr from the packages To test: * Build a package and install it, and verify that there are no errors. * Play around with koha-translate, listing, adding, and removing languages. Note: one reference to prog and ccsr remains in koha-translate. This is to allow it to remove any pre-existing translations on an upgrade. Note 2: prog translations are still being installed, I think this is due to the underlying translation system doing it. Signed-off-by: Brendan Gallagher Signed-off-by: Chris Cormack commit e4d400d34b0dfc950349c950973952b9121c9752 Author: Bernardo Gonzalez Kriegel Date: Sun Aug 3 09:41:37 2014 -0300 Bug 12539: Follow up to fix fallback theme The is a problem in the logic, fallback must be: 1. Requested (theme, lang, tmpl) a. return (theme, lang, tmpl), if not b. return (fallback, lang, tmpl), if not c. return (theme, 'en', tmpl), if not as last resort d. return (fallback, 'en', tmpl) Previous patch missed option 'c', worked for CCSR but not bootstrap, sorry. Signed-off-by: Petter Goksoyr Asen Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack commit c304159fe80c2f3333ce6cb17fec8bd2fb4b241f Author: Bernardo Gonzalez Kriegel Date: Mon Jul 7 15:30:02 2014 -0300 Bug 12539: PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm This patch removes hardcoded 'prog' from themelanguage on C4/Templates.pm It adds a new syspref OPACFallback to hold the prefferred fallback theme for new themes with minimal changes. This does not brake CCSR if new syspref value is 'prog', using 'bootstrap' works somehow, but with strange results. To test: 1) Apply the patch 2) Run updatedatbase.pl 3) CCSR, prog & bootstrap must work as usual 4) Need to test theme/language fallback a) translate for your preferred language (xx-YY) b) enable language on opac c) go to opac, select that language d) login on opac, go to personal details e) remove koha-tmpl/opac-tmpl/bootstrap/xx-YY/modules/opac-memberentry.tt d) reload page, must load in English f) click other member options, must load on translated language (can use other pages, ccsr, prog or bootstrap) 5) Do a similar test but for a staff page, enable lang, switch to it, rm koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/admin-home.tt, any page must be translated except for admin home. Signed-off-by: Chris Cormack Signed-off-by: Petter Goksoyr Asen Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack commit ae1b048a9c1f77a54a4099da63b717eae60b9099 Author: Owen Leonard Date: Tue Jul 1 11:42:30 2014 -0400 Bug 12245 - PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference With CCSR now deprecated there is no longer a need for the OPACMobileUserCSS system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack commit 9ccbe7af97cc53e5cf9d38a44a226b6ef7e17cec Author: Owen Leonard Date: Tue Jul 1 11:56:28 2014 -0400 Bug 12246 - PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference With CCSR having been deprecated there is no longer a use for the OpacMainUserBlockMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack commit 2c7c74ded8234e46372a2f44449cc96e34731ed3 Author: Owen Leonard Date: Tue Jul 1 12:18:12 2014 -0400 Bug 12513 - PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference With CCSR having been deprecated there is no longer a use for the OpacShowLibrariesPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 58 +++++--- C4/Breeding.pm | 2 +- C4/Budgets.pm | 14 +- C4/Circulation.pm | 69 ++++----- C4/ILSDI/Services.pm | 30 ++-- C4/Items.pm | 10 +- C4/Ratings.pm | 91 +++++++----- C4/Reserves.pm | 116 ++++++++++------ C4/Search.pm | 132 ++++++++++++------ C4/Utils/DataTables/Members.pm | 9 ++ Koha/Schema/Result/Issue.pm | 12 +- Koha/Schema/Result/Issuingrule.pm | 12 +- Koha/Schema/Result/OldIssue.pm | 12 +- about.pl | 1 + acqui/addorder.pl | 2 +- acqui/addorderiso2709.pl | 2 +- admin/aqbudgetperiods.pl | 4 + admin/checkmarc.pl | 15 ++ admin/smart-rules.pl | 9 +- catalogue/search.pl | 2 + circ/circulation.pl | 7 +- circ/renew.pl | 2 +- debian/build-git-snapshot | 2 +- debian/control | 6 +- debian/control.in | 2 +- debian/koha-common.cron.daily | 1 + debian/rules | 51 ------- debian/scripts/koha-translate | 15 +- .../mysql/de-DE/optional/sample_z3950_servers.sql | 6 + .../mysql/en/optional/sample_z3950_servers.sql | 6 + .../mysql/es-ES/optional/sample_z3950_servers.sql | 6 + installer/data/mysql/kohastructure.sql | 3 + .../data/mysql/nb-NO/2-Valgfritt/z3950servers.sql | 6 + installer/data/mysql/sysprefs.sql | 5 + installer/data/mysql/updatedatabase.pl | 73 +++++++++- .../prog/en/includes/checkouts-table-footer.inc | 2 +- .../intranet-tmpl/prog/en/includes/strings.inc | 2 + koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 30 +++- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 13 +- .../prog/en/modules/acqui/z3950_search.tt | 12 ++ .../prog/en/modules/admin/aqbudgetperiods.tt | 8 ++ .../prog/en/modules/admin/checkmarc.tt | 34 +++++ .../en/modules/admin/preferences/acquisitions.pref | 3 + .../en/modules/admin/preferences/circulation.pref | 15 +- .../prog/en/modules/admin/preferences/opac.pref | 5 +- .../prog/en/modules/admin/smart-rules.tt | 14 ++ .../prog/en/modules/admin/z3950servers.tt | 4 +- .../prog/en/modules/catalogue/results.tt | 13 +- .../prog/en/modules/cataloguing/z3950_search.tt | 2 +- .../prog/en/modules/circ/circulation.tt | 12 +- .../intranet-tmpl/prog/en/modules/circ/renew.tt | 24 ++++ .../intranet-tmpl/prog/en/modules/help/about.tt | 3 +- .../prog/en/modules/help/admin/z3950servers.tt | 53 ++++--- .../prog/en/modules/members/memberentrygen.tt | 2 +- .../prog/en/modules/members/members-update.tt | 1 + .../prog/en/modules/members/moremember.tt | 5 +- .../prog/en/modules/reports/bor_issues_top.tt | 42 +++++- .../en/modules/reports/guided_reports_start.tt | 2 + .../prog/en/modules/reports/reports-home.tt | 2 +- .../prog/en/modules/reserve/request.tt | 2 +- .../prog/en/modules/virtualshelves/shelves.tt | 2 +- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 21 ++- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- .../opac-tmpl/bootstrap/en/modules/errors/404.tt | 22 ++- koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 2 +- .../bootstrap/en/modules/opac-advsearch.tt | 18 +-- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 10 +- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 16 +-- .../bootstrap/en/modules/opac-results-grouped.tt | 6 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 3 + .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 18 ++- koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 24 ++++ koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 12 +- .../prog/en/modules/opac-results-grouped.tt | 6 +- .../opac-tmpl/prog/en/modules/opac-results.tt | 4 +- kohaversion.pl | 2 +- misc/cronjobs/automatic_renewals.pl | 60 ++++++++ misc/cronjobs/crontab.example | 3 + opac/opac-search.pl | 20 +++ opac/opac-sendshelf.pl | 4 - opac/opac-user.pl | 6 +- reports/bor_issues_top.pl | 2 +- svc/checkouts | 2 + svc/members/search | 14 +- t/db_dependent/Acquisition.t | 47 +------ t/db_dependent/Acquisition/CancelReceipt.t | 30 ++-- .../Acquisition/GetBasketsInfosByBookseller.t | 4 +- .../Acquisition/GetOrdersByBiblionumber.t | 6 +- t/db_dependent/Acquisition/Invoices.t | 6 +- t/db_dependent/Acquisition/NewOrder.t | 86 ++++++++++++ t/db_dependent/Acquisition/OrderFromSubscription.t | 2 +- t/db_dependent/Acquisition/TransferOrder.t | 2 +- t/db_dependent/Acquisition/close_reopen_basket.t | 4 +- t/db_dependent/Bookseller.t | 35 +++-- t/db_dependent/Breeding.t | 15 +- t/db_dependent/Budgets.t | 10 +- t/db_dependent/Circulation.t | 42 +++++- t/db_dependent/Circulation_Issuingrule.t | 9 +- t/db_dependent/Holds.t | 50 ++++++- t/db_dependent/Letters.t | 2 +- t/db_dependent/Ratings.t | 146 ++++++++++++-------- t/db_dependent/Reserves.t | 23 ++- t/db_dependent/Search.t | 80 ++++++++++- t/{ => db_dependent}/Templates.t | 2 +- t/db_dependent/Utils/Datatables_Members.t | 53 +++++-- tools/import_borrowers.pl | 3 + 107 files changed, 1478 insertions(+), 560 deletions(-) create mode 100644 misc/cronjobs/automatic_renewals.pl create mode 100644 t/db_dependent/Acquisition/NewOrder.t rename t/{ => db_dependent}/Templates.t (97%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 20:47:24 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 18:47:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-630-g6246f2c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6246f2c70049baf86bc942c2473793c83057a64f (commit) via b2839a7c9c8554097bd36de0ad439967e2035c5c (commit) via 3f2dda2f3380b341bd9575d5626cdb9ac8889191 (commit) via b04f5ba8a0071609f756e96c50b0cad19780f3e2 (commit) via 04857ed68eff319f4b7b42508aeee8a240bde995 (commit) via 2bd151fab5c673a35ce06e511ae1f4b97513539f (commit) via 70c0b8280bdaf9901eadb93133a52c891fbbd0d7 (commit) from 2d4d3d1bf511bc277e1f05e34d0857cb98b9924c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6246f2c70049baf86bc942c2473793c83057a64f Author: Marc V?ron Date: Fri Jul 25 23:57:54 2014 +0200 Bug 12162 - Add class="branchcode" to body tag to make OPAC CSS-styleable per branch This patch adds a branch sepecific class to all OPAC pages. Example: If not logged in, opac-main.pl displays: If logged in at branch FFL, it displays: If you log in, opac-user.pl should display To test: 1) Apply patch. 2) Add to syspref OPACUserCSS something highly visible, e.g. for branch FFL: .branch-FFL { background-color: yellow; border: 10px solid red; } 3) Go to OPAC and login in with a user with home branch FFL 4) Verify that colors change as appropriate. 5) Log out. Verify that colors display as before or as defined in class branch-default in OPACUserCSS 6) Display patch in patch diff view, verify that ids and classes in body tag are consistent with params bodyid and bodyclass in INCLUDE line 7) Search for regressions Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit b2839a7c9c8554097bd36de0ad439967e2035c5c Author: Tomas Cohen Arazi Date: Wed Aug 27 10:11:28 2014 -0300 Bug 11672: (followup) warnings tested Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 3f2dda2f3380b341bd9575d5626cdb9ac8889191 Author: Tomas Cohen Arazi Date: Sun Aug 24 02:11:50 2014 -0300 Bug 11672: Untranslatable dropdown on Guided Reports and dictionary This patch removes hardcoded descriptions and sets them in the templates using the variable content as id. To test, create a new guided report and verify the 'module to report on' dropdown shows as usual [1]. Functionality shouldn't get changed. The patch also changes the dictionary pages where 'area' should be displayed/selectable with the same strings as the guided reports. Try all the possible disctionary pages. The last page when creating a dictionary now shows the 'area description' instead of the code. The same happens to the dictionary list once you have dictionaries saved. [1] The following texts get changed: Catalogue -> Catalog Acquisition -> Acquisitions Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit b04f5ba8a0071609f756e96c50b0cad19780f3e2 Author: Tomas Cohen Arazi Date: Sun Aug 24 02:21:52 2014 -0300 Bug 11672: (regression test) get_report_areas gets tested This patch introduces a unit test for the new get_report_areas functionality. To try it, run $ prove t/db_dependent/Reports_Guided.t It is expected to have 16 tests defined, and to fail the introduced one Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 04857ed68eff319f4b7b42508aeee8a240bde995 Author: Colin Campbell Date: Thu Apr 17 16:07:20 2014 +0100 Bug 11633 Return Correct status if patron blocked by fines If the patron has amassed charges that block borrowing, but we allow staff override the information that the patron cannot issue should be included the patron information response This patch sets the appropriate status fields in the patron object It restores the fee_limit member to the patron object and calls a local subroutine to set it. This could be done more elegantly but that would require more major refactoring of the rather messy initializer code in ILS::Patron Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 2bd151fab5c673a35ce06e511ae1f4b97513539f Author: Colin Campbell Date: Thu Apr 17 15:55:03 2014 +0100 Bug 11633 : Block Issue if fines require staff override If a patrons fines exceed noissuescharge and we allow staff to allow issue at their discretion via an override the SIP process allowed charges to go ahead. This patch closes the loophole which allowed self issue to subvert the usual library loan policy Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 70c0b8280bdaf9901eadb93133a52c891fbbd0d7 Author: Jonathan Druart Date: Thu Sep 11 15:22:44 2014 +0200 Bug 7372: (follow-up) does execute this DB entry twice Since this enh has been backported on 3.14, this patch should be applied on 3.16 and master branch in order to update the updatedb entry. It should not be executed twice otherwise the process is stuck on this entry. http://irc.koha-community.org/koha/2014-09-11#i_1567078 Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 6 +- C4/SIP/ILS/Patron.pm | 18 +-- C4/SIP/ILS/Transaction/Checkout.pm | 4 +- installer/data/mysql/updatedatabase.pl | 43 ++++--- .../prog/en/modules/reports/dictionary.tt | 129 +++++++++++--------- .../en/modules/reports/guided_reports_start.tt | 25 +++- .../opac-tmpl/bootstrap/en/includes/bodytag.inc | 15 +++ .../bootstrap/en/modules/opac-ISBDdetail.tt | 4 +- .../bootstrap/en/modules/opac-MARCdetail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-account.tt | 1 + .../bootstrap/en/modules/opac-addbybiblionumber.tt | 4 +- .../bootstrap/en/modules/opac-advsearch.tt | 2 +- .../bootstrap/en/modules/opac-alert-subscribe.tt | 4 +- .../bootstrap/en/modules/opac-auth-MARCdetail.tt | 4 +- .../bootstrap/en/modules/opac-auth-detail.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 2 +- .../bootstrap/en/modules/opac-authorities-home.tt | 4 +- .../en/modules/opac-authoritiessearchresultlist.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-blocked.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-browser.tt | 4 +- .../bootstrap/en/modules/opac-course-details.tt | 4 +- .../bootstrap/en/modules/opac-course-reserves.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../bootstrap/en/modules/opac-downloadcart.tt | 2 +- .../bootstrap/en/modules/opac-downloadshelf.tt | 4 +- .../en/modules/opac-full-serial-issues.tt | 4 +- .../bootstrap/en/modules/opac-imageviewer.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +- .../modules/opac-memberentry-update-submitted.tt | 2 +- .../bootstrap/en/modules/opac-memberentry.tt | 2 +- .../bootstrap/en/modules/opac-messaging.tt | 2 +- .../bootstrap/en/modules/opac-overdrive-search.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- .../bootstrap/en/modules/opac-readingrecord.tt | 2 +- .../en/modules/opac-registration-confirmation.tt | 4 +- .../en/modules/opac-registration-email-sent.tt | 4 +- .../en/modules/opac-registration-invalid.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +- .../bootstrap/en/modules/opac-search-history.tt | 2 +- .../bootstrap/en/modules/opac-sendbasketform.tt | 2 +- .../bootstrap/en/modules/opac-sendshelfform.tt | 2 +- .../bootstrap/en/modules/opac-serial-issues.tt | 2 +- .../bootstrap/en/modules/opac-shareshelf.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- .../bootstrap/en/modules/opac-showmarc.tt | 2 +- .../bootstrap/en/modules/opac-showreviews.tt | 4 +- .../bootstrap/en/modules/opac-suggestions.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-tags.tt | 2 +- .../bootstrap/en/modules/opac-tags_subject.tt | 2 +- .../bootstrap/en/modules/opac-topissues.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- reports/dictionary.pl | 17 +-- reports/guided_reports.pl | 7 +- t/db_dependent/Reports_Guided.t | 32 +++-- 59 files changed, 250 insertions(+), 175 deletions(-) create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/includes/bodytag.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:21:07 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:21:07 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-10-gd4c09d6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via d4c09d6db48a10f71324696b60c2bc56bb4227a9 (commit) from 9d868b1626fb15bd244542c41478759a52364b82 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d4c09d6db48a10f71324696b60c2bc56bb4227a9 Author: Tomas Cohen Arazi Date: Thu Jul 3 13:58:30 2014 -0300 Bug 11703: (followup) svc/holds invoked with trailing .pl On my followup I forgot to fix js/holds.js. This patch rectifies that. Regards To+ Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/holds.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:26:07 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:26:07 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-13-g724a685 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 724a68540c4fdf634becae7e26094d03dfcf963b (commit) via c07a3d0d3bc7a581c88a40a8c2f3da67250b3261 (commit) via 17c0c5f9a507d0b34d98e66540f40ebc9de42845 (commit) from d4c09d6db48a10f71324696b60c2bc56bb4227a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 724a68540c4fdf634becae7e26094d03dfcf963b Author: Tomas Cohen Arazi Date: Mon Jul 14 16:29:38 2014 -0300 Bug 10519: (followup) unit tests leave problematic cruft On testing I've found that t/db_dependent/Suggestions.t leaves cruft on the DB. Small followup for that. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit c07a3d0d3bc7a581c88a40a8c2f3da67250b3261 Author: Jacek Ablewicz Date: Fri Jun 13 21:27:38 2014 +0200 Bug 10519: (followup) Fix context for evalyating $borrowernumber Follow-up to fix additional suggestion statuses, which are not working properly due to 416: borrowernumber => $input->param('borrowernumber'), being evaluated in list context inside $template->param() call arguments. Signed-off-by: Christopher Brannon Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 17c0c5f9a507d0b34d98e66540f40ebc9de42845 Author: Jacek Ablewicz Date: Wed Jun 11 08:51:34 2014 +0200 Bug 10519: Suggestions: 'Organize by' and correct display of tab descriptions broken The tabbed display in suggestions offers different options to organize the tabs. The descriptions on the tabs and some of the search options were not working correctly, displaying as "Unknown". To test: - Add several suggestions to your installation, make sure you have: - suggestions from different users - suggestions managed by different users - suggestions with different statuses - suggestions with different selected item types Test all the 'organize by' options (except "Organize by: Library" - see note below), make sure that the tabs and search options have correct descriptions and do no longer display as "Unknown". - Add 1 or 2 custom status to SUGGEST_STATUS authorized value. - Verify display is still correct and your new status are displayed. Note: "Organize by: Library" option is currently severely broken (and not easily fixable, especially for 'IndependentBranches' enabled). But this turns out to be a separate issue, with a different underlaying causes, and it's outside the scope of this patch. This should be dealt with later, in it's own bug report. Signed-off-by: Christopher Brannon Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: suggestion/suggestion.pl | 11 +++++++---- t/db_dependent/Suggestions.t | 38 ++++++++++++++++++++++++++++++-------- 2 files changed, 37 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:28:14 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:28:14 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-14-g362c42e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 362c42e91836409d4051fbc9f618b35e2a423831 (commit) from 724a68540c4fdf634becae7e26094d03dfcf963b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 362c42e91836409d4051fbc9f618b35e2a423831 Author: Dobrica Pavlinusic Date: Thu Sep 4 15:16:57 2014 +0200 Bug 12729 - Overdue items won't show as overdue in red in circulation It seems that Firefox date parser doesn't like our dates which are formatted in ISO format like "2014-08-06 00:00:00". This results in missing red color in overdue dates. So intead of munching different date formats and JavaScript (and having to support different browers) this patch moves check for overdue dates back to mysql and just transfers boolean value to JavaScript so it can show correct class for date_due. Test scenario: 1. find borrower with overdue checkouts 2. verify that all dates are black (and are in ISO format) 3. apply this patch 4. reload page and verify that overdue dates turned red Signed-off-by: Katrin Fischer Tested with different due dates (hourly and not) and different date formats. Passes tests and QA script. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 4 +--- svc/checkouts | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:30:11 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:30:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-15-gbab0e73 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via bab0e735885155b8466ff65febbaf3cc49320f73 (commit) from 362c42e91836409d4051fbc9f618b35e2a423831 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bab0e735885155b8466ff65febbaf3cc49320f73 Author: Owen Leonard Date: Wed Sep 10 08:56:24 2014 -0400 Bug 12899: Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/checkouts-table-footer.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 12 +++++++++++- .../intranet-tmpl/prog/en/modules/circ/circulation.tt | 1 + 3 files changed, 13 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:31:22 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:31:22 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-16-gb4d0863 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via b4d0863fbcd06d64c4c6b75d5f6100a5e7ea2618 (commit) from bab0e735885155b8466ff65febbaf3cc49320f73 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b4d0863fbcd06d64c4c6b75d5f6100a5e7ea2618 Author: Rafal Kopaczka Date: Fri Sep 19 14:27:04 2014 +0200 Bug 12963: Columns misplaced in moremember.tt After applying Bug 12899, in moremember page, checkouts table has misplaced columns. Test plan: 1. Check out title for a user. Columns in Detail page at checkout tab are misplaced; there's no Due date column. 2. Aplly patch, everything shuld look fine now. Signed-off-by: Owen Leonard My bad! Thanks for catching this. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:33:52 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:33:52 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-17-g973c6bb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 973c6bbf0101f3861c109900388b7708c5728621 (commit) from b4d0863fbcd06d64c4c6b75d5f6100a5e7ea2618 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 973c6bbf0101f3861c109900388b7708c5728621 Author: Jacek Ablewicz Date: Sat Aug 23 16:36:21 2014 +0200 Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions In case when the staff user doesn't have (circulate) -> (override_renewals) permission granted, this code part var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; in circ/circulation.tt and members/moremember.tt leads to javascript error, because TT statement evaluates to empty string. To reproduce: - set AllowRenewalLimitOverride syspref to "Don't allow" (this step is possibly redundant / not quite relevant), - for testing purposes, log in as some (sample) staff user whitch does not have permission granted for "(override_renewals) Override blocked renewals", - have a look at some patron accounts (preferably, ones with 1+ check-out), observe that page layout is incorrect in "Check Out" and "Details" tab. To test: - apply patch, - retest and ensure that this issue is no longer reproductible, - make sure that there are no regressions of any kinds regarding renewal override permission for staff users (i.e, that it still works like intended). Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described, passes QA script and tests. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:44:23 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:44:23 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-19-gfdb55ce Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via fdb55ce2fc9d5cc87405f9584714b5cfdab7737b (commit) via 4dab17e93626c47988bf24f62b79e4cc8b391e28 (commit) from 973c6bbf0101f3861c109900388b7708c5728621 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdb55ce2fc9d5cc87405f9584714b5cfdab7737b Author: Tomas Cohen Arazi Date: Mon Jun 30 14:55:04 2014 -0300 Bug 12419: (QA followup) regression tests Changes to searchResults deserve unit tests. Edit: minor tweaks: - Remove warning in line 702 - Modernize - License added - "This file is a stub" removed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 4dab17e93626c47988bf24f62b79e4cc8b391e28 Author: Jonathan Druart Date: Fri Jun 13 15:27:45 2014 +0200 Bug 12419: Not for loan items are not listed On the cataloguing search (cataloguing/addbook.pl), if an item has a notforloan value > 0, the item is not listed in the Location column. It is quite confusing, the current behavior let patrons believe that there is not item for the biblio (or less than the real count). Test plan: 1/ Create 2 biblio records A and B 2/ Create some items for A 3/ Create 1+ item(s) for B with a notforloan status > 0 4/ Reindex both records 5/ Launch a search on the cataloguing module and verify that the notforloan items are not listed in the 'Location' column. 6/ Apply this patch and verify the not for loan items are listed ("Not for loan (XXX)"). Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer Passes tests and QA script, not for loan items now show up. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 4 +++ .../prog/en/modules/cataloguing/addbooks.tt | 3 +- t/db_dependent/Search.t | 32 +++++++++++++++----- .../large_biblio_dom/exported_records.xml | 12 ++++++++ .../large_biblio_grs1/exported_records.xml | 12 ++++++++ 5 files changed, 55 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 22:55:07 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 20:55:07 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-28-g31f808c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 31f808cb49e13b75b4137b3adb681135f8a1e51f (commit) via 9f2c4b78261b2be1d4a09dd9dfcf0eef75acb308 (commit) via 5502447d41d93d91bfc9a20201f3049cd9f1642e (commit) via 533d6ed35c4dfa872edaf690fcb8ae05cf017358 (commit) via 7f6f09da96002fbd5bd4a7cbecc532b28647ff27 (commit) via a67bce36b0c1eb79bb7fcd45ec6a7ec8e873522c (commit) via 92b0d001da517f858e8d78fc6b6b335744f2c866 (commit) via 0a1c90084e9978c8f51c7d58d3383fd44ab2a8ef (commit) via 8d21dd98af08a76218fa374323e7a9eda7267274 (commit) from fdb55ce2fc9d5cc87405f9584714b5cfdab7737b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31f808cb49e13b75b4137b3adb681135f8a1e51f Author: Tomas Cohen Arazi Date: Wed Aug 20 11:39:27 2014 -0300 Bug 12788: (followup) minor optimization with proper tests This patch removes the $facets_info calculation from the _get_facets_data_from_record sub so it is not done for each record. It introduces a new sub, _get_facets_info that is called from the getRecords loop, that does the job only once. To test: - Apply on top of the previous patches - Run $ prove -v t/db_dependent/Search.t => SUCCESS: _get_facets_info gets tested and it passes for both MARC21 and UNIMARC. Facets rendering should remain unchaged on the UI. - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Nick Clemens Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 9f2c4b78261b2be1d4a09dd9dfcf0eef75acb308 Author: Tomas Cohen Arazi Date: Wed Aug 20 00:48:07 2014 -0300 Bug 12788: facets calculation should skip 100 if ind1=z This patch adds a test for field 100, to skip it on facet calculation if ind1=z. To test: - Have IncludeSeeFromInSearches set. - Create a biblio record, when adding an author, create a new authority record that contains a 400$a field (see from). - Rebuild zebra db. - Search for the record making sure the search returns more than one record. => FAIL: the facets contain the 'see from' field. - Run $ prove -v t/db_dependent/Search.t => FAIL: it fails - Apply the patch - Run $ prove -v t/db_dependent/Search.t => SUCCESS: it passes - Re-run the search, notice the 'see from' doesn't show anymore on the facets. - Sign off :-D Edit: minor stylistic change Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Nick Clemens Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 5502447d41d93d91bfc9a20201f3049cd9f1642e Author: Tomas Cohen Arazi Date: Wed Aug 20 00:33:40 2014 -0300 Bub 12788: (regression test) refactor facet extraction code to allow testing This patch refactors the facet extraction loop into a proper function. The loop is changed so the MARC::Record objects are created only once instead of the old/current behaviour: once for each defined facet (in C4::Koha::getFacets). To test: - Apply the patch => SUCCESS: verify facets functionality remains unchanged. - Run: $ prove -v t/db_dependent/Search.t => SUCCESS: tests for _get_facets_data_from_record fail, because 100$a is considered for fields with indicator 1=z (field added by IncludeSeeFromInSearches syspref). - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Nick Clemens Signed-off-by: David Cook Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 533d6ed35c4dfa872edaf690fcb8ae05cf017358 Author: Colin Campbell Date: Fri Jul 18 09:50:34 2014 +0100 Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel Search still works, no errors. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 7f6f09da96002fbd5bd4a7cbecc532b28647ff27 Author: Dobrica Pavlinusic Date: Thu Jul 17 12:27:55 2014 +0200 Bug 12593: search facets die with regex error if biblio has square brackets in fields It's quite common to have [something] within facet data, and it produces following error: Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE This problem was intoduced in Bug 12151 but is trivial to fix. Signed-off-by: Tomas Cohen Arazi Good catch. To test: - Created a bibliographic record, linked to an authority record (personal name). Did a search that returned the author as a facet. - Added a [ symbol to the author name. - Repeated the search => FAIL: "Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE" - Apply the patch - Retry the search => SUCCESS: No error, bracket shows correctly. Passes koha-qa.pl too. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit a67bce36b0c1eb79bb7fcd45ec6a7ec8e873522c Author: Tomas Cohen Arazi Date: Mon Jun 2 11:14:11 2014 -0300 Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm Just that. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes QA script and tests. Could only verify by reading the code. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 92b0d001da517f858e8d78fc6b6b335744f2c866 Author: Tomas Cohen Arazi Date: Mon Jun 2 11:30:48 2014 -0300 Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl The '~~' smartmatch operator is used to compare MARC::Field->subfield(code) (i.e. a string) and the text element of each MARC::Field->subfields() which is also plain text. Substituting '~~' for 'eq' should be harmless then. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes QA script and tests. Tested batch modification of items, no problems found. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 0a1c90084e9978c8f51c7d58d3383fd44ab2a8ef Author: Tomas Cohen Arazi Date: Sat May 31 00:30:32 2014 -0300 Bug 12151: Remove uses of smartmatch operator in report scripts This patch removes the use of smartmatch operators in report scripts. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes QA script and tests. Acquisition and Patron statistics wizard tested, no regressions found. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton commit 8d21dd98af08a76218fa374323e7a9eda7267274 Author: Tomas Cohen Arazi Date: Fri May 30 20:54:10 2014 -0300 Bug 12151: Remove uses of smartmatch operator in Search.pm and opac-search.pl This patch removes the use of smartmatch operators in the search code. Regards To+ Edit: this revision uses 'grep' instead of Lists::MoreUtils::any Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Tested search, no problems found. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 137 +++++++++++++++++++++----------- Koha/SearchEngine/Solr/QueryBuilder.pm | 16 ++-- opac/opac-search.pl | 15 ++-- reports/acquisitions_stats.pl | 101 ++++++++++++----------- reports/borrowers_stats.pl | 60 +++++++------- t/db_dependent/Search.t | 80 ++++++++++++++++++- tools/batchMod.pl | 2 +- 7 files changed, 262 insertions(+), 149 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 23:00:45 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 21:00:45 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-29-g05ace0b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 05ace0b38085a11fbdd7c031a8a251243544b564 (commit) from 31f808cb49e13b75b4137b3adb681135f8a1e51f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 05ace0b38085a11fbdd7c031a8a251243544b564 Author: Fridolin Somers Date: Wed Jun 11 12:25:19 2014 +0200 Bug 12405 - Search links on callnumber fails on intranet results page On intranet results page, the callnumber of items is a search like : /cgi-bin/koha/catalogue/search.pl?idx=callnum&q=[% result.itemcallnumber |url %] The callnumber should be URI-escaped to avoid special URI characters like & , ? ... If the callnumber contains some CCL words or parenthesis, the search will fail, it should be wrapped with double-quotes. This patch adds this to catalogue/results.pl and catalogue/shelves.pl : - uri TT filter instead of url - adds double-quotes using there URI code %22 since its in a HTML attribute using double-quotes Test plan : - Edit an item callnumber with : & ABC 123 - Index zebraqueue - Perform a search returning this item - Click on the callnumber => Without this patch you get no result, because URL parameters are : idx=callnum&q=& ABC 123 => With this patch you get results - Set syspref QueryWeightFields off (because this is no bug if on) - Edit an item callnumber with : AB(C) AND OR - Index zebraqueue - Perform a search returning this item - Click on the callnumber => Without this patch you get no result, because the search contains CCL words "OR" and "AND" => With this patch you get results Signed-off-by: Liz Rea Tested all with and without queryweightfields - all searches from clicked call numbers for given callnumbers fail without the patch, all are successful with the patch. Signed-off-by: Katrin Fischer Works as described - no problems found. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 8 ++++---- .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 23 23:02:51 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Sep 2014 21:02:51 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-30-g6d9e0af Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 6d9e0af198389f1d0e07d251c3468a80165a6f90 (commit) from 05ace0b38085a11fbdd7c031a8a251243544b564 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6d9e0af198389f1d0e07d251c3468a80165a6f90 Author: Robin Sheat Date: Fri Jun 27 14:48:55 2014 +1200 Bug 12492 [3.16.x] - dependency changes special handling Adds some dependencies manually, so that they aren't required at the moment, but will end up required when the control file is next regenerated. Signed-off-by: Galen Charlton ----------------------------------------------------------------------- Summary of changes: debian/control | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 24 02:27:31 2014 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Sep 2014 00:27:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.16.00-636-g755655a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 755655a42a2621c86fe3d171564401fd929c28cd (commit) via 1b5c0966bbb600b6927fa04edcb1691a794f38f6 (commit) via 171b4e24b30ddceb04e45fb51c4adb6f921217a2 (commit) via 9daef6fb5323c9a899da5241cfc0bf62ba4cb212 (commit) via e9eef04b95e7cb0dadda862f07c0d34a31f5eb6a (commit) via 6a98db50fc56be0d611170507c2ced445b894970 (commit) from 6246f2c70049baf86bc942c2473793c83057a64f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 755655a42a2621c86fe3d171564401fd929c28cd Author: Owen Leonard Date: Wed Sep 17 08:31:27 2014 -0400 Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 1b5c0966bbb600b6927fa04edcb1691a794f38f6 Author: Jonathan Druart Date: Wed Sep 17 13:11:00 2014 +0200 Bug 12937: Deleting suggestions should ask for a confirmation On the suggestion management page, the librarian can choose to delete suggestions but no confirmation is needed. This could produce unexpected lost of data. Test plan: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 171b4e24b30ddceb04e45fb51c4adb6f921217a2 Author: Tomas Cohen Arazi Date: Tue Sep 23 21:07:08 2014 -0300 Bug 12876: (followup) remove useless diags Signed-off-by: Tomas Cohen Arazi commit 9daef6fb5323c9a899da5241cfc0bf62ba4cb212 Author: Jonathan Druart Date: Fri Sep 5 17:40:05 2014 +0200 Bug 12876: Improve unit tests for CanReserveBeCanceledFromOpac This patch fix the subroutine name and add a restriction on the arguments: both argument are mandatory! Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit e9eef04b95e7cb0dadda862f07c0d34a31f5eb6a Author: Rafal Kopaczka Date: Fri Sep 5 14:50:15 2014 +0200 Bug 12876 - Reserve in waiting/transfer status may be cancelled by user User may cancel his own reservation at waiting or in transit status through calling opac-modrequest.pl. Cancel button is disabled in interface but possibility to cancel should be checked also in opac-moderequest.pl, before calling CancelReserve(). Similar situation is with opac-modrequest-suspend.pl This patch provides new soubroutine to chceck if user can cancel given reserve. It's possible only when he's owner of hold and hold isn't in transfer or waiting status. Additionaly there are new test for this function in Reserves.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Passes all tests, QA script and new tests. Works as described, tested with: .../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX Signed-off-by: Tomas Cohen Arazi commit 6a98db50fc56be0d611170507c2ced445b894970 Author: Rafal Kopaczka Date: Thu Sep 4 16:40:33 2014 +0200 Bug 12873 - Reserve can be cancelled by any logged in user It is possible to cancel reservations through simply running opac-modreserve.pl with existing reserve_id number. This may provide remove even all reservations from system. The only limitation is that user have to be logged in. Simplest solution is to check whether reserve belongs to user or not. Test plan: 1. Create reserves by 2 different users, and get their ID's 2. Before patch, hold may by cancelled by anyone who run site: http://example.com/cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX 3. After patch hold may by cancelled only by user whose reserve is. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 25 ++++++++ .../prog/en/modules/suggestion/suggestion.tt | 26 +++++++- opac/opac-modrequest-suspend.pl | 2 +- opac/opac-modrequest.pl | 2 +- t/db_dependent/Reserves.t | 67 ++++++++++++++++++-- 5 files changed, 114 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository