[koha-commits] main Koha release repository branch master updated. v3.16.00-550-gead0d88

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ead0d88c74bd0efba2d2ca0123c51ff2b6cf25fc (commit)
       via  eefef42abda81e84e42d4a3951684092045886fa (commit)
       via  62d3a286c16b97c288af54bfd4b64bffbb5f6090 (commit)
      from  abdf7194e2a9bc5e2c497e3d4d241c2e8de40ffc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ead0d88c74bd0efba2d2ca0123c51ff2b6cf25fc
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Aug 20 11:39:27 2014 -0300

    Bug 12788: (followup) minor optimization with proper tests
    
    This patch removes the $facets_info calculation from the _get_facets_data_from_record
    sub so it is not done for each record. It introduces a new sub, _get_facets_info
    that is called from the getRecords loop, that does the job only once.
    
    To test:
    - Apply on top of the previous patches
    - Run
      $ prove -v t/db_dependent/Search.t
    => SUCCESS: _get_facets_info gets tested and it passes for both MARC21 and UNIMARC.
      Facets rendering should remain unchaged on the UI.
    - Sign off :-D
    
    Sponsored-by: Universidad Nacional de Cordoba
    
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit eefef42abda81e84e42d4a3951684092045886fa
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Aug 20 00:48:07 2014 -0300

    Bug 12788: facets calculation should skip 100 if ind1=z
    
    This patch adds a test for field 100, to skip it on facet calculation
    if ind1=z.
    
    To test:
    - Have IncludeSeeFromInSearches set.
    - Create a biblio record, when adding an author, create a new authority record
      that contains a 400$a field (see from).
    - Rebuild zebra db.
    - Search for the record making sure the search returns more than one record.
    => FAIL: the facets contain the 'see from' field.
    - Run
      $ prove -v t/db_dependent/Search.t
    => FAIL: it fails
    - Apply the patch
    - Run
      $ prove -v t/db_dependent/Search.t
    => SUCCESS: it passes
    - Re-run the search, notice the 'see from' doesn't show anymore on the facets.
    - Sign off :-D
    
    Edit: minor stylistic change
    
    Regards
    To+
    
    Sponsored-by: Universidad Nacional de Cordoba
    
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 62d3a286c16b97c288af54bfd4b64bffbb5f6090
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Aug 20 00:33:40 2014 -0300

    Bub 12788: (regression test) refactor facet extraction code to allow testing
    
    This patch refactors the facet extraction loop into a proper function.
    The loop is changed so the MARC::Record objects are created only once
    instead of the old/current behaviour: once for each defined facet (in
    C4::Koha::getFacets).
    
    To test:
    - Apply the patch
    => SUCCESS: verify facets functionality remains unchanged.
    - Run:
      $ prove -v t/db_dependent/Search.t
    => SUCCESS: tests for _get_facets_data_from_record fail, because
      100$a is considered for fields with indicator 1=z (field added
      by IncludeSeeFromInSearches syspref).
    - Sign off :-D
    
    Sponsored-by: Universidad Nacional de Cordoba
    
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes tests and QA script.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm            |  128 ++++++++++++++++++++++++++++++++---------------
 t/db_dependent/Search.t |   80 +++++++++++++++++++++++++++--
 2 files changed, 163 insertions(+), 45 deletions(-)


hooks/post-receive
-- 
main Koha release repository