[koha-commits] main Koha release repository branch master updated. v3.16.00-606-g33d7a28
Git repo owner
gitmaster at git.koha-community.org
Thu Sep 18 02:35:09 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 33d7a28afa927ae190f819ffc98b578dcef4f296 (commit)
via a6da517127aeb4c89c204e3a672831e0069ed4ba (commit)
via 9d48d31130c554ee889d2ab4ff690fe9915af0ea (commit)
via 5af96e0f78d676c202f634e45dff7def31d10c4f (commit)
via 2217f98b7cf1da89ed3e4bcc2cc497fe01df724c (commit)
via 55e5c82ab593c180e0b73f1cd13bbc71ee7a39c6 (commit)
from d15cecacedd58abdafa0b0276a3002af7b266090 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 33d7a28afa927ae190f819ffc98b578dcef4f296
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Sep 17 21:33:49 2014 -0300
Bug 12728: DBRev 3.17.00.025
commit a6da517127aeb4c89c204e3a672831e0069ed4ba
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Aug 21 13:06:20 2014 +0200
Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql
This patch adds a dbrev.
If people installed Koha after the initial dbrev (3.09.00.015), an install
with sysprefs.sql did not add the pref. So they still could not have it.
Test plan:
If you have the pref, running an database update should not do anything.
If you do not have the pref (delete it via mysql), it should be added.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9d48d31130c554ee889d2ab4ff690fe9915af0ea
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Aug 7 14:16:24 2014 +0200
Bug 12728: Add StatisticsFields to sysprefs.sql
Bug 7955: [Statistics tab for Patron checkouts] introduced the pref
StatisticsFields but did not add it to the sql install file.
Test plan:
Run webinstaller or mysql ... < sysprefs.sql
Verify that the new pref is in your systempreferences table.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Run webinstall, new syspref loaded.
No koha-qa errors.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5af96e0f78d676c202f634e45dff7def31d10c4f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Aug 26 16:43:49 2014 +0200
Bug 12827: NewOrder needs more unit tests
NewOrder should be more tested!
This patch moves the existing unit tests into a new file and adds some
unit tests.
Note that there is no DB field aqorders.subscription, so the test in
NewOrder can be removed.
Test plan:
prove t/db_dependent/Acquisition/NewOrder.t
and
prove t/db_dependent/Acquisition.t
should return green.
Signed-off-by: Zeno Tajoli <z.tajoli at cineca.it>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 2217f98b7cf1da89ed3e4bcc2cc497fe01df724c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Aug 26 16:06:10 2014 +0200
Bug 12827: NewOrder should not return basketno
Since the basketno parameter is needed to insert an order, it is useless
to return it.
This patch changes the prototype for the C4::Acquisition::NewOrder
subroutine. The return value is now a scalar containing the ordernumber
created.
Test plan:
Verify there is no regression on an acquisition workflow:
1/ Create an order with several items
2/ Modify the order
3/ Receive some items
4/ Cancel the receipt
4/ Receive some items
5/ Receive all remaining items
6/ Cancel the receipt
Signed-off-by: Zeno Tajoli <z.tajoli at cineca.it>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 55e5c82ab593c180e0b73f1cd13bbc71ee7a39c6
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Sep 8 20:25:27 2014 +0200
Bug 12891: NewOrder does not return ordernumber if ordernumber is defined
The behavior is quite weird, but
$schema->resultset('Table')->create($data)->id
does not return the id inserted if $data contains the key.
To be more clear, in this case
$schema->resultset('Aqorder')->create($new_order)->id
returns an empty string because $new_order->{ordernumber} is an empty
string!
This was not caught by the unit tests, I added one.
Test plan:
- AcqCreateItem set to ordering
- Create an order with items and verify items are correctly linked to the
order.
Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Confirmed that without the patch the created item is not linked to the
order (entry in aqorders_items). With the patch, it works as expected.
Passes tests and Koha QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 37 ++++-----
acqui/addorder.pl | 2 +-
acqui/addorderiso2709.pl | 2 +-
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 10 +++
kohaversion.pl | 2 +-
t/db_dependent/Acquisition.t | 47 +----------
t/db_dependent/Acquisition/CancelReceipt.t | 4 +-
.../Acquisition/GetBasketsInfosByBookseller.t | 4 +-
.../Acquisition/GetOrdersByBiblionumber.t | 6 +-
t/db_dependent/Acquisition/Invoices.t | 6 +-
t/db_dependent/Acquisition/NewOrder.t | 86 ++++++++++++++++++++
t/db_dependent/Acquisition/OrderFromSubscription.t | 2 +-
t/db_dependent/Acquisition/TransferOrder.t | 2 +-
t/db_dependent/Acquisition/close_reopen_basket.t | 4 +-
t/db_dependent/Bookseller.t | 35 ++++----
t/db_dependent/Budgets.t | 4 +-
17 files changed, 155 insertions(+), 99 deletions(-)
create mode 100644 t/db_dependent/Acquisition/NewOrder.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list