[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-17-g973c6bb

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  973c6bbf0101f3861c109900388b7708c5728621 (commit)
      from  b4d0863fbcd06d64c4c6b75d5f6100a5e7ea2618 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 973c6bbf0101f3861c109900388b7708c5728621
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Sat Aug 23 16:36:21 2014 +0200

    Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions
    
    In case when the staff user doesn't have (circulate) ->
    (override_renewals) permission granted, this code part
    
       var AllowRenewalLimitOverride = [%
    CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %];
    
    in circ/circulation.tt and members/moremember.tt leads to javascript
    error, because TT statement evaluates to empty string.
    
    To reproduce:
    
    - set AllowRenewalLimitOverride syspref to "Don't allow" (this step is
      possibly redundant / not quite relevant),
    - for testing purposes, log in as some (sample) staff user whitch does
      not have permission granted for "(override_renewals) Override blocked
      renewals",
    - have a look at some patron accounts (preferably, ones with 1+
      check-out), observe that page layout is incorrect in "Check Out" and
      "Details" tab.
    
    To test:
    
    - apply patch,
    - retest and ensure that this issue is no longer reproductible,
    - make sure that there are no regressions of any kinds regarding renewal
      override permission for staff users (i.e, that it still works like
      intended).
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes QA script and tests.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt   |    2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository