[koha-commits] main Koha release repository branch master updated. v3.16.00-636-g755655a

Wed Sep 24 02:27:31 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  755655a42a2621c86fe3d171564401fd929c28cd (commit)
       via  1b5c0966bbb600b6927fa04edcb1691a794f38f6 (commit)
       via  171b4e24b30ddceb04e45fb51c4adb6f921217a2 (commit)
       via  9daef6fb5323c9a899da5241cfc0bf62ba4cb212 (commit)
       via  e9eef04b95e7cb0dadda862f07c0d34a31f5eb6a (commit)
       via  6a98db50fc56be0d611170507c2ced445b894970 (commit)
      from  6246f2c70049baf86bc942c2473793c83057a64f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 755655a42a2621c86fe3d171564401fd929c28cd
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Sep 17 08:31:27 2014 -0400

    Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation

    This minor follow-up revises the language a bit: Adding missing question
    marks and using the more standard prompt "Please select at least one..."

    To test, follow the previous test plan and confirm that the prompts are
    improved:

    - go on the suggestion management page
    - don't select any suggestion and try to delete (check the checkbox and
      submit the form). Verify that you get an alert.
    - select 1 suggestion and delete it, verify you get a confirmation
      message
    - select 1+ suggestions and delete it, verify you get a confirmation
      message

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 1b5c0966bbb600b6927fa04edcb1691a794f38f6
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Sep 17 13:11:00 2014 +0200

    Bug 12937: Deleting suggestions should ask for a confirmation

    On the suggestion management page, the librarian can choose to delete
    suggestions but no confirmation is needed.
    This could produce unexpected lost of data.

    Test plan:
    - go on the suggestion management page
    - don't select any suggestion and try to delete (check the checkbox and submit the form).
      Verify that you get an alert.
    - select 1 suggestion and delete it, verify you get a confirmation
      message
    - select 1+ suggestions and delete it, verify you get a confirmation
      message

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 171b4e24b30ddceb04e45fb51c4adb6f921217a2
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Tue Sep 23 21:07:08 2014 -0300

    Bug 12876: (followup) remove useless diags

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9daef6fb5323c9a899da5241cfc0bf62ba4cb212
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Sep 5 17:40:05 2014 +0200

    Bug 12876: Improve unit tests for CanReserveBeCanceledFromOpac

    This patch fix the subroutine name and add a restriction on the
    arguments: both argument are mandatory!

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit e9eef04b95e7cb0dadda862f07c0d34a31f5eb6a
Author: Rafal Kopaczka <rkk0 at poczta.onet.pl>
Date:   Fri Sep 5 14:50:15 2014 +0200

    Bug 12876 - Reserve in waiting/transfer status may be cancelled by user

    User may cancel his own reservation at waiting or in transit status
    through calling opac-modrequest.pl. Cancel button is disabled in
    interface but possibility to cancel should be checked also in
    opac-moderequest.pl, before calling CancelReserve().
    Similar situation is with opac-modrequest-suspend.pl

    This patch provides new soubroutine to chceck if user can cancel given
    reserve. It's possible only when he's owner of hold and hold isn't in
    transfer or waiting status.

    Additionaly there are new test for this function in Reserves.t

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests, QA script and new tests.
    Works as described, tested with:
    .../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 6a98db50fc56be0d611170507c2ced445b894970
Author: Rafal Kopaczka <rkk0 at poczta.onet.pl>
Date:   Thu Sep 4 16:40:33 2014 +0200

    Bug 12873 - Reserve can be cancelled by any logged in user

    It is possible to cancel reservations through simply running opac-modreserve.pl with existing reserve_id number. This may provide remove even all reservations from system. The only limitation is that user have to be logged in. Simplest solution is to check whether reserve belongs to user or not.

    Test plan:
    1. Create reserves by 2 different users, and get their ID's
    2. Before patch, hold may by cancelled by anyone who run site:
    http://example.com/cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX
    3. After patch hold may by cancelled only by user whose reserve is.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm                                     |   25 ++++++++
 .../prog/en/modules/suggestion/suggestion.tt       |   26 +++++++-
 opac/opac-modrequest-suspend.pl                    |    2 +-
 opac/opac-modrequest.pl                            |    2 +-
 t/db_dependent/Reserves.t                          |   67 ++++++++++++++++++--
 5 files changed, 114 insertions(+), 8 deletions(-)

hooks/post-receive
-- 
main Koha release repository