[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.09-5-g7f504ac

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  7f504acc13a361ba93504917498ae955b82ed430 (commit)
       via  e27969c5028211298bc4006013c0ae184d80ff5d (commit)
       via  c9d12187da005391b4cb8358e7adbcbab105e9ff (commit)
      from  b20092a566a84f76cb80f6974d7900060e9647b2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7f504acc13a361ba93504917498ae955b82ed430
Author: Mason James <mtj at kohaaloha.com>
Date:   Thu Apr 9 15:33:02 2015 +1200

    Bug 12954: Failed login should retain anonymous session (3.16.x)
    
    A failed login should not leave the user in a half logged authenticated
    state, but rather return them to an anonymouse session as per the
    pre-login attempt state.
    
    To replicate error:
    1. Try to log in with some nonexisting user id or wrong password in the
       OPAC
    2. Go directly to /opac-user.pl (e.g., enter it in the browser address
       bar, or just click on the "Log in" link)
    3. Observe a DBI error displayed on the screen
    4. You are now in the "deadloop" of sorts (opac/opac-user.pl refuses to
       display the login screen, no matter how many times you try to reload
       it); to break the deadloop, one needs to:
       - remove session cookie from the browser (or cause the session to
         expire in some other way - closing browser window would be probably
         enough for that)
       - remove offending session on the server (from mysql sessions table,
        ..)
       - log in with proper credentials using some other page (like
         opac/opac-main.pl right-side panel), which does not involve
         opac/opac-user.pl being called without "userid" CGI parameter.
    
    To test:
    1. Test as above, the DBI error should no longer be present
    2. Check that search history works across failed and sucessful login
       attempts
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit e27969c5028211298bc4006013c0ae184d80ff5d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jan 6 06:54:00 2015 +0000

    Bug 13521: Add missing semicolon
    
    Add a missing semicolon to the end of a template variable assignment
    line. This patch should not affect operation.
    
    Note: With Bug 13499 we did a non-destructive perltidy, as such we only
    affected indenting and whitespace to maintain blame history. However, a
    number of minor code issues were also highlighted, in this series of
    patches I hope to correct other minor style issues.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit c9d12187da005391b4cb8358e7adbcbab105e9ff
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jan 6 06:48:29 2015 +0000

    Bug 13521: Removed superflous semicolon
    
    Removed an uneeded semicolon from the end of an 'if' block. This should
    not affect operation of the script.
    
    Note: With Bug 13499 we did a non-destructive perltidy, as such we only
    affected indenting and whitespace to maintain blame history. However, a
    number of minor code issues were also highlighted, in this series of
    patches I hope to correct other minor style issues.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository