[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.14-5-g4992ce6

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  4992ce63b2d031a5e907bb9b5f881b26e563c332 (commit)
      from  3ab9c7c93b9c211b89daa5b34d903cd05ff2e379 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4992ce63b2d031a5e907bb9b5f881b26e563c332
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date:   Mon Jun 23 16:51:00 2014 +0200

    Bug 12631: Inventory: fix "wrong place" and "item not scanned"
    
     "item not scanned": when calling GetItemsForInventory, datelastseen should
     be used when "compare barcodes list to result" is checked.
    
     Otherwise, when loading multiple barcodes files for the same inventory, many
     items will be marked as "item not scanned" when loading the last barcode file
     ("compare barcodes list to result" checked) even though they were scanned.
    
     "wrong place": when searching for wrongly placed items, we should only check
     for the location (callnumbers, location and branch). To fix this, A new call
     to  GetItemsForInventory has been made with location filters only.
    
     Otherwise, any item with a different itemtype for instance will be marked as
     wrong place even if the location is correct.
    
     Test plan:
    
    "item not scanned" status:
    
    1) Split a barcode file in two.
    2) Load the first barcode file without checking "compare barcodes list to result".
    3) Load the second barcode file with "compare barcodes list to result" checked.
    4) Check in the csv report that you have a lot of scanned items with the "item
    not scanned" status.
    
    Then apply the patch, do the same, and check that the false "item not scanned"
    statuses are gone.
    
    "wrong place" status:
    
    1) Load a barcode file with barcode matching an item that has a correct
    location, but a different itemtype than what you're looking for.
    2) Check in the results that this item will be marked as "change item status"
    and "wrong place".
    
    Then apply the patch, do the same, and check that the only status for this item is "change item status", which is correct.
    
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    (cherry picked from commit 7d20f176ce76784d7c81399e5555f436656fd25f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 tools/inventory.pl |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository