[koha-commits] main Koha release repository branch master updated. v3.18.00-727-g40e4722
Git repo owner
gitmaster at git.koha-community.org
Wed Apr 22 18:27:27 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 40e4722a957102a52ece9cd4f21ab6fd902f3c18 (commit)
via 5ee69d78dcda0a12833f4dae5b0043d91f3c31ba (commit)
via 3eb056be6d5d0fd760c895897924f86c8eb42355 (commit)
via c7838208eb02b3fe4d3539017322a912f581d10f (commit)
via 29d9e9ee6cdb51f68356e64dc4770ed00e383fcb (commit)
via 444644b99634b85ac4f334db0c936981af2afd33 (commit)
via c7dadf82cae046cc1c9d287755bc2d085b21a94e (commit)
via 62dcd12f83945730d34be3d31da1120dc034ace6 (commit)
via 1f2ff757b51039085754b90881b892e612c1f94d (commit)
via 3c9058523b2f95b8dfa6383a65f3e8cea05b112e (commit)
via a3cf51beb9430da8a4b3dd7c91750c0f3a586524 (commit)
via 0e7fd0252fd6d2a4091e33d3c26160512eeac500 (commit)
via 927aedafa155fb53011c09a510166b4233bac499 (commit)
via 551fca629f53656bd8e9b1d36c17e6f45c230d05 (commit)
from 1c88c819a453113dc36f08f5d9c50d4a890346db (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 40e4722a957102a52ece9cd4f21ab6fd902f3c18
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 22 16:05:41 2015 +0200
Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber
C4::Circ::CheckIfIssuedToPatron called
$items = GetItemsByBiblioitemnumber($biblionumber);
But if biblionumber != biblioitemnumber, the items retrieved were not
the good ones!
Test plan:
Make your Auto increment values for biblio and biblioitems differs
Launch the tests:
prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t
Before this patch, they did not pass.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5ee69d78dcda0a12833f4dae5b0043d91f3c31ba
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Apr 17 07:22:08 2015 -0400
Bug 13819: (QA Followup) more documentation
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3eb056be6d5d0fd760c895897924f86c8eb42355
Author: Barton <barton at bywatersolutions.com>
Date: Wed Mar 11 22:53:11 2015 +0000
Bug 13819: Add biblioitems to ISSUESLIP and ISSUEQSLIP in C4::Members::IssueSlip()
Document all expansions within C4::Members::IssueSlip()
http://bugs.koha-community.org/show_bug.cgi?id=13819
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
- Works as described. ISBN appears on ISSUESLIP & ISSUEQSLIP.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
- Not all fields for biblioitems are available, but neither
are they all available for other tables. Noted in POD.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit c7838208eb02b3fe4d3539017322a912f581d10f
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Sun Nov 2 18:53:47 2014 +0100
Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl
To avoid homonyms, it would be nice if the card number is displayed in the user
suggestion.pl. Currently, consult the record of the user to know exactly who
made the suggestion.
TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has
changed, except that cardnumbers are displayed in 'Suggested by' column.
Resolved an easy conflict while applying. Followed test plan. Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 29d9e9ee6cdb51f68356e64dc4770ed00e383fcb
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Apr 19 22:48:25 2015 +0200
Bug 13623: Follow-up: remove stray </p> tag
Just removing a stray </p> tag.
I got problems when trying to check this page
with an HTML validator, would probaby be worth
checking.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 444644b99634b85ac4f334db0c936981af2afd33
Author: ByWater Staff <staff at bywatersolutions.com>
Date: Mon Jan 26 10:16:42 2015 -0600
Bug 13623: Enhance html for holds queue viewer
It would be very helpful from a css/scripting point of view if the
author field in the holds queue report had a selectable class. In
edition, it would be great if the biblionumber were easy to grab from a
hidden div.
Test Plan:
1) Apply this patch
2) Load the holds queue report ( view_holdsqueue.pl )
3) Inspect an author name with your web browser ( or view the html )
a) Note the hq-author class of the wrapping div
b) Note the hidden hq-biblionumber div
HTML appears as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit c7dadf82cae046cc1c9d287755bc2d085b21a94e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Apr 7 10:29:01 2015 -0400
Bug 13159 [QA Followup] - Remove unused call to localtime()
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 62dcd12f83945730d34be3d31da1120dc034ace6
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Tue Mar 3 18:17:59 2015 +0200
Bug 13159 [QA Followup] - Fix transaction_date and undefined warning
cli-client doesnt respect the transaction_date format
"YYYYMMDDZZZZHHMMSS"
Using timestamp() to generate the proper datetime format.
"String $value undefined"-warning in build_field() fixed.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1f2ff757b51039085754b90881b892e612c1f94d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Mar 2 05:32:28 2015 -0800
Bug 13159 [QA Followup] - Move script back to it's original path
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3c9058523b2f95b8dfa6383a65f3e8cea05b112e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Mar 2 05:31:11 2015 -0800
Bug 13159 [QA Followup] - Fix changed namespace for Sip::Constants
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a3cf51beb9430da8a4b3dd7c91750c0f3a586524
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 24 09:59:19 2015 -0500
Bug 13159 [QA Followup] - Fix flag parameters
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0e7fd0252fd6d2a4091e33d3c26160512eeac500
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Oct 29 07:49:38 2014 -0400
Bug 13159 - Enhancements to the SIP2 command line emulator
I needed to be able to perform checkout operations for testing from the
command line. I ended up reengineering the SIP2 command line tester
quite a bit.
Enhancements:
* Moved message generation code to subroutines
* Added support for more messages
* Added command line switches for each supported message
* Enabled use of Sip::Constants to keep code DRY and more understandable
* Moved script from misc to C4/SIP
* Designed with an eye towards possibly moving some code to CPAN in the future
* Also designed to make adding new messages much easier in the future
Test Plan:
1) Apply this patch
2) Look at help via ./C4/SIP/sip_cli_emulator.pl --help
3) Test patron status request and patron information, should work as before
except you need to pass the command line switche -m <message_name>
4) Test the new checkout option using -m checkout -i <item barcode>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Worked as advertised, with one warning at renew only:
Trying 'renew'
Use of uninitialized value $value in concatenation (.) or string at ./sip_cli_emulator.pl line 462, <GEN0> chunk 1.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 927aedafa155fb53011c09a510166b4233bac499
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Oct 2 14:16:09 2013 +0200
Bug 10985: [UNIMARC] Fix authority summary
The problem is the template in authority type summary is not respected
at all. It is only read to see which fields and subfields should appear
in the summary.
This patch fixes that.
It also fixes a bug in auth_finder.pl plugin when summary contains
fields other than 2XX.
Test plan:
0/ You must use a UNIMARC setup for those tests
1/ edit an authority type summary with:
NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*]
2/ create a new authority with previous fields (it is possible some
fields don't exist).
3/ search this authority and verify the summary is someting like:
NP : Name, D.-- NP -- 23849 ppn: my_ppn
4/ Verify some summary for existing authorities and check they are
correct.
5/ Edit a biblio record and use the plugin auth_finder.pl (for example
in a 7XX field)
6/ Do a search and verify the summary is correct
7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you
should have multiple 2XX fields for the numbered links to show up)
8/ Verify that the biblio field is correctly filled.
/!\ For the ppn, it should be defined in the zebra indexes.
In MARC21 and NORMARC setups, this patch should change nothing, please
verify that too (you can check that the auth_finder.pl plugin is still
working and the auth type summary is correctly displayed in authorities
search and auth_finder.pl plugin).
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
It works as described, both in authority search result page, and in authority
data entry plugin.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 551fca629f53656bd8e9b1d36c17e6f45c230d05
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Mar 20 09:48:05 2015 -0400
Bug 13880 - Allow svc/report to be passed sql parameters
The same feature added to the opac svc/report in bug 9915 should be
added to the staff side.
Test Plan:
1) Apply this patch
2) Create this report:
SELECT * FROM biblio WHERE biblionumber = <<biblionumber>>
3) Note the id of the report
4) Go to the Staff URL
/cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER
5) Note you recieve a json response
NOTE: without applying the patch you get an empty JSON response.
ALSO: running koha qa tools does not verify the changes.
$ perlcritic -4 svc/report
(my perlcritic rc points to the koha qa tool one)
No issues.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/AuthoritiesMarc.pm | 56 +--
C4/Circulation.pm | 15 +-
C4/Members.pm | 59 ++-
C4/Suggestions.pm | 1 +
.../intranet-tmpl/prog/en/css/staff-global.css | 4 +
.../en/includes/authorities-search-results.inc | 13 +-
.../modules/authorities/searchresultlist-auth.tt | 6 +-
.../prog/en/modules/circ/view_holdsqueue.tt | 31 +-
.../prog/en/modules/suggestion/suggestion.tt | 4 +-
.../en/includes/authorities-search-results.inc | 13 +-
misc/sip_cli_emulator.pl | 432 ++++++++++++++++++--
svc/report | 12 +-
t/db_dependent/AuthoritiesMarc.t | 8 +-
13 files changed, 535 insertions(+), 119 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list