[koha-commits] main Koha release repository branch master updated. v3.18.00-748-ga510a45

Wed Apr 22 22:01:53 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a510a4515c9a62ad6005f2eb997496d403dd4247 (commit)
       via  2796eb21586ea7f23c2ca5d969d242b78b1cfa09 (commit)
       via  d1cdbf9d56038f0305f9be90205c0315882ec711 (commit)
       via  b05cbc415d2461a3909db593b9b12d5cc506e35d (commit)
       via  9d025e65a823689fb1a9b8a2c182877e4234a533 (commit)
       via  cc8601f486cedfe8595b2f7abe799111ebe7309a (commit)
       via  6a69b1e65301fa301aecce0424c515a58d838cd4 (commit)
       via  9d7d645baf35ae8b0b37d5d6c8ad653f8aa55841 (commit)
       via  40543e9c45a9b986c0382cb25e6979a8cc224e56 (commit)
       via  9ad8b86643b4a5698851ce4a67122ca35c2a1b61 (commit)
      from  88eb0323d7bde5bc91b7c58bce2848fb502eb076 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a510a4515c9a62ad6005f2eb997496d403dd4247
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Apr 22 09:55:55 2015 +0200

    Bug 13482: Sent biblionumber to the template

    The biblionumber is sent to the template as 'itembiblionumber' at 1 place, the template get the 'biblionumber' variable.
    I don't understand why but the easy way is to sent the variable twice.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 2796eb21586ea7f23c2ca5d969d242b78b1cfa09
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Apr 16 14:10:30 2015 +0200

    Bug 13482: Prevent race condition on printing a ReserveSlip

    The problem has been well described by Kyle and Nicole on bug 7255
    description and comment 1.

    With this counter patch, I suggest to popup AFTER the return has been
    confirmed. This will remove the race condition and avoid to pass
    itemnumber to the pl file as in the patch submitted by Olli.

    Only the borrowernumber and biblionumber are needed (transfer and op are
    never used by circ/hold-transfer-slip.pl).

    Test plan:
    It is very hard to know all cases (at least 6) where the popup is
    displayed. Try at least to get the hold and the transfer confirmation
    messages.
    You should get the popup if you click on "print slip" button.

    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit d1cdbf9d56038f0305f9be90205c0315882ec711
Author: Marc Véron <veron at veron.ch>
Date:   Sun Apr 19 07:37:37 2015 +0200

    Bug 14008: Proposed follow-up: Dialog should appear whenever filters are active

    The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action.
    To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b05cbc415d2461a3909db593b9b12d5cc506e35d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Apr 17 15:24:36 2015 +0200

    Bug 14008: Display active filters when searching for reports

    On the saved report list, the filters on the left are not displayed.
    It means that some can be set, but the user has not visible feedbacks.

    How filters work here:
    If a user set a filter, it is saved in the session. Next time he will
    come on this search, the previous values will be kept.

    This patch just displayed the filter's values in the input fields.

    Test plan:
    Search for reports by date, author and keyword.
    The filters should be displayed after you have clicked on the submit
    button ("Apply filter").

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9d025e65a823689fb1a9b8a2c182877e4234a533
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Apr 17 14:53:24 2015 +0200

    Bug 10706: Delete saved_reports to be sure no reports existed

    We need to be sure no report existed before launching the tests.

    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit cc8601f486cedfe8595b2f7abe799111ebe7309a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Apr 16 17:23:26 2015 +0200

    Bug 10706: Add test

    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 6a69b1e65301fa301aecce0424c515a58d838cd4
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Apr 16 17:23:37 2015 +0200

    Bug 10706: Search reports by id

    This patch adds the ability to search reports by their id.

    Test plan:
    1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved)
    2/ Search for a report id (refer to the ID column in the table)
    3/ The result should be consistent

    That the filters are not kept, already existed.

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9d7d645baf35ae8b0b37d5d6c8ad653f8aa55841
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Apr 20 16:59:05 2015 +0200

    Bug 14022: Does not reset the subscription length on editing a subscription

    The subscription length is always set to the first/default value
    ('issues') when editing a subscription.
    Even if you selected another value on creating/editing it, the form will
    show you the first option.

    Test plan:
    1/ Add/Edit a subscription, select a subscription length different of
    the first value (issues)
    2/ Edit the subscription and confirm the value is kept

    Bonus: issues, week and months become translatable.

    Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 40543e9c45a9b986c0382cb25e6979a8cc224e56
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Apr 21 10:44:43 2015 +0200

    Bug 14016: (follow-up) Restore correct date format on issue date (00:00 vs 23:59)

    Same for the overdues.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9ad8b86643b4a5698851ce4a67122ca35c2a1b61
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Apr 20 10:41:19 2015 +0200

    Bug 14016: Restore correct date format on issue date (00:00 vs 23:59)

    Introduced by bug 13601, and same fix used in bug 10423 and bug 12847:
    the date_due retrieved from the DB is modified.

    There are some problems:
    1/ There is confusion between the iso and sql formats in the codebase.
    2/ Since bug 13601, dt_from_string does not manage the iso format (there
    are occurrences of 'iso' but it assumes that both formats are
    identical).

    To solve the issue, 2 solutions:
    1/ Same as bug 10423 and bug 12847: try to get rid of the change done on
    date_due in C4::Members::GetPendingIssues, it should be kept as the sql
    value.
    2/ Too many errors found and another fallback should be added to
    dt_from_string (if 'iso' is passed, try sql then iso).

    Test plan:
    Go on the checkout list at the OPAC and confirm that the due dates are
    correctly formatted.

    Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                      |    2 ++
 C4/Reports/Guided.pm                               |   14 +++++----
 circ/hold-transfer-slip.pl                         |    1 -
 circ/returns.pl                                    |   10 +++++++
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |   27 ++++++++++++++----
 .../en/modules/reports/guided_reports_start.tt     |   11 +++----
 .../prog/en/modules/serials/subscription-add.tt    |   30 ++++++++++++++++----
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |    6 ++--
 reports/guided_reports.pl                          |    1 +
 serials/subscription-add.pl                        |   18 ++++--------
 t/db_dependent/Reports_Guided.t                    |    6 +++-
 11 files changed, 83 insertions(+), 43 deletions(-)

hooks/post-receive
-- 
main Koha release repository