[koha-commits] main Koha release repository branch master updated. v3.18.00-772-gc953aee

Git repo owner gitmaster at git.koha-community.org
Thu Apr 23 18:27:28 CEST 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c953aee870c6e1f9882e178b9543ed6086e2ba17 (commit)
       via  a8971f33ad35369695e7213721a16dc94f334969 (commit)
       via  a9ac14658d826b97d470f6be5b4e3a3a33276143 (commit)
       via  dcfa31d5dc2cb0aa9a12d606ee0205a4e3be5f62 (commit)
       via  a77957a835e79aeb9f4586a67fbf3d484f2e9a6c (commit)
      from  59b15eb2212786625f9843d7b09100f91eb3a4ed (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c953aee870c6e1f9882e178b9543ed6086e2ba17
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu Apr 23 13:23:54 2015 -0300

    Bug 13606: DBRev 3.19.00.029
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a8971f33ad35369695e7213721a16dc94f334969
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu Apr 23 13:22:41 2015 -0300

    Bug 13606: (RM followup) DBIx updates
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a9ac14658d826b97d470f6be5b4e3a3a33276143
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Apr 10 15:35:54 2015 +0200

    Bug 13606: Add tests and fix existing ones
    
    Some tests were wrong and not executed in a transaction.
    Lot of sessions were created in DB because the session was never
    flushed.
    
    TEST PLAN
    ---------
    $ mysql ...
    > delete from sessions;
    ^Z
    $ prove -v t/db_dependent/BackgroundJob.t
    ...
    $ fg
    > select id from sessions;
    -- There will be lots of ids (10, if I recall)
    ^Z
    $ git bz apply 13606
    ...
    $ prove -v t/db_dependent/BackgroundJob.t
    ...
    $ fg
    > select * from sessions;
    -- there should only be the one orphaned job.
       You can tell it is correct by the "making new job".
    > quit
    
    Run the koha-qa test tools.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit dcfa31d5dc2cb0aa9a12d606ee0205a4e3be5f62
Author: Frédéric Demians <f.demians at tamil.fr>
Date:   Fri Apr 10 08:44:39 2015 +0200

    Bug 13606 Clear job data in session when the job is completed
    
    Bug 11395 uses the session to store the report sent to the interface
    (update on biblio XX OK, etc.).
    
    If the session is stored in mysql, the max size of the
    sessions.a_session will be reached easily (TEXT field).
    
    To reproduce:
    0/ Set SessionStorage to 'mysql'
    1/ Create a file with 500 biblionumbers:
      mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt
    2/ Define a marc modification template (something like "delete field 99$9" is nice)
    3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool
    4/ Repeat 3
    You will get:
      Syck parser (line 1534, column 6): syntax error at
      /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75.
    None Koha page is reachable.
    
    It comes from get_template_and_user > checkauth > get_session >
    l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh});
    
    5/ Get your sessionID contained in your CGISESSID cookie
    Have a look at the value a_session in the sessions table:
    mysql> select a_session from sessions where id="YOUR_SESSIONID";
    
    You should see that the yaml is not correctly ended.
    The size of the DB field has been reached and the yaml is truncated.
    
    Test plan:
    0/ Delete your CGISESSID cookie
    1/ Try to reproduce the previous issue
    2/ After the second batch, have a look at the sessions table and confirm
    that only one job_$JOB_ID exist in the yaml
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    
    NOTE: Nicely clears batch job session information.
          (2) is incorrect. This cleans up after a full run.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit a77957a835e79aeb9f4586a67fbf3d484f2e9a6c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Jan 21 15:59:10 2015 +0100

    Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT
    
    The previous patch fixed partially the problem.
    If you try to update more that 1000 records, you will get the same
    error.
    
    This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb).
    
    Test plan:
    1/ Try to modify a huge amount of records (1000 should be enough)
    2/ Confirm it worked!
    
    Signed-off-by: Frederic Demians <f.demians at tamil.fr>
    
    I confirm that with more than 1000 records the session object is truncated, and
    then can't be anymore be desirialized, blocking completely Koha. Fixed with
    this patch.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    This only pushes off the problem expontentially (64KB vs. 16MB), but this is a
    good start.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/BackgroundJob.pm                    |   19 +++++++++
 Koha/Schema/Result/Session.pm          |    8 ++--
 installer/data/mysql/kohastructure.sql |    2 +-
 installer/data/mysql/updatedatabase.pl |    9 ++++
 kohaversion.pl                         |    2 +-
 t/db_dependent/BackgroundJob.t         |   72 ++++++++++++++++++--------------
 tools/batch_record_modification.pl     |    1 +
 7 files changed, 76 insertions(+), 37 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list