[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.02-14-g0b03b75

Sun Aug 9 23:28:47 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  0b03b756f9f6aebcbdfe169a57de6c7fe9e97855 (commit)
       via  f5b38743c5676254d15801bac1529be4d6d2361a (commit)
       via  8ffe9410af465e618ddf4e59c97c3797cfdd4866 (commit)
       via  795f31107ebd90951169177541daa1fe7590a375 (commit)
      from  8273c561842756efa89296a40eead4416e33091f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0b03b756f9f6aebcbdfe169a57de6c7fe9e97855
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Apr 13 10:12:03 2015 +0200

    Bug 8684: Add regression tests for SearchItemsByField

    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit 2eded5f165eb1cc175bc61a93c1b5b7c8f5ac02f)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit f5b38743c5676254d15801bac1529be4d6d2361a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Apr 7 14:14:18 2015 +0200

    Bug 8684: Fix duplicate check on creating items in the acquisition module

    The script acqui/check_uniqueness.pl has been introduced by bug 7178.
    But bug 11425 added a call to a new subroutine SearchItemsByField in
    order to refactore some code. This subroutine calls SearchItems with an
    arrayref, which is not what SearchItems is expecting.
    This broke the duplicate check done on creating items in the acquisition
    module.

    To reproduce the issue:
    1/ Fill the pref UniqueItemFields with "barcode" and AcqCreateItem with
    "placing an order"
    2/ Create a new basket
    3/ Create a new order
    4/ Close the basket
    5/ Receive items and set barcode with one already in your DB
    6/ Save
    7/ Nothing happen on the interface, but an error should have been added
    in your Koha log file:
      Can't use an undefined value as an ARRAY reference at
      /home/koha/src/acqui/check_uniqueness.pl line 48.

    Test plan:
    1/ Repeat steps 1-6
    2/ You should see a warning on the interface

    Note that this should also happen with AcqCreateItem set to "creating an
    order".

    Works well, no errors.

    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit fa5104a6a1c7e3b0bcb232e4d888066dd20eebe8)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 8ffe9410af465e618ddf4e59c97c3797cfdd4866
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Wed Jun 24 19:43:05 2015 +0200

    Bug 14456: EmbedSeeFromHeadings record filter shouldn't process MARC holding fields

    If the system preference IncludeSeeFromInSearches is enabled, records
    exported for zebra indexing are being additionally processed by
    EmbedSeeFromHeadings record filter (right now used only in rebuild_zebra.pl
    script). This filter embeds 'see from' fields (extracted from authority
    records linked with the given biblio via $9 subfields) into target MARC
    record, which is then subsequently indexed in zebra.

    Currently all fields containing $9 are getting the same exact treatment
    by this filter. But on the export stage when the filter is applied, MARC
    record being processed already does have holdings data fields added in
    the previous stage (usually 952 / 995, depending on the MARC format).
    Problem is that holdings data fields use to have $9 subfields in them
    as well (mapped to item.itemnumber by default). As a consequence, some
    (great many in the typical setup) records exported for zebra indexing
    may have surplus "see from" fields added erroneously in semi-random
    fashion, so biblio searches would often return some completely
    unexpected additional results.

    EmbedSeeFromHeadings record filter should not process holdings fields
    when dealing with MARC records intended for zebra indexing.

    To reproduce:

    1) database with as many sample or real-world biblio, item and authority
    records as possible is recommended for testing purposes
    2) enable IncludeSeeFromInSearches
    3) export a bunch of biblio records for zebra (e.g.:
    misc/migration_tools/rebuild_zebra.pl -I -b -x -k -length=1000),
    inspect the result xml records in /tmp/<whatever> file; observe that at
    the end of many records, here and there some extra "see from" (= 1st
    indicator: 'z') fields tend to appear, which shouldn't be there ;)

    To test:

    4) apply patch
    5) redo 3)
    6) compare results from 3) and 5) with diff

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    I introduced a regression test for this. You should run the tests
    without/with the patch and verify that the patch actually fixes the problem.
    Good job Jacek! I'm sure writing the regression test would take less time
    than such a detailed commit message!

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit f3a8b7a0e1e1bf112628c6215105ab80f25ed94f)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 795f31107ebd90951169177541daa1fe7590a375
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Jul 22 11:22:20 2015 -0300

    Bug 14456: (regression test) Holdings fields should be skipped by EmbedSeeFromHeadings

    This patch introduces a regression test for the situation in which
    an itemnumber on a record matches the authid of an authority record
    and the current implementation of the EmbedSeeFromHeadings filter
    wrongly includes new holding fields with authority data...

    To test:
    - Apply the patch
    - Run:
      $ prove t/db_dependent/RecordProcessor_EmbedSeeFromHeadings.t
    => FAIL: The test 'Holdings fields not processed to introduce See-from heading'
       fails.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit 5e1474836024a9ccd1a9fb4eef91641fba6f8598)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm                                        |    8 ++--
 Koha/Filter/MARC/EmbedSeeFromHeadings.pm           |    5 ++
 t/db_dependent/Items.t                             |    5 +-
 .../RecordProcessor_EmbedSeeFromHeadings.t         |   48 ++++++++++++++++++++
 4 files changed, 61 insertions(+), 5 deletions(-)

hooks/post-receive
-- 
main Koha release repository