[koha-commits] main Koha release repository branch master updated. v3.20.00-412-g490c388
Git repo owner
gitmaster at git.koha-community.org
Thu Aug 20 18:44:14 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 490c3882ac423e842e787ed8c157719dcf33a040 (commit)
via 56a2607c46db30c318eda9dc44ae3c58731e23fe (commit)
via 406098b20b5385d2df588520abecefc868f4c0c0 (commit)
via 91e9cafa7a7348753337e711013ed7d0ab7c0541 (commit)
via d5a5e9576e3161e4b591ac910c88e7c703b89ee0 (commit)
via 260dbd1c70ecd8cf76b452ec2f3c59365c9860e1 (commit)
via 1dc947b18c86e4e07fe12d0b70c0f2a135b43080 (commit)
via 85d27f6d9f310002f65dbc17b9c22e9976032cf8 (commit)
via 5f227b42c183f961e83f537a9f84f13e32f4424e (commit)
via 3ec8b27185f0c8600bc931c5284a5d73d0a42aac (commit)
from 75d123d760d86f0e0d9f58d65874b40f6816008d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 490c3882ac423e842e787ed8c157719dcf33a040
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Wed Aug 12 00:00:35 2015 +0000
Bug 14484: warns when changing patron pw
To test:
1) Go to any patron's page, click Change password
2) Notice warns in error log
3) Apply patch, reload page
4) Click Change password
5) Notice warns are gone and page still works correctly
Signed-off-by: Joonas Kylmälä <j.kylmala at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 56a2607c46db30c318eda9dc44ae3c58731e23fe
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Aug 5 16:10:19 2015 -0300
Bug 14646: Koha::RecordProcessor should accept more than one filter
The docs say that Koha::RecordProcessor accepts more than one filter
at a time. But as the regression tests show it doesn't.
This is really important to extend its usage in record processing
(either to enforce policy, transform, etc).
This patch makes ->new evaluate the reference type of the passed filters
and builds an array with a single item if a scalar has been passed. The
loop now explicitly casts the filters as an array.
To test:
- Apply the test patch
- Run
$ prove t/RecordProcessor.t
=> FAIL: tests fail because Koha::RecordProcessor doesn't hanlde
more than one filter at a time.
- Apply this patch
- Run
$ prove t/RecordProcessor.t
=> SUCCESS: tests now pass
- Easy, right? Sign off :-D
NOTE: Read code. Don't like the ? operator logic, but it is
functional despite readability issues.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 406098b20b5385d2df588520abecefc868f4c0c0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 4 18:43:01 2015 -0300
Bug 14646: (regression test) Koha::RecordProcessor only accepts one filter at a time
This patch introduces new tests to t/RecordProcessor.t so it tests for
creating processors with more than one filter. It does so by running
my $processor = new Koha::RecordProcessor({
filters => ['Null','Dummy']
});
and testing the results.
To test:
- Apply the patch
- Run:
$ prove t/RecordProcessor.t
=> FAIL: tests related to multiple filters fail.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 91e9cafa7a7348753337e711013ed7d0ab7c0541
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jun 1 15:21:32 2015 +0200
Bug 3333: Confusing item status for not-for-loans
This patch makes a tiny change in C4::Search::searchResults as to the
handling of not-for-loans. This should make the display of status and
availability of items more consistent in opac and staff.
Additionally, a Place hold link should disappear in the opac, when it is
not possible to place a hold on any item of one biblio.
The following spots need special attention; the display should be
corrected by this patch:
[A] Location column showing number of available items in catalogue/search.
[B] Location column of Cataloging Search (addbooks.pl)
[C] OPAC Search results list in non-XSLT view.
NOTE
The forms opac-MARCdetail and MARCdetail also include an Items table with
column Not for loan. The information in this column might still be somewhat
confusing but is actually correct. The column only contains Not for loan if
the item field is set. So it is empty when only the item type is nfl.
Since a correction here is arguable, I am not including it on this report.
Test plan:
[1] Have at least two item types. Mark one item type (X) as not for loan.
[2] Use at least two biblios with two items each. Mark one item of the first
biblio as not for loan at item level (via item editor).
Change one item of the second biblio to the item type of step 1 (X).
[3] Set pref item-level_itypes==item and set all four xslt prefs (for opac
and staff, results and detail) to default.
[4] Check spots A, B and C as mentioned above. Also check:
[D] OPAC Detail, Holdings table, Status column
[E] Staff Detail, Holdings, Status.
[5] Make all four xslt prefs now empty. Check spots A to E again.
Especially observe C here.
[6] Set pref item-level_itypes==biblio. Change your second biblio to item
type of step 1 (X) in the cataloguing editor (MARC 942c).
Check spots A to E again.
[7] Set all four xslt prefs again to default. Check spots A to E again.
[8] Run the unit test t/db_dependent/Search.t.
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit d5a5e9576e3161e4b591ac910c88e7c703b89ee0
Author: Martin Stenberg <martin at xinxidi.net>
Date: Tue Aug 18 16:41:42 2015 +0200
Bug 14675: Don't update details if no changes made
if no changes has been made for personal details, bring user back to details
page and inform them that no changes has been made.
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 260dbd1c70ecd8cf76b452ec2f3c59365c9860e1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 6 11:00:38 2015 -0400
Bug 14498: uri_escape error triggered by duplicate accountno's for patron
If a patron has duplicate accountno's for two different fines in Koha this will trigger the error
usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1.
upon attempt to pay. How those accountno's get duplicated is unknown, but considering accountno
is somewhat vestigial at this point in time, it would be much more sensible to use accountlines_id
which is has guaranteed uniqueness at the database level.
Test Plan:
1) Create a patron with 2 fines
2) Edit the accountno's for those fines and set them to 0
3) Attempt to pay one, note the error
4) Apply this patch
5) Refesh the page
6) Attempt to pay one, no error this time!
7) Test Pay, Write off, Pay amount, Write off all, and Pay selected
Signed-off-by: Deborah Duce <deborah.duce at huntsvillelibrary.ca>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 1dc947b18c86e4e07fe12d0b70c0f2a135b43080
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 19 09:12:04 2015 +0100
Bug 14660: Fix 3 other cataloguing plugins
These 3 should use C4::Output not to explode.
Test plan:
Link the plugins with the correct fields
They should not log an error when calling them
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 85d27f6d9f310002f65dbc17b9c22e9976032cf8
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Fri Aug 7 00:33:54 2015 +0200
Bug 14660: Fix stocknumberam123.pl cataloguing plugin
The cataloguing plugin stocknumberam123.pl is broken and no
longer generating numbers - this patch fixes it.
To test:
- Link a subfield to the plugin - usually it's 952$i or the UNIMARC
equivalent in your MARC frameworks
- Create a new item, set the inventory number to: A 0000000002
- Start to catalog another item, enter A into inventory and
- Enter A as stocknumber and activate the plugin by clicking on
... at the end of the field
- The number will not get added - Firebug shows an error:
Undefined subroutine CGI::output_html_with_http_headers
- Apply patch
- Verify numbers are now generated and no errors are shown
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 5f227b42c183f961e83f537a9f84f13e32f4424e
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Fri Aug 7 00:20:09 2015 +0200
Bug 14660: Fix stocknumberAV.pl cataloguing plugin
The cataloguing plugin stocknumberAV.pl is broken and no
longer generating numbers - this patch fixes it.
To test:
- Link a subfield to the plugin - usually it's 952$i or the UNIMARC
equivalent in your MARC frameworks
- Set up a new authorised value INVENTORY, the code is an uppercase
prefix - "B"
- The Descriptions is your starting number - 1
- The OPAC description remains empty
- Catalalog an item
- Enter B as stocknumber and activate the plugin by clicking on
... at the end of the field
- The number will not get added - Firebug shows an error:
Undefined subroutine CGI::output_html_with_http_headers
- Apply patch
- Verify numbers are now generated and no errors are shown
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 3ec8b27185f0c8600bc931c5284a5d73d0a42aac
Author: Galen Charlton <gmc at esilibrary.com>
Date: Tue Aug 4 15:59:39 2015 +0000
Bug 14644: unbreak SIP2 terminal login when using telnet transport
This patch fixes breakage introduced by the patch for bug 13506
that prevented SIP2 clients from authenticating themselves over
the telnet transport. Attempts to do so would manifest by the
SIPServer backend crashing and the connection getting closed.
To test:
[1] Use the stock SIPServer config, etc/SIPconfig.xml, and ensure
that the database contains a staff user whose username is 'term1'
and password is 'term1' that has the circulate permission.
[2] Start SIPServer, telnet to port 8023, and attempt to log in. The
connection will be aborted:
$ telnet localhost 8023
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
login: term1
password: term1
Connection closed by foreign host.
[3] Apply the patch and restart SIPSever, then repeat step 2. This time,
the login should succeed:
$ telnet localhost 8023
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
login: term1
password: term1
Login OK. Initiating SIP
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/SIPServer.pm | 2 +-
C4/Search.pm | 2 +
Koha/RecordProcessor.pm | 13 ++++--
cataloguing/value_builder/callnumber-KU.pl | 1 +
cataloguing/value_builder/callnumber.pl | 1 +
cataloguing/value_builder/stocknumberAV.pl | 1 +
cataloguing/value_builder/stocknumberam123.pl | 1 +
cataloguing/value_builder/unimarc_field_010.pl | 1 +
.../intranet-tmpl/prog/en/modules/members/pay.tt | 29 +++++++-------
.../bootstrap/en/modules/opac-memberentry.tt | 3 ++
members/member-password.pl | 2 +-
members/pay.pl | 6 +--
opac/opac-memberentry.pl | 42 ++++++++++++--------
t/RecordProcessor.t | 37 ++++++++++++++++-
14 files changed, 97 insertions(+), 44 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list