[koha-commits] main Koha release repository branch master updated. v3.22.00-80-g010a32d

Git repo owner gitmaster at git.koha-community.org
Wed Dec 30 13:12:35 CET 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  010a32d95f871853f5c597b2670f3de4c62cfa51 (commit)
       via  ac541e0fa1c11254e110d94eed64c358e02e8aab (commit)
      from  3a7dd6c07c98bf97c817186d11ae1baaf585ea34 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 010a32d95f871853f5c597b2670f3de4c62cfa51
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 9 17:41:04 2015 +0000

    Bug 15344: Remove some other calls of GetMemberDetails from pl scripts
    
    Same as previously.
    For these files it's a bit less obvious.
    To make sure these changes won't introduce any regression, check that
    the variable returned by GetMember is never used to get something
    else than a borrower fields.
    The 'flags' should not be get neither.
    For opac-user.tt it's different, other keys are got but there are defined
    in the pl script.
    
    On the way:
    - 'showname' is removed (never used)
    - fix scope var issue in opac-user.tt (BORROWER_INF.OPACPatronDetails vs
    OPACPatronDetails)
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit ac541e0fa1c11254e110d94eed64c358e02e8aab
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 9 17:00:10 2015 +0000

    Bug 15344: Remove unucessary call to GetMemberDetails
    
    This subroutine does a lot a processing and should only be called when
    necessary.
    In the get_template_and_user subroutine (so called from any pages of
    Koha), it is call to pass the branchcode, title, firstname, surname and
    borrowernumber values for the logged in user.
    This subroutine calls GetMemberAccountRecords which retrieve the items
    infos for all accountlines entries of the logged in user.
    On members/members.pl, let's say you have 74 entries in the accountlines
    tables, the page will execute 115 SELECT instead of 35 if you don't have any
    accountlines entries.
    With this patch, the number of SELECT is always 31.
    
    To test this patch you should have technical skills to know what to do.
    
    Note that USER_INFO was an array of... 1 element. Now it's a hashref.
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |   10 ++---
 C4/Members.pm                                      |   10 -----
 admin/aqbudgets.pl                                 |    4 +-
 admin/aqplan.pl                                    |    6 +--
 catalogue/detail.pl                                |    2 +-
 circ/circulation.pl                                |    2 +-
 circ/returns.pl                                    |    8 ++--
 circ/transferstoreceive.pl                         |    2 +-
 circ/waitingreserves.pl                            |    2 +-
 .../prog/en/includes/cateditor-ui.inc              |   10 ++---
 .../prog/en/modules/cataloguing/addbiblio.tt       |    2 +-
 .../prog/en/modules/cataloguing/addbooks.tt        |    2 +-
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-account.tt |    2 +-
 .../bootstrap/en/modules/opac-downloadshelf.tt     |    2 +-
 .../bootstrap/en/modules/opac-messaging.tt         |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    6 +--
 .../bootstrap/en/modules/opac-shareshelf.tt        |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |    2 +-
 .../bootstrap/en/modules/opac-suggestions.tt       |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |   39 +++++++++-----------
 offline_circ/list.pl                               |    2 +-
 opac/opac-account.pl                               |    8 +---
 opac/opac-ics.pl                                   |    3 --
 opac/opac-messaging.pl                             |    6 +--
 opac/opac-passwd.pl                                |    3 +-
 opac/opac-privacy.pl                               |    3 +-
 opac/opac-user.pl                                  |    6 +--
 28 files changed, 61 insertions(+), 89 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list